From nobody Tue Oct 7 16:38:53 2025 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021122.outbound.protection.outlook.com [40.107.51.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19526279DA7; Tue, 8 Jul 2025 10:26:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.122 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751970417; cv=fail; b=mGZJPVS6kpF/f6Qjo0zaoDChttZLZRzgzY0Rki7NRCZtvg43j2Ydqzci12vCvGN3u7wTwsYPHW8MWJ4gAoqjMSkULWP5nvc5N2y13Ksb5q2AuTIZcONHImkZkn85g0Shrkdua5gRJhPgGSAlsLXeVGQEp3JAHLpJRXrubooGJNc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751970417; c=relaxed/simple; bh=J5lfZjrq5hQ/tdz3/uvIMOXr15DOwCU15XiHWTffHBA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=kId8lOQzCV+PUAeiVisOtBsIPA3G4YDwgX6kTj5GsDZ4ne77SgdtMZ/WUq/gLyQbIQInwU7OILehfWMkUQGtVOqGvDD6o8T8F55VbZXgTkj9Bx/3fEfRnG1szTJfGihEAvAWwhFOlYdBQ3aCn+MVwQfonakaYeGGcmd28Ljz1pk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io; spf=fail smtp.mailfrom=siliconsignals.io; arc=fail smtp.client-ip=40.107.51.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=siliconsignals.io ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zHLOLNUVGnaC3QaS0UZfvHZgbthqGj/Gl6azX0+YbtCotgwoqnU1Wvr0rk2K5d8jANnIMiFzEQQuERxjgf3uesgRsUDjiLdJ9ov6hwDf8P7BkKwIezaAHp+3KBMq3Ot+gvRtVixu2RDKRwAriJVHn9PfOzx+iV6+lpfz3D/krdQ7lmgUqFZUCwCcboEi3CBjpP7ZPf7DWiKZpH37Iw67kg9cNN+YdTnF5ZfELD0pxprFzdgGlwjYtDAV/kyTSCSTfbUVPdjipear1gKXp+wDnBVdSdmAs2QE6TufcDvWoF5LqwsLaiJqpR/cy9QawxUG0vSNHc1ajjXC4Ecw9MLmKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uPmpnoRwchT/vHSWIyLWtG+Yl36Ej93xQcaauZqqBGs=; b=Cy+ld+cyQ9XeUIzV2VhOPn9I5zXdhUifQEXX0JD/2dSaql3Xd9JnuxTG+nryELLaEpYMM+G7/wIHJ+qMarjns1qAxDvmhAvOyJZikzJ/W/jO+Vs9OY5qSE0LDqzO5jKiXTtpoEVFdR7ALoWICqYalEBE34fXKP++5Xh6BTACQQr274drf4ZJ1gpawzl4Hymz1QthUutcseFAP/gfliN9Epd1G2WtMMepf9EbXUQ1AYGsYVtP1BDrZiwL/1IrDvZNItzhNxWfN3WC5d/o6vbvqjqFIp+YBj6CeLP7S8KnerJn86P5ZIAhcVf8VXZU4uz42YsqD7azav2hgBP63t0/aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) by MAYP287MB3738.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:14d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.27; Tue, 8 Jul 2025 10:26:51 +0000 Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418]) by PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418%6]) with mapi id 15.20.8901.024; Tue, 8 Jul 2025 10:26:51 +0000 From: Hardevsinh Palaniya To: sakari.ailus@linux.intel.com, andriy.shevchenko@linux.intel.com, krzk+dt@kernel.org Cc: Himanshu Bhavani , Hardevsinh Palaniya , Mauro Carvalho Chehab , Rob Herring , Conor Dooley , Hans Verkuil , Ricardo Ribalda , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Hans de Goede , Sylvain Petinot , Jingjing Xiong , Benjamin Mugnier , Dongcheng Yan , Heimir Thor Sverrisson , Matthias Fend , Arnd Bergmann , "Bryan O'Donoghue" , You-Sheng Yang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] dt-bindings: media: i2c: Add ov2735 sensor Date: Tue, 8 Jul 2025 15:55:55 +0530 Message-Id: <20250708102604.29261-2-hardevsinh.palaniya@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250708102604.29261-1-hardevsinh.palaniya@siliconsignals.io> References: <20250708102604.29261-1-hardevsinh.palaniya@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BM1P287CA0023.INDP287.PROD.OUTLOOK.COM (2603:1096:b00:40::28) To PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB3519:EE_|MAYP287MB3738:EE_ X-MS-Office365-Filtering-Correlation-Id: d194b650-a2b5-4f66-542f-08ddbe09f3e5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?nGl4I4ij8UwSohw71rfVlXqjMx+wGn9e+zjPu+KVl/kSq/fYAuKs4CrKlaxb?= =?us-ascii?Q?bnij85FGh+FeShAR7xMJad8fHFVq4aiFGIHlzGawr+lbiKgXh5fsfKURyG2c?= =?us-ascii?Q?p7UqX4kKk8JyB/0NxEC9vNo8Q9/xgS9Y06UslYIELcrshpfhp5l5YBmagRvg?= =?us-ascii?Q?PisW37sScpzLv5Oceo9Ezp3rSQ0gtHoRf5EgAn75385KkXg8k3bNKPMCjzGe?= =?us-ascii?Q?prke0OmsgOO5QD0RRGkJkMWmoMgoZ3adml7YhrnCZ3WeIvqUct5UKi8Km1vp?= =?us-ascii?Q?7vhcQrMljN82tFpzGcpyUQqZHPkw3ilZ2gE6RBnX7w8EPu70yE91U+jW45Rp?= =?us-ascii?Q?IerzU0My9XfLx/y46Nug9pT7axj0h/efBnxJmWSz+lgZEAn1rixVgK5tiYPt?= =?us-ascii?Q?4xnaD/+IH3hlUY+xcnm9gM4WHstnUNjDMFjJu1KvT204J/WopbxE5amIxSiA?= =?us-ascii?Q?+XUWneVrarZIOJlRpj50VHE/44cgQ1F4c0onwxLxbonr4PTS3I5vCY2jJWPp?= =?us-ascii?Q?UvSm5WnQryW0F2NMYFHSPnedqOXCJgQaCtT7/n6K1MHajEdZ9f+PtjbHURvh?= =?us-ascii?Q?6PxCDh6nphaYUfHi8/dAxDhy9yPkCm/RADIx8ZMZiBun00yKfMuATwFfqfKg?= =?us-ascii?Q?u9U+1Vet5jSXgDtSGKitpgt2NovhXanbfvWV7UbS/iWTo/yDJIXs9ND5XWeK?= =?us-ascii?Q?NR0tRqZxqVvDHNaM8IC1dV9q7MMwpdx0Kw2YM5LSUnABbnlz3InDA7+O6PdF?= =?us-ascii?Q?Z3i5QrSpctu6uV9ogj2kUK/wyVF0Ug3q08cLIIzaEZwY2ZI1pcmRLAaEhtRf?= =?us-ascii?Q?2CvH7xZm2WfEucTy19r9zdb+dse/DQUMCipjKJFM06jjoujMaoqtl1+vFuuQ?= =?us-ascii?Q?BSRez4GAR82RxmH+UYntyfYZT1gAHDFjyI/IhqwYO+LAVmKzTBIqY8qx3Yzr?= =?us-ascii?Q?B4oCzjjCJJetkZiqxSsNsbRyeXhuld9SSZ9NJuJ79ALmG8l2Zo9OGP7+sdV7?= =?us-ascii?Q?bKa8WZrAxtCVBFbbu5VhxjqVswz8wbdlSWQpsZ1DaBfvUaEXVY2kBoKsV6Qw?= =?us-ascii?Q?6wZ2nBqVzVj/4BnnE7NnrthdPxUGFgF6yAIsvWyK18o359stj0NG+JzigGCO?= =?us-ascii?Q?bow4aXDgXguUJXcp39WtmeZl+p55aYe8HDc1pVFR1vGKS4HT6Y/pvVHlUfW2?= =?us-ascii?Q?QdRLzBb+Mf9GMYH48Dp0kd5/yi+UU9kc20W/15QJFZudrf5BIX1EZTAd4pIN?= =?us-ascii?Q?M3adJEXcGDELny5iXVmVTTXUnR6ACxa8RHx5mw3S9CVPmTKG4UDmgn+Jd1dI?= =?us-ascii?Q?w82AmH1A9qv9SF2n8ZWcheR4SHKMEkUjMUISdCMe1uZACUNy9CIOAMuaxoGX?= =?us-ascii?Q?Vp0QlPTNZl7q3xRBDhU1XPXtCwcb+cuUMDEwUkWVdJg09Uy9mF7RIlz4jthj?= =?us-ascii?Q?kgY4KoXS1Uw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB3519.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ReGCPaB8cqB4uftnoxgVkzkCB+SOaGMocFEFUIy2f2zp0OEA5z8Yaim4IEwR?= =?us-ascii?Q?VDCYq/liE+mVNmXz4OJJHzIutZNtgjAD0DEcxFmicVam3drALC3SAsA6qxwq?= =?us-ascii?Q?dmgHY69htR4nd+i5necnq1qsEimE0mCmGHJsgivujX1i/YVys50bvAi1GJJ4?= =?us-ascii?Q?4+7W/465jmjGUT3ljEl2LzyAC4Ho2sTH1X/WyZ/A3jo1WpBsNrDiTOPJidqq?= =?us-ascii?Q?mQG+Nxm4Ke7V4IMjYymCv88TIeyn7tLbe/G6sfHEenqbkgGrbRvDLnITCvC7?= =?us-ascii?Q?jLPJvCLQjsiTdmGnTJMJlmvqwTqwccUvFkWxR1ZlXUNTy/0Cqv//rhhsp33v?= =?us-ascii?Q?4g7TRGtu9VLNqK54xBfmPvinvS9mkjO4GRpkL+HGZA6ymw7Xx54MGMYnjZnZ?= =?us-ascii?Q?ozVgoTq878fbST8Ari/5fvWU2bUQkWFWF7b2fiFjcX4HgOkaISyafdCbLOhH?= =?us-ascii?Q?Vh3R4saTeeTGnnlfWzQf73Ua/BfWdUNIgdRSNLoe2Ut/3C++GVW87+SWPI6b?= =?us-ascii?Q?4ktZDUA4GGjD1qmRuh0xa1j6ONjK3kgTiI8S++gmT7/IOl+MMvl+W6CYKqex?= =?us-ascii?Q?aUB3Y5T6zs5mHMy+eoV2ia7+7iP9HqDkrdUt+9anJarl6dq3OfG+bYZpA7qT?= =?us-ascii?Q?jXWq5w40O8EuXEQ7IdsHSiBlDuXKzRvU8J2B6qqvq4Yqy01w+hPnY9ibc4I7?= =?us-ascii?Q?OEwB/+8IHTNfoFyybXzGVqxP4V+wuh2iGpncrbL2UYfjd+1evG1wDhZkw2r6?= =?us-ascii?Q?BCDelWB3mQHSlZc/CY2H7AxzN48aocpiL71JHv3XtP6JbB6ogSaOGE7yWeZv?= =?us-ascii?Q?Kf2dQCxiRdx49QFUDtHznV9/wL0ggTwlju8bC1mFskWdachFaWeNlUPBXGUr?= =?us-ascii?Q?c9WqWi0pIsj3dBfg9wqdOc/COPWJ43DPPNm3JlEPdBGSJKQSv4hf1KfV4tN+?= =?us-ascii?Q?B84sd5vnyEjRpBSNQ7mR4dRGWqACM17LxQR7QA50fQJxDR3SUdeKwwWhiKgR?= =?us-ascii?Q?FDuPSXOiU4OhMBxfSb++0/0zDeZrI7rKtJNmefFlMwzKO517T6SRF1KXfD53?= =?us-ascii?Q?K4VRGlW58QfGNxhFATDtLIooqhvGo828Edu1w+bDfzpcMTMxaDVSUDTbyp48?= =?us-ascii?Q?sglp0SICmyXW+Un/xaN3mczrHUt1Xi3Gn034V/f7ADStVxMYFFeAbZkT6DDW?= =?us-ascii?Q?0hGo+dBDAQvc9BybGpoRkZBcGu60jbXxYrJ+3wZ0KzB9o5DRiXenY35fbTCK?= =?us-ascii?Q?/vYamvonVuCuKbBHZTfz1+11/tJyH0yoadYOCyKomY6sJaSTVMgPVCjZHOoI?= =?us-ascii?Q?Kt0zHfmqjEEjj7TQszKeH+sByIyLbTRVyrsUPwnC1n+pGaqo+e5E4Jg7QTsL?= =?us-ascii?Q?B3uxBKBiiLANcwlhUWdXrsw7nRhYu2SfKcOi4f+aljuvbZBofnwRonD/LW7i?= =?us-ascii?Q?tOJR1mOYFSOp2t58Z4B1vFmxahQSO3o8bhVW+XijJsHNGQhGojPv+Z97ZjRR?= =?us-ascii?Q?Zkxfga/C1l3nri27lzYFVxrloWS/PqoNkP4UHIixlWZ9fgkxQkKh+OYZY/u/?= =?us-ascii?Q?tkV+KosSWUt7ywmX+RhVCYcYh+zVXYiRZoA1ZaOWpRa/esJoNHjDe0g98qo1?= =?us-ascii?Q?wJXNZpFRtyW0TFykKqbXN14=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: d194b650-a2b5-4f66-542f-08ddbe09f3e5 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB3519.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2025 10:26:51.3896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZM5lGS2/QITlLmOm/OUtSd+ZqnWC6GFZCEntBNMFCdA/gW+FKzTrHrvb9qQJmwE19Q7jMq6B83DlCrJB/oAZf4+uyaZKoRgz9RMr67fGG4NvedRve1IZ+s/Gh+xJMi5i X-MS-Exchange-Transport-CrossTenantHeadersStamped: MAYP287MB3738 Content-Type: text/plain; charset="utf-8" From: Himanshu Bhavani Add bindings for Omnivision OV2735 sensor. Signed-off-by: Himanshu Bhavani --- .../bindings/media/i2c/ovti,ov2735.yaml | 104 ++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov2735= .yaml diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml b= /Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml new file mode 100644 index 000000000000..a6be7886f4d6 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml @@ -0,0 +1,104 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ovti,ov2735.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OmniVision OV2735 Image Sensor + +maintainers: + - Himanshu Bhavani + +description: | + The OmniVision OV2735 is a 2MP (1920x1080) color CMOS image sensor contr= olled + through an I2C-compatible SCCB bus. it outputs RAW10 format and uses a 1= /2.7" + optical format. + +properties: + compatible: + const: ovti,ov2735 + + reg: + maxItems: 1 + + clocks: + items: + - description: XVCLK clock + + clock-names: + items: + - const: xvclk + + AVDD-supply: + description: Analog Domain Power Supply + + DOVDD-supply: + description: I/O Domain Power Supply + + DVDD-supply: + description: Digital Domain Power Supply + + reset-gpios: + maxItems: 1 + description: Reset Pin GPIO Control (active low) + + pwdn-gpios: + maxItems: 1 + description: Powerdown Pin GPIO Control (active low) + + port: + description: MIPI CSI-2 transmitter port + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + items: + - const: 1 + - const: 2 + + required: + - data-lanes + +required: + - compatible + - reg + - clocks + - port + +additionalProperties: false + +examples: + - | + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + camera-sensor@3c { + compatible =3D "ovti,ov2735"; + reg =3D <0x3c>; + clocks =3D <&ov2735_clk>; + + assigned-clocks =3D <&ov2735_clk>; + assigned-clock-parents =3D <&ov2735_clk_parent>; + assigned-clock-rates =3D <24000000>; + + reset-gpios =3D <&gpio1 6 GPIO_ACTIVE_LOW>; + pwdn-gpios =3D <&gpio2 11 GPIO_ACTIVE_LOW>; + + port { + cam_out: endpoint { + remote-endpoint =3D <&mipi_in_cam>; + data-lanes =3D <1 2>; + }; + }; + }; + }; --=20 2.34.1 From nobody Tue Oct 7 16:38:53 2025 Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazon11020072.outbound.protection.outlook.com [52.101.227.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C276269CE1; Tue, 8 Jul 2025 10:27:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.227.72 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751970434; cv=fail; b=jgPot7pMkujFMG1uUhbwgLOTm/K8wL+mPmRgzu2ejmH/b/RCPLeWpFmYjXgOpzc0PFtipQEK5tOfNi9kPwxhu7MPgYXjMPKO5/kqAHrfTFsPBc68DkQ9bJp5UHEZDAAg4s3rAo4nJ8Pg3JG3cqx2AnajQUn3Z3a0P+fWsCT9KyQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751970434; c=relaxed/simple; bh=W4N2LepcYpsYrS/aqlJPTQB4vVnzwA9clLw4mjWpCH8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=jAPaCkAx9FPlqjLnrwa2uzoDZqBofcbxpY8RHgAOJLv36yRGeFBDZzOwszMA0B5ooepkYoORnVAOc4E2kkI/LNFkHLFu7xuA+JKjbAYVUYm2mHFQV2iLimeFvhIYPPJ8XXB6fRLSSFO39tABNjGa6KSzay4Ue6lcXLd/VEJVZLg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io; spf=fail smtp.mailfrom=siliconsignals.io; arc=fail smtp.client-ip=52.101.227.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=siliconsignals.io ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C60dzrMmVeLxMVgZ5szVprnDI92PLseP5I4/XSmeGbL3chaJoi4KNJFy3ttpZZYQDC2O5bD3/5h6nfZQOCp0sVU4pPWgXqXM5dyNAnehW7XLpZCWHEL5CW5GOgitq8xaYsENzx+rloRZUWC+g1XtgMWbE/GqJJNXAER3gWqRRO47N9Qurdo7B4tFOflR/exIbFFRUzIz/KMRYeHW2ecjderWMpidTZcOeasR/86FGGHX8zmtVHjLcGKWM78qj/Xh7lznKN7HiNFDXCaU7CuLdKDEMXZ+YyLLMR3O56zDm19SibisBwOhPVVvoWjv+ruL61ttl6T5teisrv3iajp95A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HDEapPUC0hkL6LDcIh7p2eSd8ZnNNtKFmwWwYFMj0vQ=; b=JhNOlUNhAFUHr+4SNtKzeRa9StKj3BlERqq/XHrSwmHhxgbrsO5uXq7/XvfQ14xvRNZct97YYnnZgZ57w0y6ac6e0zDAjxajJDre0VWHliEdanIOIBdeBM4/o8WPySPIVaWBwWyJ2HdX9qq48+cki9KeCgnyLJCPQYBC40HDhvN+CIKnDl8mSMHic6bjYy/ZeglbCC9h4H8356MBYGs56NKTbUM5Lf2eEC0d102vmjuiK3vtz9AiWGvg81CjaX3BlR78mZNbtv2t4UMwy7vzG69tuXuWYAEjS2ccdOXyWU5asP2mUdvBC7nJMPS7tK6YT5SMt2mQnoFN+gxRIFejPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) by MAYP287MB3738.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:14d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.27; Tue, 8 Jul 2025 10:27:08 +0000 Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418]) by PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418%6]) with mapi id 15.20.8901.024; Tue, 8 Jul 2025 10:27:08 +0000 From: Hardevsinh Palaniya To: sakari.ailus@linux.intel.com, andriy.shevchenko@linux.intel.com, krzk+dt@kernel.org Cc: Hardevsinh Palaniya , Himanshu Bhavani , Mauro Carvalho Chehab , Rob Herring , Conor Dooley , Hans Verkuil , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Hans de Goede , Ricardo Ribalda , Heimir Thor Sverrisson , Matthias Fend , Benjamin Mugnier , Jingjing Xiong , Sylvain Petinot , Dongcheng Yan , Arnd Bergmann , "Bryan O'Donoghue" , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] media: i2c: add ov2735 image sensor driver Date: Tue, 8 Jul 2025 15:55:56 +0530 Message-Id: <20250708102604.29261-3-hardevsinh.palaniya@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250708102604.29261-1-hardevsinh.palaniya@siliconsignals.io> References: <20250708102604.29261-1-hardevsinh.palaniya@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BM1P287CA0023.INDP287.PROD.OUTLOOK.COM (2603:1096:b00:40::28) To PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB3519:EE_|MAYP287MB3738:EE_ X-MS-Office365-Filtering-Correlation-Id: b71d0c20-7523-4501-e036-08ddbe09fd9e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|1800799024|366016|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?JfPHQJyvhE41ZlgERlueysEP3y0XaSdDSddC8SSrnqAHNsusTYr+kzfIXCgN?= =?us-ascii?Q?GiFgMv00d8VfzPlKd03lh+WkBweI9Cpcxbh3NBToB1TwgYf7HiV7vY34a5EH?= =?us-ascii?Q?fIWfUYb+AUEY38K8lY69F25FGl+JruX7ISXXFtD+ts5hH74t9pqonQESyDki?= =?us-ascii?Q?m0/3feGyj5AWAaIDucuyIiKoXHcIfLJmYMWGKkWtU+sngbPfiRVrMd/e1CM4?= =?us-ascii?Q?M0hGzNg01tkFo7a9lyrWggVOqk+JVjLqtIkQwVOz9f1Xqi+/QmXeEQmO/eiT?= =?us-ascii?Q?aEDLD2FJJLKuf3GDsPuk/ayRtHFKY6AT4pqfEWxkU4oHfo/S/9qdmvEKanVE?= =?us-ascii?Q?rLmd22g16wHFk65V1PtKXuNOIKOEXjKaSDxzG2bTar/fpBd3OxXF7tV9tsws?= =?us-ascii?Q?GuuLJlus7CHXhXu9UhZAw/QlxFiDV4H+tjCWuIHTHJp+OQQGsLiCBhgmYalj?= =?us-ascii?Q?2EvUDKaxirB3OxJ9Nv8f+FSPL4WtN1K16v+oX9lFjn3rQzxuEk7HvmdNqZ2L?= =?us-ascii?Q?M6YHGMcFHTTyHTp9fVNR+cvvP+mqxyThaUZyjJFKIXdFM77PB5GabMMoITj3?= =?us-ascii?Q?+/cpF7Ysd59sWZfnem/SqXtEUsDZK8S/rB+opLfg04aOtsfvNd3Z6GaNFGbT?= =?us-ascii?Q?OeIm/4sgIi9yWhsHeAH880qhRSrcKZ8URFDDgCKwzTHwPsdNZG+bsmo1Oz2o?= =?us-ascii?Q?+jC1IXUoro7J7yh79lsF5sjww0syxO27ZPqSJPtSFAIPi+SCURgRB0eWIbKb?= =?us-ascii?Q?KWnQLnkUBLrS31l0wjVnMcP1mUPgeByoLuT7CDY8v2XEsCrvvGQljAYO+Msh?= =?us-ascii?Q?too0yMpxVtoNj4qFiBo8B4xK1BjO4gigdUZEYA9eADgNHWBHDa73igJbd4a6?= =?us-ascii?Q?kKPpL08/qvmQzZfQ3LgQlaKS5ZsPR3GeBWYRLECJbyv+bOIiKFjxUfYbJ5D9?= =?us-ascii?Q?bf42zArn6Mqpp9WG2ffP3kY76CBJhvQjq4KzhTHQ/sAQCOlFWSdMBOXZ0NUf?= =?us-ascii?Q?Qx8fNq3F9HGEC/f/b56AuTQeNDhSY8gbFWk0/Pu8sFyJeA/qS6d2JWKI01ho?= =?us-ascii?Q?Xiccz7rlL2KZNkD0OlzXnY4BG2f+bInL1I31osRI31vxbXV0H5JYrrk17vqS?= =?us-ascii?Q?40aPLRRaEd6iXw3ifL1E0lMAcwflC2luYxtc6Bod0jX1txfFaVFajHWyTr76?= =?us-ascii?Q?vrPxIZG6hYevvuJGflUsWXtTqaJroSDjTxlrSs4VAac/MQiEuoprGiJKxUuf?= =?us-ascii?Q?vOfP+GJOkmSBpxJk/FqJ4DMiaISb6Ue4Cos+DVCGv7Xjbu7cOBXFs4z8D5/7?= =?us-ascii?Q?W4I1PxP3nFlfeS4cDhkj2omQFUHM2v6GIxeQKOUdzyhuhBDc31APOlhkx/1X?= =?us-ascii?Q?/JdDXdA1vW1ixE7IMo3ppZKkwXQYaH6XfI4gBumbGZyLWmTSkEyeCVrlrq9B?= =?us-ascii?Q?cFfSJZa8Zm8BZzj3z1eYwcbh5uoO3lUV9JuLDfoOul41N4GZ90mCaQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB3519.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(1800799024)(366016)(7053199007)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5sTcVxrvj8WOotVkkdl5v5mSLBhA22b4u9iPXcRHDxjeUM4eXSUiGLn6ApO8?= =?us-ascii?Q?cGi6I1bzTRfTb+sX+14Zo2/r4waks1uiT+KTgBW7mlLBoDzag2NAwZykqQDR?= =?us-ascii?Q?6TDRgREHXH2y0fcWkplaLif7vVcT8jgOX9G3eb+4bZthCcQlTJo2ILzEwWb7?= =?us-ascii?Q?+weJTbBUZdv6QAvSuP9wAZ3r0IjYSWP5JnWZ3/u3VnSJ6Scs/7xeVQ7HbVQA?= =?us-ascii?Q?UqbDUrelGu9XZVUwJo2YHmBfNU5+FY0dscHDXBDEUJkBLFqfaZis+F3keNG6?= =?us-ascii?Q?UYHwtnYxnfFiUk1YaronO6GHegtI5V3K6Oy68pH/saInW08RpGFoe6U8zixH?= =?us-ascii?Q?QaKDYzeegy3WnlNcC982snawqRW4HtH/GW4POWznuSY0M+W614Bctxu1mI+h?= =?us-ascii?Q?k6p2muDoUDKLgeHk//Hxi1/9+4IiO/l36h+tW617Zsg+3b94+EASzmqGbBEw?= =?us-ascii?Q?l0SCLEy4Gtqwdxe3vNvt9LJr5aU0ohmu4zEdOV/EGf8PzkNfgQ95xVbShxHF?= =?us-ascii?Q?Ol+88G0OoJJNFOzSltUyrsfDOybrMn67S3sBujUlD+GlQJmAeMVV8TBsuB5E?= =?us-ascii?Q?VazMXBkqZDM+CDn0TCJbJqfeZ8KQm2F2gNP5pWEdwJPuiUGPJbfwqK3viL7/?= =?us-ascii?Q?ekP/y1oiHfRQLjmb2EZU7bJx5lzoOY5Q9CdhbhtWE+Rzw8Ly1aeRCQyiBQjS?= =?us-ascii?Q?aBAAYiK3rTJfCUbkMwPmlfxE0DslE1obvVsmLQgG1otioo/GAewaugoV7X8V?= =?us-ascii?Q?NWoayKN4QF9thqidSX8YPnyneLjsZ2qMkEyHDXSl1RMuUPMDBHM0kAB2OuTo?= =?us-ascii?Q?yVYXHpt0hO77kHqnYNL5adMZbI6a8J5GwCtN4SSIulnV4yxjCY0rByvrGAtV?= =?us-ascii?Q?odNV/gzd6DQyY7CEdMxz5ocqeKxwhkcsbPQsZ/5Z3+NsVFEgcsRycF28qAKk?= =?us-ascii?Q?EoSi3W/y/DC1TYUbzagRIxLuzYdV0ZA1t5L12caC+Op01XSDUtvGqY3nUcmH?= =?us-ascii?Q?I0nEr7NEnz00kddljylrueZJ4VXWupj7+NnPodxUghdA/B82oTh5kaj2oYfe?= =?us-ascii?Q?cUYUCiK/S64vnDMaakT+uf8O37mcKS/MyyCVlrW95u78oS5H1W0DJaBw1m3a?= =?us-ascii?Q?ZqEzKQ3K+UcwA0r9xchx/WZZZNxe7JZDWp2iYKNkTC18EcWkctZcWIQs0XWs?= =?us-ascii?Q?pPXgwBRnEj+3fUf3sE7M0Ze1snH5YJrP6eiuXndzqjzQoblSVveyd4T8GHPE?= =?us-ascii?Q?tRrE9/0POTqyzhBtU+XRt/2PSJnIuQSMylwenDTqOlCJ6rB2y0mCFWaYFvR4?= =?us-ascii?Q?wUPcY4V3tK8SkfHZg+kFMORFbeA1mbx//B/pIGVbXb393VxJ2vp2vCQMi3jL?= =?us-ascii?Q?I8zGajYGcGHot2LcNBo0SxMplqSU5RHbt0celesBsjENn/KuBw3EJiOogrFj?= =?us-ascii?Q?4ATQDUnMxXJiKracMu/3zM2itxs+Cq38LHtU4TMoq4ojW0icr36+UHhgZHel?= =?us-ascii?Q?O1komPqg9k/4gCPBHOnHhmK/ngVDVnA8w35AIsVsUDw8Vd8GXYdAGmFgqZvO?= =?us-ascii?Q?IV+cFM3A+Bfw6y2v+jJLDUxWCCohULAZR7WQ67fyf3XAO90kLDB73OMVyn08?= =?us-ascii?Q?PxwCrZIQ80D2vPDRpCeGhHI=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: b71d0c20-7523-4501-e036-08ddbe09fd9e X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB3519.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2025 10:27:07.9942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z69Djs7hMpsrCUOv3pmQ6WUfz0DWLlXh4xyi3z8Ryu/ZVR41kaI8rBkrNMh+ClqZtVH3Il6n2jewBTDijlXL+9NqLW0fXOP9KLQjDiPT/tNOwbHskjtoJwFb2fpSTDsY X-MS-Exchange-Transport-CrossTenantHeadersStamped: MAYP287MB3738 Content-Type: text/plain; charset="utf-8" Add a v4l2 subdevice driver for the Omnivision OV2735 sensor. The Omnivision OV2735 is a 1/2.7-Inch CMOS image sensor with an active array size of 1920 x 1080. The following features are supported: - Manual exposure an gain control support - vblank/hblank control support - Test pattern support control - Supported resolution: 1920 x 1080 @ 30fps (SGRBG10) Co-developed-by: Himanshu Bhavani Signed-off-by: Himanshu Bhavani Signed-off-by: Hardevsinh Palaniya --- MAINTAINERS | 9 + drivers/media/i2c/Kconfig | 10 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov2735.c | 908 +++++++++++++++++++++++++++++++++++++ 4 files changed, 928 insertions(+) create mode 100644 drivers/media/i2c/ov2735.c diff --git a/MAINTAINERS b/MAINTAINERS index 92e9d8c7708f..058bbfd9523b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18471,6 +18471,15 @@ T: git git://linuxtv.org/media.git F: Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml F: drivers/media/i2c/ov2685.c =20 +OMNIVISION OV2735 SENSOR DRIVER +M: Hardevsinh Palaniya +M: Himanshu Bhavani +L: linux-media@vger.kernel.org +S: Maintained +T: git git://linuxtv.org/media.git +F: Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml +F: drivers/media/i2c/ov2735.c + OMNIVISION OV2740 SENSOR DRIVER M: Tianshu Qiu R: Sakari Ailus diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 4b4c199da6ea..9646eab1b177 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -446,6 +446,16 @@ config VIDEO_OV2685 To compile this driver as a module, choose M here: the module will be called ov2685. =20 +config VIDEO_OV2735 + tristate "OmniVision OV2735 sensor support" + select V4L2_CCI_I2C + help + This is a Video4Linux2 sensor driver for the Sony + OV2735 camera. + + To compile this driver as a module, choose M here: the + module will be called ov2735. + config VIDEO_OV2740 tristate "OmniVision OV2740 sensor support" depends on ACPI || COMPILE_TEST diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile index 5873d29433ee..1adb27743fa1 100644 --- a/drivers/media/i2c/Makefile +++ b/drivers/media/i2c/Makefile @@ -93,6 +93,7 @@ obj-$(CONFIG_VIDEO_OV2640) +=3D ov2640.o obj-$(CONFIG_VIDEO_OV2659) +=3D ov2659.o obj-$(CONFIG_VIDEO_OV2680) +=3D ov2680.o obj-$(CONFIG_VIDEO_OV2685) +=3D ov2685.o +obj-$(CONFIG_VIDEO_OV2735) +=3D ov2735.o obj-$(CONFIG_VIDEO_OV2740) +=3D ov2740.o obj-$(CONFIG_VIDEO_OV4689) +=3D ov4689.o obj-$(CONFIG_VIDEO_OV5640) +=3D ov5640.o diff --git a/drivers/media/i2c/ov2735.c b/drivers/media/i2c/ov2735.c new file mode 100644 index 000000000000..a7df516eaedc --- /dev/null +++ b/drivers/media/i2c/ov2735.c @@ -0,0 +1,908 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * V4L2 Support for the OV2735 + * + * Copyright (C) 2025 Silicon Signals Pvt. Ltd. + * + * Based on Rockchip ov2735 Camera Driver + * Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd. + * + * Inspired from ov8858, imx219, imx283 camera drivers + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#define OV2735_XCLK_FREQ (24 * HZ_PER_MHZ) + +#define OV2735_REG_PAGE_SELECT CCI_REG8(0xfd) + +/* Page 0 */ +#define OV2735_REG_CHIPID CCI_REG16(0x02) +#define OV2735_CHIPID 0x2735 + +#define OV2735_REG_SOFT_REST CCI_REG8(0x20) + +/* Clock Settings */ +#define OV2735_REG_PLL_CTRL CCI_REG8(0x2f) +#define OV2735_REG_PLL_OUTDIV CCI_REG8(0x34) +#define OV2735_REG_CLK_MODE CCI_REG8(0x30) +#define OV2735_REG_CLOCK_REG1 CCI_REG8(0x33) +#define OV2735_REG_CLOCK_REG2 CCI_REG8(0x35) + +/* Page 1 */ +#define OV2735_REG_STREAM_CTRL CCI_REG8(0xa0) +#define OV2735_STREAM_ON 0x01 +#define OV2735_STREAM_OFF 0x00 + +#define OV2735_REG_UPDOWN_MIRROR CCI_REG8(0x3f) +#define OV2735_REG_BINNING_DAC_CODE_MODE CCI_REG8(0x30) +#define OV2735_REG_FRAME_LENGTH CCI_REG16(0x0e) +#define OV2735_VTS_MAX 0x0fff +#define OV2735_REG_FRAME_EXP_SEPERATE_EN CCI_REG8(0x0d) +#define OV2735_FRAME_EXP_SEPERATE_EN 0x10 +#define OV2735_REG_FRAME_SYNC CCI_REG8(0x01) + +#define OV2735_REG_HBLANK CCI_REG16(0x09) + +#define OV2735_REG_HS_MIPI CCI_REG8(0xb1) +#define OV2735_REG_MIPI_CTRL1 CCI_REG8(0x92) +#define OV2735_REG_MIPI_CTRL2 CCI_REG8(0x94) +#define OV2735_REG_MIPI_CTRL3 CCI_REG8(0xa1) +#define OV2735_REG_MIPI_CTRL4 CCI_REG8(0xb2) +#define OV2735_REG_MIPI_CTRL5 CCI_REG8(0xb3) +#define OV2735_REG_MIPI_CTRL6 CCI_REG8(0xb4) +#define OV2735_REG_MIPI_CTRL7 CCI_REG8(0xb5) +#define OV2735_REG_PREPARE CCI_REG8(0x95) +#define OV2735_REG_R_HS_ZERO CCI_REG8(0x96) +#define OV2735_REG_TRAIL CCI_REG8(0x98) +#define OV2735_REG_R_CLK_ZERO CCI_REG8(0x9c) +#define OV2735_REG_MIPI_V_SIZE CCI_REG16(0x8e) +#define OV2735_REG_MIPI_H_SIZE CCI_REG16(0x90) + +#define OV2735_REG_ANALOG_CTRL3 CCI_REG8(0x25) +#define OV2735_REG_VNCP CCI_REG8(0x20) + +/* BLC registers */ +#define OV2735_REG_BLC_GAIN_BLUE CCI_REG8(0x86) +#define OV2735_REG_BLC_GAIN_RED CCI_REG8(0x87) +#define OV2735_REG_BLC_GAIN_GR CCI_REG8(0x88) +#define OV2735_REG_BLC_GAIN_GB CCI_REG8(0x89) +#define OV2735_REG_GB_SUBOFFSET CCI_REG8(0xf0) +#define OV2735_REG_BLUE_SUBOFFSET CCI_REG8(0xf1) +#define OV2735_REG_RED_SUBOFFSET CCI_REG8(0xf2) +#define OV2735_REG_GR_SUBOFFSET CCI_REG8(0xf3) +#define OV2735_REG_BLC_BPC_TH_P CCI_REG8(0xfc) +#define OV2735_REG_BLC_BPC_TH_N CCI_REG8(0xfe) + +#define OV2735_REG_TEST_PATTERN CCI_REG8(0xb2) +#define OV2735_TEST_PATTERN_ENABLE 0x01 +#define OV2735_TEST_PATTERN_DISABLE 0xfe + +#define OV2735_REG_LONG_EXPOSURE CCI_REG16(0x03) +#define OV2735_EXPOSURE_MIN 4 +#define OV2735_EXPOSURE_STEP 1 + +#define OV2735_REG_ANALOG_GAIN CCI_REG8(0x24) +#define OV2735_ANALOG_GAIN_MIN 0x10 +#define OV2735_ANALOG_GAIN_MAX 0xff +#define OV2735_ANALOG_GAIN_STEP 1 +#define OV2735_ANALOG_GAIN_DEFAULT 0x10 + +/* Page 2 */ +#define OV2735_REG_V_START CCI_REG16(0xa0) +#define OV2735_REG_V_SIZE CCI_REG16(0xa2) +#define OV2735_REG_H_START CCI_REG16(0xa4) +#define OV2735_REG_H_SIZE CCI_REG16(0xa6) + +#define OV2735_LINK_FREQ_420MHZ (420 * HZ_PER_MHZ) +#define OV2735_PIXEL_RATE (168 * HZ_PER_MHZ) + +static const char * const ov2735_supply_name[] =3D { + "AVDD", /* Analog power */ + "DOVDD", /* Digital I/O power */ + "DVDD", /* Digital core power */ +}; + +struct ov2735 { + struct device *dev; + struct regmap *cci; + struct v4l2_subdev sd; + struct media_pad pad; + struct i2c_client *client; + struct clk *xclk; + struct gpio_desc *reset_gpio; + struct gpio_desc *pwdn_gpio; + struct regulator_bulk_data supplies[ARRAY_SIZE(ov2735_supply_name)]; + + /* V4L2 Controls */ + struct v4l2_ctrl_handler handler; + struct v4l2_ctrl *link_freq; + struct v4l2_ctrl *pixel_rate; + struct v4l2_ctrl *hblank; + struct v4l2_ctrl *vblank; + struct v4l2_ctrl *gain; + struct v4l2_ctrl *exposure; + struct v4l2_ctrl *test_pattern; +}; + +struct ov2735_reglist { + unsigned int num_regs; + const struct cci_reg_sequence *regvals; +}; + +struct ov2735_mode { + u32 width; + u32 height; + u32 hts_def; + u32 vts_def; + u32 exp_def; + struct ov2735_reglist reg_list; +}; + +static struct cci_reg_sequence ov2735_1920_1080_30fps[] =3D { + { OV2735_REG_PAGE_SELECT, 0x00 }, + { OV2735_REG_PLL_CTRL, 0x10 }, + { OV2735_REG_PLL_OUTDIV, 0x00 }, + { OV2735_REG_CLK_MODE, 0x15 }, + { OV2735_REG_CLOCK_REG1, 0x01 }, + { OV2735_REG_CLOCK_REG2, 0x20 }, + { OV2735_REG_PAGE_SELECT, 0x01 }, + { OV2735_REG_BINNING_DAC_CODE_MODE, 0x00 }, + { CCI_REG8(0xfb), 0x73 }, + { OV2735_REG_FRAME_SYNC, 0x01 }, + { OV2735_REG_PAGE_SELECT, 0x01 }, + + /* Timing ctrl */ + { CCI_REG8(0x1a), 0x6b }, + { CCI_REG8(0x1c), 0xea }, + { CCI_REG8(0x16), 0x0c }, + { CCI_REG8(0x21), 0x00 }, + { CCI_REG8(0x11), 0x63 }, + { CCI_REG8(0x19), 0xc3 }, + + /* Analog ctrl */ + { CCI_REG8(0x26), 0x5a }, + { CCI_REG8(0x29), 0x01 }, + { CCI_REG8(0x33), 0x6f }, + { CCI_REG8(0x2a), 0xd2 }, + { CCI_REG8(0x2c), 0x40 }, + { CCI_REG8(0xd0), 0x02 }, + { CCI_REG8(0xd1), 0x01 }, + { CCI_REG8(0xd2), 0x20 }, + { CCI_REG8(0xd3), 0x04 }, + { CCI_REG8(0xd4), 0x2a }, + { CCI_REG8(0x50), 0x00 }, + { CCI_REG8(0x51), 0x2c }, + { CCI_REG8(0x52), 0x29 }, + { CCI_REG8(0x53), 0x00 }, + { CCI_REG8(0x55), 0x44 }, + { CCI_REG8(0x58), 0x29 }, + { CCI_REG8(0x5a), 0x00 }, + { CCI_REG8(0x5b), 0x00 }, + { CCI_REG8(0x5d), 0x00 }, + { CCI_REG8(0x64), 0x2f }, + { CCI_REG8(0x66), 0x62 }, + { CCI_REG8(0x68), 0x5b }, + { CCI_REG8(0x75), 0x46 }, + { CCI_REG8(0x76), 0x36 }, + { CCI_REG8(0x77), 0x4f }, + { CCI_REG8(0x78), 0xef }, + { CCI_REG8(0x72), 0xcf }, + { CCI_REG8(0x73), 0x36 }, + { CCI_REG8(0x7d), 0x0d }, + { CCI_REG8(0x7e), 0x0d }, + { CCI_REG8(0x8a), 0x77 }, + { CCI_REG8(0x8b), 0x77 }, + + { OV2735_REG_PAGE_SELECT, 0x01 }, + { OV2735_REG_HS_MIPI, 0x83 }, + { OV2735_REG_MIPI_CTRL5, 0x0b }, + { OV2735_REG_MIPI_CTRL6, 0x14 }, + { CCI_REG8(0x9d), 0x40 }, + { OV2735_REG_MIPI_CTRL3, 0x05 }, + { OV2735_REG_MIPI_CTRL2, 0x44 }, + { OV2735_REG_PREPARE, 0x33 }, + { OV2735_REG_R_HS_ZERO, 0x1f }, + { OV2735_REG_TRAIL, 0x45 }, + { OV2735_REG_R_CLK_ZERO, 0x10 }, + { OV2735_REG_MIPI_CTRL7, 0x70 }, + { OV2735_REG_ANALOG_CTRL3, 0xe0 }, + { OV2735_REG_VNCP, 0x7b }, + + /* BLC */ + { OV2735_REG_PAGE_SELECT, 0x01 }, + { OV2735_REG_BLC_GAIN_BLUE, 0x77 }, + { OV2735_REG_BLC_GAIN_GB, 0x77 }, + { OV2735_REG_BLC_GAIN_RED, 0x74 }, + { OV2735_REG_BLC_GAIN_GR, 0x74 }, + { OV2735_REG_BLC_BPC_TH_P, 0xe0 }, + { OV2735_REG_BLC_BPC_TH_N, 0xe0 }, + { OV2735_REG_GB_SUBOFFSET, 0x40 }, + { OV2735_REG_BLUE_SUBOFFSET, 0x40 }, + { OV2735_REG_RED_SUBOFFSET, 0x40 }, + { OV2735_REG_GR_SUBOFFSET, 0x40 }, + + /* 1920x1080 */ + { OV2735_REG_PAGE_SELECT, 0x02 }, + { OV2735_REG_V_START, 0x0008 }, + { OV2735_REG_V_SIZE, 0x0438 }, + { OV2735_REG_H_START, 0x0008 }, + { OV2735_REG_H_SIZE, 0x03c0 }, + { OV2735_REG_PAGE_SELECT, 0x01 }, + { OV2735_REG_MIPI_V_SIZE, 0x0780 }, + { OV2735_REG_MIPI_H_SIZE, 0x0438 }, +}; + +static const struct ov2735_mode supported_modes[] =3D { + { + .width =3D 1920, + .height =3D 1080, + .exp_def =3D 399, + .hts_def =3D 2200, + .vts_def =3D 2545, + .reg_list =3D { + .num_regs =3D ARRAY_SIZE(ov2735_1920_1080_30fps), + .regvals =3D ov2735_1920_1080_30fps, + }, + }, +}; + +static const s64 link_freq_menu_items[] =3D { + OV2735_LINK_FREQ_420MHZ, +}; + +static const char * const ov2735_test_pattern_menu[] =3D { + "Disabled", + "Vertical Color", +}; + +static const u32 ov2735_mbus_codes[] =3D { + MEDIA_BUS_FMT_SGRBG10_1X10, +}; + +static inline struct ov2735 *to_ov2735(struct v4l2_subdev *_sd) +{ + return container_of(_sd, struct ov2735, sd); +} + +static int ov2735_enable_test_pattern(struct ov2735 *ov2735, u32 pattern) +{ + int ret =3D 0; + u64 val; + + cci_read(ov2735->cci, OV2735_REG_TEST_PATTERN, &val, &ret); + if (ret) + return ret; + + switch (pattern) { + case 0: + val &=3D ~OV2735_TEST_PATTERN_ENABLE; + break; + case 1: + val |=3D OV2735_TEST_PATTERN_ENABLE; + break; + } + + return cci_write(ov2735->cci, OV2735_REG_TEST_PATTERN, val, NULL); +} + +static int ov2735_set_ctrl(struct v4l2_ctrl *ctrl) +{ + struct ov2735 *ov2735 =3D container_of(ctrl->handler, struct ov2735, + handler); + const struct ov2735_mode *mode; + struct v4l2_mbus_framefmt *fmt; + struct v4l2_subdev_state *state; + u64 vts; + int ret =3D 0; + + state =3D v4l2_subdev_get_locked_active_state(&ov2735->sd); + fmt =3D v4l2_subdev_state_get_format(state, 0); + + mode =3D v4l2_find_nearest_size(supported_modes, + ARRAY_SIZE(supported_modes), + width, height, + fmt->width, fmt->height); + + if (ctrl->id =3D=3D V4L2_CID_VBLANK) { + /* Honour the VBLANK limits when setting exposure. */ + s64 max =3D mode->height + ctrl->val - 4; + + ret =3D __v4l2_ctrl_modify_range(ov2735->exposure, + ov2735->exposure->minimum, max, + ov2735->exposure->step, + ov2735->exposure->default_value); + if (ret) + return ret; + } + + /* + * Applying V4L2 control value only happens + * when power is up for streaming. + */ + if (pm_runtime_get_if_in_use(ov2735->dev) =3D=3D 0) + return 0; + + cci_write(ov2735->cci, OV2735_REG_PAGE_SELECT, 0x01, &ret); + + switch (ctrl->id) { + case V4L2_CID_EXPOSURE: + cci_write(ov2735->cci, OV2735_REG_LONG_EXPOSURE, ctrl->val, &ret); + break; + case V4L2_CID_ANALOGUE_GAIN: + cci_write(ov2735->cci, OV2735_REG_ANALOG_GAIN, ctrl->val, &ret); + break; + case V4L2_CID_HBLANK: + cci_write(ov2735->cci, OV2735_REG_HBLANK, ctrl->val, &ret); + break; + case V4L2_CID_VBLANK: + vts =3D ctrl->val + mode->height; + cci_write(ov2735->cci, OV2735_REG_FRAME_EXP_SEPERATE_EN, + OV2735_FRAME_EXP_SEPERATE_EN, &ret); + cci_write(ov2735->cci, OV2735_REG_FRAME_LENGTH, vts, &ret); + break; + case V4L2_CID_TEST_PATTERN: + ret =3D ov2735_enable_test_pattern(ov2735, ctrl->val); + break; + default: + dev_err(ov2735->dev, "ctrl(id:0x%x, val:0x%x) is not handled\n", + ctrl->id, ctrl->val); + break; + } + cci_write(ov2735->cci, OV2735_REG_FRAME_SYNC, 0x01, &ret); + + pm_runtime_put(ov2735->dev); + + return ret; +} + +static const struct v4l2_ctrl_ops ov2735_ctrl_ops =3D { + .s_ctrl =3D ov2735_set_ctrl, +}; + +static int ov2735_init_controls(struct ov2735 *ov2735) +{ + struct v4l2_ctrl_handler *ctrl_hdlr; + struct v4l2_fwnode_device_properties props; + const struct ov2735_mode *mode =3D &supported_modes[0]; + u64 hblank_def, vblank_def, exp_max; + int ret; + + ctrl_hdlr =3D &ov2735->handler; + ret =3D v4l2_ctrl_handler_init(ctrl_hdlr, 7); + if (ret) + return ret; + + ov2735->pixel_rate =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_PIXEL_RATE, 0, OV2735_PIXEL_RATE, + 1, OV2735_PIXEL_RATE); + + ov2735->link_freq =3D v4l2_ctrl_new_int_menu(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_LINK_FREQ, + 0, 0, link_freq_menu_items); + if (ov2735->link_freq) + ov2735->link_freq->flags |=3D V4L2_CTRL_FLAG_READ_ONLY; + + hblank_def =3D mode->hts_def - mode->width; + ov2735->hblank =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, V4L2_CI= D_HBLANK, + hblank_def, hblank_def, 1, hblank_def); + + vblank_def =3D mode->vts_def - mode->height; + ov2735->vblank =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_VBLANK, vblank_def, + OV2735_VTS_MAX - mode->height, + 1, vblank_def); + + exp_max =3D mode->vts_def - 4; + ov2735->exposure =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_EXPOSURE, OV2735_EXPOSURE_MIN, + exp_max, OV2735_EXPOSURE_STEP, mode->exp_def); + + ov2735->gain =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_ANALOGUE_GAIN, OV2735_ANALOG_GAIN_MIN, + OV2735_ANALOG_GAIN_MAX, OV2735_ANALOG_GAIN_STEP, + OV2735_ANALOG_GAIN_DEFAULT); + + ov2735->test_pattern =3D v4l2_ctrl_new_std_menu_items(ctrl_hdlr, + &ov2735_ctrl_ops, V4L2_CID_TEST_PATTERN, + ARRAY_SIZE(ov2735_test_pattern_menu) - 1, + 0, 0, ov2735_test_pattern_menu); + if (ctrl_hdlr->error) { + ret =3D ctrl_hdlr->error; + dev_err(ov2735->dev, "control init failed (%d)\n", ret); + goto err_handler_free; + } + + ret =3D v4l2_fwnode_device_parse(ov2735->dev, &props); + if (ret) + goto err_handler_free; + + ret =3D v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &ov2735_ctrl_ops, + &props); + if (ret) + goto err_handler_free; + + ov2735->sd.ctrl_handler =3D ctrl_hdlr; + + return 0; + +err_handler_free: + v4l2_ctrl_handler_free(ctrl_hdlr); + + return ret; +} + +static int ov2735_enable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) +{ + struct ov2735 *ov2735 =3D to_ov2735(sd); + const struct ov2735_mode *mode; + const struct ov2735_reglist *reg_list; + const struct v4l2_mbus_framefmt *fmt; + int ret; + + fmt =3D v4l2_subdev_state_get_format(state, 0); + mode =3D v4l2_find_nearest_size(supported_modes, + ARRAY_SIZE(supported_modes), + width, height, + fmt->width, fmt->height); + + ret =3D pm_runtime_resume_and_get(ov2735->dev); + if (ret < 0) + return ret; + + reg_list =3D &mode->reg_list; + cci_multi_reg_write(ov2735->cci, reg_list->regvals, reg_list->num_regs, &= ret); + if (ret) { + dev_err(ov2735->dev, "%s failed to send mfg header\n", __func__); + goto err_rpm_put; + } + + /* Apply customized values from user */ + ret =3D __v4l2_ctrl_handler_setup(ov2735->sd.ctrl_handler); + if (ret) + goto err_rpm_put; + + /* set stream on register */ + cci_write(ov2735->cci, OV2735_REG_PAGE_SELECT, 0x01, &ret); + cci_write(ov2735->cci, OV2735_REG_STREAM_CTRL, OV2735_STREAM_ON, &ret); + if (ret) + goto err_rpm_put; + + return 0; + +err_rpm_put: + pm_runtime_put(ov2735->dev); + return ret; +} + +static int ov2735_disable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) +{ + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret =3D 0; + + /* set stream off register */ + cci_write(ov2735->cci, OV2735_REG_PAGE_SELECT, 0x01, &ret); + cci_write(ov2735->cci, OV2735_REG_STREAM_CTRL, OV2735_STREAM_OFF, &ret); + if (ret) + dev_err(ov2735->dev, "%s failed to set stream\n", __func__); + + pm_runtime_put(ov2735->dev); + + return ret; +} + +static int ov2735_enum_mbus_code(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_mbus_code_enum *code) +{ + if (code->index >=3D ARRAY_SIZE(ov2735_mbus_codes)) + return -EINVAL; + + code->code =3D ov2735_mbus_codes[code->index]; + + return 0; +} + +static int ov2735_enum_frame_size(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_frame_size_enum *fse) +{ + u32 code; + + if (fse->index >=3D ARRAY_SIZE(supported_modes)) + return -EINVAL; + + code =3D MEDIA_BUS_FMT_SGRBG10_1X10; + if (fse->code !=3D code) + return -EINVAL; + + fse->min_width =3D supported_modes[fse->index].width; + fse->max_width =3D fse->min_width; + fse->min_height =3D supported_modes[fse->index].height; + fse->max_height =3D fse->min_height; + + return 0; +} + +static void ov2735_set_framing_limits(struct ov2735 *ov2735, + const struct ov2735_mode *mode) +{ + u32 hblank, vblank_def; + + hblank =3D mode->hts_def - mode->width; + __v4l2_ctrl_modify_range(ov2735->hblank, hblank, hblank, 1, hblank); + + vblank_def =3D mode->vts_def - mode->height; + __v4l2_ctrl_modify_range(ov2735->vblank, vblank_def, OV2735_VTS_MAX - mod= e->height, + 1, vblank_def); +} + +static int ov2735_set_pad_format(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_format *fmt) +{ + struct v4l2_mbus_framefmt *format; + const struct ov2735_mode *mode; + struct ov2735 *ov2735 =3D to_ov2735(sd); + + format =3D v4l2_subdev_state_get_format(sd_state, 0); + + mode =3D v4l2_find_nearest_size(supported_modes, + ARRAY_SIZE(supported_modes), + width, height, + fmt->format.width, fmt->format.height); + + fmt->format.width =3D mode->width; + fmt->format.height =3D mode->height; + fmt->format.field =3D V4L2_FIELD_NONE; + fmt->format.colorspace =3D V4L2_COLORSPACE_RAW; + fmt->format.quantization =3D V4L2_QUANTIZATION_FULL_RANGE; + fmt->format.xfer_func =3D V4L2_XFER_FUNC_NONE; + + format =3D v4l2_subdev_state_get_format(sd_state, 0); + + if (fmt->which =3D=3D V4L2_SUBDEV_FORMAT_ACTIVE) + ov2735_set_framing_limits(ov2735, mode); + + *format =3D fmt->format; + + return 0; +} + +static int ov2735_init_state(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state) +{ + struct v4l2_subdev_format fmt =3D { + .which =3D V4L2_SUBDEV_FORMAT_TRY, + .pad =3D 0, + .format =3D { + .code =3D MEDIA_BUS_FMT_SGRBG10_1X10, + .width =3D supported_modes[0].width, + .height =3D supported_modes[0].height, + }, + }; + + ov2735_set_pad_format(sd, state, &fmt); + + return 0; +} + +static const struct v4l2_subdev_video_ops ov2735_video_ops =3D { + .s_stream =3D v4l2_subdev_s_stream_helper, +}; + +static const struct v4l2_subdev_pad_ops ov2735_pad_ops =3D { + .enum_mbus_code =3D ov2735_enum_mbus_code, + .get_fmt =3D v4l2_subdev_get_fmt, + .set_fmt =3D ov2735_set_pad_format, + .enum_frame_size =3D ov2735_enum_frame_size, + .enable_streams =3D ov2735_enable_streams, + .disable_streams =3D ov2735_disable_streams, +}; + +static const struct v4l2_subdev_ops ov2735_subdev_ops =3D { + .video =3D &ov2735_video_ops, + .pad =3D &ov2735_pad_ops, +}; + +static const struct v4l2_subdev_internal_ops ov2735_internal_ops =3D { + .init_state =3D ov2735_init_state, +}; + +static int ov2735_power_on(struct device *dev) +{ + struct v4l2_subdev *sd =3D dev_get_drvdata(dev); + struct ov2735 *ov2735 =3D to_ov2735(sd); + unsigned long delay_us; + int ret; + + gpiod_set_value_cansleep(ov2735->pwdn_gpio, 0); + fsleep(3000); + + ret =3D regulator_bulk_enable(ARRAY_SIZE(ov2735_supply_name), + ov2735->supplies); + if (ret) { + dev_err(ov2735->dev, "failed to enable regulators\n"); + return ret; + } + + gpiod_set_value_cansleep(ov2735->pwdn_gpio, 1); + fsleep(3000); + + gpiod_set_value_cansleep(ov2735->reset_gpio, 0); + fsleep(3000); + + ret =3D clk_prepare_enable(ov2735->xclk); + if (ret) { + dev_err(ov2735->dev, "failed to enable clock\n"); + goto err_regulator_off; + } + + /* 8192 cycles prior to first SCCB transaction */ + delay_us =3D DIV_ROUND_UP(8192, OV2735_XCLK_FREQ / 1000 / 1000); + fsleep(delay_us); + + return 0; + +err_regulator_off: + regulator_bulk_disable(ARRAY_SIZE(ov2735_supply_name), ov2735->supplies); + return ret; +} + +static int ov2735_power_off(struct device *dev) +{ + struct v4l2_subdev *sd =3D dev_get_drvdata(dev); + struct ov2735 *ov2735 =3D to_ov2735(sd); + + gpiod_set_value_cansleep(ov2735->pwdn_gpio, 1); + clk_disable_unprepare(ov2735->xclk); + gpiod_set_value_cansleep(ov2735->reset_gpio, 0); + regulator_bulk_disable(ARRAY_SIZE(ov2735_supply_name), ov2735->supplies); + + return 0; +} + +static int ov2735_get_regulators(struct ov2735 *ov2735) +{ + unsigned int i; + + for (i =3D 0; i < ARRAY_SIZE(ov2735_supply_name); i++) + ov2735->supplies[i].supply =3D ov2735_supply_name[i]; + + return devm_regulator_bulk_get(ov2735->dev, + ARRAY_SIZE(ov2735_supply_name), + ov2735->supplies); +} + +static int ov2735_identify_module(struct ov2735 *ov2735) +{ + u64 chip_id; + int ret =3D 0; + + cci_write(ov2735->cci, OV2735_REG_PAGE_SELECT, 0x00, &ret); + cci_read(ov2735->cci, OV2735_REG_CHIPID, &chip_id, &ret); + if (ret) + return dev_err_probe(ov2735->dev, ret, "failed to read chip id %x\n", + OV2735_CHIPID); + + if (chip_id !=3D OV2735_CHIPID) + return dev_err_probe(ov2735->dev, -EIO, "chip id mismatch: %x!=3D%llx\n", + OV2735_CHIPID, chip_id); + + return 0; +} + +static int ov2735_parse_endpoint(struct ov2735 *ov2735) +{ + struct fwnode_handle *fwnode; + struct v4l2_fwnode_endpoint bus_cfg =3D { + .bus_type =3D V4L2_MBUS_CSI2_DPHY, + }; + struct fwnode_handle *ep; + int ret; + + fwnode =3D dev_fwnode(ov2735->dev); + ep =3D fwnode_graph_get_next_endpoint(fwnode, NULL); + if (!ep) { + dev_err(ov2735->dev, "Failed to get next endpoint\n"); + return -ENXIO; + } + + ret =3D v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg); + fwnode_handle_put(ep); + if (ret) + return ret; + + if (bus_cfg.bus.mipi_csi2.num_data_lanes !=3D 2) { + dev_err_probe(ov2735->dev, -EINVAL, "only 2 data lanes are supported\n"); + goto error_out; + } + + return 0; + +error_out: + v4l2_fwnode_endpoint_free(&bus_cfg); + + return ret; +}; + +static int ov2735_probe(struct i2c_client *client) +{ + struct ov2735 *ov2735; + unsigned int xclk_freq; + int ret; + + ov2735 =3D devm_kzalloc(&client->dev, sizeof(*ov2735), GFP_KERNEL); + if (!ov2735) + return -ENOMEM; + + ov2735->client =3D client; + ov2735->dev =3D &client->dev; + + v4l2_i2c_subdev_init(&ov2735->sd, client, &ov2735_subdev_ops); + ov2735->sd.internal_ops =3D &ov2735_internal_ops; + + ov2735->cci =3D devm_cci_regmap_init_i2c(client, 8); + if (IS_ERR(ov2735->cci)) { + ret =3D PTR_ERR(ov2735->cci); + return dev_err_probe(ov2735->dev, ret, "failed to initialize CCI\n"); + } + + /* Get system clock (xvclk) */ + ov2735->xclk =3D devm_v4l2_sensor_clk_get(ov2735->dev, NULL); + if (IS_ERR(ov2735->xclk)) { + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->xclk), + "failed to get xclk\n"); + } + + xclk_freq =3D clk_get_rate(ov2735->xclk); + if (xclk_freq !=3D OV2735_XCLK_FREQ) + return dev_err_probe(ov2735->dev, -EINVAL, + "xclk frequency not supported: %d Hz\n", + xclk_freq); + + ret =3D ov2735_get_regulators(ov2735); + if (ret) + return dev_err_probe(ov2735->dev, ret, "failed to get regulators\n"); + + ret =3D ov2735_parse_endpoint(ov2735); + if (ret) { + dev_err(ov2735->dev, "failed to parse endpoint configuration\n"); + return ret; + } + + ov2735->reset_gpio =3D devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_LO= W); + if (IS_ERR(ov2735->reset_gpio)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->reset_gpio), + "failed to get reset GPIO\n"); + + ov2735->pwdn_gpio =3D devm_gpiod_get(&client->dev, "pwdn", GPIOD_OUT_LOW); + if (IS_ERR(ov2735->pwdn_gpio)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->pwdn_gpio), + "failed to get reset GPIO\n"); + + ret =3D ov2735_power_on(ov2735->dev); + if (ret) + return ret; + + ret =3D ov2735_identify_module(ov2735); + if (ret) + goto error_power_off; + + /* This needs the pm runtime to be registered. */ + ret =3D ov2735_init_controls(ov2735); + if (ret) + goto error_power_off; + + /* Initialize subdev */ + ov2735->sd.flags |=3D V4L2_SUBDEV_FL_HAS_DEVNODE; + ov2735->sd.entity.function =3D MEDIA_ENT_F_CAM_SENSOR; + ov2735->pad.flags =3D MEDIA_PAD_FL_SOURCE; + + ret =3D media_entity_pads_init(&ov2735->sd.entity, 1, &ov2735->pad); + if (ret) { + dev_err_probe(ov2735->dev, ret, "failed to init entity pads\n"); + goto error_handler_free; + } + + ov2735->sd.state_lock =3D ov2735->handler.lock; + ret =3D v4l2_subdev_init_finalize(&ov2735->sd); + if (ret < 0) { + dev_err_probe(ov2735->dev, ret, "subdev init error\n"); + goto error_media_entity; + } + + pm_runtime_set_active(ov2735->dev); + pm_runtime_enable(ov2735->dev); + + ret =3D v4l2_async_register_subdev_sensor(&ov2735->sd); + if (ret < 0) { + dev_err_probe(ov2735->dev, ret, + "failed to register ov2735 sub-device\n"); + goto error_subdev_cleanup; + } + + pm_runtime_idle(ov2735->dev); + + return 0; + +error_subdev_cleanup: + v4l2_subdev_cleanup(&ov2735->sd); + pm_runtime_disable(ov2735->dev); + pm_runtime_set_suspended(ov2735->dev); + +error_media_entity: + media_entity_cleanup(&ov2735->sd.entity); + +error_handler_free: + v4l2_ctrl_handler_free(ov2735->sd.ctrl_handler); + +error_power_off: + ov2735_power_off(ov2735->dev); + + return ret; +} + +static void ov2735_remove(struct i2c_client *client) +{ + struct v4l2_subdev *sd =3D i2c_get_clientdata(client); + struct ov2735 *ov2735 =3D to_ov2735(sd); + + v4l2_async_unregister_subdev(sd); + v4l2_subdev_cleanup(&ov2735->sd); + media_entity_cleanup(&sd->entity); + v4l2_ctrl_handler_free(ov2735->sd.ctrl_handler); + + pm_runtime_disable(ov2735->dev); + if (!pm_runtime_status_suspended(ov2735->dev)) + ov2735_power_off(ov2735->dev); + pm_runtime_set_suspended(ov2735->dev); +} + +static DEFINE_RUNTIME_DEV_PM_OPS(ov2735_pm_ops, + ov2735_power_off, ov2735_power_on, NULL); + +static const struct of_device_id ov2735_id[] =3D { + { .compatible =3D "ovti,ov2735" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, ov2735_id); + +static struct i2c_driver ov2735_driver =3D { + .driver =3D { + .name =3D "ov2735", + .pm =3D pm_ptr(&ov2735_pm_ops), + .of_match_table =3D ov2735_id, + }, + .probe =3D ov2735_probe, + .remove =3D ov2735_remove, +}; +module_i2c_driver(ov2735_driver); + +MODULE_DESCRIPTION("OV2735 Camera Sensor Driver"); +MODULE_AUTHOR("Hardevsinh Palaniya = "); +MODULE_AUTHOR("Himanshu Bhavani "); +MODULE_LICENSE("GPL"); --=20 2.34.1