From nobody Tue Oct 7 17:42:24 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46C432BEC3E; Tue, 8 Jul 2025 08:57:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751965053; cv=none; b=FPLuzwaTSe03f/Ctm0/mXfQ9oQSWYuOwvRamIeoSmBbuAhp6sl9ale6RrrS6opcj5HwwCn/674VryMoqZgzQ08bdox1t4LQ97gC0u3s9cfFCh8haEoR+wmrinA+mFCBwbCzYDywX0Nubl1AbxVfYqeupNnvSxV3a5gglltyjtbc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751965053; c=relaxed/simple; bh=ArnlYJ2oQj3tI9v/yYa8u3NPCosxGc2PHAGvQ5Ft23I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=grIyDFQh4KQAvzUiIJ7aXpxTJZpjZxjV5NloIi3v/ZoVjUicqoJjvewd32eUS6Or0d/ymm6QDMbzf2gN6oDZ1kmUINaqzhgjEbN1EIYw0CEM+vuHqMAZUB9A4XWexH8MCtCfQbrwM724nKIO6ZNq6qGmTt/zWP2klxeALRYfIIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rvh8iKxF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rvh8iKxF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFD10C4CEED; Tue, 8 Jul 2025 08:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751965052; bh=ArnlYJ2oQj3tI9v/yYa8u3NPCosxGc2PHAGvQ5Ft23I=; h=From:To:Cc:Subject:Date:From; b=rvh8iKxF3DnqpYx5xx7WUAdDdmTftIqfB8+mn4y5D1x7xpIVv9/KB+M/mHH3IDiVn 7/bi9LaIzkpv3NrZKieayo5CMfqXj7jnTA6Y+LnLXTGHleQf4NE7pexoEjqpaNSsqP 3fAJ//M9QbrElXOx8FVL3I+a40pAotRZZHR7OtVjE0v8VtMcZ0pWwQBtvqY7UtDcxK lppicE78Ro6xzenJEHO4oi7HGYVizZ3/MDnx0IYVmPcF2XAbp5Q6xnTOq4KP10eENp uOqdYaPBHhuijCtqaXpAkSja3m9MmDycgdJJ7YIbf002Hvam8nmNRA/ZoWLQTJ8ttA ub2NG6/dq6qpA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1uZ48j-0000000049T-0BDy; Tue, 08 Jul 2025 10:57:25 +0200 From: Johan Hovold To: Bjorn Andersson Cc: Konrad Dybcio , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Bjorn Andersson Subject: [PATCH] soc: qcom: pmic_glink: fix OF node leak Date: Tue, 8 Jul 2025 10:57:17 +0200 Message-ID: <20250708085717.15922-1-johan@kernel.org> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the OF node reference taken when registering the auxiliary devices when the devices are later released. Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driv= er") Cc: Bjorn Andersson Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- drivers/soc/qcom/pmic_glink.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c index 0a6d325b195c..c0a4be5df926 100644 --- a/drivers/soc/qcom/pmic_glink.c +++ b/drivers/soc/qcom/pmic_glink.c @@ -167,7 +167,10 @@ static int pmic_glink_rpmsg_callback(struct rpmsg_devi= ce *rpdev, void *data, return 0; } =20 -static void pmic_glink_aux_release(struct device *dev) {} +static void pmic_glink_aux_release(struct device *dev) +{ + of_node_put(dev->of_node); +} =20 static int pmic_glink_add_aux_device(struct pmic_glink *pg, struct auxiliary_device *aux, @@ -181,8 +184,10 @@ static int pmic_glink_add_aux_device(struct pmic_glink= *pg, aux->dev.release =3D pmic_glink_aux_release; device_set_of_node_from_dev(&aux->dev, parent); ret =3D auxiliary_device_init(aux); - if (ret) + if (ret) { + of_node_put(aux->dev.of_node); return ret; + } =20 ret =3D auxiliary_device_add(aux); if (ret) --=20 2.49.0