From nobody Tue Oct 7 18:26:06 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAF522E06FD for ; Tue, 8 Jul 2025 15:00:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751986820; cv=none; b=X7gxZxJeVC0GQJiPwkNDnoMVleIKcGg8eMpQOOXxYlxFToojyV40R9W0esVtd+EiS9DJtC6iovkKC4j+hO9z1M+29YHOJ6JvvQ9GNjB3zgjzgrnkhYzWHUcLyZT19kCpZB/+AthOKXmWqsQCc8laZupv1VFXMNqYYSJHGSU/meg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751986820; c=relaxed/simple; bh=TcNVKg1uWK5gvw7ouEDNUpzejUpmhf7qeqTdsGGsOR0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f8ecC/GPRru6NFWP2HMH+NsB9lCODs817zd1gJZ9JW6t1zYuj8Jfbj9iJxtC6N3cJnLLp3pIfv1XAZEoVOotMksa1k9hl5ADk3PLlaT6Sc2dtu5L7MsFM7i0W0syu9oyK35jF2p7YNYjkh/bBmP7ya89ncK95BGtGyYWqg6k8Zc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thegoodpenguin.co.uk; spf=pass smtp.mailfrom=thegoodpenguin.co.uk; dkim=pass (2048-bit key) header.d=thegoodpenguin-co-uk.20230601.gappssmtp.com header.i=@thegoodpenguin-co-uk.20230601.gappssmtp.com header.b=Hu+h6bqE; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thegoodpenguin.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thegoodpenguin.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thegoodpenguin-co-uk.20230601.gappssmtp.com header.i=@thegoodpenguin-co-uk.20230601.gappssmtp.com header.b="Hu+h6bqE" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4538bc1cffdso38659625e9.0 for ; Tue, 08 Jul 2025 08:00:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thegoodpenguin-co-uk.20230601.gappssmtp.com; s=20230601; t=1751986817; x=1752591617; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V+bfOYiAAZEmOkKJUcdq4zkMimVeCuvfF0enwIJA4MM=; b=Hu+h6bqEWHW3YFlrzhRQTB/DmqRXLza20UHRSwyU1oi7oqqINXvsOKZQKxvDxFoms5 FCCfVszmonkumcb19FpvJa0SSnWXGPjKlmNHX3WNZDs6iW23v/sWbnqdYBBHq8LrG7HL FUZ02YjzzxWmdVunnWGWDU07rLsMhaiBwAX/QLbNPIXQ8XO1HJTiVdMb5Pk+ckbhxuaO 8pkPlgaw+A88j7NRTGbWbQiFwXZPJh4XbbpKUqqcyZIbT5jd03meTbMa1RicBOUMVI30 SVfUs5+qZyrTJlNlA2D6HScqJNV6afWGUTBAD1lU6RiG9XZD5Q1yfBCNQd0CR7fyzXlt 922g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751986817; x=1752591617; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V+bfOYiAAZEmOkKJUcdq4zkMimVeCuvfF0enwIJA4MM=; b=eCvCwNswkVJYyK+D8m9pAPU8LSIbj/sJGTp9iyIJ1HkPzzXJXOmNgyn7Kje4g+OE0w mHaO0fl9m6c4Q0ijF/Xsjv/41Nf4cE+Pok4P0nJ/8Cmd9FkdA4yJRrA349mXMaAFiL/L srriSAvoqN8yy9tDoH3/gKSM0wQJlEZDRsh0O7LhMpXmIozEoZV14UIAU8dED3HWeRIP YAEdZO/4N2ff0F9bkQ6457hzaDd2auOY98Kq3/qgOOM0nfvT1m+oAX8Nj8ril+9VICin mS/7fAQ2lBIDYGl5S+HFnEWBj8P4W0pIH5KPCQSJyCccYIQ8n2yQndMLs3Djjnbfb906 t3Ag== X-Forwarded-Encrypted: i=1; AJvYcCXhrzMm87mHiTgqcMbn6ciMlyfxzl2AZLD1H71447NeHnPK8NurrsVBP60vzPsLUOOnACzJzPncHC9ABrk=@vger.kernel.org X-Gm-Message-State: AOJu0YxrCBeT1ha/P6gGSenqAI5H2Wp8ULlY0k0qLYXZNEN/ARBFGj46 jdyS7U8hOQv4linN9c4KqF+SaBhgAAAKPt7Jwbfh34dT9oP6scwULTw1XKh/sLCJahY= X-Gm-Gg: ASbGnculvdjosxPgIWKRVTP9g4zlxes1ZAWfzE5IhMyv1jZ5VWQbsY46IZQmrx13PDZ TiKKlXo74evV/Py7sa/uQrNh6ZDgZur1Fwfj0OGowx1sUcv9Lz5zigqiiHA+aQIZ60xOe62U28M dh/mbDiS0CAt+aWwWLhiUNjabH8S4DyVTzJw9zc1mfWZphJZub9YIB/q3tBwxtWtC9mGVHAtcas XHidMht9b2YMNy3AElFKLkIdhZcL/k10LGPBtlC2BvOrGHF1cyuZDuQKZQKkWPFfDIugfZfmDDh LgfL+IPV+nd7zSWubogA3OS0/5VbFtrvZYHlfSahYlETt/Tss0xfcushjN0E0u12XmozengYoIx DVaw= X-Google-Smtp-Source: AGHT+IEI+a6mSfBqIeYw8GeeQrtXv67hwYKl3tgQqC9zKHmZfV3vVZnOkmbHKxPCRBOiFxCrGo5Zmg== X-Received: by 2002:a05:600c:3f1a:b0:453:81a:2f3f with SMTP id 5b1f17b1804b1-454b4ec2132mr180590745e9.30.1751986816769; Tue, 08 Jul 2025 08:00:16 -0700 (PDT) Received: from [127.0.1.1] ([2a00:23c7:1d1a:9c01:f9da:8274:e1d1:97ce]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030b4f6sm13517433f8f.10.2025.07.08.08.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 08:00:16 -0700 (PDT) From: Pawel Zalewski Date: Tue, 08 Jul 2025 15:59:45 +0100 Subject: [PATCH v3 1/3] leds/leds-is31fl32xx: add support for is31fl3236a Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250708-leds-is31fl3236a-v3-1-d68979b042dd@thegoodpenguin.co.uk> References: <20250708-leds-is31fl3236a-v3-0-d68979b042dd@thegoodpenguin.co.uk> In-Reply-To: <20250708-leds-is31fl3236a-v3-0-d68979b042dd@thegoodpenguin.co.uk> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek , devicetree@vger.kernel.org, Pawel Zalewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1751986814; l=4945; i=pzalewski@thegoodpenguin.co.uk; s=20250625; h=from:subject:message-id; bh=TcNVKg1uWK5gvw7ouEDNUpzejUpmhf7qeqTdsGGsOR0=; b=dOiTmPFnkgkqhSdkpVMyWBhm7R30MnKMKWOWtMYFID40JbkNkWpubXkjPrzaHpRN/GtcL+Seb ZZRzNTwLDiuCQ6ugi2DJx3tuZv9fEXJDxX0iZcfnUjgOuuFwisvqzhJ X-Developer-Key: i=pzalewski@thegoodpenguin.co.uk; a=ed25519; pk=hHrwBom/yjrVTqpEvKpVXLYfxr6nqBNP16RkQopIRrI= Add an additional and optional control register for setting the output PWM frequency to 22kHz. The default is 3kHz and this option puts the operational frequency outside of the audible range. Signed-off-by: Pawel Zalewski --- drivers/leds/leds-is31fl32xx.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index 8793330dd4142f49f15d6ee9d87468c08509859f..c8e27c219177e8e7a17738fbd3b= ba84340d9776f 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -32,6 +32,8 @@ #define IS31FL3216_CONFIG_SSD_ENABLE BIT(7) #define IS31FL3216_CONFIG_SSD_DISABLE 0 =20 +#define IS31FL32XX_PWM_FREQUENCY_22kHz 0x01 + struct is31fl32xx_priv; struct is31fl32xx_led_data { struct led_classdev cdev; @@ -53,6 +55,7 @@ struct is31fl32xx_priv { * @pwm_update_reg : address of PWM Update register * @global_control_reg : address of Global Control register (optional) * @reset_reg : address of Reset register (optional) + * @output_frequency_setting_reg: address of output frequency register (op= tional) * @pwm_register_base : address of first PWM register * @pwm_registers_reversed: : true if PWM registers count down instead of = up * @led_control_register_base : address of first LED control register (opt= ional) @@ -76,6 +79,7 @@ struct is31fl32xx_chipdef { u8 pwm_update_reg; u8 global_control_reg; u8 reset_reg; + u8 output_frequency_setting_reg; u8 pwm_register_base; bool pwm_registers_reversed; u8 led_control_register_base; @@ -90,6 +94,19 @@ static const struct is31fl32xx_chipdef is31fl3236_cdef = =3D { .pwm_update_reg =3D 0x25, .global_control_reg =3D 0x4a, .reset_reg =3D 0x4f, + .output_frequency_setting_reg =3D IS31FL32XX_REG_NONE, + .pwm_register_base =3D 0x01, + .led_control_register_base =3D 0x26, + .enable_bits_per_led_control_register =3D 1, +}; + +static const struct is31fl32xx_chipdef is31fl3236a_cdef =3D { + .channels =3D 36, + .shutdown_reg =3D 0x00, + .pwm_update_reg =3D 0x25, + .global_control_reg =3D 0x4a, + .reset_reg =3D 0x4f, + .output_frequency_setting_reg =3D 0x4b, .pwm_register_base =3D 0x01, .led_control_register_base =3D 0x26, .enable_bits_per_led_control_register =3D 1, @@ -101,6 +118,7 @@ static const struct is31fl32xx_chipdef is31fl3235_cdef = =3D { .pwm_update_reg =3D 0x25, .global_control_reg =3D 0x4a, .reset_reg =3D 0x4f, + .output_frequency_setting_reg =3D IS31FL32XX_REG_NONE, .pwm_register_base =3D 0x05, .led_control_register_base =3D 0x2a, .enable_bits_per_led_control_register =3D 1, @@ -112,6 +130,7 @@ static const struct is31fl32xx_chipdef is31fl3218_cdef = =3D { .pwm_update_reg =3D 0x16, .global_control_reg =3D IS31FL32XX_REG_NONE, .reset_reg =3D 0x17, + .output_frequency_setting_reg =3D IS31FL32XX_REG_NONE, .pwm_register_base =3D 0x01, .led_control_register_base =3D 0x13, .enable_bits_per_led_control_register =3D 6, @@ -126,6 +145,7 @@ static const struct is31fl32xx_chipdef is31fl3216_cdef = =3D { .pwm_update_reg =3D 0xB0, .global_control_reg =3D IS31FL32XX_REG_NONE, .reset_reg =3D IS31FL32XX_REG_NONE, + .output_frequency_setting_reg =3D IS31FL32XX_REG_NONE, .pwm_register_base =3D 0x10, .pwm_registers_reversed =3D true, .led_control_register_base =3D 0x01, @@ -363,8 +383,21 @@ static struct is31fl32xx_led_data *is31fl32xx_find_led= _data( static int is31fl32xx_parse_dt(struct device *dev, struct is31fl32xx_priv *priv) { + const struct is31fl32xx_chipdef *cdef =3D priv->cdef; int ret =3D 0; =20 + if ((cdef->output_frequency_setting_reg !=3D IS31FL32XX_REG_NONE) && + of_property_read_bool(dev_of_node(dev), "issi,22kHz-pwm")) { + + ret =3D is31fl32xx_write(priv, cdef->output_frequency_setting_reg, + IS31FL32XX_PWM_FREQUENCY_22kHz); + + if (ret) { + dev_err(dev, "Failed to write output PWM frequency register\n"); + return ret; + } + } + for_each_available_child_of_node_scoped(dev_of_node(dev), child) { struct led_init_data init_data =3D {}; struct is31fl32xx_led_data *led_data =3D @@ -405,6 +438,7 @@ static int is31fl32xx_parse_dt(struct device *dev, =20 static const struct of_device_id of_is31fl32xx_match[] =3D { { .compatible =3D "issi,is31fl3236", .data =3D &is31fl3236_cdef, }, + { .compatible =3D "issi,is31fl3236a", .data =3D &is31fl3236a_cdef, }, { .compatible =3D "issi,is31fl3235", .data =3D &is31fl3235_cdef, }, { .compatible =3D "issi,is31fl3218", .data =3D &is31fl3218_cdef, }, { .compatible =3D "si-en,sn3218", .data =3D &is31fl3218_cdef, }, @@ -466,6 +500,7 @@ static void is31fl32xx_remove(struct i2c_client *client) */ static const struct i2c_device_id is31fl32xx_id[] =3D { { "is31fl3236" }, + { "is31fl3236a" }, { "is31fl3235" }, { "is31fl3218" }, { "sn3218" }, --=20 2.48.1