From nobody Tue Oct 7 21:36:27 2025 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAA9228A1D3 for ; Mon, 7 Jul 2025 07:57:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751875053; cv=none; b=PpEQpiABBz/ecumxc01G4wEF2bIQrti+0RHLdMhAoPtUJhlJn6x8JCxNGEL6H7npQPVdjDpmirX+JtxbykD+ik3S8sachb7Lo3MvnTwaJ2e40WOWNzHnKF8bUWQUvEAe7OWeyjRBFojc1kIj9g6i5IC5vM0kfHw1pOdC6Xp7ISY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751875053; c=relaxed/simple; bh=ShU8yklGcE2Nn5vs6gIvPaLoQyjIaXH2iJ09CEBsak8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SDnzJ+61+xaurEk1Dqg7i3g0APtlSwIq1kIkVPCGOiXJKKmav9XcLPGRDD11HSxdpVlAWJ13pePlgkwbd8rlx/che/7pdczIQXgQ7ZqPWPaoAfysZr2f8yLdE0ARWO9RkRG0k+2Z2iwtveHcYzcKCjZJhvwCnDYdlwj62PVSYAc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brighamcampbell.com; spf=pass smtp.mailfrom=brighamcampbell.com; dkim=pass (2048-bit key) header.d=brighamcampbell.com header.i=@brighamcampbell.com header.b=MXOBNNIi; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brighamcampbell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=brighamcampbell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=brighamcampbell.com header.i=@brighamcampbell.com header.b="MXOBNNIi" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-747c2cc3419so2228511b3a.2 for ; Mon, 07 Jul 2025 00:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brighamcampbell.com; s=google; t=1751875051; x=1752479851; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PoWchHvEvGdP5Z/q0UzERLxYZuvcNkSip61qcq1I2gk=; b=MXOBNNIiGX3tcEZR3ljDT/YHyMsWetdTtixqq0kB+WncRBQXJEmZxMW6uBfzx7C7n6 S8cHEiNKqdfgog89Z8PLPqo+rCQ2aZTBdGA911dBO8UbQc7Quc2ncyx/aPZ99NEMCNK/ Ci2R6o+aSQoh3uFGRIc/6cmA40jX3EOF1pmjMstq+jl2WKoTxC8+XeREPp3WQ5XFnEiH ymSszx5IFur1y31nJPPX1So8BM+4L5yMjzgVBxyVYU0pXilu+Mubh46wCvO3tDMSxk9R mq0j8o3lmaEYmWWmb2b+MFM98BATqlR3JgBZ/B4q7nS997Ilzl0Ij2aFg+1MBmrgly6S pvWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751875051; x=1752479851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PoWchHvEvGdP5Z/q0UzERLxYZuvcNkSip61qcq1I2gk=; b=YzGaqWfKbpcTgiUNlFQZBXHAnV0MD8CntF4kOs66kaV7+eqwCKAXzi0DYihGwfNNC/ zGOrZcSIOCH0jddilgRRxt3jQJZZs8wGu8KOHLXefOYfxB6+yW+JAih7Ucd0ajXpZg8K /Ru00LbcVhKUQX082Yrm4XICEHIu7u08nwd2w/UySLDu7eR0upskwuQaVpwHhC0uj2Iq 6KUstNJXbp/xXWoLs9ghk/n4wAMgbPl7tz+gQRDvn8yNq2+E7L/oinKMUj8cFVbdanjD R6wI5MB5lPAdRnlfjkY2p3fWaSsMwcBkqCJCgdYJm/BW5UbhYv1YhX80CVLC0FdaiknU JXvg== X-Forwarded-Encrypted: i=1; AJvYcCVLAT2mfVfO+N0+2Yohy5WCnGRqAZAoWDSOex8RNd/Bhc7Y4F2Bmp3kYiywz3GzrQGtziwvy57a708Qukg=@vger.kernel.org X-Gm-Message-State: AOJu0YwSMHSvz9iFI88eTVago2jv2RA1bLmAM4L9L5P/u2dYneo8UXwk CWXp14TA3stF/zB8CwJy6FgvBPE0qFm1T0d4MGCKDyPKF4Hkef365yTPYm+qbCnD/yc= X-Gm-Gg: ASbGncsSDfW0LzTuaGUhltPXfkIJVU6YwVxbGbM74NRWxwbGYd60pRKekP/jp4Ml17w rrRmkIMko6a/lN5gB0T1DrEW7nDTo/WwU/MIvvIznWF80glFwo2AMfivK2f3i5t2FbX2+zRVIPV 4wJl+Ui2kJViwE1AN3cNQzmUiFfLYi8LbogzXXkC0y3z9SE+tWIndQU7YmubxCvwkPgZcbGBh+d P0JKjZXjlD69H1CUIBTbDqWLQp1Cou2Ddpw0K2PjpjM59kePV3iFlYjKdpK3YOsnNT0aVmnLejF dqghictUC3gwPH1T5x0EXkkAqxHeLA5hpPdRi/vJge+YWsZLEd5YO7qpOl0xmO0ezVY136eBGVr 0TvXJSOedjtd/SqtL7g== X-Google-Smtp-Source: AGHT+IEItjQ5pli2AJ0rBOKHmZ7rfFk3/t/CL1j/RMQ2Bp4Fe+1XZFqzMaA4o2gCpzZkugK6AWVtuQ== X-Received: by 2002:a05:6a00:2195:b0:748:33f3:8da3 with SMTP id d2e1a72fcca58-74cf6fd0ad9mr11173295b3a.19.1751875051077; Mon, 07 Jul 2025 00:57:31 -0700 (PDT) Received: from mystery-machine.brighamcampbell.com ([64.71.154.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b38ee62f8bdsm8246476a12.57.2025.07.07.00.57.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 00:57:30 -0700 (PDT) From: Brigham Campbell To: dianders@chromium.org, tejasvipin76@gmail.com, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Brigham Campbell Subject: [PATCH 2/3] drm: Remove unused MIPI write seq and chatty functions Date: Mon, 7 Jul 2025 01:56:57 -0600 Message-ID: <20250707075659.75810-3-me@brighamcampbell.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250707075659.75810-1-me@brighamcampbell.com> References: <20250707075659.75810-1-me@brighamcampbell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the deprecated mipi_dsi_generic_write_seq() macro and mipi_dsi_generic_write_chatty() function now that they are no longer used. Signed-off-by: Brigham Campbell --- drivers/gpu/drm/drm_mipi_dsi.c | 34 +++------------------------------- include/drm/drm_mipi_dsi.h | 23 ----------------------- 2 files changed, 3 insertions(+), 54 deletions(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index a00d76443128..3b8ff24980b4 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -772,41 +772,13 @@ ssize_t mipi_dsi_generic_write(struct mipi_dsi_device= *dsi, const void *payload, EXPORT_SYMBOL(mipi_dsi_generic_write); =20 /** - * mipi_dsi_generic_write_chatty() - mipi_dsi_generic_write() w/ an error = log - * @dsi: DSI peripheral device - * @payload: buffer containing the payload - * @size: size of payload buffer - * - * Like mipi_dsi_generic_write() but includes a dev_err() - * call for you and returns 0 upon success, not the number of bytes sent. - * - * Return: 0 on success or a negative error code on failure. - */ -int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi, - const void *payload, size_t size) -{ - struct device *dev =3D &dsi->dev; - ssize_t ret; - - ret =3D mipi_dsi_generic_write(dsi, payload, size); - if (ret < 0) { - dev_err(dev, "sending generic data %*ph failed: %zd\n", - (int)size, payload, ret); - return ret; - } - - return 0; -} -EXPORT_SYMBOL(mipi_dsi_generic_write_chatty); - -/** - * mipi_dsi_generic_write_multi() - mipi_dsi_generic_write_chatty() w/ acc= um_err + * mipi_dsi_generic_write_multi() - mipi_dsi_generic_write() w/ accum_err * @ctx: Context for multiple DSI transactions * @payload: buffer containing the payload * @size: size of payload buffer * - * Like mipi_dsi_generic_write_chatty() but deals with errors in a way that - * makes it convenient to make several calls in a row. + * A wrapper around mipi_dsi_generic_write() that deals with errors in a w= ay + * that makes it convenient to make several calls in a row. */ void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx, const void *payload, size_t size) diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 369b0d8830c3..f9cc106c8eb6 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -285,8 +285,6 @@ void mipi_dsi_picture_parameter_set_multi(struct mipi_d= si_multi_context *ctx, =20 ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *pa= yload, size_t size); -int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi, - const void *payload, size_t size); void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx, const void *payload, size_t size); ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *par= ams, @@ -379,27 +377,6 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_= dsi_multi_context *ctx, u16 scanline); void mipi_dsi_dcs_set_tear_off_multi(struct mipi_dsi_multi_context *ctx); =20 -/** - * mipi_dsi_generic_write_seq - transmit data using a generic write packet - * - * This macro will print errors for you and will RETURN FROM THE CALLING - * FUNCTION (yes this is non-intuitive) upon error. - * - * Because of the non-intuitive return behavior, THIS MACRO IS DEPRECATED. - * Please replace calls of it with mipi_dsi_generic_write_seq_multi(). - * - * @dsi: DSI peripheral device - * @seq: buffer containing the payload - */ -#define mipi_dsi_generic_write_seq(dsi, seq...) = \ - do { \ - static const u8 d[] =3D { seq }; \ - int ret; \ - ret =3D mipi_dsi_generic_write_chatty(dsi, d, ARRAY_SIZE(d)); \ - if (ret < 0) \ - return ret; \ - } while (0) - /** * mipi_dsi_generic_write_seq_multi - transmit data using a generic write = packet * --=20 2.49.0