From nobody Tue Oct 7 19:59:40 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 201B328A72A for ; Mon, 7 Jul 2025 07:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751875049; cv=none; b=p8jy+wh62qDjrtBUF8ZH2KJytoc5FF60bvQLNdchwTdfOXMvcFF+BJ6FBmShM3hBkVYpsN2J+zJjMBK+08VyTege1NJStjna05X+jVUAaKSNrGIunCFvVYnexXqaql/jq3eropkryqjNsmCG0rWJ2gDdtXHWNIEQobxagfsjyqk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751875049; c=relaxed/simple; bh=P8HQ9uJ3XyqukKDyIYQMPHz+6q2ZpiD7QwsLElWeJkQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C0wiqmY6eYWYPQ90SpWbzwYE298ZHxsa05l6dd0SdLUrTmnamWsE51WpXgAPEDWkkUpU1HDuTZq0s3zGn3OCRIdR7gP1OhCOm5dtCdLpbT87ImrDj4XJCxY61bYG+Fp+g/+OADqR2dwQOwInvthTYdVAsT9sLtJGZ/byLrQatiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brighamcampbell.com; spf=pass smtp.mailfrom=brighamcampbell.com; dkim=pass (2048-bit key) header.d=brighamcampbell.com header.i=@brighamcampbell.com header.b=CYU0OuXS; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brighamcampbell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=brighamcampbell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=brighamcampbell.com header.i=@brighamcampbell.com header.b="CYU0OuXS" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-23c8f179e1bso21173685ad.1 for ; Mon, 07 Jul 2025 00:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brighamcampbell.com; s=google; t=1751875047; x=1752479847; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gizo1Y9JZrUMSmoAMbm1FYjU79aRDOXQASrbUODDlcY=; b=CYU0OuXS7sZTck4Vw69mzo5jZxgSuCTp51tA9iVnbwG3Yldh7hZNJBbibb2y7w6Bwe OBm/b1S/fVLAMdu3qbJzZT/HjhKvVnUZiVpO+imUcYBRWOA8IXUPsusiV4WF9Fx5KeZg AC6XiX9kj9MUrszurds/RwEraCqYxUEXxuR6sTmocdpEOV9z9CXT+jS/PSjt/WuSRP35 A4xae0c6OvCjoY/mBe73NusDUsU57Ka9Jwcjj64kbpyCA4EpMXbE7nsNe0uczZ8WdOzL b4dl5Z+GEl+rHZVeVcoN1pSQM0BxsiQiHd3kxzIfxyEJ6DCZlOjBS9bdyaxhh8VuYdHn 0i0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751875047; x=1752479847; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gizo1Y9JZrUMSmoAMbm1FYjU79aRDOXQASrbUODDlcY=; b=pwxpzxBKfVUfdPqslBv6pD2iAKOm3OWr8PBHfzPxOOZEdBNQljSVNOh+Ty2lpxeDFN JPKUdHhPTdB3tmDwAbHs5XTpAUb98T6MBL1InY18djCSneRdYK6FPdLpSv3sjmFysfZH WiyA9RdlWVBd4ADlDcwIQiQS5wGJos62c069HfHKuaFLfQcTFbNNVeneWIm7aol9qU59 SYjrNmnHQ4KWEbhMY5CjZfUw3BkgpRYU1OLqfldxUzAWwD+/qBiwXSoL7gEq+oOkzY0I JibM5uXifNYuDhBu1QyGucKQ+HYDBxqp0UWoqmqj4CGDovMRdhqyClTYR2Sk5DcW2sr3 mzBA== X-Forwarded-Encrypted: i=1; AJvYcCUpex0J3kuD6VdH+qtT8k3OBLTfB7025ww7OeQWatutD+w04Kd6KV2Zs1qolTLovLyv39jZLLkI9b63zs4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8CPlEZTbn0Gvq/KweSzqdpnOQ0lZUGB3oVbs50KYKgO8uUGsY L/D4HLVjTkrXebfHhj4Rx2BVic4Djc5liC0aHaeG4wQc53gThXaHc6IBZlbtwQsw1ZA= X-Gm-Gg: ASbGncvXqMn+RJsX9jd76zKP4HNLsHifJU5sEB4F8S71fzyyECVe31bW6GtIWSOuplH BZC8Y0Tc9ZkzXx5DstL6J5PxhAYakHAF/CQHX1QfdVUTlCSuPVp20y/E//+jPnIWigcZUPj7BWX nj73uq5htriioZVaWsAIzT82I681rkrNvAiPhSo1kpHY67w0uRTQi8apqUNPm4lUixHYpIR6ntT DgaiuWtBwCE9pplYEY1LWfQVR7hqOKpIFICH5KBaNMzqsE6z4m7tBZ9uA83+iNGuLwCQvZ99qbo 3K37uGYUWDZ3lOW2nQp71A5fznHCdMStTPDWfG/Os6ilvcJR5ldZXtprCzABsPMUikmSahnJlP7 +KMBbjZtwb+l4RN7B8w== X-Google-Smtp-Source: AGHT+IH3zTssQXlW4e9+S6k2Gnh2tBpqiBPmGMJFWBwXftXzY2NmSu5YHWb2cBRXSypKAiCuAwySvg== X-Received: by 2002:a17:902:f792:b0:223:619e:71da with SMTP id d9443c01a7336-23c875da391mr150368325ad.49.1751875047455; Mon, 07 Jul 2025 00:57:27 -0700 (PDT) Received: from mystery-machine.brighamcampbell.com ([64.71.154.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b38ee62f8bdsm8246476a12.57.2025.07.07.00.57.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 00:57:26 -0700 (PDT) From: Brigham Campbell To: dianders@chromium.org, tejasvipin76@gmail.com, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Brigham Campbell Subject: [PATCH 1/3] drm: panel: Replace usage of deprecated MIPI macro Date: Mon, 7 Jul 2025 01:56:56 -0600 Message-ID: <20250707075659.75810-2-me@brighamcampbell.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250707075659.75810-1-me@brighamcampbell.com> References: <20250707075659.75810-1-me@brighamcampbell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace all usages of the deprecated mipi_dsi_generic_write_seq() with mipi_dsi_generic_write_seq_multi(). This patch's usage of the mipi_dsi_multi_context struct is not idiomatic. Rightfully, the struct wasn't designed to cater to the needs of panels with multiple MIPI DSI interfaces. This panel is an oddity which requires swapping the dsi pointer between calls to mipi_dsi_generic_write_seq_multi() in order to preserve the exact behavior implemented using the non-multi variant of the macro. Signed-off-by: Brigham Campbell --- drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c b/drivers/gpu/dr= m/panel/panel-jdi-lpm102a188a.c index 5b5082efb282..777a8ab3a397 100644 --- a/drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c +++ b/drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c @@ -161,29 +161,35 @@ static int jdi_setup_symmetrical_split(struct mipi_ds= i_device *left, =20 static int jdi_write_dcdc_registers(struct jdi_panel *jdi) { + struct mipi_dsi_multi_context dsi_ctx; + /* Clear the manufacturer command access protection */ - mipi_dsi_generic_write_seq(jdi->link1, MCS_CMD_ACS_PROT, + dsi_ctx.dsi =3D jdi->link1; + mipi_dsi_generic_write_seq_multi(&dsi_ctx, MCS_CMD_ACS_PROT, MCS_CMD_ACS_PROT_OFF); - mipi_dsi_generic_write_seq(jdi->link2, MCS_CMD_ACS_PROT, + dsi_ctx.dsi =3D jdi->link2; + mipi_dsi_generic_write_seq_multi(&dsi_ctx, MCS_CMD_ACS_PROT, MCS_CMD_ACS_PROT_OFF); /* - * Change the VGH/VGL divide rations to move the noise generated by the + * Change the VGH/VGL divide ratios to move the noise generated by the * TCONN. This should hopefully avoid interaction with the backlight * controller. */ - mipi_dsi_generic_write_seq(jdi->link1, MCS_PWR_CTRL_FUNC, + dsi_ctx.dsi =3D jdi->link1; + mipi_dsi_generic_write_seq_multi(&dsi_ctx, MCS_PWR_CTRL_FUNC, MCS_PWR_CTRL_PARAM1_VGH_330_DIV | MCS_PWR_CTRL_PARAM1_DEFAULT, MCS_PWR_CTRL_PARAM2_VGL_410_DIV | MCS_PWR_CTRL_PARAM2_DEFAULT); =20 - mipi_dsi_generic_write_seq(jdi->link2, MCS_PWR_CTRL_FUNC, + dsi_ctx.dsi =3D jdi->link2; + mipi_dsi_generic_write_seq_multi(&dsi_ctx, MCS_PWR_CTRL_FUNC, MCS_PWR_CTRL_PARAM1_VGH_330_DIV | MCS_PWR_CTRL_PARAM1_DEFAULT, MCS_PWR_CTRL_PARAM2_VGL_410_DIV | MCS_PWR_CTRL_PARAM2_DEFAULT); =20 - return 0; + return dsi_ctx.accum_err; } =20 static int jdi_panel_prepare(struct drm_panel *panel) --=20 2.49.0 From nobody Tue Oct 7 19:59:40 2025 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAA9228A1D3 for ; Mon, 7 Jul 2025 07:57:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751875053; cv=none; b=PpEQpiABBz/ecumxc01G4wEF2bIQrti+0RHLdMhAoPtUJhlJn6x8JCxNGEL6H7npQPVdjDpmirX+JtxbykD+ik3S8sachb7Lo3MvnTwaJ2e40WOWNzHnKF8bUWQUvEAe7OWeyjRBFojc1kIj9g6i5IC5vM0kfHw1pOdC6Xp7ISY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751875053; c=relaxed/simple; bh=ShU8yklGcE2Nn5vs6gIvPaLoQyjIaXH2iJ09CEBsak8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SDnzJ+61+xaurEk1Dqg7i3g0APtlSwIq1kIkVPCGOiXJKKmav9XcLPGRDD11HSxdpVlAWJ13pePlgkwbd8rlx/che/7pdczIQXgQ7ZqPWPaoAfysZr2f8yLdE0ARWO9RkRG0k+2Z2iwtveHcYzcKCjZJhvwCnDYdlwj62PVSYAc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brighamcampbell.com; spf=pass smtp.mailfrom=brighamcampbell.com; dkim=pass (2048-bit key) header.d=brighamcampbell.com header.i=@brighamcampbell.com header.b=MXOBNNIi; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brighamcampbell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=brighamcampbell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=brighamcampbell.com header.i=@brighamcampbell.com header.b="MXOBNNIi" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-747c2cc3419so2228511b3a.2 for ; Mon, 07 Jul 2025 00:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brighamcampbell.com; s=google; t=1751875051; x=1752479851; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PoWchHvEvGdP5Z/q0UzERLxYZuvcNkSip61qcq1I2gk=; b=MXOBNNIiGX3tcEZR3ljDT/YHyMsWetdTtixqq0kB+WncRBQXJEmZxMW6uBfzx7C7n6 S8cHEiNKqdfgog89Z8PLPqo+rCQ2aZTBdGA911dBO8UbQc7Quc2ncyx/aPZ99NEMCNK/ Ci2R6o+aSQoh3uFGRIc/6cmA40jX3EOF1pmjMstq+jl2WKoTxC8+XeREPp3WQ5XFnEiH ymSszx5IFur1y31nJPPX1So8BM+4L5yMjzgVBxyVYU0pXilu+Mubh46wCvO3tDMSxk9R mq0j8o3lmaEYmWWmb2b+MFM98BATqlR3JgBZ/B4q7nS997Ilzl0Ij2aFg+1MBmrgly6S pvWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751875051; x=1752479851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PoWchHvEvGdP5Z/q0UzERLxYZuvcNkSip61qcq1I2gk=; b=YzGaqWfKbpcTgiUNlFQZBXHAnV0MD8CntF4kOs66kaV7+eqwCKAXzi0DYihGwfNNC/ zGOrZcSIOCH0jddilgRRxt3jQJZZs8wGu8KOHLXefOYfxB6+yW+JAih7Ucd0ajXpZg8K /Ru00LbcVhKUQX082Yrm4XICEHIu7u08nwd2w/UySLDu7eR0upskwuQaVpwHhC0uj2Iq 6KUstNJXbp/xXWoLs9ghk/n4wAMgbPl7tz+gQRDvn8yNq2+E7L/oinKMUj8cFVbdanjD R6wI5MB5lPAdRnlfjkY2p3fWaSsMwcBkqCJCgdYJm/BW5UbhYv1YhX80CVLC0FdaiknU JXvg== X-Forwarded-Encrypted: i=1; AJvYcCVLAT2mfVfO+N0+2Yohy5WCnGRqAZAoWDSOex8RNd/Bhc7Y4F2Bmp3kYiywz3GzrQGtziwvy57a708Qukg=@vger.kernel.org X-Gm-Message-State: AOJu0YwSMHSvz9iFI88eTVago2jv2RA1bLmAM4L9L5P/u2dYneo8UXwk CWXp14TA3stF/zB8CwJy6FgvBPE0qFm1T0d4MGCKDyPKF4Hkef365yTPYm+qbCnD/yc= X-Gm-Gg: ASbGncsSDfW0LzTuaGUhltPXfkIJVU6YwVxbGbM74NRWxwbGYd60pRKekP/jp4Ml17w rrRmkIMko6a/lN5gB0T1DrEW7nDTo/WwU/MIvvIznWF80glFwo2AMfivK2f3i5t2FbX2+zRVIPV 4wJl+Ui2kJViwE1AN3cNQzmUiFfLYi8LbogzXXkC0y3z9SE+tWIndQU7YmubxCvwkPgZcbGBh+d P0JKjZXjlD69H1CUIBTbDqWLQp1Cou2Ddpw0K2PjpjM59kePV3iFlYjKdpK3YOsnNT0aVmnLejF dqghictUC3gwPH1T5x0EXkkAqxHeLA5hpPdRi/vJge+YWsZLEd5YO7qpOl0xmO0ezVY136eBGVr 0TvXJSOedjtd/SqtL7g== X-Google-Smtp-Source: AGHT+IEItjQ5pli2AJ0rBOKHmZ7rfFk3/t/CL1j/RMQ2Bp4Fe+1XZFqzMaA4o2gCpzZkugK6AWVtuQ== X-Received: by 2002:a05:6a00:2195:b0:748:33f3:8da3 with SMTP id d2e1a72fcca58-74cf6fd0ad9mr11173295b3a.19.1751875051077; Mon, 07 Jul 2025 00:57:31 -0700 (PDT) Received: from mystery-machine.brighamcampbell.com ([64.71.154.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b38ee62f8bdsm8246476a12.57.2025.07.07.00.57.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 00:57:30 -0700 (PDT) From: Brigham Campbell To: dianders@chromium.org, tejasvipin76@gmail.com, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Brigham Campbell Subject: [PATCH 2/3] drm: Remove unused MIPI write seq and chatty functions Date: Mon, 7 Jul 2025 01:56:57 -0600 Message-ID: <20250707075659.75810-3-me@brighamcampbell.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250707075659.75810-1-me@brighamcampbell.com> References: <20250707075659.75810-1-me@brighamcampbell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the deprecated mipi_dsi_generic_write_seq() macro and mipi_dsi_generic_write_chatty() function now that they are no longer used. Signed-off-by: Brigham Campbell --- drivers/gpu/drm/drm_mipi_dsi.c | 34 +++------------------------------- include/drm/drm_mipi_dsi.h | 23 ----------------------- 2 files changed, 3 insertions(+), 54 deletions(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index a00d76443128..3b8ff24980b4 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -772,41 +772,13 @@ ssize_t mipi_dsi_generic_write(struct mipi_dsi_device= *dsi, const void *payload, EXPORT_SYMBOL(mipi_dsi_generic_write); =20 /** - * mipi_dsi_generic_write_chatty() - mipi_dsi_generic_write() w/ an error = log - * @dsi: DSI peripheral device - * @payload: buffer containing the payload - * @size: size of payload buffer - * - * Like mipi_dsi_generic_write() but includes a dev_err() - * call for you and returns 0 upon success, not the number of bytes sent. - * - * Return: 0 on success or a negative error code on failure. - */ -int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi, - const void *payload, size_t size) -{ - struct device *dev =3D &dsi->dev; - ssize_t ret; - - ret =3D mipi_dsi_generic_write(dsi, payload, size); - if (ret < 0) { - dev_err(dev, "sending generic data %*ph failed: %zd\n", - (int)size, payload, ret); - return ret; - } - - return 0; -} -EXPORT_SYMBOL(mipi_dsi_generic_write_chatty); - -/** - * mipi_dsi_generic_write_multi() - mipi_dsi_generic_write_chatty() w/ acc= um_err + * mipi_dsi_generic_write_multi() - mipi_dsi_generic_write() w/ accum_err * @ctx: Context for multiple DSI transactions * @payload: buffer containing the payload * @size: size of payload buffer * - * Like mipi_dsi_generic_write_chatty() but deals with errors in a way that - * makes it convenient to make several calls in a row. + * A wrapper around mipi_dsi_generic_write() that deals with errors in a w= ay + * that makes it convenient to make several calls in a row. */ void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx, const void *payload, size_t size) diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 369b0d8830c3..f9cc106c8eb6 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -285,8 +285,6 @@ void mipi_dsi_picture_parameter_set_multi(struct mipi_d= si_multi_context *ctx, =20 ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *pa= yload, size_t size); -int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi, - const void *payload, size_t size); void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx, const void *payload, size_t size); ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *par= ams, @@ -379,27 +377,6 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_= dsi_multi_context *ctx, u16 scanline); void mipi_dsi_dcs_set_tear_off_multi(struct mipi_dsi_multi_context *ctx); =20 -/** - * mipi_dsi_generic_write_seq - transmit data using a generic write packet - * - * This macro will print errors for you and will RETURN FROM THE CALLING - * FUNCTION (yes this is non-intuitive) upon error. - * - * Because of the non-intuitive return behavior, THIS MACRO IS DEPRECATED. - * Please replace calls of it with mipi_dsi_generic_write_seq_multi(). - * - * @dsi: DSI peripheral device - * @seq: buffer containing the payload - */ -#define mipi_dsi_generic_write_seq(dsi, seq...) = \ - do { \ - static const u8 d[] =3D { seq }; \ - int ret; \ - ret =3D mipi_dsi_generic_write_chatty(dsi, d, ARRAY_SIZE(d)); \ - if (ret < 0) \ - return ret; \ - } while (0) - /** * mipi_dsi_generic_write_seq_multi - transmit data using a generic write = packet * --=20 2.49.0 From nobody Tue Oct 7 19:59:40 2025 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A79DC28C2B3 for ; Mon, 7 Jul 2025 07:57:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751875057; cv=none; b=mB8i+XEzVx73ytmwABos2LexEns3lAojfA6LuN41c1TELeejqr4Wg5kE2pZLsNmVunq93NxAjc4+Ix4S4jRcKphrqi19PEom3pORER4MimEzS6ApCj8EVbIjaZbSeQPMlwHoylybMjRxamfAHCU8F/yRcuuOP4e7nTDCtiSJF4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751875057; c=relaxed/simple; bh=TIYvoKfMMCjlv2uIdTylizwMRIdwqTIRMTgS9s8saVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fPM1hWLN+IuTUjMFz8PuGVM5mXkX0nOmzAqVKP6VNZQoPX+YnSco5HRJYYLDmzG4xy3f8b2kDY8QaJq+QLCncxx8aHRm7xoIYH1G1v7rg6eVqaVvKP/C8iOgO0A8FKyNveDoDJ8Mx2shm3cmIdOxt13+ikIP84WqoV6ipX3D3jA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brighamcampbell.com; spf=pass smtp.mailfrom=brighamcampbell.com; dkim=pass (2048-bit key) header.d=brighamcampbell.com header.i=@brighamcampbell.com header.b=fAXCp2Ok; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brighamcampbell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=brighamcampbell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=brighamcampbell.com header.i=@brighamcampbell.com header.b="fAXCp2Ok" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-af51596da56so2098205a12.0 for ; Mon, 07 Jul 2025 00:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brighamcampbell.com; s=google; t=1751875055; x=1752479855; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/MC/xohKHOcg+vnOOSNCEDTYlZuTz6zJxo6U8fkD0yY=; b=fAXCp2OkG630hcC1x3SNl4GRMHD9RpPkRHnjMVtZ6FFYIFmA53Ndu6pC/DKss6AMO0 miJtcA+RgIfT4ZcCMdSEHsINFBUDHyI0z9bz3OFdiVmnswRIdua/ZjZp3X9iF03RlRyR PlUD4+PZJqaqi9vMAIRxLOFBwL3Hi5gjOBPSrGPWxESuMLzJJOVV8as2NhmOjRDLPHtl HVcFX1ZR1kifAT7YyHm/ado3fX+5d0vOwbVHRgRNFvCfyoPlU5Qg1W6jn8MtBpl6pjkw Zn6Z1VO6TWQKNSdiSDneMvIRQkdurjS0pAs9Yw5opKmDyrHORLnwUS5tm6zN109SuUJL OU/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751875055; x=1752479855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/MC/xohKHOcg+vnOOSNCEDTYlZuTz6zJxo6U8fkD0yY=; b=EkMZCpI4Cv96KwM45Nrt0mQTWHgWfh19whG4CcCJiTsjed2ojzZRLpXJH9FY/GATE7 SwCjDTXFUA/HgiWJc1Z8e+kY13X2fbxyV5igaFu+SWa5vLglo5WiLa3GYFkrN4JxQq7n sfT0cum+c1b7aCrM664Yp8v6Y2mYMadio4XU251mEH3VzU/jkPqo2GxtyzBimRjHUc/u Q9dcSxonpeTQV+/f5/emjAzZY7J7+ZulHiIEmq0OZZRSgS+41jEKSzcdpnQyv2AHEkkr mvf5UaYZ9mmLvb3vnv0Bbn/6nw3QBYqPKgiXqBrV8NgodecNWWC1teGWiDN9oxybuCNw e+6A== X-Forwarded-Encrypted: i=1; AJvYcCUCebzOyD5oy0lwE3juPrfOBID1ebAx/cc9wbuiVvfY3KJ1sgHqWGOpoAhpluR932HJZKnaF2qDJxzwr0w=@vger.kernel.org X-Gm-Message-State: AOJu0YwKZzDSPIfVuUBxQN+reap05IH8vJ5fFZgi3EHlbZCyJymaGDZn XhI5kU9j5k21KAAWCCuzp31fZEoqylFDnbfb64O2KfIRrQVoKHNZEATpZWQ6rGx/7Qg= X-Gm-Gg: ASbGncsMDba7MdetRHU3daOqdh73hspyykBfq2RPUF+DomvHKkMEPeoBWfKJandRTEK AAoXKacCpAdTYE+i3UmcQWbRr9urMYNpscZ29brpcK6Ch5ggEIAWyTv4uFoT3kBieFz4GwMD5KY c8PxvcHNBE9wRaqcaJC8egcpv3GqM5F6u+9U6IV02Z1T4tUlD8yjqweVjXFhZMqHzEYyBt7ddOw I1dO24Ny02Edm1gu+YLl3NMkY4Y+1XKh+xeTD/TFPIXNZf8hUBnklYX6CYdnTpR7DPLFYXTGFWH FyXiYuaiH2N/4cbbpZk9WEKoLCHPqjWOXdl1zw12ejJMR6xMldt5eWI2lvn0YSTzPW/+XjoBnqF u1+zCBXg55WtyJQ3WSA== X-Google-Smtp-Source: AGHT+IEG3rUVLj/sU9Sc3cCmT/rktoO/r9+WAKUWx4b+U8GR+jBcTNhe69ooHHcJV8ngN58Oe5tUvA== X-Received: by 2002:a05:6a20:2583:b0:21f:54f0:3b84 with SMTP id adf61e73a8af0-2260b96873fmr18892440637.35.1751875054860; Mon, 07 Jul 2025 00:57:34 -0700 (PDT) Received: from mystery-machine.brighamcampbell.com ([64.71.154.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b38ee62f8bdsm8246476a12.57.2025.07.07.00.57.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 00:57:34 -0700 (PDT) From: Brigham Campbell To: dianders@chromium.org, tejasvipin76@gmail.com, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet Cc: Brigham Campbell Subject: [PATCH 3/3] drm: docs: Remove completed task from drm TODO list Date: Mon, 7 Jul 2025 01:56:58 -0600 Message-ID: <20250707075659.75810-4-me@brighamcampbell.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250707075659.75810-1-me@brighamcampbell.com> References: <20250707075659.75810-1-me@brighamcampbell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove TODO item from drm documentation to transition away from using mipi_dsi_*_write_seq() macros now that the work is complete. Signed-off-by: Brigham Campbell --- Documentation/gpu/todo.rst | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index be8637da3fe9..76afb8a784e3 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -497,24 +497,6 @@ Contact: Douglas Anderson =20 Level: Intermediate =20 -Transition away from using mipi_dsi_*_write_seq() -------------------------------------------------- - -The macros mipi_dsi_generic_write_seq() and mipi_dsi_dcs_write_seq() are -non-intuitive because, if there are errors, they return out of the *caller= 's* -function. We should move all callers to use mipi_dsi_generic_write_seq_mul= ti() -and mipi_dsi_dcs_write_seq_multi() macros instead. - -Once all callers are transitioned, the macros and the functions that they = call, -mipi_dsi_generic_write_chatty() and mipi_dsi_dcs_write_buffer_chatty(), can -probably be removed. Alternatively, if people feel like the _multi() varia= nts -are overkill for some use cases, we could keep the mipi_dsi_*_write_seq() -variants but change them not to return out of the caller. - -Contact: Douglas Anderson - -Level: Starter - Remove devm_drm_put_bridge() ---------------------------- =20 --=20 2.49.0