From nobody Tue Oct 7 21:39:56 2025 Received: from mx9.didiglobal.com (mx9.didiglobal.com [111.202.70.124]) by smtp.subspace.kernel.org (Postfix) with SMTP id E2EE827932E; Mon, 7 Jul 2025 07:00:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=111.202.70.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751871648; cv=none; b=BVtN71PFqGBk8pno97T2e/9d+v+6n9VuZDT4uTq6zqZ1SbQJ+M01Qu00JZ+molfEXXqMdyeL7o6fGLqpqVPhU7LC9WVuZpJzxj8kyUXndp0KSM3Vchvymq5gEevQ09ePuC4zGA/QjjwTFLDfWBoa3YPGpZETFpWwz7YqMnbel/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751871648; c=relaxed/simple; bh=G4rwVJYLKQqnce8QoPmaSGWeYFRMyGi7Hu7kmAMCExA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:Content-Type: MIME-Version; b=gfWP8pTstP9NjAOHeYoZsQ4ZvVD2WK1puAgLg5gyo/U4ueXFx8HReKnD3sxrFlEBz+hN6mD8doNThGqm42EzC/G79RFTEJO1I2aWVRzm+Azy4qgSGLI7d0Tc1/fFEfKjQS755yHee6cy+H+D8pN2wpjuEW+k8GWmco6rcY3O42c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=didiglobal.com; spf=pass smtp.mailfrom=didiglobal.com; dkim=pass (1024-bit key) header.d=didiglobal.com header.i=@didiglobal.com header.b=SOQ9gZx2; arc=none smtp.client-ip=111.202.70.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=didiglobal.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=didiglobal.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=didiglobal.com header.i=@didiglobal.com header.b="SOQ9gZx2" Received: from mail.didiglobal.com (unknown [10.79.65.19]) by mx9.didiglobal.com (MailData Gateway V2.8.8) with ESMTPS id E9D2B196C52387; Mon, 7 Jul 2025 14:56:25 +0800 (CST) Received: from BJ02-ACTMBX-08.didichuxing.com (10.79.65.15) by BJ02-ACTMBX-01.didichuxing.com (10.79.65.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Mon, 7 Jul 2025 15:00:29 +0800 Received: from BJ03-ACTMBX-07.didichuxing.com (10.79.71.34) by BJ02-ACTMBX-08.didichuxing.com (10.79.65.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Mon, 7 Jul 2025 15:00:28 +0800 Received: from BJ03-ACTMBX-07.didichuxing.com ([fe80::2e1a:dd47:6d25:287e]) by BJ03-ACTMBX-07.didichuxing.com ([fe80::2e1a:dd47:6d25:287e%7]) with mapi id 15.02.1748.010; Mon, 7 Jul 2025 15:00:28 +0800 X-MD-Sfrom: chentaotao@didiglobal.com X-MD-SrcIP: 10.79.65.19 From: =?gb2312?B?s8LMzszOIFRhb3RhbyBDaGVu?= To: "tytso@mit.edu" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "willy@infradead.org" , "brauner@kernel.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" , "airlied@gmail.com" CC: "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-block@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "chentao325@qq.com" , "frank.li@vivo.com" , =?gb2312?B?s8LMzszOIFRhb3RhbyBDaGVu?= Subject: [PATCH v4 1/5] drm/i915: Use kernel_write() in shmem object create Thread-Topic: [PATCH v4 1/5] drm/i915: Use kernel_write() in shmem object create Thread-Index: AQHb7wzSnrNvMBtkFkukDbqDBoOCMA== Date: Mon, 7 Jul 2025 07:00:28 +0000 Message-ID: <20250707070023.206725-2-chentaotao@didiglobal.com> In-Reply-To: <20250707070023.206725-1-chentaotao@didiglobal.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=didiglobal.com; s=2025; t=1751871390; bh=G4rwVJYLKQqnce8QoPmaSGWeYFRMyGi7Hu7kmAMCExA=; h=From:To:CC:Subject:Date:Message-ID:Content-Type; b=SOQ9gZx2iuT4VO72DdkXd4zktXp9ze/IeJcSZgo5wkoLWvJ949F02oWP8UrNLyP0A o4bNrVPS5/DzVXNxdag5VnIqsLIC9iUHard9cijJrDPuat59AheNJA4oImkwfDG97O 3aMja+mGmh5y4B1IP04ktZb2F0ATfFuQrYeaczSg= Content-Type: text/plain; charset="utf-8" From: Taotao Chen Replace the write_begin/write_end loop in i915_gem_object_create_shmem_from_data() with call to kernel_write(). This function initializes shmem-backed GEM objects. kernel_write() simplifies the code by removing manual folio handling. Part of a series refactoring address_space_operations write_begin and write_end callbacks to use struct kiocb for passing write context and flags. Signed-off-by: Taotao Chen --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 33 +++++++---------------- 1 file changed, 9 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i9= 15/gem/i915_gem_shmem.c index 19a3eb82dc6a..1e8f66ac48ca 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c @@ -637,9 +637,8 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_= private *i915, { struct drm_i915_gem_object *obj; struct file *file; - const struct address_space_operations *aops; - loff_t pos; - int err; + loff_t pos =3D 0; + ssize_t err; =20 GEM_WARN_ON(IS_DGFX(i915)); obj =3D i915_gem_object_create_shmem(i915, round_up(size, PAGE_SIZE)); @@ -649,29 +648,15 @@ i915_gem_object_create_shmem_from_data(struct drm_i91= 5_private *i915, GEM_BUG_ON(obj->write_domain !=3D I915_GEM_DOMAIN_CPU); =20 file =3D obj->base.filp; - aops =3D file->f_mapping->a_ops; - pos =3D 0; - do { - unsigned int len =3D min_t(typeof(size), size, PAGE_SIZE); - struct folio *folio; - void *fsdata; - - err =3D aops->write_begin(file, file->f_mapping, pos, len, - &folio, &fsdata); - if (err < 0) - goto fail; + err =3D kernel_write(file, data, size, &pos); =20 - memcpy_to_folio(folio, offset_in_folio(folio, pos), data, len); + if (err < 0) + goto fail; =20 - err =3D aops->write_end(file, file->f_mapping, pos, len, len, - folio, fsdata); - if (err < 0) - goto fail; - - size -=3D len; - data +=3D len; - pos +=3D len; - } while (size); + if (err !=3D size) { + err =3D -EIO; + goto fail; + } =20 return obj; =20 --=20 2.34.1