From nobody Tue Oct 7 19:50:47 2025 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 420C6271A7B for ; Mon, 7 Jul 2025 18:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751913249; cv=none; b=IP1zsjJrCnp9oEjaJw8KagXQoOTjIZRFCzveEr07+tFWsVUJqSHz/ARUK/EO69xoyOoKZvCkldxzZ9H0dNui16P4ake/8/42Mwh/TjZ8+JciWUDeKqROLJWYWId+t5Su1A5JeeZqnSdgD0oR/CE4VWuZFdCIh66u/p1NXBc7nvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751913249; c=relaxed/simple; bh=sVG3jXB7G5g5VkbTuzz7YugXFtGc7x/LVOgePX3jelA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S3l3n6pRf16R0uRLkeZjwLkUM2hswOkoyi4cm3WzfTJtgN1qWwu222TCzF2uGkw84ouOcTbnZ9Jmp9u+UVnizYv0TO74tJpTVusKmkOGR3wsnULd7ymp28DddE2VvtjbF3xXam+Ld/HY1Jz3Gwx0LM7OOQp06Q/emo/FuPOHv4I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ZBFLNEG3; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZBFLNEG3" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-556fd896c99so2877558e87.3 for ; Mon, 07 Jul 2025 11:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1751913245; x=1752518045; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KPIaOyTFadqUjMfdacN75cl1wBFQWTU+JWrkSX4D/W4=; b=ZBFLNEG35hnvby1Y3HSJ8IKqvtDwfp5sbN7xUI8nCARUgOZmGNXy+kBaMV0w6N6cXG gKeSxnBSvYh/n/we88HN4VUsh2ZLqo9tX1NVsFKjSEpyi9duCnb/Mn8pVzK1M1fSEFxP MSUKkEXvCosXWNJHVTY1Q+dWas6Ez7vMJO6ZM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751913245; x=1752518045; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KPIaOyTFadqUjMfdacN75cl1wBFQWTU+JWrkSX4D/W4=; b=Bh0uA++1+RBWtSYY7FNFWOw8/ckmzAAgLyl6gEcOnl8ACPEm9gynRYPTKhZ4Ziufwv 1PwDv/8kLwJxXiaresamTWsM/Ptb2KWO8DHBBuWJzZ4AoO6gIc/Rblg+TdJ1jAUBChG7 Jz864htTfY1xglxJbRx0yj8NeApg3MPp9sk/aJTPxNwfbXLFO/IDEYdUzNFdNJ1ji62S 1xOL/r7zaCGj3+sUJ9zx+1V7M7GPZ0gPmPUbjJSw9TZJwhnnzO9XF26a5IrtcXRl/8ww sDdzB9t/aImhGVA6/aoJAn9Kmb6WHL9wCsmD1PPoOUciGiFY1giScKRJcnPqlz9PzvGl kDPw== X-Forwarded-Encrypted: i=1; AJvYcCXVdWh7rfM+5gM+7wBKvNSBLgtd+KKh0ErQI+vOxMEbnOn6Ekumh7sqEKRym89IM6ntv0zUW+biqIGvaY0=@vger.kernel.org X-Gm-Message-State: AOJu0YwatSaH1POvRWvrTqbHZtCNE3cpL5HM8TVh8Eh7sex/7nF/PSEz 2s8dHFDUgKxperrPbWDDzE4DzYsko2O80+wpQs22o8gPli9DUEZ4PZJdw8mmHsTyaUg07XE7X3S 5q6Y= X-Gm-Gg: ASbGnctOn8olNUGX3b4z6bCwN2+VW2jXfYnMhI9S/Is78vz2rvdKb29YVZI2wFrWtXx R7GP3tUiJh14q6dOL15VVxb6qu4EcsoJGCJiBbAeIEj6SdZ/lHcCdwrdDLNC0S82DsyCEddR1nP TUHPsBHIjKI1HVieSr2rXHszLc2BVH3+kwNHNLK3lFHDrpBjvNWt3IebRvovJVKlgM6Pg+gRJXH uP/ICYwqsGmEnrR8oCS7BC4tPoeTfZ5GXqH+DV2NlWwGouS32K2yqbKWecBBmPixCB2W+3M6fBx DdIzAehV/7/uRh5wIYfurM8L1snR2pM4mJB2q7drkrwl775tFeWZDEwc+kbUbFMVYU6blERbU3C VVTMZHKeZwfT76KUl4JPcn8f7MYJEYsBVh6LUcNxLjw== X-Google-Smtp-Source: AGHT+IE4uyqyZpucH4y+ZvlBsX58kvvph8A860fajfAiOIZDRFqwIHkUsRPLwiIFiVEjP0cClON7YQ== X-Received: by 2002:a05:6512:3e25:b0:553:2698:99c5 with SMTP id 2adb3069b0e04-557aa86aae9mr3669267e87.39.1751913244975; Mon, 07 Jul 2025 11:34:04 -0700 (PDT) Received: from ribalda.c.googlers.com (166.141.88.34.bc.googleusercontent.com. [34.88.141.166]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-556383d31a6sm1417630e87.61.2025.07.07.11.34.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 11:34:04 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 07 Jul 2025 18:34:05 +0000 Subject: [PATCH v8 5/5] media: uvcvideo: Auto-set UVC_QUIRK_MSXU_META Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250707-uvc-meta-v8-5-ed17f8b1218b@chromium.org> References: <20250707-uvc-meta-v8-0-ed17f8b1218b@chromium.org> In-Reply-To: <20250707-uvc-meta-v8-0-ed17f8b1218b@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Guennadi Liakhovetski , Greg Kroah-Hartman , Hans de Goede , Hans de Goede Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 If the camera supports the MSXU_CONTROL_METADATA control, auto set the MSXU_META quirk. Reviewed-by: Hans de Goede Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_driver.c | 7 +++- drivers/media/usb/uvc/uvc_metadata.c | 75 ++++++++++++++++++++++++++++++++= +++- drivers/media/usb/uvc/uvcvideo.h | 2 +- include/linux/usb/uvc.h | 3 ++ 4 files changed, 84 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc= _driver.c index 56ea20eeb7b9d5d92f3d837c15bdf11d536e9f2d..9de5abb43e19d9e876cddc5d712= 4592953db89ac 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -2315,7 +2315,12 @@ static int uvc_probe(struct usb_interface *intf, goto error; } =20 - uvc_meta_init(dev); + ret =3D uvc_meta_init(dev); + if (ret < 0) { + dev_err(&dev->udev->dev, + "Error initializing the metadata formats (%d)\n", ret); + goto error; + } =20 if (dev->quirks & UVC_QUIRK_NO_RESET_RESUME) udev->quirks &=3D ~USB_QUIRK_RESET_RESUME; diff --git a/drivers/media/usb/uvc/uvc_metadata.c b/drivers/media/usb/uvc/u= vc_metadata.c index 77e03273d3cf6b00cac6ebb9b29b941f1cbfd9f7..59bb133baf9a73ef6a30fa8ead8= 5aa90653d60f4 100644 --- a/drivers/media/usb/uvc/uvc_metadata.c +++ b/drivers/media/usb/uvc/uvc_metadata.c @@ -10,6 +10,7 @@ #include #include #include +#include #include =20 #include @@ -166,6 +167,71 @@ static const struct v4l2_file_operations uvc_meta_fops= =3D { .mmap =3D vb2_fop_mmap, }; =20 +static struct uvc_entity *uvc_meta_find_msxu(struct uvc_device *dev) +{ + static const u8 uvc_msxu_guid[16] =3D UVC_GUID_MSXU_1_5; + struct uvc_entity *entity; + + list_for_each_entry(entity, &dev->entities, list) { + if (!memcmp(entity->guid, uvc_msxu_guid, sizeof(entity->guid))) + return entity; + } + + return NULL; +} + +#define MSXU_CONTROL_METADATA 0x9 +static int uvc_meta_detect_msxu(struct uvc_device *dev) +{ + u32 *data __free(kfree) =3D NULL; + struct uvc_entity *entity; + int ret; + + entity =3D uvc_meta_find_msxu(dev); + if (!entity) + return 0; + + /* + * USB requires buffers aligned in a special way, simplest way is to + * make sure that query_ctrl will work is to kmalloc() them. + */ + data =3D kmalloc(sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + /* Check if the metadata is already enabled. */ + ret =3D uvc_query_ctrl(dev, UVC_GET_CUR, entity->id, dev->intfnum, + MSXU_CONTROL_METADATA, data, sizeof(*data)); + if (ret) + return 0; + + if (*data) { + dev->quirks |=3D UVC_QUIRK_MSXU_META; + return 0; + } + + /* + * We have seen devices that require 1 to enable the metadata, others + * requiring a value !=3D 1 and others requiring a value >1. Luckily for + * us, the value from GET_MAX seems to work all the time. + */ + ret =3D uvc_query_ctrl(dev, UVC_GET_MAX, entity->id, dev->intfnum, + MSXU_CONTROL_METADATA, data, sizeof(*data)); + if (ret || !*data) + return 0; + + /* + * If we can set MSXU_CONTROL_METADATA, the device will report + * metadata. + */ + ret =3D uvc_query_ctrl(dev, UVC_SET_CUR, entity->id, dev->intfnum, + MSXU_CONTROL_METADATA, data, sizeof(*data)); + if (!ret) + dev->quirks |=3D UVC_QUIRK_MSXU_META; + + return 0; +} + int uvc_meta_register(struct uvc_streaming *stream) { struct uvc_device *dev =3D stream->dev; @@ -185,9 +251,14 @@ int uvc_meta_register(struct uvc_streaming *stream) &uvc_meta_fops, &uvc_meta_ioctl_ops); } =20 -void uvc_meta_init(struct uvc_device *dev) +int uvc_meta_init(struct uvc_device *dev) { unsigned int i =3D 0; + int ret; + + ret =3D uvc_meta_detect_msxu(dev); + if (ret) + return ret; =20 dev->meta_formats[i++] =3D V4L2_META_FMT_UVC; =20 @@ -201,4 +272,6 @@ void uvc_meta_init(struct uvc_device *dev) =20 /* IMPORTANT: for new meta-formats update UVC_MAX_META_DATA_FORMATS. */ dev->meta_formats[i++] =3D 0; + + return 0; } diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvi= deo.h index 616adc417c62a58686beccbc440a5dfac0a2d588..a4c064c5e046f2a4adba742c877= 7a10619569606 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -757,7 +757,7 @@ int uvc_query_ctrl(struct uvc_device *dev, u8 query, u8= unit, void uvc_video_clock_update(struct uvc_streaming *stream, struct vb2_v4l2_buffer *vbuf, struct uvc_buffer *buf); -void uvc_meta_init(struct uvc_device *dev); +int uvc_meta_init(struct uvc_device *dev); int uvc_meta_register(struct uvc_streaming *stream); =20 int uvc_register_video_device(struct uvc_device *dev, diff --git a/include/linux/usb/uvc.h b/include/linux/usb/uvc.h index bce95153e5a65613a710d7316fc17cf5462b5bce..ee19e9f915b8370c333c426dc1e= e4202c7b75c5b 100644 --- a/include/linux/usb/uvc.h +++ b/include/linux/usb/uvc.h @@ -29,6 +29,9 @@ #define UVC_GUID_EXT_GPIO_CONTROLLER \ {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x03} +#define UVC_GUID_MSXU_1_5 \ + {0xdc, 0x95, 0x3f, 0x0f, 0x32, 0x26, 0x4e, 0x4c, \ + 0x92, 0xc9, 0xa0, 0x47, 0x82, 0xf4, 0x3b, 0xc8} =20 #define UVC_GUID_FORMAT_MJPEG \ { 'M', 'J', 'P', 'G', 0x00, 0x00, 0x10, 0x00, \ --=20 2.50.0.727.gbf7dc18ff4-goog