From nobody Tue Oct 7 21:00:22 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EF74186A; Sun, 6 Jul 2025 19:32:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830332; cv=none; b=rlGI4CHABZlSGVJfkdwT2mmbsTHvm+eSeIOA/6LYY9Ag4PjU9VVvQ9vCWMI6Gxl39q1T4E9O74y5blMWyV9UkKvTq2QZ06MVLoQdvGn9jKDInxK6wTmrBpfSYVadi+MR4LKLRuJ/wJohBuMin0GJ16Muz0VhQJuqvB0aso/FnbE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830332; c=relaxed/simple; bh=sJNUfzwZJvQuoC1F66bEVuJ3ctg7lAi4+PjtYCktIEk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oOLFMY6xeaDtzJL79NBw8CMyArsZY03mcYtwvhSwLg4CUr1jteOTU4ggHqElv61kM8SsMm58J3+v8wyQXjsHHxsQ0QFh1AW3Ns41wuieJ+UvS/md3XSRc1d3LgZfoiYZHtWrYL8sY6aWbeVdGvvaj+VrmgsHrQNYSQ8Fe7QWYJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kNms0LMn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kNms0LMn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CEF0C4CEEE; Sun, 6 Jul 2025 19:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751830332; bh=sJNUfzwZJvQuoC1F66bEVuJ3ctg7lAi4+PjtYCktIEk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kNms0LMnuLq5XZ6TxvfkzWtuOenMfZRROw0kJ5+cQl9xWB24W3LzEwyWWmlGR9HtY AMbsxj2gYKPhGgIRcd8xoe+yu8OPTCVxt9YrgG7jeTdJFJtnT9LfxlNRC7ZFzFeYIy WABZK2AKedpb1JSrnCYxEroLPUUf7i2QNUqs/+qpYZOOKlnYZDWmuvyNp9sw7A9reF 31E7p9yReXo4OpbxkMIneMiAvdB25ljXfRRLQN4O/hDtKxk6y95A6PCOCvLXhO+5hh EaIomREwbJifZTOkCbNYZAqMRJGBRCwfXysRHcRs63XNU02Jc9YeQsaw2P/laz4E/v pM1zJ7JBVa+Xg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: [PATCH 1/6] samples/damon/wsse: fix boot time enable handling Date: Sun, 6 Jul 2025 12:32:02 -0700 Message-Id: <20250706193207.39810-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706193207.39810-1-sj@kernel.org> References: <20250706193207.39810-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If 'enable' parameter of the 'wsse' DAMON sample module is set at boot time via the kernel command line, memory allocation is tried before the slab is initialized. As a result kernel NULL pointer dereference BUG can happen. Fix it by checking the initialization status. Fixes: b757c6cfc696 ("samples/damon/wsse: start and stop DAMON as the user = requests") Cc: stable@vger.kernel.org Signed-off-by: SeongJae Park --- samples/damon/wsse.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/samples/damon/wsse.c b/samples/damon/wsse.c index e20238a249e7..15e2683fe5f3 100644 --- a/samples/damon/wsse.c +++ b/samples/damon/wsse.c @@ -89,6 +89,8 @@ static void damon_sample_wsse_stop(void) put_pid(target_pidp); } =20 +static bool init_called; + static int damon_sample_wsse_enable_store( const char *val, const struct kernel_param *kp) { @@ -103,6 +105,9 @@ static int damon_sample_wsse_enable_store( return 0; =20 if (enable) { + if (!init_called) + return 0; + err =3D damon_sample_wsse_start(); if (err) enable =3D false; @@ -114,7 +119,15 @@ static int damon_sample_wsse_enable_store( =20 static int __init damon_sample_wsse_init(void) { - return 0; + int err =3D 0; + + init_called =3D true; + if (enable) { + err =3D damon_sample_wsse_start(); + if (err) + enable =3D false; + } + return err; } =20 module_init(damon_sample_wsse_init); --=20 2.39.5 From nobody Tue Oct 7 21:00:22 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD3E62BCF4B; Sun, 6 Jul 2025 19:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830333; cv=none; b=C6iKXlMoHFPrk7n8jq0hE/BQcXQ+S+fGS3UbGBw0/Ksz6uRteEWhbmCLn0QKYeBvVG6Q2s1MT1MMNeUO8UX05VgQ5DN34PxgUNjsZe05DLWuLcqICNdAmBJ98iQ+2Qg0PhWsalxxeVReoBsSp5aG7Fw4c6Zhmsh7KtgCMkcDk1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830333; c=relaxed/simple; bh=ItdKrZvjvoLfJbg0R8zs5Hictw962k8iIPOxGamn4Z8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=teyrtdPMkj/zBSbr8PkS1Z89qId+K/VZp7vLLsfDbxQMnOLei7htT9HVIkO3yg66Q4GtLg6wxGKEYEsVgzZPG8XLzfK682sHBg8azGcGEiiLj7F0+MFqsh7AMJbfQEsWcjIvWtp0Pz7HFOviS+5fRo7Pr1CWueVGI7iUVxQ5FwY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LnUauxP5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LnUauxP5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22F2AC4CEEE; Sun, 6 Jul 2025 19:32:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751830333; bh=ItdKrZvjvoLfJbg0R8zs5Hictw962k8iIPOxGamn4Z8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LnUauxP53NuIKsYA+Jp/AghJ+OGnIGLIvW9Sdra0SjiFWxC9gQEz7ZiW10YBNQG76 k4WGRJf59ArnLzCNPxNkCtiDY5EMvWY8a0ttN5xlqhgJpxgkrBPkssF2sh9Gd+YPZs pIlWVnvpKtLfO4tYM7k8bbArmJPm6fqtE0Mhg9q621EtekOiUe1yjyeNTW3FN0dyZ5 vDr5Ylz7j8UZlhZZyB6tgYuTMj6+EGL7kfVpGypNq1kTNAlBVQUAUGfLhrtbyksHtF o9SJvNRehFZOTTefDTQcp6HZavj6in5HXpQ9OiCFLNyQ9pkAyxwFUKGea6nsH5kLjD OOYY2ZJSAUcvw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/6] samples/damon/prcl: fix boot time enable crash Date: Sun, 6 Jul 2025 12:32:03 -0700 Message-Id: <20250706193207.39810-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706193207.39810-1-sj@kernel.org> References: <20250706193207.39810-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If 'enable' parameter of the 'prcl' DAMON sample module is set at boot time via the kernel command line, memory allocation is tried before the slab is initialized. As a result kernel NULL pointer dereference BUG can happen. Fix it by checking the initialization status. Fixes: 2aca254620a8 ("samples/damon: introduce a skeleton of a smaple DAMON= module for proactive reclamation") Signed-off-by: SeongJae Park --- samples/damon/prcl.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/samples/damon/prcl.c b/samples/damon/prcl.c index 5597e6a08ab2..f04a18a8626a 100644 --- a/samples/damon/prcl.c +++ b/samples/damon/prcl.c @@ -109,6 +109,8 @@ static void damon_sample_prcl_stop(void) put_pid(target_pidp); } =20 +static bool init_called; + static int damon_sample_prcl_enable_store( const char *val, const struct kernel_param *kp) { @@ -122,6 +124,9 @@ static int damon_sample_prcl_enable_store( if (enable =3D=3D enabled) return 0; =20 + if (!init_called) + return 0; + if (enable) { err =3D damon_sample_prcl_start(); if (err) @@ -134,6 +139,14 @@ static int damon_sample_prcl_enable_store( =20 static int __init damon_sample_prcl_init(void) { + int err =3D 0; + + init_called =3D true; + if (enable) { + err =3D damon_sample_prcl_start(); + if (err) + enable =3D false; + } return 0; } =20 --=20 2.39.5 From nobody Tue Oct 7 21:00:22 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6BE72BD03D; Sun, 6 Jul 2025 19:32:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830334; cv=none; b=ALEw+xErHnFTwy3WPmo8PRkGcBDzvK6FTd9o57+MmfdFtiFU1EMznVsy7I7+xJnc2SoT7BZj6o4iLgklH+sMy8pJDM4KwgzNWNwdXU7MTluQwFKre504sgaqL3/nMrAyks56nalzqchF8u3aoT9O7PqGnWpH7uPSPTjOX4qLJTc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830334; c=relaxed/simple; bh=6YD9fy08Fo/Z6UH4MbMMm+CPYSdgQozsFgabwgS4zT4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=A+QkU1OPBzEc/AL2slHfQ6xVc25O1Qet0sIF1170r2aL1af/kq86xFyi3iXIQyCEO0GNF8KXYBca2oPRvFWMGJIhm7LzTtGUgwXrXm62DLMSSGp4qZ/WRfPNNVlOmyffxClJquFLKnDydjYlRgNFizxHF0NA8MiqtdJANjSLj80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OMJRlayK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OMJRlayK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C56AC4CEED; Sun, 6 Jul 2025 19:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751830334; bh=6YD9fy08Fo/Z6UH4MbMMm+CPYSdgQozsFgabwgS4zT4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OMJRlayKVif4YbZF9qfw9t+/LZpmyuFR/neasYaN30x+/Uro4/h7gm0L4P9lyLCHp qqxu1PF7g1OZphsraYVBTe2h2BzlfGS9roOjjp0CGJVAz9gaxzXFBSvrI1g6PGu/TA AG53phwplyMHUlFnqmZOzK7SV3q3xudIwDMzm1RJ050OONWzteQf4LsAlt+9Z19pkl KB5knvrBsMnWnHJS7SGYgES1uUDKo/3KrfPU3XKcmPtXVRijp7rwxeJum//6Ef3Mpp xxglyjXdpy51HeLQXm2x28Tt9kDyP5N1YGVcdz03k9pwJEJHXShIqN4J7la3dSu0Jk 4NDIVjwrZmpEA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: [PATCH 3/6] samples/damon/mtier: support boot time enable setup Date: Sun, 6 Jul 2025 12:32:04 -0700 Message-Id: <20250706193207.39810-4-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706193207.39810-1-sj@kernel.org> References: <20250706193207.39810-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If 'enable' parameter of the 'mtier' DAMON sample module is set at boot time via the kernel command line, memory allocation is tried before the slab is initialized. As a result kernel NULL pointer dereference BUG can happen. Fix it by checking the initialization status. Fixes: 82a08bde3cf7 ("samples/damon: implement a DAMON module for memory ti= ering") Cc: stable@vger.kernel.org Signed-off-by: SeongJae Park --- samples/damon/mtier.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c index 97892ade7f31..20c3102242ec 100644 --- a/samples/damon/mtier.c +++ b/samples/damon/mtier.c @@ -157,6 +157,8 @@ static void damon_sample_mtier_stop(void) damon_destroy_ctx(ctxs[1]); } =20 +static bool init_called; + static int damon_sample_mtier_enable_store( const char *val, const struct kernel_param *kp) { @@ -170,6 +172,9 @@ static int damon_sample_mtier_enable_store( if (enable =3D=3D enabled) return 0; =20 + if (!init_called) + return 0; + if (enable) { err =3D damon_sample_mtier_start(); if (err) @@ -182,6 +187,14 @@ static int damon_sample_mtier_enable_store( =20 static int __init damon_sample_mtier_init(void) { + int err =3D 0; + + init_called =3D true; + if (enable) { + err =3D damon_sample_mtier_start(); + if (err) + enable =3D false; + } return 0; } =20 --=20 2.39.5 From nobody Tue Oct 7 21:00:22 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2E4B226D18; Sun, 6 Jul 2025 19:32:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830335; cv=none; b=hB1OgN3zhoqrdJZXRcihaU+9x7sE1ZcXb9iZg+nl9s9ggGCz13igzzqEVRroM/BI0+eiJdOhuxZ3nyrqDck2Vn9yTHd2V5V0Jopu1R8Atp/J87Yo/Z0HJrKIFEFonH2oe2eKZbz9bG3LHW8qKiCGjleLjrecJ0GGhDQNDnb/BQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830335; c=relaxed/simple; bh=iRbDRRBdy920t5w60L/6dOK5zIzjusH9p6xCWRALcoE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ODlwQ7+UXHlXbFcdb7X6EiWwDdHGuyTS49lKqPiPhZUBrfz6JFiHWVYiZjIwWU47yyX1uYu0FETJ+t9DrN0uF4aUn3JQT93stSLpf+xvYklmtf81dI69ZSzvzbCntDr2bCxKBUegTCk1bMsZySwd6QyrArGrESr7ULX4xPJsbZk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pp4Dm5E/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pp4Dm5E/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30C82C4CEEE; Sun, 6 Jul 2025 19:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751830335; bh=iRbDRRBdy920t5w60L/6dOK5zIzjusH9p6xCWRALcoE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pp4Dm5E/nbhA75Wq1v/zugIkgMxTI08nllee9NR2IzqA406U4JCM86QvyqD/RgDiH NTAlxK+UoF9DyvUo+6TJzktytbzYmZZIOVHcTrIXXpDh0zX2uoFXj0X2mQf7IaTclK 8P5qqdBkMJh1qgYphtDK3s8KMLCq39hrAcxHXmthkKumR/2mjCYDD7Fxj/cTi1oXiR jc2Skv/goone3434aiDwZdi19hsdhn8lIn4IcRDmQpYvLdiA+1oGaSUTbNJLzCfZxH q6CzS3d0691f9VzTKI62okfv4qDNNADJZTh8Va+h5I2AihqRmuKVZG0ldf4cNsT8NF fU2g9zh3zIaGA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 4/6] mm/damon/reclaim: reset enabled when DAMON start failed Date: Sun, 6 Jul 2025 12:32:05 -0700 Message-Id: <20250706193207.39810-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706193207.39810-1-sj@kernel.org> References: <20250706193207.39810-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When the startup fails, 'enabled' parameter is not reset. As a result, users show the parameter 'Y' while it is not really working. Fix it by resetting 'enabled' to 'false' when the work is failed. Fixes: 04e98764befa ("mm/damon/reclaim: enable and disable synchronously") Signed-off-by: SeongJae Park --- mm/damon/reclaim.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index a675150965e0..c91098d8aa51 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -329,7 +329,7 @@ static int __init damon_reclaim_init(void) int err =3D damon_modules_new_paddr_ctx_target(&ctx, &target); =20 if (err) - return err; + goto out; =20 ctx->callback.after_wmarks_check =3D damon_reclaim_after_wmarks_check; ctx->callback.after_aggregation =3D damon_reclaim_after_aggregation; @@ -338,6 +338,9 @@ static int __init damon_reclaim_init(void) if (enabled) err =3D damon_reclaim_turn(true); =20 +out: + if (err && enabled) + enabled =3D false; return err; } =20 --=20 2.39.5 From nobody Tue Oct 7 21:00:22 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E3E82BDC32; Sun, 6 Jul 2025 19:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830336; cv=none; b=KSLfNWRyM7PTdbw6Yn3+wa5QeK16JS92w4SkpgNO95ZnjIJTbxPhFsxJmRyEhmeO8SD0bo0PTKzoI15w0D2nfczOPP0s/aNTub5RskqWLVWUH6MpxRY2mq9+5s4qas2yze/wEuexk6SZFKvLgmNgmWCaz/GyUSgJBW+gjoyZZz4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830336; c=relaxed/simple; bh=BX6VH3nU4cicI6oNo09G9KGanoMTvjCG3WQxbqMleEE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tmkcgOLBya5M4G+I0gjsHImQzuLz1bROmJbahuo51PWO0qG8yeTEQIOXSPG6FBkM32k2gOTiq0DNmdZ/00evRVzyCqtLx8mtqbnAUOaOaJyh9U4SeaIbrGEuGjx8wMPmc8ZSDZLVRgQKMvfjym8paVtQH3ZKeu9QdZpl5sm9oCo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A6xH6Ldd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A6xH6Ldd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A1CCC4CEED; Sun, 6 Jul 2025 19:32:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751830336; bh=BX6VH3nU4cicI6oNo09G9KGanoMTvjCG3WQxbqMleEE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A6xH6LddAHfbhNHvwE1DttcsqSYZdbyBn1mryhXPADkEC8ig/ZF+axPAA2AXwhrg7 g0OpHpG5Ekz82QauJzzA1ucDI7H31lcjXxxanhyZ1L7E0FUs0R5IFZqdSLTTxWrtwZ 97x+YOiZHThAP/9fxJ/Buq2KXJ3eoC5a6gLbDBqdU+kiPeJBOVLrFSSotnNo4K1SEr WQUmT8TpfrS+w4XQvkHzjqRCcMrPXKkKzi83j9edkjMYrbrLcQiCWC8XY3V8mFP+eu kF19WeZDtg72x+ZZJBT+CwWUQtL7tstsD1zlSqiKSRPZasBvtvtNnV3V81VN+wKHCX oM7tzV/f1hPVQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 5/6] mm/damon/lru_sort: reset enabled when DAMON start failed Date: Sun, 6 Jul 2025 12:32:06 -0700 Message-Id: <20250706193207.39810-6-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706193207.39810-1-sj@kernel.org> References: <20250706193207.39810-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When the startup fails, 'enabled' parameter is not reset. As a result, users show the parameter 'Y' while it is not really working. Fix it by resetting 'enabled' to 'false' when the work is failed. Fixes: 7a034fbba336 ("mm/damon/lru_sort: enable and disable synchronously") Signed-off-by: SeongJae Park --- mm/damon/lru_sort.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c index 4af8fd4a390b..9bd8a1a115e0 100644 --- a/mm/damon/lru_sort.c +++ b/mm/damon/lru_sort.c @@ -325,7 +325,7 @@ static int __init damon_lru_sort_init(void) int err =3D damon_modules_new_paddr_ctx_target(&ctx, &target); =20 if (err) - return err; + goto out; =20 ctx->callback.after_wmarks_check =3D damon_lru_sort_after_wmarks_check; ctx->callback.after_aggregation =3D damon_lru_sort_after_aggregation; @@ -334,6 +334,9 @@ static int __init damon_lru_sort_init(void) if (enabled) err =3D damon_lru_sort_turn(true); =20 +out: + if (err && enabled) + enabled =3D false; return err; } =20 --=20 2.39.5 From nobody Tue Oct 7 21:00:22 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3B242BE044; Sun, 6 Jul 2025 19:32:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830339; cv=none; b=cloKxzHCuk3TzIS3B1ULnAt3M8jwIgltsao+Okq5fbGn7F+VQA2d++SEh+ZonnTcDKVJSsdowAggKzQSVJXyMXqIrg/miskPs6Z8/s+9L+AfLEOSdxItPl1SbdPyBzpHNDvL/M2cs74XeiTvrr40b0zrO4yTr+MKxuDGcltJBsA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751830339; c=relaxed/simple; bh=WC8o13MdyLXSnn3QYHivVgrcO/OQGT6f7JW9k71JMmU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Sav4oOm65B2XeHBldx6n2y0ZYrCY5XaS90bRD6u/SbfXSE0dkl+I4sGWIhkVMwJGtpRrzq8qA4y7e5E5O53hBpNlS40ylWhFTT+nmmqLI8woGZoWqQkuCCE5efoVc8ICMA33jwkmiFPNGN7RlEQYFnD1Jm6h2QkcgJaBlXkwoIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XTcsFcHe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XTcsFcHe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E2E3C4CEED; Sun, 6 Jul 2025 19:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751830337; bh=WC8o13MdyLXSnn3QYHivVgrcO/OQGT6f7JW9k71JMmU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XTcsFcHeGBuTCVMgzEV9IqQPrvIQNoUIc1770mFyAGnibmeRz3G0wR7UntkY9x2Rq nwSSP2k5J6zU14YCzE2GNp0ayirLuKwHy+/4bwPdxlh6gIA8QvnyEnThFJZXERj8JX /V/AzzM0jIsNwj7VKMX8s8AMUpG5+SbhepCeD7yO9vtE4D8QaC/G0p/pmkq0rzeet0 a+9Gi7Dl+dKKBCxQ1THkmtzs7Hn4yI7kMipkJWNXRKF8iEbFJRDkgwlhijWK+xww1v NfOqrtNlvNPRcFcgm2G7QFW9G7FaQt90kms3kictnzG0V1eKkxyrogDDRJJHFoYE1D m6qFX/phjWiQg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 6/6] mm/damon/reclaim: use parameter context correctly Date: Sun, 6 Jul 2025 12:32:07 -0700 Message-Id: <20250706193207.39810-7-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706193207.39810-1-sj@kernel.org> References: <20250706193207.39810-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" damon_reclaim_apply_parameters() allocates a new DAMON context, stages user-specified DAMON parameters on it, and commits to running DAMON context at once, using damon_commit_ctx(). The code is mistakenly over-writing the monitoring attributes and the reclaim scheme on the running context. It is not causing a real problem for monitoring attributes, but the scheme overwriting can remove scheme's internal status such as charged quota. Fix the wrong use of the parameter context. Fixes: 11ddcfc257a3 ("mm/damon/reclaim: use damon_commit_ctx()") Signed-off-by: SeongJae Park --- mm/damon/reclaim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index c91098d8aa51..0fe8996328b8 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -194,7 +194,7 @@ static int damon_reclaim_apply_parameters(void) if (err) return err; =20 - err =3D damon_set_attrs(ctx, &damon_reclaim_mon_attrs); + err =3D damon_set_attrs(param_ctx, &damon_reclaim_mon_attrs); if (err) goto out; =20 @@ -202,7 +202,7 @@ static int damon_reclaim_apply_parameters(void) scheme =3D damon_reclaim_new_scheme(); if (!scheme) goto out; - damon_set_schemes(ctx, &scheme, 1); + damon_set_schemes(param_ctx, &scheme, 1); =20 if (quota_mem_pressure_us) { goal =3D damos_new_quota_goal(DAMOS_QUOTA_SOME_MEM_PSI_US, --=20 2.39.5