From nobody Tue Oct 7 22:39:01 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06C2020B1FC for ; Sun, 6 Jul 2025 10:50:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751799053; cv=none; b=fgTiKH+ny4wJCmNh0iekLopX2UXAGOwnBKlIm300iJpzQsOwDTfCoHfsidqhrfEmvfSu/kjgHPN19b6vaTY7fNZDTB5lEL3GdhC5t421ozTPm69iPqhBo7AZcz0SnQEmPf+NpOnbOlKorYEDmXVL98rpwg/Db1N942HeNaUQlO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751799053; c=relaxed/simple; bh=EUOM9GC2j9wX5WPerbms/C/z2nxGawxsehEkeu7mMVA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z1L6Gc6nYPp0P6zP7H/KPEXUx9DX3jCQDjBzJdphkvQ6ECd5YaOatOrojhcunj5ZtpMPd0OhKTQ3PokXjWt73uty1qzDjVNq1n082EfH3AY28s6cbli5ONiATB+V3JrnRDI3Vp+rZxkvthwLlCK3zpZ+rThL8WxmUjmhPeVfbOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fHKp6e+E; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fHKp6e+E" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 566AdRRv012747 for ; Sun, 6 Jul 2025 10:50:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8nwUz2+wfrG4Z9KqAAvjHu9al6EBZNSbjiTXJPQqpbE=; b=fHKp6e+E5wKL979D UnR1gN6ha9yFki6avKH/Fsri4APqx5kmjffLbIKqaSvrmfwanadRDoBT/Dt04oRq oMb6VxACsRFOktD2jkvuhypBnIJDDdohgkRBZ+aVx1C/XNZqg5Kk/cwaY+LmvxFI IwhpvbW0QpNqyl69fdMMeI1d+NxstMa8HstENuZo7CZkNVgYkVDmuSY9NZQSJHTY sYvjUhM1ylooZMp9AxAYU59qFI7k9oXduZTox3UVPLYC77yznQpJXnZCVlHFmvjE Xe52J4UPbyMmDgGoqHZPer9ZNQhqvJ/I+g2Ayh9AAatPB6NuconL3cE6fY63t0E1 WzLm3g== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47pu0vukg8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 06 Jul 2025 10:50:51 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5e2872e57so353480085a.0 for ; Sun, 06 Jul 2025 03:50:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751799050; x=1752403850; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8nwUz2+wfrG4Z9KqAAvjHu9al6EBZNSbjiTXJPQqpbE=; b=Xulus43aMuBFGPGQl8rd/vFY35vOiLEKP1mKT3h+Zj8eO6qhWu5irM9ATT2341kFS0 FGehltqCcl+qB/+SrvBhUj1hb8v2utvm/scZdtESJLq2bJm6yRxZObI7y5d3QV5Tkw8x AWmq91ak7UJB224j7Bi003vTgcDpJI9T+4EhqXG118dckjyafdhFkmqUWgU/uMO34ols 9X1KZj/gAOglx0lIiihXO7or8qrWn8tWBIohQ+3fn1iZEvQy8ccRW6d21EfmpIeh2NEY t8qB3HfUST5ua5DTB2fCTKQKkXkJ+vv08+ya6wfS4YoLfBPBsXK9s2NJ5iCGfptppwYD UeTg== X-Forwarded-Encrypted: i=1; AJvYcCUMQaNEzc3GYNaoAvRjdfjymXCmSIldAylNhpE1y7YeOm48kKLEaH1lZuAVk9qj06+0+iFAqfvxawFbgIk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0kAnefOnDvlffCJSUDTw79QcH8/CQiB4/pWqHwvOpdNMR5Mvx 5YpcJX5T+6JswwXYuVS5HhNfL9rt2WxF7dMLqHUVUUq1s5zwYeJ+JjSX/LbTfB1LKiOdW8xFEaL BURlKRBV+xfWUTiDv2yu7fY7kC1TGTcf4pk4N051emnxmDkGaADGYlzENZmK3faxT1iw= X-Gm-Gg: ASbGncs+K0zanWPGgla1DOV/lhRJIcqBGgrKv8au1wu678Lcwc2rG1s5I8/GMwb18JU 2Usfi3FiRWpzjLA8Wq8BzRBZb/zvRuODrSs6zuskigTBeNuXobUk/d9NZDG/MpMmq6CanLKLE9y YImf0lTuzrWgTgBLcjVQ4lirFjVbEO6BsreWPSZmU7V25l2mAPAxJ3v8mLWb+U27U8Ux7Gk7Eo/ pcACmPuvuIG7BGjOr7w2tNsKG17Tj75QqrGbBtDdfIHVfEN+0MWWcnFFsBi7WMciQbGrQDnjj+S mwR+IMAvhkVIHDuA61hVTqEZH6KCgOZTxEhycXfmxkHL8OnG65KcMxpvWMwWJKPFQ8zzmyucW0g TTO1qymVRRkVVe238c4Es9oQ3RPvbGLkyVgc= X-Received: by 2002:a05:620a:4396:b0:7d5:d018:1bf6 with SMTP id af79cd13be357-7d5df119e79mr1104797785a.14.1751799049937; Sun, 06 Jul 2025 03:50:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGnbXcyMALNSAIMrbcV1bErIvj9gLgHlW+lpPLzxeJcvFUcUsGsOmoX7j1K8yEeXnyxMSvpeQ== X-Received: by 2002:a05:620a:4396:b0:7d5:d018:1bf6 with SMTP id af79cd13be357-7d5df119e79mr1104795385a.14.1751799049538; Sun, 06 Jul 2025 03:50:49 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-556383bb555sm920621e87.20.2025.07.06.03.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 03:50:48 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 06 Jul 2025 13:50:38 +0300 Subject: [PATCH 3/3] drm/msm/mdp4: use msm_kms_init_vm() instead of duplicating it Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250706-msm-no-iommu-v1-3-9e8274b30c33@oss.qualcomm.com> References: <20250706-msm-no-iommu-v1-0-9e8274b30c33@oss.qualcomm.com> In-Reply-To: <20250706-msm-no-iommu-v1-0-9e8274b30c33@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2046; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=EUOM9GC2j9wX5WPerbms/C/z2nxGawxsehEkeu7mMVA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBoalUC3CxjmG2qO1jRWXx5gPkOE/BU/KfOLjFAd 21zJFA0vaaJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaGpVAgAKCRCLPIo+Aiko 1bLnB/9zMeuT+8VKzUaMNF0llrx3m3vtO2VrQ+Z5tjOtNMvw7pklBRfaSZrOrQEXcY8eVpcTjkZ byftNEf0tObHUHcrk2nwEsjJ5+F3HmLK9Iu2uR0cPW7nbMm4Pzu3foT+1K83LKrNYBvj4kWnMI7 rkyeAiI7yqTKGAPFvV7Wp9JfzNqLUFxs1FL9FoZG6qaYtfxuWbyAlDYr0pK6ZkejjH8nb9JhLqI cBOweeTjQaTa2ltWjkv+vKbJxvLiHo2Ta49zkUdZ4EA3OBtbrDnVZgXc8aw1ISv1M5h0gQeczmZ /0NvYh4t+H2gxp1SabuYOj+1Hzfoqm0JF6ysG3FDegD10Kd8 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: B7DcSn1swejwP_-U858pIfzASI_o90s5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA2MDA2NyBTYWx0ZWRfX9DOJQQ3bBccR vSu5ODfu7qOR87Jtcqr9+ZT2z9NZAU8JNjRmP8B9a1PS7cZ7eITFRAk+d+0L0H6YVfhsdLp3XPz EWgHb4epqXLkYneFeE+oIjvqHg22djLayP0Le2dOet7OMKwg2i5bXroDbzD8zl2dODtnVJZlZXo RBsSRWB58AyA5alQuiFU0MXr6HYXNasr5+JHgg0lDiujHwIyK5lGM6aVNvQd4zlhjBOT4V4OOKj FJ0HXBoTApNIIS9as0KhzNbGAeKpNAAItzS/votYhqaztgCbgWmaTABH7HD24ahW+ON3x4A+XIg dkZZZ8NZKHI35synsCyK1S0EE+NPH6xyHCXY2cFUTbD8KEzDuIWOdHQ1v6oU81l6k739LZk2KNq GDdw2L2IhpHuCCen2AOSThMTcyGTMlxAHXcG5ot80BhKsC0nrSS4cmFeCBUEpqEY1D51NcFB X-Authority-Analysis: v=2.4 cv=Rd2QC0tv c=1 sm=1 tr=0 ts=686a550b cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=OZ-Rx8C-MikYIJhCyHkA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: B7DcSn1swejwP_-U858pIfzASI_o90s5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-04_07,2025-07-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507060067 Use the msm_kms_init_vm() function to allocate memory manager instead of hand-coding a copy of it. Although MDP4 platforms don't have MDSS device, it's still safe to use the function as all MDP4 devices have IOMMU and the parent of the MDP4 is the root SoC device. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 27 +++++---------------------- 1 file changed, 5 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm= /disp/mdp4/mdp4_kms.c index 88296c41d1a5eb0e16cb6ec4d0475000b6318c4e..41d236d30e71ebb6ac8a5905252= 9f36fadf15cd7 100644 --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c @@ -391,11 +391,9 @@ static void read_mdp_hw_revision(struct mdp4_kms *mdp4= _kms, =20 static int mdp4_kms_init(struct drm_device *dev) { - struct platform_device *pdev =3D to_platform_device(dev->dev); struct msm_drm_private *priv =3D dev->dev_private; struct mdp4_kms *mdp4_kms =3D to_mdp4_kms(to_mdp_kms(priv->kms)); struct msm_kms *kms =3D NULL; - struct msm_mmu *mmu; struct drm_gpuvm *vm; int ret; u32 major, minor; @@ -458,29 +456,14 @@ static int mdp4_kms_init(struct drm_device *dev) mdp4_disable(mdp4_kms); mdelay(16); =20 - mmu =3D msm_iommu_new(&pdev->dev, 0); - if (IS_ERR(mmu)) { - ret =3D PTR_ERR(mmu); + vm =3D msm_kms_init_vm(mdp4_kms->dev); + if (IS_ERR(vm)) { + ret =3D PTR_ERR(vm); goto fail; - } else if (!mmu) { - DRM_DEV_INFO(dev->dev, "no IOMMU configuration is no longer supported\n"= ); - ret =3D -ENODEV; - goto fail; - } else { - vm =3D msm_gem_vm_create(dev, mmu, "mdp4", - 0x1000, 0x100000000 - 0x1000, - true); - - if (IS_ERR(vm)) { - if (!IS_ERR(mmu)) - mmu->funcs->destroy(mmu); - ret =3D PTR_ERR(vm); - goto fail; - } - - kms->vm =3D vm; } =20 + kms->vm =3D vm; + ret =3D modeset_init(mdp4_kms); if (ret) { DRM_DEV_ERROR(dev->dev, "modeset_init failed: %d\n", ret); --=20 2.39.5