From nobody Tue Oct 7 21:02:20 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 982161FFC77 for ; Sun, 6 Jul 2025 10:50:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751799048; cv=none; b=NM7IoNw5Nj7Qk67PRvgVQZXU4EVnbYhxVfD3NAFAonbkhdrQtDXNc7Xse74V1u08XEeRBRTtT0jh9S+1Z66j9xT51hcsc9uY57cj+HENGyjeHcIgiee5o8PrWdj7crwFZkTOPKS/j07HUuWrvu5gPhUE0hUkMPK6ex6p1lfv0dM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751799048; c=relaxed/simple; bh=N1V1r2a+Uu111oA5aVLPWmTma/v7zxodScONBUW8ukI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wavq/8+qlGZ1uWhA0lHSWwKtLLHKjPCRZjo9N6v0hPEa06/golVt/q7XSTCUudLMdnoNcQQzWYjZD1gbqjwSlBmELHeqNdPpD2pVF+s9a2wRpcZgMbtFoTYzx7hWVD33ou6I1xIKw6aUUwSYYQE9TwXyFQky3vNnEG+EEak5AgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=goY77ZMh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="goY77ZMh" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 566AW4eW023340 for ; Sun, 6 Jul 2025 10:50:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TXj2kLxWlavFfODBCwO4C0ty0sy70kRk1f8+2FzBiKk=; b=goY77ZMh7wpYl4CD 97r0d25IbvAKRjshLAnj/gebj0p7V0ciNSu2pJKCR7nZ5W2rnw7vU8x2pcT8TWMr WreXaFnLMszLfn6FJrz3ISm2wYOz3qlwyCIDLOK+wtwm9k1sgmngyxnegxB72q9Q cUH59uIqnc2DBCLcXsmdxQNVom040/8Yj/PritiKPxk+LbHNxcP3vWnEBH4aONrt mEEccjWRn3JMMfC2csJclEHKVPurYmRsLCW43jaGhuEhH1awuHbXddPRcnmucP6d o8383lK+NTs5/RSKWMuSX0recRtg01/A2II/03Lr1TjjfmZVSLKfFUcRM92Rdvns PtCYMw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47psrk3mkq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 06 Jul 2025 10:50:46 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7d460764849so559485285a.1 for ; Sun, 06 Jul 2025 03:50:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751799045; x=1752403845; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TXj2kLxWlavFfODBCwO4C0ty0sy70kRk1f8+2FzBiKk=; b=WqJ9QYYSapPcxqyAK7J5FFMTrL+jiXLqiuiOxH3qNRg57GUYB/aYmI71Hiibshc4c7 jc9lGBWa2X8MXvrIwYXKADsN/rIHuLJL17uVoxHhQKWQdb4weNboNlxcL+ZJW1h1nTcJ 2K8II0fhN2HJCVWRVmt9XxNaYuPw/LdowFRkLX5Fnxl0/2OeniwIrxdDQPLwUp5LT44F /F6lMueXoDqZrDQG2Oas9etE31zfQyhraDkzZZavPyeINR8Ygv+g+jcTf4eI5L98kH82 EHc6r+iIZhQjyONYpMZGH1Fkwwqps5woZcLDOs9wNQCD8xexCwA3QAN6AYSWuEmo6NF9 fQRA== X-Forwarded-Encrypted: i=1; AJvYcCWK06aEjauPj0P9xkK3gOH3st4nz0c8ja/ISjF5ZL9v3m3YN0ARpbGsUROtDjM+03bjCcPPoF0LwHxU6a4=@vger.kernel.org X-Gm-Message-State: AOJu0YyqN5TbeSjaCBRxFfkKIsTQrXCBbzf9vWWoOba72CsaH1UfZmSa EyKzJVMBDdOEsP+uh0kRNMpWBgA7sbqmAiR8j7PkvHnZo2O38otIvYuNpF2bW8jyX3DPjvmb3OO XCWnuMYSmYr1KKkN+gem0Rfj+nm7ayq9orP/dPZ63Gv+J0uaOcKvYSzP3818HP2g5bbIt6iYzIN w9UA== X-Gm-Gg: ASbGncu5qCJQcylPtRlRXURIVgSLnDDG56Qzo1MRmA9tNWilhc9vF/WQ8365yw9oMMQ kTeFokcTJfv5KHlp/xOWeuGosPBdtMwVQEa6jWzDS0D0Y6hTYUxdnh4TGH0y1vtrcuLxog+crvV V++XqgkatL2wSvLqiVdJygvuFCMu4PtUC1X051An+3WEP11+H2UurY6VIHb02CBjd7UrL5PkGDM Q/n88msmV9fyppMokNIVZujbZYmEM+g+Vpg1fFuxs75GhEZJ3amEJ2ULe3SL2YoOG/nOuzhImix MiStKs6qdxay/pjpic/iZUCK8/8FL2S9+ba2Gy5dOqv5UU5tZonjn4/a9WugqB/8iHkXBLUnUsE RG0ExXT0kRMSxXC6CHolbyU6NuMmh8SlWp0k= X-Received: by 2002:a05:620a:6289:b0:7c5:95e6:62c9 with SMTP id af79cd13be357-7d5dcd47e14mr1035827085a.29.1751799045107; Sun, 06 Jul 2025 03:50:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENzyvjnnPNU0+auiROsO8L9tJv+5rcHPjjuz97ShcVFzt8dFEs20zG+8sIADzQBxRqDaUTUA== X-Received: by 2002:a05:620a:6289:b0:7c5:95e6:62c9 with SMTP id af79cd13be357-7d5dcd47e14mr1035824685a.29.1751799044764; Sun, 06 Jul 2025 03:50:44 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-556383bb555sm920621e87.20.2025.07.06.03.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 03:50:43 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 06 Jul 2025 13:50:36 +0300 Subject: [PATCH 1/3] drm/msm/mdp4: stop supporting no-IOMMU configuration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250706-msm-no-iommu-v1-1-9e8274b30c33@oss.qualcomm.com> References: <20250706-msm-no-iommu-v1-0-9e8274b30c33@oss.qualcomm.com> In-Reply-To: <20250706-msm-no-iommu-v1-0-9e8274b30c33@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1188; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=N1V1r2a+Uu111oA5aVLPWmTma/v7zxodScONBUW8ukI=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBoalUBQahHAv2TwvvVK6FFPuXM20VbAQOAG8788 ssuEBgbNNGJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaGpVAQAKCRCLPIo+Aiko 1f0mB/9PUKhWISZlHBDACtU3YF/1alKgkRr5n3JHsdRqlQeuTcv7GtWeTdbBgfcxxcR1qnFRZwd +o40ttKKbXMaTPm3hfz9nSbot1W+caMuNXSLtZUzk2tDECCK0EGsPk5UrRHzVOV9RGR8fWK0Gqo GW9m7ZEIJOJqOPXtzaXSeF9DBgHtbWr4mvxSvipVlRBUgJzUCQ8rmNdkpcvdwB/LWtX+d9OSdGD XuiYccV7R44JUN6RSc6EhjfQM953FfA9QFRMvrTSqbYhpy+DrYQyOGQm+MvMJmU45x+ofhnueYa 6rrDlr4nMhqujzT8V2Zrk7tqCMpl4zFHJMRZGA/hBUIxxDMa X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: Vufs0_OWMSwaw-EHB8eVN5ZmWlgJzKjW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA2MDA2NyBTYWx0ZWRfX7hx0IHU7bhr/ y/RThGclFTZI8koBcmTksExRcIVK2LGGEFII+EHHDVptjbRvvkvoxaPcm15D/J+qsJAOyKCBdim cbDQJw2Oe0N/CScDUQS3PsYhmpoH5RjbKuqhqqoXxDV79d+eyTm4mjREdC7viVADNHsXsnhCQXm 7HAIREwK87/yDuuyTC2Ub3Jg2m11f4C6uknloe6f8YGFTP8EP31RTnA+zS6ZtuxpuDYPFil3+AF opJUprtPG5TTvKWbC76aRBK/SADPbgQblR5Kdc2hYK83phqvRAvye41GvkHKiJkxmm1JFV2QnhM s10YKHAQF9A7q5QGihmlYaFPrM/D5EoQctdq3DNuLn/qArc4RZO+OmIlwZ3fptke2o8WMtPVcLV FC3aEd0sp7SErCgMQcsXtXn1NoDKAD3sfQRoaBD9KDwkg1qAourwDqORWSWUygx/LqbsyHE6 X-Proofpoint-GUID: Vufs0_OWMSwaw-EHB8eVN5ZmWlgJzKjW X-Authority-Analysis: v=2.4 cv=GtBC+l1C c=1 sm=1 tr=0 ts=686a5506 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=0pe4r8NFi1m0JDAohsgA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-04_07,2025-07-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 spamscore=0 adultscore=0 phishscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 suspectscore=0 impostorscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507060067 With the switch to GPUVM the msm driver no longer supports the no-IOMMU configurations (even without the actual GPU). Return an error in case we face the lack of the IOMMU for an MDP4 device. Fixes: 111fdd2198e6 ("drm/msm: drm_gpuvm conversion") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm= /disp/mdp4/mdp4_kms.c index 0952c7f18abdca4a7e24e5af8a7132456bfec129..88296c41d1a5eb0e16cb6ec4d04= 75000b6318c4e 100644 --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c @@ -463,9 +463,9 @@ static int mdp4_kms_init(struct drm_device *dev) ret =3D PTR_ERR(mmu); goto fail; } else if (!mmu) { - DRM_DEV_INFO(dev->dev, "no iommu, fallback to phys " - "contig buffers for scanout\n"); - vm =3D NULL; + DRM_DEV_INFO(dev->dev, "no IOMMU configuration is no longer supported\n"= ); + ret =3D -ENODEV; + goto fail; } else { vm =3D msm_gem_vm_create(dev, mmu, "mdp4", 0x1000, 0x100000000 - 0x1000, --=20 2.39.5 From nobody Tue Oct 7 21:02:20 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AB14205E2F for ; Sun, 6 Jul 2025 10:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751799051; cv=none; b=rVQMiec4RS5LWM80xx1IU6aLWFRVyfTWUlMwQvZBNx9iDnxAM8sRpYKO10Z7GbTNxFPsod59hz972IoKDEnQm/P4xKOCaPRgDvd35iY2BlwHu9BHStwDuVRSvljuky1M4kYKel3K7IRQ4eyk394YBlsOB6PzTRsElhE52xRKh0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751799051; c=relaxed/simple; bh=CVAxMJ583rYEGC1+K/sUzP+WPoNKZGaqzP5oZqg2sAw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CwcdC5wFry13nYj6ob+B8u5NZYbX0jf1una9ebPciK3d11sS8QWialfslZJ6Bi4/34FDkRqT9h9O+8pTSBYjzkWBWGmz2G0AfnKxpPZxHcXO5YnV6Ma0hmWRNfYT96kVb44PKqQWCjr5mvxCYyknxB4hQVW2SV1k5WlH5eZkpUU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z9HJKwee; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z9HJKwee" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5665M3Hg026655 for ; Sun, 6 Jul 2025 10:50:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gQwF7BjTXtg7965OybbDmRj0hZykpVfXE58N/V76Bys=; b=Z9HJKwee5TLv50Zw jjBRKSb+twj3ZK0Kls/ivOxeaVRfH3rRcJT59qXJXEvXLfoqGKhRGYEuHZumMNqt diUZwR3TASXONH00f5XJ8l1LvHs+jiAJvJ/h1U/hNbriShmnWHo0WF/Zkc7nWrh+ cpnGOHZT1SkVzYLnmq21We2O6Uo35xeulz0PbAeqj4x+DPZedtyEovdNT8B4Nv6P XIjcUnu0qKcXJUr8CYzHNQXQhCIkFUBv8dLvF1e0MZQ7+xgbyTfow9aF5+DSFRVW 08+LEt6o7lSF3EXVGbJn3Kpey/9iAtYwWb8wxnjbpbaWtfR4QIRqEZTInWBCIoBL tqq+Sw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47pw7q3d4x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 06 Jul 2025 10:50:49 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7d38fe2eff2so323942385a.2 for ; Sun, 06 Jul 2025 03:50:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751799048; x=1752403848; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gQwF7BjTXtg7965OybbDmRj0hZykpVfXE58N/V76Bys=; b=o4RHG7d8IcjbXOj5UD7sV5QWBheQGBLDBAmPp6DaVFqLh/W6YnKP6as6/zTgGLJfTI xuW0AHD3M7Zk4gBQsAHvlMWEXIpfxZ6bduaukMRjtgwhFlFETzNWH0fv24zL1VY/XA96 HKj7IQOexb5xtlHpNTUUIDbwUzHLpeoBkgiQ7ADKStRYxUaSQsvP/PRsHIN6qB4v2Sdx +dJKc/4ihglr1PTBmxR5g2xWYbfkcHZ7AVr8U6S5ail5fyHDHZV5vyIMLfCcWZpir0e0 e0f4w230S0zfXBL0JX/ujT60yPl8/74S2WpreNT/J97LlFXy0dSxve1Y3BTTH83GFNXV v09Q== X-Forwarded-Encrypted: i=1; AJvYcCW+ikJegExikEXJyBtmJ6Y3GA+2lk/oenZtFyMYn11FTGdOKYiAzXPH+/rn4EzRLOwv+Ut0bvne6cxz7Cg=@vger.kernel.org X-Gm-Message-State: AOJu0YyImhX2vXWcYk/R3vdZZ4khjxWdSbx8dywkdYNQUpQlHLmQ9woT sFtYNGKn/sG3OHTxfiW15+d9rJyoooTCTCMbGvWOtdGPpsbTc2L7M30Rc9oTwOhXpbOUuvcj+Nj YqZNmGJzCstEPWUPfuAThZzjKD8iK1JIUrwWoPg32jaml303nN/yFvozoi1DBrNc/MLo= X-Gm-Gg: ASbGncsYhcVxVbkfC93IuD4Lti/5FCVP5uTXDc0tUg+oCVPhYlAkfYXpJ/hcIHlzb4D B7g/25jmZw7lzCo29M7k10jd937iNUdiyMbcMJaF6E7/HzwgbCC3zC491KFty+cdrNy+qfOjo02 zqdtJrr8zKzfm7Sr6sBJ+7TLYszmXTpf4A5dYhlmgaiW9VkPDxhPn6pLrVPqEa37CRejfb9sDJK bc3vZLjWom1t6p1TDMmlZbHeei+H0CmPQI8ruZeLTpOl3BUD/n5epm4OZerTD3c/Q+UycrnCe++ XAG0/jRxJPC9F7yiWboRW6cstqHni5exsjHMuBuxs1DM7G4YchzTv3YRsANUYFpIL7bG3xuRmmO tfw3zSTT2NoN0O6l1CXQhp55L35LlsKN8+Jo= X-Received: by 2002:a05:620a:7014:b0:7d4:53d4:578d with SMTP id af79cd13be357-7d5f10fa22fmr697622985a.36.1751799047553; Sun, 06 Jul 2025 03:50:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtyZ9ucK7jsORVaYGW7av0WIAu76YoLf2T3keQ5iRHn3mdAtAO4h06LyQ2I0lncFhsncDHXw== X-Received: by 2002:a05:620a:7014:b0:7d4:53d4:578d with SMTP id af79cd13be357-7d5f10fa22fmr697620385a.36.1751799047134; Sun, 06 Jul 2025 03:50:47 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-556383bb555sm920621e87.20.2025.07.06.03.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 03:50:46 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 06 Jul 2025 13:50:37 +0300 Subject: [PATCH 2/3] drm/msm: stop supporting no-IOMMU configuration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250706-msm-no-iommu-v1-2-9e8274b30c33@oss.qualcomm.com> References: <20250706-msm-no-iommu-v1-0-9e8274b30c33@oss.qualcomm.com> In-Reply-To: <20250706-msm-no-iommu-v1-0-9e8274b30c33@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1053; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=CVAxMJ583rYEGC1+K/sUzP+WPoNKZGaqzP5oZqg2sAw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBoalUB1+xuuKCza8FRxLDaIpuk4/9nNPUhbOJSM jVRNJAo8N6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaGpVAQAKCRCLPIo+Aiko 1UkMB/9kTumwrySnCjd4VSt41UeB4BUW/u21VLeSik9PtHt1VuBLn6bQIhc2174IcmTnc1lQ0PQ SP8DPvssNDhjdb25NISWlpA22w5hYNeZnoBcwZ1hspvX01vSaHDyavJXQWSsfQAruHog8hEMsjY K+USDp5d+IN6DrP0nM3EJ6/beHJ6aDOyRiM3l9A5IXL7B3Xhe1LS20yXeokJ4aICVQf1vyfzSyC cvagS7NZpMysbO+OeFMjwPvp+N1nXsYGzKCR4R7UKBWs9QeyB/5afJLgsMOCBq9wNURns5Pz2od UJXe5YkdA+va3Df2WP+dyqGhfFsDNpcvDBspBEq4LKD/SDGD X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA2MDA2NyBTYWx0ZWRfX1/6pvuR9D+iy jNN0Czi4HVKGrkQ4umUJFkHj5QyEZtqsmpF54by8g8sAgFHfaO2k3g8P1jcnI1RQqHIiUQ1DNtm yiAVqg6cmpGDrTw6hhNihm4cok/IuMxMtByviJ7MrAVJGhu8WEYBuI/i0YK+oPB/lyld/WtLHjL E4unqLuijJAn6bkcbADzatnarhfxSNkpozSB3XNsY0epHqydCm5jpqru0IGrzAQxW3VhnMEzYa/ To/6RedXRmkS691rJyARgdCl7smpOQlCdNz5RA3yr7JrML/RLywSQ24MMnT5zK9y8a7YVZ7hHeJ Hrc4dfAuSErmOQyB6woU/ZZrrXk0m0WuU20XEYD88BcjFFVHKKWPG0rJUdak2jirYGyjzRZ144i tYG70dQDB/1ULwNDZiEyaYLV2UQJwKBiEuJzJXVWSMB5ls8MiO6F/IuD5kPTBGjyI4Tae0Ze X-Proofpoint-GUID: E12oofb-dPzw9_Hks62yeHJyfEzsJjrL X-Proofpoint-ORIG-GUID: E12oofb-dPzw9_Hks62yeHJyfEzsJjrL X-Authority-Analysis: v=2.4 cv=SOBCVPvH c=1 sm=1 tr=0 ts=686a5509 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=bqLZAy-zUTJ7f3hpqcwA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-04_07,2025-07-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 mlxlogscore=999 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 suspectscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507060067 With the switch to GPUVM the msm driver no longer supports the no-IOMMU configurations (even without the actual GPU). Return an error in case we face the lack of the IOMMU for an MDP4 device. Fixes: 111fdd2198e6 ("drm/msm: drm_gpuvm conversion") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_kms.c b/drivers/gpu/drm/msm/msm_kms.c index 6889f1c1e72121dcc735fa460ea04cdab11c6705..2e2ab93b0f6f6a462e99d54b33d= a6dc21b1e8435 100644 --- a/drivers/gpu/drm/msm/msm_kms.c +++ b/drivers/gpu/drm/msm/msm_kms.c @@ -201,8 +201,8 @@ struct drm_gpuvm *msm_kms_init_vm(struct drm_device *de= v) return ERR_CAST(mmu); =20 if (!mmu) { - drm_info(dev, "no IOMMU, fallback to phys contig buffers for scanout\n"); - return NULL; + drm_info(dev, "no IOMMU configuration is no longer supported\n"); + return ERR_PTR(-ENODEV); } =20 vm =3D msm_gem_vm_create(dev, mmu, "mdp_kms", --=20 2.39.5 From nobody Tue Oct 7 21:02:20 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06C2020B1FC for ; Sun, 6 Jul 2025 10:50:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751799053; cv=none; b=fgTiKH+ny4wJCmNh0iekLopX2UXAGOwnBKlIm300iJpzQsOwDTfCoHfsidqhrfEmvfSu/kjgHPN19b6vaTY7fNZDTB5lEL3GdhC5t421ozTPm69iPqhBo7AZcz0SnQEmPf+NpOnbOlKorYEDmXVL98rpwg/Db1N942HeNaUQlO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751799053; c=relaxed/simple; bh=EUOM9GC2j9wX5WPerbms/C/z2nxGawxsehEkeu7mMVA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z1L6Gc6nYPp0P6zP7H/KPEXUx9DX3jCQDjBzJdphkvQ6ECd5YaOatOrojhcunj5ZtpMPd0OhKTQ3PokXjWt73uty1qzDjVNq1n082EfH3AY28s6cbli5ONiATB+V3JrnRDI3Vp+rZxkvthwLlCK3zpZ+rThL8WxmUjmhPeVfbOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fHKp6e+E; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fHKp6e+E" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 566AdRRv012747 for ; Sun, 6 Jul 2025 10:50:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8nwUz2+wfrG4Z9KqAAvjHu9al6EBZNSbjiTXJPQqpbE=; b=fHKp6e+E5wKL979D UnR1gN6ha9yFki6avKH/Fsri4APqx5kmjffLbIKqaSvrmfwanadRDoBT/Dt04oRq oMb6VxACsRFOktD2jkvuhypBnIJDDdohgkRBZ+aVx1C/XNZqg5Kk/cwaY+LmvxFI IwhpvbW0QpNqyl69fdMMeI1d+NxstMa8HstENuZo7CZkNVgYkVDmuSY9NZQSJHTY sYvjUhM1ylooZMp9AxAYU59qFI7k9oXduZTox3UVPLYC77yznQpJXnZCVlHFmvjE Xe52J4UPbyMmDgGoqHZPer9ZNQhqvJ/I+g2Ayh9AAatPB6NuconL3cE6fY63t0E1 WzLm3g== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47pu0vukg8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 06 Jul 2025 10:50:51 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5e2872e57so353480085a.0 for ; Sun, 06 Jul 2025 03:50:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751799050; x=1752403850; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8nwUz2+wfrG4Z9KqAAvjHu9al6EBZNSbjiTXJPQqpbE=; b=Xulus43aMuBFGPGQl8rd/vFY35vOiLEKP1mKT3h+Zj8eO6qhWu5irM9ATT2341kFS0 FGehltqCcl+qB/+SrvBhUj1hb8v2utvm/scZdtESJLq2bJm6yRxZObI7y5d3QV5Tkw8x AWmq91ak7UJB224j7Bi003vTgcDpJI9T+4EhqXG118dckjyafdhFkmqUWgU/uMO34ols 9X1KZj/gAOglx0lIiihXO7or8qrWn8tWBIohQ+3fn1iZEvQy8ccRW6d21EfmpIeh2NEY t8qB3HfUST5ua5DTB2fCTKQKkXkJ+vv08+ya6wfS4YoLfBPBsXK9s2NJ5iCGfptppwYD UeTg== X-Forwarded-Encrypted: i=1; AJvYcCUMQaNEzc3GYNaoAvRjdfjymXCmSIldAylNhpE1y7YeOm48kKLEaH1lZuAVk9qj06+0+iFAqfvxawFbgIk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0kAnefOnDvlffCJSUDTw79QcH8/CQiB4/pWqHwvOpdNMR5Mvx 5YpcJX5T+6JswwXYuVS5HhNfL9rt2WxF7dMLqHUVUUq1s5zwYeJ+JjSX/LbTfB1LKiOdW8xFEaL BURlKRBV+xfWUTiDv2yu7fY7kC1TGTcf4pk4N051emnxmDkGaADGYlzENZmK3faxT1iw= X-Gm-Gg: ASbGncs+K0zanWPGgla1DOV/lhRJIcqBGgrKv8au1wu678Lcwc2rG1s5I8/GMwb18JU 2Usfi3FiRWpzjLA8Wq8BzRBZb/zvRuODrSs6zuskigTBeNuXobUk/d9NZDG/MpMmq6CanLKLE9y YImf0lTuzrWgTgBLcjVQ4lirFjVbEO6BsreWPSZmU7V25l2mAPAxJ3v8mLWb+U27U8Ux7Gk7Eo/ pcACmPuvuIG7BGjOr7w2tNsKG17Tj75QqrGbBtDdfIHVfEN+0MWWcnFFsBi7WMciQbGrQDnjj+S mwR+IMAvhkVIHDuA61hVTqEZH6KCgOZTxEhycXfmxkHL8OnG65KcMxpvWMwWJKPFQ8zzmyucW0g TTO1qymVRRkVVe238c4Es9oQ3RPvbGLkyVgc= X-Received: by 2002:a05:620a:4396:b0:7d5:d018:1bf6 with SMTP id af79cd13be357-7d5df119e79mr1104797785a.14.1751799049937; Sun, 06 Jul 2025 03:50:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGnbXcyMALNSAIMrbcV1bErIvj9gLgHlW+lpPLzxeJcvFUcUsGsOmoX7j1K8yEeXnyxMSvpeQ== X-Received: by 2002:a05:620a:4396:b0:7d5:d018:1bf6 with SMTP id af79cd13be357-7d5df119e79mr1104795385a.14.1751799049538; Sun, 06 Jul 2025 03:50:49 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-556383bb555sm920621e87.20.2025.07.06.03.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 03:50:48 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 06 Jul 2025 13:50:38 +0300 Subject: [PATCH 3/3] drm/msm/mdp4: use msm_kms_init_vm() instead of duplicating it Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250706-msm-no-iommu-v1-3-9e8274b30c33@oss.qualcomm.com> References: <20250706-msm-no-iommu-v1-0-9e8274b30c33@oss.qualcomm.com> In-Reply-To: <20250706-msm-no-iommu-v1-0-9e8274b30c33@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2046; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=EUOM9GC2j9wX5WPerbms/C/z2nxGawxsehEkeu7mMVA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBoalUC3CxjmG2qO1jRWXx5gPkOE/BU/KfOLjFAd 21zJFA0vaaJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaGpVAgAKCRCLPIo+Aiko 1bLnB/9zMeuT+8VKzUaMNF0llrx3m3vtO2VrQ+Z5tjOtNMvw7pklBRfaSZrOrQEXcY8eVpcTjkZ byftNEf0tObHUHcrk2nwEsjJ5+F3HmLK9Iu2uR0cPW7nbMm4Pzu3foT+1K83LKrNYBvj4kWnMI7 rkyeAiI7yqTKGAPFvV7Wp9JfzNqLUFxs1FL9FoZG6qaYtfxuWbyAlDYr0pK6ZkejjH8nb9JhLqI cBOweeTjQaTa2ltWjkv+vKbJxvLiHo2Ta49zkUdZ4EA3OBtbrDnVZgXc8aw1ISv1M5h0gQeczmZ /0NvYh4t+H2gxp1SabuYOj+1Hzfoqm0JF6ysG3FDegD10Kd8 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: B7DcSn1swejwP_-U858pIfzASI_o90s5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA2MDA2NyBTYWx0ZWRfX9DOJQQ3bBccR vSu5ODfu7qOR87Jtcqr9+ZT2z9NZAU8JNjRmP8B9a1PS7cZ7eITFRAk+d+0L0H6YVfhsdLp3XPz EWgHb4epqXLkYneFeE+oIjvqHg22djLayP0Le2dOet7OMKwg2i5bXroDbzD8zl2dODtnVJZlZXo RBsSRWB58AyA5alQuiFU0MXr6HYXNasr5+JHgg0lDiujHwIyK5lGM6aVNvQd4zlhjBOT4V4OOKj FJ0HXBoTApNIIS9as0KhzNbGAeKpNAAItzS/votYhqaztgCbgWmaTABH7HD24ahW+ON3x4A+XIg dkZZZ8NZKHI35synsCyK1S0EE+NPH6xyHCXY2cFUTbD8KEzDuIWOdHQ1v6oU81l6k739LZk2KNq GDdw2L2IhpHuCCen2AOSThMTcyGTMlxAHXcG5ot80BhKsC0nrSS4cmFeCBUEpqEY1D51NcFB X-Authority-Analysis: v=2.4 cv=Rd2QC0tv c=1 sm=1 tr=0 ts=686a550b cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=OZ-Rx8C-MikYIJhCyHkA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: B7DcSn1swejwP_-U858pIfzASI_o90s5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-04_07,2025-07-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507060067 Use the msm_kms_init_vm() function to allocate memory manager instead of hand-coding a copy of it. Although MDP4 platforms don't have MDSS device, it's still safe to use the function as all MDP4 devices have IOMMU and the parent of the MDP4 is the root SoC device. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 27 +++++---------------------- 1 file changed, 5 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm= /disp/mdp4/mdp4_kms.c index 88296c41d1a5eb0e16cb6ec4d0475000b6318c4e..41d236d30e71ebb6ac8a5905252= 9f36fadf15cd7 100644 --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c @@ -391,11 +391,9 @@ static void read_mdp_hw_revision(struct mdp4_kms *mdp4= _kms, =20 static int mdp4_kms_init(struct drm_device *dev) { - struct platform_device *pdev =3D to_platform_device(dev->dev); struct msm_drm_private *priv =3D dev->dev_private; struct mdp4_kms *mdp4_kms =3D to_mdp4_kms(to_mdp_kms(priv->kms)); struct msm_kms *kms =3D NULL; - struct msm_mmu *mmu; struct drm_gpuvm *vm; int ret; u32 major, minor; @@ -458,29 +456,14 @@ static int mdp4_kms_init(struct drm_device *dev) mdp4_disable(mdp4_kms); mdelay(16); =20 - mmu =3D msm_iommu_new(&pdev->dev, 0); - if (IS_ERR(mmu)) { - ret =3D PTR_ERR(mmu); + vm =3D msm_kms_init_vm(mdp4_kms->dev); + if (IS_ERR(vm)) { + ret =3D PTR_ERR(vm); goto fail; - } else if (!mmu) { - DRM_DEV_INFO(dev->dev, "no IOMMU configuration is no longer supported\n"= ); - ret =3D -ENODEV; - goto fail; - } else { - vm =3D msm_gem_vm_create(dev, mmu, "mdp4", - 0x1000, 0x100000000 - 0x1000, - true); - - if (IS_ERR(vm)) { - if (!IS_ERR(mmu)) - mmu->funcs->destroy(mmu); - ret =3D PTR_ERR(vm); - goto fail; - } - - kms->vm =3D vm; } =20 + kms->vm =3D vm; + ret =3D modeset_init(mdp4_kms); if (ret) { DRM_DEV_ERROR(dev->dev, "modeset_init failed: %d\n", ret); --=20 2.39.5