From nobody Tue Oct 7 22:58:35 2025 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DB6329E106; Sun, 6 Jul 2025 18:27:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751826443; cv=none; b=NJXk/BOzWhTole9I3LxcexmbeL5NC8WNP1nbM1i7zLAHtwJEbOtsY8B1NIo6D1nL0qfZ0oq4QvW5OKe8ZNTGIU+waOYIifmNWoH9UkJ1x1XlZWrFFdBBIro1Tgj8ToDw4tnjcjPsq1Q00UtKGpWL1oLqSjbRSgFZpqRQicUB/cI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751826443; c=relaxed/simple; bh=T0VIq57CdMsuApiqUpsp/pDwUjngV96YO/wTX94idkA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G31LCDJkoqVcoZpo6ToOy3Ezv3GzbPYCiipskfFMbSeOlpRIV/cajVcaJExYDPh/YvIM3pnBY7eGrzrdtH3DKzQRA6eRbIl1qPtIUJsUIqjnRpGxg4dsuweBM/GD0493rhvyHfKdUUpAtjPVb8aL8ohxisQRVS0F8UHD3BeV44k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=fqumIqkt; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="fqumIqkt" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 47B6025C79; Sun, 6 Jul 2025 20:27:20 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id spAyo9RSzySy; Sun, 6 Jul 2025 20:27:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1751826439; bh=T0VIq57CdMsuApiqUpsp/pDwUjngV96YO/wTX94idkA=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=fqumIqkt0m9woqMuU9mAmmDpUD5m4A5SsPNJ/YROupXpiwyPeuTeONDqmcckpwaay RXhNmW4Szxc9gtD8CavQjH4eF/lc/jK+i+nQZgS8QNPOv3QNJEmHhG+l4D7kTYxnwE FgH55CcXUV7V2eK1TitccxL7dLdyOkpIERFhiYaN/Oes6p1+YSry0pTsm3PJcko9WV vbIsIy196otchv2oShUBvhO31KImkEY/bvluzt3bFsV3TmedTpmwE2lqZfs/puuHp4 o75oxT7PvZckABc/tVSCVth95M6/4ndrEJ9Er0m+ftugl8SEeRYb5m5kv3Nc5SZaFD Eqkrsko/B6vww== From: Kaustabh Chakraborty Date: Sun, 06 Jul 2025 23:55:42 +0530 Subject: [PATCH v3 08/13] drm/bridge: samsung-dsim: allow configuring the PLL_STABLE bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250706-exynos7870-dsim-v3-8-9879fb9a644d@disroot.org> References: <20250706-exynos7870-dsim-v3-0-9879fb9a644d@disroot.org> In-Reply-To: <20250706-exynos7870-dsim-v3-0-9879fb9a644d@disroot.org> To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1751826342; l=3590; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=T0VIq57CdMsuApiqUpsp/pDwUjngV96YO/wTX94idkA=; b=wkbrLglZn9guumLsfLqeKxrkKIcwcP7q1UxaLr6P1BkMEskvyaJCLgQZIQYarnlb8Dm1Tf/pE /15aBS0mk0pD9ctV2tCTnhgls1ah0iEU3I9GOPxULw3kN2gItjfRIFh X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= The PLL_STABLE bit of DSIM_DPHY_STATUS is hardcoded to BIT(31), but Exynos7870's DSIM has it in BIT(24) as per downstream kernel sources. In order to support both, move this bit value to the driver data struct and define it for every driver compatible. Reference the value from there instead, in functions wherever required. Signed-off-by: Kaustabh Chakraborty --- drivers/gpu/drm/bridge/samsung-dsim.c | 9 +++++++-- include/drm/bridge/samsung-dsim.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge= /samsung-dsim.c index d67fb857d0359b813c268a77c2a0f2c3574d6dc2..fb2cb09cfd5a4f2fb50f802dc43= 4c0956107b4e9 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -35,7 +35,6 @@ #define DSIM_STOP_STATE_DAT(x) (((x) & 0xf) << 0) #define DSIM_STOP_STATE_CLK BIT(8) #define DSIM_TX_READY_HS_CLK BIT(10) -#define DSIM_PLL_STABLE BIT(31) =20 /* DSIM_SWRST */ #define DSIM_FUNCRST BIT(16) @@ -415,6 +414,7 @@ static const struct samsung_dsim_driver_data exynos3_ds= i_driver_data =3D { .wait_for_reset =3D 1, .num_bits_resol =3D 11, .video_mode_bit =3D 25, + .pll_stable_bit =3D 31, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -445,6 +445,7 @@ static const struct samsung_dsim_driver_data exynos4_ds= i_driver_data =3D { .wait_for_reset =3D 1, .num_bits_resol =3D 11, .video_mode_bit =3D 25, + .pll_stable_bit =3D 31, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -473,6 +474,7 @@ static const struct samsung_dsim_driver_data exynos5_ds= i_driver_data =3D { .wait_for_reset =3D 1, .num_bits_resol =3D 11, .video_mode_bit =3D 25, + .pll_stable_bit =3D 31, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -501,6 +503,7 @@ static const struct samsung_dsim_driver_data exynos5433= _dsi_driver_data =3D { .wait_for_reset =3D 0, .num_bits_resol =3D 12, .video_mode_bit =3D 25, + .pll_stable_bit =3D 31, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -529,6 +532,7 @@ static const struct samsung_dsim_driver_data exynos5422= _dsi_driver_data =3D { .wait_for_reset =3D 1, .num_bits_resol =3D 12, .video_mode_bit =3D 25, + .pll_stable_bit =3D 31, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -557,6 +561,7 @@ static const struct samsung_dsim_driver_data imx8mm_dsi= _driver_data =3D { .wait_for_reset =3D 0, .num_bits_resol =3D 12, .video_mode_bit =3D 25, + .pll_stable_bit =3D 31, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -760,7 +765,7 @@ static unsigned long samsung_dsim_set_pll(struct samsun= g_dsim *dsi, reg =3D samsung_dsim_read(dsi, DSIM_STATUS_REG); else reg =3D samsung_dsim_read(dsi, DSIM_LINK_STATUS_REG); - } while ((reg & DSIM_PLL_STABLE) =3D=3D 0); + } while ((reg & BIT(driver_data->pll_stable_bit)) =3D=3D 0); =20 dsi->hs_clock =3D fout; =20 diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung= -dsim.h index 000ada3ece4d61c61412be550a8ccc13bd3f777e..04ed11787bbd22503f7221cad1a= 491a4e5e66781 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -65,6 +65,7 @@ struct samsung_dsim_driver_data { unsigned int wait_for_reset; unsigned int num_bits_resol; unsigned int video_mode_bit; + unsigned int pll_stable_bit; unsigned int esc_clken_bit; unsigned int byte_clken_bit; unsigned int tx_req_hsclk_bit; --=20 2.49.0