From nobody Tue Oct 7 22:58:35 2025 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8F9929E115; Sun, 6 Jul 2025 18:26:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751826406; cv=none; b=PU7+rVEc5iXVwFEjWUqbP2U9UTyIRLNROecgDEthuepSD4iUGaLiyb5BfPlgVs/+2AWI9ac7hvFE/tKh96gle9paah5+5DCPYmOrT7ttBQQ58TlL5eyk6GyFJuLOnRxOT9X7bKQrm0Xa+oGOcNY+Sf/Z7fcsyu7IT7xseMAIBC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751826406; c=relaxed/simple; bh=bjtJIjfPVA1dazouYBClK8TP5EhzRm7A0VApH2M0W8E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CiDYFYNGkowzJMEpULvnTHHetbicwjcXG5mBeJbx0+8KZR7IkxD2051eW14oeanFlnnk8Q5j3R3si/sq/WSb/c2Il0jAS3UdRf5ptNy/0lkGGJGVquidDnP3ncWR33spXP3VuobiGsfpt4Oe9yTpI+kCamKoikqIVj3wWYHpIQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=L30N+vdI; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="L30N+vdI" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 3EE9E20D0D; Sun, 6 Jul 2025 20:26:43 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id PmfshaQaDONC; Sun, 6 Jul 2025 20:26:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1751826401; bh=bjtJIjfPVA1dazouYBClK8TP5EhzRm7A0VApH2M0W8E=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=L30N+vdI3ANTrR7nByu59YwV8jshN2raZXMQ5IIDJi1UwxXyutOniHGZpgdOyrELo 8+0INjjnu+VXVPpIKHjXVzuh7ZphDzeHXdZLTZx03b7B1L86gZd/2g7FNz6golVkv3 cgwH1O3pkb+vbM88NFusxLM9koyQ/4mEYx4RgE+D0/Vitp6vYUADfNbUTOhsiBfxOp 95/H08BQJGSHL6ABF0iBhPdrbhKGZx15TdJ+yGFbdLTvqocqxHjDcJwJUKd4ESbCZq E8ux5qsVaR5hn0YtnzcSGQWI9982elldjeELp29s9wFGbrpM+ddQ0NAf9Bp8KTF/FN Q7heXLhIJiWCA== From: Kaustabh Chakraborty Date: Sun, 06 Jul 2025 23:55:39 +0530 Subject: [PATCH v3 05/13] drm/bridge: samsung-dsim: allow configuring the MAIN_VSA offset Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250706-exynos7870-dsim-v3-5-9879fb9a644d@disroot.org> References: <20250706-exynos7870-dsim-v3-0-9879fb9a644d@disroot.org> In-Reply-To: <20250706-exynos7870-dsim-v3-0-9879fb9a644d@disroot.org> To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1751826342; l=4240; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=bjtJIjfPVA1dazouYBClK8TP5EhzRm7A0VApH2M0W8E=; b=TjmdG/eOGkbo2pOMCnBxjC5jxuc7P2/cE+slWoPjFkMVtfJYptuBnDt55XEUmZQm99ZpmS/k2 9E96HgVYhoNB0HfFAQJWyClc1nc2LFhZ4Iy1DCePH2fk9QlB+fMds17 X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= The MAIN_VSA offset of DSIM_MSYNC is hardcoded to a 22-bit offset, but Exynos7870's DSIM has it in a 16-bit offset as per the downstream kernel sources. In order to support both, move this offset value to the driver data struct and define it for every driver compatible. Reference the value from there instead, in functions wherever required. Signed-off-by: Kaustabh Chakraborty --- drivers/gpu/drm/bridge/samsung-dsim.c | 13 ++++++++++--- include/drm/bridge/samsung-dsim.h | 1 + 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge= /samsung-dsim.c index 199c7ace78bfeb01d3ef9a841fe9339c0fb9f478..89ece3e6f200c710e4c9204efd8= 4c84b9260456b 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -125,9 +125,9 @@ #define DSIM_MAIN_HBP_MASK ((0xffff) << 0) =20 /* DSIM_MSYNC */ -#define DSIM_MAIN_VSA(x) ((x) << 22) +#define DSIM_MAIN_VSA(x, offset) ((x) << offset) #define DSIM_MAIN_HSA(x) ((x) << 0) -#define DSIM_MAIN_VSA_MASK ((0x3ff) << 22) +#define DSIM_MAIN_VSA_MASK(offset) ((0x3ff) << offset) #define DSIM_MAIN_HSA_MASK ((0xffff) << 0) =20 /* DSIM_SDRESOL */ @@ -423,6 +423,7 @@ static const struct samsung_dsim_driver_data exynos3_ds= i_driver_data =3D { .lane_esc_clk_bit =3D 19, .lane_esc_data_offset =3D 20, .pll_p_offset =3D 13, + .main_vsa_offset =3D 22, .reg_values =3D reg_values, .pll_fin_min =3D 6, .pll_fin_max =3D 12, @@ -449,6 +450,7 @@ static const struct samsung_dsim_driver_data exynos4_ds= i_driver_data =3D { .lane_esc_clk_bit =3D 19, .lane_esc_data_offset =3D 20, .pll_p_offset =3D 13, + .main_vsa_offset =3D 22, .reg_values =3D reg_values, .pll_fin_min =3D 6, .pll_fin_max =3D 12, @@ -473,6 +475,7 @@ static const struct samsung_dsim_driver_data exynos5_ds= i_driver_data =3D { .lane_esc_clk_bit =3D 19, .lane_esc_data_offset =3D 20, .pll_p_offset =3D 13, + .main_vsa_offset =3D 22, .reg_values =3D reg_values, .pll_fin_min =3D 6, .pll_fin_max =3D 12, @@ -497,6 +500,7 @@ static const struct samsung_dsim_driver_data exynos5433= _dsi_driver_data =3D { .lane_esc_clk_bit =3D 19, .lane_esc_data_offset =3D 20, .pll_p_offset =3D 13, + .main_vsa_offset =3D 22, .reg_values =3D exynos5433_reg_values, .pll_fin_min =3D 6, .pll_fin_max =3D 12, @@ -521,6 +525,7 @@ static const struct samsung_dsim_driver_data exynos5422= _dsi_driver_data =3D { .lane_esc_clk_bit =3D 19, .lane_esc_data_offset =3D 20, .pll_p_offset =3D 13, + .main_vsa_offset =3D 22, .reg_values =3D exynos5422_reg_values, .pll_fin_min =3D 6, .pll_fin_max =3D 12, @@ -549,6 +554,7 @@ static const struct samsung_dsim_driver_data imx8mm_dsi= _driver_data =3D { * downstream driver - drivers/gpu/drm/bridge/sec-dsim.c */ .pll_p_offset =3D 14, + .main_vsa_offset =3D 22, .reg_values =3D imx8mm_dsim_reg_values, .pll_fin_min =3D 2, .pll_fin_max =3D 30, @@ -1041,6 +1047,7 @@ static void samsung_dsim_set_display_mode(struct sams= ung_dsim *dsi) { struct drm_display_mode *m =3D &dsi->mode; unsigned int num_bits_resol =3D dsi->driver_data->num_bits_resol; + unsigned int main_vsa_offset =3D dsi->driver_data->main_vsa_offset; u32 reg; =20 if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO) { @@ -1067,7 +1074,7 @@ static void samsung_dsim_set_display_mode(struct sams= ung_dsim *dsi) reg =3D DSIM_MAIN_HFP(hfp) | DSIM_MAIN_HBP(hbp); samsung_dsim_write(dsi, DSIM_MHPORCH_REG, reg); =20 - reg =3D DSIM_MAIN_VSA(m->vsync_end - m->vsync_start) + reg =3D DSIM_MAIN_VSA(m->vsync_end - m->vsync_start, main_vsa_offset) | DSIM_MAIN_HSA(hsa); samsung_dsim_write(dsi, DSIM_MSYNC_REG, reg); } diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung= -dsim.h index b1e64c7f993189879d9549f147f7eebdf3b7ded4..7f6d353f34af14f156e864c624f= 6eb980296c32d 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -70,6 +70,7 @@ struct samsung_dsim_driver_data { unsigned int lane_esc_clk_bit; unsigned int lane_esc_data_offset; unsigned int pll_p_offset; + unsigned int main_vsa_offset; const unsigned int *reg_values; unsigned int pll_fin_min; unsigned int pll_fin_max; --=20 2.49.0