From nobody Tue Oct 7 21:18:30 2025 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F8792750FE; Sat, 5 Jul 2025 03:34:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686472; cv=none; b=X6+bmT6lpaWU+iy6F0TgxMfIG1emfN93jZkQ/MXP02+0Kcxv/1PEcKLLwYiEFrF1hc0rbIqxFecww9b1YQ4YlUXZeAT58yyVV7g8kykamtWGt9wx+Avtgfapmi0LmvdaDSKnpuleZIotFntVHZyPaCPH72t9aRPaRfLp1OXf/nQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686472; c=relaxed/simple; bh=qesUASDRqxVXZpS+A6xRsFs8Zz1otj+XO6QGFCpLsJ0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dnBYf9PT7guoTJpN6lYQzD4VAljFZ0eioV6b+Gy2ToL5MN6VcfsJ0Qvx85TbGTtMLRFXZhi/L1aQ2mhCCmZhcSjVO5lZ4U53hLBtesPG84cSkWVTXbLR+m+8RY22WPEQ5OlqgC7Gh92UFgZvy965P41C8zb5lPAOI0JA5KSaxIQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GyID7RvW; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GyID7RvW" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4a58ebece05so18651191cf.1; Fri, 04 Jul 2025 20:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751686469; x=1752291269; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JnkXAtFrf7nxnP+T+BL361jXm28TaP0Cx95Aq6bp4vI=; b=GyID7RvWD9eEn+PZv4B0tOyBt4O5iTKSqF5JLU9ql73k40NaTE4dWyN6h58kw2ygLg OpP2+GhOYjvz1SZS1ziOA26igwzISccpiOmSqes08NRQEnRU9M9WX3NIJ60NNyf+zT2r QRzLRYyLoN2gfmUQgTpGyTcCTk5ud7+HqHKUL2A9a0pYvnp+OLnQelxOnDtCRqZGtt4C GTFaUFOngGVksfAoLBoMRvLCfti3sxyCSCLc/Ya60X4DLK/519JuHcDZz4bFdefm+/P8 fYWgcWLUhV3sKzDSBp1dhn4GtoL+MWrl2DILvdj6XIi3KB7BcdJiYVaUwSdr+q/3QBx6 +vtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751686469; x=1752291269; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JnkXAtFrf7nxnP+T+BL361jXm28TaP0Cx95Aq6bp4vI=; b=J4cbOk58xy0Cvg2FPQsIhdIiqVGo7IdZ+5GW38caITH/035R0TRhrE6bmGm6/njs2R CF9Ht7jfUhsoxyAauFMDW2D1QBJFFfqYlEflDBsPyTaqXwdgqLj9nEpFNzpuhr5YhpfD LJIgZTg6Uin7WxF/9ENapDeyVaKnqVi/X6bENRyR04BnDaYyEBIuaElZ7cVWanSWHtKQ 5rijwolmbT0tYIKohXR8pKhLu41WoGiLaadqykTEtCFuFdd+wuoNJlTNPmX9or1N8RqS 0NsBO5TYVo4yjsqf+r7EwziKoIWroUHWa/i6sRNtCGTLqjS3+ag/GLtkZdlb5zAnibNf F+LQ== X-Forwarded-Encrypted: i=1; AJvYcCW9p8ln2+qbsslM1OJuavcuAH/bXKVioilQ7w8kvbdFtjnHM4GWb9aZQBPiSQsdyjDnwj8nfulhNt9AtjQ=@vger.kernel.org, AJvYcCWYMd4gehMVdmgqNG3tVELEqFfkRaifcqA7Mgy9f1D03Evsd52FThb0oOmZyFYrC3b7WkfnFUQ7V2vuCKDd4NBRJZwoug==@vger.kernel.org X-Gm-Message-State: AOJu0YwwanfXJetMInEZ9UmlS/8UoL1yk97iVoU4heqdDYzbIy4Ox3q3 jdgRV+2NE14udrJK64YXF7Qb1d5jcY9wd0/IxJe95PHkxN9j1trZbsxH X-Gm-Gg: ASbGncuttHrnSC7vhnTTnA9Th46kaXXvaNC9dgny5kkT432D1r7bAaNgHAN8WkG8jNq qQZjxEcspl3GfqFGpJO5o6wfhGaOP6gSp3iEl1VY5x/CNoAnFL4OM1sfvqfTAq2AnJeRW/ebuJZ VoHYuZ+cv75/lOgr+JOkf5AOfQSM2EG7sLILz1rOw/9szFJg3sfPk8fW8PoX58ue5F57X3BinD3 l377kYtdfN3AUEQuhDKm7vqE8FwgQEcHXBzAcWW+ZDA1OJSJT16xmk/qLUBMLfeygIvPoo4oEeX qf1lLKTORbFTO+vOs7HCl9MKSsgsDqCoWrIEyw/k4JY/jtzyjacqkGX/02F+6Q== X-Google-Smtp-Source: AGHT+IHirRPjd9W4dOhjeX1p0e8FhmnU0OCdPNPxgt2CS+a0PmXCMwK+ceDXAMKGpLFFQo3codJmKw== X-Received: by 2002:a05:622a:8f13:b0:4a9:91fa:7ff4 with SMTP id d75a77b69052e-4a9a119b45bmr29902501cf.33.1751686469074; Fri, 04 Jul 2025 20:34:29 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4a48sm25850281cf.13.2025.07.04.20.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 20:34:28 -0700 (PDT) From: Kurt Borja Date: Sat, 05 Jul 2025 00:33:56 -0300 Subject: [PATCH v5 1/6] platform/x86: firmware_attributes_class: Add device initialization methods Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250705-fw-attrs-api-v5-1-60b6d51d93eb@gmail.com> References: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> In-Reply-To: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=6433; i=kuurtb@gmail.com; h=from:subject:message-id; bh=/QEeIwGjvbsjee7Vf79ak5H1ghdhU4XqRdrxZm09VUw=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBkZc20e5Rbs+7Jjwbu1d678mntrQ9n1Vbm+H96p5Dw1d 9Xb++GxXkcpC4MYF4OsmCJLe8Kib4+i8t76HQi9DzOHlQlkCAMXpwBMpGo3I8NZneYceZ+ZUq+v /mVaztX7kTFeJnfW7bUfLf16LuoqnN/IyPB7gYTPqcK3Sy9p/D1lItE1Jfx0YFOj63vX6UYccu6 bi7gA X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A From: Thomas Wei=C3=9Fschuh Currently each user of firmware_attributes_class has to manually set up kobjects, devices, etc. Provide this infrastructure out-of-the-box through the newly introduced fwat_device_register(). Reviewed-by: Mario Limonciello Signed-off-by: Thomas Wei=C3=9Fschuh Co-developed-by: Kurt Borja Signed-off-by: Kurt Borja --- drivers/platform/x86/firmware_attributes_class.c | 125 +++++++++++++++++++= ++++ drivers/platform/x86/firmware_attributes_class.h | 28 +++++ 2 files changed, 153 insertions(+) diff --git a/drivers/platform/x86/firmware_attributes_class.c b/drivers/pla= tform/x86/firmware_attributes_class.c index 736e96c186d9dc6d945517f090e9af903e93bbf4..290364202cce64bb0e9046e0b2b= bb8d85e2cbc6f 100644 --- a/drivers/platform/x86/firmware_attributes_class.c +++ b/drivers/platform/x86/firmware_attributes_class.c @@ -2,7 +2,14 @@ =20 /* Firmware attributes class helper module */ =20 +#include +#include +#include +#include +#include #include +#include +#include #include "firmware_attributes_class.h" =20 const struct class firmware_attributes_class =3D { @@ -10,6 +17,122 @@ const struct class firmware_attributes_class =3D { }; EXPORT_SYMBOL_GPL(firmware_attributes_class); =20 +static void fwat_device_release(struct device *dev) +{ + struct fwat_device *fadev =3D to_fwat_device(dev); + + kfree(fadev); +} + +/** + * fwat_device_register - Create and register a firmware-attributes class + * device + * @parent: Parent device + * @name: Name of the class device + * @drvdata: Drvdata of the class device + * @groups: Extra groups for the "attributes" directory + * + * Return: pointer to the new fwat_device on success, ERR_PTR on failure + */ +struct fwat_device * +fwat_device_register(struct device *parent, const char *name, void *drvdat= a, + const struct attribute_group **groups) +{ + struct fwat_device *fadev; + int ret; + + if (!parent || !name) + return ERR_PTR(-EINVAL); + + fadev =3D kzalloc(sizeof(*fadev), GFP_KERNEL); + if (!fadev) + return ERR_PTR(-ENOMEM); + + fadev->groups =3D groups; + fadev->dev.class =3D &firmware_attributes_class; + fadev->dev.parent =3D parent; + fadev->dev.release =3D fwat_device_release; + dev_set_drvdata(&fadev->dev, drvdata); + ret =3D dev_set_name(&fadev->dev, "%s", name); + if (ret) { + kfree(fadev); + return ERR_PTR(ret); + } + ret =3D device_register(&fadev->dev); + if (ret) + return ERR_PTR(ret); + + fadev->attrs_kset =3D kset_create_and_add("attributes", NULL, &fadev->dev= .kobj); + if (!fadev->attrs_kset) { + ret =3D -ENOMEM; + goto out_device_unregister; + } + + ret =3D sysfs_create_groups(&fadev->attrs_kset->kobj, groups); + if (ret) + goto out_kset_unregister; + + return fadev; + +out_kset_unregister: + kset_unregister(fadev->attrs_kset); + +out_device_unregister: + device_unregister(&fadev->dev); + + return ERR_PTR(ret); +} +EXPORT_SYMBOL_GPL(fwat_device_register); + +void fwat_device_unregister(struct fwat_device *fadev) +{ + if (!fadev) + return; + + sysfs_remove_groups(&fadev->attrs_kset->kobj, fadev->groups); + kset_unregister(fadev->attrs_kset); + device_unregister(&fadev->dev); +} +EXPORT_SYMBOL_GPL(fwat_device_unregister); + +static void devm_fwat_device_release(void *data) +{ + struct fwat_device *fadev =3D data; + + fwat_device_unregister(fadev); +} + +/** + * devm_fwat_device_register - Create and register a firmware-attributes c= lass + * device + * @parent: Parent device + * @name: Name of the class device + * @data: Drvdata of the class device + * @groups: Extra groups for the class device (Optional) + * + * Device managed version of fwat_device_register(). + * + * Return: pointer to the new fwat_device on success, ERR_PTR on failure + */ +struct fwat_device * +devm_fwat_device_register(struct device *parent, const char *name, void *d= ata, + const struct attribute_group **groups) +{ + struct fwat_device *fadev; + int ret; + + fadev =3D fwat_device_register(parent, name, data, groups); + if (IS_ERR(fadev)) + return fadev; + + ret =3D devm_add_action_or_reset(parent, devm_fwat_device_release, fadev); + if (ret) + return ERR_PTR(ret); + + return fadev; +} +EXPORT_SYMBOL_GPL(devm_fwat_device_register); + static __init int fw_attributes_class_init(void) { return class_register(&firmware_attributes_class); @@ -23,5 +146,7 @@ static __exit void fw_attributes_class_exit(void) module_exit(fw_attributes_class_exit); =20 MODULE_AUTHOR("Mark Pearson "); +MODULE_AUTHOR("Thomas Wei=C3=9Fschuh "); +MODULE_AUTHOR("Kurt Borja "); MODULE_DESCRIPTION("Firmware attributes class helper module"); MODULE_LICENSE("GPL"); diff --git a/drivers/platform/x86/firmware_attributes_class.h b/drivers/pla= tform/x86/firmware_attributes_class.h index d27abe54fcf9812a2f0868eec5426bbc8e7eb21c..048fd0904f767357ef856e687ec= 4cf3260016ec6 100644 --- a/drivers/platform/x86/firmware_attributes_class.h +++ b/drivers/platform/x86/firmware_attributes_class.h @@ -5,8 +5,36 @@ #ifndef FW_ATTR_CLASS_H #define FW_ATTR_CLASS_H =20 +#include +#include #include +#include +#include =20 extern const struct class firmware_attributes_class; =20 +/** + * struct fwat_device - The firmware-attributes device + * @dev: The class device. + * @attrs_kobj: The "attributes" root kobject. + * @groups: Sysfs groups attached to the @attrs_kobj. + */ +struct fwat_device { + struct device dev; + struct kset *attrs_kset; + const struct attribute_group **groups; +}; + +#define to_fwat_device(_d) container_of_const(_d, struct fwat_device, dev) + +struct fwat_device * __must_check +fwat_device_register(struct device *parent, const char *name, void *drvdat= a, + const struct attribute_group **groups); + +void fwat_device_unregister(struct fwat_device *fwadev); + +struct fwat_device * __must_check +devm_fwat_device_register(struct device *parent, const char *name, void *d= ata, + const struct attribute_group **groups); + #endif /* FW_ATTR_CLASS_H */ --=20 2.50.0 From nobody Tue Oct 7 21:18:30 2025 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B7F124B26; Sat, 5 Jul 2025 03:34:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686476; cv=none; b=ZolvJxoS/P6LWJPU3d5KfDZYXQ2FwfcDT3fiw9tqAKaVrYwyPh0FW3TkiOCHx7/9gChlnO3/DoSpwLIKjtT6p/ogUAzzN+oCYZW+PFL1p9jcZSx2hnepUwv3T2uwYKi0gafOo2MKudDAXXjs844KPFRCGXdiiyjVWIVfy5QyRok= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686476; c=relaxed/simple; bh=Wxja1Er06nSdThUZPUQQgnFdDHaeZEk4NrYl5ehKZko=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CLjNvcWzKYSsAhUZ70JxiFz8LbZuoo9IAxmnTaY3LlmhiP9ObT4qvaiHykuYc3OFbFSTgZKZtdR+hEPvXvF4ZucBjeFITHty1GwHbc6lzEIqbPOv+vvW/1L4KRDoiEAsDEtgbsM+SEgmFiBwyI9WfP3XIHskEu6y7itIL8zUFQY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eqs5iw9s; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eqs5iw9s" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4a7a8c2b7b9so20672371cf.1; Fri, 04 Jul 2025 20:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751686473; x=1752291273; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X1xECn9D/F3wXBhMhprWDMFyGU0kGz7RxcioK8xwO6E=; b=eqs5iw9sQIA8JuxTFzfeyS6iYCuFEDFkkDxz+U59mdzKWymVZYxpPRllwJqK/OPorG 9omiaQBgNWLB67bcYBen05DI2ZMBE8OJshonpNy1Jk8L5Mlz0deVysvvN6LVWHHko5O+ ErvXTW5PN5N9HAmQDnOKqLKx6gLERyek9xxELT5q/AAeRtdDMvMWhN2YyzYrhbkB/WMX 7gUV0Wu5yc6jl2De1IzWNAWFDCfC1dLeeIklw0RIAQU88q3m1pCxeXe+6QERPhWMRtJ6 E0Zi73FfScL/fYA6fYkSo1v9oe2AX6SVALNZ5NX6YXkvPtKkv2mznJAcjHwcKTiZXekR 0qHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751686473; x=1752291273; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X1xECn9D/F3wXBhMhprWDMFyGU0kGz7RxcioK8xwO6E=; b=fEaDA0P4TOL/fD8Rnh7RaSIbEY/uDtQekBr+f45mgwad5m2Yhic0CNdwFsQztJ4cAS 9DANIh7Vkg9AfxMn+3Rg5SGRb+3uEpiR09ktaZIqRlmstzgK1wbPd+3anemgwmTt40DY AXwvp41zc6umSbKZzkxRRlG3OdFBzQQuBwJB8XHHkXQgMbqvNSPN7rUagwjN4mHx8hHO F3AchLa0ypbZFR3UbUoy/Uiid7fkv7phsVVF+krImK2Suid8y1TvKCDWWP1C2J+uMnvD eAkl3+vHBQttB/z+YSw7PP3V0cTm9mMQY/hYCrScvXad3+jdy4V91TnkmZ+5nqPspkMJ rILg== X-Forwarded-Encrypted: i=1; AJvYcCVxx7IrTSZRxaZBf+08odd+8n7Ci4vK4KnVlMgHWm3ncPTcqrHHWRI8yQBppnmIRAFfsOj2IeNlseqEBtp6ZRr8GXEjRw==@vger.kernel.org, AJvYcCXAI1VLJb8JISUG4k/Vq54CU71zHZgwdrSvEhYRxV7NG4jHp901m2GR/I5m7z6UmGCwjkgAdSKd56aYZ6M=@vger.kernel.org X-Gm-Message-State: AOJu0YxEIonolOkraogAX8VOk4AAiYktRwKER7/9bCdBZGgmcuRM7qNc dpZg9FbaXR48CictxgCti6ZxBru0aOBFet5J/bUlaXVsaAj8tjGLBkx7 X-Gm-Gg: ASbGnct7GpfgO8VvkVbHaf0wEk82x/za7Eo7GoyUU3T3PUZqO8ggoTqd1SpK9iobumW FWt6cF32fPIb0RYZeAmelQ9zwkPoa9TUoH0Fmm8ap5ugUhbjmlifBBHYU5JWGW6lW6D/fvp116S PD3jXa+DGl0XpcXaQnLxeqnsrMq+jAus/q2Bs6j7mQW/9qHf/n7LkUtA7z+l5hTGgIpPQfuVW4B H3Iw0OaHj0iYCdQBRajTveN9Sa3LWHrsOk+a6QxISwkITnXMWVim19x6ldhcZ8CzoJ1d8j9Yumq u+dP4IiCRTGYWSdsotpgNPw2t3QFU3mPjuv7Ce/WPylMn9mQCSdx23O9/mzBXA== X-Google-Smtp-Source: AGHT+IFJSgPeKbN8+z/PFVe4L6FW+FgOb+mGBL8MSQ5HZwqTCwrLJ0QROsGkbSguTOIpzAUgr2dBew== X-Received: by 2002:ac8:7f92:0:b0:4a4:39a6:93c4 with SMTP id d75a77b69052e-4a998677b65mr62501261cf.21.1751686472812; Fri, 04 Jul 2025 20:34:32 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4a48sm25850281cf.13.2025.07.04.20.34.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 20:34:32 -0700 (PDT) From: Kurt Borja Date: Sat, 05 Jul 2025 00:33:57 -0300 Subject: [PATCH v5 2/6] platform/x86: firmware_attributes_class: Add high level API for the attributes interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250705-fw-attrs-api-v5-2-60b6d51d93eb@gmail.com> References: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> In-Reply-To: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=31331; i=kuurtb@gmail.com; h=from:subject:message-id; bh=Wxja1Er06nSdThUZPUQQgnFdDHaeZEk4NrYl5ehKZko=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBkZc230CiZ7Je1/6ybcfyQt8uXcI7NnvDm40aap2a+7T eAMz/VFHaUsDGJcDLJiiiztCYu+PYrKe+t3IPQ+zBxWJpAhDFycAjCR/1MYGQ67WB+qufBX+k3X gqwcDen6A1q+oXuXG7s0Pgq+bHe47j4jw/Kjy/aVik34KtnzqWJSeYpO4xEv/VM/fwvq/p/x+I+ hDxcA X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Add high level API to aid in the creation of attribute groups attached to the `attrs_kobj` (per ABI specification). This new API lets users configure each group, either statically or dynamically through a (per type) data struct and then create this group through the generic fwat_create_group() macro. Signed-off-by: Kurt Borja --- drivers/platform/x86/firmware_attributes_class.c | 532 +++++++++++++++++++= ++++ drivers/platform/x86/firmware_attributes_class.h | 335 ++++++++++++++ 2 files changed, 867 insertions(+) diff --git a/drivers/platform/x86/firmware_attributes_class.c b/drivers/pla= tform/x86/firmware_attributes_class.c index 290364202cce64bb0e9046e0b2bbb8d85e2cbc6f..96473b3b1a2a87cf21a6e2a9a14= d72ae322c94ae 100644 --- a/drivers/platform/x86/firmware_attributes_class.c +++ b/drivers/platform/x86/firmware_attributes_class.c @@ -10,13 +10,67 @@ #include #include #include +#include #include "firmware_attributes_class.h" =20 +#define FWAT_TYPE_NONE -1 + +#define to_fwat_bool_data(_c) \ + container_of_const(_c, struct fwat_bool_data, group) +#define to_fwat_enum_data(_c) \ + container_of_const(_c, struct fwat_enum_data, group) +#define to_fwat_int_data(_c) \ + container_of_const(_c, struct fwat_int_data, group) +#define to_fwat_str_data(_c) \ + container_of_const(_c, struct fwat_str_data, group) + +struct fwat_attribute { + struct attribute attr; + ssize_t (*show)(struct kobject *kobj, struct fwat_attribute *attr, + char *buf); + ssize_t (*store)(struct kobject *kobj, struct fwat_attribute *attr, + const char *buf, size_t count); + int type; +}; + +#define to_fwat_attribute(_a) \ + container_of_const(_a, struct fwat_attribute, attr) + +#define __FWAT_ATTR(_name, _mode, _show, _store, _type) \ + { \ + .attr =3D { .name =3D __stringify(_name), .mode =3D _mode }, \ + .show =3D _show, .store =3D _store, .type =3D _type, \ + } + +#define FWAT_ATTR_RO(_prefix, _name, _show, _type) \ + static struct fwat_attribute fwat_##_prefix##_##_name##_attr =3D \ + __FWAT_ATTR(_name, 0444, _show, NULL, _type) + +#define FWAT_ATTR_RW(_prefix, _name, _show, _store, _type) \ + static struct fwat_attribute fwat_##_prefix##_##_name##_attr =3D \ + __FWAT_ATTR(_name, 0644, _show, _store, _type) + +struct fwat_group { + const struct fwat_group_data *data; + struct device *dev; + struct kobject kobj; +}; + +#define kobj_to_fwat_group(_k) \ + container_of_const(_k, struct fwat_group, kobj) + const struct class firmware_attributes_class =3D { .name =3D "firmware-attributes", }; EXPORT_SYMBOL_GPL(firmware_attributes_class); =20 +static const char * const fwat_type_labels[] =3D { + [fwat_group_boolean] =3D "boolean", + [fwat_group_enumeration] =3D "enumeration", + [fwat_group_integer] =3D "integer", + [fwat_group_string] =3D "string", +}; + static void fwat_device_release(struct device *dev) { struct fwat_device *fadev =3D to_fwat_device(dev); @@ -24,6 +78,483 @@ static void fwat_device_release(struct device *dev) kfree(fadev); } =20 +static ssize_t +type_show(struct kobject *kobj, struct fwat_attribute *attr, char *buf) +{ + return sysfs_emit(buf, "%s\n", fwat_type_labels[attr->type]); +} + +static ssize_t +display_name_show(struct kobject *kobj, struct fwat_attribute *attr, char = *buf) +{ + struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const char *disp_name =3D group->data->display_name; + + if (!disp_name) + return -EOPNOTSUPP; + + return sysfs_emit(buf, "%s\n", disp_name); +} + +static ssize_t +display_name_language_code_show(struct kobject *kobj, struct fwat_attribut= e *attr, + char *buf) +{ + struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const char *lang_code =3D group->data->language_code; + + if (!lang_code) + return -EOPNOTSUPP; + + return sysfs_emit(buf, "%s\n", lang_code); +} + +static ssize_t +bool_group_show(struct kobject *kobj, struct fwat_attribute *attr, char *b= uf) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_bool_data *data =3D to_fwat_bool_data(group->data); + bool val; + int ret; + + /* show_override does not affect current_value */ + if (data->group.show_override && attr->type !=3D fwat_bool_current_value) + return data->group.show_override(group->dev, attr->type, buf); + + switch (attr->type) { + case fwat_bool_current_value: + ret =3D data->read(group->dev, data->group.id, &val); + if (ret < 0) + return ret; + break; + case fwat_bool_default_value: + val =3D data->default_val; + break; + default: + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%s\n", str_yes_no(val)); +} + +static ssize_t +bool_group_store(struct kobject *kobj, struct fwat_attribute *attr, const = char *buf, + size_t count) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_bool_data *data =3D to_fwat_bool_data(group->data); + bool val; + int ret; + + ret =3D kstrtobool(buf, &val); + if (ret) + return ret; + + ret =3D data->write(group->dev, data->group.id, val); + if (ret) + return ret; + + return count; +} + +static ssize_t +enum_group_show(struct kobject *kobj, struct fwat_attribute *attr, char *b= uf) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_enum_data *data =3D to_fwat_enum_data(group->data); + int val_idx, sz =3D 0; + int ret; + + /* show_override does not affect current_value */ + if (data->group.show_override && attr->type !=3D fwat_enum_current_value) + return data->group.show_override(group->dev, attr->type, buf); + + switch (attr->type) { + case fwat_enum_current_value: + ret =3D data->read(group->dev, data->group.id, &val_idx); + if (ret < 0) + return ret; + break; + case fwat_enum_default_value: + val_idx =3D data->default_idx; + break; + case fwat_enum_possible_values: + sz +=3D sysfs_emit_at(buf, sz, "%s", data->possible_vals[0]); + for (unsigned int i =3D 1; data->possible_vals[i]; i++) + sz +=3D sysfs_emit_at(buf, sz, ";%s", data->possible_vals[i]); + sz +=3D sysfs_emit_at(buf, sz, "\n"); + return sz; + default: + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%s\n", data->possible_vals[val_idx]); +} + +static ssize_t +enum_group_store(struct kobject *kobj, struct fwat_attribute *attr, const = char *buf, + size_t count) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_enum_data *data =3D to_fwat_enum_data(group->data); + int val_idx; + int ret; + + val_idx =3D __sysfs_match_string(data->possible_vals, -1, buf); + if (val_idx < 0) + return val_idx; + + ret =3D data->write(group->dev, data->group.id, val_idx); + if (ret) + return ret; + + return count; +} + +static ssize_t +int_group_show(struct kobject *kobj, struct fwat_attribute *attr, char *bu= f) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_int_data *data =3D to_fwat_int_data(group->data); + long val; + int ret; + + /* show_override does not affect current_value */ + if (data->group.show_override && attr->type !=3D fwat_int_current_value) + return data->group.show_override(group->dev, attr->type, buf); + + switch (attr->type) { + case fwat_int_current_value: + ret =3D data->read(group->dev, data->group.id, &val); + if (ret < 0) + return ret; + break; + case fwat_int_default_value: + val =3D data->default_val; + break; + case fwat_int_min_value: + val =3D data->min_val; + break; + case fwat_int_max_value: + val =3D data->max_val; + break; + case fwat_int_scalar_increment: + val =3D data->increment; + break; + default: + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%ld\n", val); +} + +static ssize_t +int_group_store(struct kobject *kobj, struct fwat_attribute *attr, const c= har *buf, + size_t count) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_int_data *data =3D to_fwat_int_data(group->data); + long val; + int ret; + + ret =3D kstrtol(buf, 0, &val); + if (ret) + return ret; + + ret =3D data->write(group->dev, data->group.id, val); + if (ret) + return ret; + + return count; +} + +static ssize_t +str_group_show(struct kobject *kobj, struct fwat_attribute *attr, char *bu= f) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_str_data *data =3D to_fwat_str_data(group->data); + const char *val; + long len; + int ret; + + /* show_override does not affect current_value */ + if (data->group.show_override && attr->type !=3D fwat_bool_current_value) + return data->group.show_override(group->dev, attr->type, buf); + + switch (attr->type) { + case fwat_str_current_value: + ret =3D data->read(group->dev, data->group.id, &val); + if (ret < 0) + return ret; + break; + case fwat_str_default_value: + val =3D data->default_val; + break; + case fwat_str_min_length: + len =3D data->min_len; + return sysfs_emit(buf, "%ld\n", len); + case fwat_str_max_length: + len =3D data->max_len; + return sysfs_emit(buf, "%ld\n", len); + default: + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%s\n", val); +} + +static ssize_t +str_group_store(struct kobject *kobj, struct fwat_attribute *attr, const c= har *buf, + size_t count) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_str_data *data =3D to_fwat_str_data(group->data); + int ret; + + ret =3D data->write(group->dev, data->group.id, buf); + if (ret) + return ret; + + return count; +} + +FWAT_ATTR_RO(all, display_name, display_name_show, FWAT_TYPE_NONE); +FWAT_ATTR_RO(all, display_name_language_code, display_name_language_code_s= how, FWAT_TYPE_NONE); + +FWAT_ATTR_RO(bool, type, type_show, fwat_group_boolean); +FWAT_ATTR_RW(bool, current_value, bool_group_show, bool_group_store, fwat_= bool_current_value); +FWAT_ATTR_RO(bool, default_value, bool_group_show, fwat_bool_default_value= ); + +FWAT_ATTR_RO(enum, type, type_show, fwat_group_enumeration); +FWAT_ATTR_RW(enum, current_value, enum_group_show, enum_group_store, fwat_= enum_current_value); +FWAT_ATTR_RO(enum, default_value, enum_group_show, fwat_enum_default_value= ); +FWAT_ATTR_RO(enum, possible_values, enum_group_show, fwat_enum_possible_va= lues); + +FWAT_ATTR_RO(int, type, type_show, fwat_group_integer); +FWAT_ATTR_RW(int, current_value, int_group_show, int_group_store, fwat_int= _current_value); +FWAT_ATTR_RO(int, default_value, int_group_show, fwat_int_default_value); +FWAT_ATTR_RO(int, min_value, int_group_show, fwat_int_min_value); +FWAT_ATTR_RO(int, max_value, int_group_show, fwat_int_max_value); +FWAT_ATTR_RO(int, scalar_increment, int_group_show, fwat_int_scalar_increm= ent); + +FWAT_ATTR_RO(str, type, type_show, fwat_group_string); +FWAT_ATTR_RW(str, current_value, str_group_show, str_group_store, fwat_int= _current_value); +FWAT_ATTR_RO(str, default_value, str_group_show, fwat_str_default_value); +FWAT_ATTR_RO(str, min_length, str_group_show, fwat_str_min_length); +FWAT_ATTR_RO(str, max_length, str_group_show, fwat_str_max_length); + +static struct attribute *fwat_bool_attrs[] =3D { + &fwat_bool_type_attr.attr, + &fwat_all_display_name_attr.attr, + &fwat_all_display_name_language_code_attr.attr, + &fwat_bool_current_value_attr.attr, + &fwat_bool_default_value_attr.attr, + NULL +}; + +static struct attribute *fwat_enum_attrs[] =3D { + &fwat_enum_type_attr.attr, + &fwat_all_display_name_attr.attr, + &fwat_all_display_name_language_code_attr.attr, + &fwat_enum_current_value_attr.attr, + &fwat_enum_default_value_attr.attr, + &fwat_enum_possible_values_attr.attr, + NULL +}; + +static struct attribute *fwat_int_attrs[] =3D { + &fwat_int_type_attr.attr, + &fwat_all_display_name_attr.attr, + &fwat_all_display_name_language_code_attr.attr, + &fwat_int_current_value_attr.attr, + &fwat_int_default_value_attr.attr, + &fwat_int_min_value_attr.attr, + &fwat_int_max_value_attr.attr, + &fwat_int_scalar_increment_attr.attr, + NULL +}; + +static struct attribute *fwat_str_attrs[] =3D { + &fwat_str_type_attr.attr, + &fwat_all_display_name_attr.attr, + &fwat_all_display_name_language_code_attr.attr, + &fwat_str_current_value_attr.attr, + &fwat_str_default_value_attr.attr, + &fwat_str_min_length_attr.attr, + &fwat_str_max_length_attr.attr, + NULL +}; + +static umode_t fwat_attr_visible(struct kobject *kobj, struct attribute *a= ttr, int n) +{ + struct fwat_attribute *fwat_attr =3D to_fwat_attribute(attr); + struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_group_data *data =3D group->data; + + /* The `type` attribute is always first */ + if (n =3D=3D 0) + return attr->mode; + + if (attr =3D=3D &fwat_all_display_name_attr.attr) + return data->display_name ? attr->mode : 0; + + if (attr =3D=3D &fwat_all_display_name_language_code_attr.attr) + return data->language_code ? attr->mode : 0; + + /* The `current_value` attribute always has type =3D=3D 0 */ + if (!fwat_attr->type) + return data->mode; + + return test_bit(fwat_attr->type, &data->fattrs) ? attr->mode : 0; +} + +static umode_t fwat_group_visible(struct kobject *kobj) +{ + return true; +} + +DEFINE_SYSFS_GROUP_VISIBLE(fwat); + +static const struct attribute_group fwat_bool_group =3D { + .attrs =3D fwat_bool_attrs, + .is_visible =3D SYSFS_GROUP_VISIBLE(fwat), +}; +__ATTRIBUTE_GROUPS(fwat_bool); + +static const struct attribute_group fwat_enum_group =3D { + .attrs =3D fwat_enum_attrs, + .is_visible =3D SYSFS_GROUP_VISIBLE(fwat), +}; +__ATTRIBUTE_GROUPS(fwat_enum); + +static const struct attribute_group fwat_int_group =3D { + .attrs =3D fwat_int_attrs, + .is_visible =3D SYSFS_GROUP_VISIBLE(fwat), +}; +__ATTRIBUTE_GROUPS(fwat_int); + +static const struct attribute_group fwat_str_group =3D { + .attrs =3D fwat_str_attrs, + .is_visible =3D SYSFS_GROUP_VISIBLE(fwat), +}; +__ATTRIBUTE_GROUPS(fwat_str); + +static ssize_t +fwat_attr_sysfs_show(struct kobject *kobj, struct attribute *attr, char *b= uf) +{ + struct fwat_attribute *fwat_attr =3D to_fwat_attribute(attr); + + if (!fwat_attr->show) + return -EOPNOTSUPP; + + return fwat_attr->show(kobj, fwat_attr, buf); +} + +static ssize_t +fwat_attr_sysfs_store(struct kobject *kobj, struct attribute *attr, const = char *buf, + size_t count) +{ + struct fwat_attribute *fwat_attr =3D to_fwat_attribute(attr); + + if (!fwat_attr->show) + return -EOPNOTSUPP; + + return fwat_attr->store(kobj, fwat_attr, buf, count); +} + +static void fwat_group_release(struct kobject *kobj) +{ + struct fwat_group *group =3D kobj_to_fwat_group(kobj); + + kfree(group); +} + +static const struct sysfs_ops fwat_attr_sysfs_ops =3D { + .show =3D fwat_attr_sysfs_show, + .store =3D fwat_attr_sysfs_store, +}; + +static const struct kobj_type fwat_boolean_ktype =3D { + .sysfs_ops =3D &fwat_attr_sysfs_ops, + .release =3D fwat_group_release, + .default_groups =3D fwat_bool_groups, +}; + +static const struct kobj_type fwat_enumeration_ktype =3D { + .sysfs_ops =3D &fwat_attr_sysfs_ops, + .release =3D fwat_group_release, + .default_groups =3D fwat_enum_groups, +}; + +static const struct kobj_type fwat_integer_ktype =3D { + .sysfs_ops =3D &fwat_attr_sysfs_ops, + .release =3D fwat_group_release, + .default_groups =3D fwat_int_groups, +}; + +static const struct kobj_type fwat_string_ktype =3D { + .sysfs_ops =3D &fwat_attr_sysfs_ops, + .release =3D fwat_group_release, + .default_groups =3D fwat_str_groups, +}; + +static int __fwat_create_group(struct fwat_device *fadev, const struct kob= j_type *ktype, + const struct fwat_group_data *data) +{ + struct fwat_group *group; + int ret; + + group =3D kzalloc(sizeof(*group), GFP_KERNEL); + if (!group) + return -ENOMEM; + + group->dev =3D &fadev->dev; + group->data =3D data; + + group->kobj.kset =3D fadev->attrs_kset; + ret =3D kobject_init_and_add(&group->kobj, ktype, NULL, "%s", data->name); + if (ret) { + kobject_put(&group->kobj); + return ret; + } + + kobject_uevent(&group->kobj, KOBJ_ADD); + + return 0; +} + +static void fwat_remove_auto_groups(struct fwat_device *fadev) +{ + struct kobject *pos, *n; + + list_for_each_entry_safe(pos, n, &fadev->attrs_kset->list, entry) + kobject_put(pos); +} + +int fwat_create_bool_group(struct fwat_device *fadev, const struct fwat_bo= ol_data *data) +{ + return __fwat_create_group(fadev, &fwat_boolean_ktype, &data->group); +} +EXPORT_SYMBOL_GPL(fwat_create_bool_group); + +int fwat_create_enum_group(struct fwat_device *fadev, const struct fwat_en= um_data *data) +{ + return __fwat_create_group(fadev, &fwat_enumeration_ktype, &data->group); +} +EXPORT_SYMBOL_GPL(fwat_create_enum_group); + +int fwat_create_int_group(struct fwat_device *fadev, const struct fwat_int= _data *data) +{ + return __fwat_create_group(fadev, &fwat_integer_ktype, &data->group); +} +EXPORT_SYMBOL_GPL(fwat_create_int_group); + +int fwat_create_str_group(struct fwat_device *fadev, const struct fwat_str= _data *data) +{ + return __fwat_create_group(fadev, &fwat_string_ktype, &data->group); +} +EXPORT_SYMBOL_GPL(fwat_create_str_group); + /** * fwat_device_register - Create and register a firmware-attributes class * device @@ -89,6 +620,7 @@ void fwat_device_unregister(struct fwat_device *fadev) if (!fadev) return; =20 + fwat_remove_auto_groups(fadev); sysfs_remove_groups(&fadev->attrs_kset->kobj, fadev->groups); kset_unregister(fadev->attrs_kset); device_unregister(&fadev->dev); diff --git a/drivers/platform/x86/firmware_attributes_class.h b/drivers/pla= tform/x86/firmware_attributes_class.h index 048fd0904f767357ef856e687ec4cf3260016ec6..e8868ce05b595eda94a98975428= 391b9f9341e3d 100644 --- a/drivers/platform/x86/firmware_attributes_class.h +++ b/drivers/platform/x86/firmware_attributes_class.h @@ -10,6 +10,7 @@ #include #include #include +#include =20 extern const struct class firmware_attributes_class; =20 @@ -27,6 +28,340 @@ struct fwat_device { =20 #define to_fwat_device(_d) container_of_const(_d, struct fwat_device, dev) =20 +enum fwat_group_type { + fwat_group_boolean, + fwat_group_enumeration, + fwat_group_integer, + fwat_group_string, +}; + +enum fwat_bool_attrs { + fwat_bool_current_value, + fwat_bool_default_value, + fwat_bool_attrs_last +}; + +#define FWAT_BOOL_CURRENT_VALUE BIT(fwat_bool_current_value) +#define FWAT_BOOL_DEFAULT_VALUE BIT(fwat_bool_default_value) +#define FWAT_BOOL_ALL_ATTRS GENMASK(fwat_bool_attrs_last, 0) + +enum fwat_enum_attrs { + fwat_enum_current_value, + fwat_enum_default_value, + fwat_enum_possible_values, + fwat_enum_attrs_last +}; + +#define FWAT_ENUM_CURRENT_VALUE BIT(fwat_enum_current_value) +#define FWAT_ENUM_DEFAULT_VALUE BIT(fwat_enum_default_value) +#define FWAT_ENUM_POSSIBLE_VALUES BIT(fwat_enum_possible_values) +#define FWAT_ENUM_ALL_ATTRS GENMASK(fwat_enum_attrs_last, 0) + +enum fwat_int_attrs { + fwat_int_current_value, + fwat_int_default_value, + fwat_int_min_value, + fwat_int_max_value, + fwat_int_scalar_increment, + fwat_int_attrs_last +}; + +#define FWAT_INT_CURRENT_VALUE BIT(fwat_int_current_value) +#define FWAT_INT_DEFAULT_VALUE BIT(fwat_int_default_value) +#define FWAT_INT_MIN_VALUE BIT(fwat_int_min_value) +#define FWAT_INT_MAX_VALUE BIT(fwat_int_max_value) +#define FWAT_INT_SCALAR_INCREMENT BIT(fwat_int_scalar_increment) +#define FWAT_INT_ALL_ATTRS GENMASK(fwat_int_attrs_last, 0) + +enum fwat_str_attrs { + fwat_str_current_value, + fwat_str_default_value, + fwat_str_min_length, + fwat_str_max_length, + fwat_str_attrs_last +}; + +#define FWAT_STR_CURRENT_VALUE BIT(fwat_str_current_value) +#define FWAT_STR_DEFAULT_VALUE BIT(fwat_str_default_value) +#define FWAT_STR_MIN_LENGTH BIT(fwat_str_min_length) +#define FWAT_STR_MAX_LENGTH BIT(fwat_str_max_length) +#define FWAT_STR_ALL_ATTRS GENMASK(fwat_str_attrs_last, 0) + +static_assert(fwat_bool_current_value =3D=3D 0); +static_assert(fwat_enum_current_value =3D=3D 0); +static_assert(fwat_int_current_value =3D=3D 0); +static_assert(fwat_str_current_value =3D=3D 0); + +/** + * struct fwat_group_data - Data struct common between group types + * @id: Group ID defined by the user. + * @name: Name of the group. + * @display_name: Name showed in the display_name attribute. (Optional) + * @language_code: Language code showed in the display_name_language_code + * attribute. (Optional) + * @mode: Mode for the current_value attribute. All other attributes will = have + * 0444 permissions. + * @fattrs: Bitmap of selected attributes for this group type. + * @show_override: Custom show method for attributes in this group, except= for + * the current_value attribute, for which the a `read` callback + * will still be used. (Optional) + * + * NOTE: This struct is not meant to be defined directly. It is supposed t= o be + * embedded and defined as part of fwat_[type]_data structs. + */ +struct fwat_group_data { + long id; + umode_t mode; + const char *name; + const char *display_name; + const char *language_code; + unsigned long fattrs; + ssize_t (*show_override)(struct device *dev, int type, char *buf); +}; + +/** + * struct fwat_bool_data - Data struct for the boolean group type + * @read: Read callback for the current_value attribute. + * @write: Write callback for the current_value attribute. + * @default_val: Default value. + * @group: Group data. + */ +struct fwat_bool_data { + int (*read)(struct device *dev, long id, bool *val); + int (*write)(struct device *dev, long id, bool val); + bool default_val; + struct fwat_group_data group; +}; + +/** + * struct fwat_enum_data - Data struct for the enumeration group type + * @read: Read callback for the current_value attribute. + * @write: Write callback for the current_value attribute. + * @default_idx: Index of the default value in the @possible_vals array. + * @possible_vals: Array of possible value strings for this group type. + * @group: Group data. + * + * NOTE: The `val_idx` argument in the @write callback is guaranteed to be= a + * valid (within bounds) index. However, the user is in charge of wr= iting + * valid indexes to the `*val_idx` argument of the @read callback. + * Failing to do so may result in an OOB access. + */ +struct fwat_enum_data { + int (*read)(struct device *dev, long id, int *val_idx); + int (*write)(struct device *dev, long id, int val_idx); + int default_idx; + const char * const *possible_vals; + struct fwat_group_data group; +}; + +/** + * struct fwat_int_data - Data struct for the integer group type + * @read: Read callback for the current_value attribute. + * @write: Write callback for the current_value attribute. + * @default_val: Default value. + * @min_val: Minimum value. + * @max_val: Maximum value. + * @increment: Scalar increment for this value. + * @group: Group data. + * + * NOTE: The @min_val, @max_val, @increment constraints are merely informa= tive. + * These values are not enforced in any of the callbacks. + */ +struct fwat_int_data { + int (*read)(struct device *dev, long id, long *val); + int (*write)(struct device *dev, long id, long val); + long default_val; + long min_val; + long max_val; + long increment; + struct fwat_group_data group; +}; + +/** + * struct fwat_str_data - Data struct for the string group type + * @read: Read callback for the current_value attribute. + * @write: Write callback for the current_value attribute. + * @default_val: Default value. + * @min_len: Minimum string length. + * @max_len: Maximum string length. + * @group: Group data. + * + * NOTE: The @min_len, @max_len constraints are merely informative. These + * values are not enforced in any of the callbacks. + */ +struct fwat_str_data { + int (*read)(struct device *dev, long id, const char **buf); + int (*write)(struct device *dev, long id, const char *buf); + const char *default_val; + long min_len; + long max_len; + struct fwat_group_data group; +}; + +#define __FWAT_GROUP(_name, _disp_name, _mode, _fattrs) \ + { .name =3D __stringify(_name), .display_name =3D _disp_name, .mode =3D _= mode, .fattrs =3D _fattrs } + +/** + * DEFINE_FWAT_BOOL_GROUP - Convenience macro to quickly define an static + * struct fwat_bool_data instance + * @_name: Name of the group. + * @_disp_name: Name showed in the display_name attribute. (Optional) + * @_def_val: Default value. + * @_mode: Mode for the current_value attribute. All other attributes will= have + * 0444 permissions. + * @_fattrs: Bitmap of selected attributes for this group type. + * + * `read` and `write` callbacks are required to be already defined as + * `_name##_read` and `_name##_write` respectively. + */ +#define DEFINE_FWAT_BOOL_GROUP(_name, _disp_name, _def_val, _mode, _fattrs= ) \ + static const struct fwat_bool_data _name##_group_data =3D { \ + .read =3D _name##_read, \ + .write =3D _name##_write, \ + .default_val =3D _def_val, \ + .group =3D __FWAT_GROUP(_name, _disp_name, _mode, _fattrs), \ + } + +/** + * DEFINE_FWAT_ENUM_GROUP - Convenience macro to quickly define an static + * struct fwat_enum_data instance + * @_name: Name of the group. + * @_disp_name: Name showed in the display_name attribute. (Optional) + * @_def_idx: Index of the default value in the @_poss_vals array. + * @_poss_vals: Array of possible value strings for this group type. + * @_mode: Mode for the current_value attribute. All other attributes will= have + * 0444 permissions. + * @_fattrs: Bitmap of selected attributes for this group type. + * + * `read` and `write` callbacks are required to be already defined as + * `_name##_read` and `_name##_write` respectively. + * + * NOTE: The `val_idx` argument in the `write` callback is guaranteed to b= e a + * valid (within bounds) index. However, the user is in charge of wr= iting + * valid indexes to the `*val_idx` argument of the `read` callback. + * Failing to do so may result in an OOB access. + */ +#define DEFINE_FWAT_ENUM_GROUP(_name, _disp_name, _poss_vals, _def_idx, _m= ode, _fattrs) \ + static const struct fwat_enum_data _name##_group_data =3D { \ + .read =3D _name##_read, \ + .write =3D _name##_write, \ + .default_idx =3D _def_idx, \ + .possible_vals =3D _poss_vals, \ + .group =3D __FWAT_GROUP(_name, _disp_name, _mode, _fattrs), \ + } + +/** + * DEFINE_FWAT_INT_GROUP - Convenience macro to quickly define an static + * struct fwat_int_data instance + * @_name: Name of the group. + * @_disp_name: Name showed in the display_name attribute. (Optional) + * @_def_val: Default value. + * @_min: Minimum value. + * @_max: Maximum value. + * @_inc: Scalar increment for this value. + * @_mode: Mode for the current_value attribute. All other attributes will= have + * 0444 permissions. + * @_fattrs: Bitmap of selected attributes for this group type. + * + * `read` and `write` callbacks are required to be already defined as + * `_name##_read` and `_name##_write` respectively. + * + * NOTE: The @_min, @_max, @_inc constraints are merely informative. These + * values are not enforced in any of the callbacks. + */ +#define DEFINE_FWAT_INT_GROUP(_name, _disp_name, _def_val, _min, _max, _in= c, _mode, _fattrs) \ + static const struct fwat_int_data _name##_group_data =3D { \ + .read =3D _name##_read, \ + .write =3D _name##_write, \ + .default_val =3D _def_val, \ + .min_val =3D _min, \ + .max_val =3D _max, \ + .increment =3D _inc, \ + .group =3D __FWAT_GROUP(_name, _disp_name, _mode, _fattrs), \ + } + +/** + * DEFINE_FWAT_STR_GROUP - Convenience macro to quickly define an static + * struct fwat_str_data instance + * @_name: Name of the group. + * @_disp_name: Name showed in the display_name attribute. (Optional) + * @_def_val: Default value. + * @_min: Minimum string length. + * @_max: Maximum string length. + * @_mode: Mode for the current_value attribute. All other attributes will= have + * 0444 permissions. + * @_fattrs: Bitmap of selected attributes for this group type. + * + * `read` and `write` callbacks are required to be already defined as + * `_name##_read` and `_name##_write` respectively. + * + * NOTE: The @_min, @_max constraints are merely informative. These values= are + * not enforced in any of the callbacks. + */ +#define DEFINE_FWAT_STR_GROUP(_name, _disp_name, _def_val, _min, _max, _mo= de, _fattrs) \ + static const struct fwat_str_data _name##_group_data =3D { \ + .read =3D _name##_read, \ + .write =3D _name##_write, \ + .default_val =3D _def_val, \ + .min_len =3D _min, \ + .max_len =3D _max, \ + .group =3D __FWAT_GROUP(_name, _disp_name, _mode, _fattrs), \ + } + +int fwat_create_bool_group(struct fwat_device *fadev, + const struct fwat_bool_data *data); +int fwat_create_enum_group(struct fwat_device *fadev, + const struct fwat_enum_data *data); +int fwat_create_int_group(struct fwat_device *fadev, + const struct fwat_int_data *data); +int fwat_create_str_group(struct fwat_device *fadev, + const struct fwat_str_data *data); + +/** + * fwat_create_group - Convenience generic macro to create a group + * @_dev: fwat_device + * @_data: One of fwat_{bool,enum,int,str}_data instance + * + * This macro (and associated functions) creates a sysfs group under the + * 'attributes' directory, which is located in the class device root direc= tory. + * + * See Documentation/ABI/testing/sysfs-class-firmware-attributes for detai= ls. + * + * The @_data associated with this group may be created either statically, + * through DEFINE_FWAT_*_GROUP macros or dynamically, in which case the us= er + * would have allocate and fill the struct manually. The dynamic approach = should + * be preferred when group constraints and/or visibility is decided dynami= cally. + * + * Example: + * + * static int stat_read(...){...}; + * static int stat_write(...){...}; + * + * DEFINE_FWAT_(BOOL|ENUM|INT|STR)_GROUP(stat, ...); + * + * static int create_groups(struct fwat_device *fadev) + * { + * struct fwat_enum_data *dyn_group_data; + * + * dyn_group_data =3D kzalloc(...); + * // Fill the data + * ... + * fwat_create_group(fadev, &stat_group_data); + * fwat_create_group(fadev, &dyn_group_data); + * fwat_create_group(...); + * ... + * } + * + * Return: 0 on success, -errno on failure + */ +#define fwat_create_group(_dev, _data) \ + _Generic((_data), \ + const struct fwat_bool_data * : fwat_create_bool_group, \ + const struct fwat_enum_data * : fwat_create_enum_group, \ + const struct fwat_int_data * : fwat_create_int_group, \ + const struct fwat_str_data * : fwat_create_str_group) \ + (_dev, _data) + struct fwat_device * __must_check fwat_device_register(struct device *parent, const char *name, void *drvdat= a, const struct attribute_group **groups); --=20 2.50.0 From nobody Tue Oct 7 21:18:30 2025 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CBDD1E833D; Sat, 5 Jul 2025 03:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686479; cv=none; b=rjaux3KSUntEwupBGgLfY+/2pZmnD4cC5D/yt4LIteMJpv7ukOpJ3yE8o2r5cGNB7hxjGkR7jgw2hKx4aCIjEyK+7IHa+8UEAXdaveAcdbF5J6/OAxIIQyXdiqPOBoBAqGX+nYZkPrheIzNaKl2d2Xj4PODER7lu29tVv2sO9mQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686479; c=relaxed/simple; bh=Lnjuh4ZOXocex20M6BS4afXq/dyIN8vU7SmMelSJkHQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CMAFxdlGV8wN9epHV6kdAi8MvkHW/ayZNkFkl17Iaj5gjXuuX1+UKCBy785h6x/0HxoOyep+9zEDzQnlWIT+rkydEoQR/RI05ra/MvO6Tj70yZu3cA/Pgdp9vaCLo6g2iPXkfKh/O8XsVbG8QJrH6XzqEABOWavW7vGgkMyJL8A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mQ8t0il4; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mQ8t0il4" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4a4bb155edeso18208391cf.2; Fri, 04 Jul 2025 20:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751686476; x=1752291276; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PLvba3Gwh4N2lya1BYovWa27xgWPh27HKdvKaSYmsw8=; b=mQ8t0il4zE/4weoL90nDeq/a+oU3iel+Lv1RRIPe09gOIZ0yfNyJj75/+1Ohe7s0wk xGR8ldQad0m/tozu+Cmf7xXVAtgnvlkrDzn1uimWiBaQmZ7SXgx0O824HyDxBKU/N6I/ zZ7N1aRxi6TkXxtT2sWbwi7myWhY8w2TMuKRw0QEZApwhsVgh8KCe1FZ+7YG1OD70jwm Qbm3JfHg1jG7Jx1zZfboqNq48aDJuG/CrJ1JrPc24FlkAmbwfema9AVttWQXr7ee5alZ Npb7Rx8d4+3wnDEhhmpi9nB6H/19W7MDIWvgSVaun0i1SuX05c7efDR6dopcTQvb3f/w g24A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751686476; x=1752291276; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PLvba3Gwh4N2lya1BYovWa27xgWPh27HKdvKaSYmsw8=; b=iGTaegX6tFLL+NSVdP6KbfmL+2VaL6anFAyXtwmI7tXaEWy2jxfY/qTqodp4MxySFV pS0qXGA0/HlaKM3Xmcp4PkHGNK/Fxyhbz8OhJxdkwALv1r+a7jctntZt8hmejX8LvqSq vtmxh4cfpwZ+4CPu4MHvMBMkMTFajLMkvBgempskkSy7SA9xO70BJKWjvI7JtEA7kK2p 28MDOjh5UuW1I3x+IkSKa1BoSXrImOIMIu0dNMP3JYprj9kH+AKDKFELJYs7GCHBttzU 1lUdReg8u8ZVJjD7nnztWBRbLYvpL18u1kjjxkbBiCXwth4zObX8SS1777OdDvYVuUQ9 WrcA== X-Forwarded-Encrypted: i=1; AJvYcCVE0r5Y2789FnQonG/LRkpwF7SJL5/Q+ik8FIU/ERVyUdKGtZmbrVyLpp2ywnxNxDrzY/TFrrc9YrYaUkk=@vger.kernel.org, AJvYcCXrBdJM3yfod1iS0oQeteMDv4oYiQOqubn5vOHnC4eB+OD8+UhV5jHUb3ughvZbHPeZU659Q7f5e41o1fH6mDHLBRI/bw==@vger.kernel.org X-Gm-Message-State: AOJu0Yx+T6F8eNqg7+i0iKkwoOJIepOUCW8JDuZiPoJNOAOG6hS/Ljdg QUGe8r9sJD9KlmBtPhuiSQjw7GU/gJBkevaG03EyAdvprS0a4Xm7LaIB X-Gm-Gg: ASbGncsgwvlTKLf/ZfnMtWV5Vth57LNskjvxBZz0L6sh76fwZxleTZIBOZTNL8HYu2H 0OIVOTA3qBtAtsyFD4RUuI6zVR1IUglue25FwHt3fX4MzvqlDWsRGsbogc04q0Z+DuP4Tg1HhBN 27Oz/GuwdCqe01HHqktGNDFVI/TIejBJJQXjb78VFKQjr59FQtaqfuN+wHW2YS+drChogmebVuS MSvYsQsdgCVT5KFt0nmGfZz/lZf1VSW6YIGrWxx9zZ3CLDd+JJPxdB7wp2nVzLHRwTZZjI9KkEd Qn/1TsGoQjDVftCtyDHtLl4Mb5c8ulj5OPJEsLTwGnKyNTYFcJDSgrHkjfV/ng== X-Google-Smtp-Source: AGHT+IHk1qMpuzmGpA4370ZbLNoCBLBkXTm55CYQc/CYM45R83p/YAe6MYxYOJckt+XeB1Favbq0Tw== X-Received: by 2002:ac8:59cd:0:b0:4a5:a96d:604c with SMTP id d75a77b69052e-4a9a69724d4mr19201241cf.39.1751686476268; Fri, 04 Jul 2025 20:34:36 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4a48sm25850281cf.13.2025.07.04.20.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 20:34:36 -0700 (PDT) From: Kurt Borja Date: Sat, 05 Jul 2025 00:33:58 -0300 Subject: [PATCH v5 3/6] platform/x86: firmware_attributes_class: Move header to include directory Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250705-fw-attrs-api-v5-3-60b6d51d93eb@gmail.com> References: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> In-Reply-To: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3715; i=kuurtb@gmail.com; h=from:subject:message-id; bh=Lnjuh4ZOXocex20M6BS4afXq/dyIN8vU7SmMelSJkHQ=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBkZc212fDPJtby9qFSuNLaiISpNdt2iRyc/JK1VYjEXN IzdUG/XUcrCIMbFICumyNKesOjbo6i8t34HQu/DzGFlAhnCwMUpABMxYGP4K7n13Nn4ydd/sph/ 3F7LkPJxkqT6v4wX+6ZbBDudcenVEmL4KxsU6bGmYGFN2HY5/4yeZ23leqY2D1SNMz9u5P69oyG DHQA= X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Move firmware_attributes_class.h to include/linux/ to avoid hardcoding paths inside drivers/platform/x86/. Signed-off-by: Kurt Borja --- drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 2 +- drivers/platform/x86/firmware_attributes_class.c | 2 +- drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 2 +- drivers/platform/x86/lenovo/think-lmi.c | 2 +- drivers/platform/x86/samsung-galaxybook.c | 2 +- {drivers/platform/x86 =3D> include/linux}/firmware_attributes_class.h | 0 6 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/p= latform/x86/dell/dell-wmi-sysman/sysman.c index d00389b860e4ea0655c740c78bc3751f323b6370..3aec09987ab145508ed05b02e61= a6d94edf79484 100644 --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c @@ -12,8 +12,8 @@ #include #include #include +#include #include "dell-wmi-sysman.h" -#include "../../firmware_attributes_class.h" =20 #define MAX_TYPES 4 #include diff --git a/drivers/platform/x86/firmware_attributes_class.c b/drivers/pla= tform/x86/firmware_attributes_class.c index 96473b3b1a2a87cf21a6e2a9a14d72ae322c94ae..25a0f424ea9f691570f399e1771= da4fc9ff12397 100644 --- a/drivers/platform/x86/firmware_attributes_class.c +++ b/drivers/platform/x86/firmware_attributes_class.c @@ -11,7 +11,7 @@ #include #include #include -#include "firmware_attributes_class.h" +#include =20 #define FWAT_TYPE_NONE -1 =20 diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platfor= m/x86/hp/hp-bioscfg/bioscfg.c index 13237890fc92002e7e730b1c235ddf068a6737cd..2df31af8a3b4ac88710af1fae2d= 5dabbb3185f1d 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c @@ -12,7 +12,7 @@ #include #include #include "bioscfg.h" -#include "../../firmware_attributes_class.h" +#include #include #include =20 diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86= /lenovo/think-lmi.c index 34a47269e3d34d2eda6b71af73892656cd2bf67d..f61a6287eb0ebe9ac4c0c9445c3= b54c12b276691 100644 --- a/drivers/platform/x86/lenovo/think-lmi.c +++ b/drivers/platform/x86/lenovo/think-lmi.c @@ -20,7 +20,7 @@ #include #include #include -#include "../firmware_attributes_class.h" +#include #include "think-lmi.h" =20 static bool debug_support; diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x= 86/samsung-galaxybook.c index 5878a351993eb05a4c5c2c75b4915d972ce9becc..9a5a7b956a9f6a2738470e83ce9= 3f4cccf4bf3b4 100644 --- a/drivers/platform/x86/samsung-galaxybook.c +++ b/drivers/platform/x86/samsung-galaxybook.c @@ -28,7 +28,7 @@ #include #include #include -#include "firmware_attributes_class.h" +#include =20 #define DRIVER_NAME "samsung-galaxybook" =20 diff --git a/drivers/platform/x86/firmware_attributes_class.h b/include/lin= ux/firmware_attributes_class.h similarity index 100% rename from drivers/platform/x86/firmware_attributes_class.h rename to include/linux/firmware_attributes_class.h --=20 2.50.0 From nobody Tue Oct 7 21:18:30 2025 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CB04286898; Sat, 5 Jul 2025 03:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686483; cv=none; b=J/1axZhy7fpKbCNh+4d2eTJixKPdNI3qqMCVGDffgd20f6v3Hf5V8ZPBys8MK/DMLID1rGD9FRzipP5SX43Vxf+/Wa62hsvw+LwMEO8J2cyM1U63Fs5yFx5CXzxkqWOfGtwdfUQz7/rwxbsjg5JZgfkdqE+KvoYPNmaZRFP0PA8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686483; c=relaxed/simple; bh=liILi0h70NtnHMaTrnZq1JtW1kl+WBBQwRBtx4jqqqU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GSp1aVibrQwZc0a203zj/U6IgEsNBBNnFB4YG5hHzcFCUJwXS7Vrd5X04MNhIO08W/gmQ6R0y9C25F7h96BxF4F/Wn70fGRXcVe8LP/mKz0QXXmI4/SaNRgnanvmf3AyXlUhYwfYqTOTKX+5hiidgb8lQHQhzgudhWKEanh23m4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YxHPH9wi; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YxHPH9wi" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4a43972dcd7so18418931cf.3; Fri, 04 Jul 2025 20:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751686480; x=1752291280; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=K2/KSwnwApNBj2qg4eJFgFllM2G5u9JrEk978fuXLkk=; b=YxHPH9wiUMe6dxHlPH2LpoBm5aGOvg0J3Gi5ibMecMd7jsNf4FSLCCUePCeYMF/zje 72RWpOItIdzSRvtyihnA+6s+Dc3/Rn5zVArwrCsaEAlgoYJbw2SJ19UdbZmUKN8uwo29 ko6VJ+nGv4Y/KJ3nhxAeZUzrrSqMSNT1r+vls5eKT+WLBmkYP82utTpUsE4beJCcEmaX kUdIND4vKSfLMlGzHHEql8L3RZRDh5NWqo0mxTQuBIQqMZ90sLZj2DnZnRri0TrwG3zL jFdXud/7nfDO3FAcgbtfzl4TQUWA1/ry1R2ezcHfuFMDYP31pEAkkMJCCC0RQNiK0fno fnIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751686480; x=1752291280; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K2/KSwnwApNBj2qg4eJFgFllM2G5u9JrEk978fuXLkk=; b=FY/0jaBfBQOb5YkMY1Plwvb/GOXe+UQBjoN6C6RdI8xBIVLIME3PYJhrsr7X0ZHqix LBMI32VQmWSxnuTqY44MHzfrjHf3VCzWFSwu4DnBmXpHBrbR2MljUqCtmA61kuCGsCFm /5EiZ1mdZBKVxu9vEw8Dj57tmgrmRyyF+49J1h8q3V/ziNYQlLXqEzUg8Psuf/LGBx9y 2Q9QLtmQUHWHaB8AYOWNEHUSYg45Hx3RZt7dNsBUoqTIZ1zbiSkfMF3WERgHlPceBrHO /6+Ey8cJKGLWHXLliflPhgJv+hC7I9KYSkTDmO1eUbesg/KJp5erfAbsunqUy7HZfSt6 sgQw== X-Forwarded-Encrypted: i=1; AJvYcCUYKk0G+ktI8XS09cr2olN53fL91wgmTx5EPJ9xnmVUS3ZNqj+W8yWwwEKpUCQ4l+qdoPPZLi7113ZvyJz6RtWhtgttUA==@vger.kernel.org, AJvYcCXXdFftQYSKNTSlExik+X+XyR9tH5kfFcL2H8miyYb1nEWT52H+HegER1S//cOKSQ1x51/Sd8FZd5Yrhng=@vger.kernel.org X-Gm-Message-State: AOJu0YzsWg3izHJyeL/aUMYoC9WJtJWMQ8znjwRaFz9xNKzGWf+zZQqK 4EB7VrOHNGOWWg25S8QGudDqrqrjk5zk35NCanY66L0hKQOPY5sum5JZ X-Gm-Gg: ASbGncu4z9iCeBW0l4xf/Z6EdjVFqjvFV4SaZm/WSAzIIewheejxpI4jSWLV/053j81 FsNRsQjyZM4fsz14+CgcDBhDk8qEjT4aq6+MABaT5NcnWf/EkCEXLsc439cF/Nfwa9uiYtRsM4I HrpQFhkbK1CkmzEYwtyz2IeA07J5lS9Gpk1xObmvaYwxNGb8bkamfQUZ6VOZtBif677RtDxezX2 im2qyOqXuE292yWkx4OMsJjghwqrR7mDRC5PzwIuLx9SuUTeR4ziWEdeZXCX/amB4NO7OLd3IjI tgI/4GV12mgmlEp4Cyp+glfSQOQS76zID4buGHpSinoueE6+nYbK3Jg4AhngYw== X-Google-Smtp-Source: AGHT+IG418JgvQGskotvpfmXfUmnDxPc2eg/lG7SZn+eohe0VWwY4vAxCTUSZtEr0FwHG7SRWJDk7Q== X-Received: by 2002:a05:622a:1a85:b0:4a4:30e7:782 with SMTP id d75a77b69052e-4a99868ee60mr58311751cf.18.1751686479916; Fri, 04 Jul 2025 20:34:39 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4a48sm25850281cf.13.2025.07.04.20.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 20:34:39 -0700 (PDT) From: Kurt Borja Date: Sat, 05 Jul 2025 00:33:59 -0300 Subject: [PATCH v5 4/6] platform/x86: samsung-galaxybook: Transition new firmware_attributes API Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250705-fw-attrs-api-v5-4-60b6d51d93eb@gmail.com> References: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> In-Reply-To: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=10903; i=kuurtb@gmail.com; h=from:subject:message-id; bh=liILi0h70NtnHMaTrnZq1JtW1kl+WBBQwRBtx4jqqqU=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBkZc23i7tQ/9bJfabHxNcMP9QcXCmYsv1STaHq5T/Cjy of3Akffd5SyMIhxMciKKbK0Jyz69igq763fgdD7MHNYmUCGMHBxCsBNfsHwh3vF8ukd15nfN0jY GXtEnL8hNe/yrlqxbb+/q4X0Mmz102BkWHdGW0nI2KVj1hy7fYck5R32hezKS0p5mzHl6imzRo/ z/AA= X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Transition to new firmware_attributes API. Defining firmware_attributes groups statically through DEFINE_FWAT_ENUM_GROUP() incurs in a minor ABI change. In particular the display_name_language_code attribute is no longer created. Fortunately, this doesn't break user-space compatibility, because this attribute is not required, neither by the ABI specification nor by user-space tools. Signed-off-by: Kurt Borja --- drivers/platform/x86/samsung-galaxybook.c | 244 ++++++++------------------= ---- 1 file changed, 61 insertions(+), 183 deletions(-) diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x= 86/samsung-galaxybook.c index 9a5a7b956a9f6a2738470e83ce93f4cccf4bf3b4..d1db2a3f716aafc5a314f2bdc57= f7c958a9ae346 100644 --- a/drivers/platform/x86/samsung-galaxybook.c +++ b/drivers/platform/x86/samsung-galaxybook.c @@ -36,8 +36,6 @@ struct samsung_galaxybook { struct platform_device *platform; struct acpi_device *acpi; =20 - struct device *fw_attrs_dev; - struct kset *fw_attrs_kset; /* block in case firmware attributes are updated in multiple threads */ struct mutex fw_attr_lock; =20 @@ -60,36 +58,6 @@ struct samsung_galaxybook { u8 profile_performance_modes[PLATFORM_PROFILE_LAST]; }; =20 -enum galaxybook_fw_attr_id { - GB_ATTR_POWER_ON_LID_OPEN, - GB_ATTR_USB_CHARGING, - GB_ATTR_BLOCK_RECORDING, -}; - -static const char * const galaxybook_fw_attr_name[] =3D { - [GB_ATTR_POWER_ON_LID_OPEN] =3D "power_on_lid_open", - [GB_ATTR_USB_CHARGING] =3D "usb_charging", - [GB_ATTR_BLOCK_RECORDING] =3D "block_recording", -}; - -static const char * const galaxybook_fw_attr_desc[] =3D { - [GB_ATTR_POWER_ON_LID_OPEN] =3D "Power On Lid Open", - [GB_ATTR_USB_CHARGING] =3D "USB Charging", - [GB_ATTR_BLOCK_RECORDING] =3D "Block Recording", -}; - -#define GB_ATTR_LANGUAGE_CODE "en_US.UTF-8" - -struct galaxybook_fw_attr { - struct samsung_galaxybook *galaxybook; - enum galaxybook_fw_attr_id fw_attr_id; - struct attribute_group attr_group; - struct kobj_attribute display_name; - struct kobj_attribute current_value; - int (*get_value)(struct samsung_galaxybook *galaxybook, bool *value); - int (*set_value)(struct samsung_galaxybook *galaxybook, const bool value); -}; - struct sawb { u16 safn; u16 sasb; @@ -908,193 +876,106 @@ static int galaxybook_block_recording_init(struct s= amsung_galaxybook *galaxybook =20 /* Firmware Attributes setup */ =20 -static ssize_t type_show(struct kobject *kobj, struct kobj_attribute *attr= , char *buf) +static const char * const galaxybook_possible_vals[] =3D { + [false] =3D "0", [true] =3D "1", NULL +}; + +static int power_on_lid_open_read(struct device *dev, long id, int *val_id= x) { - return sysfs_emit(buf, "enumeration\n"); -} - -static struct kobj_attribute fw_attr_type =3D __ATTR_RO(type); - -static ssize_t default_value_show(struct kobject *kobj, struct kobj_attrib= ute *attr, char *buf) -{ - return sysfs_emit(buf, "0\n"); -} - -static struct kobj_attribute fw_attr_default_value =3D __ATTR_RO(default_v= alue); - -static ssize_t possible_values_show(struct kobject *kobj, struct kobj_attr= ibute *attr, char *buf) -{ - return sysfs_emit(buf, "0;1\n"); -} - -static struct kobj_attribute fw_attr_possible_values =3D __ATTR_RO(possibl= e_values); - -static ssize_t display_name_language_code_show(struct kobject *kobj, struc= t kobj_attribute *attr, - char *buf) -{ - return sysfs_emit(buf, "%s\n", GB_ATTR_LANGUAGE_CODE); -} - -static struct kobj_attribute fw_attr_display_name_language_code =3D - __ATTR_RO(display_name_language_code); - -static ssize_t display_name_show(struct kobject *kobj, struct kobj_attribu= te *attr, char *buf) -{ - struct galaxybook_fw_attr *fw_attr =3D - container_of(attr, struct galaxybook_fw_attr, display_name); - - return sysfs_emit(buf, "%s\n", galaxybook_fw_attr_desc[fw_attr->fw_attr_i= d]); -} - -static ssize_t current_value_show(struct kobject *kobj, struct kobj_attrib= ute *attr, char *buf) -{ - struct galaxybook_fw_attr *fw_attr =3D - container_of(attr, struct galaxybook_fw_attr, current_value); - bool value; + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); + bool val; int err; =20 - err =3D fw_attr->get_value(fw_attr->galaxybook, &value); + err =3D power_on_lid_open_acpi_get(galaxybook, &val); if (err) return err; =20 - return sysfs_emit(buf, "%u\n", value); + *val_idx =3D val; + + return 0; } =20 -static ssize_t current_value_store(struct kobject *kobj, struct kobj_attri= bute *attr, - const char *buf, size_t count) +static int power_on_lid_open_write(struct device *dev, long id, int val_id= x) { - struct galaxybook_fw_attr *fw_attr =3D - container_of(attr, struct galaxybook_fw_attr, current_value); - struct samsung_galaxybook *galaxybook =3D fw_attr->galaxybook; - bool value; + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); + + return power_on_lid_open_acpi_set(galaxybook, val_idx ? true : false); +} + +DEFINE_FWAT_ENUM_GROUP(power_on_lid_open, "Power On Lid Open", galaxybook_= possible_vals, + false, 0644, FWAT_ENUM_ALL_ATTRS); + +static int usb_charging_read(struct device *dev, long id, int *val_idx) +{ + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); + bool val; int err; =20 - if (!count) - return -EINVAL; - - err =3D kstrtobool(buf, &value); + err =3D usb_charging_acpi_get(galaxybook, &val); if (err) return err; =20 - guard(mutex)(&galaxybook->fw_attr_lock); + *val_idx =3D val; =20 - err =3D fw_attr->set_value(galaxybook, value); + return 0; +} + +static int usb_charging_write(struct device *dev, long id, int val_idx) +{ + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); + + return usb_charging_acpi_set(galaxybook, val_idx ? true : false); +} + +DEFINE_FWAT_ENUM_GROUP(usb_charging, "USB Charging", galaxybook_possible_v= als, + false, 0644, FWAT_ENUM_ALL_ATTRS); + +static int block_recording_read(struct device *dev, long id, int *val_idx) +{ + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); + bool val; + int err; + + err =3D block_recording_acpi_get(galaxybook, &val); if (err) return err; =20 - return count; + *val_idx =3D val; + + return 0; } =20 -#define NUM_FW_ATTR_ENUM_ATTRS 6 - -static int galaxybook_fw_attr_init(struct samsung_galaxybook *galaxybook, - const enum galaxybook_fw_attr_id fw_attr_id, - int (*get_value)(struct samsung_galaxybook *galaxybook, - bool *value), - int (*set_value)(struct samsung_galaxybook *galaxybook, - const bool value)) +static int block_recording_write(struct device *dev, long id, int val_idx) { - struct galaxybook_fw_attr *fw_attr; - struct attribute **attrs; =20 - fw_attr =3D devm_kzalloc(&galaxybook->platform->dev, sizeof(*fw_attr), GF= P_KERNEL); - if (!fw_attr) - return -ENOMEM; + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); =20 - attrs =3D devm_kcalloc(&galaxybook->platform->dev, NUM_FW_ATTR_ENUM_ATTRS= + 1, - sizeof(*attrs), GFP_KERNEL); - if (!attrs) - return -ENOMEM; - - attrs[0] =3D &fw_attr_type.attr; - attrs[1] =3D &fw_attr_default_value.attr; - attrs[2] =3D &fw_attr_possible_values.attr; - attrs[3] =3D &fw_attr_display_name_language_code.attr; - - sysfs_attr_init(&fw_attr->display_name.attr); - fw_attr->display_name.attr.name =3D "display_name"; - fw_attr->display_name.attr.mode =3D 0444; - fw_attr->display_name.show =3D display_name_show; - attrs[4] =3D &fw_attr->display_name.attr; - - sysfs_attr_init(&fw_attr->current_value.attr); - fw_attr->current_value.attr.name =3D "current_value"; - fw_attr->current_value.attr.mode =3D 0644; - fw_attr->current_value.show =3D current_value_show; - fw_attr->current_value.store =3D current_value_store; - attrs[5] =3D &fw_attr->current_value.attr; - - attrs[6] =3D NULL; - - fw_attr->galaxybook =3D galaxybook; - fw_attr->fw_attr_id =3D fw_attr_id; - fw_attr->attr_group.name =3D galaxybook_fw_attr_name[fw_attr_id]; - fw_attr->attr_group.attrs =3D attrs; - fw_attr->get_value =3D get_value; - fw_attr->set_value =3D set_value; - - return sysfs_create_group(&galaxybook->fw_attrs_kset->kobj, &fw_attr->att= r_group); + return block_recording_acpi_set(galaxybook, val_idx ? true : false); } =20 -static void galaxybook_kset_unregister(void *data) -{ - struct kset *kset =3D data; - - kset_unregister(kset); -} - -static void galaxybook_fw_attrs_dev_unregister(void *data) -{ - struct device *fw_attrs_dev =3D data; - - device_unregister(fw_attrs_dev); -} +DEFINE_FWAT_ENUM_GROUP(block_recording, "Block Recording", galaxybook_poss= ible_vals, + false, 0644, FWAT_ENUM_ALL_ATTRS); =20 static int galaxybook_fw_attrs_init(struct samsung_galaxybook *galaxybook) { + struct fwat_device *fdev; bool value; int err; =20 - err =3D devm_mutex_init(&galaxybook->platform->dev, &galaxybook->fw_attr_= lock); - if (err) - return err; - - galaxybook->fw_attrs_dev =3D device_create(&firmware_attributes_class, NU= LL, MKDEV(0, 0), - NULL, "%s", DRIVER_NAME); - if (IS_ERR(galaxybook->fw_attrs_dev)) - return PTR_ERR(galaxybook->fw_attrs_dev); - - err =3D devm_add_action_or_reset(&galaxybook->platform->dev, - galaxybook_fw_attrs_dev_unregister, - galaxybook->fw_attrs_dev); - if (err) - return err; - - galaxybook->fw_attrs_kset =3D kset_create_and_add("attributes", NULL, - &galaxybook->fw_attrs_dev->kobj); - if (!galaxybook->fw_attrs_kset) - return -ENOMEM; - err =3D devm_add_action_or_reset(&galaxybook->platform->dev, - galaxybook_kset_unregister, galaxybook->fw_attrs_kset); - if (err) - return err; + fdev =3D devm_fwat_device_register(&galaxybook->platform->dev, DRIVER_NAM= E, galaxybook, NULL); + if (IS_ERR(fdev)) + return PTR_ERR(fdev); =20 err =3D power_on_lid_open_acpi_get(galaxybook, &value); if (!err) { - err =3D galaxybook_fw_attr_init(galaxybook, - GB_ATTR_POWER_ON_LID_OPEN, - &power_on_lid_open_acpi_get, - &power_on_lid_open_acpi_set); + err =3D fwat_create_group(fdev, &power_on_lid_open_group_data); if (err) return err; } =20 err =3D usb_charging_acpi_get(galaxybook, &value); if (!err) { - err =3D galaxybook_fw_attr_init(galaxybook, - GB_ATTR_USB_CHARGING, - &usb_charging_acpi_get, - &usb_charging_acpi_set); + err =3D fwat_create_group(fdev, &usb_charging_group_data); if (err) return err; } @@ -1107,10 +988,7 @@ static int galaxybook_fw_attrs_init(struct samsung_ga= laxybook *galaxybook) =20 galaxybook->has_block_recording =3D true; =20 - return galaxybook_fw_attr_init(galaxybook, - GB_ATTR_BLOCK_RECORDING, - &block_recording_acpi_get, - &block_recording_acpi_set); + return fwat_create_group(fdev, &block_recording_group_data); } =20 /* --=20 2.50.0 From nobody Tue Oct 7 21:18:30 2025 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB14F1E833D; Sat, 5 Jul 2025 03:34:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686486; cv=none; b=ZnUiQtgHnxaMZlT1Gik1/TrOtPYBabcRCYghr4dQgs+rkvOtrnCV8zknNO6cShod3B4dhFfV/ScYBqkl4O/cqPrYX34pFsXw5cNEuzKMv1nCbYqGrlzGxf2Mr2iYb6rmyHs5jWhOs3Y81+bkYkrzmvA6R5RStIXOKAv5J/kvq50= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686486; c=relaxed/simple; bh=PGzNmxKPeKeIW9y3SLrZgxUtNxszaOvcO3mqQbh5IU4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DIcfvrGY5dW/vWjvEhb5f6fY33ISBuyTnKDK4RzUc/aRpUJL8lusplVzepx2xa7RpkLxBKLOWvKk2J4XkLi4EtyWOdrUkgPQMFIkBFwMIZbVQ0O/FQozV4oAJ1vrqK8CTVEtAbbNO/++s/xfdO7T1NIgAHUGsS73SDzj+IE0y8I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ByJlUMkY; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ByJlUMkY" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-4a44b3526e6so23058511cf.0; Fri, 04 Jul 2025 20:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751686484; x=1752291284; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SXIjFbe4Vrz2bi8rFlLHVCaoVK6EIDR/YQX7SQMy1sc=; b=ByJlUMkYBepacORcc6b4fWAjEW6wFw9NBADu7HzVHuj0Pf7UEk4pT0QyidZqp9Y57y MIUQROBOlfeHSjRL0BL8V8MOWbFi/91OtoLu5DqJDAWHmuSq8CphjjOfJcao0Xqu3Rol KdMohXidWsORwEm2kGdCFB3SNpw3bZEGo/Zo1KDwkA28jko+ZUi5pygGeCSPbffxEVyR ewuIClN+xxGO5fZmL+f7ME6mFg1vxwrusjBs6VTujImFAizDRbUYcm8kNO8k29WpUzUF aNVm5LKvGEhLsKtHh91Q5266kYj/wV4SMYX6uieXmeHYw9Jz9TtY0S1is0Bwq4RXu38Q P5vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751686484; x=1752291284; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SXIjFbe4Vrz2bi8rFlLHVCaoVK6EIDR/YQX7SQMy1sc=; b=HM0Z4Qga3X9qq1Rc6X/KV3fwcGsodGfLwmlRsJxnyr83/jWmSpU/obrUFWmTn2CssI UafyHQcl5bBxcHTeIhmk7vbmbt6qPPu+cB455Axi9NoEuP1+5+alUL0B5iRC6pe0DAZL qo2HLULLyxvOqswQh5IH+BixL7TWGDwEFpnxY+0MTvA78aBj0XtiAIanT4FRKQOgMuKl /R8ZMTX3zKrnPC+XdVf3YqAmO83OYEEYOkpKbhkXTak1BrzQPfM1NLLVGs6VkFfDlYuz jcSX/6I0G4GxOHz7NDq+quG5/V3JHoNqT0rMj17+E85n00EeCLJGHxuS/y66xShXfgpe TJgw== X-Forwarded-Encrypted: i=1; AJvYcCXOfT1NOJtPueegklaTXICrt5P9Hp39r7PTrx1h+a5qGTXafuSDyup9+Y/SLzPQa8RmPdI6Q7Goyt258UKce/m/ynjdRw==@vger.kernel.org, AJvYcCXgbNCBEi3Z0/Jc9ZsRUChkvnNLga2vc6grq64VnSy0BuL/57t8OlEt3fErEJSQb+Nox+ikfr9uAT+Y0/I=@vger.kernel.org X-Gm-Message-State: AOJu0YwFBKhEjEVjU/Fetp96IF0nfChnBDQ8UsFhVBqViynisD+NXsgm rCEVDacGy5Mmne253Aem6RnpBa9XugqaOFZXp/cX6rdeY/Pw15blX+TY X-Gm-Gg: ASbGncuwgavZwFPGpxg8Sod3eJVtVsP3h3Dcj+kh3hZJsfXGpEC9JjPoU3LDyNrljf2 T3xyNxFXTr0OEDsPm8GZ6RpSSJJWQ4KTdLm8JDNxfmCNLALTBnUZg9EVS4cKDV4GMZcWkmM51MX v3l/GAvvHHQHPBUt9i2MVoTieK9Wt2LrpuJE1lUhfZw3EAz+YbMTjrxXJuVaWqMAsarF9ezmBEO o1fs/OtVPg6TFMjvVYILHcWMz/1MNn8gcDPBC20+ipovJBMzNcnj24NTxEOol+RZ4VJ231jlnE3 YKqVt62Yopd94YZwJLr+w+rpjyN0Oy+oyqubuXFER2cB0g5QTs0I1Z/+B7/+T2tNgTMxrbnA X-Google-Smtp-Source: AGHT+IEEL+nGQOQKOqbHnIIL062aFeOFyIJtWqnNnWtY8TBhIxolpSi25iRRGZvQnCMlcsZgGHMtcg== X-Received: by 2002:a05:622a:298c:b0:4a4:2c92:27e3 with SMTP id d75a77b69052e-4a9a695de82mr20294141cf.34.1751686483600; Fri, 04 Jul 2025 20:34:43 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4a48sm25850281cf.13.2025.07.04.20.34.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 20:34:43 -0700 (PDT) From: Kurt Borja Date: Sat, 05 Jul 2025 00:34:00 -0300 Subject: [PATCH v5 5/6] Documentation: ABI: Update sysfs-class-firmware-attributes documentation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250705-fw-attrs-api-v5-5-60b6d51d93eb@gmail.com> References: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> In-Reply-To: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=756; i=kuurtb@gmail.com; h=from:subject:message-id; bh=PGzNmxKPeKeIW9y3SLrZgxUtNxszaOvcO3mqQbh5IU4=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBkZc202WJmJ+Kr1H9NsEjln++1c/zwGa+EPAQ8Xud7N7 ZPYJmrYUcrCIMbFICumyNKesOjbo6i8t34HQu/DzGFlAhnCwMUpABPZaczwT3fejkUt7mb6H/VO tQi6iO35IrtuB/uNhMyHh2e/PDlF24Thr4SAav4yu6npDxd2zzkhqbH9kbX+krytPz/wTrgnzWp +jxsA X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Add a simple boolean type. Signed-off-by: Kurt Borja --- Documentation/ABI/testing/sysfs-class-firmware-attributes | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/ABI/testing/sysfs-class-firmware-attributes b/Do= cumentation/ABI/testing/sysfs-class-firmware-attributes index 2713efa509b465a39bf014180794bf487e5b42d6..64b8d5d49716e8387fee26e3e56= 910862f6a4f5c 100644 --- a/Documentation/ABI/testing/sysfs-class-firmware-attributes +++ b/Documentation/ABI/testing/sysfs-class-firmware-attributes @@ -18,6 +18,7 @@ Description: =20 The following are known types: =20 + - boolean - enumeration: a set of pre-defined valid values - integer: a range of numerical values - string --=20 2.50.0 From nobody Tue Oct 7 21:18:30 2025 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C63028BAAF; Sat, 5 Jul 2025 03:34:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686489; cv=none; b=MZ+wOJYQmQl07Lj6pf3oIVZtwwPiMJ5Q5D2/4z39oBwRdyOjgrv2qdBWGF7ODHJJuZ6+sjQlywYbMjrFcx3xMUwBNzQRUI7WcBQPEIdfIp9DxNItca91X4MBVy/wm1vDOBLleKa09PpTW7dwtvc41TO/EvbqfO02b8BxmhOOz0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751686489; c=relaxed/simple; bh=hOd6+qOcYjH/w/j3ddYeY0GLTSBfqJE3weH99urGytI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ay8b1XrdLyd0xSslp5CISRnCwD6v0peSnxxFofvLcDKMq6hoqSXOp0o8Fw9ef1LZL8OXjrTZwfCcmNQoZjwTg48NA+kz8AoEvXloAwDw4CGb661RBMHkJ+EDO6WVdy/U9NUh7fBbtmNQlq5g4lMkPQr2DwHh7ZoHYaapP7v++vQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J1cbvPRT; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J1cbvPRT" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4a58ebece05so18652481cf.1; Fri, 04 Jul 2025 20:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751686487; x=1752291287; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3DnWNuVGlcxt97iON5+GLNil5h81EohwejutmAGRqZY=; b=J1cbvPRTwYV7HBDrsBaKyYrhMGYgJA8zVc1k9cG3PijFbQXx603UK99NLkyUsGC4HM CjvQ1LzssZay/LLRLnCm2Yebh2leZgCXpcSe7DJw+CFguspCyT8xVYx84+A1gyy2be8M cbDoxmWMuIsPWFlrNlZ1OKDDEAfWruGdusRolbV9ndSOVNspFKT3vbudz2/p6LCu4qgK 60OYSPEKiB3+HB/MdvoIxKok+PN2hZw7TpDFZhWd08HYhri0pr2eQzKUipAdj242qqNl kljP2mdScfuRvvb/2xd75S+o+E/EGI2l7oe4xCWaB4N2p6+xZ9oRX+3fe6EDtL+mCb7Z zVPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751686487; x=1752291287; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3DnWNuVGlcxt97iON5+GLNil5h81EohwejutmAGRqZY=; b=LG2mitAHQdNQ7imPg0ru0DSqFE2N0Rukg1YetASJelQMpoJvcRkaSV7uMoOx6TPxay U5F7BRYDhrjVBobaGCSZ7chID9gPhLRuyiJUaMIUs4JMmekklZ4keBA8MemF72/bFMws H4YYnX9t9Q8SPyMvOYnoOoQnz3Ma/hSXnBofGNaxrgi9XNZ5LJl5Mo0cIJLXHBAHdvXU q0fTNMpQpioYK1Vus//C1vX/fIS655plnJyTUDyRWJ+aEynLjb51TjXaqQmjQLyQcsbs 9/KR+bTRO9JD40GwxWj51PMj2vmP2QTtiJd/sGswZAqGcRz3aEzl2LE/+ShyzgHGagpA RARQ== X-Forwarded-Encrypted: i=1; AJvYcCUVKmeV3JiiExe53T2kSwUpBzlJGLyM0ryGlasxN3wJOSbkqeiJmMSVQQZpW/O6d/8WHrN3fcGPqEc9C6A=@vger.kernel.org, AJvYcCXWRWxoUHesu+OICxjbz7303+1BQ41fo7hDn1LWK0qzuxOSUbP+iJ0c8NgC80C5hZEWGS0xkC+c1f0G8A4Z7K9P2Q/Anw==@vger.kernel.org X-Gm-Message-State: AOJu0Yw6CHGasRupyenP0O4Vi9EUxpOe6Y3XZup+ZXW/AhE1yOna0sVC 0PCl5+8aww+ZyIYmMRfLvxRqHQOzMoROzFjKu625hROXOn1QpDXIaIop X-Gm-Gg: ASbGncsbvuBUMPO4wZhIwd4lo6lFbwydEktCmMQXhjXlq/tSJ7dGk3cX/PZSMLJdGEK WeBFRcNoN5BoCHZNst/Q8d9wbnsZROG4T6CgQnmbA0GLsaeBitj1a+YB5ZrWwJdpprXIAZ9jT2p PnuttuTpc+WCrPo1H5Ckd6Q0B9Rp5cnK4rtENynl1VNQ2KM0fEfErJaYe5JoSj66xvuYrWedzF/ 7OTxno68+m8fuKhxa3iecNuyxeeZcc89AywInHJY6fg3TEfKgiPyyTvTADCN8YidXno843aubH9 toKITTpXO7Nwn8nTrYXHIBw0kOqu0ew/1I39bgcLqNH+uxm1hhPZzQ8MO67mfA== X-Google-Smtp-Source: AGHT+IHrDdoTE2f9tihUfrdXEUCbU8AFPiaXN13MoT//IKpgavZ7+H3EahWcMhecuTgSgt46Vlj2iw== X-Received: by 2002:a05:622a:1e87:b0:4a9:8ddf:83e7 with SMTP id d75a77b69052e-4a99672a3bcmr78983931cf.39.1751686487284; Fri, 04 Jul 2025 20:34:47 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4a48sm25850281cf.13.2025.07.04.20.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 20:34:47 -0700 (PDT) From: Kurt Borja Date: Sat, 05 Jul 2025 00:34:01 -0300 Subject: [PATCH v5 6/6] MAINTAINERS: Add FIRMWARE ATTRIBUTES CLASS entry Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250705-fw-attrs-api-v5-6-60b6d51d93eb@gmail.com> References: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> In-Reply-To: <20250705-fw-attrs-api-v5-0-60b6d51d93eb@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=875; i=kuurtb@gmail.com; h=from:subject:message-id; bh=hOd6+qOcYjH/w/j3ddYeY0GLTSBfqJE3weH99urGytI=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBkZc20PTt4SaJVd98p/q6BW/ETJxUpfTsfMvZqTXH1tt s2PPUHlHaUsDGJcDLJiiiztCYu+PYrKe+t3IPQ+zBxWJpAhDFycAjARbk5Ghn8rE44FlxXc2zfZ ZlKAlO625tyzJTXh10s1226FB9b0BzH8M5UNz3iy/LdpS0WL549ovya2w4I7mQ5+evW0USz3shI PLwA= X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Add entry for the FIRMWARE ATTRIBUTES CLASS. Signed-off-by: Kurt Borja --- MAINTAINERS | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c14614613377df7f40565c6df50661fe3f510034..c799f603e9210e4703eeb1f0ac9= d6b9e8bd469c5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9352,6 +9352,14 @@ F: include/linux/firewire.h F: include/uapi/linux/firewire*.h F: tools/firewire/ =20 +FIRMWARE ATTRIBUTES CLASS +M: Kurt Borja +L: platform-driver-x86@vger.kernel.org +S: Maintained +F: drivers/platform/x86/firmware_attributes_class.c +F: include/linux/firmware_attributes_class.h +K: (devm_)?fwat_device_(un)?register + FIRMWARE FRAMEWORK FOR ARMV8-A M: Sudeep Holla L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) --=20 2.50.0