From nobody Wed Oct 8 01:01:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54D6320C004; Fri, 4 Jul 2025 04:23:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751603020; cv=none; b=ksOX+Jil+C+B4A7u3ffw/YabjI0tcmJ900t0m/aE5ke/lyxbrkbT/rLJ3CVx7+JI5y6L84Ce7u/fLoqq4WW7BHC+sU1LvSOCudGNy1sTIZwv8porzRdw+3pw5LSXa82aoWKa36OnbidNHEyLabNvHv8O0GzLAF+2XRp+1yK8GVw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751603020; c=relaxed/simple; bh=67XBFQJx9vgOGh9HYwd5EPtGelqpXURPeqiAnhwiVtU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=E/Nur0Vue1WDD3ZDDn5GBoiAuXBcViV/La7DRJyFefrQKz5KT7aSc4khhVrfls5E/Xq3dawIDTYGvYi5PaxRoVUacsGk4E3Ch3GauYEW+g363M0a/yetperh+R0iaC1bTuMU1aNoXBJNhI8pwbiJlrJIPkLeH+V7blTDNJsc6Ms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BnSV6SLK; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BnSV6SLK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751603019; x=1783139019; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=67XBFQJx9vgOGh9HYwd5EPtGelqpXURPeqiAnhwiVtU=; b=BnSV6SLK5N4vA0y+fw9GQZQHiEEg46FT18xzNTd4xZDxc/eNR4G5C8Uy 1cXRNtlUpGo1qxF4x3OfylAjWvdPabsMlJPnaYcj6zpvFDnoIjNGIglFU tFZzVU+oKCZSCmYa5/WFdmRoQIf1HahWIYQaB7GfUlcWMVA7ZV+ntnei9 uZfzYfZh9Abo5639tM9/rLqyJfIfBmz9HXLgKfaNGCfmswaHYQ4Vfg6y+ 7+cJ9Rj9WHXoe9oPEeGNxvtSPiTJb5VMVY2bsood8Sqg7+wkgs5gNtcDK eQF/QYbHdV6OPRaAlV1cq85+OUJh+tHpJy35OgPlSv2gEjPGfLx+6LfD8 Q==; X-CSE-ConnectionGUID: K2ySSIEqSP2zNuinM28bOw== X-CSE-MsgGUID: dzCz8PPzRFupYfQgO0wkWQ== X-IronPort-AV: E=McAfee;i="6800,10657,11483"; a="53909140" X-IronPort-AV: E=Sophos;i="6.16,286,1744095600"; d="scan'208";a="53909140" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2025 21:23:26 -0700 X-CSE-ConnectionGUID: qLyqzMLLQ7iZNvpsrvEsFQ== X-CSE-MsgGUID: RY/Rd+qVQsSf6Lxgr2ABMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,286,1744095600"; d="scan'208";a="153968705" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by orviesa006.jf.intel.com with ESMTP; 03 Jul 2025 21:23:26 -0700 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, vinicius.gomes@intel.com Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v10 15/25] crypto: iaa - Disable iaa_verify_compress by default. Date: Thu, 3 Jul 2025 21:23:13 -0700 Message-Id: <20250704042323.10318-16-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250704042323.10318-1-kanchana.p.sridhar@intel.com> References: <20250704042323.10318-1-kanchana.p.sridhar@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch makes it easier for IAA hardware acceleration in the iaa_crypto driver to be loaded by default with "iaa_verify_compress" disabled, to facilitate performance comparisons with software compressors (which also do not run compress verification by default). Earlier, iaa_crypto compress verification used to be enabled by default. The iaa_crypto driver documentation has been updated with this change. With this patch, if users want to enable compress verification, they can do so with these steps: 1) disable all the IAA device/wq bindings that happen at boot time 2) rmmod iaa_crypto 3) modprobe iaa_crypto 4) echo 1 > /sys/bus/dsa/drivers/crypto/verify_compress 5) re-run initialization of the IAA devices and wqs Signed-off-by: Kanchana P Sridhar --- Documentation/driver-api/crypto/iaa/iaa-crypto.rst | 2 +- drivers/crypto/intel/iaa/iaa_crypto_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst b/Documenta= tion/driver-api/crypto/iaa/iaa-crypto.rst index 8e0e98d509720..bc5912f22ae1f 100644 --- a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst +++ b/Documentation/driver-api/crypto/iaa/iaa-crypto.rst @@ -239,7 +239,7 @@ The available attributes are: =20 echo 0 > /sys/bus/dsa/drivers/crypto/verify_compress =20 - The default setting is '1' - verify all compresses. + The default setting is '0' - to not verify compresses. =20 - sync_mode =20 diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/in= tel/iaa/iaa_crypto_main.c index cf12257f7400d..09d786e85ab66 100644 --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c @@ -120,7 +120,7 @@ static bool iaa_distribute_decomps; static bool iaa_distribute_comps =3D true; =20 /* Verify results of IAA compress or not */ -static bool iaa_verify_compress =3D true; +static bool iaa_verify_compress; =20 /* * The iaa crypto driver supports three 'sync' methods determining how --=20 2.27.0