From nobody Wed Oct 8 00:39:45 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D56E12F2C7B; Thu, 3 Jul 2025 18:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751567717; cv=none; b=U8xt2Q2lBS7aD4gNYMrXcZn62ui8XjvkCorWpVNmgzg1Xun4kVWDHKNis1cBblvhk68kPRF50yqHKDcB1aAokMj2zDyolMoXLryz3v57nVFVenMcsQqdmFQiTOv9H6OnbEffEs12dpP5q499sCFGXNgDMHthmDbmpbDVBqvOFJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751567717; c=relaxed/simple; bh=9jb2HLI9HrPZc5LhaUHkznBv5LXACEW22xeTnBLCoi0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FDOxhjKQYzf7NjldbI7edrsjlC0naNmNs7EIo6GCe7W95MhkHtvoOE8W8IJVxB7qM5gCbBVkAiYm+OYdCo1gJhKcM/xjXR48gKMFc9D5fYXRjHhFbb99HTuqvqvZP4Oi4wjago7/xAVXlqO2WefFHJAPQdDFQ1IAeTWwmRMfYl0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fbu0Pmtu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fbu0Pmtu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88A50C4CEE3; Thu, 3 Jul 2025 18:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751567717; bh=9jb2HLI9HrPZc5LhaUHkznBv5LXACEW22xeTnBLCoi0=; h=From:To:Cc:Subject:Date:From; b=fbu0PmtuWC2GHVZSZNyBmOQD1mxvq6kYdXkW2FM1JSYB+I+vH9ljZS16YYVZIj2vD aDL6ezVHjRe/XjOBeBR6NNZcT1fokxdggvz2MOCFomJS4wyk/soWy9H3ydAnxM8fzt v9bXUvP3dMKjX2hdjfbRc7G3QWQtcTBDGn1KeLASvZobFtIRCRZq9TWxLsyYY6Dcma MydtI83vGfDLFvj+Er9QgOncX+cHKdCZPzsTXu39CivQistF+pTPIU+Ml29OAuRg2h mrCilhUS92/eDOLb7cyx7OuqTDlYFGtvefyTrhENHgJqMAzZ+hjNx8ScEd8OBMTdMH qaCqoc6qmT1fA== From: "Rob Herring (Arm)" To: Hans de Goede , Helge Deller Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] fbdev: simplefb: Use of_reserved_mem_region_to_resource() for "memory-region" Date: Thu, 3 Jul 2025 13:35:13 -0500 Message-ID: <20250703183514.2074928-1-robh@kernel.org> X-Mailer: git-send-email 2.47.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the newly added of_reserved_mem_region_to_resource() function to handle "memory-region" properties. The error handling is a bit different. "memory-region" is optional, so failed lookup is not an error. But then an error in of_address_to_resource() is treated as an error. However, that distinction is not really important. Either the region is available and usable or it is not. So now, it is just of_reserved_mem_region_to_resource() which is checked for an error. Signed-off-by: Rob Herring (Arm) --- drivers/video/fbdev/simplefb.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c index be95fcddce4c..1893815dc67f 100644 --- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c @@ -21,9 +21,9 @@ #include #include #include -#include #include #include +#include #include #include #include @@ -134,7 +134,7 @@ struct simplefb_params { static int simplefb_parse_dt(struct platform_device *pdev, struct simplefb_params *params) { - struct device_node *np =3D pdev->dev.of_node, *mem; + struct device_node *np =3D pdev->dev.of_node; int ret; const char *format; int i; @@ -174,19 +174,10 @@ static int simplefb_parse_dt(struct platform_device *= pdev, return -EINVAL; } =20 - mem =3D of_parse_phandle(np, "memory-region", 0); - if (mem) { - ret =3D of_address_to_resource(mem, 0, ¶ms->memory); - if (ret < 0) { - dev_err(&pdev->dev, "failed to parse memory-region\n"); - of_node_put(mem); - return ret; - } - + ret =3D of_reserved_mem_region_to_resource(np, 0, ¶ms->memory); + if (!ret) { if (of_property_present(np, "reg")) dev_warn(&pdev->dev, "preferring \"memory-region\" over \"reg\" propert= y\n"); - - of_node_put(mem); } else { memset(¶ms->memory, 0, sizeof(params->memory)); } --=20 2.47.2