From nobody Wed Oct 8 02:22:57 2025 Received: from lelvem-ot02.ext.ti.com (lelvem-ot02.ext.ti.com [198.47.23.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF942278773; Thu, 3 Jul 2025 18:08:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.235 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751566092; cv=none; b=ZzstSTbTC/NXqZ5RT+hkM7HCN42zIuqTUL+rOV8k5HhL49Arj5+x66cL6tAlJf6x3DMAi2Gtxvu5dkAdvrNlCvktEMz+n6CnDEOA3EWCUkSJUDcGwZMrQtu4vFpvx3iuit0T8HdCW3UB8M0w6EuVfT8u0kiVB2wAio3ILSTNvlU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751566092; c=relaxed/simple; bh=i6tKxEuNcD+G3UxzVGGlc6hiHq4a95HioUMYUjqtpEI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uEpgj2K1aLos2nbnCa/KLisQSx6k/s9KNFwePstrTlObUZcDVOhDw7bMls8CHfNRb6xz/7XpPX8APu5TgwNHB0AXINYlXFutsez5r/+PHOMicaa5wPfeMMcUzdP8f7tHtAomvFuLjqQW6zqV2Kxk86WwDdSEXzL/OhXjezfcb6M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=UVYIWrso; arc=none smtp.client-ip=198.47.23.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="UVYIWrso" Received: from fllvem-sh04.itg.ti.com ([10.64.41.54]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTP id 563I7qZ8092676; Thu, 3 Jul 2025 13:07:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1751566072; bh=HVdfvtwEcQGLkiDPt4ta3EAyLflj1k+V7DiWgjSOcBM=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=UVYIWrsoCP1VY+Q7RibB0bt0AuPIkeKccO4izJmTJflEbsxYssVQW2W6jQxn3OsyU gL8ljUHlyw0IjqAKVhXtdufSXO5z2CpIB5nGTpcGrcVD9TpE7wox/xBJ5gpoiWsgwY oX4DTBl2tnJtJJ1GZsL0onHZfxCqckOJHHk4A3ZE= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllvem-sh04.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 563I7qDY973484 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Thu, 3 Jul 2025 13:07:52 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Thu, 3 Jul 2025 13:07:52 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Thu, 3 Jul 2025 13:07:51 -0500 Received: from DMZ007XYY.dhcp.ti.com (dmz007xyy.dhcp.ti.com [128.247.29.251]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 563I7pSd1546973; Thu, 3 Jul 2025 13:07:51 -0500 From: Shree Ramamoorthy To: , , , , , , , , , CC: , , Subject: [PATCH v6 1/2] gpio: tps65219: Update _IDX & _OFFSET macro prefix Date: Thu, 3 Jul 2025 13:07:50 -0500 Message-ID: <20250703180751.168755-2-s-ramamoorthy@ti.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250703180751.168755-1-s-ramamoorthy@ti.com> References: <20250703180751.168755-1-s-ramamoorthy@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Content-Type: text/plain; charset="utf-8" TPS65215 and TPS65219 are overlapping PMIC devices. While their regulator features differe, the GPIO features are the same. In the TPS65219 MFD driver, the 2 PMICs share the same "tps65219-gpio" compatible string to limit support for TPS65215 in this GPIO driver to comments. The TPS6521X_GPIO0_IDX and TPS6521X_GPIO0_OFFSET macro name prefixes are updated to indicate these macros apply to both PMICs. Reviewed-by: Roger Quadros Acked-by: Linus Walleij Reviewed-by: Jonathan Cormier Signed-off-by: Shree Ramamoorthy --- drivers/gpio/gpio-tps65219.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c index 526640c39a11..2355eec0cee6 100644 --- a/drivers/gpio/gpio-tps65219.c +++ b/drivers/gpio/gpio-tps65219.c @@ -1,8 +1,8 @@ // SPDX-License-Identifier: GPL-2.0 /* - * GPIO driver for TI TPS65219 PMICs + * GPIO driver for TI TPS65215/TPS65219 PMICs * - * Copyright (C) 2022 Texas Instruments Incorporated - http://www.ti.com/ + * Copyright (C) 2022, 2025 Texas Instruments Incorporated - http://www.ti= .com/ */ =20 #include @@ -13,8 +13,15 @@ #include =20 #define TPS65219_GPIO0_DIR_MASK BIT(3) -#define TPS65219_GPIO0_OFFSET 2 -#define TPS65219_GPIO0_IDX 0 +#define TPS6521X_GPIO0_OFFSET 2 +#define TPS6521X_GPIO0_IDX 0 + +/* + * TPS65215 & TPS65219 GPIO mapping + * Linux gpio offset 0 -> GPIO (pin16) -> bit_offset 2 + * Linux gpio offset 1 -> GPO1 (pin8 ) -> bit_offset 0 + * Linux gpio offset 2 -> GPO2 (pin17) -> bit_offset 1 + */ =20 struct tps65219_gpio { struct gpio_chip gpio_chip; @@ -26,7 +33,7 @@ static int tps65219_gpio_get_direction(struct gpio_chip *= gc, unsigned int offset struct tps65219_gpio *gpio =3D gpiochip_get_data(gc); int ret, val; =20 - if (offset !=3D TPS65219_GPIO0_IDX) + if (offset !=3D TPS6521X_GPIO0_IDX) return GPIO_LINE_DIRECTION_OUT; =20 ret =3D regmap_read(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG, &val); @@ -42,7 +49,7 @@ static int tps65219_gpio_get(struct gpio_chip *gc, unsign= ed int offset) struct device *dev =3D gpio->tps->dev; int ret, val; =20 - if (offset !=3D TPS65219_GPIO0_IDX) { + if (offset !=3D TPS6521X_GPIO0_IDX) { dev_err(dev, "GPIO%d is output only, cannot get\n", offset); return -ENOTSUPP; } @@ -71,7 +78,7 @@ static void tps65219_gpio_set(struct gpio_chip *gc, unsig= ned int offset, int val struct device *dev =3D gpio->tps->dev; int v, mask, bit; =20 - bit =3D (offset =3D=3D TPS65219_GPIO0_IDX) ? TPS65219_GPIO0_OFFSET : offs= et - 1; + bit =3D (offset =3D=3D TPS6521X_GPIO0_IDX) ? TPS6521X_GPIO0_OFFSET : offs= et - 1; =20 mask =3D BIT(bit); v =3D value ? mask : 0; @@ -117,7 +124,7 @@ static int tps65219_gpio_direction_input(struct gpio_ch= ip *gc, unsigned int offs struct tps65219_gpio *gpio =3D gpiochip_get_data(gc); struct device *dev =3D gpio->tps->dev; =20 - if (offset !=3D TPS65219_GPIO0_IDX) { + if (offset !=3D TPS6521X_GPIO0_IDX) { dev_err(dev, "GPIO%d is output only, cannot change to input\n", offset); return -ENOTSUPP; } @@ -131,7 +138,7 @@ static int tps65219_gpio_direction_input(struct gpio_ch= ip *gc, unsigned int offs static int tps65219_gpio_direction_output(struct gpio_chip *gc, unsigned i= nt offset, int value) { tps65219_gpio_set(gc, offset, value); - if (offset !=3D TPS65219_GPIO0_IDX) + if (offset !=3D TPS6521X_GPIO0_IDX) return 0; =20 if (tps65219_gpio_get_direction(gc, offset) =3D=3D GPIO_LINE_DIRECTION_OU= T) @@ -179,5 +186,5 @@ module_platform_driver(tps65219_gpio_driver); =20 MODULE_ALIAS("platform:tps65219-gpio"); MODULE_AUTHOR("Jonathan Cormier "); -MODULE_DESCRIPTION("TPS65219 GPIO driver"); +MODULE_DESCRIPTION("TPS65215/TPS65219 GPIO driver"); MODULE_LICENSE("GPL"); --=20 2.43.0