From nobody Wed Oct 8 02:17:14 2025 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2CE2DE6FC; Thu, 3 Jul 2025 06:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522858; cv=none; b=F2o8GJDDcekZeF68mO4NRcEMj6WPSOKG8NYTEzus0oktmawZ+FD3ISvmnnBTpPHJW/c+6LShwTO6I6L/MU/PsgCHZUTqVcg0sw1cNa/O3PTG9cu9XSEqBdmSu/95dhjXo1RQO7FrhlBnzAE+ZXIuTbFpU1RJn6Rg2R0VBvqmQRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522858; c=relaxed/simple; bh=/P1eHfHl1L4qFmCM4kwBP23IvldlxFppS3yN64Cgcxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e9D8DgZ9sVT02aMU0b0W33KEz+p70HssV9/RYrusrEPKcvhsNvgxX1M8k7BcfroL75XGddVpk2PFjbUVylxsgWG6T/A+3054quOht6LGAFX+m4yTPKo1nkMJkGbpViKyKj7qqVjl6nSV7BRTiJ05G76nDrGB5EMUyS5RrzZzXvs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=kp6R8TIu; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="kp6R8TIu" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 562KSZs0011086; Thu, 3 Jul 2025 06:07:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=xVl1ZnerADps5kjzZ QU5n2XjwSyP/GvOGz6w5Rf0Wug=; b=kp6R8TIuxkUpt81Eab5k+HDb6Eu/vFpW9 5tw7JXiY7NoIpKSZsnaszcH+hgVpTfuM/kPsmx17ce9H7eey6ckP7nWH3YQZNJdU ieUskmlNeEJBvI+SUBpOxL3BVEV19pgA1BWy5dkOigF0pnrfQXtyz2JiBFOriZlu XWtdwggOKu9bNbyBP6Esb59a7RUH+c4GlXt1ex2sH8AenGiBRawLA7W1j5Q7iU/Z lKL8DT6OJYkCHPykIlmRhLlh8hvv9X6C75vBWE4LbTs6yl3LGrV8cfvt/eand26X jwvG/cZ3ASq3n9TdoscKnUkbDfOGYJQnfKX9Ebh6OzepC2qDzyuSQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j82g19j1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:16 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 56366xZT028836; Thu, 3 Jul 2025 06:07:15 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j82g19hx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:15 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5632noMB006881; Thu, 3 Jul 2025 06:07:15 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 47jvxmk4je-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:14 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 56367BVh56295712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2025 06:07:11 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4F0BE20043; Thu, 3 Jul 2025 06:07:11 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DA44220040; Thu, 3 Jul 2025 06:07:05 +0000 (GMT) Received: from aboo.ibm.com.com (unknown [9.39.26.205]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 3 Jul 2025 06:07:05 +0000 (GMT) From: Aboorva Devarajan To: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com, aboorvad@linux.ibm.com Subject: [PATCH v2 1/7] mm/selftests: Fix incorrect pointer being passed to mark_range() Date: Thu, 3 Jul 2025 11:36:50 +0530 Message-ID: <20250703060656.54345-2-aboorvad@linux.ibm.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703060656.54345-1-aboorvad@linux.ibm.com> References: <20250703060656.54345-1-aboorvad@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Z4mAURdhI9lJQMMn2CZAQuUThE9NPT80 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDA0NCBTYWx0ZWRfX3BGdKC5KA2lZ iqlaOJH9CqbyEDHsjPlEIT0VjfY93mEGPxldrjGbupG8b1m4hfIO6znHqoCVothMiVZFZ9ePJm4 tvAAWLfG3kQ+JPpCj+aio8p/cPnCMJYUUQM84jjJu5Ec/wHV0YIzUeFIMUiELafQWKKiikQ8xTE //h8WuFSI2yPg74zY/w4q4HWgEVJLlwmFpR2QTrZG1n4qzWYa3TYk9d2ZD5XU8EXwa4/nd3wAkb DR8H2n50bfi/SIixgkyFCjeV9YbTcfL974n4t+pW/l9++e0luY21TuxnPyW00SLIxlSHRqbnGj8 CqtHqcYJ/DvEdu/CNOfWKGmlDHlXYzTrmESmjZnDSkOqruydSb722i9hANSz3AuR4n3OX9SNCgA c0wun5Jf8G2jINWwldXaF7L+m1RomQlxwno0q2EzzfISl0VrYSrmE6cfNS18QgkBLIPBre1e X-Authority-Analysis: v=2.4 cv=LpeSymdc c=1 sm=1 tr=0 ts=68661e14 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=USQBeCa_g6oaaad9oeAA:9 X-Proofpoint-GUID: VLtHMn6lJKbdzMCOUOS_LFdvTIcYyUu_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_01,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 mlxscore=0 mlxlogscore=925 phishscore=0 suspectscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030044 Content-Type: text/plain; charset="utf-8" From: Donet Tom In main(), the high address is stored in hptr, but for mark_range(), the address passed is ptr, not hptr. Fixed this by changing ptr[i] to hptr[i] in mark_range() function call. Fixes: b2a79f62133a ("selftests/mm: virtual_address_range: unmap chunks aft= er validation") Signed-off-by: Donet Tom Signed-off-by: Aboorva Devarajan Acked-by: David Hildenbrand Reviewed-by: Dev Jain Reviewed-by: Zi Yan --- tools/testing/selftests/mm/virtual_address_range.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/tes= ting/selftests/mm/virtual_address_range.c index 169dbd692bf5..e24c36a39f22 100644 --- a/tools/testing/selftests/mm/virtual_address_range.c +++ b/tools/testing/selftests/mm/virtual_address_range.c @@ -227,7 +227,7 @@ int main(int argc, char *argv[]) if (hptr[i] =3D=3D MAP_FAILED) break; =20 - mark_range(ptr[i], MAP_CHUNK_SIZE); + mark_range(hptr[i], MAP_CHUNK_SIZE); validate_addr(hptr[i], 1); } hchunks =3D i; --=20 2.43.5 From nobody Wed Oct 8 02:17:14 2025 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFABB291C25; Thu, 3 Jul 2025 06:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522861; cv=none; b=Cq5q9UU6Fb4C+ntzE4yenjyhkzYnzvlZor9k8Yn3bR5yAm/oBY2m443nj1lhhQC0OhYtTCzOus3PX0bQ2uMp1Mvv57kuxvLgkz8YllUjvBVnQUdJorH++1nHGoSsvhyfYkySgrJ1XdeEMzHzMJ39WHk8YZOGjOdmiVrRh5yhqLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522861; c=relaxed/simple; bh=21pULq5A3TF7YG4dFtWsyFOIHRJM8Ew9Cip7tElmeVM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PRIzvzqaQrThPXvOX6mIQ2lSexTsmRx7vW3xmnGEpy3OggcUqH271cA0UPr7LxZlhiaDPKtdpix42J9iB3jH1sNeM2J3aGxuR1jldifasqJqvoPXu+NNnh5++OFUUI0lZxXkcws6fVT07CVVTpUJEZl+44csbUnsqZ/s5P+xdtM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=D3fPPjEq; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="D3fPPjEq" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56365KWL023252; Thu, 3 Jul 2025 06:07:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=u7YIbQiP+/ef1u/7u uFPRUmmaRlSBehAK9LbebQcf3Q=; b=D3fPPjEqas22CSkn0/H/lrYoJa0hGIox5 5Prfae1S0i+M8Rs3x4UsBlvr7nP1gRa8zOUpEptQUn4+SQPh40rcWID49jbL5C+e 4gXcET9QtNGtNoZYAh8DjMChnme8c4Mi2jnxI1F6p97qD82bN5bDdTJwcHe6Hgno tfaQPVomj4cHTyaMFdhZL+5NTohl7ds7R4EvfPSqnpQcAwTOmr6fJZiusWysEPJF TY/lQk8WtZW0yt2USHDErZUfq7bE+CdduMRJ42UyUY5j+oMRjPkeY7u16WGk/WuM 9i4szsAisvLagk/t8BmgkxwKq6c/jq4JN38oxlytO+7f12+UqYXJw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j84dhtey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:23 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 5635vciI006792; Thu, 3 Jul 2025 06:07:22 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j84dhtet-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:22 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5635rbCN032216; Thu, 3 Jul 2025 06:07:21 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47ju40uf0p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:21 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 56367Hk716974318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2025 06:07:17 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4C1662004E; Thu, 3 Jul 2025 06:07:17 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CA86F20043; Thu, 3 Jul 2025 06:07:11 +0000 (GMT) Received: from aboo.ibm.com.com (unknown [9.39.26.205]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 3 Jul 2025 06:07:11 +0000 (GMT) From: Aboorva Devarajan To: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com, aboorvad@linux.ibm.com Subject: [PATCH v2 2/7] selftests/mm: Add support to test 4PB VA on PPC64 Date: Thu, 3 Jul 2025 11:36:51 +0530 Message-ID: <20250703060656.54345-3-aboorvad@linux.ibm.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703060656.54345-1-aboorvad@linux.ibm.com> References: <20250703060656.54345-1-aboorvad@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: tmbFQJNISn6HPBQMdf9Cf-XNvSsH9xNB X-Proofpoint-GUID: uVk-xLyp3Zx-I3ZLfzuU-_vwFZSdFFNq X-Authority-Analysis: v=2.4 cv=Ib6HWXqa c=1 sm=1 tr=0 ts=68661e1b cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=jWZC2Vw2s6trTHuKtcwA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDA0NCBTYWx0ZWRfXzo8+nRTYMaqz VPVFqmxs3+tAq0W7AkhcIxYjwDqUh+vryUl8OSzyk1HSIuU6UocWZVShahFywq245/72GqkRt7h Zv7sCgqwmxHCo2j6a64fZ+RhiXw+xqSnzavdxQh4GnqaMIis9O5lGeFfOdvbY7w0L2eJgnIIbLM Vl8+H03XjBGt5Sbv1hReaBIXr+lpyw1OqbG4Xqc4YLys4agNHggiFecTSTxOisB1pCLUUZHxvD0 GcCrzHMUOvCcPNsUqScHLdMRJdGnIKh83YwStMrkqpS5G049DuGtRi5m7X1MmDQAy3wIJsLGfed VxCow+CLWqFyS59RL6zhQk+Ev8IwK/69rDtyvgkrfgzUOPVPmgd+KcpdDGgstNrjzpa01IjNMrW 1sW694dCDJxI9t9/0V/ww0YMsGfhMfWrsaGysZc2ztEuEn+FNCkrVXejVwtGd5wVrVNKIvzV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_01,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 mlxlogscore=818 lowpriorityscore=0 impostorscore=0 mlxscore=0 malwarescore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030044 Content-Type: text/plain; charset="utf-8" From: Donet Tom PowerPC64 supports a 4PB virtual address space, but this test was previously limited to 512TB. This patch extends the coverage up to the full 4PB VA range on PowerPC64. Memory from 0 to 128TB is allocated without an address hint, while allocations from 128TB to 4PB use a hint address. Signed-off-by: Donet Tom Signed-off-by: Aboorva Devarajan Acked-by: David Hildenbrand Reviewed-by: Dev Jain Reviewed-by: Zi Yan --- tools/testing/selftests/mm/virtual_address_range.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/tes= ting/selftests/mm/virtual_address_range.c index e24c36a39f22..619acf0b9239 100644 --- a/tools/testing/selftests/mm/virtual_address_range.c +++ b/tools/testing/selftests/mm/virtual_address_range.c @@ -50,6 +50,7 @@ #define NR_CHUNKS_256TB (NR_CHUNKS_128TB * 2UL) #define NR_CHUNKS_384TB (NR_CHUNKS_128TB * 3UL) #define NR_CHUNKS_3840TB (NR_CHUNKS_128TB * 30UL) +#define NR_CHUNKS_3968TB (NR_CHUNKS_128TB * 31UL) =20 #define ADDR_MARK_128TB (1UL << 47) /* First address beyond 128TB */ #define ADDR_MARK_256TB (1UL << 48) /* First address beyond 256TB */ @@ -59,6 +60,11 @@ #define HIGH_ADDR_SHIFT 49 #define NR_CHUNKS_LOW NR_CHUNKS_256TB #define NR_CHUNKS_HIGH NR_CHUNKS_3840TB +#elif defined(__PPC64__) +#define HIGH_ADDR_MARK ADDR_MARK_128TB +#define HIGH_ADDR_SHIFT 48 +#define NR_CHUNKS_LOW NR_CHUNKS_128TB +#define NR_CHUNKS_HIGH NR_CHUNKS_3968TB #else #define HIGH_ADDR_MARK ADDR_MARK_128TB #define HIGH_ADDR_SHIFT 48 --=20 2.43.5 From nobody Wed Oct 8 02:17:14 2025 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA074292906; Thu, 3 Jul 2025 06:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522864; cv=none; b=BPrwP6M44SkottmZBIAagD/NRCPFwg4sDeILYtUlfSi/zU/uqHblVSUaDHQq4KANqCjvtNXYAQB/pSkP/0sAAwUV4XngnGcs312w9Dz8BdoJtwAH08vOfkd9kwULSkQes+p1uE77529xKp9pPsj1K0cmq5pvWxlGJVhmKooZw80= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522864; c=relaxed/simple; bh=st9AZr9FBinirERjQRkt+KuQ/Y60pXmEZ5EyAPLbcck=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nHaglP5dbuuB9Q8ZYQz0aSYsmS/WdMDAO5SWLajeKiFheOkmyBN/1wD+gXvZ3uXAEIiwICtxI4Egfe5D/4Fb+bfk2kDcw20KVumXzcwtU9XbTtUIbA4WE7J09Xoyow/p9AuHGyLh8x8D7rGODcLZrnm7Y9+acGtmH+eFkyu1R0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=qUoZ6nbT; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="qUoZ6nbT" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 562Mwk9t019240; Thu, 3 Jul 2025 06:07:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=8SoKOth7WukoanuC5 O8znHCvWYLEtx3ySqY/SXhmPsc=; b=qUoZ6nbTkVEHuNHsJ4uNSxVHKTpOBe+w3 0viuNxBR1aS2lpyqgvBM8FO7i02DRr+FkLR+eutqc8kIpsQbwzYAhMQhyhMaSIYx TYM6Sk2eZplVo0BsaqQASbV8eYUlrk2l3DvnXIMrRngA2KxvjQgGc6iBt6skkpw/ refxTesizxL5iYAK3ESnTBSKamywRvHU7d9UwCOLWBYkA80gZrEVCBxNSKa3kT/S bD63U0QgBG/G/cXEB42xVuUeU6hgx1giB/U7Mi4WC++xFVbzrw2UZJzO3DhMhWAA fMi3pLqmXQsyKx9yHyU92t2Ymr/zvXYCSJ+wWtrFD3aJpXuvePE2w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j6u21f0c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:28 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 56367Sr2006803; Thu, 3 Jul 2025 06:07:28 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j6u21f0a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:28 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 56326sO0021914; Thu, 3 Jul 2025 06:07:27 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47juqpuan5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:27 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 56367Nvt29425938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2025 06:07:23 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6F3D12004B; Thu, 3 Jul 2025 06:07:23 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2E20220043; Thu, 3 Jul 2025 06:07:18 +0000 (GMT) Received: from aboo.ibm.com.com (unknown [9.39.26.205]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 3 Jul 2025 06:07:17 +0000 (GMT) From: Aboorva Devarajan To: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com, aboorvad@linux.ibm.com Subject: [PATCH v2 3/7] selftest/mm: Fix ksm_funtional_test failures Date: Thu, 3 Jul 2025 11:36:52 +0530 Message-ID: <20250703060656.54345-4-aboorvad@linux.ibm.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703060656.54345-1-aboorvad@linux.ibm.com> References: <20250703060656.54345-1-aboorvad@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: iTBI4fHhg2lWJeei_9P1gtvuTVqJHSRz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDA0MCBTYWx0ZWRfXwcuLCf7j22UF 1REt/gZaGtXFFER7Wobn/ZSktMfbDYvvaXy6UDEGk28U/l9HqEZhfrbSwfbtQIRrsqr/D6s9fPw UUl7YJjwRcRdm83SZ/gEielaGEDdlHQMCzQdIIcwhhUr1MJt326i4ygak9Yx0xIJg2VFpDoUTew slftQ1CfIEcfcJDdH5xBBjVaOpZFHYnG3Xz+NE9019iThJPnl/NHozl7/kOv1TRPQgyMHRXAJr5 bOYD5DAJhjg1Unc+Yyy+aKr0nsolwKRNdnxgiQsk/AzlMd3cWu1Rg+48unvUMJgbagv7lNG+Hpy gtUtMMKHoq2a3/R2TYdyRj3iqwYtooXMXviXuaJt462clxQBC00T+GOBu+ukjt5wspM8iSBlsxE TrIevu5+p3DzOJClOMvnFW+HBG6Gu/8oLWAAhqltkzfXQzvjEJ1O/dTJmmL5PZYMQQSunhQi X-Proofpoint-GUID: n5Fw5RbeIM-J-jusQvgRtsy7Mlpx99nO X-Authority-Analysis: v=2.4 cv=GrRC+l1C c=1 sm=1 tr=0 ts=68661e21 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=yVrA2fujCtLeWmk1P3cA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_01,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030040 Content-Type: text/plain; charset="utf-8" From: Donet Tom This patch fixed 2 issues. 1)After fork() in test_prctl_fork, the child process uses the file descriptors from the parent process to read ksm_stat and ksm_merging_pages. This results in incorrect values being read (parent process ksm_stat and ksm_merge_pages will be read in child), causing the test to fail. This patch calls init_global_file_handles() in the child process to ensure that the current process's file descriptors are used to read ksm_stat and ksm_merging_pages. 2) All tests currently call ksm_merge to trigger page merging. To ensure the system remains in a consistent state for subsequent tests, it is better to call ksm_unmerge during the test cleanup phase In the test_prctl_fork test, after a fork(), reading ksm_merging_pages in the child process returns a non-zero value because a previous test performed a merge, and the child's memory state is inherited from the parent. Although the child process calls ksm_unmerge, the ksm_merging_pages counter in the parent is reset to zero, while the child's counter remains unchanged. This discrepancy causes the test to fail. To avoid this issue, each test should call ksm_unmerge during cleanup to ensure the counter is reset and the system is in a clean state for subsequent tests. execv argument is an array of pointers to null-terminated strings. In this patch we also added NULL in the execv argument. Fixes: 6c47de3be3a0 ("selftest/mm: ksm_functional_tests: extend test case f= or ksm fork/exec") Signed-off-by: Donet Tom Signed-off-by: Aboorva Devarajan --- tools/testing/selftests/mm/ksm_functional_tests.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/test= ing/selftests/mm/ksm_functional_tests.c index d8bd1911dfc0..996dc6645570 100644 --- a/tools/testing/selftests/mm/ksm_functional_tests.c +++ b/tools/testing/selftests/mm/ksm_functional_tests.c @@ -46,6 +46,8 @@ static int ksm_use_zero_pages_fd; static int pagemap_fd; static size_t pagesize; =20 +static void init_global_file_handles(void); + static bool range_maps_duplicates(char *addr, unsigned long size) { unsigned long offs_a, offs_b, pfn_a, pfn_b; @@ -274,6 +276,7 @@ static void test_unmerge(void) ksft_test_result(!range_maps_duplicates(map, size), "Pages were unmerged\n"); unmap: + ksm_unmerge(); munmap(map, size); } =20 @@ -338,6 +341,7 @@ static void test_unmerge_zero_pages(void) ksft_test_result(!range_maps_duplicates(map, size), "KSM zero pages were unmerged\n"); unmap: + ksm_unmerge(); munmap(map, size); } =20 @@ -366,6 +370,7 @@ static void test_unmerge_discarded(void) ksft_test_result(!range_maps_duplicates(map, size), "Pages were unmerged\n"); unmap: + ksm_unmerge(); munmap(map, size); } =20 @@ -452,6 +457,7 @@ static void test_unmerge_uffd_wp(void) close_uffd: close(uffd); unmap: + ksm_unmerge(); munmap(map, size); } #endif @@ -515,6 +521,7 @@ static int test_child_ksm(void) else if (map =3D=3D MAP_MERGE_SKIP) return -3; =20 + ksm_unmerge(); munmap(map, size); return 0; } @@ -548,6 +555,7 @@ static void test_prctl_fork(void) =20 child_pid =3D fork(); if (!child_pid) { + init_global_file_handles(); exit(test_child_ksm()); } else if (child_pid < 0) { ksft_test_result_fail("fork() failed\n"); @@ -595,7 +603,7 @@ static void test_prctl_fork_exec(void) return; } else if (child_pid =3D=3D 0) { char *prg_name =3D "./ksm_functional_tests"; - char *argv_for_program[] =3D { prg_name, FORK_EXEC_CHILD_PRG_NAME }; + char *argv_for_program[] =3D { prg_name, FORK_EXEC_CHILD_PRG_NAME, NULL = }; =20 execv(prg_name, argv_for_program); return; @@ -644,6 +652,7 @@ static void test_prctl_unmerge(void) ksft_test_result(!range_maps_duplicates(map, size), "Pages were unmerged\n"); unmap: + ksm_unmerge(); munmap(map, size); } =20 @@ -677,6 +686,7 @@ static void test_prot_none(void) ksft_test_result(!range_maps_duplicates(map, size), "Pages were unmerged\n"); unmap: + ksm_unmerge(); munmap(map, size); } =20 --=20 2.43.5 From nobody Wed Oct 8 02:17:14 2025 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E463D2918EB; Thu, 3 Jul 2025 06:07:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522872; cv=none; b=M7DiF0cjv7eu68hMFerqxVMxq8qQAVw5j8qm6IuiDpkdLFNn6BEKRRe6Mfy/0T5SBuUVBlVrm3QPjJwRQQc5Jr6zXwBX0PTtbOP7EEwuWdA1gt2pLtLDZuzI+w1C6sYuEdg11iXSOBz7mCFw1/s2dLx6LNTJczIkvmbCrTvbuIA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522872; c=relaxed/simple; bh=IzapdKV2obfkfdZJHCbc1SXKfkHoI0pRVCX+FcVFCf8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S1Nm1FMXR8uvFb/3SKgK262wkBb4AOEHkWZT0VVIUthQEKTCMRGqOEzaeFeTyMYXLa5PDXR6SWAloYkUHG4YB6yu/kxt8AYc2jTBglsRvXKAwci6KPqL4UY+fB9jQIUveMtxB2RlAasB/s21vS/ZNnJvl5ymTOgYhwJcGPt/PAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=grsplI4s; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="grsplI4s" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 562JEAHr003793; Thu, 3 Jul 2025 06:07:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=WzwP+9sDG+i2wV/yf iWzzrWqUy0HiJfsMxt3u5SMiHM=; b=grsplI4sPtuCgzQzjOnxpH7J/4193ic7S IsakgE5U/17WwIVXQ+NfmhprlfrUSNKGUmii6T3iqGAfeG69jvdyvjo0OHS/uL++ oQFVdNkhmyIpPysh9IuqJzLbMyqSVtONo9jwgGDT6LAmMa/H2zbquNSTXjCZtw6E 8OPDlWLu0No3AETxS/ManvTTjg1rXMZ8NCQu3vc9zJ1kQrlkJobyxjqTtOH49r4A 12tABR0ncry2/35CXCfKMhHsxvW3wSjTYna9vl7D4Znwd4XYIlc+ezKtFfzBi/6Z Cm+WMUyd+xNrpJCcn8OsnJEn4O/UOOA7E9d/prfDeeD1mY+GqLNMw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j84dhtg0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:35 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 56360Cc3013739; Thu, 3 Jul 2025 06:07:34 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j84dhtfq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:34 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5631n6Fa021928; Thu, 3 Jul 2025 06:07:33 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47juqpuann-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:33 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 56367TON52953554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2025 06:07:29 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5CE342004B; Thu, 3 Jul 2025 06:07:29 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0354220043; Thu, 3 Jul 2025 06:07:24 +0000 (GMT) Received: from aboo.ibm.com.com (unknown [9.39.26.205]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 3 Jul 2025 06:07:23 +0000 (GMT) From: Aboorva Devarajan To: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com, aboorvad@linux.ibm.com Subject: [PATCH v2 4/7] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size Date: Thu, 3 Jul 2025 11:36:53 +0530 Message-ID: <20250703060656.54345-5-aboorvad@linux.ibm.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703060656.54345-1-aboorvad@linux.ibm.com> References: <20250703060656.54345-1-aboorvad@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 19o7swHgACqwZUkAOzAHQED58QoBmdqU X-Proofpoint-GUID: AvOPteWKimfxn-Tf9hFtUKVKH109_3uN X-Authority-Analysis: v=2.4 cv=Ib6HWXqa c=1 sm=1 tr=0 ts=68661e27 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=v8RjUI9D9iq2XQVy_EMA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDA0NCBTYWx0ZWRfX5RsdTM/QzZ7u 8+IpWqxfj9Pzy1qW4rPzKxIJHBH/S3UHSEpa/g+uL4tpYRm5R4UnK53lI3tgjixzxYhfndMeB/h DPW8PKYgDj++nROqEj8X9GH4dw5LKvgmS+UhZPrPFa2AFqxnAgE0m674M/W2uiubmzHBLAr7eDQ C7JPVU9NxbmqvxNJDKXEdH3SmHuWzd/jw/fgZlC0lL1dPSLA+3fB5M6WknSTXbb33sZhYn91C9S 0jwQRd8O18cR7F+AgmUDsMjvpfhI0bRp7XDRXcK06TTLFYBH0g0pAgN8AqpBNf35EijkNYnFPkY 8RGDzYZy9sQXvMooSUBpw8Y8aj6HFbvEiJHp0zE4CrmAWAZu/kA0jl23Vj8HZltm1rWwczk2n08 JK38MsydOXg1lYnUf5qn/4VJlmICitIE4X8WlC2fCLtMbfu456P7x4oQWG7VlBzJY6eI3BmS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_01,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 mlxscore=0 malwarescore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030044 Content-Type: text/plain; charset="utf-8" From: Donet Tom The split_huge_page_test fails on systems with a 64KB base page size. This is because the order of a 2MB huge page is different: On 64KB systems, the order is 5. On 4KB systems, it's 9. The test currently assumes a maximum huge page order of 9, which is only valid for 4KB base page systems. On systems with 64KB pages, attempting to split huge pages beyond their actual order (5) causes the test to fail. In this patch, we calculate the huge page order based on the system's base page size. With this change, the tests now run successfully on both 64KB and 4KB page size systems. Fixes: fa6c02315f745 ("mm: huge_memory: a new debugfs interface for splitti= ng THP tests") Signed-off-by: Donet Tom Signed-off-by: Aboorva Devarajan Reviewed-by: Dev Jain --- .../selftests/mm/split_huge_page_test.c | 23 ++++++++++++++----- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/test= ing/selftests/mm/split_huge_page_test.c index aa7400ed0e99..38296a758330 100644 --- a/tools/testing/selftests/mm/split_huge_page_test.c +++ b/tools/testing/selftests/mm/split_huge_page_test.c @@ -514,6 +514,15 @@ void split_thp_in_pagecache_to_order_at(size_t fd_size= , const char *fs_loc, } } =20 +static unsigned int get_order(unsigned int pages) +{ + unsigned int order =3D 0; + + while ((1U << order) < pages) + order++; + return order; +} + int main(int argc, char **argv) { int i; @@ -523,6 +532,7 @@ int main(int argc, char **argv) const char *fs_loc; bool created_tmp; int offset; + unsigned int max_order; =20 ksft_print_header(); =20 @@ -534,32 +544,33 @@ int main(int argc, char **argv) if (argc > 1) optional_xfs_path =3D argv[1]; =20 - ksft_set_plan(1+8+1+9+9+8*4+2); - pagesize =3D getpagesize(); pageshift =3D ffs(pagesize) - 1; pmd_pagesize =3D read_pmd_pagesize(); if (!pmd_pagesize) ksft_exit_fail_msg("Reading PMD pagesize failed\n"); =20 + max_order =3D get_order(pmd_pagesize/pagesize); + ksft_set_plan(1+(max_order-1)+1+max_order+max_order+(max_order-1)*4+2); + fd_size =3D 2 * pmd_pagesize; =20 split_pmd_zero_pages(); =20 - for (i =3D 0; i < 9; i++) + for (i =3D 0; i < max_order; i++) if (i !=3D 1) split_pmd_thp_to_order(i); =20 split_pte_mapped_thp(); - for (i =3D 0; i < 9; i++) + for (i =3D 0; i < max_order; i++) split_file_backed_thp(i); =20 created_tmp =3D prepare_thp_fs(optional_xfs_path, fs_loc_template, &fs_loc); - for (i =3D 8; i >=3D 0; i--) + for (i =3D (max_order-1); i >=3D 0; i--) split_thp_in_pagecache_to_order_at(fd_size, fs_loc, i, -1); =20 - for (i =3D 0; i < 9; i++) + for (i =3D 0; i < max_order; i++) for (offset =3D 0; offset < pmd_pagesize / pagesize; offset +=3D MAX(pmd_pagesize / pagesize / 4, 1 << i)) --=20 2.43.5 From nobody Wed Oct 8 02:17:14 2025 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E8BD2900AA; Thu, 3 Jul 2025 06:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522878; cv=none; b=Ye3rdc+eJmQ7upSrMyNNUihOBrBMmWbevx4Jp36BrCewbSD2/99zp88pHpHpHVce2fUDO88Tga5J5rTEOT4rd0PCAHAtUzHx4qzTSCoc5JneGzNPN7ZCy6P67ts+jDhx2mAOoGSv62YfnZjdw0eeEbC3qfjUjBYOX5Fah7JoNf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522878; c=relaxed/simple; bh=xffQR6XtmI/H8A1ynAKKmbQlZwiRQq3VZ+lSMaP4An4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ezbn/a4hTLllrJKO4sKLAOYBOPT3eT5Id4fznzwcb/EvGbcJVGO+8HjvSKSlAu4Y+6nvAEcuwBTujfvF/t6zVRXLdmEt4ZEnTRz6xUWfTgj+pMb/dnOlpwtj2EKgnvyQ1Cs9n8QvSedLQUWwVffn0gZp2XSAEJ4e3lAoOkvn2NI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=XAsR6yuP; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="XAsR6yuP" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 562IopE6006998; Thu, 3 Jul 2025 06:07:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=VDWyXk2omXrjUS99H db3lCXn8WFctyIkgn3MVqYwmnk=; b=XAsR6yuPgYoD20HyVM5AFFL9zrrrlCYZS xc+G2RtSDKwf762xgoqOJZEiEMyWE5eiFIG+JS8lDHAP16mGPkxy20LIRW9JcPgt t5RbOPEco68CunqFkmRF6Y/IXJeK5TCqU0HIbrlaDWYFg7pDuu5erbiw3ZzbqRRQ PZ04QEk/z3H5+yWt0LniakPvTcESanmZ91roKBQ0SNoRnVfnXUZzKQy3c30c6GGB VMnYk2aKQB31PYAJIKj1R3ZvYyetDQ3iz1EMdUz2KbS4MZQUkCyqobR/i0Zs5rZV typF0fYYTOQu53TMM4wsOataRW7W8wwqzEWFQfVdi+1OrwtqICzSw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j84dhtg5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:40 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 5635swDI002744; Thu, 3 Jul 2025 06:07:39 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j84dhtg3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:39 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5634Tn5V021112; Thu, 3 Jul 2025 06:07:38 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 47jtqukgkv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:38 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 56367Z2Q35652126 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2025 06:07:35 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 184F420043; Thu, 3 Jul 2025 06:07:35 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CAA1120040; Thu, 3 Jul 2025 06:07:29 +0000 (GMT) Received: from aboo.ibm.com.com (unknown [9.39.26.205]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 3 Jul 2025 06:07:29 +0000 (GMT) From: Aboorva Devarajan To: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com, aboorvad@linux.ibm.com Subject: [PATCH v2 5/7] selftests/mm: Fix child process exit codes in ksm_functional_tests Date: Thu, 3 Jul 2025 11:36:54 +0530 Message-ID: <20250703060656.54345-6-aboorvad@linux.ibm.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703060656.54345-1-aboorvad@linux.ibm.com> References: <20250703060656.54345-1-aboorvad@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 3U-eNkLO9m5wqYelp7ePBLIn-dt9sL5B X-Proofpoint-GUID: ipEo3pKlPSd_UHlIWwQZyB_HGuBjTw3x X-Authority-Analysis: v=2.4 cv=Ib6HWXqa c=1 sm=1 tr=0 ts=68661e2c cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=LodmC_IXZg0r39vkjIAA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDA0NCBTYWx0ZWRfX/jvABfPkIcvQ f8i3H01IqT6gKUS5hk44lSMHZ5ga2kOtAAJdia+g2BA4z8ftDxhWTGY+joYvy4fNbOYPynTI7F0 J3+sSzkP89ofob7lmKE0i+KG1/UUX34GoUA+lhyEkdKwBOpvnELx25EToqpNVthzI9bZMe4siQN vjEBRrwzgivtRo1/YQqZF0nKWauGSVwd3UGJjKmEqC0DM2kHIt9kJrALVf4jec5a41h1L0CX7Bc 2ShSHCuBeNe/ivMRmImGeGls5/s+oz/m/kS3aparJDCwMbIIkafX4Tz15A6g605H5Kz8WQH18Fy LNOICMoi+xdIwJvtjJUroMU2OFlQxJTX81Jt5WSDpL3Z7UQ7gobGD6WxOnMSXSQzO4TnHu0p3rG XeeiBQTKwJhVPtra+qV9mfO+xqIFHIHvYgEe6VtSJ0j318oh0KJGafKMRYrvtPlZhnlM8WiY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_01,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 mlxscore=0 malwarescore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030044 Content-Type: text/plain; charset="utf-8" In ksm_functional_tests, test_child_ksm() returned negative values to indicate errors. However, when passed to exit(), these were interpreted as large unsigned values (e.g, -2 became 254), leading to incorrect handling in the parent process. As a result, some tests appeared to be skipped or silently failed. This patch changes test_child_ksm() to return positive error codes (1, 2, 3) and updates test_child_ksm_err() to interpret them correctly. This ensures the parent accurately detects and reports child process failures. Acked-by: David Hildenbrand -------------- Before patch: -------------- - [RUN] test_unmerge ok 1 Pages were unmerged ... - [RUN] test_prctl_fork - No pages got merged - [RUN] test_prctl_fork_exec ok 7 PR_SET_MEMORY_MERGE value is inherited ... Bail out! 1 out of 8 tests failed - Planned tests !=3D run tests (9 !=3D 8) - Totals: pass:7 fail:1 xfail:0 xpass:0 skip:0 error:0 -------------- After patch: -------------- - [RUN] test_unmerge ok 1 Pages were unmerged ... - [RUN] test_prctl_fork - No pages got merged not ok 7 Merge in child failed - [RUN] test_prctl_fork_exec ok 8 PR_SET_MEMORY_MERGE value is inherited ... Bail out! 2 out of 9 tests failed - Totals: pass:7 fail:2 xfail:0 xpass:0 skip:0 error:0 Fixes: 6c47de3be3a0 ("selftest/mm: ksm_functional_tests: extend test case f= or ksm fork/exec") Signed-off-by: Aboorva Devarajan --- tools/testing/selftests/mm/ksm_functional_tests.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/test= ing/selftests/mm/ksm_functional_tests.c index 996dc6645570..b080d591d984 100644 --- a/tools/testing/selftests/mm/ksm_functional_tests.c +++ b/tools/testing/selftests/mm/ksm_functional_tests.c @@ -512,14 +512,14 @@ static int test_child_ksm(void) =20 /* Test if KSM is enabled for the process. */ if (prctl(PR_GET_MEMORY_MERGE, 0, 0, 0, 0) !=3D 1) - return -1; + return 1; =20 /* Test if merge could really happen. */ map =3D __mmap_and_merge_range(0xcf, size, PROT_READ | PROT_WRITE, KSM_ME= RGE_NONE); if (map =3D=3D MAP_MERGE_FAIL) - return -2; + return 2; else if (map =3D=3D MAP_MERGE_SKIP) - return -3; + return 3; =20 ksm_unmerge(); munmap(map, size); @@ -528,11 +528,11 @@ static int test_child_ksm(void) =20 static void test_child_ksm_err(int status) { - if (status =3D=3D -1) + if (status =3D=3D 1) ksft_test_result_fail("unexpected PR_GET_MEMORY_MERGE result in child\n"= ); - else if (status =3D=3D -2) + else if (status =3D=3D 2) ksft_test_result_fail("Merge in child failed\n"); - else if (status =3D=3D -3) + else if (status =3D=3D 3) ksft_test_result_skip("Merge in child skipped\n"); } =20 --=20 2.43.5 From nobody Wed Oct 8 02:17:14 2025 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E2E0292B25; Thu, 3 Jul 2025 06:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522884; cv=none; b=jbEdDCrg5khpmxBdnhO6Dyx0WngxntkGT5PL2bvMvyxsDt27HycEBkGtUNj51iwGHDTJBAE/4Fp6AxKhevVvXvadwlgjRb+vBQOWYrrBzGa/YaAxAFKP0D1uDtj3KfU/MhA8fqMNrSFLMZUDo2yE78eryLzTwERMwJhtNhKCA3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522884; c=relaxed/simple; bh=z1qzz8+R3VoVACXFDdDoVSGUO1vQcDjCZIwcpRkIyY8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=miL1pLumsunxZ3guc46lDqCQO6H+OBOg8UicqbQqFFbB5JxpLJTQYmKTnV4tv9bRmXtoBHoTX787K7o1z0IIzP1IQlASwS6KNVFPvkTMi7NWJG1/ZuUS1N115vfnipukKJAMtsVyFInuK/VCLZ2hjKLncyW5TpOkxNwNLJHgxGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=dPr3KBWh; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="dPr3KBWh" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 562KmGFh017644; Thu, 3 Jul 2025 06:07:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=+thMMYZJsoVCkLewq kMGLHl3RouhJPJEcXLypUADols=; b=dPr3KBWh8J2wNWTIafTwBiBTxIXp4OUe7 83IkCQQCkFZH/ajWuuVWTRu2ZQuIxpx/lfE1g7yiB51a7zAzv4XljF/Ba+iEGHDf mUX0UFXxHtauOjyFxX6vUIyQAvyzckachpMpo3phT/W3gN88H/ice9mx6XIo5WQy 1V/dqC2zWOkp1t5/iNosb01GBozKwlzlDQ8ITukiLID+Kt+yU57vwKLo/VedBymm x9ysSLuc65QbQsAjdTeT02gh1oEQA++BIY2w4naaLPWG9B8jUudSNf8ZIN+jcvzR Dm/rNIcOWMYCFCRmWo1jISZuW83FYwYx8CXmlij1VJvOI1YENfhhg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j7wrsv2d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:46 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 56365Cp1032752; Thu, 3 Jul 2025 06:07:46 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j7wrsv2b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:45 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5632qaKF006830; Thu, 3 Jul 2025 06:07:44 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 47jvxmk4mc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:44 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 56367f0M54985064 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2025 06:07:41 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1D37D2004B; Thu, 3 Jul 2025 06:07:41 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8F0E620040; Thu, 3 Jul 2025 06:07:35 +0000 (GMT) Received: from aboo.ibm.com.com (unknown [9.39.26.205]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 3 Jul 2025 06:07:35 +0000 (GMT) From: Aboorva Devarajan To: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com, aboorvad@linux.ibm.com Subject: [PATCH v2 6/7] selftests/mm: Skip thuge-gen if shmmax is too small or no 1G huge pages Date: Thu, 3 Jul 2025 11:36:55 +0530 Message-ID: <20250703060656.54345-7-aboorvad@linux.ibm.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703060656.54345-1-aboorvad@linux.ibm.com> References: <20250703060656.54345-1-aboorvad@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=E/PNpbdl c=1 sm=1 tr=0 ts=68661e32 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=BKkNsC1I8dDgxTX2b6sA:9 X-Proofpoint-GUID: 6cRWN5sxyD1J_BU62QiHXTuM9wTEW7VZ X-Proofpoint-ORIG-GUID: -8nq2TMwybS7ZxSThzCAy9Da_wZA018D X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDA0NCBTYWx0ZWRfX9UBQpkPhDpPk EkwgaEFTCXSCOHzq2gpMjkhdTfBNdZC/a2un5+jY5REjVSAz/UvylEkNEpgnZMdT2vwikLQj/4i 3/fwX9s79V1W43eJ68PCjPkQiAHgR533BNJyE4HI80wQDPi1QRBVILJn+0ti3KnJIrcKWKmVbaH PMYcEezUdGJyh0qM9Gw9aV9w3Z0WtYU1fFfUrrM0uMmPHB8d0PXs5bYj7mtlwMPdvMdQwqQjdyA 47UFkaBf8dkRDPwOlhIlyzceSR8lS5Lmv3xwdR8A3W6QEjd4/VOLUp78gXtsKVqO9kbG4cegC5t qlJBTIc/ToQCIVnetXycEyBpbfvn9vDI2BXSMNyeJA7VyaHqNpugLgqI39tAeRIMZxq9QU9Fwbf hoczPnwtFW3qpyJxQXfUkPA/sJFtsxKOcZk3ecjO/zj05CqZDCgnehCXRQq63JkVp+9w6dSh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_01,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 mlxscore=0 clxscore=1015 adultscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030044 Content-Type: text/plain; charset="utf-8" Make thuge-gen skip instead of fail when it can't run due to system settings. If shmmax is too small or no 1G huge pages are available, the test now prints a warning and is marked as skipped. Acked-by: David Hildenbrand Reviewed-by: Dev Jain Reviewed-by: Zi Yan ------------------- Before Patch: ------------------- ~ running ./thuge-gen ~ Bail out! Please do echo 262144 > /proc/sys/kernel/shmmax ~ Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0 ~ [FAIL] not ok 28 thuge-gen ~ exit=3D1 ------------------- After Patch: ------------------- ~ running ./thuge-gen ~ ~ WARNING: shmmax is too small to run this test. ~ ~ Please run the following command to increase shmmax: ~ ~ echo 262144 > /proc/sys/kernel/shmmax ~ 1..0 ~ SKIP Test skipped due to insufficient shmmax value. ~ [SKIP] ok 29 thuge-gen ~ SKIP Signed-off-by: Aboorva Devarajan --- tools/testing/selftests/mm/thuge-gen.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftes= ts/mm/thuge-gen.c index 8e2b08dc5762..4f5e290ff1a6 100644 --- a/tools/testing/selftests/mm/thuge-gen.c +++ b/tools/testing/selftests/mm/thuge-gen.c @@ -177,13 +177,16 @@ void find_pagesizes(void) globfree(&g); =20 read_sysfs("/proc/sys/kernel/shmmax", &shmmax_val); - if (shmmax_val < NUM_PAGES * largest) - ksft_exit_fail_msg("Please do echo %lu > /proc/sys/kernel/shmmax", - largest * NUM_PAGES); + if (shmmax_val < NUM_PAGES * largest) { + ksft_print_msg("WARNING: shmmax is too small to run this test.\n"); + ksft_print_msg("Please run the following command to increase shmmax:\n"); + ksft_print_msg("echo %lu > /proc/sys/kernel/shmmax\n", largest * NUM_PAG= ES); + ksft_exit_skip("Test skipped due to insufficient shmmax value.\n"); + } =20 #if defined(__x86_64__) if (largest !=3D 1U<<30) { - ksft_exit_fail_msg("No GB pages available on x86-64\n" + ksft_exit_skip("No GB pages available on x86-64\n" "Please boot with hugepagesz=3D1G hugepages=3D%d\n", NUM_PAGES); } #endif --=20 2.43.5 From nobody Wed Oct 8 02:17:14 2025 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24E9229550F; Thu, 3 Jul 2025 06:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522887; cv=none; b=PE5Q3DOdC8UJTyrWM0jokVIIUTbCu2rFaZ1JhmQuGpY58CvX05JD9TNzddZWZ+6rkTAQsMhRKSxfia+qTCdeQEGxy1aQ73BDlwkHRDVUgw28ZT0lhEgpZFvoCrhZwaNlali/YMDZFUQPGXjVsj7hqlzrBS01IKchq2PtcwpcOgs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751522887; c=relaxed/simple; bh=H6ceUGAWatlNiIAcR00D1RWx4pfgZMWMJZZOEv7RQb8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hbFcg9pS4BHAji65ZmzSzaiFCLkbVridhVPX6W5pCNSuPkZHjOrzDIQhFAf1FVkZhl7QVlrtqGrRnkzMzqAVeRqKphq6lA3wIzGZTCGNGKgVjd90vAJQR+vIgp86R7LZN4R8BjJSoemD/B2bY+r8o2aqtUTJ009SZA6PrAQ/X80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=UlAYR+qE; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="UlAYR+qE" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 562J9O65007121; Thu, 3 Jul 2025 06:07:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=tiY/AII9izsAEKLm3 vI3qnsQ7jY6+9euqbVmCviXXq4=; b=UlAYR+qE1G1x5YI+fviQq8h4nmYqxwlm5 QxuORB29TJ+HjDldA88P2vkvqm5C7Z1cq7/6lPXpbL4HDBPwyrf7OdGsef9Hvo/O t+o7gJYwWWzzEl+noMpNIO3ecRi0hKltqqQKp1jhh0hNO7WoBXqCyPyOiI3YNTHa NnHdJWr7mgyUcKLStdNadapmEohj0oof9Ygj4s3NP8MJoSlUvduxed07gaohF/OB JLahmjYNDRnvOwfg8plIdjUePh16l7wzOr+KHFp0WtZM10H+vqKtBeoF35whgddw mtCHo2OdKm6zPM0VdTLJpiGQztZbIhC+sWsTckXq9Fuv2eOJSYbxQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j82g19kp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:52 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 56363WWs022299; Thu, 3 Jul 2025 06:07:51 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j82g19kj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:51 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5632p92R012027; Thu, 3 Jul 2025 06:07:51 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47jv7n3812-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 06:07:51 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 56367lij46530968 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2025 06:07:47 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E9CE52004B; Thu, 3 Jul 2025 06:07:46 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 998A620040; Thu, 3 Jul 2025 06:07:41 +0000 (GMT) Received: from aboo.ibm.com.com (unknown [9.39.26.205]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 3 Jul 2025 06:07:41 +0000 (GMT) From: Aboorva Devarajan To: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com, aboorvad@linux.ibm.com Subject: [PATCH v2 7/7] selftests/mm: Skip hugepage-mremap test if userfaultfd unavailable Date: Thu, 3 Jul 2025 11:36:56 +0530 Message-ID: <20250703060656.54345-8-aboorvad@linux.ibm.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703060656.54345-1-aboorvad@linux.ibm.com> References: <20250703060656.54345-1-aboorvad@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 5Ls_1_7HOXzI2zmpYqNqX88roOpK-jGu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDA0NCBTYWx0ZWRfX/zEbeLNpLbEg wjxGKn9BUIGWtjzKwUCg4EPH5oYZvBjP/865ePo0sQrTRwBb7bq1h9bfi631xlQN8WH2959YS8v QDoWr8DzSkT4eFTFGLdkOG+WikXrVlSuw6XdcI/RPsjz0S8e9Dta8Cv3/GePUjwbCQGu+Il2Hl/ AofQUjCAVfOvuXwKO5b2mFF1TMgnz5dPh9MupMqbrVooxSL662uMFLH1/Yl1kNcw3E+DFzxl0CC q+eSWvjNvSWqJjLWLWotnmnmq4Y/j4YFdKnMwPBCqiw0iTPy+45gdDDS2PZb2noJtTyTYAUZW9X dzzTqFmYf94koByC3gymCZt4593uN0eE0Us5Y0FlkdiYWs8zK0stx3AnRx8ZJ5V35C3vKr5lzsw UWN4V2grn5g3hzdqbhLyVr9RxRQcaOmnfaHUFpwn/TqHolOdRItRw5ipdVbTjjs0B2ZC6q1B X-Authority-Analysis: v=2.4 cv=LpeSymdc c=1 sm=1 tr=0 ts=68661e38 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=I-yzSHZ7cBtOcMPljFIA:9 X-Proofpoint-GUID: HUff6wG2QLV5FWq9UjfQSvPCV-lAD2g1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_01,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030044 Content-Type: text/plain; charset="utf-8" Gracefully skip test if userfaultfd is not supported (ENOSYS) or not permitted (EPERM), instead of failing. This avoids misleading failures with clear skip messages. Acked-by: David Hildenbrand Reviewed-by: Zi Yan -------------- Before Patch -------------- ~ running ./hugepage-mremap ... ~ Bail out! userfaultfd: Function not implemented ~ Planned tests !=3D run tests (1 !=3D 0) ~ Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0 ~ [FAIL] not ok 4 hugepage-mremap # exit=3D1 -------------- After Patch -------------- ~ running ./hugepage-mremap ... ~ ok 2 # SKIP userfaultfd is not supported/not enabled. ~ 1 skipped test(s) detected. ~ Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0 ~ [SKIP] ok 4 hugepage-mremap # SKIP Signed-off-by: Aboorva Devarajan --- tools/testing/selftests/mm/hugepage-mremap.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/hugepage-mremap.c b/tools/testing/s= elftests/mm/hugepage-mremap.c index c463d1c09c9b..1a0e6dd87578 100644 --- a/tools/testing/selftests/mm/hugepage-mremap.c +++ b/tools/testing/selftests/mm/hugepage-mremap.c @@ -65,10 +65,20 @@ static void register_region_with_uffd(char *addr, size_= t len) struct uffdio_api uffdio_api; =20 /* Create and enable userfaultfd object. */ - uffd =3D syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK); - if (uffd =3D=3D -1) - ksft_exit_fail_msg("userfaultfd: %s\n", strerror(errno)); + if (uffd =3D=3D -1) { + switch (errno) { + case EPERM: + ksft_exit_skip("No userfaultfd permissions, try running as root.\n"); + break; + case ENOSYS: + ksft_exit_skip("userfaultfd is not supported/not enabled.\n"); + break; + default: + ksft_exit_fail_msg("userfaultfd failed with %s\n", strerror(errno)); + break; + } + } =20 uffdio_api.api =3D UFFD_API; uffdio_api.features =3D 0; --=20 2.43.5