From nobody Wed Oct 8 00:41:26 2025 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 607A217A319 for ; Thu, 3 Jul 2025 16:33:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751560394; cv=none; b=YOS/1HR84ebAK7jWu+eOFkhAYhsW9JutxutMCxHZIJGfdsWnmJ8vCRsTz8USoROE17WI0eyvTl1KWuiAZ+JqPUS5OaBPpr3mv7DFq1XszWbehPBnXa62fXurFHcHed7J2MXi6KQYaXZF93e6G6chxN0QminVWgdLBJpHYlsm+Pg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751560394; c=relaxed/simple; bh=nNGsEZMceh7ByyehkXz7V37kQRvRuP/MeTJFxiGsrI0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=MccIBLy4lnO/5+X2AsyVv2ng0kX6Og6V9byGi+Hee/yYnRCpmvIyRvsiExEIaSNWYgZb/5NP/Pnwd5Rcr9zHD++xhk8zaprxHgSazmIh4J6tRpC3LUneI6viNNsWB7IfCg0nyLw4Ttb9w98r1VExTvX6rh/GL+j48iX7+daV2jM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Q4X2hBv6; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Q4X2hBv6" Received: by mail.gandi.net (Postfix) with ESMTPSA id 20FFA442AB; Thu, 3 Jul 2025 16:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1751560390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=++u5S5RPzXhKBex/t5CbkjWaVjlj1TY8uieui7XWnyw=; b=Q4X2hBv6PMHXJQLRkiv4/YMIxX3ZWnAzONbzrmZBtD8hUdKmFsJHmPykufmHKr5kfEpKJu mSuSjpNdMHvtrlubKULrVRuW2N2ohsSP1kBhH05sdxWm4O1Ibc460+cyrhLPGWC+tL++2t tIYFaXtogWyr0CCm1rn9xkQS1JDQQNqyEmaQ3J39LftJeXtVrHdw70q/b8k/aggiNq92FN Pj+AJTKF9yICzXSSdKGGDKdbIMbo2snJt+kXeLiNr3iQMuK49HAU27cQUFBJO638aTP71Z AEY+dTTJp3MMSLGqEYfWrnZRPwoKipRMOEt7ZNREKY265mV3hAtVW3kCWpQsVA== From: Luca Ceresoli Date: Thu, 03 Jul 2025 18:32:32 +0200 Subject: [PATCH] drm/bridge: tc358767: fix uninitialized variable regression Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250703-drm-bridge-alloc-fix-tc358767-regression-v1-1-8f224cd063c4@bootlin.com> X-B4-Tracking: v=1; b=H4sIAJ+wZmgC/x2NSwrDMAwFrxK0rsCxsR1yldCFayupID/kUgohd 4/S5TCPeQdUEqYKfXOA0Jcrb6tC+2ggv9M6EXJRBmusN9E4LLLgS7ioSfO8ZRz5h5/sfBdDRKF JqN4R9C5Qsl1o0xhAc7uQTv9Xw/M8L5T0c9J6AAAA X-Change-ID: 20250703-drm-bridge-alloc-fix-tc358767-regression-536ea2861af6 To: "Colin King (gmail)" , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov Cc: Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Luca Ceresoli X-Mailer: b4 0.14.2 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddvtdejjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephfffufggtgfgkffvvefosehtjeertdertdejnecuhfhrohhmpefnuhgtrgcuvegvrhgvshholhhiuceolhhutggrrdgtvghrvghsohhlihessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepvdeuleetffeutdfhvedvjeffuddtteejtdfhffdvhedvleevteekjeejgfejgfehnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphephedurddujeelrddutdefrdehheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeehuddrudejledruddtfedrheehpdhhvghloheplgduledvrdduieekrddurdduleeingdpmhgrihhlfhhrohhmpehluhgtrgdrtggvrhgvshholhhisegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedukedprhgtphhtthhopehjvghrnhgvjhdrshhkrhgrsggvtgesghhmrghilhdrtghomhdprhgtphhtthhopehjohhnrghssehkfihisghoohdrshgvpdhrtghpthhtohepmhgrrghrthgvnhdrlhgrnhhkhhhorhhstheslhhinhhugidrihhnthgvlhdrtghomhdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvl hdrohhrghdprhgtphhtthhopefnrghurhgvnhhtrdhpihhntghhrghrthesihguvggrshhonhgsohgrrhgurdgtohhmpdhrtghpthhtoheprghirhhlihgvugesghhmrghilhdrtghomhdprhgtphhtthhopehsihhmohhnrgesfhhffihllhdrtghhpdhrtghpthhtohepughrihdquggvvhgvlheslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrgh X-GND-Sasl: luca.ceresoli@bootlin.com Commit a59a27176914 ("drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API") split tc_probe_bridge_endpoint() in two functions, thus duplicating the loop over the endpoints in each of those functions. However it missed duplicating the of_graph_parse_endpoint() call which initializes the struct of_endpoint, resulting in an uninitialized read. Fixes: a59a27176914 ("drm/bridge: tc358767: convert to devm_drm_bridge_allo= c() API") Reported-by: Colin King (gmail) Closes: https://lore.kernel.org/all/056b34c3-c1ea-4b8c-9672-c98903ffd012@gm= ail.com056b34c3-c1ea-4b8c-9672-c98903ffd012@gmail.com Signed-off-by: Luca Ceresoli Reviewed-by: Colin Ian King --- drivers/gpu/drm/bridge/tc358767.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc3= 58767.c index 61559467e2d22b4b1b4223c97766ca3bf58908fd..562fea47b3ecf360e64a414e95a= b5d645e610e9e 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -2422,6 +2422,7 @@ static int tc_probe_bridge_endpoint(struct tc_data *t= c, enum tc_mode mode) struct device_node *node =3D NULL; =20 for_each_endpoint_of_node(dev->of_node, node) { + of_graph_parse_endpoint(node, &endpoint); if (endpoint.port =3D=3D 2) { of_property_read_u8_array(node, "toshiba,pre-emphasis", tc->pre_emphasis, --- base-commit: b4cd18f485687a2061ee7a0ce6833851fc4438da change-id: 20250703-drm-bridge-alloc-fix-tc358767-regression-536ea2861af6 Best regards, --=20 Luca Ceresoli