From nobody Wed Oct 8 03:52:58 2025 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A84647E0E4; Wed, 2 Jul 2025 22:36:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.79.88.28 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751495767; cv=none; b=ns87/ly8XaRBpOmTjJ4GNmMPOGtk4IXHTbjOvC2QV27FIccNuLUBYQsjzNEl1aNKZwE2lsJZbSbMY5sDGpmY2suo8LgB9Ii/1apjCEnYRy0L9dqVF//PLFnwW6pBdwe14CgNAfZ4PYfhVFc7QKJNUp/zKUqojdm6UhAYgKYUaK0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751495767; c=relaxed/simple; bh=FwhImwbafGh/zSIx/tFbbpugx28qhWcgTkn8+5R/NgI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=itOXmXqSPeyyYnnQyKgCr80yxeGQ+ZAvjWqUXgo4A2e62fhAk1TK/joJYz+osPfMRDa/zHn8BnDbWdFZkgJvPmfEvqXM8B3awkVXZglTxRIyEnszt3WkShlkm6kx89dpUCIsdR6rfHmZ/AJv+la8reN3tlenCFIgUXH0n/+YMO8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lwn.net; spf=pass smtp.mailfrom=lwn.net; dkim=pass (2048-bit key) header.d=lwn.net header.i=@lwn.net header.b=JgeSRHRT; arc=none smtp.client-ip=45.79.88.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lwn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lwn.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lwn.net header.i=@lwn.net header.b="JgeSRHRT" DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net EF6F040AD8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1751495762; bh=DTvXcrbBitRgXHw7xikNWkgt0Dd2ojvGet8pYn6xCbI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JgeSRHRTh7KmdIczkY+8jBtbz2xFOEH7ldbEQ0Y3jVA3k5r28AnX5OL9rGH4Hu4MP QKeQPhjetk2ylXHZGc63iCApJp57z5MAD0b3CR34jrdl3C94PAKJIIL721opT9Wj5/ 8V73PGGD8RnNllEAlWJI3tzk97+9i8YG8ZxiAvRkd6f89nl2wCzBNV95VkIuJGY0LO 3uZxQyZ4t8oFayLvtdxG4B5a5I08MPjmQamrfXSXzRZtBs9/rlH676/Abjovz8d6Hv 4Y2aYeCleYvhZj9Cc4aAf/w3Z35Ol9Zqh2TxMbSqRSVInkNFS5yTrPbJmdY6VqPIO0 szkrUKslj9nmA== Received: from trenco.lwn.net (unknown [IPv6:2601:280:4600:2da9::1fe]) by ms.lwn.net (Postfix) with ESMTPA id EF6F040AD8; Wed, 2 Jul 2025 22:36:01 +0000 (UTC) From: Jonathan Corbet To: linux-doc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Akira Yokosawa , Jonathan Corbet Subject: [PATCH 06/12] docs: kdoc: use self.entry.parameterlist directly in check_sections() Date: Wed, 2 Jul 2025 16:35:18 -0600 Message-ID: <20250702223524.231794-7-corbet@lwn.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250702223524.231794-1-corbet@lwn.net> References: <20250702223524.231794-1-corbet@lwn.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Callers of check_sections() join parameterlist into a single string, which is then immediately split back into the original list. Rather than do all that, just use parameterlist directly in check_sections(). Signed-off-by: Jonathan Corbet Reviewed-by: Mauro Carvalho Chehab --- scripts/lib/kdoc/kdoc_parser.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/scripts/lib/kdoc/kdoc_parser.py b/scripts/lib/kdoc/kdoc_parser= .py index b28f056365cb..ffd49f9395ae 100644 --- a/scripts/lib/kdoc/kdoc_parser.py +++ b/scripts/lib/kdoc/kdoc_parser.py @@ -476,19 +476,18 @@ class KernelDoc: self.push_parameter(ln, decl_type, param, dtype, arg, declaration_name) =20 - def check_sections(self, ln, decl_name, decl_type, sectcheck, prmschec= k): + def check_sections(self, ln, decl_name, decl_type, sectcheck): """ Check for errors inside sections, emitting warnings if not found parameters are described. """ =20 sects =3D sectcheck.split() - prms =3D prmscheck.split() =20 for sx in range(len(sects)): # pylint: disable=3D= C0200 err =3D True - for px in range(len(prms)): # pylint: disable=3D= C0200 - if prms[px] =3D=3D sects[sx]: + for param in self.entry.parameterlist: + if param =3D=3D sects[sx]: err =3D False break =20 @@ -753,8 +752,7 @@ class KernelDoc: =20 self.create_parameter_list(ln, decl_type, members, ';', declaration_name) - self.check_sections(ln, declaration_name, decl_type, - self.entry.sectcheck, ' '.join(self.entry.para= meterlist)) + self.check_sections(ln, declaration_name, decl_type, self.entry.se= ctcheck) =20 # Adjust declaration for better display declaration =3D KernRe(r'([\{;])').sub(r'\1\n', declaration) @@ -1032,9 +1030,7 @@ class KernelDoc: f"expecting prototype for {self.entry.identifier= }(). Prototype was for {declaration_name}() instead") return =20 - prms =3D " ".join(self.entry.parameterlist) - self.check_sections(ln, declaration_name, "function", - self.entry.sectcheck, prms) + self.check_sections(ln, declaration_name, "function", self.entry.s= ectcheck) =20 self.check_return_section(ln, declaration_name, return_type) =20 --=20 2.49.0