From nobody Wed Oct 8 05:52:39 2025 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 920D2275AE7; Wed, 2 Jul 2025 13:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751461454; cv=none; b=SuMq7FISC70W6hOzbxnDM7PkpxMr95o+aRMKpROUHayWQ7vAX+SH3vSypi+42UdR/Capqp/bAM9/u8fwAvUZWNp5L2pWlgv4Yt0azJebUyP+Ok4vpIL3SSmh6O/jow2Tedv/w32EM406tQNga8eDgPN4XZA3ZgRjdbUpOI2ZWkM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751461454; c=relaxed/simple; bh=eq/Uu2HMEIvyDIof+COL2BAZ9tNFTuY++Wr2dzc7AIk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=d6qCk3yfa1KGoCnkx17iI9wA6MnLGj7NhWnBiUHGHhiHDqCTKK3qTLF8Y84o0/7m+LfW9h5NtDLfS1tVw4/rXfeUKeaI0P+vd9iKnZr+8u6vSbu0wuGXyBTDYfwVrH1Z9EHxdgPs/xwZ6ZvxafbxeZs+j+X4errbyoxnU+JIGnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4bXKqx4Kj8z16TJ1; Wed, 2 Jul 2025 21:05:01 +0800 (CST) Received: from kwepemk100013.china.huawei.com (unknown [7.202.194.61]) by mail.maildlp.com (Postfix) with ESMTPS id 23F6B1A016C; Wed, 2 Jul 2025 21:04:05 +0800 (CST) Received: from localhost.localdomain (10.90.31.46) by kwepemk100013.china.huawei.com (7.202.194.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 2 Jul 2025 21:04:04 +0800 From: Jijie Shao To: , , , , , CC: , , , , , , , , Subject: [PATCH V5 net-next 1/3] net: hibmcge: support scenario without PHY Date: Wed, 2 Jul 2025 20:57:14 +0800 Message-ID: <20250702125716.2875169-2-shaojijie@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20250702125716.2875169-1-shaojijie@huawei.com> References: <20250702125716.2875169-1-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To kwepemk100013.china.huawei.com (7.202.194.61) Content-Type: text/plain; charset="utf-8" Currently, the driver uses phylib to operate PHY by default. On some boards, the PHY device is separated from the MAC device. As a result, the hibmcge driver cannot operate the PHY device. In this patch, the driver determines whether a PHY is available based on register configuration. If no PHY is available, the driver will use fixed_phy to register fake phydev. Signed-off-by: Jijie Shao Reviewed-by: Larysa Zaremba --- ChangeLog: v4 -> v5: - Use PTR_ERR() instead of IS_ERR(), suggested by Andrew Lunn. v4: https://lore.kernel.org/all/20250701125446.720176-1-shaojijie@huawei.= com/ v3 -> v4: - Fix git log syntax issues, suggested by Larysa Zaremba v3: https://lore.kernel.org/all/20250626020613.637949-1-shaojijie@huawei.= com/ v2 -> v3: - Use fixed_phy to re-implement the no-phy scenario, suggested by Andrew = Lunn v2: https://lore.kernel.org/all/20250623034129.838246-1-shaojijie@huawei.= com/ --- .../net/ethernet/hisilicon/hibmcge/hbg_mdio.c | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_mdio.c b/drivers/ne= t/ethernet/hisilicon/hibmcge/hbg_mdio.c index 42b0083c9193..8b7b476ed7fb 100644 --- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_mdio.c +++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_mdio.c @@ -2,6 +2,7 @@ // Copyright (c) 2024 Hisilicon Limited. =20 #include +#include #include #include "hbg_common.h" #include "hbg_hw.h" @@ -19,6 +20,7 @@ #define HBG_MDIO_OP_INTERVAL_US (5 * 1000) =20 #define HBG_NP_LINK_FAIL_RETRY_TIMES 5 +#define HBG_NO_PHY 0xFF =20 static void hbg_mdio_set_command(struct hbg_mac *mac, u32 cmd) { @@ -229,6 +231,39 @@ void hbg_phy_stop(struct hbg_priv *priv) phy_stop(priv->mac.phydev); } =20 +static void hbg_fixed_phy_uninit(void *data) +{ + fixed_phy_unregister((struct phy_device *)data); +} + +static int hbg_fixed_phy_init(struct hbg_priv *priv) +{ + struct fixed_phy_status hbg_fixed_phy_status =3D { + .link =3D 1, + .speed =3D SPEED_1000, + .duplex =3D DUPLEX_FULL, + .pause =3D 1, + .asym_pause =3D 1, + }; + struct device *dev =3D &priv->pdev->dev; + struct phy_device *phydev; + int ret; + + phydev =3D fixed_phy_register(&hbg_fixed_phy_status, NULL); + if (IS_ERR(phydev)) { + dev_err_probe(dev, PTR_ERR(phydev), + "failed to register fixed PHY device\n"); + return PTR_ERR(phydev); + } + + ret =3D devm_add_action_or_reset(dev, hbg_fixed_phy_uninit, phydev); + if (ret) + return ret; + + priv->mac.phydev =3D phydev; + return hbg_phy_connect(priv); +} + int hbg_mdio_init(struct hbg_priv *priv) { struct device *dev =3D &priv->pdev->dev; @@ -238,6 +273,9 @@ int hbg_mdio_init(struct hbg_priv *priv) int ret; =20 mac->phy_addr =3D priv->dev_specs.phy_addr; + if (mac->phy_addr =3D=3D HBG_NO_PHY) + return hbg_fixed_phy_init(priv); + mdio_bus =3D devm_mdiobus_alloc(dev); if (!mdio_bus) return dev_err_probe(dev, -ENOMEM, --=20 2.33.0