From nobody Wed Oct 8 04:04:49 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 126252749E6 for ; Wed, 2 Jul 2025 12:15:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751458531; cv=none; b=C70FJy59LPptCDSG3G8zmD2wCn0Jcecf6T4Yv1gpCB96f6vwnlmXr/MoRd4O4hlj1foWWBtX+nq4WvCRTddUbtXSMKEGtSw0l//ex5qsMDC/bLq9JD3Wf4YszTJoNKq+L+6Sh+yOk45SZuVWG0ej1+LdsrwOOlGR8RMAm0lMIOA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751458531; c=relaxed/simple; bh=Sonnye7hZy2wt/2sdkee8anX7maKzoAKHEmbBG3T8tA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=FF4LGCCRYvgPolXur6GoTmlWobky7/w0X/lPptCj6ECEri3AFaAc9jYdQ1/xlZaCH5WsGMiKEuRiNcUTK0kAeviBU4yHg1CK3aH2cXX4ltdpNg2ZxcZfbRrv3h8NrX9OpYZwH1ptHTs6fG7PlM71DDIHe9yLY7QpxC1sfVm3b6s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CBJA5grf; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CBJA5grf" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4537fdec39fso14390645e9.0 for ; Wed, 02 Jul 2025 05:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751458528; x=1752063328; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=x9pvwsjMWPA9nQD+iBKKTHpsU97t1wWZ+fWjmxW/6k4=; b=CBJA5grfPo7uThx18W4+K4wM2sAUrX5doEu77eyR6b7Akxr7rMCwfSHynjWM+tNklw +7c0DZrdi8mpCNtKjWS+XIXcQX6bk6yv7z7ncjzYBcfVF92VNhMpFyofp7bP7F0oW1AS YEwgEwQqPqc6PKBs519K3R1y9hY5RleQQoBrw+p7MAfymks2KAz9XES6kqYt41/6cZyS xZte1f23kIYlx/WLK/Kis2xZjwfY/fPd6lrMwRwuMPUG7BFrD8sO9LiVqRVSSDq+DJ3y hH4vEW/vzwy1nU/omZRP60ByaQF1DpQzziJ/nQkkdGxyRdwkOdWa+BINcVmD41HjtP4f 5VDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751458528; x=1752063328; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x9pvwsjMWPA9nQD+iBKKTHpsU97t1wWZ+fWjmxW/6k4=; b=qlD8W+R/vvbt9PEMxl3Pa3x6Un70n4fBjlBUNezLHB4SesyDorS2oMJJnVHS08M+tz OPZcUbcHjINo3Mpxrx+BW+Q1G3291ndm5qlDrwObL4zwsBKZKeWx69VO5MFSzBBwSeFP Zu0G4aSAK/oYinUFCFREgjcQt2mUULWo1thEifZKivEJkqnVk0fvfSlZPdfdZfMt/vQP +IPPtdoxGNvCKw2c7KfZGIFq1ptxEfN8EqRup7T89aMi1w0NHZvciz+an4qDm/96XlMH IsHMbXjD27Qe+UmoovGc5I4U9xSd7HIDn19Wl8+Qtitw/TwAHQUNB3t3YhfD+1x03uIh clYw== X-Forwarded-Encrypted: i=1; AJvYcCUIguLaNBGSChKvclF7ZDPzptSz7p6wS3mVkaCZY34Dhgzbbu28c4BJoCXol7ZmUAgZlSu5eYx6f6m7Zbc=@vger.kernel.org X-Gm-Message-State: AOJu0YxGey08JzWBhR/ntRkljCZE+0/st2JjjzamAeCE43gvzb1XEySg UR8USSBsWKrn3sNKXy7ulH3c3kSD4/bj6/VFZIwLD98G+O3TgMLHV53nh5DdO63luXTMUxc4n9+ Rey3/ X-Gm-Gg: ASbGnctQY+jxCAtKAT6hI5gSp8FYQDTnemjDeWUunR7eoWL+ldHNr1gZsGd5d8cnr51 Tld3cOdJBAqYS3jQJ+zkdi3BBscMDADay3sjc+qWA+v9/toMxGVOyrw4K81HdOWh+ppQ7Vr6Mvr ORd096ALv3qOIVsvMQ7/HvMrDP0Wp0hHKo5CiZVFjH+fRm/nUEcTlrwAKjR9K8RSPtx0wrBT1km E8NV0wfFVMdz390hEt8x3iiEAZoEWxuyFbQnbDeKBCSyczrktvOo+qFbxU33jGXHEhiu/W4IfGE A3qyj7avDTID+wzp2pvKSA/2bMBKYfMm3kJT2dBgPempCXFHCk8Tsgve/OyyEYdk4EQqXAnSFdY eGqrWi5QKZiiym7rH X-Google-Smtp-Source: AGHT+IELgg5UZzqaTlSfiyc6Ytkoj6C/RHdaT40F4scmmqS3AYJLBC3dMjYCI068eBu4lplMXDVdzA== X-Received: by 2002:a05:600c:4f13:b0:43c:f6c6:578c with SMTP id 5b1f17b1804b1-454a36ec540mr34363525e9.15.1751458528249; Wed, 02 Jul 2025 05:15:28 -0700 (PDT) Received: from gpeter-l.roam.corp.google.com ([145.224.66.164]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823ad01csm228256345e9.22.2025.07.02.05.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 05:15:27 -0700 (PDT) From: Peter Griffin Date: Wed, 02 Jul 2025 13:15:24 +0100 Subject: [PATCH] pinctrl: samsung: Fix gs101 irq chip Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250702-fix-gs101-irqchip-v1-1-ccc84b44ad72@linaro.org> X-B4-Tracking: v=1; b=H4sIANsiZWgC/x2MywqAIBAAfyX23MJq734lOoRuuhcrhQjCf086D szMC4mjcIK5eiHyLUmOUEDVFRi/BccotjBo0h0NpHGXB11SpFDiZbycOFqlbdNPbUsGSndGLtL /XNacPzMOKGhjAAAA X-Change-ID: 20250702-fix-gs101-irqchip-8d12d369440c To: Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Linus Walleij Cc: Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Peter Griffin X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1589; i=peter.griffin@linaro.org; h=from:subject:message-id; bh=Sonnye7hZy2wt/2sdkee8anX7maKzoAKHEmbBG3T8tA=; b=owEBbQKS/ZANAwAKAc7ouNYCNHK6AcsmYgBoZSLecwK0sxfmoygPy9wJSjKSBq78rF5mEbSPI jagEn353PyJAjMEAAEKAB0WIQQO/I5vVXh1DVa1SfzO6LjWAjRyugUCaGUi3gAKCRDO6LjWAjRy ujWQD/9dX1YTX9ZBnRCltukRwwg2+Ex5ETtEJVtNrSYJtAj6JDjMCK32q+2ExEr8o4nxkdDbNZq tcQqwCP3OtUaNf5+cZALlUvIrAB9j7MfFyhCK+4V3um44lc60sulhIZZ9X427vxU6Oy2DovBzpn 1/22Zjj3t2R9QmskA4AlInV2Rhr3PkPEeQGNS8xa5YGt0kV+oPVPJG94ckz6k0zUh2cvaFeuLfZ aPe9UVsynX81YvNMCyFXHB3aH81kI0VBciFnhcky7rL24T7ir+8tADpsIa5rrw9jFYrIWyRv5jy AgdOP44wde/WX6EnfhCJHFnQZG8LnefXO9dl0CykpuwsOXzssPy4QjFDm5ZWNHGB/K4t//kezHa 9Z/xVRjGJrPI3aS5fvcIgx7kDjGkMSLFln7PadJmY2QzYMB8YJqe7IzXbu3jJ/lMBslF8K1RUNB 6EQNW4j3/5j0SmdweFTVhgH6TmxLbKEYqblLtss4jgFvUI1d4eqTlYKzJyQoVsWOliXDsL1/Pa4 NZSYa+eSrD0GMcItjGp9a6g4VPJcOG+9JgTcU+9kc5VzedjCQP7RrYcXkS2ysi4emDOh5K1sXrV bIYsUU73Un5KFJlI4nJsce3Zg58KY/Lm/r4SWokTVsUB/BaD4BGPkOl4lVPNR2nHk4NFvTe1Lwc rrGx4t9wNbgLsJQ== X-Developer-Key: i=peter.griffin@linaro.org; a=openpgp; fpr=0EFC8E6F5578750D56B549FCCEE8B8D6023472BA When adding the dedicated gs101_wkup_irq_chip struct to support the eint wakeup mask the .eint_con, eint_mask and .eint_pend fields were missed. The result is that irqs on gs101 for the buttons etc are broken. Reported-by: Andr=C3=A9 Draszik Fixes: 2642f55d44ce ("pinctrl: samsung: add support for gs101 wakeup mask p= rogramming") Signed-off-by: Peter Griffin Tested-by: Andr=C3=A9 Draszik --- Note: no Closes tag as issue was reported on private chat. Permission has been obtained for using the Reported-by tag. --- drivers/pinctrl/samsung/pinctrl-exynos.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/sam= sung/pinctrl-exynos.c index 5554768d465fe0d8bf6e423b2e835965cde5d8f5..81fe0b08a9af5682421e5a5533a= 6cb4c9561cd24 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -665,6 +665,9 @@ static const struct exynos_irq_chip gs101_wkup_irq_chip= __initconst =3D { .irq_request_resources =3D exynos_irq_request_resources, .irq_release_resources =3D exynos_irq_release_resources, }, + .eint_con =3D EXYNOS7_WKUP_ECON_OFFSET, + .eint_mask =3D EXYNOS7_WKUP_EMASK_OFFSET, + .eint_pend =3D EXYNOS7_WKUP_EPEND_OFFSET, .eint_num_wakeup_reg =3D 3, .eint_wake_mask_reg =3D GS101_EINT_WAKEUP_MASK, .set_eint_wakeup_mask =3D gs101_pinctrl_set_eint_wakeup_mask, --- base-commit: 2aeda9592360c200085898a258c4754bfe879921 change-id: 20250702-fix-gs101-irqchip-8d12d369440c Best regards, --=20 Peter Griffin