From nobody Wed Oct 8 05:33:53 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B376F12CD88; Wed, 2 Jul 2025 10:56:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751453794; cv=none; b=faXsjRpSNJZsb7Ij1n5gneNnK6Zarpr5N9gaGdgbFk7uGSQCtzMmuHibz9EPyTnDRxK7xH738SZVlvOAcVca9mT69V59aVz988kDmlYLdt7Jdcveh4M6kI7RJ1AO6lvxpxz3WEUt8dZxU0P/TyKtKj/0A711tBfKXSmHsuDhIYQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751453794; c=relaxed/simple; bh=58+3HJOajqHhaBuOa7ipEd3ah9IrK8/b0nQffaXKgLE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FWX0Ap1DDPXOFXC6yLcxp/35vdhBDpE7FWXIP9CRokbKLD+l56918Uhp0HWRP4x6zTnUH5/55E19GvJ3tJLHUyZ2zbONmXWYMeEYOzaJ8RYTg6aQ1eeJDhVYBMgSMp7EOTHnQXWnOdBXTVNaDu0A/2bkDUhILs7dMKlk7sEG42k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QIIxnapr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QIIxnapr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80573C4CEF0; Wed, 2 Jul 2025 10:56:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751453794; bh=58+3HJOajqHhaBuOa7ipEd3ah9IrK8/b0nQffaXKgLE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=QIIxnaprZessF76VN1winLxExyelsoC52sE0Zpy0ta3GyQ67NsaEoGLFX5rdCYUeg +H/rBf3xJlcWz6ZyP8xAcMTRA8kE/fnwXFyBB+opXEi7MNJ4gjyoeDNToz9vNiPahu J6/ogE1/QHuEv0sTlpg5C321+1QytmuX1p8mWtsu9VyrgaQBNk+yeStkyBgrhtmb5D OiW8VVQJ6UQovFJNhpI+Nu0GMpmwxVAExiTc6yRkWgJ3E03MTuxwME5ZpJJoAN8C5h SM+tPg9msN/uxf4JiN3s+ea0VmEgMgtdNhzuZWwqMge6ytAROy51CnYdwtmXdMV5Zb DiWhskbEPaymw== From: Mark Brown Date: Wed, 02 Jul 2025 11:39:12 +0100 Subject: [PATCH v18 7/8] selftests/clone3: Allow tests to flag if -E2BIG is a valid error code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250702-clone3-shadow-stack-v18-7-7965d2b694db@kernel.org> References: <20250702-clone3-shadow-stack-v18-0-7965d2b694db@kernel.org> In-Reply-To: <20250702-clone3-shadow-stack-v18-0-7965d2b694db@kernel.org> To: "Rick P. Edgecombe" , Deepak Gupta , Szabolcs Nagy , "H.J. Lu" , Florian Weimer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Brauner , Shuah Khan Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , jannh@google.com, bsegall@google.com, Andrew Morton , Yury Khrustalev , Wilco Dijkstra , linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org, Mark Brown , Kees Cook , Kees Cook , Shuah Khan X-Mailer: b4 0.15-dev-cff91 X-Developer-Signature: v=1; a=openpgp-sha256; l=2075; i=broonie@kernel.org; h=from:subject:message-id; bh=58+3HJOajqHhaBuOa7ipEd3ah9IrK8/b0nQffaXKgLE=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBoZRAv59uwxCVPNi3cfZwRXj8C7vTHR8APqu00O 3QLql1kfLeJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCaGUQLwAKCRAk1otyXVSH 0MJ0B/4s64CUeoyB1k7dOdLecXfrgNzZ8P5bEQe7ndL/4V+zRAJAC3aCvRudAjEXMu6REjBsX3r KkXoB4F3MFriJ9R+chrb9qZFIHgzrDX1PVSDnVKKgu5FA7IsKFStLGpEvqlf3XlXIbd1Q1gfSDC drPJtsSmU9sjDxH/ik+xA/74ExaCC2kFQTqLVjmqnaT8Vk15NA1Ycwgew13CJyT2VXLyK825a7P qYV4PodeHUNh0+0oyuFT0UIb/D7AOLr5xSWUCmsudGSKm3NkXpNzhLRi6F8BAqECXR32tcYcxmq S5XWsMWnMg3aFBU64dzI2cWF/eH6FflwdObgJZXeqwtzR5Ss X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB The clone_args structure is extensible, with the syscall passing in the length of the structure. Inside the kernel we use copy_struct_from_user() to read the struct but this has the unfortunate side effect of silently accepting some overrun in the structure size providing the extra data is all zeros. This means that we can't discover the clone3() features that the running kernel supports by simply probing with various struct sizes. We need to check this for the benefit of test systems which run newer kselftests on old kernels. Add a flag which can be set on a test to indicate that clone3() may return -E2BIG due to the use of newer struct versions. Currently no tests need this but it will become an issue for testing clone3() support for shadow stacks, the support for shadow stacks is already present on x86. Reviewed-by: Kees Cook Tested-by: Kees Cook Acked-by: Shuah Khan Reviewed-by: Catalin Marinas Signed-off-by: Mark Brown --- tools/testing/selftests/clone3/clone3.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selfte= sts/clone3/clone3.c index e066b201fa64..5b8b7d640e70 100644 --- a/tools/testing/selftests/clone3/clone3.c +++ b/tools/testing/selftests/clone3/clone3.c @@ -39,6 +39,7 @@ struct test { size_t size; size_function size_function; int expected; + bool e2big_valid; enum test_mode test_mode; filter_function filter; }; @@ -146,6 +147,11 @@ static void test_clone3(const struct test *test) ksft_print_msg("[%d] clone3() with flags says: %d expected %d\n", getpid(), ret, test->expected); if (ret !=3D test->expected) { + if (test->e2big_valid && ret =3D=3D -E2BIG) { + ksft_print_msg("Test reported -E2BIG\n"); + ksft_test_result_skip("%s\n", test->name); + return; + } ksft_print_msg( "[%d] Result (%d) is different than expected (%d)\n", getpid(), ret, test->expected); --=20 2.39.5