From nobody Wed Oct 8 07:24:30 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F48D26E154 for ; Tue, 1 Jul 2025 09:11:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751361117; cv=none; b=Oa+iUDr8gNi4EaQHwqsVa2I367F8zddFLPD5nWfB+E/+VzCl290UNtVzL4GqDWM+aSAXUcw2DW+y8KyfvNhPWIB92QpulAHdcSQ5X3T6qba1tM6BZm4euiHJ0SoP2kU0DB7l01cCf0c1bWyAlyvcN4QI1i+41Lp9ztPGbTTlwjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751361117; c=relaxed/simple; bh=W6cP78wIGMhoYyHYkrHnhShjuVMTLSpYdc7+nQOTa4w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GbSw8p0p2uiRCeslL401TrMhPfEin1XOFACvbJtJ6rjjhejHrNfhmErOYHWLp2GA97r6CIw0jl3DCiazAoiFI7j/IcpI4AidXcVAp3H38uEv8EQqxsP73dp15uMMe9yvKE7X+lCCQIKjxVs1UD6xImVDUJkgTiAtG/L8WmRHu/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ASTr3KMN; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ASTr3KMN" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2350fc2591dso50300075ad.1 for ; Tue, 01 Jul 2025 02:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1751361115; x=1751965915; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g1gBQftS2Fk6V7LZfv5a/Ar3bdUI/g78/+w8i6zo9Uo=; b=ASTr3KMN6ksHo/oij9hn+PUtLiTR9C7nK7ewEWCIbhTs0p15jV3Askeimt7cdhW0SI HeZRu/bscNcy/1Jj31l4Ya9IQNy94Ub+HxV0y+oV/Fj0ZGE9uqTTIjzfoQidZmktRCxU Mq5aXBtxWKdMRHwyoSHUW2lHOboZokPEjwoD0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751361115; x=1751965915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g1gBQftS2Fk6V7LZfv5a/Ar3bdUI/g78/+w8i6zo9Uo=; b=U9BEuMFVYzm0/gUjIkhpcgK1NcoBfrLJ4rLGa7XpTmzA5Ub6SKm3cRkPWWvVBNplqU 9b4vtHxhpS194Aw059kiJZhMmc6eEnqmK59e/xokgHFJCuNNEqWG8bZbVUrOc3LntQ7L LyuWmSfurncjTjH1FLCNxxL+ydbu2LWLYJ93S9sBGmZ8BV0e+YGnNiClZ/7PIdUTKwgP n02W0GBLYMbYMMVTil/1q0CP6vhsYRMntIFNxQbf1RKBgqKzxpuMEzk2dYqF0FZItBzO 10m6xYQmyKzovosCRvSE1BC9Rdv2+Io3uKRW9YH70dDlnKWDdlIjCUMJekpcqTqPjoUv /UPg== X-Forwarded-Encrypted: i=1; AJvYcCXN0NmjYS/bI3da4N6hxP2SYRo58eJ16uArmzQ/bNQMhJ6r4KljJXMKQ9jPVptGV9xbEX9rimra484A0lU=@vger.kernel.org X-Gm-Message-State: AOJu0YwDRzkkqD0Z0wDQ+/7xjHfCMkkK5qoagr2V1WrMUAEw0eeNJYzO TL6ojf36U20ClT+U9TRKPx/CplspRKZUqT2HwDVkkMeqQj+nSCP47xKuE9y2NQDwsw== X-Gm-Gg: ASbGncvxu4D9U6QNXAlh3hhTiQAbLOtxUBf7APUaafpt532NMkm79crLRPI3yYl6pHU jYBSWM4z2n8fIr3v3ulzXCKuxCGsJ+8BIjoooINpvZgs6O4YueDJhDVpxrvWAfYfFJIxp+rTqDV R1iAYPwzA+su9N1w5wJaKbao//rMxJvfyatQrzym8MlTC3KdBY+YrYDqQdDmSR/vzPF/I79h3mW Mr/gKLSPg7q1P83ONKW6uPxISfVrS3gGIiFiIPObAaE56fCPy3rPsgqcm9bmUkxUtXiEtxvGzY1 39beZV+TgsVm618HOWdTIBHWwmZfGCCaEzHqZU4Dxy1LVgNt6N8TBij1jFsdDIiCwA61ta1cxEt ZFQzVds0B9qtMrLjVjSiUIYu1I7Ks X-Google-Smtp-Source: AGHT+IEsR0fX4mu6qIR0dec/ZWIENXXucQzEdKkuwM/+snwoIUasS41gYQP+hlmbxTeAUtwsnl0Urw== X-Received: by 2002:a17:903:f8c:b0:221:1497:7b08 with SMTP id d9443c01a7336-23b355985d6mr50306475ad.23.1751361114685; Tue, 01 Jul 2025 02:11:54 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b34e30201c1sm8893603a12.22.2025.07.01.02.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 02:11:54 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, Vikas Gupta , Bhargava Chenna Marreddy , Rajashekar Hudumula Subject: [net-next, v3 02/10] bng_en: Add devlink interface Date: Tue, 1 Jul 2025 14:35:00 +0000 Message-ID: <20250701143511.280702-3-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250701143511.280702-1-vikas.gupta@broadcom.com> References: <20250701143511.280702-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Allocate a base device and devlink interface with minimal devlink ops. Add dsn and board related information. Map PCIe BAR (bar0), which helps to communicate with the firmware. Signed-off-by: Vikas Gupta Reviewed-by: Bhargava Chenna Marreddy Reviewed-by: Rajashekar Hudumula --- drivers/net/ethernet/broadcom/Kconfig | 1 + drivers/net/ethernet/broadcom/bnge/Makefile | 3 +- drivers/net/ethernet/broadcom/bnge/bnge.h | 11 ++ .../net/ethernet/broadcom/bnge/bnge_core.c | 39 +++++ .../net/ethernet/broadcom/bnge/bnge_devlink.c | 142 ++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_devlink.h | 16 ++ 6 files changed, 211 insertions(+), 1 deletion(-) create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_devlink.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_devlink.h diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/b= roadcom/Kconfig index e2c1ac91708e..0fc10e6c6902 100644 --- a/drivers/net/ethernet/broadcom/Kconfig +++ b/drivers/net/ethernet/broadcom/Kconfig @@ -256,6 +256,7 @@ config BNXT_HWMON config BNGE tristate "Broadcom Ethernet device support" depends on PCI + select NET_DEVLINK help This driver supports Broadcom 50/100/200/400/800 gigabit Ethernet cards. The module will be called bng_en. To compile this driver as a module, diff --git a/drivers/net/ethernet/broadcom/bnge/Makefile b/drivers/net/ethe= rnet/broadcom/bnge/Makefile index 0c3d632805d1..e021a14d2fa0 100644 --- a/drivers/net/ethernet/broadcom/bnge/Makefile +++ b/drivers/net/ethernet/broadcom/bnge/Makefile @@ -2,4 +2,5 @@ =20 obj-$(CONFIG_BNGE) +=3D bng_en.o =20 -bng_en-y :=3D bnge_core.o +bng_en-y :=3D bnge_core.o \ + bnge_devlink.o diff --git a/drivers/net/ethernet/broadcom/bnge/bnge.h b/drivers/net/ethern= et/broadcom/bnge/bnge.h index b49c51b44473..19d85aabab4e 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge.h @@ -13,4 +13,15 @@ enum board_idx { BCM57708, }; =20 +struct bnge_dev { + struct device *dev; + struct pci_dev *pdev; + u64 dsn; +#define BNGE_VPD_FLD_LEN 32 + char board_partno[BNGE_VPD_FLD_LEN]; + char board_serialno[BNGE_VPD_FLD_LEN]; + + void __iomem *bar0; +}; + #endif /* _BNGE_H_ */ diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_core.c b/drivers/net/e= thernet/broadcom/bnge/bnge_core.c index 514602555cd1..2596215f0639 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_core.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_core.c @@ -7,6 +7,7 @@ #include =20 #include "bnge.h" +#include "bnge_devlink.h" =20 MODULE_LICENSE("GPL"); MODULE_DESCRIPTION(DRV_SUMMARY); @@ -77,8 +78,19 @@ static int bnge_pci_enable(struct pci_dev *pdev) return rc; } =20 +static void bnge_unmap_bars(struct pci_dev *pdev) +{ + struct bnge_dev *bd =3D pci_get_drvdata(pdev); + + if (bd->bar0) { + pci_iounmap(pdev, bd->bar0); + bd->bar0 =3D NULL; + } +} + static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id= *ent) { + struct bnge_dev *bd; int rc; =20 if (pci_is_bridge(pdev)) @@ -100,13 +112,40 @@ static int bnge_probe_one(struct pci_dev *pdev, const= struct pci_device_id *ent) =20 bnge_print_device_info(pdev, ent->driver_data); =20 + bd =3D bnge_devlink_alloc(pdev); + if (!bd) { + dev_err(&pdev->dev, "Devlink allocation failed\n"); + rc =3D -ENOMEM; + goto err_pci_disable; + } + + bd->bar0 =3D pci_ioremap_bar(pdev, 0); + if (!bd->bar0) { + dev_err(&pdev->dev, "Failed mapping BAR-0, aborting\n"); + rc =3D -ENOMEM; + goto err_devl_free; + } + pci_save_state(pdev); =20 return 0; + +err_devl_free: + bnge_devlink_free(bd); + +err_pci_disable: + bnge_pci_disable(pdev); + return rc; } =20 static void bnge_remove_one(struct pci_dev *pdev) { + struct bnge_dev *bd =3D pci_get_drvdata(pdev); + + bnge_unmap_bars(pdev); + + bnge_devlink_free(bd); + bnge_pci_disable(pdev); } =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/ne= t/ethernet/broadcom/bnge/bnge_devlink.c new file mode 100644 index 000000000000..d01cc32ce241 --- /dev/null +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c @@ -0,0 +1,142 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) 2025 Broadcom. + +#include +#include +#include +#include + +#include "bnge.h" +#include "bnge_devlink.h" + +static int bnge_dl_info_put(struct bnge_dev *bd, struct devlink_info_req *= req, + enum bnge_dl_version_type type, const char *key, + char *buf) +{ + if (!strlen(buf)) + return 0; + + switch (type) { + case BNGE_VERSION_FIXED: + return devlink_info_version_fixed_put(req, key, buf); + case BNGE_VERSION_RUNNING: + return devlink_info_version_running_put(req, key, buf); + case BNGE_VERSION_STORED: + return devlink_info_version_stored_put(req, key, buf); + } + + return 0; +} + +static void bnge_vpd_read_info(struct bnge_dev *bd) +{ + struct pci_dev *pdev =3D bd->pdev; + unsigned int vpd_size, kw_len; + int pos, size; + u8 *vpd_data; + + vpd_data =3D pci_vpd_alloc(pdev, &vpd_size); + if (IS_ERR(vpd_data)) { + pci_warn(pdev, "Unable to read VPD\n"); + return; + } + + pos =3D pci_vpd_find_ro_info_keyword(vpd_data, vpd_size, + PCI_VPD_RO_KEYWORD_PARTNO, &kw_len); + if (pos < 0) + goto read_sn; + + size =3D min_t(int, kw_len, BNGE_VPD_FLD_LEN - 1); + memcpy(bd->board_partno, &vpd_data[pos], size); + +read_sn: + pos =3D pci_vpd_find_ro_info_keyword(vpd_data, vpd_size, + PCI_VPD_RO_KEYWORD_SERIALNO, + &kw_len); + if (pos < 0) + goto exit; + + size =3D min_t(int, kw_len, BNGE_VPD_FLD_LEN - 1); + memcpy(bd->board_serialno, &vpd_data[pos], size); + +exit: + kfree(vpd_data); +} + +static int bnge_devlink_info_get(struct devlink *devlink, + struct devlink_info_req *req, + struct netlink_ext_ack *extack) +{ + struct bnge_dev *bd =3D devlink_priv(devlink); + int rc; + + if (bd->dsn) { + char buf[32]; + u8 dsn[8]; + int rc; + + put_unaligned_le64(bd->dsn, dsn); + sprintf(buf, "%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X", + dsn[7], dsn[6], dsn[5], dsn[4], + dsn[3], dsn[2], dsn[1], dsn[0]); + rc =3D devlink_info_serial_number_put(req, buf); + if (rc) { + NL_SET_ERR_MSG_MOD(extack, "Failed to set dsn"); + return rc; + } + } + + if (strlen(bd->board_serialno)) { + rc =3D devlink_info_board_serial_number_put(req, + bd->board_serialno); + if (rc) { + NL_SET_ERR_MSG_MOD(extack, + "Failed to set board serial number"); + return rc; + } + } + + rc =3D bnge_dl_info_put(bd, req, BNGE_VERSION_FIXED, + DEVLINK_INFO_VERSION_GENERIC_BOARD_ID, + bd->board_partno); + if (rc) { + NL_SET_ERR_MSG_MOD(extack, "Failed to set board part number"); + return rc; + } + + return rc; +} + +static const struct devlink_ops bnge_devlink_ops =3D { + .info_get =3D bnge_devlink_info_get, +}; + +void bnge_devlink_free(struct bnge_dev *bd) +{ + struct devlink *devlink =3D priv_to_devlink(bd); + + devlink_free(devlink); +} + +struct bnge_dev *bnge_devlink_alloc(struct pci_dev *pdev) +{ + struct devlink *devlink; + struct bnge_dev *bd; + + devlink =3D devlink_alloc(&bnge_devlink_ops, sizeof(*bd), &pdev->dev); + if (!devlink) + return NULL; + + bd =3D devlink_priv(devlink); + pci_set_drvdata(pdev, bd); + bd->dev =3D &pdev->dev; + bd->pdev =3D pdev; + + bd->dsn =3D pci_get_dsn(pdev); + if (!bd->dsn) + pci_warn(pdev, "Failed to get DSN\n"); + + bnge_vpd_read_info(bd); + + return bd; +} diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.h b/drivers/ne= t/ethernet/broadcom/bnge/bnge_devlink.h new file mode 100644 index 000000000000..497543918741 --- /dev/null +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.h @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2025 Broadcom */ + +#ifndef _BNGE_DEVLINK_H_ +#define _BNGE_DEVLINK_H_ + +enum bnge_dl_version_type { + BNGE_VERSION_FIXED, + BNGE_VERSION_RUNNING, + BNGE_VERSION_STORED, +}; + +void bnge_devlink_free(struct bnge_dev *bd); +struct bnge_dev *bnge_devlink_alloc(struct pci_dev *pdev); + +#endif /* _BNGE_DEVLINK_H_ */ --=20 2.47.1