From nobody Wed Oct 8 07:44:57 2025 Received: from forward103b.mail.yandex.net (forward103b.mail.yandex.net [178.154.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1FEDA47; Tue, 1 Jul 2025 05:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.150 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348191; cv=none; b=WZpBs2wV9qsMjhsqSF7e5sFt2UnX0LvuZjk5KzhE0mWHJ6/GH4kJeQGlXNycNGcmlra5xRpGXsgYgXsbAAyPZ2yF1kBrZC3Krzosy2pT8+MHbWVqNt5W5B6sLDde5+ZFk++8yobgG0EzMgvHj7Npkh4jGntlhqXES/swMCM9fBQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348191; c=relaxed/simple; bh=+eIrbPhrMh0++e6kz5iSAOdM+z+t7Psr3bYkT3DkrO8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=K5YI6yOFttKEbnN1tcW6G6z4x5y0k/BH2TVq78SYnUuucUuWvMxrMgFVbWZtOmz/cJUXcJwEp9y07gmvssKwKz24GzdsaVxDae9lTpho+NLODEtPKXQ1muq4TVAKHX94/hcuEwrwuRqYtpmh/6we0ttrGO2wEDReLDC5vtDXA/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev; spf=pass smtp.mailfrom=onurozkan.dev; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b=bSfWsoCC; arc=none smtp.client-ip=178.154.239.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="bSfWsoCC" Received: from mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net [IPv6:2a02:6b8:c23:2f3c:0:640:5ff5:0]) by forward103b.mail.yandex.net (Yandex) with ESMTPS id 29CAA60B26; Tue, 1 Jul 2025 08:36:19 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 6aSk1O9Lw4Y0-O8ja4a0R; Tue, 01 Jul 2025 08:36:18 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=mail; t=1751348178; bh=y+LAMmnFYTdz8jpbgDC1hzvn1qc57V9XPIM+KBbaED0=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=bSfWsoCCoApYmQOWQ88UCQqIYtJ2JlIT9ZInwoh5nrhzZADZOCpiZrCsKSevzh0Kc vu20S9V1MqMvtHEZnnt19Sg2CzztAqCys92d6YxmGqOlMPYeILl5ZiWre4ILiuqwzj j5lBtnmZt0Uy1Ml6EiMxppRjy0vTg8hpWxJL+3NE= Authentication-Results: mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net; dkim=pass header.i=@onurozkan.dev From: =?UTF-8?q?Onur=20=C3=96zkan?= To: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Cc: airlied@gmail.com, simona@ffwll.ch, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, rafael@kernel.org, viresh.kumar@linaro.org, gregkh@linuxfoundation.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, davidgow@google.com, nm@ti.com, =?UTF-8?q?Onur=20=C3=96zkan?= Subject: [PATCH v4 1/6] rust: switch to `#[expect(...)]` in core modules Date: Tue, 1 Jul 2025 08:35:52 +0300 Message-ID: <20250701053557.20859-2-work@onurozkan.dev> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250701053557.20859-1-work@onurozkan.dev> References: <20250701053557.20859-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This makes it clear that the warning is expected not just ignored, so we don't end up having various unnecessary linting rules in the codebase. Some parts of the codebase already use this approach, this patch just applies it more broadly. No functional changes. Signed-off-by: Onur =C3=96zkan --- rust/kernel/alloc/allocator_test.rs | 2 +- rust/kernel/error.rs | 2 +- rust/kernel/types.rs | 2 +- rust/macros/helpers.rs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/alloca= tor_test.rs index d19c06ef0498..844197d7194e 100644 --- a/rust/kernel/alloc/allocator_test.rs +++ b/rust/kernel/alloc/allocator_test.rs @@ -7,7 +7,7 @@ //! `Cmalloc` allocator within the `allocator_test` module and type alias = all kernel allocators to //! `Cmalloc`. The `Cmalloc` allocator uses libc's `realloc()` function as= allocator backend. -#![allow(missing_docs)] +#![expect(missing_docs)] use super::{flags::*, AllocError, Allocator, Flags}; use core::alloc::Layout; diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs index 3dee3139fcd4..a59613918d4c 100644 --- a/rust/kernel/error.rs +++ b/rust/kernel/error.rs @@ -263,7 +263,7 @@ fn from(e: core::convert::Infallible) -> Error { /// [`samples/rust/rust_minimal.rs`]): /// /// ``` -/// # #[allow(clippy::single_match)] +/// # #[expect(clippy::single_match)] /// fn example() -> Result { /// let mut numbers =3D KVec::new(); /// diff --git a/rust/kernel/types.rs b/rust/kernel/types.rs index 22985b6f6982..a5d5a4737a41 100644 --- a/rust/kernel/types.rs +++ b/rust/kernel/types.rs @@ -600,5 +600,5 @@ pub enum Either { /// constructed. /// /// [`NotThreadSafe`]: type@NotThreadSafe -#[allow(non_upper_case_globals)] +#[expect(non_upper_case_globals)] pub const NotThreadSafe: NotThreadSafe =3D PhantomData; diff --git a/rust/macros/helpers.rs b/rust/macros/helpers.rs index e2602be402c1..6fd1462ff01a 100644 --- a/rust/macros/helpers.rs +++ b/rust/macros/helpers.rs @@ -98,7 +98,7 @@ pub(crate) fn file() -> String { } #[cfg(CONFIG_RUSTC_HAS_SPAN_FILE)] - #[allow(clippy::incompatible_msrv)] + #[expect(clippy::incompatible_msrv)] { proc_macro::Span::call_site().file() } -- 2.50.0 From nobody Wed Oct 8 07:44:57 2025 Received: from forward102b.mail.yandex.net (forward102b.mail.yandex.net [178.154.239.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E7E121CC5D; Tue, 1 Jul 2025 05:36:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.149 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348193; cv=none; b=mxjAGi/7F8xr8PVD3z4dTUdchTqnHfQ1zfgsTEK9Z0XkQNcR4IVvI8Co+n3jr6FI9kcPrzuRDanUTXx014yPdc3at4YMIkf+iGNZ4V/otxn+ZrU4FCFlFHerECFIfhO+kBjZ0tnhyw5pN0l23sGR5PtSDpCGGPx6i1bdjph/YiY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348193; c=relaxed/simple; bh=vrPJWN941QVnpQ/d7LvVaOBwHEMzgQZ+babRIJu8FRk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Fjces62qlTcX9IBENjtnUM2bmOE8Il5Oj5XvegZkoUgDEYPt8c56e7iz825SUmCuhhnVZPH5bp5RcQmZsr9u9oLVndg559QwNG0ZeLmZkB6kAYxjap6grgQYEy3wXdEozjFHy58jd8jhZoz3r0MbAmwb4avW/v9hFyAMLGp69hY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev; spf=pass smtp.mailfrom=onurozkan.dev; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b=Dlik2Jxw; arc=none smtp.client-ip=178.154.239.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="Dlik2Jxw" Received: from mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net [IPv6:2a02:6b8:c23:2f3c:0:640:5ff5:0]) by forward102b.mail.yandex.net (Yandex) with ESMTPS id CC1BB60D55; Tue, 1 Jul 2025 08:36:22 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 6aSk1O9Lw4Y0-pYGl2S2K; Tue, 01 Jul 2025 08:36:21 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=mail; t=1751348182; bh=Fu/EvnRcgzeSqzXsKWwb9gUgTOQaKWQ8C0GMLKqO88M=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=Dlik2Jxwp+xx0rQZbJ7/IiXcdzuBneu412xiV+Jx3/QOrGK2Ak+7+5ItER6Bnhgcz bEKGqoLIzYWXQhtODA2h7Wdl9TylA1EtQl1L13xCoDyyDnEN+5JhoVxp83HjUCuhPv IKaT1v0aHLCl7RmldGah7CfH/vXKQbaMxspqqrsM= Authentication-Results: mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net; dkim=pass header.i=@onurozkan.dev From: =?UTF-8?q?Onur=20=C3=96zkan?= To: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Cc: airlied@gmail.com, simona@ffwll.ch, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, rafael@kernel.org, viresh.kumar@linaro.org, gregkh@linuxfoundation.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, davidgow@google.com, nm@ti.com, =?UTF-8?q?Onur=20=C3=96zkan?= Subject: [PATCH v4 2/6] rust: switch to `#[expect(...)]` in init and kunit Date: Tue, 1 Jul 2025 08:35:53 +0300 Message-ID: <20250701053557.20859-3-work@onurozkan.dev> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250701053557.20859-1-work@onurozkan.dev> References: <20250701053557.20859-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This makes it clear that the warning is expected not just ignored, so we don't end up having various unnecessary linting rules in the codebase. Some parts of the codebase already use this approach, this patch just applies it more broadly. No functional changes. Signed-off-by: Onur =C3=96zkan Reviewed-by: Trevor Gross --- rust/kernel/init.rs | 6 +++--- rust/kernel/kunit.rs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/rust/kernel/init.rs b/rust/kernel/init.rs index 8d228c237954..288b1c2a290d 100644 --- a/rust/kernel/init.rs +++ b/rust/kernel/init.rs @@ -30,7 +30,7 @@ //! ## General Examples //! //! ```rust,ignore -//! # #![allow(clippy::disallowed_names)] +//! # #![expect(clippy::disallowed_names)] //! use kernel::types::Opaque; //! use pin_init::pin_init_from_closure; //! @@ -67,11 +67,11 @@ //! ``` //! //! ```rust,ignore -//! # #![allow(unreachable_pub, clippy::disallowed_names)] +//! # #![expect(unreachable_pub, clippy::disallowed_names)] //! use kernel::{prelude::*, types::Opaque}; //! use core::{ptr::addr_of_mut, marker::PhantomPinned, pin::Pin}; //! # mod bindings { -//! # #![allow(non_camel_case_types)] +//! # #![expect(non_camel_case_types)] //! # pub struct foo; //! # pub unsafe fn init_foo(_ptr: *mut foo) {} //! # pub unsafe fn destroy_foo(_ptr: *mut foo) {} diff --git a/rust/kernel/kunit.rs b/rust/kernel/kunit.rs index 4b8cdcb21e77..91710a1d7b87 100644 --- a/rust/kernel/kunit.rs +++ b/rust/kernel/kunit.rs @@ -280,7 +280,7 @@ macro_rules! kunit_unsafe_test_suite { static mut KUNIT_TEST_SUITE: ::kernel::bindings::kunit_suite = =3D ::kernel::bindings::kunit_suite { name: KUNIT_TEST_SUITE_NAME, - #[allow(unused_unsafe)] + #[expect(unused_unsafe)] // SAFETY: `$test_cases` is passed in by the user, and // (as documented) must be valid for the lifetime of // the suite (i.e., static). -- 2.50.0 From nobody Wed Oct 8 07:44:57 2025 Received: from forward103b.mail.yandex.net (forward103b.mail.yandex.net [178.154.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FED31AF0B6; Tue, 1 Jul 2025 05:36:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.150 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348190; cv=none; b=hjyJc2V6FoGX1D78JB1G3qKHiKRy/zGPSPWZ+t3VMwEcu+DtCI1bWRvCEiaTANsIT7tSJtyZUVqI0BsuvxYWokbpPHZJjZssZ/zGRdWpNHEJ7BN0tn1+wXxN6B1A/GQuSCS2KQzU88Ovq8n0PTlaLfcN54MvmGTj0AaLi/8n3G4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348190; c=relaxed/simple; bh=QyWrQPXXxFIvY5Y5myJjIi7pV2uH3HswisRYsgJ2pGw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YMlgg1eTRD6x9/3niQ3R+dUhzuJY5PsLvOIqIgbbrInYojR4ZDbK4uXYqU7qYvueH0/oxtKjDtKiY26JmTndA7umo3ct4/IYmth897xXjyhdzEyUMr4ytRds8n7lifx90FLmSp7RaJ4dH5utKVWxUIRd00c8TMAv2TKVPxd5aqo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev; spf=pass smtp.mailfrom=onurozkan.dev; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b=ZbyeDo7b; arc=none smtp.client-ip=178.154.239.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="ZbyeDo7b" Received: from mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net [IPv6:2a02:6b8:c23:2f3c:0:640:5ff5:0]) by forward103b.mail.yandex.net (Yandex) with ESMTPS id 7012E60CFF; Tue, 1 Jul 2025 08:36:26 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 6aSk1O9Lw4Y0-QdGxv3DU; Tue, 01 Jul 2025 08:36:25 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=mail; t=1751348185; bh=QyWrQPXXxFIvY5Y5myJjIi7pV2uH3HswisRYsgJ2pGw=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=ZbyeDo7bCUa12zV+VLQBteTD7EBASnT+aPfM6wgePDFm/evRJBImQ8CLnylIdCJZv zhE3GRycEFoe2nDIxVCkn6KNeDzFHZc2v5I/wX5oSqzOUP/wm/K0lBDz05caQhJWyH MMjH7vYrsV+b5mr9JImbfvjcbajPvAaB/DMlE69Y= Authentication-Results: mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net; dkim=pass header.i=@onurozkan.dev From: =?UTF-8?q?Onur=20=C3=96zkan?= To: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Cc: airlied@gmail.com, simona@ffwll.ch, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, rafael@kernel.org, viresh.kumar@linaro.org, gregkh@linuxfoundation.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, davidgow@google.com, nm@ti.com, =?UTF-8?q?Onur=20=C3=96zkan?= Subject: [PATCH v4 3/6] drivers: gpu: switch to `#[expect(...)]` in nova-core/regs.rs Date: Tue, 1 Jul 2025 08:35:54 +0300 Message-ID: <20250701053557.20859-4-work@onurozkan.dev> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250701053557.20859-1-work@onurozkan.dev> References: <20250701053557.20859-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This makes it clear that the warning is expected not just ignored, so we don't end up having various unnecessary linting rules in the codebase. Some parts of the codebase already use this approach, this patch just applies it more broadly. No functional changes. Signed-off-by: Onur =C3=96zkan Reviewed-by: Trevor Gross --- drivers/gpu/nova-core/regs.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index 5a1273230306..87e5963f1ebb 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -2,7 +2,7 @@ // Required to retain the original register names used by OpenRM, which ar= e all capital snake case // but are mapped to types. -#![allow(non_camel_case_types)] +#![expect(non_camel_case_types)] #[macro_use] mod macros; -- 2.50.0 From nobody Wed Oct 8 07:44:57 2025 Received: from forward103b.mail.yandex.net (forward103b.mail.yandex.net [178.154.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F91D221F37; Tue, 1 Jul 2025 05:36:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.150 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348193; cv=none; b=UEKC40YUOIVUzzGOuBsdov6vWeOZuPUenLNMvaWA3IYagwdjASMxLY9YIvOv143UOiHY7BGgTuRrAgW8sjNsWd0GrdfszOR4MXgqlDSYI+bcgRAO7jnPjlCR9enAunvZb4A8mMhpOGBdIydFfDmdJOgXtLG1HJGi+V/kr3xdHnM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348193; c=relaxed/simple; bh=uAnU3kDp5eULh9YY0m4O2RAbhlB1sslSRQ44j/FLrBk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Bo+f6lNQoSKrIgCW7AMlvYvBn3WYQ+g9uYU18zAptXiJ/RAsqyF4InpQBESf1eKArPs0sIX/g3pqgK6l7te8d1wwps8BemoM8hmMpa6XpFaKPpxV+W9LpchZ/FDf98/LuNILbVDW+glzH2cmDhIIR8R9XwPbe1JD2q+v+L1Xebw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev; spf=pass smtp.mailfrom=onurozkan.dev; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b=MIjsTkTC; arc=none smtp.client-ip=178.154.239.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="MIjsTkTC" Received: from mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net [IPv6:2a02:6b8:c23:2f3c:0:640:5ff5:0]) by forward103b.mail.yandex.net (Yandex) with ESMTPS id A961860A78; Tue, 1 Jul 2025 08:36:29 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 6aSk1O9Lw4Y0-plAPQCWS; Tue, 01 Jul 2025 08:36:29 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=mail; t=1751348189; bh=pm/en0ZhUL0BgyJub87GJFGa1ribxd2XG0S8lpom2u0=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=MIjsTkTCDCjKX3QrRdPaFBQlNPTevzwkWwI/P0mKU877VgJ/Se5ZWPTTVtJyZYsa+ JuSCScKvINjAMNUpMwLuquV8ZwAPWEFLX1xNyjaN/oxZEKz95zdAT+T2jfjS590qLn CvWEC1xfrD8hya+GobD0iRUpI3uMoIg1gY2VzoJk= Authentication-Results: mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net; dkim=pass header.i=@onurozkan.dev From: =?UTF-8?q?Onur=20=C3=96zkan?= To: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Cc: airlied@gmail.com, simona@ffwll.ch, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, rafael@kernel.org, viresh.kumar@linaro.org, gregkh@linuxfoundation.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, davidgow@google.com, nm@ti.com, =?UTF-8?q?Onur=20=C3=96zkan?= Subject: [PATCH v4 4/6] rust: switch to `#[expect(...)]` in devres, driver and ioctl Date: Tue, 1 Jul 2025 08:35:55 +0300 Message-ID: <20250701053557.20859-5-work@onurozkan.dev> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250701053557.20859-1-work@onurozkan.dev> References: <20250701053557.20859-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This makes it clear that the warning is expected not just ignored, so we don't end up having various unnecessary linting rules in the codebase. Some parts of the codebase already use this approach, this patch just applies it more broadly. No functional changes. Signed-off-by: Onur =C3=96zkan --- rust/kernel/devres.rs | 2 +- rust/kernel/driver.rs | 2 +- rust/kernel/drm/ioctl.rs | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs index 57502534d985..0e9510cf4625 100644 --- a/rust/kernel/devres.rs +++ b/rust/kernel/devres.rs @@ -157,7 +157,7 @@ fn remove_action(this: &Arc) -> bool { success } - #[allow(clippy::missing_safety_doc)] + #[expect(clippy::missing_safety_doc)] unsafe extern "C" fn devres_callback(ptr: *mut kernel::ffi::c_void) { let ptr =3D ptr as *mut DevresInner; // Devres owned this memory; now that we received the callback, dr= op the `Arc` and hence the diff --git a/rust/kernel/driver.rs b/rust/kernel/driver.rs index ec9166cedfa7..fc7bd65b01f1 100644 --- a/rust/kernel/driver.rs +++ b/rust/kernel/driver.rs @@ -168,7 +168,7 @@ fn of_id_info(dev: &device::Device) -> Option<&'static = Self::IdInfo> { } #[cfg(not(CONFIG_OF))] - #[allow(missing_docs)] + #[expect(missing_docs)] fn of_id_info(_dev: &device::Device) -> Option<&'static Self::IdInfo> { None } diff --git a/rust/kernel/drm/ioctl.rs b/rust/kernel/drm/ioctl.rs index 445639404fb7..3ae8d2d8263f 100644 --- a/rust/kernel/drm/ioctl.rs +++ b/rust/kernel/drm/ioctl.rs @@ -9,28 +9,28 @@ const BASE: u32 =3D uapi::DRM_IOCTL_BASE as u32; /// Construct a DRM ioctl number with no argument. -#[allow(non_snake_case)] +#[expect(non_snake_case)] #[inline(always)] pub const fn IO(nr: u32) -> u32 { ioctl::_IO(BASE, nr) } /// Construct a DRM ioctl number with a read-only argument. -#[allow(non_snake_case)] +#[expect(non_snake_case)] #[inline(always)] pub const fn IOR(nr: u32) -> u32 { ioctl::_IOR::(BASE, nr) } /// Construct a DRM ioctl number with a write-only argument. -#[allow(non_snake_case)] +#[expect(non_snake_case)] #[inline(always)] pub const fn IOW(nr: u32) -> u32 { ioctl::_IOW::(BASE, nr) } /// Construct a DRM ioctl number with a read-write argument. -#[allow(non_snake_case)] +#[expect(non_snake_case)] #[inline(always)] pub const fn IOWR(nr: u32) -> u32 { ioctl::_IOWR::(BASE, nr) -- 2.50.0 From nobody Wed Oct 8 07:44:57 2025 Received: from forward101b.mail.yandex.net (forward101b.mail.yandex.net [178.154.239.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7DDE25A631; Tue, 1 Jul 2025 05:36:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.148 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348203; cv=none; b=aPi/yCb5ptKfFiwJ1tIVPhCIp5qZOx2zMg9VUuOzvKfZfllSbgRohf1ezhNT17ANLFVBmQAj7uCaro0VgaUL810NMpt4Hw7eIqhNs/ZM7D1/JE6zbqd10uiRzTOfzzCY/0kHyWqLwGBVQkuWLpFah2AFvBfovn/8F84cV7t5aBk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348203; c=relaxed/simple; bh=5jNHxYiPINqgM7TZSD4XvG1CJYs9BSX4iWIo7g+ug3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ab8eF0oyYrBBo+tDRMx8Q2Yx5CexR5y9433Nw0Ylg/z5/SGWt8AoCQAtiKb3GgFpRGGFYivosU+G4efQWst84l2eYwTW1XZXL22MgkjoE3w7Kote98ohoaNZISYWTAQfSx883d4kQOoj+Qbpxagh+r9V4LtcBs3891r0aC3tcUY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev; spf=pass smtp.mailfrom=onurozkan.dev; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b=UWHkH0fX; arc=none smtp.client-ip=178.154.239.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="UWHkH0fX" Received: from mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net [IPv6:2a02:6b8:c23:2f3c:0:640:5ff5:0]) by forward101b.mail.yandex.net (Yandex) with ESMTPS id 591C560E90; Tue, 1 Jul 2025 08:36:33 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 6aSk1O9Lw4Y0-1OE3Q5MK; Tue, 01 Jul 2025 08:36:32 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=mail; t=1751348192; bh=ry/nljdjBuoojwts/DOYg5GF1XJZ/JGUBkyIcJh8zZo=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=UWHkH0fXVN3+tw31Ku6DMjgmpa4O7ffykpmPQclND3Raezz2+0vbkfPPJ/NwUiEUz RMzm+tYNe76wq+isNP4tcpr1AfgVDMNnM7FgJ/4qTA+TXSwnj2cK26qVYvGpioDuGU NiOnuGbJxam06BrRrjocCHMcV9ZKb+MZsD9h6E9A= Authentication-Results: mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net; dkim=pass header.i=@onurozkan.dev From: =?UTF-8?q?Onur=20=C3=96zkan?= To: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Cc: airlied@gmail.com, simona@ffwll.ch, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, rafael@kernel.org, viresh.kumar@linaro.org, gregkh@linuxfoundation.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, davidgow@google.com, nm@ti.com, =?UTF-8?q?Onur=20=C3=96zkan?= Subject: [PATCH v4 5/6] rust: remove `#[allow(clippy::unnecessary_cast)]` Date: Tue, 1 Jul 2025 08:35:56 +0300 Message-ID: <20250701053557.20859-6-work@onurozkan.dev> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250701053557.20859-1-work@onurozkan.dev> References: <20250701053557.20859-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This isn't needed anymore since `kernel::ffi::c_int` type is always `i32` which differs from `err` (isize). Signed-off-by: Onur =C3=96zkan Reviewed-by: Trevor Gross --- rust/kernel/error.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs index a59613918d4c..05c6e71c0afb 100644 --- a/rust/kernel/error.rs +++ b/rust/kernel/error.rs @@ -413,7 +413,6 @@ pub fn from_err_ptr(ptr: *mut T) -> Result<*mut T> { // SAFETY: The FFI function does not deref the pointer. let err =3D unsafe { bindings::PTR_ERR(const_ptr) }; - #[allow(clippy::unnecessary_cast)] // CAST: If `IS_ERR()` returns `true`, // then `PTR_ERR()` is guaranteed to return a // negative value greater-or-equal to `-bindings::MAX_ERRNO`, -- 2.50.0 From nobody Wed Oct 8 07:44:57 2025 Received: from forward103b.mail.yandex.net (forward103b.mail.yandex.net [178.154.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1AA1F8753; Tue, 1 Jul 2025 05:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.150 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348200; cv=none; b=fHLRaIhK7cMUMqKbBUezK16aHf0m/4opmuEKVzBG1RC/OCK0ohOARv05PwA9UTYSPHoexL4VoPPQsLdrmzJ9T5DIzlvVV9ZWLfK72XotgDdB4OPbBuywJQp23p3Ua4jvUimyxSzFirjHgmzDYXW07zEcwreFw9Jd0rljls4Up0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751348200; c=relaxed/simple; bh=DlQdZ+tKxr2mrZ0rbdKHurSPk85XG411g8Jq+IVgsOc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uhf7iEdiXQYjZwDxxNcQ4gqRqsqniGJaw57usxWnAcoiNmnGXaoWuvWCvXU5Nmhns3VFLEZmbsjRJJRCcLj4gMq/JSwMHCUA6ixc+zqzg41VVW1KclFF1s6KeNw8ibi63pWXK/HqYYTXrNc2mAVUB9ytunjMD4+3Q11EkOZH2qE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev; spf=pass smtp.mailfrom=onurozkan.dev; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b=TafVrYzf; arc=none smtp.client-ip=178.154.239.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="TafVrYzf" Received: from mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net [IPv6:2a02:6b8:c23:2f3c:0:640:5ff5:0]) by forward103b.mail.yandex.net (Yandex) with ESMTPS id 8844B60B52; Tue, 1 Jul 2025 08:36:36 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 6aSk1O9Lw4Y0-5nNzaaUb; Tue, 01 Jul 2025 08:36:36 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=mail; t=1751348196; bh=DlQdZ+tKxr2mrZ0rbdKHurSPk85XG411g8Jq+IVgsOc=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=TafVrYzf7ghMvfbJ0L4pTQER77oEf0SCoMteGufwb9wk2AhdeH7r5713694Wg/FcN fuvEOrE2AITwu9/8E1eRIR6mLCgUwIphPsb/KoFMP4SDkB0VMckvLrS6X/fVRleYNl dsgYgfFsmguGuGZmJdJwYEn0OYV81phhn1w3PfHE= Authentication-Results: mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net; dkim=pass header.i=@onurozkan.dev From: =?UTF-8?q?Onur=20=C3=96zkan?= To: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Cc: airlied@gmail.com, simona@ffwll.ch, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, rafael@kernel.org, viresh.kumar@linaro.org, gregkh@linuxfoundation.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, davidgow@google.com, nm@ti.com, =?UTF-8?q?Onur=20=C3=96zkan?= Subject: [PATCH v4 6/6] rust: remove `#[allow(clippy::non_send_fields_in_send_ty)]` Date: Tue, 1 Jul 2025 08:35:57 +0300 Message-ID: <20250701053557.20859-7-work@onurozkan.dev> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250701053557.20859-1-work@onurozkan.dev> References: <20250701053557.20859-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Just like how we did in [1], we no longer need this lint as it's no longer part of Clippy's `suspicious` lint group. Link: https://github.com/torvalds/linux/commit/5e7c9b84ad08cc7a41b2ddbbbacc= b60057da3860 [1] Signed-off-by: Onur =C3=96zkan --- rust/kernel/cpufreq.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/rust/kernel/cpufreq.rs b/rust/kernel/cpufreq.rs index 11b03e9d7e89..97de9b0573da 100644 --- a/rust/kernel/cpufreq.rs +++ b/rust/kernel/cpufreq.rs @@ -907,7 +907,6 @@ fn register_em(_policy: &mut Policy) { /// or CPUs, so it is safe to share it. unsafe impl Sync for Registration {} -#[allow(clippy::non_send_fields_in_send_ty)] /// SAFETY: Registration with and unregistration from the cpufreq subsyste= m can happen from any /// thread. unsafe impl Send for Registration {} -- 2.50.0