From nobody Wed Oct 8 09:28:28 2025 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BFD271917ED; Tue, 1 Jul 2025 03:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751339708; cv=none; b=TeAJ4TYO00YWI78XZFkRBXKMUjz1GNg2KCixhfG8hLOhMPc0XhF71hA0rwDXSiUd1J80QaYcSyWR4LEKKEN4IppJarA6OJ19a5VnZoDoKoSqYpswotmCFTTczHJ3mbSLKMWOtvUIejmoEjFLiaBDHtkddvLPfGRp79Y3sN/LOTs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751339708; c=relaxed/simple; bh=2wxlRWPiHsTaVt5zYkgULH82AhTGfKsEBem5i4BH374=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pFQl1zEyajJmtg9TCBnWXku1gGzE1FfaLhtlOkvqypAK4CQ3NYBkLf0yHvzi3+Ny8IVNhpFG6n3ckfSfxdcRGYGKQM1hkLM1PHOxd84+xP0KfnQ//9TSdy5tTVSUOEBEqvmz+T9PtsPrAs79e/Xr3ThJVT8A5m2Fb5uSivHSWLo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.2.5.213]) by gateway (Coremail) with SMTP id _____8BxrnK5UmNoK1AgAQ--.5875S3; Tue, 01 Jul 2025 11:15:05 +0800 (CST) Received: from localhost.localdomain (unknown [10.2.5.213]) by front1 (Coremail) with SMTP id qMiowJCxocK4UmNo7GcEAA--.27349S2; Tue, 01 Jul 2025 11:15:05 +0800 (CST) From: Bibo Mao To: Tianrui Zhao , Huacai Chen , Xianglai Li Cc: kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 09/13] LoongArch: KVM: Replace eiointc_enable_irq() with eiointc_update_irq() Date: Tue, 1 Jul 2025 11:15:00 +0800 Message-Id: <20250701031504.1233777-1-maobibo@loongson.cn> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20250701030842.1136519-1-maobibo@loongson.cn> References: <20250701030842.1136519-1-maobibo@loongson.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qMiowJCxocK4UmNo7GcEAA--.27349S2 X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Content-Type: text/plain; charset="utf-8" Function eiointc_enable_irq() checks mask value with char type, and call eiointc_update_irq() eventually. Function eiointc_update_irq() will update one single irq status directly. Here it can check mask value with unsigned long type and call function eiointc_update_irq(), that is simple and direct. Signed-off-by: Bibo Mao --- arch/loongarch/kvm/intc/eiointc.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/arch/loongarch/kvm/intc/eiointc.c b/arch/loongarch/kvm/intc/ei= ointc.c index 5b5b3a73a4fb..5f2c291049b1 100644 --- a/arch/loongarch/kvm/intc/eiointc.c +++ b/arch/loongarch/kvm/intc/eiointc.c @@ -471,7 +471,7 @@ static int loongarch_eiointc_writeq(struct kvm_vcpu *vc= pu, struct loongarch_eiointc *s, gpa_t addr, const void *val) { - int i, index, irq, ret =3D 0; + int index, irq, ret =3D 0; u8 cpu; u64 data, old_data; gpa_t offset; @@ -501,18 +501,21 @@ static int loongarch_eiointc_writeq(struct kvm_vcpu *= vcpu, * update irq when isr is set. */ data =3D s->enable.reg_u64[index] & ~old_data & s->isr.reg_u64[index]; - for (i =3D 0; i < sizeof(data); i++) { - u8 mask =3D (data >> (i * 8)) & 0xff; - eiointc_enable_irq(vcpu, s, index * 8 + i, mask, 1); + while (data) { + irq =3D __ffs(data); + eiointc_update_irq(s, irq + index * 64, 1); + data &=3D ~BIT_ULL(irq); } + /* * 0: disable irq. * update irq when isr is set. */ data =3D ~s->enable.reg_u64[index] & old_data & s->isr.reg_u64[index]; - for (i =3D 0; i < sizeof(data); i++) { - u8 mask =3D (data >> (i * 8)) & 0xff; - eiointc_enable_irq(vcpu, s, index * 8 + i, mask, 0); + while (data) { + irq =3D __ffs(data); + eiointc_update_irq(s, irq + index * 64, 0); + data &=3D ~BIT_ULL(irq); } break; case EIOINTC_BOUNCE_START ... EIOINTC_BOUNCE_END: --=20 2.39.3