From nobody Wed Oct 8 05:54:43 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D849274FFC; Tue, 1 Jul 2025 14:35:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751380536; cv=pass; b=lZkD3M0S631QhC99kNVDfbQDdRF4s8vRfesRQd0E59gkh6iSp+VtIY8n141BUH6k97lwFcy3pSCp4sXMunrbouW2DL8DIVhNj95rGobJSwqBH17gXAULTDMh4DxffMgNFzA8cklLc/BfY2zuk3kqPULAgKzV+esXsmXiIAGr8PY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751380536; c=relaxed/simple; bh=L6HGAuoOWz16KJQyCN1VBJQ0GGYAw625gy+vfasU8v4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kA7sxVrXS3wS4yrTJZGp91fXYs2B0WjsbP6XsVd4YABEDaRrjt5ZvKQxvJn5TKMgCam3rof7FZMzxYqPNUE9RXIB9pVwV4nFd+txvKgFDE+HhOOljjnPP1zxRd4oBP6ua/3w5tF0v3H1cuZFHlVpRBZvZblMC3dGb8YQki+bOBg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=bvlHW6yR; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="bvlHW6yR" ARC-Seal: i=1; a=rsa-sha256; t=1751380511; cv=none; d=zohomail.com; s=zohoarc; b=UrkOcHZJp0oAlNoEYXah58xpfp3GdGPm9PniOS9YRFMADvWeViLwbAgAlZKjp4AOYDm7T1N57dKk8HHiLQNe6XD14hS64LL7MWrIWWppjC+2PZYAT1SVEeeZowCdMWmoF+oXwUSkrf4XdDY22B43h0ZXBdfmV5HpRoIe6knmdtM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751380511; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=am1+k9Vgsj0sTx4Gf9bt86y9Yfop8AO+jd4VXp6U3OQ=; b=jp21Z521pTOaIT8RiRaHB3ppDlop1Fxz76y1fXmdKfGP4w2TW7y1XGtlK25xAgdyhDVwzwiVPAQ/M8QUFDNL5NxNdKJ7A+in72YCV83FsBesjDf5CGQTRwx9MawWcQjaFTo0fy3mV+Ez5xoIM4qg5BQI/PNv64J4YL41AerKk7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1751380511; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=am1+k9Vgsj0sTx4Gf9bt86y9Yfop8AO+jd4VXp6U3OQ=; b=bvlHW6yRc/FOGLRn7O7nS0h6wh/SK4QYn+cVf60uV+PWSJwxaqOhhGGQiHdgm2EI Vw8Yo5PnHGX1PiUzn4Q+miXb878dM1MfJd8ck1CqPRhB4S/j5d0I84OdcOBhZCrIK+B Hb9wh+PPW+q/0ITbQLiL+m+VZFFQKx7/HSziFMEo= Received: by mx.zohomail.com with SMTPS id 175138051036077.87853010475237; Tue, 1 Jul 2025 07:35:10 -0700 (PDT) From: Daniel Almeida Date: Tue, 01 Jul 2025 11:34:39 -0300 Subject: [PATCH v11 1/4] rust: io: add resource abstraction Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250701-topics-tyr-platform_iomem-v11-1-6cd5d5061151@collabora.com> References: <20250701-topics-tyr-platform_iomem-v11-0-6cd5d5061151@collabora.com> In-Reply-To: <20250701-topics-tyr-platform_iomem-v11-0-6cd5d5061151@collabora.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bjorn Helgaas , Mika Westerberg , Ying Huang , Benno Lossin , Benno Lossin Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Fiona Behrens , Daniel Almeida X-Mailer: b4 0.14.2 X-ZohoMailClient: External In preparation for ioremap support, add a Rust abstraction for struct resource. A future commit will introduce the Rust API to ioremap a resource from a platform device. The current abstraction, therefore, adds only the minimum API needed to get that done. Co-developed-by: Fiona Behrens Signed-off-by: Fiona Behrens Signed-off-by: Daniel Almeida Acked-by: Miguel Ojeda --- rust/bindings/bindings_helper.h | 1 + rust/helpers/io.c | 36 +++++++ rust/kernel/io.rs | 4 + rust/kernel/io/resource.rs | 222 ++++++++++++++++++++++++++++++++++++= ++++ 4 files changed, 263 insertions(+) diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helpe= r.h index 7e8f2285064797d5bbac5583990ff823b76c6bdc..5f795e60e889b9fc887013743c8= 1b1cf92a52adb 100644 --- a/rust/bindings/bindings_helper.h +++ b/rust/bindings/bindings_helper.h @@ -53,6 +53,7 @@ #include #include #include +#include #include #include #include diff --git a/rust/helpers/io.c b/rust/helpers/io.c index 15ea187c5466256effd07efe6f6995a1dd95a967..404776cf6717c8570c7600a2471= 2ce6e4623d3c6 100644 --- a/rust/helpers/io.c +++ b/rust/helpers/io.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 =20 #include +#include =20 void __iomem *rust_helper_ioremap(phys_addr_t offset, size_t size) { @@ -99,3 +100,38 @@ void rust_helper_writeq_relaxed(u64 value, void __iomem= *addr) writeq_relaxed(value, addr); } #endif + +resource_size_t rust_helper_resource_size(struct resource *res) +{ + return resource_size(res); +} + +struct resource *rust_helper_request_mem_region(resource_size_t start, + resource_size_t n, + const char *name) +{ + return request_mem_region(start, n, name); +} + +void rust_helper_release_mem_region(resource_size_t start, resource_size_t= n) +{ + release_mem_region(start, n); +} + +struct resource *rust_helper_request_region(resource_size_t start, + resource_size_t n, const char *name) +{ + return request_region(start, n, name); +} + +struct resource *rust_helper_request_muxed_region(resource_size_t start, + resource_size_t n, + const char *name) +{ + return request_muxed_region(start, n, name); +} + +void rust_helper_release_region(resource_size_t start, resource_size_t n) +{ + release_region(start, n); +} diff --git a/rust/kernel/io.rs b/rust/kernel/io.rs index 72d80a6f131e3e826ecd9d2c3bcf54e89aa60cc3..7b70d5b5477e57d6d0f24bcd26b= d8b0071721bc0 100644 --- a/rust/kernel/io.rs +++ b/rust/kernel/io.rs @@ -7,6 +7,10 @@ use crate::error::{code::EINVAL, Result}; use crate::{bindings, build_assert}; =20 +pub mod resource; + +pub use resource::Resource; + /// Raw representation of an MMIO region. /// /// By itself, the existence of an instance of this structure does not pro= vide any guarantees that diff --git a/rust/kernel/io/resource.rs b/rust/kernel/io/resource.rs new file mode 100644 index 0000000000000000000000000000000000000000..611eca8cc693d83bccc2c384db2= ff22d11e7ac46 --- /dev/null +++ b/rust/kernel/io/resource.rs @@ -0,0 +1,222 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Abstractions for system resources. +//! +//! C header: [`include/linux/ioport.h`](srctree/include/linux/ioport.h) + +use core::ops::Deref; +use core::ptr::NonNull; + +use crate::str::CStr; +use crate::types::Opaque; + +#[cfg(CONFIG_HAS_IOPORT)] +/// Returns a reference to the global `ioport_resource` variable. +pub fn ioport_resource() -> &'static Resource { + // SAFETY: `bindings::ioport_resoure` has global lifetime and is of ty= pe Resource. + unsafe { Resource::as_ref(&raw mut bindings::ioport_resource) } +} + +#[cfg(CONFIG_HAS_IOMEM)] +/// Returns a reference to the global `iomem_resource` variable. +pub fn iomem_resource() -> &'static Resource { + // SAFETY: `bindings::iomem_resoure` has global lifetime and is of typ= e Resource. + unsafe { Resource::as_ref(&raw mut bindings::iomem_resource) } +} + +/// Resource Size type. +/// +/// This is a type alias to `u64` depending on the config option +/// `CONFIG_PHYS_ADDR_T_64BIT`. +#[cfg(CONFIG_PHYS_ADDR_T_64BIT)] +pub type ResourceSize =3D u64; + +/// Resource Size type. +/// +/// This is a type alias to `u32` depending on the config option +/// `CONFIG_PHYS_ADDR_T_64BIT`. +#[cfg(not(CONFIG_PHYS_ADDR_T_64BIT))] +pub type ResourceSize =3D u32; + +/// A region allocated from a parent [`Resource`]. +/// +/// # Invariants +/// +/// - `self.0` points to a valid `bindings::resource` that was obtained th= rough +/// `bindings::__request_region`. +pub struct Region(NonNull); + +impl Deref for Region { + type Target =3D Resource; + + fn deref(&self) -> &Self::Target { + // SAFETY: Safe as per the invariant of `Region` + unsafe { Resource::as_ref(self.0.as_ptr()) } + } +} + +impl Drop for Region { + fn drop(&mut self) { + // SAFETY: Safe as per the invariant of `Region` + let res =3D unsafe { Resource::as_ref(self.0.as_ptr()) }; + let flags =3D res.flags(); + + let release_fn =3D if flags.contains(flags::IORESOURCE_MEM) { + bindings::release_mem_region + } else { + bindings::release_region + }; + + // SAFETY: Safe as per the invariant of `Region` + unsafe { release_fn(res.start(), res.size()) }; + } +} + +// SAFETY: `Region` only holds a pointer to a C `struct resource`, which i= s safe to be used from +// any thread. +unsafe impl Send for Region {} + +// SAFETY: `Region` only holds a pointer to a C `struct resource`, referen= ces to which are +// safe to be used from any thread. +unsafe impl Sync for Region {} + +/// A resource abstraction. +/// +/// # Invariants +/// +/// [`Resource`] is a transparent wrapper around a valid `bindings::resour= ce`. +#[repr(transparent)] +pub struct Resource(Opaque); + +impl Resource { + /// Creates a reference to a [`Resource`] from a valid pointer. + /// + /// # Safety + /// + /// The caller must ensure that for the duration of 'a, the pointer wi= ll + /// point at a valid `bindings::resource`. + /// + /// The caller must also ensure that the [`Resource`] is only accessed= via the + /// returned reference for the duration of 'a. + pub(crate) const unsafe fn as_ref<'a>(ptr: *mut bindings::resource) ->= &'a Self { + // SAFETY: Self is a transparent wrapper around `Opaque`. + unsafe { &*ptr.cast() } + } + + /// Requests a resource region. + /// + /// Exclusive access will be given and the region will be marked as bu= sy. + /// Further calls to [`Self::request_region`] will return [`None`] if + /// the region, or a part of it, is already in use. + pub fn request_region( + &self, + start: ResourceSize, + size: ResourceSize, + name: &'static CStr, + flags: Flags, + ) -> Option { + // SAFETY: Safe as per the invariant of `Resource` + let region =3D unsafe { + bindings::__request_region( + self.0.get(), + start, + size, + name.as_char_ptr(), + flags.0 as i32, + ) + }; + + Some(Region(NonNull::new(region)?)) + } + + /// Returns the size of the resource. + pub fn size(&self) -> ResourceSize { + let inner =3D self.0.get(); + // SAFETY: safe as per the invariants of `Resource` + unsafe { bindings::resource_size(inner) } + } + + /// Returns the start address of the resource. + pub fn start(&self) -> u64 { + let inner =3D self.0.get(); + // SAFETY: safe as per the invariants of `Resource` + unsafe { *inner }.start + } + + /// Returns the name of the resource. + pub fn name(&self) -> &'static CStr { + let inner =3D self.0.get(); + // SAFETY: safe as per the invariants of `Resource` + unsafe { CStr::from_char_ptr((*inner).name) } + } + + /// Returns the flags associated with the resource. + pub fn flags(&self) -> Flags { + let inner =3D self.0.get(); + // SAFETY: safe as per the invariants of `Resource` + let flags =3D unsafe { *inner }.flags; + + Flags(flags) + } +} + +// SAFETY: `Resource` only holds a pointer to a C `struct resource`, which= is safe to be used from +// any thead. +unsafe impl Send for Resource {} + +// SAFETY: `Resource` only holds a pointer to a C `struct resource`, refer= ences to which are +// safe to be used from any thead. +unsafe impl Sync for Resource {} + +/// Resource flags as stored in the C `struct resource::flags` field. +/// +/// They can be combined with the operators `|`, `&`, and `!`. +/// +/// Values can be used from the [`flags`] module. +#[derive(Clone, Copy, PartialEq)] +pub struct Flags(usize); + +impl Flags { + /// Check whether `flags` is contained in `self`. + pub fn contains(self, flags: Flags) -> bool { + (self & flags) =3D=3D flags + } +} + +impl core::ops::BitOr for Flags { + type Output =3D Self; + fn bitor(self, rhs: Self) -> Self::Output { + Self(self.0 | rhs.0) + } +} + +impl core::ops::BitAnd for Flags { + type Output =3D Self; + fn bitand(self, rhs: Self) -> Self::Output { + Self(self.0 & rhs.0) + } +} + +impl core::ops::Not for Flags { + type Output =3D Self; + fn not(self) -> Self::Output { + Self(!self.0) + } +} + +/// Resource flags as stored in the `struct resource::flags` field. +pub mod flags { + use super::Flags; + + /// PCI/ISA I/O ports. + pub const IORESOURCE_IO: Flags =3D Flags(bindings::IORESOURCE_IO as us= ize); + + /// Resource is software muxed. + pub const IORESOURCE_MUXED: Flags =3D Flags(bindings::IORESOURCE_MUXED= as usize); + + /// Resource represents a memory region. + pub const IORESOURCE_MEM: Flags =3D Flags(bindings::IORESOURCE_MEM as = usize); + + /// Resource represents a memory region that must be ioremaped using `= ioremap_np`. + pub const IORESOURCE_MEM_NONPOSTED: Flags =3D Flags(bindings::IORESOUR= CE_MEM_NONPOSTED as usize); +} --=20 2.50.0 From nobody Wed Oct 8 05:54:43 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D63EB277C9E; Tue, 1 Jul 2025 14:35:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751380540; cv=pass; b=TkjLo5bhdkldtvFGGYIUn/jX6tUqugKMc6Ic9oa3SZuR8rXfB4bdOQbAydDHw0kmCDO4jBjqBWVhLkCK061sceNs1J6YecNPOuWwZUumfEdh7+UIhZStFVGYPLPq2OMWV8f+ne2MJhK2yFiDCZKJQO0yn0vvYCAbHEpTS0OwbYA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751380540; c=relaxed/simple; bh=Rptf+sv1VX4B/+C2B9gdhZFGhVXXCxTi1EyWHPPzAvo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Uc2Pt3a4LbaX3Pmj3ZHU7MhN7EdLgwv80xefaeNqNFpAv1sDlPgpeKJJpE5k2SfsVZlzH6BfgJZfxR2HZ/QT0oDfFU9aoWhfUfGwp8uF7L9Bjq19I181iOG7qnySRO3wHDublFAB97d8M35ZiWemyBIgokqCOX58lYGQGWBR4Pc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=LlQgoUTw; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="LlQgoUTw" ARC-Seal: i=1; a=rsa-sha256; t=1751380519; cv=none; d=zohomail.com; s=zohoarc; b=KDlfEKqYhWYlN62pN2CZjM/UAZZxUVdrnVa+tEuFkLXfuxWX9+Qn4BJ7a6p2C26tLU4nv7/ynWcwXWEjkX8iMuOBWR8u74rDA7S9sG5gLhMpsrk3Hrbpy3ujjpnugT4WY86CZMK53l8iUatb4BUb7sU78LmZS/Jvpdym0XSJOgU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751380519; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=EYrBsQi1TC80wEIpdSJrvb4LqOzrOeOmKctTnpjzleQ=; b=mxUnC1nVHrjC3yOcbsNRlBZ/2JQdNAVNBJb97tH1PIySNyMuyu/lDQYyTaf2c/tbh61ySSwsx6bu0SBj1b+h6vq14uCHG2UPs4UZE8Gjg8aM6RL/aw+aazgcG1eOdUSodwTxq9Nc3EmlPaw8uHmsodzGu4Oib6hdzEfE97W86WI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1751380519; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=EYrBsQi1TC80wEIpdSJrvb4LqOzrOeOmKctTnpjzleQ=; b=LlQgoUTwP272M41QYJdMtEsqKUtOJtXr3DLow2Sb0oZsKiOazB/QtbdkD9IeyuJ1 lHUakjE3qEDs19TmWK6YYini7J6Jgv1UHg2piNw+OLdW+STKjJ2p1bvfj1niaxI9yBQ MC/aTBXkwqxx1aAyEW5VE8VTU3kKndS1tPW/Hmc8= Received: by mx.zohomail.com with SMTPS id 1751380515131699.1691349237082; Tue, 1 Jul 2025 07:35:15 -0700 (PDT) From: Daniel Almeida Date: Tue, 01 Jul 2025 11:34:40 -0300 Subject: [PATCH v11 2/4] rust: io: mem: add a generic iomem abstraction Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250701-topics-tyr-platform_iomem-v11-2-6cd5d5061151@collabora.com> References: <20250701-topics-tyr-platform_iomem-v11-0-6cd5d5061151@collabora.com> In-Reply-To: <20250701-topics-tyr-platform_iomem-v11-0-6cd5d5061151@collabora.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bjorn Helgaas , Mika Westerberg , Ying Huang , Benno Lossin , Benno Lossin Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Daniel Almeida X-Mailer: b4 0.14.2 X-ZohoMailClient: External Add a generic iomem abstraction to safely read and write ioremapped regions. The reads and writes are done through IoRaw, and are thus checked either at compile-time, if the size of the region is known at that point, or at runtime otherwise. Non-exclusive access to the underlying memory region is made possible to cater to cases where overlapped regions are unavoidable. Signed-off-by: Daniel Almeida Acked-by: Miguel Ojeda --- rust/helpers/io.c | 5 ++ rust/kernel/io.rs | 1 + rust/kernel/io/mem.rs | 147 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 153 insertions(+) diff --git a/rust/helpers/io.c b/rust/helpers/io.c index 404776cf6717c8570c7600a24712ce6e4623d3c6..c475913c69e647b1042e8e7d66b= 9148d892947a1 100644 --- a/rust/helpers/io.c +++ b/rust/helpers/io.c @@ -8,6 +8,11 @@ void __iomem *rust_helper_ioremap(phys_addr_t offset, size= _t size) return ioremap(offset, size); } =20 +void __iomem *rust_helper_ioremap_np(phys_addr_t offset, size_t size) +{ + return ioremap_np(offset, size); +} + void rust_helper_iounmap(void __iomem *addr) { iounmap(addr); diff --git a/rust/kernel/io.rs b/rust/kernel/io.rs index 7b70d5b5477e57d6d0f24bcd26bd8b0071721bc0..b7fc759f8b5d3c3ac6f33f5a66e= 9f619c58b7405 100644 --- a/rust/kernel/io.rs +++ b/rust/kernel/io.rs @@ -7,6 +7,7 @@ use crate::error::{code::EINVAL, Result}; use crate::{bindings, build_assert}; =20 +pub mod mem; pub mod resource; =20 pub use resource::Resource; diff --git a/rust/kernel/io/mem.rs b/rust/kernel/io/mem.rs new file mode 100644 index 0000000000000000000000000000000000000000..16bd2d6752ff720cb791eaff633= adbc1c0964f03 --- /dev/null +++ b/rust/kernel/io/mem.rs @@ -0,0 +1,147 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Generic memory-mapped IO. + +use core::ops::Deref; + +use crate::device::Bound; +use crate::device::Device; +use crate::devres::Devres; +use crate::io; +use crate::io::resource::Region; +use crate::io::resource::Resource; +use crate::io::Io; +use crate::io::IoRaw; +use crate::prelude::*; + +/// An exclusive memory-mapped IO region. +/// +/// # Invariants +/// +/// - [`ExclusiveIoMem`] has exclusive access to the underlying [`IoMem`]. +#[pin_data] +pub struct ExclusiveIoMem { + /// The underlying `IoMem` instance. + iomem: IoMem, + + /// The region abstraction. This represents exclusive access to the + /// range represented by the underlying `iomem`. + /// + /// This field is needed for ownership of the region. + _region: Region, +} + +impl ExclusiveIoMem { + /// Creates a new `ExclusiveIoMem` instance. + pub(crate) fn ioremap(resource: &Resource) -> Result { + let start =3D resource.start(); + let size =3D resource.size(); + let name =3D resource.name(); + + let region =3D resource + .request_region(start, size, name, io::resource::flags::IORESO= URCE_MEM) + .ok_or(EBUSY)?; + + let iomem =3D IoMem::ioremap(resource)?; + + let iomem =3D ExclusiveIoMem { + iomem, + _region: region, + }; + + Ok(iomem) + } + + pub(crate) fn new<'a>( + resource: &Resource, + device: &'a Device, + ) -> Result, Error> + 'a> { + let iomem =3D Self::ioremap(resource)?; + let devres =3D Devres::new(device, iomem); + + Ok(devres) + } +} + +impl Deref for ExclusiveIoMem { + type Target =3D Io; + + fn deref(&self) -> &Self::Target { + &self.iomem + } +} + +/// A generic memory-mapped IO region. +/// +/// Accesses to the underlying region is checked either at compile time, i= f the +/// region's size is known at that point, or at runtime otherwise. +/// +/// # Invariants +/// +/// [`IoMem`] always holds an [`IoRaw`] instance that holds a valid pointe= r to the +/// start of the I/O memory mapped region. +pub struct IoMem { + io: IoRaw, +} + +impl IoMem { + fn ioremap(resource: &Resource) -> Result { + let size =3D resource.size(); + if size =3D=3D 0 { + return Err(EINVAL); + } + + let res_start =3D resource.start(); + + let addr =3D if resource + .flags() + .contains(io::resource::flags::IORESOURCE_MEM_NONPOSTED) + { + // SAFETY: + // - `res_start` and `size` are read from a presumably valid `= struct resource`. + // - `size` is known not to be zero at this point. + unsafe { bindings::ioremap_np(res_start, size as usize) } + } else { + // SAFETY: + // - `res_start` and `size` are read from a presumably valid `= struct resource`. + // - `size` is known not to be zero at this point. + unsafe { bindings::ioremap(res_start, size as usize) } + }; + + if addr.is_null() { + return Err(ENOMEM); + } + + let io =3D IoRaw::new(addr as usize, size as usize)?; + let io =3D IoMem { io }; + + Ok(io) + } + + /// Creates a new `IoMem` instance. + pub(crate) fn new<'a>( + resource: &Resource, + device: &'a Device, + ) -> Result, Error> + 'a> { + let io =3D Self::ioremap(resource)?; + let devres =3D Devres::new(device, io); + + Ok(devres) + } +} + +impl Drop for IoMem { + fn drop(&mut self) { + // SAFETY: Safe as by the invariant of `Io`. + unsafe { bindings::iounmap(self.io.addr() as *mut core::ffi::c_voi= d) } + } +} + +impl Deref for IoMem { + type Target =3D Io; + + fn deref(&self) -> &Self::Target { + // SAFETY: Safe as by the invariant of `IoMem`. + unsafe { Io::from_raw(&self.io) } + } +} --=20 2.50.0 From nobody Wed Oct 8 05:54:43 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3AD227700C; Tue, 1 Jul 2025 14:35:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751380549; cv=pass; b=DyWeykOU/g+Guk27vUCPjmMdFAUJvYhdzzOX5dUJF/9vJh6021R9NiwmV3aV5pTthnE5syuRh1ECOOLSyjz23NWfXyg1lAS00zHgfTakT9kunq3MICWRyUNqMykttdjuU2YNuHVuPgEK8Wavb8xQ5bI8Kt7mEbUIrGG7V6qARwk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751380549; c=relaxed/simple; bh=6iN3yOj7qhjC9r531PX5JclwzLQcfGWp/eWDOaiqZQk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IPopTfPLxAAqkMHeGtKQCIFsqxA8Qv1XlpQECbilAGoCNAsiKG0o0DzU9OtRRTfeNq7AsYM7hMHbmVuW4negcJy2hdYLIrVRB93BFD4Lc0AIGALkya06oUZ1M21Z85JqZnwreP2fUq5VHL6xdzKlQLmThpaQ5K97pvbFgcpbkSE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=MLXZSe5m; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="MLXZSe5m" ARC-Seal: i=1; a=rsa-sha256; t=1751380523; cv=none; d=zohomail.com; s=zohoarc; b=Fz5tSSCepqKgpo04vYKVrtBWEnj2BbkHGNhv9L0mKHxbECCkO2hINRGn0daRsOARkVvZV+GQQf27PMijLq589ilvu1+I8s8uObZWA5YJUA3/M5plH+i0U1+WOqPMqkHPyCuIgKkk+D4wHoJyCHtt2pmu+wtYjtmEfvHCpUesdIc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751380523; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Jc9sdrd75wcC67sLGeH8ZfQI/75mCRckbSptWH4o3m4=; b=TQMQGIf/3DZJI8qTsdxmUcfoFe+6BtgfhQXzTedZ8d0l2zM0OhlpPxc3UoXMz6YhLq09VWBz5o28Utuc1ylZ7aCO2Zm9nGN0YcEQg9nlVVggXudt6baV6rdffCuEJXYD0Pwv5CHPatSLnRQ4/SvwbhGnK6BrYeypPHGQleCBgz4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1751380523; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=Jc9sdrd75wcC67sLGeH8ZfQI/75mCRckbSptWH4o3m4=; b=MLXZSe5m0Wf+P1Qah0AzWyXTam72TxjC/XMjlIS7lBXmBGJxIPrGxKLjd527sVPi ADb2Fmrw3tjzejXU4IrHR7yJxPrwHCyhTSmOAvkCoYcHMMohahtsuAbVME9VFHTTopx QntchWxxZBTKMViXZ6f8CfSdC7dN+Srcw0kHsTQY= Received: by mx.zohomail.com with SMTPS id 1751380521685497.0733471940739; Tue, 1 Jul 2025 07:35:21 -0700 (PDT) From: Daniel Almeida Date: Tue, 01 Jul 2025 11:34:41 -0300 Subject: [PATCH v11 3/4] rust: platform: add resource accessors Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250701-topics-tyr-platform_iomem-v11-3-6cd5d5061151@collabora.com> References: <20250701-topics-tyr-platform_iomem-v11-0-6cd5d5061151@collabora.com> In-Reply-To: <20250701-topics-tyr-platform_iomem-v11-0-6cd5d5061151@collabora.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bjorn Helgaas , Mika Westerberg , Ying Huang , Benno Lossin , Benno Lossin Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Daniel Almeida X-Mailer: b4 0.14.2 X-ZohoMailClient: External A previous patch has exposed the abstractions struct resource. Now make it possible to retrieve resources from platform devices in Rust using either a name or an index. Signed-off-by: Daniel Almeida Acked-by: Miguel Ojeda --- rust/kernel/platform.rs | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs index 86f9d73c64b38ffe067be329a77b2fc04564c7fe..bafd3ccea6d15b7965d1a993dee= f3f58e03b3490 100644 --- a/rust/kernel/platform.rs +++ b/rust/kernel/platform.rs @@ -7,6 +7,7 @@ use crate::{ acpi, bindings, container_of, device, driver, error::{to_result, Result}, + io::Resource, of, prelude::*, str::CStr, @@ -211,6 +212,43 @@ impl Device { fn as_raw(&self) -> *mut bindings::platform_device { self.0.get() } + + /// Returns the resource at `index`, if any. + pub fn resource_by_index(&self, index: u32) -> Option<&Resource> { + // SAFETY: `self.as_raw()` returns a valid pointer to a `struct pl= atform_device`. + let resource =3D unsafe { + bindings::platform_get_resource(self.as_raw(), bindings::IORES= OURCE_MEM, index) + }; + + if resource.is_null() { + return None; + } + + // SAFETY: `resource` is a valid pointer to a `struct resource` as + // returned by `platform_get_resource`. + Some(unsafe { Resource::as_ref(resource) }) + } + + /// Returns the resource with a given `name`, if any. + pub fn resource_by_name(&self, name: &CStr) -> Option<&Resource> { + // SAFETY: `self.as_raw()` returns a valid pointer to a `struct + // platform_device` and `name` points to a valid C string. + let resource =3D unsafe { + bindings::platform_get_resource_byname( + self.as_raw(), + bindings::IORESOURCE_MEM, + name.as_char_ptr(), + ) + }; + + if resource.is_null() { + return None; + } + + // SAFETY: `resource` is a valid pointer to a `struct resource` as + // returned by `platform_get_resource`. + Some(unsafe { Resource::as_ref(resource) }) + } } =20 // SAFETY: `Device` is a transparent wrapper of a type that doesn't depend= on `Device`'s generic --=20 2.50.0 From nobody Wed Oct 8 05:54:43 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE4872727E2; Tue, 1 Jul 2025 14:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751380552; cv=pass; b=Xgnfh0VcMpj8MvnsLdvKEiT7Jn59HCRZTsP/ZJCCOoiy6uuuLw8gEpFwpSGBN4FqtPMs3y+usuvqeb49GnDYBYZRuqgb7IwYz1xfDL5bGmTX6aOLMX7aAATkacIReyEzCFBXh5X6PvXFXfJ06UeyuhjgY4ucMVHrP+0isP7uhjk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751380552; c=relaxed/simple; bh=RFF4HZsCA1/aqivGylnpl/zmYTyzs6/vFUohEaI8E3w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lhf1w/E0hsVUhWrPQN0cPBrh+5i3l6plV9IeneaYF/7vob7oakWuczJWmtgMM8EclLbxWnxi91KjafHi5UqMlYSIq6DG/IfeX+xGC/0shu3Sjx6wubyhZB4D+5Ii6Auct2lssCX0aCgCDSFPE/dLERFdD+OK5xukM9HFg+OhqWU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=e/RlLUV4; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="e/RlLUV4" ARC-Seal: i=1; a=rsa-sha256; t=1751380527; cv=none; d=zohomail.com; s=zohoarc; b=TGVCgLk9mPGH4aRpbk61SIulwbSL077y4suEJkY3JBvVg+64IwA8vNum9OCdOxTw661Dr1TeTcvnFPDLfWq0Z2mOLM8oxySDi+uPOtW9czdOKg5eVHdHrjeE8n7pbypvaG6PEOPD4pRp7uuSS1iU2t6kFefRZDCo/ax+UyrLlAQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751380527; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=9qx2K7ri1vTm3J/raEM49wZb7qlOxaHzPm52ap9Pbqw=; b=OSGrwb2mknssxqiAsYQsxJVwDLjvoRiLjDuKLiue5xtesHFQu2xSNWVrYVC9VN4skLx5M9daUkfPNFaTaj0yAxAJhDPGqGVf77VkVNaPevDLrK37rcCUfp5eqBrejXirArNsF2Uv6L9P3N6UjaFD0ORnde0ANqVfjzokcObwblo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1751380527; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=9qx2K7ri1vTm3J/raEM49wZb7qlOxaHzPm52ap9Pbqw=; b=e/RlLUV4K9sj45DLW2xRIs8SIo7EZ4MRYxReUz/NjbJCBWqCkHX8QCIUfTRvrbS5 NYzj505blrWfIEy1pBD/0dFgGgT8FMnqL6t0Qceq1cDLDN4VzaBDli70WiXNetio7yJ ZWdThDmoeZ9em3fIh8z77+5fSTtbDvwbui/+hca0= Received: by mx.zohomail.com with SMTPS id 1751380526351830.310196252349; Tue, 1 Jul 2025 07:35:26 -0700 (PDT) From: Daniel Almeida Date: Tue, 01 Jul 2025 11:34:42 -0300 Subject: [PATCH v11 4/4] rust: platform: allow ioremap of platform resources Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250701-topics-tyr-platform_iomem-v11-4-6cd5d5061151@collabora.com> References: <20250701-topics-tyr-platform_iomem-v11-0-6cd5d5061151@collabora.com> In-Reply-To: <20250701-topics-tyr-platform_iomem-v11-0-6cd5d5061151@collabora.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bjorn Helgaas , Mika Westerberg , Ying Huang , Benno Lossin , Benno Lossin Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Daniel Almeida X-Mailer: b4 0.14.2 X-ZohoMailClient: External The preceding patches added support for resources, and for a general IoMem abstraction, but thus far there is no way to access said IoMem from drivers, as its creation is unsafe and depends on a resource that must be acquired from some device first. Now, allow the ioremap of platform resources themselves, thereby making the IoMem available to platform drivers. Signed-off-by: Daniel Almeida Acked-by: Miguel Ojeda --- rust/kernel/platform.rs | 127 ++++++++++++++++++++++++++++++++++++++++++++= +++- 1 file changed, 125 insertions(+), 2 deletions(-) diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs index bafd3ccea6d15b7965d1a993deef3f58e03b3490..b2c17fd6ab990c0b5ae6d6ed2e4= 66b199eae2536 100644 --- a/rust/kernel/platform.rs +++ b/rust/kernel/platform.rs @@ -5,9 +5,14 @@ //! C header: [`include/linux/platform_device.h`](srctree/include/linux/pl= atform_device.h) =20 use crate::{ - acpi, bindings, container_of, device, driver, + acpi, bindings, container_of, device, + devres::Devres, + driver, error::{to_result, Result}, - io::Resource, + io::{ + mem::{ExclusiveIoMem, IoMem}, + Resource, + }, of, prelude::*, str::CStr, @@ -251,6 +256,124 @@ pub fn resource_by_name(&self, name: &CStr) -> Option= <&Resource> { } } =20 +impl Device { + /// Maps a platform resource where the size is known at compile time. + /// + /// This uses the + /// [`ioremap()`](https://docs.kernel.org/driver-api/device-io.html#ge= tting-access-to-the-device) + /// C API. + /// + /// # Examples + /// + /// ```no_run + /// # use kernel::{bindings, c_str, platform, of, device::Core}; + /// # struct SampleDriver; + /// + /// impl platform::Driver for SampleDriver { + /// # type IdInfo =3D (); + /// # const OF_ID_TABLE: Option> =3D None; + /// + /// fn probe( + /// pdev: &platform::Device, + /// info: Option<&Self::IdInfo>, + /// ) -> Result>> { + /// let offset =3D 0; // Some offset. + /// + /// // If the size is known at compile time, use [`Self::iomap_r= esource_sized`]. + /// // + /// // No runtime checks will apply when reading and writing. + /// let resource =3D pdev.resource_by_index(0).ok_or(ENODEV)?; + /// let iomem =3D pdev.iomap_resource_sized::<42>(&resource)?; + /// let iomem =3D KBox::pin_init(iomem, GFP_KERNEL)?; + /// + /// let io =3D iomem.access(pdev.as_ref())?; + /// + /// // Read and write a 32-bit value at `offset`. + /// let data =3D io.read32_relaxed(offset); + /// + /// io.write32_relaxed(data, offset); + /// + /// # Ok(KBox::new(SampleDriver, GFP_KERNEL)?.into()) + /// } + /// } + /// ``` + pub fn iomap_resource_sized( + &self, + resource: &Resource, + ) -> Result>, Error> + '_> { + IoMem::new(resource, self.as_ref()) + } + + /// Same as [`Self::iomap_resource_sized`] but with exclusive access t= o the + /// underlying region. + /// + /// This uses the + /// [`ioremap()`](https://docs.kernel.org/driver-api/device-io.html#ge= tting-access-to-the-device) + /// C API. + pub fn iomap_resource_exclusive_sized( + &self, + resource: &Resource, + ) -> Result>, Error> + '_> { + ExclusiveIoMem::new(resource, self.as_ref()) + } + + /// Maps a platform resource through `iomap()`. + /// + /// This uses the + /// [`ioremap()`](https://docs.kernel.org/driver-api/device-io.html#ge= tting-access-to-the-device) + /// C API. + /// + /// # Examples + /// + /// ```no_run + /// # use kernel::{bindings, c_str, platform, of, device::Core}; + /// # struct SampleDriver; + /// + /// impl platform::Driver for SampleDriver { + /// # type IdInfo =3D (); + /// # const OF_ID_TABLE: Option> =3D None; + /// + /// fn probe( + /// pdev: &platform::Device, + /// info: Option<&Self::IdInfo>, + /// ) -> Result>> { + /// let offset =3D 0; // Some offset. + /// + /// // Unlike [`Self::iomap_resource_sized`], here the size of t= he memory region + /// // is not known at compile time, so only the `try_read*` and= `try_write*` + /// // family of functions should be used, leading to runtime ch= ecks on every + /// // access. + /// let resource =3D pdev.resource_by_index(0).ok_or(ENODEV)?; + /// let iomem =3D pdev.iomap_resource(&resource)?; + /// let iomem =3D KBox::pin_init(iomem, GFP_KERNEL)?; + /// + /// let io =3D iomem.access(pdev.as_ref())?; + /// + /// let data =3D io.try_read32_relaxed(offset)?; + /// + /// io.try_write32_relaxed(data, offset)?; + /// + /// # Ok(KBox::new(SampleDriver, GFP_KERNEL)?.into()) + /// } + /// } + /// ``` + pub fn iomap_resource( + &self, + resource: &Resource, + ) -> Result>, Error> + '_> { + self.iomap_resource_sized::<0>(resource) + } + + /// Same as [`Self::iomap_resource`] but with exclusive access to the = underlying + /// region. + pub fn iomap_resource_exclusive( + &self, + resource: &Resource, + ) -> Result>, Error> + '_> { + self.iomap_resource_exclusive_sized::<0>(resource) + } +} + // SAFETY: `Device` is a transparent wrapper of a type that doesn't depend= on `Device`'s generic // argument. kernel::impl_device_context_deref!(unsafe { Device }); --=20 2.50.0