From nobody Wed Oct 8 07:07:13 2025 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D5B0306DC1 for ; Tue, 1 Jul 2025 21:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751405980; cv=none; b=iX/K02Fc5J1jNE9yFv1XJ5ekfzAzqorKERxfaBkVp2KQlhfVqSA/T3ti5u+GJWVcEidVepHQ6BFLpEPrhIMMhYMMx2guoJnryNDCnPhyfEKLuF7vINHiDHcyj7WZgCNYAiknPVS5EpqPQ3HYJbsKqk+AGZMmmvbhBSrGcdQDWno= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751405980; c=relaxed/simple; bh=ri+GV8hDbxQKdegUY+Asy/ciZDUtvEJCgrkaZk0M59E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OIlHLfU7MDD0tVXDNp2XTAWZYOhjp1XaI8TnqsC9UFEXTMVFcT3usDVfNRDY//Opw6PlMBnVpIdECpmY15caF2bZO+BBrGn9bJ1SiSUeiLhPhR+RgIgNplAKAHtyPsjCHBI0bKXet/vI+s6g55FCJvZAapwkL8r9uTjsdsQWf+Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=RIsvOkDF; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="RIsvOkDF" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-40af40aee93so3950239b6e.0 for ; Tue, 01 Jul 2025 14:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1751405977; x=1752010777; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LoGkdeBhqcrBQnH+/S0/qj4I6O0imtl9FrWlFxhByvM=; b=RIsvOkDFlXrUcuBEjwGKjoBkQQnVsS/k5kA549BzP2MQ5grqUYwuJ+UyiR8/W6fl9g RSKQplCnQt1CwhZjAed34sMPAXeGQ05p4Fhv6YX5/SrAUdb57j3CN25DEWNM8Mmb/L5c ikrcRUXJGpy87jH+CgjrK2iMFtdSLu3UJ3zjTXOFXDDDSrPnNGGb4ht+puunLuegsm5A /emZW8kVSGct+l+04MAWuuqdqpvch1FAqSlFCBNxfvx/X2uM4+vE8YscTs7SLWNGMr9P ARIHl+/L2gq4+Km+UC5pg2PP/l8+rdakessOm3cL9N0M9vI3vMkfhPO5Ni7Q84Dy36Fa Qd0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751405977; x=1752010777; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LoGkdeBhqcrBQnH+/S0/qj4I6O0imtl9FrWlFxhByvM=; b=vm/tQWMR0SHaSVQ2hfRNTr812UhoJmrukBa3LalFYsTCkLlyEvB90VqO+RrN8/mNLc aV3Dn0pfXlDa5u+c7xSu8Iv066pm6jqgDvLDSDQQ98zUJLQWt8iQA7HShZyFYuIQ3k8O mLlRq8OFs7JnSjqGuAbfIu4FL26VXeu5qf3GeaBFF+8gExe9o2Ia5PeMv7ssqvbcPULK 4iX9Tg8BbWybJEnp4BDOarKwOtpYiC6//dmO2LlSs+NJO1xa9kfbGpF0G2DUoQFSdxT/ Reo9eBQJ9szTe5U/sUc79qCfQ4oWCzJxC5kui6DADoNZj2oFx6aZSAMd/IkRjyLDETq0 fSlQ== X-Forwarded-Encrypted: i=1; AJvYcCW0+YjXLR3PdD28FLnGJNCT+f+m9hbL9lZDXoxn4LglZURziKzRbvSsskFUSgazPRH8NfnEHJnwPbmsCdw=@vger.kernel.org X-Gm-Message-State: AOJu0YzZsCAarsOGMmMt5wajzMw9/oWI0i5iG6QYRUKW+qghj2BnF76/ I3ku4AqK6yIkJxSumPoBc1z12PAlkOySGBfkezntTonEZjoTpPf1F5mW8WnYWRikfZo= X-Gm-Gg: ASbGncvXk2ShZcIbe4TV856q8aobOfvXnKLZUpAlWkSUW3zv1X+N582uXziXHzjYEKC SKBr6RTtmdroICUojyMTfUpOzvhtezgWe2GTR7D1YwgBWNRa9vaFJuHGovGQIFHg3ekvhwehxeK l01pGY9Lwak0EuxwqyINAe40Hp96xKW93pGAsXYYhZzMlXkmxlKcMcW28EwoicXaZLIWLg2ZcnE RPJF3i9B1q9fCGip6wlYhjeqfBi6+mOT9cH6Hc2gtpZxm8TINbowQxkGh7suBdL8zWI2NfIBxRp 6+nOg7tv0LkmTGurXQizMC5Lc48bBl9oeSeZ0kPDsraHcmHHt+rfqZEZtCDOrg95NZkS X-Google-Smtp-Source: AGHT+IFjLqFCy7sYMcfA64FamIas5nnvC28bvlSgo6+v1bonAVCJqb91DMUaJslqnGnYR+QfEJLqag== X-Received: by 2002:a05:6808:f94:b0:404:ed0d:79e5 with SMTP id 5614622812f47-40b88807fd5mr304514b6e.30.1751405977395; Tue, 01 Jul 2025 14:39:37 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:70a7:ca49:a250:f1d5]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40b3243deeesm2288335b6e.48.2025.07.01.14.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 14:39:37 -0700 (PDT) From: David Lechner Date: Tue, 01 Jul 2025 16:37:55 -0500 Subject: [PATCH v3 07/12] iio: adc: ad_sigma_delta: refactor setting read address Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250701-iio-adc-ad7173-add-spi-offload-support-v3-7-42abb83e3dac@baylibre.com> References: <20250701-iio-adc-ad7173-add-spi-offload-support-v3-0-42abb83e3dac@baylibre.com> In-Reply-To: <20250701-iio-adc-ad7173-add-spi-offload-support-v3-0-42abb83e3dac@baylibre.com> To: Michael Hennerich , Jonathan Cameron , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2048; i=dlechner@baylibre.com; h=from:subject:message-id; bh=ri+GV8hDbxQKdegUY+Asy/ciZDUtvEJCgrkaZk0M59E=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoZFVoUoOvzajg9oS+SsuzrU8BJSDqxyjIjP369 K3N8UaK+ryJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaGRVaAAKCRDCzCAB/wGP wMnWB/0XlKOgOHhV9LDrxXB7kWcQugtbnzivlxQliToetR3VfVAZ8zQY2xL0Fya1YWYJeNWvSlq tA+sSbybKR+V+PJdaHdhTdgR8fPVkECr8SZboyxAA93O+OmsRYWxeBep7i14VDEsDrYENR0dJAy KYirmjlPXKYcOIpTzYBs0ffaVDEuZg83jGvTzKrcrrSiHfAXMdzxGRoK5/6SVXsglL0RInLMmEk Q85Muk94V++iPjj4Js2q3KL14iBmJQhPG7+xw6ErVj8+ZdLvx1w3iexThUrowCCAtH9+yhtAsZ6 L2CKwdmG5bJosTf2GPuH+rjmGXCtNgZWod7V9fIVEXfGtfxv X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Refactor code to set the read address in a separate function. This code is already duplicated twice and we will need to use it a third time in a later commit. Signed-off-by: David Lechner --- drivers/iio/adc/ad_sigma_delta.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_de= lta.c index b5c66a6cc47ec8e36c458fae87309fd30109c0ec..ce549775ac3d68fd11e660b6b99= 3ac661301756a 100644 --- a/drivers/iio/adc/ad_sigma_delta.c +++ b/drivers/iio/adc/ad_sigma_delta.c @@ -107,6 +107,14 @@ int ad_sd_write_reg(struct ad_sigma_delta *sigma_delta= , unsigned int reg, } EXPORT_SYMBOL_NS_GPL(ad_sd_write_reg, "IIO_AD_SIGMA_DELTA"); =20 +static void ad_sd_set_read_reg_addr(struct ad_sigma_delta *sigma_delta, u8= reg, + u8 *data) +{ + data[0] =3D reg << sigma_delta->info->addr_shift; + data[0] |=3D sigma_delta->info->read_mask; + data[0] |=3D sigma_delta->comm; +} + static int ad_sd_read_reg_raw(struct ad_sigma_delta *sigma_delta, unsigned int reg, unsigned int size, u8 *val) { @@ -127,9 +135,7 @@ static int ad_sd_read_reg_raw(struct ad_sigma_delta *si= gma_delta, spi_message_init(&m); =20 if (sigma_delta->info->has_registers) { - data[0] =3D reg << sigma_delta->info->addr_shift; - data[0] |=3D sigma_delta->info->read_mask; - data[0] |=3D sigma_delta->comm; + ad_sd_set_read_reg_addr(sigma_delta, reg, data); spi_message_add_tail(&t[0], &m); } spi_message_add_tail(&t[1], &m); @@ -288,9 +294,7 @@ static int ad_sigma_delta_clear_pending_event(struct ad= _sigma_delta *sigma_delta if (sigma_delta->info->has_registers) { unsigned int data_reg =3D sigma_delta->info->data_reg ?: AD_SD_REG_DATA; =20 - data[0] =3D data_reg << sigma_delta->info->addr_shift; - data[0] |=3D sigma_delta->info->read_mask; - data[0] |=3D sigma_delta->comm; + ad_sd_set_read_reg_addr(sigma_delta, data_reg, data); t[0].tx_buf =3D data; spi_message_add_tail(&t[0], &m); } --=20 2.43.0