From nobody Wed Oct 8 07:01:43 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACE522741DA for ; Tue, 1 Jul 2025 11:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370590; cv=none; b=AcAE7sp1Ty2qAD0EBtGXxG9whQnVxg5tors9x7K663Bu+1BZza3Wj2k6cirkePkigaVjz3CQ3pecWu8v+JAOChvPG0LqBod4waI/wVNOavifbVJgSpI607hsKxXM4njxsFQTQ1MpvCx82EzE3wHN53fMXfiISV8CnXpQTc6OAlw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370590; c=relaxed/simple; bh=hcIDtxH5Hejd56JnbLxX/DThNyqYz5aQPdB6DwPdGeU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TKSVtuiFZpu+KhEDGtRMRL1uCJTqdy6mpPTe9dnmTQSDpjltVU9zdFbuDL67Dd0rpNzJqzsUt/3HN+AjA9JUWLdZ4yXeMH752GZsH1L7uLj5Nr8hTJUf/ItQfBbd2t41PbGOy5EWwQNX9dWOt98W41ujl4MyohPdy8lAZKPQpT8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=JK+hsgvm; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="JK+hsgvm" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-453634d8609so39210435e9.3 for ; Tue, 01 Jul 2025 04:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1751370587; x=1751975387; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fQhO5CK7xr+BRbw716ywq43T0E2MyjcZyeM9R805cuU=; b=JK+hsgvmHGPGMzaGjpURaXHNNqtTVDUXRfyPTC/sAz/RPqkv4MMaTJGkqTCrq9Y4Rr ofKY3EKFXjEyDOnExy3nmM6RwoPZr6z0C2DcThcZhCIBucSaSqx0j8/SyurHwNrPcOBk WGLC5CUInJpwL816VDOpXUwoIjpBIuRvmWnlxq0tB4VPhk4VJP5kNoMUUL9x1YecV31t j/bWQzzzBjGjkQnA8EaFYY0YBwzTT9TAvjoSg53HzhUPPGaFz+bgmR/HwoPWGP+h9xUz 0bCv/FmI3Gqvxawgb99YQ1BLkh7JsUCU6tw1+pk+E4hn0JOYxEdtAnfP2UugjN4lGjb1 IiCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751370587; x=1751975387; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fQhO5CK7xr+BRbw716ywq43T0E2MyjcZyeM9R805cuU=; b=cHlBBWyhidHZLJR2Fd1olUUpOjDGQv0DEp+IRPkvJ9Wu3XIvZDsY8nQ8yf2K523EOU dKQUCeLvXa4xX6mXvvpXfFL69kNyVrknifoSosjn0ttOBkTijCDPsDe32gqHVRhYCVNx 91eE1yM8c5okHp/PgQmm8+cabk6DRF33SiUQQmJv0lkMQtvdaNaO2kSX9yk9HT4LEHZc YKP/G/QENN1cSlpUUDqaBgfxK8NpXRxQla3sx0u2cX0gBLx1BgzSIn+ZxHdyaqhQaMgp OpSk0CR1b2MSEPtUtupCLszD+X6chl3h08nHSwt6gU4G8Bo7YnfowvhMBbyg0qtmeA9+ heYg== X-Forwarded-Encrypted: i=1; AJvYcCWh39fd7x+fMSjF8xlsmK/O6J8BACv4v3r8/OyVDd+KMyqma6TT3khO6ksu5eIz4nzYW1OEj8OD9dMdfyQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzAIQSu9jOerOZx/RLJkLB6MbsmTymJCOaJiZRN9WROJxrq5aLQ Q0my0bzPwoJyWK8n2CNHGmlGYlh3ixsYVuXg37ZM11vJYasQseyqViZ1tjVbfTG0GSo= X-Gm-Gg: ASbGncvazzEA69X/9D916WbUhOzim10+bbytCGV8dLbFKECPXmFTUxAOgr3ujXDpZOX gEGkSVMwC6mcE123J3Aw9XSodavAbExb33hESAOW2utj8OhxYRKzVGWOx31smlOSYpyOJFF0oq+ Me90M6rrpYib0hIE9idBPIibnz824C37pwdr73qvsX7oFz6H+DcGL2AgTX/pvoVNYrJipqNXqGi ALj/LYWgt2FV/s8HHx8bFlWUoM80KmeDP/5Qkap0cFjTfp/bHwIkUOCV7htGEdISBHiuomrP54N zcXPTd6B4zVzy4EK/O2xFtVMv5fT4vCcyjPqzfnmYzJgpbgrKP25Uw== X-Google-Smtp-Source: AGHT+IF5Sg0B8tl+fCojf4YIFaidiXIPVi9KuYAYLaIRKEo99mAjGGdG9ilSXjaOXUtGQt6ATnpQAg== X-Received: by 2002:a05:600c:c4ac:b0:442:d9fc:7de with SMTP id 5b1f17b1804b1-4538ee85615mr149734825e9.22.1751370586972; Tue, 01 Jul 2025 04:49:46 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:a387:7a32:8457:f9b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233c05csm193988925e9.5.2025.07.01.04.49.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 04:49:46 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 01 Jul 2025 13:49:35 +0200 Subject: [PATCH RFT v2 1/6] gpio: mmio: drop the big-endian platform device variant Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250701-gpio-mmio-pdata-v2-1-ebf34d273497@linaro.org> References: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> In-Reply-To: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Lee Jones , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Krzysztof Kozlowski , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, patches@opensource.cirrus.com, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=793; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=EQNCHQeiRFrJidx0AqHxdmYPY25oaY45CVK9LNBnNoo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoY8tW4Xfv3MA0u8w4cDlEXM5V9JxRuYxPfOjsy yLM5bXKzu+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaGPLVgAKCRARpy6gFHHX ctvmEAC99TfqwF/82KeqILREi97Bf5pbCXyaAEUEuay+H27Gu852eYClS5j5nY4cOxII3JXlMiR 5osHJY4CqYj+4f4xJ4/xeWVlxtqzVO4F3mNIwOA2zE/z/dhWhmlX5MIxUuxXdU6yY2ueLhlIDLq R3EDniSnD82XNsSesTrDmou7rOJgvn2AMCozSZPybgMvlc9fO1ZJ+9RNSKo8YN0sgru2Qk3qJCY QhE6Jlkr1z20e6yB4KwKoUwAq/ACWytH9o147f7iHZBurMkuXT6C44n1EEUJycUYEO6AxfYB9vz R+ed6SNGGOQpPw1vECX04T7HjxlwsVmWGrRHkM6kf+Z+llfzbnNhT3fSEErJjxNuzjRF4dfbFGT zpBQ3K2ijN8t44h93x4LYnxZpL7Mccj2HzYJUzfF76bVweV7Dziy3vTBTBdJ1ja60Ih0IeEDtQw E0//k175j2e4FnlrWemRr6HOcypAyh/mlldxn1YxS1D1xgDtVNRhCU0/zeLq86SlHJ05Xqt8+8/ Jed2xmlucx1cpfua2QMuI9iYpNaib5jWx64F1QSZLeksCrl4V1mZ+Fsf7ENy8qR0l3ly0TAZeGH EfCcHNhMYBKD2h6aWd01IUbqRn0dCE+AbOrB9A63Kro32BDbhCLZGMXu/yJf6qmksS43kv7eGaR /2rqW24aN5W8lWA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski There are no more users of the "basic-mmio-gpio-be" platform device ID in the kernel. We can safely drop it. Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mmio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c index 08466e123818e958755fe6e7baf5a4e8b8d863c1..ffe6b6f6cc9b1e9341e1c42cf8f= ee917e0147bf3 100644 --- a/drivers/gpio/gpio-mmio.c +++ b/drivers/gpio/gpio-mmio.c @@ -831,9 +831,6 @@ static const struct platform_device_id bgpio_id_table[]= =3D { { .name =3D "basic-mmio-gpio", .driver_data =3D 0, - }, { - .name =3D "basic-mmio-gpio-be", - .driver_data =3D BGPIOF_BIG_ENDIAN, }, { } }; --=20 2.48.1 From nobody Wed Oct 8 07:01:43 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28F7C274659 for ; Tue, 1 Jul 2025 11:49:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370592; cv=none; b=epz04pyfq2vhTqgeLFjz2ThDNk56wOZsfWojKbTzyLXPV+9e+PGvEcul0sToXUDaiIQehPIx8/Pz8lutfKVYfwfKtDOZsEhIXK6Mf5+iSagFHPI74iST9RkUV1At/LV0ibajgulHRnNvW/8tZHK8p66pjF0iwWFZnsAsDtAcOfM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370592; c=relaxed/simple; bh=/liGg8Z1FTCCY6VxUUiyw/vjJxQXpm//lBqgX9kP3dI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QYWNbF/fupl7xwC+z7nhcYJP7ARev8Vg89pqp+Ys4fIZBV6mCSrXwQsNJzT2c40p6qjg8IOxXm/Sa/upZx4isrGifljiVTB/VwDk7hjRxNbpdPjDV4VX/YXCdRSvA6WdI8urhC/Z/ZdwnMS+k8wJ3Q5JKgr19jQHjoSwxLaE+S0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=FAt+xAG5; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="FAt+xAG5" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3a50fc819f2so4011845f8f.2 for ; Tue, 01 Jul 2025 04:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1751370588; x=1751975388; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gnET98UW3q4Lh5roGHBULYTY/QH8nhGQbEQwpvTzKlQ=; b=FAt+xAG52I+Eb40vF5gUQ9IEb2I0TMRUr7ORsEUTC4j0wZsyE0ki46Ve4fICZ7qraz UsT2GV+B/3Cr7C2NIhUhY5Fs7rrpi4seHAey6dD+j7sOkUxPDJT6xZXByf3a9UHsEdJe YicK5t4C9fIv/hnw5dsWRYi5Pguqmm6JYKuDnGVfbdDkV9/tg24/jZ+jh2/dye0ly/LM rdyVmyxfSW1w2CaUY4xbvjhsZDXNIFe/wHEtwYi1wOYesomk41am7uTJrITH7LUEla7i FY58qamCS0ABA2Iucmt0i3sI11my0Wr+WrVcbv/O5EyE+aralJJVWqh3fmXoLnBGBDMk o8+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751370588; x=1751975388; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gnET98UW3q4Lh5roGHBULYTY/QH8nhGQbEQwpvTzKlQ=; b=dRsZoDafGLqm+/Hyoy1Vo73e5Ga0+mc8oYr75sgDi0B49Flb1r615ixsUHT7xgRMEv 26boKSXWshvHqp8bD1E6X3PTzspGghBYqXefoHmrj5E2UHSODa9bsl2QKP59F4wrVfcJ 1fw+ETpKFnDedegbYScCFHAgJhRJyVgJSLGb24dQ+E5cjsQgSeE8ZpJCz/FdxdDekpmp wcBd2nXwHrDhxj5sLE4HHBg6P2g8ScwM1JaG6iSjJlerklsIMCQfLMOsK0i5H7QB/flG Alubrr4z+ixrCnFlrgK05+/ra62hLF2bZWsKJcLzDOJExOPqUIe9cfE/2SIDLEhytVjb njdA== X-Forwarded-Encrypted: i=1; AJvYcCVgbLbxPjxJUt7Y/FRhqaUwp4ObaTMVV1zFo9rQAMCazKvJ+U0nTzHsW4cFHiTN3+0Z25vcii5cEmOfKB4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm0hPQjhYfqG/EQ52SV++TZDLOPuPC3Himx7dyioIv/OMWeao/ EfWcNZ4CMFYrQpX4DkdX5DWepnKbZr8QsHruSLPnn/KP/cbhZ2oBqQ9sfvw8GEA6mT8= X-Gm-Gg: ASbGncs8tTXZ93nglMIHKv+Ri+q7X+JawczQMX3O83pmy9+5mAf2hOsM8NpSHA43bxN YyfevIw5rUpZxZ15t0YH9qg7SxP5kORcVdjhB898ZBdjImt1VxDghRdLSBr8wXtKPVfVPHO+Iaf xtfNhr12yq8Hfxm2U/XuM7qfF+VKYwFpv2ybm4te3iVITqUKwUTePGTXkJupg7X0tcfegBsI1Wh 1dNCpYIXQezPzWDRgMvUyV0jLyTiWG6W5bUvqS79+0g9vJ7Lc6Jpvz2J9VI8bMyYwWUhODzQtsN NM+Fq1TFFF50DA/6GSzclTSYoUFqvBJhimMf2R/i+4hbZBgqGzRmCg== X-Google-Smtp-Source: AGHT+IGzD4Mf8syZLNv6toYxZEcYHBpzR51yBNAd8gDbc5ThQS0t22Hcfo27kXGUE7z0H6MDx9Amyg== X-Received: by 2002:a05:6000:104e:b0:3a4:f513:7f03 with SMTP id ffacd0b85a97d-3a917bc827cmr12012983f8f.44.1751370588497; Tue, 01 Jul 2025 04:49:48 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:a387:7a32:8457:f9b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233c05csm193988925e9.5.2025.07.01.04.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 04:49:47 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 01 Jul 2025 13:49:36 +0200 Subject: [PATCH RFT v2 2/6] gpio: mmio: get chip label and GPIO base from device properties Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250701-gpio-mmio-pdata-v2-2-ebf34d273497@linaro.org> References: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> In-Reply-To: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Lee Jones , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Krzysztof Kozlowski , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, patches@opensource.cirrus.com, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1825; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=GroFk8Q5FkhtN365brFZHyh2tlzBuOR036y6JYVpJP8=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoY8tXgR8SvDBadENlz3jrMIRT1uq7RXKh2WvYk h5qNXOpDVqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaGPLVwAKCRARpy6gFHHX coMTEADCnHYB6sIGGMnETNsvZvTMFWuIKl4hmd/MJvNwxPLxGSAQMY8Iv5AMkfa5y+vpFI1CCqY ItUhoMYuoZhgWZbuPp2Mp5n0k8rbZuR8xvlNRmRl1okJF5UfkBUZXNU++yE1OnFkKqdIqdjvCLe GjiCZ6d7Rlyj1eAiztikmz0X+a3otxj88gBbJ4Xce8xldqreAt9psxwTt5Csso2Ed7CBifFCkdF jggoFS43tmUKiEgQDX7QrMdUz2ZzWcEnScXzxXCybwChAwBm89CNC8nwDIdpkwv8SVpTXLjoDBI KMUo59dDIDM5JlVQG+hOvEGn0KwXwdOdUdIrxjC4jmOy9P1SZBQDpuQjGQ0KrkgWHodvsobzWsH gDboc9/lF+vhA6cb8JqlW8b7efovKfPdgzryvGHU1fDAuA67fx0uaP1uk03sMdjsfcXU4j1+6Q7 4H5UPNqnJhXS2ZtONHUnMHHoFdOdp4IAIYgS/FnZ5pgZ6uCrwPYP8TizLs+7MfaBP+Nd9x1R97L oOZT8GX4x5AVOWvC0Ja4EZ1AhFD/ohEiCc3qE6lmHkvCWSrbW+5CJ0l34b9FpQ98tneqIecRGmp QaIdfjYq1PniianL9wOyXpiG1asjjQzvnapg1liCMla4LDxUDlrFW7xii6z+3tA1lg5iASR+GqA dHRw54sQZ++x2MA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Ahead of removing struct bgpio_pdata support from the gpio-mmio generic module, let's add support for getting the relevant values from generic device properties. "label" is a semi-standardized property in some GPIO drivers so let's go with it. There's no standard "base" property, so let's use the name "gpio-mmio,base" to tie it to this driver specifically. The number of GPIOs will be retrieved using gpiochip_get_ngpios() so there's no need to look it up in the software node. Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mmio.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c index ffe6b6f6cc9b1e9341e1c42cf8fee917e0147bf3..f66137caa245b14e6e8dbd04324= 3224bc47c9609 100644 --- a/drivers/gpio/gpio-mmio.c +++ b/drivers/gpio/gpio-mmio.c @@ -737,6 +737,9 @@ MODULE_DEVICE_TABLE(of, bgpio_of_match); static struct bgpio_pdata *bgpio_parse_fw(struct device *dev, unsigned lon= g *flags) { struct bgpio_pdata *pdata; + const char *label; + unsigned int base; + int ret; =20 if (!dev_fwnode(dev)) return NULL; @@ -753,6 +756,18 @@ static struct bgpio_pdata *bgpio_parse_fw(struct devic= e *dev, unsigned long *fla if (device_property_read_bool(dev, "no-output")) *flags |=3D BGPIOF_NO_OUTPUT; =20 + ret =3D device_property_read_string(dev, "label", &label); + if (!ret) + pdata->label =3D label; + + /* + * This property *must not* be used in device-tree sources, it's only + * meant to be passed to the driver from board files and MFD core. + */ + ret =3D device_property_read_u32(dev, "gpio-mmio,base", &base); + if (!ret && base <=3D INT_MAX) + pdata->base =3D base; + return pdata; } =20 --=20 2.48.1 From nobody Wed Oct 8 07:01:43 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7830274642 for ; Tue, 1 Jul 2025 11:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370593; cv=none; b=O7oH3xSP5zOPCQZOqI5TtmdQlDDWjoeahaXfoI0ZeA7GBHubA5ScBNeKHmEbLRlJEBjQfS5an2SKMzX6/pn5wSKc92aVnlPtvWuzsVBcTiTAb4u06gpQu4XfSpkAnJxcFawNSUFvSed3Re6T1Zo0YgDE4emYXl8y6mO5vbk2GdU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370593; c=relaxed/simple; bh=xYU5I7Lu+Jn3hhEIVbzF6uUlBzDo+9kqpgQz2+1XBmk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JjEd+yZRFwd7X+aOuaoF5/TGsDCFrrqW1cwJPpeloLB/JJxaQKhpbic+s1ZlUypmXE1ZU7cjfXbsQE9S1K6VdaEpjGrObCfz4mQX7pi/v3wa3hpICBLu7NEgF3xWlEypNMcuAE6+GmrHCQ+EZkWfoJA+JRn1WhXlicVgP0Gw81c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=jy4WzMNb; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="jy4WzMNb" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-451dbe494d6so34168095e9.1 for ; Tue, 01 Jul 2025 04:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1751370590; x=1751975390; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dmlFoe2aym4eeL7Hz5sMKNcWh8dSGY8xkumy4xR8mSk=; b=jy4WzMNbJhNkD4RoTE1xOXU3scI1qSUdUSUWSW2Q++LTXpVWKP1D1ne5JsqbUyOzzq zTMxwU10OH8/s9+YREUo4b9GELH6G488und+roJPhFMoEc94m0/Z+KoA95dEmP0gzqGJ W4sKZ9kqbvlRKBBrJrBZnfGweCyNwxc++P+uRBACPcVgXNm1TJ0pfzATaWnzWsuWs+4O k5LCi1aJCYD1wLd5ZdAMltDuQrCm4IcMekjtJQ0BE7HSdvJd7teuXgdGBC0PTvMiMM6p rNGHZnUIckOAuB08mqaGS+mfARjprVTGtjQFBXVCIJPI0w4AZVmGOskH85lRgGYGkF9o HU2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751370590; x=1751975390; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dmlFoe2aym4eeL7Hz5sMKNcWh8dSGY8xkumy4xR8mSk=; b=qbFNxeD671wH/zWdAKq6aEVjXP5KKe6lxM8SyNEGc275yDxfz/Ol2nWz+7huSHlKzC 9+TVVmAQ+XCDtmGa/pK7akbC/aimd3yuOSBWFN39geNMlGl89YR2UcoEQx+qQKvvpuEb URQUvMCaUiuKa3KqmhrUtF3rEBQ3XpWDgwARYSISihg9+e0DsFmqC6H87MzyPelT+Eqp 7VBamskSnATdNuHonImt1oL8x5syOtc6Qk6k1ubHh6D0kNfeZ3vJkMjvKIBheX2hF+MH EFFkT8mB62SSqx+rU/alHn3eYPEV/mTqb5rH1Oz29oQ4lejXI53TDONFv8QR7I+Yn39Y 9RxA== X-Forwarded-Encrypted: i=1; AJvYcCW48uzIP2YAMIjTuCNyoMYMhhirW06dFnmU6RrwOlkQOGfS42uwIVLCayEt3EmVRYoaqUoLk50nka74RVk=@vger.kernel.org X-Gm-Message-State: AOJu0YzpaLObQTwgfGq+U74hZ/TFDRKWeCa5a1JZUPLMDr0ZbPZi2J1t g+g5z1ClAf9XL1Qv8DQICkoBhLBzNH2KbUe8QkDKhVkGobaWw/9yYt4VStmo9ybs+jw= X-Gm-Gg: ASbGncs1PKKryewLTd1s7xVdorD4bnzq9r7Wi2JMYhJhEawg2xbtcMZh/5yUM/sYrPJ 1ElfSRF4sJ10zNbpCAkKMK70c0hsDTRhobd/qGKbVvlBJRJ27YZddG8gqsVmu0RhdUjzeg1sH3h FxJ/6Jgx5B+0zoxS6PvMyTXxYGyP75cKRG0NZLCiWWA6lJeWo2ScghMOwIoRptxNbRrwKxVh/h1 zrqxeEqsVYNbdY4ILMP0aOCBYJXRsWlzunYR/XkblqVwZVw8YMcyJ+6XuNXoRAZTFhPiIHV57R9 eB6ImR1jZHFqqMyx7lcmoggHwtNnmzL/8ytH0cSC2DApQcuimsG3eQ== X-Google-Smtp-Source: AGHT+IGJrN6PNufVnPsz2OChBPF0nzndAxw1Vgqz8TrakhIeBN1I20xOkzC1J1aLNxuEe6wnZRadWA== X-Received: by 2002:a05:600c:4e01:b0:453:6146:1172 with SMTP id 5b1f17b1804b1-4538ee4f7cfmr193139605e9.3.1751370589775; Tue, 01 Jul 2025 04:49:49 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:a387:7a32:8457:f9b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233c05csm193988925e9.5.2025.07.01.04.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 04:49:49 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 01 Jul 2025 13:49:37 +0200 Subject: [PATCH RFT v2 3/6] mfd: vexpress-sysreg: set-up software nodes for gpio-mmio Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250701-gpio-mmio-pdata-v2-3-ebf34d273497@linaro.org> References: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> In-Reply-To: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Lee Jones , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Krzysztof Kozlowski , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, patches@opensource.cirrus.com, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3488; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=T6LXibepSEWSVZc5pSawHsl5dJjLPLgQMdCiAMb4Z7Q=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoY8tX3EkD2/+Qls/ylxbJqZ8GBp5rTpjE9xcMl GxTjsfzP0OJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaGPLVwAKCRARpy6gFHHX cpCvEADPfHzms9P3YOgQRuuTWhfoI9MXVAtI7MQBLr3MoBA4W0MBMbmvFXzZukdAnQlPygwowCT hKvSLzZzJtfL9kj2p3QlCJcsyrfKpnbFOcCODQ+ktHV9i36LEsZ1jS8SQTyY72JQbe6LYFAnmEQ eEZWT4f1VJbiryBn9b34dsURVsjgVR5A0lgizO/J3R2UyvESZJW1W3jEwCZ5uh3IjHqmCjKUkkh AMbPzmyUxq+jM6Irzj89JmFrg2kd8Au8qW6mp+UKJkVzzyvPdQuzc0PPWe0qvu83zbceJnBlGtx S6oila3incG4pqEoh3dlwnwArCKvEekCZZjiB2+SYsLkZwhYGYUi8n7kNJAYOZQ2swpVLm9Yt7X +39BMZvQTOP45spQWexcRbhFb0n1ehMOY0V5V79jpCE9RSD+Y1zNZZK5c22RNMrXXWIqDB7vQqK qq6k+/vydQKjL/gQSZ3CfGWshMzsNh6UHpLHJIPTo/RPcGmsoMcEZOOR/pCCDdUi6A2pCLU/XOY ojeStlRrT+kGuYekJyqr07U9tueX+1anJ4zBuI2z+By67Fb2ZRbe1pjMadGtU4BbyfVlw9RWUeS 29fMfr/NEqeDo1yqwk1rrWwGJpxNX417UDjiPK7Q90BJOOgGiI4DLH8grbYUAazW61aap7lLE5d 5fKD5bW1I1h8cqw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Replace struct bgpio_pdata - that we plan to remove - with software nodes containing properties encoding the same values thatr can now be parsed by gpio-mmio. Acked-by: Lee Jones Reviewed-by: Liviu Dudau Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski --- drivers/mfd/vexpress-sysreg.c | 46 ++++++++++++++++++++++++++-------------= ---- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c index ef03d6cec9ff6927668d051ca459eb1d8ff7269e..fc2daffc4352cca763cefbf6e17= bdd5242290198 100644 --- a/drivers/mfd/vexpress-sysreg.c +++ b/drivers/mfd/vexpress-sysreg.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include =20 @@ -37,22 +38,34 @@ =20 /* The sysreg block is just a random collection of various functions... */ =20 -static struct bgpio_pdata vexpress_sysreg_sys_led_pdata =3D { - .label =3D "sys_led", - .base =3D -1, - .ngpio =3D 8, +static const struct property_entry vexpress_sysreg_sys_led_props[] =3D { + PROPERTY_ENTRY_STRING("label", "sys_led"), + PROPERTY_ENTRY_U32("ngpios", 8), + { } }; =20 -static struct bgpio_pdata vexpress_sysreg_sys_mci_pdata =3D { - .label =3D "sys_mci", - .base =3D -1, - .ngpio =3D 2, +static const struct software_node vexpress_sysreg_sys_led_swnode =3D { + .properties =3D vexpress_sysreg_sys_led_props, }; =20 -static struct bgpio_pdata vexpress_sysreg_sys_flash_pdata =3D { - .label =3D "sys_flash", - .base =3D -1, - .ngpio =3D 1, +static const struct property_entry vexpress_sysreg_sys_mci_props[] =3D { + PROPERTY_ENTRY_STRING("label", "sys_mci"), + PROPERTY_ENTRY_U32("ngpios", 2), + { } +}; + +static const struct software_node vexpress_sysreg_sys_mci_swnode =3D { + .properties =3D vexpress_sysreg_sys_mci_props, +}; + +static const struct property_entry vexpress_sysreg_sys_flash_props[] =3D { + PROPERTY_ENTRY_STRING("label", "sys_flash"), + PROPERTY_ENTRY_U32("ngpios", 1), + { } +}; + +static const struct software_node vexpress_sysreg_sys_flash_swnode =3D { + .properties =3D vexpress_sysreg_sys_flash_props, }; =20 static struct mfd_cell vexpress_sysreg_cells[] =3D { @@ -61,22 +74,19 @@ static struct mfd_cell vexpress_sysreg_cells[] =3D { .of_compatible =3D "arm,vexpress-sysreg,sys_led", .num_resources =3D 1, .resources =3D &DEFINE_RES_MEM_NAMED(SYS_LED, 0x4, "dat"), - .platform_data =3D &vexpress_sysreg_sys_led_pdata, - .pdata_size =3D sizeof(vexpress_sysreg_sys_led_pdata), + .swnode =3D &vexpress_sysreg_sys_led_swnode, }, { .name =3D "basic-mmio-gpio", .of_compatible =3D "arm,vexpress-sysreg,sys_mci", .num_resources =3D 1, .resources =3D &DEFINE_RES_MEM_NAMED(SYS_MCI, 0x4, "dat"), - .platform_data =3D &vexpress_sysreg_sys_mci_pdata, - .pdata_size =3D sizeof(vexpress_sysreg_sys_mci_pdata), + .swnode =3D &vexpress_sysreg_sys_mci_swnode, }, { .name =3D "basic-mmio-gpio", .of_compatible =3D "arm,vexpress-sysreg,sys_flash", .num_resources =3D 1, .resources =3D &DEFINE_RES_MEM_NAMED(SYS_FLASH, 0x4, "dat"), - .platform_data =3D &vexpress_sysreg_sys_flash_pdata, - .pdata_size =3D sizeof(vexpress_sysreg_sys_flash_pdata), + .swnode =3D &vexpress_sysreg_sys_flash_swnode, }, { .name =3D "vexpress-syscfg", .num_resources =3D 1, --=20 2.48.1 From nobody Wed Oct 8 07:01:43 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA2BC2749E1 for ; Tue, 1 Jul 2025 11:49:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370594; cv=none; b=Lb9/q0UjyJn+XzvR7FwVykXeVVJB9NSjhtmlEMOFo4SaUtOhtHWNlbPzR+xpi3EsmCm4wI7feK4pi8Ec2UW2VaAaNQvMZYhFRyWArFRwhjeKpoCl2jHh2fXRibDzlHBEYQrUu5df4fcJISEHLbpCMHw5vY3gWtQZrEOiR+kVN00= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370594; c=relaxed/simple; bh=m8g10qpaHzBwCwL13B2EwAjy8RqqGFIRTWKPTOvRXes=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EL4+xU4kHRciweQIyDDg6IiUpamdMMi4pCypk+9m+QmmCLAv6MZ+HOB/ntxRh+Yh+9mBjfkcpaOY8wxBtWV9yKjEKUk8Z2SatussyMpa0dY60LDaLRRznYAN20ClvpjKb+m8sjrp2bVK4yfG/+JHgSFOqwbtupu54iRMTZ7Aijk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=P1Jen1zS; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="P1Jen1zS" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-453643020bdso48237985e9.1 for ; Tue, 01 Jul 2025 04:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1751370591; x=1751975391; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=izGYiVRCi02r3mHWqGF4QIu9SBmrk+ZHTmWL1Vrn6tY=; b=P1Jen1zSJJCf+PXCmXE5SI+6QdnIRcwfwKAVIT3l61W2ywABm1vIQYmcBHrtvmbCUt yBEsTAlSTm03SUJuGIbPpvYihWr0e5+G/4wA7sg3qos+CAku3p7qFhHin0YlgTjZZ2tT 33k8bGxtg63GhR0ooTX/ZDpPKYK0auWqBk/vJZ49ondjq+TWBqDZ9ajtBu0Ezar74cHo eDk1xfCmA0p6HWCgDmEbx3+sUGxJx9TPz4GejnrMOfgi5dOQWZ0suUKgPFg8eqAQTDeY xy4v5rVdCRHfmLBwhMEEHOFv+QQWlxw5nRWWTX+lEOTctYfkqz9VzRNBL63VZsiqSBlk bgag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751370591; x=1751975391; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=izGYiVRCi02r3mHWqGF4QIu9SBmrk+ZHTmWL1Vrn6tY=; b=dG9Q+jXYT035F98iPNKbj4jM0XazB8rgN0HYkXjXkfnu9GdhMgG04enfMgZRzmRXKA WPOTGLJdOrNBLAxS734s38XMo3xN/+FJBPMbAHHLKheb+S2ja2grXB9H3XReUyu3pMdC Q4JvGXe8uP0mmRZ3ZxdhKh2lsTTPQvYN3lqFkoAbS120Yz+XUVHtze7AE/hhFSfywTnt ApxuqJ/ZsIOmyPFH36NARon2SRtMoo2BReOk+pL2ZwJHpFGWMc/hvYNjIldvOe1WV8eq rM6f5VXtg11nk3Rv8ZgN/2dCogVC5gfscMapSdq+GJmQ59a2ALJY6yvYft1XeZ3/EsRE i7Ig== X-Forwarded-Encrypted: i=1; AJvYcCWjr3Y8Z0wy4QIqXJkauq5/AkuNdq8+2UTVnthbemqlCXZTOmnnG1L4Sl5H6KPM9Oct9ufY+/xM29MGuPI=@vger.kernel.org X-Gm-Message-State: AOJu0YyX0h/PiVq4/QBjUruXKmT+uLMkHVZgYmhhyZ38Iuyn4k9AJWMz YBS4LyifrS893qxmXcuU99dGdDkzFoGgypzLsIc8EFRnK1kBT6taNmnjpQULxh3whh0= X-Gm-Gg: ASbGncvnl7dVjXl9gvB9hJ0S6IKyF6zeoRpKoESv/wa1PKk3HgjdZq3Q2zYgk4060XN H5jOJD7cP0jo+ND4qu4z0gk3GZP/hL7eZEOMlE3x6/FFcLKD4lxPCkEcDgb/LvvL86CGDM27ncU LXLyKQiUh16g3bF/K/5tepc6jh03SBtUZd/Rn7BODeIEBGu4NQdecYg6DweGj+G6B21zyfEj1HD LbvTQ09ZVwg9M67S6UuKMFG6e3WBu20Bvimay+ppY2Ok88LHfNbrWRr5crQsLMVALOPkqBmTgNB ohLnAvOeS2mhaZ5XgnqZq96V1TdNL6mgP5BX8RUlOlkNWUzujLXCEQ== X-Google-Smtp-Source: AGHT+IFrcmk0/tbiV/1dv+6YlxrA5d22+2IS83WwEoAaJRu/KYB6N6nKzdbcBuOnEP7Enr6/jTeGEg== X-Received: by 2002:a05:600c:1f94:b0:453:c39:d0c2 with SMTP id 5b1f17b1804b1-4538ee8562dmr175036385e9.24.1751370591152; Tue, 01 Jul 2025 04:49:51 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:a387:7a32:8457:f9b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233c05csm193988925e9.5.2025.07.01.04.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 04:49:50 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 01 Jul 2025 13:49:38 +0200 Subject: [PATCH RFT v2 4/6] ARM: omap1: ams-delta: use generic device properties for gpio-mmio Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250701-gpio-mmio-pdata-v2-4-ebf34d273497@linaro.org> References: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> In-Reply-To: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Lee Jones , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Krzysztof Kozlowski , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, patches@opensource.cirrus.com, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3706; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=7iayfgJ1dAZc21AW/gMObpJaTK4Jre7W6uoH3VtFMTk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoY8tXdkaoNLb+tPOwKTmXWO2Kc1HFqnzGAwtoq Y0sJyZVX3yJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaGPLVwAKCRARpy6gFHHX clDND/9BuRpZx3u9XqWNJ7hOLcErccn0sL4gSURj0Br9j+kDJJr46tueiThfMZpkPEwlYT6h3s3 Q47+uYZ8bV9WkhY+59KzB8otEDdNvsMP05xEdnLoD0h8C2l12eu+jAUZv5lI3ueCGW5/fxcXjT0 Iucu9kXJbjwq+EU/+ucAuMzRT9/GqyiP++t6Kvw9A62uldgPVPhgir3m7KMVeSNzVFXfevpsmkB aIHOTAwDDGwDRferwWj/9GQlHB4BuapKCS992iP1tQgbCWhev7bMZdqdDhtYt2iYkZYndrQGdg0 9Dj84j79kyzrWjE+OEDPdw3DVEg20KVvJP6SlRx8RcSpd18sT4U7bSkqkbRMo1si3/oLWgVo+ae VIWNZmQjj5ZHCwvAJcjQDJNIJpnmayRzQc/ealI5muuiAzpWCl+oSjYlLevvI23fJI2dVfxSWva Ut+objfa15+H2NMgDVpPkKOrMUPKsZb24Az4Rn/q7Trmk3lsx9jReF6gpCPjqb04ZDmhMWnBp3B ciR4Ytq03ponzgxA90LttFx9K7+tvdAxup6UD6urmPjpT09F6vEpZTkPzqJN3L4OadivrVR+Xxx DkycKLK4K5DCQhrrN7QOsoiEmCh9WYAgQhDhTMOyDjQ0jWBYddTPm4Z+LvjGqBqHOWzlfGFD5jF Xc13UlKAP1cOiXw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The two latch GPIO devices in ams-delta are registered with struct bgpio_pdata passed as platform_data to the gpio-mmio driver. We want to remove the bgpio_pdata from the kernel and the gpio-mmio driver is now also able to get the relevant values from the software node. Set up device properties and switch to using platform_device_info to register the devices as platform_add_devices() doesn't allow us to pass device properties to the driver model. Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski Acked-by: Janusz Krzysztofik --- arch/arm/mach-omap1/board-ams-delta.c | 42 +++++++++++++++++--------------= ---- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/bo= ard-ams-delta.c index 0daf6c5b5c1cbcfd5bd15203cad119d39aa95f19..16392720296cd224732450c8541= 9c35bbab506f6 100644 --- a/arch/arm/mach-omap1/board-ams-delta.c +++ b/arch/arm/mach-omap1/board-ams-delta.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -175,20 +176,18 @@ static struct resource latch1_resources[] =3D { =20 #define LATCH1_LABEL "latch1" =20 -static struct bgpio_pdata latch1_pdata =3D { - .label =3D LATCH1_LABEL, - .base =3D -1, - .ngpio =3D LATCH1_NGPIO, +static const struct property_entry latch1_gpio_props[] =3D { + PROPERTY_ENTRY_STRING("label", LATCH1_LABEL), + PROPERTY_ENTRY_U32("ngpios", LATCH1_NGPIO), + { } }; =20 -static struct platform_device latch1_gpio_device =3D { +static const struct platform_device_info latch1_gpio_devinfo =3D { .name =3D "basic-mmio-gpio", .id =3D 0, - .resource =3D latch1_resources, - .num_resources =3D ARRAY_SIZE(latch1_resources), - .dev =3D { - .platform_data =3D &latch1_pdata, - }, + .res =3D latch1_resources, + .num_res =3D ARRAY_SIZE(latch1_resources), + .properties =3D latch1_gpio_props, }; =20 #define LATCH1_PIN_LED_CAMERA 0 @@ -213,20 +212,18 @@ static struct resource latch2_resources[] =3D { =20 #define LATCH2_LABEL "latch2" =20 -static struct bgpio_pdata latch2_pdata =3D { - .label =3D LATCH2_LABEL, - .base =3D -1, - .ngpio =3D LATCH2_NGPIO, +static const struct property_entry latch2_gpio_props[] =3D { + PROPERTY_ENTRY_STRING("label", LATCH2_LABEL), + PROPERTY_ENTRY_U32("ngpios", LATCH2_NGPIO), + { } }; =20 -static struct platform_device latch2_gpio_device =3D { +static struct platform_device_info latch2_gpio_devinfo =3D { .name =3D "basic-mmio-gpio", .id =3D 1, - .resource =3D latch2_resources, - .num_resources =3D ARRAY_SIZE(latch2_resources), - .dev =3D { - .platform_data =3D &latch2_pdata, - }, + .res =3D latch2_resources, + .num_res =3D ARRAY_SIZE(latch2_resources), + .properties =3D latch2_gpio_props, }; =20 #define LATCH2_PIN_LCD_VBLEN 0 @@ -542,8 +539,6 @@ static struct gpiod_lookup_table keybrd_pwr_gpio_table = =3D { }; =20 static struct platform_device *ams_delta_devices[] __initdata =3D { - &latch1_gpio_device, - &latch2_gpio_device, &ams_delta_kp_device, &ams_delta_audio_device, &ams_delta_serio_device, @@ -697,6 +692,9 @@ static void __init ams_delta_init(void) omap1_usb_init(&ams_delta_usb_config); platform_add_devices(ams_delta_devices, ARRAY_SIZE(ams_delta_devices)); =20 + platform_device_register_full(&latch1_gpio_devinfo); + platform_device_register_full(&latch2_gpio_devinfo); + /* * As soon as regulator consumers have been registered, assign their * dev_names to consumer supply entries of respective regulators. --=20 2.48.1 From nobody Wed Oct 8 07:01:43 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 696C4274B47 for ; Tue, 1 Jul 2025 11:49:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370596; cv=none; b=Rg+sCtrUIEkgnv/prXV4551doSlEsO3FhYwBTgNtvBzaOq8CXdfuOYojTefBVuyrO2wywDHDLjOD9QBEPat1g2zvtocLrLpZaHI3oPz5h7twIMNhOrE7VMndSTGYQH6dSqHGARA2wQElCSMXk8GgYDRPJ2yWq0yc/3RExIkc7fc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370596; c=relaxed/simple; bh=alxabAift/c7LQirbWabFH/BEgz3gW7F6hGSpjDv4XU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=teLm36EEaectNU3tgls3mLarBQgRMpNeJPFZHi0JO22ikfspR5gSn0rtm7yJV4+2ZZ6G+ZzMNKy005S12At/48ILXXUa4udVagQvLPKENyuCyre96eT7walzrq74UApH2nSMn1goi6zoWZ0kU7mnYOhtrn/or2h2UxK4oBAB3U4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=ZcXxagRq; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="ZcXxagRq" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3a4f72cba73so4215405f8f.1 for ; Tue, 01 Jul 2025 04:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1751370592; x=1751975392; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G5JfVfRdI8YGSmLupnI2yntxXLXiEBq3CMfmRLHEFpg=; b=ZcXxagRq3HyUCyNHv3jx8ty+uFcrCT+wXTM7QL4Yhlv2enqCrD6ZGRuxoHfGq+Uc0S IambCCWkLA48LwEsfwX8i5nGeCh92jgyjsVJ1tNl5/oKnn7oYx/fsEYvi+kiSUT6FfHD /n4543TMaT5t0gczIJD4KUUvxd0dTY4vVuzGmjWMAt0Q7ZbPU15C2GaDVHY4COY3/2Ng 6zz6l5FyzNMP24LLL5hCaKjr0nmPAEXUhzDLOScNUOpBKQ/mfh3Fry40UqshRpb1U5jS btrzWkGgM4+8MxfIs9hbrA1OhaXubvy0ZY1ORAqzBR7V+4gsVZ2AuxC0ZBur0E9oPT7p voUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751370592; x=1751975392; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G5JfVfRdI8YGSmLupnI2yntxXLXiEBq3CMfmRLHEFpg=; b=Z5GE6Z6HG8LXPEyt2quSaNHTxuIeSDUWdNgyOoQAa1hCIbgGa4NizhFe8IikY+J8WC dITBu5/Gz3jADFrovDWHASaEbYRsLslqvAGFZX9QHTTVvqU4vb8Rto6k0sBNEL+y3QPy Quu4KBP/B4PQ3TibJJLSOq3GjdwUK/nVz6CYruB8HMlFFAGgbM7YedFIeZhicp/6Hmx4 X1YkXLwb27R0GEuj2lqAZOQ48H2r81CIoOPNTlbKSaJAi2VZa5gq5uiWCgd0Y/P1gv5o B3ECRtc/ZB6eFLgdgG7LHbi3iR/sB0gh4JjGe8M/dc5ZxXPIt443PFGGqgUFMVh+PyLe ykmg== X-Forwarded-Encrypted: i=1; AJvYcCWvUkbLPGFd2neo4Vy1gxBOngg1cS3zH6/odNav1lizsQ/p+IdjvlVfPjTrIVw8OO+atkRt+C8jPVxlR2g=@vger.kernel.org X-Gm-Message-State: AOJu0YzA0JAECuTeqrwh7nXQtAnEnRSIqVg7mJG5w1ef0LGsVlFQmOlb IL8fgobJ95SKdkfyNLnxgkya1FC9g8MWxTEa4MW0L7etIQC/K4pAuLiShKHAHJMgVZ4= X-Gm-Gg: ASbGncsyJ0Bacg0WBc038cvDzoJK7eAGACOR06pd4m/p2MRjBsM3Mj6BMAIuMvzKZnc +khG3E3y02ichYNCCKpMTSzX2+7eEtd6MGkJKRbjM7WfW0/TroSHqbE/8NkCde62dC/j2skZ4Hc jD4MWgYRcjTLPpeFQ0iJfg1LQlhbdOFVwM+ISF4aMqEbOGDwcg4JPwbMKJynYtDT0zuHLwxuYWX 18oP/XRrqbCwl4AEqQACHaVFfwUhQ0MYOg9pbvoe0+pkzdiJPR9musXn0QtwwOOcr1MpUy2SMbs pyxZrYGKHWRbDBwO0AUQ84fm3hrUVltcrlQ/H6w6aML6FcprHevuSQ== X-Google-Smtp-Source: AGHT+IFBzvAMW8OcUT3OzLMR56Uz0A7DDsGCczyaZLiFWhXpYZeAX5dF84CgrX1TS2+Bnz9657x6Hg== X-Received: by 2002:adf:ea09:0:b0:3a4:e1f5:41f4 with SMTP id ffacd0b85a97d-3af100ae561mr2412822f8f.17.1751370592384; Tue, 01 Jul 2025 04:49:52 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:a387:7a32:8457:f9b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233c05csm193988925e9.5.2025.07.01.04.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 04:49:51 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 01 Jul 2025 13:49:39 +0200 Subject: [PATCH RFT v2 5/6] ARM: s3c: crag6410: use generic device properties for gpio-mmio Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250701-gpio-mmio-pdata-v2-5-ebf34d273497@linaro.org> References: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> In-Reply-To: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Lee Jones , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Krzysztof Kozlowski , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, patches@opensource.cirrus.com, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski , Krzysztof Kozlowski , Charles Keepax X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2505; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Csz4Ip4F3hS2hKgICREYbcOQHfEZUMwUqPJfONVy8Bs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoY8tXJojV9gB1TOh7n6XBghRiq0iDiiZ/ZcyDE +zhzMX8YQ+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaGPLVwAKCRARpy6gFHHX chEzEACFiqLeHegljvLOJZKOgMI/7feOpGsAaU6leda/8EMbLme22btPegktzBE2Tx+25dc1NMk 1S4hZOElYE9kmJ3RtG8k73hIx4aGXWx9V5tc5qPjH1fETRwMw6q0NTbX+htTvKTweNccQTGpXt2 Ck807f72IdwQgp1VpDlA3AHWyFxKZgUufNlt5tUK+5NATO37+QWfJXgiAZzEBJsQMUKCHkngKmh 2kHyGTR++BAIvQS1N7pao8D21fUf94+jN1GIQe3WE+IkV3peFf5mNFm79RMojKtROHYVqQcUufB AEzv2/23aUJJFSx6gMI6x/VQ3/ijH+fdbjeoNvFPS9X8UtcSbxtRRcoCj1tKZHAltD7xTdW/tMX dGz+rgzkuO2dgx3Z8sJ5LGcCybYk7+DJ6Zq4wxcDDhUFr9h9ldwzEyhKt63/KERqZonhAC0Wnx7 yqG/LxvgTcoyedbspNOhAqsMMZ/C0JdFMfogDtwThcQJXSYUvHEak7ftsRbb1iNp+dpXjLjS9E+ +nuZOf4k137Vk5CAStaGKp5Owxe9AL6D8eHIZo31ou5woBlI1BPSx8x7WiOYDtYnnxEVYy98DFw OF70h4BCXWWlZO7X+eMBJc40Q5KhRl4Mf7p6UzLAT5y/4EmcR/WIw7ss5+6NTtIuPJ0vK0ybpJr pp4oITttl0uyP0w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The GPIO device in crag6410 is registered with struct bgpio_pdata passed as platform_data to the gpio-mmio driver. We want to remove the bgpio_pdata from the kernel and the gpio-mmio driver is now also able to get the relevant values from the software node. Set up device properties and switch to using platform_device_info to register the device as platform_add_devices() doesn't allow us to pass device properties to the driver model. Acked-by: Krzysztof Kozlowski Reviewed-by: Linus Walleij Reviewed-by: Charles Keepax Signed-off-by: Bartosz Golaszewski --- arch/arm/mach-s3c/mach-crag6410.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-s3c/mach-crag6410.c b/arch/arm/mach-s3c/mach-cra= g6410.c index e5df2cb51ab27896d9dd80571f421e959db1fd1e..028169c7debf325ab6f51475d35= 95b92b1307189 100644 --- a/arch/arm/mach-s3c/mach-crag6410.c +++ b/arch/arm/mach-s3c/mach-crag6410.c @@ -252,14 +252,17 @@ static struct resource crag6410_mmgpio_resource[] =3D= { [0] =3D DEFINE_RES_MEM_NAMED(S3C64XX_PA_XM0CSN4, 1, "dat"), }; =20 -static struct platform_device crag6410_mmgpio =3D { +static const struct property_entry crag6410_mmgpio_props[] =3D { + PROPERTY_ENTRY_U32("gpio-mmio,base", MMGPIO_GPIO_BASE), + { } +}; + +static struct platform_device_info crag6410_mmgpio_devinfo =3D { .name =3D "basic-mmio-gpio", .id =3D -1, - .resource =3D crag6410_mmgpio_resource, - .num_resources =3D ARRAY_SIZE(crag6410_mmgpio_resource), - .dev.platform_data =3D &(struct bgpio_pdata) { - .base =3D MMGPIO_GPIO_BASE, - }, + .res =3D crag6410_mmgpio_resource, + .num_res =3D ARRAY_SIZE(crag6410_mmgpio_resource), + .properties =3D crag6410_mmgpio_props, }; =20 static struct platform_device speyside_device =3D { @@ -373,7 +376,6 @@ static struct platform_device *crag6410_devices[] __ini= tdata =3D { &crag6410_gpio_keydev, &crag6410_dm9k_device, &s3c64xx_device_spi0, - &crag6410_mmgpio, &crag6410_lcd_powerdev, &crag6410_backlight_device, &speyside_device, @@ -871,6 +873,7 @@ static void __init crag6410_machine_init(void) =20 pwm_add_table(crag6410_pwm_lookup, ARRAY_SIZE(crag6410_pwm_lookup)); platform_add_devices(crag6410_devices, ARRAY_SIZE(crag6410_devices)); + platform_device_register_full(&crag6410_mmgpio_devinfo); =20 gpio_led_register_device(-1, &gpio_leds_pdata); =20 --=20 2.48.1 From nobody Wed Oct 8 07:01:43 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65CA52749E9 for ; Tue, 1 Jul 2025 11:49:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370597; cv=none; b=b0MrdBLH7+IJ49bDqhb++QuDdr8zYbahSMVrsXrbhkmEEFAHurMxqHFax1+qY9oJXPtyCyzSfd66IqKMxu/9+ApeyCaWLIXs+/Ds1A+I4FUEv9Yslb09RD45cWcVYNLLnSO6iCZ9qzHz8PbJVTDJSgmiOM9bfJjXiAY96moBkIw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751370597; c=relaxed/simple; bh=LSvGz4bhsBG69h9nh8mrPUSnRQpI+1agKF+cI4q1FRA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eP8ylqUTSw3ck/uIDcKOqU8eqH/6FZH3a7QDZh8fMT+wZ37Lu7/FjCmn/LOjaIcmAu+i2WoEG5ob/Z6R4mEUvuerlvQiIg6p5xzW9iKz3fTKVr2Qy140kLw4kGDpc6wm0foemBTImSEtb8uvoKN51G0/jInRM+VJ06AcGqGacxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=LUUzwLri; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="LUUzwLri" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-453426170b6so34833215e9.1 for ; Tue, 01 Jul 2025 04:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1751370594; x=1751975394; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=K18eD4fwuNNbiShs9650A8odEfXbIRgpXnl+v+odKRg=; b=LUUzwLrizjpBQ2GsTqAW42xxbB4KjAlgoGXvluhDZCAwi1omvXCegti3Rh/oy+khVz 9/Qj9dd0tXwLy0M1+qIUbPbJ/LY4OsM8TwtlwJdJ7zNTtQRZ/isKqLx10dR/HK4gBmUY 1ARzmZIqtcEsYvLJRZt/wj4GiC+hO4bvWHM/6JmmYSBDJOucSYaQqrMhjNx2DrxBJNB/ d6Q8244Od45ml4Ikpa6BXTTzN54Oz3i86Cvb2tDOIx5OuhwYH75m4iDZ1/6pP7AGzJk4 kHb02TjG/cAYB/w1/6npEp+TpDm6Qk1dLyokOlW24vXzTdhsj8gltIHxyAEM2PfOqeqg lNaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751370594; x=1751975394; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K18eD4fwuNNbiShs9650A8odEfXbIRgpXnl+v+odKRg=; b=Mb6sg/YdxquF+Wn1EfXVnk34Z97dAFfj0l4206NKyLGnkXiXta4oiSxvr88w+rtcoA G2SIJJnG+jha+Oc1C7mK4Tvtf9rR7uNMeMksd+a2SmZMK9eWIvF3uFzd99z65UwW3ZCA Kvuqm7DV4DpNGnmiGnPsJPfp6F+DkY8x2mmn7Q67zKprYP+WjDMdnzrdWnj46biX6gF8 A8KexdCZQ/ZtUcCxv3uABOGa5DWlzzmmi5qdIw5JwO63hLuJyyJ/BD23q9e9V40LlCk+ 9vt+FPRpsqYs0rWXTqQ7773Qdcjc4Qr6TV1byasi3ReD2PJsu3TzSFn/DbbUAA6vS/qm e79g== X-Forwarded-Encrypted: i=1; AJvYcCVzz4DxJQ8goftYBil8t5ww1lRLD0riozPhunpRX58os3CepuMMQ4BV46ojkuw8IVL8WbBy09qbhV3aOtQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyUgfVMNhFEN0GeDAKwKnCvEEPFd8yTo8tpD3hZReFtxRBG4TIm 2pq0OiJw1uEsXF+G4JFxPxoEtirKdMTkqMcvbTga8yshFqnBZKfBsUVi2c4mYDtbZF0= X-Gm-Gg: ASbGncsurTAA7sP8fqgJvrjW+kxh8yRVOxWVVPLD8teS+vLdtvUmFZwEoj0m8o0ifrL mx7JrdkF+hUhb4T5Y3WvsMnLzP6h4fmARDcqCnoW6YSeMER6a1TN/T+E4wH18mJKBov9abwwrtV jQRTKb01yiaE+R8luBYDDu7jdYg3UfpsuI+/HR+2p/S0Sg2LVmaR651cYSiK2j23Yf+V205dKO4 NSR7xWjLTIOCASct1gSR5RxBqI2WC3/ObbROC23TCkSr855eVRGwSr69giT6fykgt9ao2lZFdaB UolNPEfLvB7rRvGz+3S6aZIDKS3xnw6v+bzIW4IiLC/pFaSdGKvJGw== X-Google-Smtp-Source: AGHT+IF1V2h4z8e2b+q/5QYbiJ/3eFoAFYUWiFfRtaEit+V7F7YE8tn3jrKaiEhuVsy1QNVoKx5zRw== X-Received: by 2002:a05:600c:a11c:b0:450:c9e3:91fe with SMTP id 5b1f17b1804b1-4541b6db66dmr14175005e9.0.1751370593607; Tue, 01 Jul 2025 04:49:53 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:a387:7a32:8457:f9b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233c05csm193988925e9.5.2025.07.01.04.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 04:49:53 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 01 Jul 2025 13:49:40 +0200 Subject: [PATCH RFT v2 6/6] gpio: mmio: remove struct bgpio_pdata Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250701-gpio-mmio-pdata-v2-6-ebf34d273497@linaro.org> References: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> In-Reply-To: <20250701-gpio-mmio-pdata-v2-0-ebf34d273497@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Lee Jones , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Krzysztof Kozlowski , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, patches@opensource.cirrus.com, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3955; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=WO0jeIzGeDRWwlltYN6KLDzN1nDqq0wG0YjMIyZ69bE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoY8tYQedunR7lNaIA7I2BJg5XNf3SaooHlaS6n viTggRWov2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaGPLWAAKCRARpy6gFHHX cl8zD/9sO5Jq5Wzq/bFjPjz0TkCxAfA5RvMtEcX04+91lEim8zAy2tLuujFKQ1EZ/j+kEzp/ga8 CLi60fQsJF9gk8a9ecsDKXJrdDGTTemE0ws2iSqALUPjbzY4By3p7V2k0SOO83KHs0ctsOoD+9N j/yo2H5t5ysxHnYdeigLWyqXvu1K99c4tqkDsLtqK5lCwnh6E24Du9S0/AvwBUdG7C4cyqvQvty yrpq7ffBrIkIOQLuaygE/7AsMojI+8/2L/W/Kx8h/9rooyCSTLOloACnjKYQRehYvJ4CiIbit6H OWQWN8RKj4eWlATCcwyl93QshTZQvWA+YWiMnN8qcIcmPEaT+24/tsrUArlctzTBON0qdg97Jqg 8OJ3bhql9HaNoy29uJ58PsUuzo3+x6sOObqKhld8IvZ62gVzsZlV1CHja4VodJFPHAo1Olz4dJI kXEIuPj1pr0ybdNuFDKc2x7IjrwIIO/FQmlWDSFSApeeQaT/8BCnOXU4Pt6RV3FkYiBrGKWl65/ v+k/Hh67+XZqW85RmvNdrYOp1MhRcMxhG8casJMj7bEiqbPOGhhzqyGlr0CmKFeIwbTBgS3u1lI S23NYaez7ty+9cARY3vV9jFOmbzvIBOvMqwwetL+ELUsC4uieXEgDQbHX1rDAIlSFzqmBJR90ZA IVgRnicRfV5w2IA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski With no more users, we can now remove struct bgpio_pdata. Move the relevant bits from bgpio_parse_fw() into bgpio_pdev_probe() while maintaining the logical ordering (get flags before calling bgpio_init()). Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mmio.c | 73 ++++++++++++-----------------------------= ---- include/linux/gpio/driver.h | 6 ---- 2 files changed, 19 insertions(+), 60 deletions(-) diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c index f66137caa245b14e6e8dbd043243224bc47c9609..cf878c2ea6bf1bb6dfbd1040d64= 787687335132a 100644 --- a/drivers/gpio/gpio-mmio.c +++ b/drivers/gpio/gpio-mmio.c @@ -734,43 +734,6 @@ static const struct of_device_id bgpio_of_match[] =3D { }; MODULE_DEVICE_TABLE(of, bgpio_of_match); =20 -static struct bgpio_pdata *bgpio_parse_fw(struct device *dev, unsigned lon= g *flags) -{ - struct bgpio_pdata *pdata; - const char *label; - unsigned int base; - int ret; - - if (!dev_fwnode(dev)) - return NULL; - - pdata =3D devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); - if (!pdata) - return ERR_PTR(-ENOMEM); - - pdata->base =3D -1; - - if (device_is_big_endian(dev)) - *flags |=3D BGPIOF_BIG_ENDIAN_BYTE_ORDER; - - if (device_property_read_bool(dev, "no-output")) - *flags |=3D BGPIOF_NO_OUTPUT; - - ret =3D device_property_read_string(dev, "label", &label); - if (!ret) - pdata->label =3D label; - - /* - * This property *must not* be used in device-tree sources, it's only - * meant to be passed to the driver from board files and MFD core. - */ - ret =3D device_property_read_u32(dev, "gpio-mmio,base", &base); - if (!ret && base <=3D INT_MAX) - pdata->base =3D base; - - return pdata; -} - static int bgpio_pdev_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -782,18 +745,10 @@ static int bgpio_pdev_probe(struct platform_device *p= dev) void __iomem *dirin; unsigned long sz; unsigned long flags =3D 0; + unsigned int base; int err; struct gpio_chip *gc; - struct bgpio_pdata *pdata; - - pdata =3D bgpio_parse_fw(dev, &flags); - if (IS_ERR(pdata)) - return PTR_ERR(pdata); - - if (!pdata) { - pdata =3D dev_get_platdata(dev); - flags =3D pdev->id_entry->driver_data; - } + const char *label; =20 r =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "dat"); if (!r) @@ -825,17 +780,27 @@ static int bgpio_pdev_probe(struct platform_device *p= dev) if (!gc) return -ENOMEM; =20 + if (device_is_big_endian(dev)) + flags |=3D BGPIOF_BIG_ENDIAN_BYTE_ORDER; + + if (device_property_read_bool(dev, "no-output")) + flags |=3D BGPIOF_NO_OUTPUT; + err =3D bgpio_init(gc, dev, sz, dat, set, clr, dirout, dirin, flags); if (err) return err; =20 - if (pdata) { - if (pdata->label) - gc->label =3D pdata->label; - gc->base =3D pdata->base; - if (pdata->ngpio > 0) - gc->ngpio =3D pdata->ngpio; - } + err =3D device_property_read_string(dev, "label", &label); + if (!err) + gc->label =3D label; + + /* + * This property *must not* be used in device-tree sources, it's only + * meant to be passed to the driver from board files and MFD core. + */ + err =3D device_property_read_u32(dev, "gpio-mmio,base", &base); + if (!err && base <=3D INT_MAX) + gc->base =3D base; =20 platform_set_drvdata(pdev, gc); =20 diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index 97cc75623261917e9b3624e1e636d2432c0db205..4b984e8f8fcdbba5c008fc67ff0= 557bda11df40b 100644 --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -718,12 +718,6 @@ const unsigned long *gpiochip_query_valid_mask(const s= truct gpio_chip *gc); /* get driver data */ void *gpiochip_get_data(struct gpio_chip *gc); =20 -struct bgpio_pdata { - const char *label; - int base; - int ngpio; -}; - #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY =20 int gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *gc, --=20 2.48.1