From nobody Wed Oct 8 09:26:49 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 842242036EC; Mon, 30 Jun 2025 10:56:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751280965; cv=none; b=BcFiCLiAwNA2+xlu3HbFewEd3oQ9bqM61fPjyoVnBZX7cUawQC7qpNaBipKGeDbU9JhH7d0AuTcV7guP9YkyMm/7a+iv9LnBU+F8VkLnXC4rC8Jk1AOG+KUavmg3q8NCrME+aAnV6efWQzfb85SXkoUu+oGgKRtjvDx2gyqWEXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751280965; c=relaxed/simple; bh=m1e2jP99pIwoQ8AWABazqche6407sbJa8/waUENtyX0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eD5kE0F8ZmxMf/7w02SfG6iIGQnu5z1CY1xxJwIf6TbzD2hStKfjXg5fm3f4uGaKJ//3Gi2KvZsVRgtD3rxHZRoPVBPeKu1pqkA9hCJqsor93cy6L5j9jqkxyRw3NEAWVVUdWgfGqhq/tobOpSZG0FcfHAQl1HYVBmcy32oWR+E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 12D581F60; Mon, 30 Jun 2025 03:55:47 -0700 (PDT) Received: from oss-apollo7005.oss.cambridge.arm.com (oss-apollo7005.oss.lab.cambridge.arm.com [10.7.15.171]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9E5C23F6A8; Mon, 30 Jun 2025 03:56:01 -0700 (PDT) From: Philip Radford To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, luke.parkin@arm.com, philip.radford@arm.com Subject: [PATCH v2 1/3] firmware: arm_scmi: Add debug decrement counter Date: Mon, 30 Jun 2025 10:55:41 +0000 Message-Id: <20250630105544.531723-2-philip.radford@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250630105544.531723-1-philip.radford@arm.com> References: <20250630105544.531723-1-philip.radford@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Create scmi_dec_count function to decrease any of the Arm SCMI debug counters. There is already an scmi_inc_count function but no decrement function. Reviewed-by: Cristian Marussi Signed-off-by: Philip Radford --- V1->V2 - Amended commit message --- drivers/firmware/arm_scmi/common.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi= /common.h index dab758c5fdea..c6495c4a0e8a 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -314,6 +314,12 @@ static inline void scmi_inc_count(atomic_t *arr, int s= tat) atomic_inc(&arr[stat]); } =20 +static inline void scmi_dec_count(atomic_t *arr, int stat) +{ + if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_COUNTERS)) + atomic_dec(&arr[stat]); +} + enum scmi_bad_msg { MSG_UNEXPECTED =3D -1, MSG_INVALID =3D -2, --=20 2.25.1 From nobody Wed Oct 8 09:26:49 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2DDB425B2F4; Mon, 30 Jun 2025 10:56:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751280967; cv=none; b=T9wNQqOMK7+YFwLxvGgnHw23sdK/bxVAgqwrEXo5tpJpOuRxQ4LK80IeEhIOvzwtp3rbSi0+qYfIRxfVGHfGhUBmZql0e6YqTQRV3dWv3Kwkv9BPqSvbvtQ2PmlDfeHnBtrbROeOGCXrrHAzncW1C+28bYmFPViY60LR46CPxyU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751280967; c=relaxed/simple; bh=UDtO93Ewr9G4bfy7ZqLigw2eIdqG7Zr/5Eq1eSR2TFQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FB78ZYzyYsxv4um3GYiQGODF+/xu3FBkwOBF1rgIksmsV79apuffLQ+WGY479SPyutUC0+IgXC9zPSobAQwvOEXXeU8LMnJxr+XD6Oy0vH9M5Ii3/uVFvgM6XoGuO0KkNIVzMGKL0nBM0d1AmWNZC5EUE+g2sAlo0dX635eR6a0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9B6C31FCD; Mon, 30 Jun 2025 03:55:49 -0700 (PDT) Received: from oss-apollo7005.oss.cambridge.arm.com (oss-apollo7005.oss.lab.cambridge.arm.com [10.7.15.171]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 320183F6A8; Mon, 30 Jun 2025 03:56:04 -0700 (PDT) From: Philip Radford To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, luke.parkin@arm.com, philip.radford@arm.com Subject: [PATCH v2 2/3] firmware: arm_scmi: Add xfer_inflight counter Date: Mon, 30 Jun 2025 10:55:42 +0000 Message-Id: <20250630105544.531723-3-philip.radford@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250630105544.531723-1-philip.radford@arm.com> References: <20250630105544.531723-1-philip.radford@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a counter to the debug_counters struct to record the current number of outstanding inflight xfers. Reviewed-by: Cristian Marussi Signed-off-by: Philip Radford --- V1->V2 - Amended commit message --- drivers/firmware/arm_scmi/common.h | 1 + drivers/firmware/arm_scmi/driver.c | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi= /common.h index c6495c4a0e8a..ad9232c982ce 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -305,6 +305,7 @@ enum debug_counters { ERR_MSG_INVALID, ERR_MSG_NOMEM, ERR_PROTOCOL, + XFERS_INFLIGHT, SCMI_DEBUG_COUNTERS_LAST }; =20 diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index 2699c8efef0a..46f15c5b4998 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -190,6 +190,7 @@ struct scmi_info { }; =20 #define handle_to_scmi_info(h) container_of(h, struct scmi_info, handle) +#define tx_minfo_to_scmi_info(h) container_of(h, struct scmi_info, tx_minf= o) #define bus_nb_to_scmi_info(nb) container_of(nb, struct scmi_info, bus_nb) #define req_nb_to_scmi_info(nb) container_of(nb, struct scmi_info, dev_req= _nb) =20 @@ -603,9 +604,14 @@ static inline void scmi_xfer_inflight_register_unlocked(struct scmi_xfer *xfer, struct scmi_xfers_info *minfo) { + /* In this context minfo will be tx_minfo due to the xfer pending */ + struct scmi_info *info =3D tx_minfo_to_scmi_info(minfo); + /* Set in-flight */ set_bit(xfer->hdr.seq, minfo->xfer_alloc_table); hash_add(minfo->pending_xfers, &xfer->node, xfer->hdr.seq); + scmi_inc_count(info->dbg->counters, XFERS_INFLIGHT); + xfer->pending =3D true; } =20 @@ -807,9 +813,13 @@ __scmi_xfer_put(struct scmi_xfers_info *minfo, struct = scmi_xfer *xfer) spin_lock_irqsave(&minfo->xfer_lock, flags); if (refcount_dec_and_test(&xfer->users)) { if (xfer->pending) { + struct scmi_info *info =3D tx_minfo_to_scmi_info(minfo); + scmi_xfer_token_clear(minfo, xfer); hash_del(&xfer->node); xfer->pending =3D false; + + scmi_dec_count(info->dbg->counters, XFERS_INFLIGHT); } hlist_add_head(&xfer->node, &minfo->free_xfers); } @@ -2909,6 +2919,7 @@ static const char * const dbg_counter_strs[] =3D { "err_msg_invalid", "err_msg_nomem", "err_protocol", + "xfers_inflight", }; =20 static ssize_t reset_all_on_write(struct file *filp, const char __user *bu= f, --=20 2.25.1 From nobody Wed Oct 8 09:26:49 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6BC2F25B695; Mon, 30 Jun 2025 10:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751280969; cv=none; b=MFCH7KjXIwbzd3SF4zrJR14/7wB4gtNifvNorhYmOF7pm93BiTR5/HWDOYaroF5j1UEUKoJTk/6Kwoweoq0LDUpunOK69lQzKRWTtyabqOWG+B5koxiQysIvyfjhh6AmDkXrCSeuQ2TYICH2oN9TAWnc5pMDwSkfGFqtgeh5sKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751280969; c=relaxed/simple; bh=b/z1sgPkbfBEOcl+PMjYucX5yrkhTA/5nnK+l9aYq+E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FSMITUgwxTWXsusbqIw8sO/aoVdrCTIdHhQ/HCFdPton5v3nYYCYGGdkm+gkXS/qtTLu2RWrljH+rCg1WrtfXvvf80ZJ10yfZ3P+VQyIjBIBLBlBUapssDeIXgUb2ZH4JqHBw9k8xBWYnb1JI8guvP0k5XqjmYU7gVsPQ/GdAVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EDA741D34; Mon, 30 Jun 2025 03:55:51 -0700 (PDT) Received: from oss-apollo7005.oss.cambridge.arm.com (oss-apollo7005.oss.lab.cambridge.arm.com [10.7.15.171]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 84D6F3F6A8; Mon, 30 Jun 2025 03:56:06 -0700 (PDT) From: Philip Radford To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, luke.parkin@arm.com, philip.radford@arm.com Subject: [PATCH v2 3/3] include: trace: Add inflight_xfer counter tracepoint Date: Mon, 30 Jun 2025 10:55:43 +0000 Message-Id: <20250630105544.531723-4-philip.radford@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250630105544.531723-1-philip.radford@arm.com> References: <20250630105544.531723-1-philip.radford@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add tracepoint for inflight_xfers and patch all related callsites. firmware: arm_scmi: Add new inflight tracing functionality Add scmi_inflight_count function to fetch the current xfer inflight count to use in trace. Reviewed-by: Cristian Marussi Signed-off-by: Philip Radford --- V1->V2 - Squashed final commit adding functionality into this commit - Cleaned up erroneous blank space --- drivers/firmware/arm_scmi/common.h | 1 + drivers/firmware/arm_scmi/driver.c | 17 +++++++++++++++-- drivers/firmware/arm_scmi/raw_mode.c | 6 ++++-- include/trace/events/scmi.h | 24 ++++++++++++++---------- 4 files changed, 34 insertions(+), 14 deletions(-) diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi= /common.h index ad9232c982ce..07b9e629276d 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -505,4 +505,5 @@ static struct platform_driver __drv =3D { \ void scmi_notification_instance_data_set(const struct scmi_handle *handle, void *priv); void *scmi_notification_instance_data_get(const struct scmi_handle *handle= ); +int scmi_inflight_count(const struct scmi_handle *handle); #endif /* _SCMI_COMMON_H */ diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index 46f15c5b4998..ccc70f10408f 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1440,7 +1440,8 @@ static int do_xfer(const struct scmi_protocol_handle = *ph, =20 trace_scmi_xfer_begin(xfer->transfer_id, xfer->hdr.id, xfer->hdr.protocol_id, xfer->hdr.seq, - xfer->hdr.poll_completion); + xfer->hdr.poll_completion, + scmi_inflight_count(&info->handle)); =20 /* Clear any stale status */ xfer->hdr.status =3D SCMI_SUCCESS; @@ -1476,7 +1477,8 @@ static int do_xfer(const struct scmi_protocol_handle = *ph, info->desc->ops->mark_txdone(cinfo, ret, xfer); =20 trace_scmi_xfer_end(xfer->transfer_id, xfer->hdr.id, - xfer->hdr.protocol_id, xfer->hdr.seq, ret); + xfer->hdr.protocol_id, xfer->hdr.seq, ret, + scmi_inflight_count(&info->handle)); =20 return ret; } @@ -3413,6 +3415,17 @@ static struct dentry *scmi_debugfs_init(void) return d; } =20 +int scmi_inflight_count(const struct scmi_handle *handle) +{ + if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_COUNTERS)) { + struct scmi_info *info =3D handle_to_scmi_info(handle); + + return atomic_read(&info->dbg->counters[XFERS_INFLIGHT]); + } else { + return 0; + } +} + static int __init scmi_driver_init(void) { scmi_quirks_initialize(); diff --git a/drivers/firmware/arm_scmi/raw_mode.c b/drivers/firmware/arm_sc= mi/raw_mode.c index 3d543b1d8947..73db5492ab44 100644 --- a/drivers/firmware/arm_scmi/raw_mode.c +++ b/drivers/firmware/arm_scmi/raw_mode.c @@ -475,7 +475,8 @@ static void scmi_xfer_raw_worker(struct work_struct *wo= rk) raw->desc->ops->mark_txdone(rw->cinfo, ret, xfer); =20 trace_scmi_xfer_end(xfer->transfer_id, xfer->hdr.id, - xfer->hdr.protocol_id, xfer->hdr.seq, ret); + xfer->hdr.protocol_id, xfer->hdr.seq, + ret, scmi_inflight_count(raw->handle)); =20 /* Wait also for an async delayed response if needed */ if (!ret && xfer->async_done) { @@ -642,7 +643,8 @@ static int scmi_do_xfer_raw_start(struct scmi_raw_mode_= info *raw, =20 trace_scmi_xfer_begin(xfer->transfer_id, xfer->hdr.id, xfer->hdr.protocol_id, xfer->hdr.seq, - xfer->hdr.poll_completion); + xfer->hdr.poll_completion, + scmi_inflight_count(raw->handle)); =20 ret =3D raw->desc->ops->send_message(rw->cinfo, xfer); if (ret) { diff --git a/include/trace/events/scmi.h b/include/trace/events/scmi.h index 127300481123..703b7bb68e44 100644 --- a/include/trace/events/scmi.h +++ b/include/trace/events/scmi.h @@ -36,8 +36,8 @@ TRACE_EVENT(scmi_fc_call, =20 TRACE_EVENT(scmi_xfer_begin, TP_PROTO(int transfer_id, u8 msg_id, u8 protocol_id, u16 seq, - bool poll), - TP_ARGS(transfer_id, msg_id, protocol_id, seq, poll), + bool poll, int inflight), + TP_ARGS(transfer_id, msg_id, protocol_id, seq, poll, inflight), =20 TP_STRUCT__entry( __field(int, transfer_id) @@ -45,6 +45,7 @@ TRACE_EVENT(scmi_xfer_begin, __field(u8, protocol_id) __field(u16, seq) __field(bool, poll) + __field(int, inflight) ), =20 TP_fast_assign( @@ -53,11 +54,12 @@ TRACE_EVENT(scmi_xfer_begin, __entry->protocol_id =3D protocol_id; __entry->seq =3D seq; __entry->poll =3D poll; + __entry->inflight =3D inflight; ), =20 - TP_printk("pt=3D%02X msg_id=3D%02X seq=3D%04X transfer_id=3D%X poll=3D%u", - __entry->protocol_id, __entry->msg_id, __entry->seq, - __entry->transfer_id, __entry->poll) + TP_printk("pt=3D%02X msg_id=3D%02X seq=3D%04X transfer_id=3D%X poll=3D%u = inflight=3D%d", + __entry->protocol_id, __entry->msg_id, __entry->seq, + __entry->transfer_id, __entry->poll, __entry->inflight) ); =20 TRACE_EVENT(scmi_xfer_response_wait, @@ -90,8 +92,8 @@ TRACE_EVENT(scmi_xfer_response_wait, =20 TRACE_EVENT(scmi_xfer_end, TP_PROTO(int transfer_id, u8 msg_id, u8 protocol_id, u16 seq, - int status), - TP_ARGS(transfer_id, msg_id, protocol_id, seq, status), + int status, int inflight), + TP_ARGS(transfer_id, msg_id, protocol_id, seq, status, inflight), =20 TP_STRUCT__entry( __field(int, transfer_id) @@ -99,6 +101,7 @@ TRACE_EVENT(scmi_xfer_end, __field(u8, protocol_id) __field(u16, seq) __field(int, status) + __field(int, inflight) ), =20 TP_fast_assign( @@ -107,11 +110,12 @@ TRACE_EVENT(scmi_xfer_end, __entry->protocol_id =3D protocol_id; __entry->seq =3D seq; __entry->status =3D status; + __entry->inflight =3D inflight; ), =20 - TP_printk("pt=3D%02X msg_id=3D%02X seq=3D%04X transfer_id=3D%X s=3D%d", - __entry->protocol_id, __entry->msg_id, __entry->seq, - __entry->transfer_id, __entry->status) + TP_printk("pt=3D%02X msg_id=3D%02X seq=3D%04X transfer_id=3D%X s=3D%d inf= light=3D%d", + __entry->protocol_id, __entry->msg_id, __entry->seq, + __entry->transfer_id, __entry->status, __entry->inflight) ); =20 TRACE_EVENT(scmi_rx_done, --=20 2.25.1