From nobody Wed Oct 8 08:14:51 2025 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD4002BD5B5; Mon, 30 Jun 2025 17:31:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751304715; cv=none; b=AQd7Ft12TJZUhDOioL95G4AK8e7rt/E4We+HHC/122/QJU+XyAIFgcHywP54SHr6vIQNnZBY42cDGSYd3Zu9c/m3PigWvjfJvOyqoDn9WkwpWPDGqw+lvAiG2vIO9aDB0GIgXsHBNFzfq7rlfvJTPQaZSUyWWEb5+un5Z+jMDYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751304715; c=relaxed/simple; bh=bFQBqEheyr4aZ/KTyxhArKPVeEF2ZZO9d/HFxecTvJU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qL/H2+/XOjSOKlw1SLj8RSqL4mNHbo/3OxZeb3PkXPHJdCwZozibgS4tNvrmpe2YdcSlV4KLuKatmpvoEAKv4JVqs2br6JflwHIxAoYj2E0+98hgpMgPL39AIik3xbbCWoEM6RaHElzZBeYL4SX/6hL7lLHObQIGTp8krrWbtgg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mcwGfWZy; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mcwGfWZy" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4a42cb03673so60287041cf.3; Mon, 30 Jun 2025 10:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751304712; x=1751909512; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NVDqontjbqJDFX5cMzxu9XEm9l6XNXc31daQxLrNgwM=; b=mcwGfWZyPYWQGlf62baJ8yxa5cRT6Q2vMOvxN2UhwziCNBu7X09TbjAV2Sbv4V+9Au zG/8wudKNOvF+O8GtzUJWbkeA+hyZacRWJpklfk6kGpOY5gBNAC+eh1uIEzcE7SbzG0M NNn8LLuV1ZSptCuDtBwRHajHrZnbVf6RI2hE+scKjolY9X/72jyMgRLgP4eMjrSHWz6j zbpgY0upkX/GeqrCT3vAQMLpkChWMhOYIqS1Ij3arUpx2o8hmjjCm0YE19yDQQJ3zjwV HjuvfVObWf6iXyIA0QQ2aNw7tUB504AdzPhB6SUSiQWyNGfoifKmtq2QUo/dlaYc6Mih 4R2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751304712; x=1751909512; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NVDqontjbqJDFX5cMzxu9XEm9l6XNXc31daQxLrNgwM=; b=VKb+zYArhmxMOY6HjvSEAZ6GPCePQTkDaB4igtZRcIYJABsi/34AfeDtdSXzdUbVPU 6PH4s3AM+OiIADW7Pf88eH+K5/jbqHldXwR/681GlRXVSrEgpWLiZ6Yw/Goi5w9xnpfg 79pJIcBHYHPdANlSSTNNhqVUoOvKX/uREPYttE2sIJC3i6H6eK5Ph2AL/Tew2kfGUHTo r3xm+aepSKXuNOUcj8x3bdAmaiSruIFgoMzh+kh0zjTvRqYmlCC8jMKwHyT+ECBmVtJf Q6HaGPjUgmkcMWNyLFvXh8l5WMr9YPjfSNhtBFsw84fmYA7PpoNCx+qXSa/O8ugIIivB EiAQ== X-Forwarded-Encrypted: i=1; AJvYcCVOSazpPrMoeLVUFJ9lWIs9XIY8fXeuW0+c4Vj/Eu6Coomty2rTNt815Qpdrg2s4kPRw/UQdk8V@vger.kernel.org, AJvYcCWx7SleLbVvjNhu4MJtFluO4s1/sMSB6BYbOfg2Q+B703cMf3lQQneBqxRDmdtprX86r4IdYR8S9vJkRHk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/xk/r2KTcPEXc3eKfzh7bliyUo3tLjzRveQ9fz0k4xFmi95rA DAQ380TQ/2SVxWI19bBmhz6R03Z81VEzIllxJIcuKyI7oGHIz2WHGV6dyx5RoZLg X-Gm-Gg: ASbGncsUljWmHl/Pw27nhuYPCqf01d8rVbd+tHTovmmoHUK6u5LGlcLgltOrD8jEexq rtIU8Ew4JlrRMM0IbrMywtg9LSiFTkMEUNAmeAQdnJ76PEwoZgFN+U6SsVryNXFomYq4xIFpMiY Q4YqGBFsxh3gKpvW0a/hvuKu+kZ9N7A+n1GI8L8NuoZK7pNpz7WHXCiUdpmAmp1rskF1fU6GpAr LYfmCxBlX7JiLt5KXf3X9uT9VNdZDXXtLGWssXywd8lvs8kbIV37RMzhVMRP2G4k/b20C3qR3bu +EImddt0nrOF5wxQVTac/Zx8CgQ4k/i7/0FELnfkrFJfsBpIRII2Xy9vh9+k1w== X-Google-Smtp-Source: AGHT+IGohO+H1t4zEd+J84aW1WC+S9/4R0DzCq15gbMSgdFlZnJf2TpTggm6I4gXLMGtxWQ5u4W/tA== X-Received: by 2002:a05:622a:248:b0:48d:8053:d8ee with SMTP id d75a77b69052e-4a7fcde94a5mr192338081cf.36.1751304712278; Mon, 30 Jun 2025 10:31:52 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a7fdadb11bsm59784521cf.17.2025.06.30.10.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 10:31:51 -0700 (PDT) From: Kurt Borja Date: Mon, 30 Jun 2025 14:31:19 -0300 Subject: [PATCH v3 1/3] platform/x86: think-lmi: Create ksets consecutively Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250630-lmi-fix-v3-1-ce4f81c9c481@gmail.com> References: <20250630-lmi-fix-v3-0-ce4f81c9c481@gmail.com> In-Reply-To: <20250630-lmi-fix-v3-0-ce4f81c9c481@gmail.com> To: Mark Pearson , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Hans de Goede Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Kurt Borja , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1690; i=kuurtb@gmail.com; h=from:subject:message-id; bh=bFQBqEheyr4aZ/KTyxhArKPVeEF2ZZO9d/HFxecTvJU=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBlJp5hFXdPeXzhey1QitYQp0ZtZXHaRzj4VuYKIcsX2T 6vZxXZ2lLIwiHExyIopsrQnLPr2KCrvrd+B0Pswc1iZQIYwcHEKwET4JBkZOqa8XnQ58KGMXGxl +KubogLLjB3iq0/YyhiIiK2Jt31VzPC/JjErZPHvW8+aF56smtbTyhW86GJH199IP3GVzVzfolI 5AQ== X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Avoid entering tlmi_release_attr() in error paths if both ksets are not yet created. This is accomplished by initializing them side by side. Cc: stable@vger.kernel.org Reviewed-by: Mark Pearson Reviewed-by: Ilpo J=C3=A4rvinen Signed-off-by: Kurt Borja --- drivers/platform/x86/think-lmi.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-= lmi.c index 00b1e7c79a3d1e95621701530ea5e11015414498..4c10a26e7e5e3471f286136d671= 606acf68b401e 100644 --- a/drivers/platform/x86/think-lmi.c +++ b/drivers/platform/x86/think-lmi.c @@ -1455,6 +1455,14 @@ static int tlmi_sysfs_init(void) goto fail_device_created; } =20 + tlmi_priv.authentication_kset =3D kset_create_and_add("authentication", N= ULL, + &tlmi_priv.class_dev->kobj); + if (!tlmi_priv.authentication_kset) { + kset_unregister(tlmi_priv.attribute_kset); + ret =3D -ENOMEM; + goto fail_device_created; + } + for (i =3D 0; i < TLMI_SETTINGS_COUNT; i++) { /* Check if index is a valid setting - skip if it isn't */ if (!tlmi_priv.setting[i]) @@ -1496,12 +1504,6 @@ static int tlmi_sysfs_init(void) } =20 /* Create authentication entries */ - tlmi_priv.authentication_kset =3D kset_create_and_add("authentication", N= ULL, - &tlmi_priv.class_dev->kobj); - if (!tlmi_priv.authentication_kset) { - ret =3D -ENOMEM; - goto fail_create_attr; - } tlmi_priv.pwd_admin->kobj.kset =3D tlmi_priv.authentication_kset; ret =3D kobject_add(&tlmi_priv.pwd_admin->kobj, NULL, "%s", "Admin"); if (ret) --=20 2.50.0 From nobody Wed Oct 8 08:14:51 2025 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 531142E54D9; Mon, 30 Jun 2025 17:31:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751304720; cv=none; b=Z6X1XYKf5/nwVdKgXniT6pv9kEc0Pw8s07VaMtGrSSJP9HmiZRL1jMQN9CCzkGxmBGyalgkrPLmqpqrEVRpGmN/eQm2Kb2WPYZf8Q/XtaQetu23lYAjI85vj6xFPBXoBis0wIQjtMUYIRYg51X6CyaukyTsZRCHbsiker+Ra5HE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751304720; c=relaxed/simple; bh=WhrQT0XcjA48So7VV8f3CLepQJj/6oaWUaubJg1pcSI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jQBAY+oFs0ukpkQMRcp0qMECQM2Y9z29l0gQlh3tdwZojKaEAGSlLQuwqhGwgKTtFymqG1Z4aw+UDqLBUootxLuqNx7bONybUgjKBdHGX3ZYWnEm+ebC+UhClDtuk7qo7QBm06Qa0KCE4vYRbKBEzpyqmBa6UY7Zt90yzUVudX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ncVYymp4; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ncVYymp4" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4a745fc9bafso67137091cf.1; Mon, 30 Jun 2025 10:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751304715; x=1751909515; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FWYXpI/1WvU7LThqEa5N6KoGudK8x9uuTgmTBk7pvaA=; b=ncVYymp4wXA/n8XdK4wwNrvzGpuhBqcKFkz4mQSrvk1/95cW2Ovn2JsFpZiiC3sx6O 0KFGVKJoKclt1bfyl5nY6+Fknmf9jjrVaA9zUUefeKn5Wc/PqZ3/e/RCyGhsgNoM1E7o zXRlOqUeaY+JlKVveuoVyqxdBLSQqqJuyQ6VzLZF32tB8HPerROCzfA3A3jXru3q9eqj fQAZip++ZOoG+T1GUK7tSe8cqVB7ODjbGD9xP3ccBv5prZhcBSoZpNdVGScSxQEb6BtB TLFCerd+36OAB6iRlfadvTKcE5etc6IV7zAWZ9X4HzgIlqqcywsm7rbQa8rWEQIzmilN 3oUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751304715; x=1751909515; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FWYXpI/1WvU7LThqEa5N6KoGudK8x9uuTgmTBk7pvaA=; b=jRPxkXgLmOmBKRW/1zL0XtHK6D5rJIs/PXs/WeaOz9RxP110Yf7wz3mj5VvsBl1Y/y blz4B0d8yrCsVHiZAVY9FwflcjS7fOYT0eb3MQOv8qbdi+EhwxbCZvTO7uZs3XZYay9d gKnFKgvxOMHqQs8RTElieE1ShAxTEYUb/HcbFjyuFBdQ8rBgcbNNlKg1W5ueZhPAnVeR iJT3ZvO6vr0eWjCcDt+c6U7EgExS55h3P5g1OxFd9oyRl97LjEa3VX2CwNWM9oPVkfv6 AX3QtbH58N06OasCCEg6YfNqtZWivgILUGRrPUOJCHPpi7R/7qTj8aHXk6Wh9nWk8c8j LuGg== X-Forwarded-Encrypted: i=1; AJvYcCVfCXqcfFKqBfeZsCrZ+eMb44vLHKrB7YtFEKNgHeU6AOOMMQqetv4ulkTglfq4la/jQEp83Vxh6F5wTxY=@vger.kernel.org, AJvYcCW1EzzIG8zz/ZLoEmE2EQ4l5eyyLnZfFZSSV5Pj4uO6ZA/QO0ueNSaxaeaybL5Im9rNyYpVoBN0@vger.kernel.org X-Gm-Message-State: AOJu0YxuStcxennxfL2ascMEyYLqDYGFhcUuoWmTdDrGdRxpHwa83wsO JQ/N5mN535iUd5Wx7uaKfdw+yxI9S4PwWONJHt4Db57G1j8DeaMTmbF2FMACClpi X-Gm-Gg: ASbGncvdC1vdQDCDqs8jfB2IBmU++XzKWZrcH32f7EX4gyJKVv94MagXAUZg96B8XrV txUmCVZOZZE37pnyvMrOXFgRND7SHeepEL+EjxSLCW8OgD+kmVAF3Qd0s9SDYeyFajiv0GLfEyf FFqk0cI/fY/CAccmQJWTOe/UIos45KSFlcpku/IwtIdF0YYfar6bVMyOZL3K0ZA3JNpOfAzWKt0 mRYVPMMTOrLY2BXTD/dLfCsFRnxpZJXbKQqFmNRtok0ck5OItQlwJo5FDMbuJkRIf72RciRe+ng oLs64JFWMZRN2pcoi+jDYc45sk6XWVZMOGA2UJqMtLEuZI6l0L40hxhAPAc/WA== X-Google-Smtp-Source: AGHT+IG92KzcDWTz7z7ThEbKog2vKx31iUOwDYoOHxc6XaYUqLU4+lxJyyfelJpkUe4vY3ksx8Z/AA== X-Received: by 2002:a05:622a:5143:b0:4a5:9993:ede8 with SMTP id d75a77b69052e-4a82eaa4ac3mr7688821cf.15.1751304714795; Mon, 30 Jun 2025 10:31:54 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a7fdadb11bsm59784521cf.17.2025.06.30.10.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 10:31:54 -0700 (PDT) From: Kurt Borja Date: Mon, 30 Jun 2025 14:31:20 -0300 Subject: [PATCH v3 2/3] platform/x86: think-lmi: Fix kobject cleanup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250630-lmi-fix-v3-2-ce4f81c9c481@gmail.com> References: <20250630-lmi-fix-v3-0-ce4f81c9c481@gmail.com> In-Reply-To: <20250630-lmi-fix-v3-0-ce4f81c9c481@gmail.com> To: Mark Pearson , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Hans de Goede Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Kurt Borja , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5846; i=kuurtb@gmail.com; h=from:subject:message-id; bh=WhrQT0XcjA48So7VV8f3CLepQJj/6oaWUaubJg1pcSI=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBlJp5gLZvWIbDBa37WYl+mkuH++V9ULux0dH55/uXtse +cqzTdJHaUsDGJcDLJiiiztCYu+PYrKe+t3IPQ+zBxWJpAhDFycAjCRLw8Z/ilNld6Vp7F8X/XZ mo+aEsUNmZ/n20RoLjHoDrAtLTvw9zLDP1N98d933yc7eNw+m5JiY8YTvtKUdytjQ2joDrvfs5b mMwAA X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A In tlmi_analyze(), allocated structs with an embedded kobject are freed in error paths after the they were already initialized. Fix this by first by avoiding the initialization of kobjects in tlmi_analyze() and then by correctly cleaning them up in tlmi_release_attr() using their kset's kobject list. Cc: stable@vger.kernel.org Fixes: a40cd7ef22fb ("platform/x86: think-lmi: Add WMI interface support on= Lenovo platforms") Fixes: 30e78435d3bf ("platform/x86: think-lmi: Split kobject_init() and kob= ject_add() calls") Reviewed-by: Mark Pearson Reviewed-by: Ilpo J=C3=A4rvinen Signed-off-by: Kurt Borja --- drivers/platform/x86/think-lmi.c | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-= lmi.c index 4c10a26e7e5e3471f286136d671606acf68b401e..3e5e6e6031efcefe6b3d31bc144= e738599566d98 100644 --- a/drivers/platform/x86/think-lmi.c +++ b/drivers/platform/x86/think-lmi.c @@ -1380,13 +1380,13 @@ static struct kobj_attribute debug_cmd =3D __ATTR_W= O(debug_cmd); /* ---- Initialisation ---------------------------------------------------= ------ */ static void tlmi_release_attr(void) { + struct kobject *pos, *n; int i; =20 /* Attribute structures */ for (i =3D 0; i < TLMI_SETTINGS_COUNT; i++) { if (tlmi_priv.setting[i]) { sysfs_remove_group(&tlmi_priv.setting[i]->kobj, &tlmi_attr_group); - kobject_put(&tlmi_priv.setting[i]->kobj); } } sysfs_remove_file(&tlmi_priv.attribute_kset->kobj, &pending_reboot.attr); @@ -1395,6 +1395,9 @@ static void tlmi_release_attr(void) if (tlmi_priv.can_debug_cmd && debug_support) sysfs_remove_file(&tlmi_priv.attribute_kset->kobj, &debug_cmd.attr); =20 + list_for_each_entry_safe(pos, n, &tlmi_priv.attribute_kset->list, entry) + kobject_put(pos); + kset_unregister(tlmi_priv.attribute_kset); =20 /* Free up any saved signatures */ @@ -1403,19 +1406,17 @@ static void tlmi_release_attr(void) =20 /* Authentication structures */ sysfs_remove_group(&tlmi_priv.pwd_admin->kobj, &auth_attr_group); - kobject_put(&tlmi_priv.pwd_admin->kobj); sysfs_remove_group(&tlmi_priv.pwd_power->kobj, &auth_attr_group); - kobject_put(&tlmi_priv.pwd_power->kobj); =20 if (tlmi_priv.opcode_support) { sysfs_remove_group(&tlmi_priv.pwd_system->kobj, &auth_attr_group); - kobject_put(&tlmi_priv.pwd_system->kobj); sysfs_remove_group(&tlmi_priv.pwd_hdd->kobj, &auth_attr_group); - kobject_put(&tlmi_priv.pwd_hdd->kobj); sysfs_remove_group(&tlmi_priv.pwd_nvme->kobj, &auth_attr_group); - kobject_put(&tlmi_priv.pwd_nvme->kobj); } =20 + list_for_each_entry_safe(pos, n, &tlmi_priv.authentication_kset->list, en= try) + kobject_put(pos); + kset_unregister(tlmi_priv.authentication_kset); } =20 @@ -1479,8 +1480,8 @@ static int tlmi_sysfs_init(void) =20 /* Build attribute */ tlmi_priv.setting[i]->kobj.kset =3D tlmi_priv.attribute_kset; - ret =3D kobject_add(&tlmi_priv.setting[i]->kobj, NULL, - "%s", tlmi_priv.setting[i]->display_name); + ret =3D kobject_init_and_add(&tlmi_priv.setting[i]->kobj, &tlmi_attr_set= ting_ktype, + NULL, "%s", tlmi_priv.setting[i]->display_name); if (ret) goto fail_create_attr; =20 @@ -1505,7 +1506,8 @@ static int tlmi_sysfs_init(void) =20 /* Create authentication entries */ tlmi_priv.pwd_admin->kobj.kset =3D tlmi_priv.authentication_kset; - ret =3D kobject_add(&tlmi_priv.pwd_admin->kobj, NULL, "%s", "Admin"); + ret =3D kobject_init_and_add(&tlmi_priv.pwd_admin->kobj, &tlmi_pwd_settin= g_ktype, + NULL, "%s", "Admin"); if (ret) goto fail_create_attr; =20 @@ -1514,7 +1516,8 @@ static int tlmi_sysfs_init(void) goto fail_create_attr; =20 tlmi_priv.pwd_power->kobj.kset =3D tlmi_priv.authentication_kset; - ret =3D kobject_add(&tlmi_priv.pwd_power->kobj, NULL, "%s", "Power-on"); + ret =3D kobject_init_and_add(&tlmi_priv.pwd_power->kobj, &tlmi_pwd_settin= g_ktype, + NULL, "%s", "Power-on"); if (ret) goto fail_create_attr; =20 @@ -1524,7 +1527,8 @@ static int tlmi_sysfs_init(void) =20 if (tlmi_priv.opcode_support) { tlmi_priv.pwd_system->kobj.kset =3D tlmi_priv.authentication_kset; - ret =3D kobject_add(&tlmi_priv.pwd_system->kobj, NULL, "%s", "System"); + ret =3D kobject_init_and_add(&tlmi_priv.pwd_system->kobj, &tlmi_pwd_sett= ing_ktype, + NULL, "%s", "System"); if (ret) goto fail_create_attr; =20 @@ -1533,7 +1537,8 @@ static int tlmi_sysfs_init(void) goto fail_create_attr; =20 tlmi_priv.pwd_hdd->kobj.kset =3D tlmi_priv.authentication_kset; - ret =3D kobject_add(&tlmi_priv.pwd_hdd->kobj, NULL, "%s", "HDD"); + ret =3D kobject_init_and_add(&tlmi_priv.pwd_hdd->kobj, &tlmi_pwd_setting= _ktype, + NULL, "%s", "HDD"); if (ret) goto fail_create_attr; =20 @@ -1542,7 +1547,8 @@ static int tlmi_sysfs_init(void) goto fail_create_attr; =20 tlmi_priv.pwd_nvme->kobj.kset =3D tlmi_priv.authentication_kset; - ret =3D kobject_add(&tlmi_priv.pwd_nvme->kobj, NULL, "%s", "NVMe"); + ret =3D kobject_init_and_add(&tlmi_priv.pwd_nvme->kobj, &tlmi_pwd_settin= g_ktype, + NULL, "%s", "NVMe"); if (ret) goto fail_create_attr; =20 @@ -1579,8 +1585,6 @@ static struct tlmi_pwd_setting *tlmi_create_auth(cons= t char *pwd_type, new_pwd->maxlen =3D tlmi_priv.pwdcfg.core.max_length; new_pwd->index =3D 0; =20 - kobject_init(&new_pwd->kobj, &tlmi_pwd_setting_ktype); - return new_pwd; } =20 @@ -1685,7 +1689,6 @@ static int tlmi_analyze(struct wmi_device *wdev) if (setting->possible_values) strreplace(setting->possible_values, ',', ';'); =20 - kobject_init(&setting->kobj, &tlmi_attr_setting_ktype); tlmi_priv.setting[i] =3D setting; kfree(item); } --=20 2.50.0 From nobody Wed Oct 8 08:14:51 2025 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF1CB19CC29; Mon, 30 Jun 2025 17:31:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751304720; cv=none; b=od4XuG6/bmFdLReBZEKfnU81VmIB0Ku2kd2MFvhvRVOk68hj1av7Yl3hwPngTeccJg/tuaZ2oI8f17hlykTSIReMSOKYsSvv4r8AADn77jKmXHJe74KRg+pfdf36fa7WOE6h27BvUbLvqdWWsOrV1ySDMxNvAH48mNLd5cpihLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751304720; c=relaxed/simple; bh=ZURlPW2Su3bhWmXhsJ5JPtUvI0sHbLz04Z8qD3gPWwA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=u6J8LFd2TrXSIyiBBO5iAIORJdzRfe38PuFtzg6GBRJNNMGBdxh6IP2oBWglg9wSco2plW5QUQdzWsyO4u1RIT4m4f5PnZUVdH8Qi/nDlxE3gXGPwohbgqdZ5IzkALJu877YJZ52wT8WVEICEpNhedxcZvvPY2YEr5bLexVfbZk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ys7g7dDU; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ys7g7dDU" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4a752944794so55029071cf.3; Mon, 30 Jun 2025 10:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751304717; x=1751909517; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1XyHKWfXiT73L/YJwJtLTidOp8ZtTUUZ7vQ8/O4IC6M=; b=Ys7g7dDU8y88S88k0nmzf0CkhRzvf6wGUpwUtNcc7/XZarG57tsu317I72bUwcVo0o I8T9YT8AURo+7dX8uZ1brGsxlFZ1g5/NLbWNNSMRDU8EhKSRv839UvaAeCGw8yIgPesQ XkUnuBdYZ9bbfgIfyFhRUWE0E7Y85yrRuryyuWNz3vdUJyGawGKDuzSPsH1e1g4xRKAN PwK1gTpp055EharZ3iWT/C4yTw9ZA86SS9a0VZThY2jXnqkRaeqXT5PjtFv29rxPXifR 5OoP0xa90TdUUUR4qsa9UAGSlKwnEv7tWsOIhfPSj7ECxD6runMzJFXDisKUMseIRG1Z 3/fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751304717; x=1751909517; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1XyHKWfXiT73L/YJwJtLTidOp8ZtTUUZ7vQ8/O4IC6M=; b=HVE7JfGel61WzizK43puQ4wjcFq+K3JEW2btNYRj7Gwtnlr40DE9fnUx8lT60YSgL+ eU44o4mNWaBNUg5R0Mpk3whIKTV6hSt6loAbTwbCjHrq3+OONNEmCJuUSqHTt+apadj7 C0BKN7RI7CoBrDyFRN/RGs/+OgwlWGxQeUA9JGgqdF+B50IBVKftJK7krk8edYNCQ48K EEsR0P2bVuftQXUVwAIH0P7uPYwww8RQrAgZJBkeLejJFH49ePp1AhxucmLkvi8iklu4 TmACMYtq7LuZOLL+gO3KubQXKUh2qaPvYrPuQUOExgFfIMgZdcyjjwoV0TtBJU4CRKBA JGiA== X-Forwarded-Encrypted: i=1; AJvYcCW0WTz16BgxHg64swvdf9YIBSJrAoTuWbBDtRmixX2pHYBYUZngL7RZwc5kftCm1ctxGzttVZppgkAK5AE=@vger.kernel.org, AJvYcCWMBBYyPKSObQiAbxm2E0TbEWdZU4D3A4KurieNmg+buPGwZ8RUnS1OqdmlMO28H1+xBilJC3qv@vger.kernel.org X-Gm-Message-State: AOJu0Ywo0otyarWttgsSb9xo48KsFkr0qQdWzt/+40/L4ae6CupCGzUi ru2wbk4ccL4u77kNiuFpSCmXgz1f4bm4DiTNSmOhGOu7ZQ9kHvFWfa3kFemPL2nx X-Gm-Gg: ASbGncv5+9HAZHf6oWFsHeookAVZtPOXTWfLDhPUURT4H9rnwkFxDww4Ozzjlzjj9s6 +AwecUKpJ6PzJTPgzW0li1o5IIKiSIceFz40G3cuoCLxf+/wAHr6E9HXO05ul+6MqlPuZm1PHVc WX1U6BVm7lVY0ON25Cuq5nn/QFe+lZW20JhfVRU1PHZzocVdC1UgrOCjl2VhfzydOxeeDW7c/xS 1auozeVIAJ9vIeKCBaIu6iZ2sZDVq6sYg4kRnZZh95r41ORY1bRuBaEn1poDZijHNmivEasX8s9 e/9QWKWrwIt1vRbH/CvXGU3sl7J/Mqx0EVys1m7T9UYsyugA7XXhjZJwaAZtUg== X-Google-Smtp-Source: AGHT+IGkuOjju5AuPtd/cJ1gTcI5SpsR41Hyu6T1TxW+PRwPKPth4lKNdSMaaT9esOCSEaX3+1gKLw== X-Received: by 2002:a05:622a:30d:b0:494:a2b8:88f0 with SMTP id d75a77b69052e-4a7fcab19cbmr220357751cf.33.1751304717324; Mon, 30 Jun 2025 10:31:57 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a7fdadb11bsm59784521cf.17.2025.06.30.10.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 10:31:57 -0700 (PDT) From: Kurt Borja Date: Mon, 30 Jun 2025 14:31:21 -0300 Subject: [PATCH v3 3/3] platform/x86: think-lmi: Fix sysfs group cleanup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250630-lmi-fix-v3-3-ce4f81c9c481@gmail.com> References: <20250630-lmi-fix-v3-0-ce4f81c9c481@gmail.com> In-Reply-To: <20250630-lmi-fix-v3-0-ce4f81c9c481@gmail.com> To: Mark Pearson , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Hans de Goede Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Kurt Borja , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5264; i=kuurtb@gmail.com; h=from:subject:message-id; bh=ZURlPW2Su3bhWmXhsJ5JPtUvI0sHbLz04Z8qD3gPWwA=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBlJp5jlxSzfsrh8unrZ1V5/499Sru+Cgvdjzh5K7E76O 2nD3RTGjlIWBjEuBlkxRZb2hEXfHkXlvfU7EHofZg4rE8gQBi5OAZjIpOmMDDearsq9KU5WeS3w xe+Xm/27jo3nLfZemDwv+T9DgT9nbycjw35f74R5XyYGpl7tv2gS3BZnppqg/yRA3ynHgPfjO5l 4HgA= X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Many error paths in tlmi_sysfs_init() lead to sysfs groups being removed when they were not even created. Fix this by letting the kobject core manage these groups through their kobj_type's defult_groups. Cc: stable@vger.kernel.org Fixes: a40cd7ef22fb ("platform/x86: think-lmi: Add WMI interface support on= Lenovo platforms") Reviewed-by: Mark Pearson Reviewed-by: Ilpo J=C3=A4rvinen Signed-off-by: Kurt Borja --- drivers/platform/x86/think-lmi.c | 43 ++++--------------------------------= ---- 1 file changed, 4 insertions(+), 39 deletions(-) diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-= lmi.c index 3e5e6e6031efcefe6b3d31bc144e738599566d98..ca8498f8b831ae5d5c1dcb3f058= 5e748975dd2c7 100644 --- a/drivers/platform/x86/think-lmi.c +++ b/drivers/platform/x86/think-lmi.c @@ -973,6 +973,7 @@ static const struct attribute_group auth_attr_group =3D= { .is_visible =3D auth_attr_is_visible, .attrs =3D auth_attrs, }; +__ATTRIBUTE_GROUPS(auth_attr); =20 /* ---- Attributes sysfs -------------------------------------------------= -------- */ static ssize_t display_name_show(struct kobject *kobj, struct kobj_attribu= te *attr, @@ -1188,6 +1189,7 @@ static const struct attribute_group tlmi_attr_group = =3D { .is_visible =3D attr_is_visible, .attrs =3D tlmi_attrs, }; +__ATTRIBUTE_GROUPS(tlmi_attr); =20 static void tlmi_attr_setting_release(struct kobject *kobj) { @@ -1207,11 +1209,13 @@ static void tlmi_pwd_setting_release(struct kobject= *kobj) static const struct kobj_type tlmi_attr_setting_ktype =3D { .release =3D &tlmi_attr_setting_release, .sysfs_ops =3D &kobj_sysfs_ops, + .default_groups =3D tlmi_attr_groups, }; =20 static const struct kobj_type tlmi_pwd_setting_ktype =3D { .release =3D &tlmi_pwd_setting_release, .sysfs_ops =3D &kobj_sysfs_ops, + .default_groups =3D auth_attr_groups, }; =20 static ssize_t pending_reboot_show(struct kobject *kobj, struct kobj_attri= bute *attr, @@ -1381,14 +1385,8 @@ static struct kobj_attribute debug_cmd =3D __ATTR_WO= (debug_cmd); static void tlmi_release_attr(void) { struct kobject *pos, *n; - int i; =20 /* Attribute structures */ - for (i =3D 0; i < TLMI_SETTINGS_COUNT; i++) { - if (tlmi_priv.setting[i]) { - sysfs_remove_group(&tlmi_priv.setting[i]->kobj, &tlmi_attr_group); - } - } sysfs_remove_file(&tlmi_priv.attribute_kset->kobj, &pending_reboot.attr); sysfs_remove_file(&tlmi_priv.attribute_kset->kobj, &save_settings.attr); =20 @@ -1405,15 +1403,6 @@ static void tlmi_release_attr(void) kfree(tlmi_priv.pwd_admin->save_signature); =20 /* Authentication structures */ - sysfs_remove_group(&tlmi_priv.pwd_admin->kobj, &auth_attr_group); - sysfs_remove_group(&tlmi_priv.pwd_power->kobj, &auth_attr_group); - - if (tlmi_priv.opcode_support) { - sysfs_remove_group(&tlmi_priv.pwd_system->kobj, &auth_attr_group); - sysfs_remove_group(&tlmi_priv.pwd_hdd->kobj, &auth_attr_group); - sysfs_remove_group(&tlmi_priv.pwd_nvme->kobj, &auth_attr_group); - } - list_for_each_entry_safe(pos, n, &tlmi_priv.authentication_kset->list, en= try) kobject_put(pos); =20 @@ -1484,10 +1473,6 @@ static int tlmi_sysfs_init(void) NULL, "%s", tlmi_priv.setting[i]->display_name); if (ret) goto fail_create_attr; - - ret =3D sysfs_create_group(&tlmi_priv.setting[i]->kobj, &tlmi_attr_group= ); - if (ret) - goto fail_create_attr; } =20 ret =3D sysfs_create_file(&tlmi_priv.attribute_kset->kobj, &pending_reboo= t.attr); @@ -1511,20 +1496,12 @@ static int tlmi_sysfs_init(void) if (ret) goto fail_create_attr; =20 - ret =3D sysfs_create_group(&tlmi_priv.pwd_admin->kobj, &auth_attr_group); - if (ret) - goto fail_create_attr; - tlmi_priv.pwd_power->kobj.kset =3D tlmi_priv.authentication_kset; ret =3D kobject_init_and_add(&tlmi_priv.pwd_power->kobj, &tlmi_pwd_settin= g_ktype, NULL, "%s", "Power-on"); if (ret) goto fail_create_attr; =20 - ret =3D sysfs_create_group(&tlmi_priv.pwd_power->kobj, &auth_attr_group); - if (ret) - goto fail_create_attr; - if (tlmi_priv.opcode_support) { tlmi_priv.pwd_system->kobj.kset =3D tlmi_priv.authentication_kset; ret =3D kobject_init_and_add(&tlmi_priv.pwd_system->kobj, &tlmi_pwd_sett= ing_ktype, @@ -1532,29 +1509,17 @@ static int tlmi_sysfs_init(void) if (ret) goto fail_create_attr; =20 - ret =3D sysfs_create_group(&tlmi_priv.pwd_system->kobj, &auth_attr_group= ); - if (ret) - goto fail_create_attr; - tlmi_priv.pwd_hdd->kobj.kset =3D tlmi_priv.authentication_kset; ret =3D kobject_init_and_add(&tlmi_priv.pwd_hdd->kobj, &tlmi_pwd_setting= _ktype, NULL, "%s", "HDD"); if (ret) goto fail_create_attr; =20 - ret =3D sysfs_create_group(&tlmi_priv.pwd_hdd->kobj, &auth_attr_group); - if (ret) - goto fail_create_attr; - tlmi_priv.pwd_nvme->kobj.kset =3D tlmi_priv.authentication_kset; ret =3D kobject_init_and_add(&tlmi_priv.pwd_nvme->kobj, &tlmi_pwd_settin= g_ktype, NULL, "%s", "NVMe"); if (ret) goto fail_create_attr; - - ret =3D sysfs_create_group(&tlmi_priv.pwd_nvme->kobj, &auth_attr_group); - if (ret) - goto fail_create_attr; } =20 return ret; --=20 2.50.0