From nobody Wed Oct 8 09:04:35 2025 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6746B226188; Mon, 30 Jun 2025 08:01:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270511; cv=none; b=h+235TlJJwJ/Z/HxPsEylSy+alhZHN6itzgcIY11m5ld9jaYvlRmtfKPMNQs3qtCUq0aSO+yShzwoOz8phZFu6MYTGz4xPXHvUa8DXlkNZD+AxqiY0kiGUC97FRSc7ZD3+UnmpdNoCfDygmq/1xui0zjfrIoGSaIYFR43P02gCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270511; c=relaxed/simple; bh=zZ69nhPC05C/IVyet5AAcunJAngX7yFVUr44yHysUEQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CM5Txj1ZnoqKNqIIswxJIwE6oVoSF3xJ13pEpCxLMMfuZDmWWzjMhevf5r2pHkARte3QUrYFS91zLSlRSMopsMLB8T05pAcJ5MqI+uu+nTKwnX7XgvSuuLX/OeI4Lrn/526SqGqyo+UqdwSLa+1GW7rM0BFwAm6zqEvB6ycZ6EU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lxMqFkgX; arc=none smtp.client-ip=209.85.219.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lxMqFkgX" Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6facacf521eso39928236d6.3; Mon, 30 Jun 2025 01:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751270508; x=1751875308; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=N/hr4oZCa99X/XQ29O91yb8fYOE3pn7wlTo8T8hI858=; b=lxMqFkgXpjBeAp3/yvRFNiAZBlV40wzUIBPVv12BDTbAwxEQl5yh7BmkXH33W2k9fr I75/J32aJ181Yo88sG8RiIotJ8sYWf30sdUSMvgDl0M8dzDAv598j7djfWfNtGj3Wfly 2CjJjMSUm2TdC1iaIQzTIbz9fdkUOHNnJlo65d9S3IzbzM77rmwarO8Ln2baGtW5wSio 4j/wImLxNUh+fl7kJPbUn3kJmfWL1I7HIwtn+rux0w5X3+ghy5iLd4HfuDLVEmHt2DxX qp9xWip/fFpgsfx0ORGaeGFeqjQxF1Z3fzv7AOHlc6O7k0j2RulUbAumXI8ROBCu9SqR DeiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751270508; x=1751875308; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N/hr4oZCa99X/XQ29O91yb8fYOE3pn7wlTo8T8hI858=; b=n3I/9ZDWLaQKf83zPuAaBN2BLFNUfyiNK+hkcd50Ki2sYSFn7tCW+7ZY+ZtaC+xJWd QdfFCF3dpzntEAQ6OIZwE+OjTVN7A4F9OgnzXXpkndfvMiyGkJE66TWchMsm5kbu95gV PSTq8jVGCMupvsoLYvZUJBykkdU4BscSch2pIfALi77TiwAMmrQ4Nnbefm4hKgLiPbK3 ENT/y9R/hnUmBJQZefqlShqOyS/0h60TLXrxfnI9JeLzgb57p1N4SZIi5IIxkRxm+ucW bD0jvIsXGUfajH2prpOXP8yZcu0lfVw75jK/Fdr7Fc7Hr3jmL7ju5esti3YW4aSlILd3 NSzg== X-Forwarded-Encrypted: i=1; AJvYcCVCQosXXg/xGV2kiHEQlNXWb6CFPZvJddLDjDY+4dIKDuieZcmOGJ6POc2f59Ce1hottFj0zF5ppoOA0i7fHWOI4bb9xA==@vger.kernel.org, AJvYcCX4AB6w9qdWxgGgv9LxHoKxzcTkTV0luDZeEJZov24QOvGjhk5OoaDQCcPxhwTqIjXeJRA1vA0yLnxxpyU=@vger.kernel.org X-Gm-Message-State: AOJu0YxLido09L5+7i3TNwxAPZtAXzubJH/bjRZd8uO1Q09PRQ++EHlI fNJDkYj2k6CiYAkITVZ3mmHgQELRm3BjLTwUDNCtWL9ayXDpXCCsqdvW X-Gm-Gg: ASbGnctGee2iwC1NdfzIa8uI91AZkV2sJDNSc0tVwFdA/zG1498DpR9KHFlTpWaXO2R j+awY0GjXRYmmd9940W9jXlSU0eONFa/UbrEq+a/wx3GnI1F/bFUxHf65tRTFwnw/j5GkNyWcLY DCvERsGvyxbZjnu4wci4nGwfi4pd0yie/yVRE+DXrY030j0YVT0neafKeyXgZxPGdhCMG54kamb HhikUeyG2A31aX30pDNlxdeyS+ezpOaz+qxQAf/IcyKsQlEnyKJQm1JmM85/CvJv9QVdbHFPHPX ZvZhXHS6pav0LbX4Ktg2nxnsd8gtdMmHDngi+se5kbReUujgmwAJTVjYx5fvDF8h7fvRYY8i X-Google-Smtp-Source: AGHT+IHskYkxpsJvBPm9JBOuX//BGvZ8iinVtXuBAELRkfUZGzB7gp1/62K3tOPOF8hmaislRkajnw== X-Received: by 2002:a05:6214:c67:b0:6fd:6fc6:3961 with SMTP id 6a1803df08f44-70003c8eae7mr211017006d6.37.1751270508208; Mon, 30 Jun 2025 01:01:48 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd772df637sm63677026d6.79.2025.06.30.01.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 01:01:47 -0700 (PDT) From: Kurt Borja Date: Mon, 30 Jun 2025 05:01:08 -0300 Subject: [PATCH v4 1/6] platform/x86: firmware_attributes_class: Add device initialization methods Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250630-fw-attrs-api-v4-1-1a04952b255f@gmail.com> References: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> In-Reply-To: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=6428; i=kuurtb@gmail.com; h=from:subject:message-id; bh=miBaZDkSezgefWBLluXQog1pUwOQXq4z7EwqkNdxXE8=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBlJLsksi3cz3G7ZPYXn3Q3u1yy7mq8lqme9WqiyP3ZB6 POcG4HyHaUsDGJcDLJiiiztCYu+PYrKe+t3IPQ+zBxWJpAhDFycAjCR7ksM/1Qt8io+fFCXXZ4s KrpccN/sE6ua59QfmsG6Z2qHybXo5Z8ZGVbW350teOjwi7VxgvnxYYcfRfVmbP933inOcK6YT+h 6YQ4A X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A From: Thomas Wei=C3=9Fschuh Currently each user of firmware_attributes_class has to manually set up kobjects, devices, etc. Provide this infrastructure out-of-the-box through the newly introduced fwat_device_register(). Reviewed-by: Mario Limonciello Signed-off-by: Thomas Wei=C3=9Fschuh Co-developed-by: Kurt Borja Signed-off-by: Kurt Borja --- drivers/platform/x86/firmware_attributes_class.c | 125 +++++++++++++++++++= ++++ drivers/platform/x86/firmware_attributes_class.h | 28 +++++ 2 files changed, 153 insertions(+) diff --git a/drivers/platform/x86/firmware_attributes_class.c b/drivers/pla= tform/x86/firmware_attributes_class.c index 736e96c186d9dc6d945517f090e9af903e93bbf4..29c303c20d47a7dccf59cf54fa1= a7e91e582f894 100644 --- a/drivers/platform/x86/firmware_attributes_class.c +++ b/drivers/platform/x86/firmware_attributes_class.c @@ -2,7 +2,14 @@ =20 /* Firmware attributes class helper module */ =20 +#include +#include +#include +#include +#include #include +#include +#include #include "firmware_attributes_class.h" =20 const struct class firmware_attributes_class =3D { @@ -10,6 +17,122 @@ const struct class firmware_attributes_class =3D { }; EXPORT_SYMBOL_GPL(firmware_attributes_class); =20 +static void fwat_device_release(struct device *dev) +{ + struct fwat_device *fadev =3D to_fwat_device(dev); + + kfree(fadev); +} + +/** + * fwat_device_register - Create and register a firmware-attributes class + * device + * @parent: Parent device + * @name: Name of the class device + * @data: Drvdata of the class device + * @groups: Extra groups for the class device (Optional) + * + * Return: pointer to the new fwat_device on success, ERR_PTR on failure + */ +struct fwat_device * +fwat_device_register(struct device *parent, const char *name, void *drvdat= a, + const struct attribute_group **groups) +{ + struct fwat_device *fadev; + int ret; + + if (!parent || !name) + return ERR_PTR(-EINVAL); + + fadev =3D kzalloc(sizeof(*fadev), GFP_KERNEL); + if (!fadev) + return ERR_PTR(-ENOMEM); + + fadev->groups =3D groups; + fadev->dev.class =3D &firmware_attributes_class; + fadev->dev.parent =3D parent; + fadev->dev.release =3D fwat_device_release; + dev_set_drvdata(&fadev->dev, drvdata); + ret =3D dev_set_name(&fadev->dev, "%s", name); + if (ret) { + kfree(fadev); + return ERR_PTR(ret); + } + ret =3D device_register(&fadev->dev); + if (ret) + return ERR_PTR(ret); + + fadev->attrs_kset =3D kset_create_and_add("attributes", NULL, &fadev->dev= .kobj); + if (!fadev->attrs_kset) { + ret =3D -ENOMEM; + goto out_device_unregister; + } + + ret =3D sysfs_create_groups(&fadev->attrs_kset->kobj, groups); + if (ret) + goto out_kset_unregister; + + return fadev; + +out_kset_unregister: + kset_unregister(fadev->attrs_kset); + +out_device_unregister: + device_unregister(&fadev->dev); + + return ERR_PTR(ret); +} +EXPORT_SYMBOL_GPL(fwat_device_register); + +void fwat_device_unregister(struct fwat_device *fadev) +{ + if (!fadev) + return; + + sysfs_remove_groups(&fadev->attrs_kset->kobj, fadev->groups); + kset_unregister(fadev->attrs_kset); + device_unregister(&fadev->dev); +} +EXPORT_SYMBOL_GPL(fwat_device_unregister); + +static void devm_fwat_device_release(void *data) +{ + struct fwat_device *fadev =3D data; + + fwat_device_unregister(fadev); +} + +/** + * devm_fwat_device_register - Create and register a firmware-attributes c= lass + * device + * @parent: Parent device + * @name: Name of the class device + * @data: Drvdata of the class device + * @groups: Extra groups for the class device (Optional) + * + * Device managed version of fwat_device_register(). + * + * Return: pointer to the new fwat_device on success, ERR_PTR on failure + */ +struct fwat_device * +devm_fwat_device_register(struct device *parent, const char *name, void *d= ata, + const struct attribute_group **groups) +{ + struct fwat_device *fadev; + int ret; + + fadev =3D fwat_device_register(parent, name, data, groups); + if (IS_ERR(fadev)) + return fadev; + + ret =3D devm_add_action_or_reset(parent, devm_fwat_device_release, fadev); + if (ret) + return ERR_PTR(ret); + + return fadev; +} +EXPORT_SYMBOL_GPL(devm_fwat_device_register); + static __init int fw_attributes_class_init(void) { return class_register(&firmware_attributes_class); @@ -23,5 +146,7 @@ static __exit void fw_attributes_class_exit(void) module_exit(fw_attributes_class_exit); =20 MODULE_AUTHOR("Mark Pearson "); +MODULE_AUTHOR("Thomas Wei=C3=9Fschuh "); +MODULE_AUTHOR("Kurt Borja "); MODULE_DESCRIPTION("Firmware attributes class helper module"); MODULE_LICENSE("GPL"); diff --git a/drivers/platform/x86/firmware_attributes_class.h b/drivers/pla= tform/x86/firmware_attributes_class.h index d27abe54fcf9812a2f0868eec5426bbc8e7eb21c..4ae700eec1e586e1f9ed96bd6e3= 843342381816d 100644 --- a/drivers/platform/x86/firmware_attributes_class.h +++ b/drivers/platform/x86/firmware_attributes_class.h @@ -5,8 +5,36 @@ #ifndef FW_ATTR_CLASS_H #define FW_ATTR_CLASS_H =20 +#include +#include #include +#include +#include =20 extern const struct class firmware_attributes_class; =20 +/** + * struct fwat_device - The firmware-attributes device + * @dev: The class device. + * @attrs_kobj: The "attributes" root kobject. + * @groups: Sysfs groups attached to the @attrs_kobj. + */ +struct fwat_device { + struct device dev; + struct kset *attrs_kset; + const struct attribute_group **groups; +}; + +#define to_fwat_device(_d) container_of_const(_d, struct fwat_device, dev) + +struct fwat_device * __must_check +fwat_device_register(struct device *parent, const char *name, void *data, + const struct attribute_group **groups); + +void fwat_device_unregister(struct fwat_device *fwadev); + +struct fwat_device * __must_check +devm_fwat_device_register(struct device *parent, const char *name, void *d= ata, + const struct attribute_group **groups); + #endif /* FW_ATTR_CLASS_H */ --=20 2.50.0 From nobody Wed Oct 8 09:04:35 2025 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3022923496F; Mon, 30 Jun 2025 08:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270516; cv=none; b=Jg1ZjoCM7Ke+D5+sX4SNLSF5i88Q71NhAxHa60wpgAyRk3oqcfwlPeNlwePHlmrcGYG/evi3ly1i35XVKAyNjpCYGzuxtss3jxpTLXsHVCe8aPnIHBEtqr7M+ub+F4+nQagjVyqTtMYq/tk2E2Ju7QcxC0U9BNcCYxVS7AbA8Kg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270516; c=relaxed/simple; bh=AZEEUqC+EjE7k7PlTPQopSyTC6DQni6ony37VFSWdio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m0f1blHByqtcnm6NYp37eHPcR3X4nnmzGxZ3OOtoNWJBNjP3XsKVvAJinvwOXnsJQVa/EokzjSaj/WRxOJbdSTnEfpL9ZMzIYHyRYWevlxrmrGtJu0sMJIDnLXAkKAdzuWKX8/Sxjl5oztaq5Sw5jRIDk2Lgu1yPNAL4pSdJXDk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l5VqCdek; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l5VqCdek" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6ff16e97d1eso36921896d6.1; Mon, 30 Jun 2025 01:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751270513; x=1751875313; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FldLtsa2ZraQHB5ZJy0XrJxSRe5TFy/rBHQk7sQUcHI=; b=l5VqCdekvF8jS4esB0m8kl1BdD6vj//eXLTrZdv2N66vZD7ailfVjb+waSfzwRcVcL +6djxuxW6cb8UF93Q7eGTQRXwTMaVAfN/Ws+H1mbOYP2CuUFfvgvt7LRDpNNi51veDyp P9Ns/pcClL3wNJDDms0w0Os7hUaCbJr9+xP6MFDsLHtAwc80KKMXXQ6A9CbLCQn5YzBf gzSfupj41V3ofADwt8xYD9qvj2NKEKpDPBnxtNz6kwxOumv6ODgNe+YZWP9jZWOWM/UV FkhTYmt7wcFXbIcAzZnltSLJ1yPtK/KhfLPWvttc8HRmmxFxOoUJWVP5b/6nL1JUrwgu sW4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751270513; x=1751875313; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FldLtsa2ZraQHB5ZJy0XrJxSRe5TFy/rBHQk7sQUcHI=; b=Ie0KtyUfR3u5qmhQW+1+/3BvTCg943TwKnTR3l5vaKu6hMwiY2d3JwM8uR5poUsQP8 pED4HarwbtbdqihWIPQezg95l+7pOMvGk/kRVkUKsC764b09mWFj3zGwd2CjmqgFEjJh U9yerqIH5oL7QpEojnVnLEKeN7aZyBefkUI2kGT2v0nmHXumVwOMUd/HoibYAfhqhg5G 8Pwkq+eSegcGtqHUD+UhlcbGCn+aic5XeMyIyhs79EKli7+tQa2rp8bpJSQG6KGiEQAh o/AYh0N/veoFjEq7OYl9dl2YlkrsDfeIm8l10oWZBL3rStzuYBJx4OxZSXaGDBCdkSKt pwFg== X-Forwarded-Encrypted: i=1; AJvYcCWMoShpUKjuQWgf2qCqBTqVrQRvr4FNQ2VxlOcvRqJm/Qiw2oG9h/t/ncNiJGVVLuuxdImvNB+0srzShrauAFlgYVcWJA==@vger.kernel.org, AJvYcCXCwKNsZ6nIP10Rr9vVw4CsDV9joUzQ86pWDXwpOxV//PKHqlEIDr76h5pClH9tyQgOeTULq2NXTdUoKr4=@vger.kernel.org X-Gm-Message-State: AOJu0YyqZNm+wuHZQgIpbc8PyVAVuMzwyvFjM569JBCzWo9uR3Upm+P9 hxypC7ex+8xKfxysSTqcXs6Ta+S2lutf9T3GwlCkdw57PIAdzHNFGgZ4 X-Gm-Gg: ASbGncurXtxpBTw2qj8IYqfF6RGVQRuHDkiZrtRe7u6oUJrDIIXIKhs16ChC3UCU72E BcoK0IwnWoPz9/236Ue0Yi0RfefCq+UBZEZmnxxqDhMymiM5OwOOGrQbZS3ImlqocSsMEJyUyEo /odzNtvqtOkRZ7wP1Gru2w6H/dABG6k1a/ELY2PmRjFyBHmRGxwfrWFJdZYShsrLKfhEVvbe8DS 2AQMn0twQQUUv03KvNxbKz4LVT4xkfNBubf08sdjr9yRI3Mxb6MvPCao0ywczOQf+bf2GcWJC4S mJWq4o4wiDMUXszfyTT6fdcbHFc8R/B9xQf1OptmmwH4dp735kD3UzSNTUQnPg4iAFyqDCAw X-Google-Smtp-Source: AGHT+IFnBDazOKajLYcCYTIZ5swm9fCpC805eDrGtkDU1wQMIKLfQKwazQ2tAeDcyaCBJf7VOuBUBg== X-Received: by 2002:a05:6214:d44:b0:6fd:3963:7a7b with SMTP id 6a1803df08f44-6fd75335c24mr322419316d6.1.1751270512636; Mon, 30 Jun 2025 01:01:52 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd772df637sm63677026d6.79.2025.06.30.01.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 01:01:52 -0700 (PDT) From: Kurt Borja Date: Mon, 30 Jun 2025 05:01:09 -0300 Subject: [PATCH v4 2/6] platform/x86: firmware_attributes_class: Add high level API for the attributes interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250630-fw-attrs-api-v4-2-1a04952b255f@gmail.com> References: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> In-Reply-To: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=31328; i=kuurtb@gmail.com; h=from:subject:message-id; bh=AZEEUqC+EjE7k7PlTPQopSyTC6DQni6ony37VFSWdio=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBlJLslM1gxyV8UMGY6yK+Ru8E2tnxiYeHqSZ5bHT4XLc 5V5/fo6SlkYxLgYZMUUWdoTFn17FJX31u9A6H2YOaxMIEMYuDgFYCIVRxkZFu7JcWjuDduvKLFm y79+LxfFatf7p674iPt/8BNv+/yGhZGhnefQqYReCyEhbg0ddZej0TGuASacDqyef3zjpz2ab8k AAA== X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Add high level API to aid in the creation of attribute groups attached to the `attrs_kobj` (per ABI specification). This new API lets users configure each group, either statically or dynamically through a (per type) data struct and then create this group through the generic fwat_create_group() macro. Signed-off-by: Kurt Borja --- drivers/platform/x86/firmware_attributes_class.c | 532 +++++++++++++++++++= ++++ drivers/platform/x86/firmware_attributes_class.h | 335 ++++++++++++++ 2 files changed, 867 insertions(+) diff --git a/drivers/platform/x86/firmware_attributes_class.c b/drivers/pla= tform/x86/firmware_attributes_class.c index 29c303c20d47a7dccf59cf54fa1a7e91e582f894..86d2a8bf4bb9debc81e38c928c5= a3eb5a440cc18 100644 --- a/drivers/platform/x86/firmware_attributes_class.c +++ b/drivers/platform/x86/firmware_attributes_class.c @@ -10,13 +10,67 @@ #include #include #include +#include #include "firmware_attributes_class.h" =20 +#define FWAT_TYPE_NONE -1 + +#define to_fwat_bool_data(_c) \ + container_of_const(_c, struct fwat_bool_data, group) +#define to_fwat_enum_data(_c) \ + container_of_const(_c, struct fwat_enum_data, group) +#define to_fwat_int_data(_c) \ + container_of_const(_c, struct fwat_int_data, group) +#define to_fwat_str_data(_c) \ + container_of_const(_c, struct fwat_str_data, group) + +struct fwat_attribute { + struct attribute attr; + ssize_t (*show)(struct kobject *kobj, struct fwat_attribute *attr, + char *buf); + ssize_t (*store)(struct kobject *kobj, struct fwat_attribute *attr, + const char *buf, size_t count); + int type; +}; + +#define to_fwat_attribute(_a) \ + container_of_const(_a, struct fwat_attribute, attr) + +#define __FWAT_ATTR(_name, _mode, _show, _store, _type) \ + { \ + .attr =3D { .name =3D __stringify(_name), .mode =3D _mode }, \ + .show =3D _show, .store =3D _store, .type =3D _type, \ + } + +#define FWAT_ATTR_RO(_prefix, _name, _show, _type) \ + static struct fwat_attribute fwat_##_prefix##_##_name##_attr =3D \ + __FWAT_ATTR(_name, 0444, _show, NULL, _type) + +#define FWAT_ATTR_RW(_prefix, _name, _show, _store, _type) \ + static struct fwat_attribute fwat_##_prefix##_##_name##_attr =3D \ + __FWAT_ATTR(_name, 0644, _show, _store, _type) + +struct fwat_group { + const struct fwat_group_data *data; + struct device *dev; + struct kobject kobj; +}; + +#define kobj_to_fwat_group(_k) \ + container_of_const(_k, struct fwat_group, kobj) + const struct class firmware_attributes_class =3D { .name =3D "firmware-attributes", }; EXPORT_SYMBOL_GPL(firmware_attributes_class); =20 +static const char * const fwat_type_labels[] =3D { + [fwat_group_boolean] =3D "boolean", + [fwat_group_enumeration] =3D "enumeration", + [fwat_group_integer] =3D "integer", + [fwat_group_string] =3D "string", +}; + static void fwat_device_release(struct device *dev) { struct fwat_device *fadev =3D to_fwat_device(dev); @@ -24,6 +78,483 @@ static void fwat_device_release(struct device *dev) kfree(fadev); } =20 +static ssize_t +type_show(struct kobject *kobj, struct fwat_attribute *attr, char *buf) +{ + return sysfs_emit(buf, "%s\n", fwat_type_labels[attr->type]); +} + +static ssize_t +display_name_show(struct kobject *kobj, struct fwat_attribute *attr, char = *buf) +{ + struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const char *disp_name =3D group->data->display_name; + + if (!disp_name) + return -EOPNOTSUPP; + + return sysfs_emit(buf, "%s\n", disp_name); +} + +static ssize_t +display_name_language_code_show(struct kobject *kobj, struct fwat_attribut= e *attr, + char *buf) +{ + struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const char *lang_code =3D group->data->language_code; + + if (!lang_code) + return -EOPNOTSUPP; + + return sysfs_emit(buf, "%s\n", lang_code); +} + +static ssize_t +bool_group_show(struct kobject *kobj, struct fwat_attribute *attr, char *b= uf) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_bool_data *data =3D to_fwat_bool_data(group->data); + bool val; + int ret; + + /* show_override does not affect current_value */ + if (data->group.show_override && attr->type !=3D fwat_bool_current_value) + return data->group.show_override(group->dev, attr->type, buf); + + switch (attr->type) { + case fwat_bool_current_value: + ret =3D data->read(group->dev, data->group.id, &val); + if (ret < 0) + return ret; + break; + case fwat_bool_default_value: + val =3D data->default_val; + break; + default: + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%s\n", str_yes_no(val)); +} + +static ssize_t +bool_group_store(struct kobject *kobj, struct fwat_attribute *attr, const = char *buf, + size_t count) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_bool_data *data =3D to_fwat_bool_data(group->data); + bool val; + int ret; + + ret =3D kstrtobool(buf, &val); + if (ret) + return ret; + + ret =3D data->write(group->dev, data->group.id, val); + if (ret) + return ret; + + return count; +} + +static ssize_t +enum_group_show(struct kobject *kobj, struct fwat_attribute *attr, char *b= uf) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_enum_data *data =3D to_fwat_enum_data(group->data); + int val_idx, sz =3D 0; + int ret; + + /* show_override does not affect current_value */ + if (data->group.show_override && attr->type !=3D fwat_enum_current_value) + return data->group.show_override(group->dev, attr->type, buf); + + switch (attr->type) { + case fwat_enum_current_value: + ret =3D data->read(group->dev, data->group.id, &val_idx); + if (ret < 0) + return ret; + break; + case fwat_enum_default_value: + val_idx =3D data->default_idx; + break; + case fwat_enum_possible_values: + sz +=3D sysfs_emit_at(buf, sz, "%s", data->possible_vals[0]); + for (unsigned int i =3D 1; data->possible_vals[i]; i++) + sz +=3D sysfs_emit_at(buf, sz, ";%s", data->possible_vals[i]); + sz +=3D sysfs_emit_at(buf, sz, "\n"); + return sz; + default: + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%s\n", data->possible_vals[val_idx]); +} + +static ssize_t +enum_group_store(struct kobject *kobj, struct fwat_attribute *attr, const = char *buf, + size_t count) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_enum_data *data =3D to_fwat_enum_data(group->data); + int val_idx; + int ret; + + val_idx =3D __sysfs_match_string(data->possible_vals, -1, buf); + if (val_idx < 0) + return val_idx; + + ret =3D data->write(group->dev, data->group.id, val_idx); + if (ret) + return ret; + + return count; +} + +static ssize_t +int_group_show(struct kobject *kobj, struct fwat_attribute *attr, char *bu= f) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_int_data *data =3D to_fwat_int_data(group->data); + long val; + int ret; + + /* show_override does not affect current_value */ + if (data->group.show_override && attr->type !=3D fwat_int_current_value) + return data->group.show_override(group->dev, attr->type, buf); + + switch (attr->type) { + case fwat_int_current_value: + ret =3D data->read(group->dev, data->group.id, &val); + if (ret < 0) + return ret; + break; + case fwat_int_default_value: + val =3D data->default_val; + break; + case fwat_int_min_value: + val =3D data->min_val; + break; + case fwat_int_max_value: + val =3D data->max_val; + break; + case fwat_int_scalar_increment: + val =3D data->increment; + break; + default: + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%ld\n", val); +} + +static ssize_t +int_group_store(struct kobject *kobj, struct fwat_attribute *attr, const c= har *buf, + size_t count) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_int_data *data =3D to_fwat_int_data(group->data); + long val; + int ret; + + ret =3D kstrtol(buf, 0, &val); + if (ret) + return ret; + + ret =3D data->write(group->dev, data->group.id, val); + if (ret) + return ret; + + return count; +} + +static ssize_t +str_group_show(struct kobject *kobj, struct fwat_attribute *attr, char *bu= f) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_str_data *data =3D to_fwat_str_data(group->data); + const char *val; + long len; + int ret; + + /* show_override does not affect current_value */ + if (data->group.show_override && attr->type !=3D fwat_bool_current_value) + return data->group.show_override(group->dev, attr->type, buf); + + switch (attr->type) { + case fwat_str_current_value: + ret =3D data->read(group->dev, data->group.id, &val); + if (ret < 0) + return ret; + break; + case fwat_str_default_value: + val =3D data->default_val; + break; + case fwat_str_min_length: + len =3D data->min_len; + return sysfs_emit(buf, "%ld\n", len); + case fwat_str_max_length: + len =3D data->max_len; + return sysfs_emit(buf, "%ld\n", len); + default: + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%s\n", val); +} + +static ssize_t +str_group_store(struct kobject *kobj, struct fwat_attribute *attr, const c= har *buf, + size_t count) +{ + const struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_str_data *data =3D to_fwat_str_data(group->data); + int ret; + + ret =3D data->write(group->dev, data->group.id, buf); + if (ret) + return ret; + + return count; +} + +FWAT_ATTR_RO(all, display_name, display_name_show, FWAT_TYPE_NONE); +FWAT_ATTR_RO(all, display_name_language_code, display_name_language_code_s= how, FWAT_TYPE_NONE); + +FWAT_ATTR_RO(bool, type, type_show, fwat_group_boolean); +FWAT_ATTR_RW(bool, current_value, bool_group_show, bool_group_store, fwat_= bool_current_value); +FWAT_ATTR_RO(bool, default_value, bool_group_show, fwat_bool_default_value= ); + +FWAT_ATTR_RO(enum, type, type_show, fwat_group_enumeration); +FWAT_ATTR_RW(enum, current_value, enum_group_show, enum_group_store, fwat_= enum_current_value); +FWAT_ATTR_RO(enum, default_value, enum_group_show, fwat_enum_default_value= ); +FWAT_ATTR_RO(enum, possible_values, enum_group_show, fwat_enum_possible_va= lues); + +FWAT_ATTR_RO(int, type, type_show, fwat_group_integer); +FWAT_ATTR_RW(int, current_value, int_group_show, int_group_store, fwat_int= _current_value); +FWAT_ATTR_RO(int, default_value, int_group_show, fwat_int_default_value); +FWAT_ATTR_RO(int, min_value, int_group_show, fwat_int_min_value); +FWAT_ATTR_RO(int, max_value, int_group_show, fwat_int_max_value); +FWAT_ATTR_RO(int, scalar_increment, int_group_show, fwat_int_scalar_increm= ent); + +FWAT_ATTR_RO(str, type, type_show, fwat_group_string); +FWAT_ATTR_RW(str, current_value, str_group_show, str_group_store, fwat_int= _current_value); +FWAT_ATTR_RO(str, default_value, str_group_show, fwat_str_default_value); +FWAT_ATTR_RO(str, min_length, str_group_show, fwat_str_min_length); +FWAT_ATTR_RO(str, max_length, str_group_show, fwat_str_max_length); + +static struct attribute *fwat_bool_attrs[] =3D { + &fwat_bool_type_attr.attr, + &fwat_all_display_name_attr.attr, + &fwat_all_display_name_language_code_attr.attr, + &fwat_bool_current_value_attr.attr, + &fwat_bool_default_value_attr.attr, + NULL +}; + +static struct attribute *fwat_enum_attrs[] =3D { + &fwat_enum_type_attr.attr, + &fwat_all_display_name_attr.attr, + &fwat_all_display_name_language_code_attr.attr, + &fwat_enum_current_value_attr.attr, + &fwat_enum_default_value_attr.attr, + &fwat_enum_possible_values_attr.attr, + NULL +}; + +static struct attribute *fwat_int_attrs[] =3D { + &fwat_int_type_attr.attr, + &fwat_all_display_name_attr.attr, + &fwat_all_display_name_language_code_attr.attr, + &fwat_int_current_value_attr.attr, + &fwat_int_default_value_attr.attr, + &fwat_int_min_value_attr.attr, + &fwat_int_max_value_attr.attr, + &fwat_int_scalar_increment_attr.attr, + NULL +}; + +static struct attribute *fwat_str_attrs[] =3D { + &fwat_str_type_attr.attr, + &fwat_all_display_name_attr.attr, + &fwat_all_display_name_language_code_attr.attr, + &fwat_str_current_value_attr.attr, + &fwat_str_default_value_attr.attr, + &fwat_str_min_length_attr.attr, + &fwat_str_max_length_attr.attr, + NULL +}; + +static umode_t fwat_attr_visible(struct kobject *kobj, struct attribute *a= ttr, int n) +{ + struct fwat_attribute *fwat_attr =3D to_fwat_attribute(attr); + struct fwat_group *group =3D kobj_to_fwat_group(kobj); + const struct fwat_group_data *data =3D group->data; + + /* The `type` attribute is always first */ + if (n =3D=3D 0) + return attr->mode; + + if (attr =3D=3D &fwat_all_display_name_attr.attr) + return data->display_name ? attr->mode : 0; + + if (attr =3D=3D &fwat_all_display_name_language_code_attr.attr) + return data->language_code ? attr->mode : 0; + + /* The `current_value` attribute always has type =3D=3D 0 */ + if (!fwat_attr->type) + return data->mode; + + return test_bit(fwat_attr->type, &data->fattrs) ? attr->mode : 0; +} + +static umode_t fwat_group_visible(struct kobject *kobj) +{ + return true; +} + +DEFINE_SYSFS_GROUP_VISIBLE(fwat); + +static const struct attribute_group fwat_bool_group =3D { + .attrs =3D fwat_bool_attrs, + .is_visible =3D SYSFS_GROUP_VISIBLE(fwat), +}; +__ATTRIBUTE_GROUPS(fwat_bool); + +static const struct attribute_group fwat_enum_group =3D { + .attrs =3D fwat_enum_attrs, + .is_visible =3D SYSFS_GROUP_VISIBLE(fwat), +}; +__ATTRIBUTE_GROUPS(fwat_enum); + +static const struct attribute_group fwat_int_group =3D { + .attrs =3D fwat_int_attrs, + .is_visible =3D SYSFS_GROUP_VISIBLE(fwat), +}; +__ATTRIBUTE_GROUPS(fwat_int); + +static const struct attribute_group fwat_str_group =3D { + .attrs =3D fwat_str_attrs, + .is_visible =3D SYSFS_GROUP_VISIBLE(fwat), +}; +__ATTRIBUTE_GROUPS(fwat_str); + +static ssize_t +fwat_attr_sysfs_show(struct kobject *kobj, struct attribute *attr, char *b= uf) +{ + struct fwat_attribute *fwat_attr =3D to_fwat_attribute(attr); + + if (!fwat_attr->show) + return -EOPNOTSUPP; + + return fwat_attr->show(kobj, fwat_attr, buf); +} + +static ssize_t +fwat_attr_sysfs_store(struct kobject *kobj, struct attribute *attr, const = char *buf, + size_t count) +{ + struct fwat_attribute *fwat_attr =3D to_fwat_attribute(attr); + + if (!fwat_attr->show) + return -EOPNOTSUPP; + + return fwat_attr->store(kobj, fwat_attr, buf, count); +} + +static void fwat_group_release(struct kobject *kobj) +{ + struct fwat_group *group =3D kobj_to_fwat_group(kobj); + + kfree(group); +} + +static const struct sysfs_ops fwat_attr_sysfs_ops =3D { + .show =3D fwat_attr_sysfs_show, + .store =3D fwat_attr_sysfs_store, +}; + +static const struct kobj_type fwat_boolean_ktype =3D { + .sysfs_ops =3D &fwat_attr_sysfs_ops, + .release =3D fwat_group_release, + .default_groups =3D fwat_bool_groups, +}; + +static const struct kobj_type fwat_enumeration_ktype =3D { + .sysfs_ops =3D &fwat_attr_sysfs_ops, + .release =3D fwat_group_release, + .default_groups =3D fwat_enum_groups, +}; + +static const struct kobj_type fwat_integer_ktype =3D { + .sysfs_ops =3D &fwat_attr_sysfs_ops, + .release =3D fwat_group_release, + .default_groups =3D fwat_int_groups, +}; + +static const struct kobj_type fwat_string_ktype =3D { + .sysfs_ops =3D &fwat_attr_sysfs_ops, + .release =3D fwat_group_release, + .default_groups =3D fwat_str_groups, +}; + +static int __fwat_create_group(struct fwat_device *fadev, const struct kob= j_type *ktype, + const struct fwat_group_data *data) +{ + struct fwat_group *group; + int ret; + + group =3D kzalloc(sizeof(*group), GFP_KERNEL); + if (!group) + return -ENOMEM; + + group->dev =3D &fadev->dev; + group->data =3D data; + + group->kobj.kset =3D fadev->attrs_kset; + ret =3D kobject_init_and_add(&group->kobj, ktype, NULL, "%s", data->name); + if (ret) { + kobject_put(&group->kobj); + return ret; + } + + kobject_uevent(&group->kobj, KOBJ_ADD); + + return 0; +} + +static void fwat_remove_auto_groups(struct fwat_device *fadev) +{ + struct kobject *pos, *n; + + list_for_each_entry_safe(pos, n, &fadev->attrs_kset->list, entry) + kobject_put(pos); +} + +int fwat_create_bool_group(struct fwat_device *fadev, const struct fwat_bo= ol_data *data) +{ + return __fwat_create_group(fadev, &fwat_boolean_ktype, &data->group); +} +EXPORT_SYMBOL_GPL(fwat_create_bool_group); + +int fwat_create_enum_group(struct fwat_device *fadev, const struct fwat_en= um_data *data) +{ + return __fwat_create_group(fadev, &fwat_enumeration_ktype, &data->group); +} +EXPORT_SYMBOL_GPL(fwat_create_enum_group); + +int fwat_create_int_group(struct fwat_device *fadev, const struct fwat_int= _data *data) +{ + return __fwat_create_group(fadev, &fwat_integer_ktype, &data->group); +} +EXPORT_SYMBOL_GPL(fwat_create_int_group); + +int fwat_create_str_group(struct fwat_device *fadev, const struct fwat_str= _data *data) +{ + return __fwat_create_group(fadev, &fwat_string_ktype, &data->group); +} +EXPORT_SYMBOL_GPL(fwat_create_str_group); + /** * fwat_device_register - Create and register a firmware-attributes class * device @@ -89,6 +620,7 @@ void fwat_device_unregister(struct fwat_device *fadev) if (!fadev) return; =20 + fwat_remove_auto_groups(fadev); sysfs_remove_groups(&fadev->attrs_kset->kobj, fadev->groups); kset_unregister(fadev->attrs_kset); device_unregister(&fadev->dev); diff --git a/drivers/platform/x86/firmware_attributes_class.h b/drivers/pla= tform/x86/firmware_attributes_class.h index 4ae700eec1e586e1f9ed96bd6e3843342381816d..744fc9ef6055e466caa30b3bc8e= 23097f8f2dd58 100644 --- a/drivers/platform/x86/firmware_attributes_class.h +++ b/drivers/platform/x86/firmware_attributes_class.h @@ -10,6 +10,7 @@ #include #include #include +#include =20 extern const struct class firmware_attributes_class; =20 @@ -27,6 +28,340 @@ struct fwat_device { =20 #define to_fwat_device(_d) container_of_const(_d, struct fwat_device, dev) =20 +enum fwat_group_type { + fwat_group_boolean, + fwat_group_enumeration, + fwat_group_integer, + fwat_group_string, +}; + +enum fwat_bool_attrs { + fwat_bool_current_value, + fwat_bool_default_value, + fwat_bool_attrs_last +}; + +#define FWAT_BOOL_CURRENT_VALUE BIT(fwat_bool_current_value) +#define FWAT_BOOL_DEFAULT_VALUE BIT(fwat_bool_default_value) +#define FWAT_BOOL_ALL_ATTRS GENMASK(fwat_bool_attrs_last, 0) + +enum fwat_enum_attrs { + fwat_enum_current_value, + fwat_enum_default_value, + fwat_enum_possible_values, + fwat_enum_attrs_last +}; + +#define FWAT_ENUM_CURRENT_VALUE BIT(fwat_enum_current_value) +#define FWAT_ENUM_DEFAULT_VALUE BIT(fwat_enum_default_value) +#define FWAT_ENUM_POSSIBLE_VALUES BIT(fwat_enum_possible_values) +#define FWAT_ENUM_ALL_ATTRS GENMASK(fwat_enum_attrs_last, 0) + +enum fwat_int_attrs { + fwat_int_current_value, + fwat_int_default_value, + fwat_int_min_value, + fwat_int_max_value, + fwat_int_scalar_increment, + fwat_int_attrs_last +}; + +#define FWAT_INT_CURRENT_VALUE BIT(fwat_int_current_value) +#define FWAT_INT_DEFAULT_VALUE BIT(fwat_int_default_value) +#define FWAT_INT_MIN_VALUE BIT(fwat_int_min_value) +#define FWAT_INT_MAX_VALUE BIT(fwat_int_max_value) +#define FWAT_INT_SCALAR_INCREMENT BIT(fwat_int_scalar_increment) +#define FWAT_INT_ALL_ATTRS GENMASK(fwat_int_attrs_last, 0) + +enum fwat_str_attrs { + fwat_str_current_value, + fwat_str_default_value, + fwat_str_min_length, + fwat_str_max_length, + fwat_str_attrs_last +}; + +#define FWAT_STR_CURRENT_VALUE BIT(fwat_str_current_value) +#define FWAT_STR_DEFAULT_VALUE BIT(fwat_str_default_value) +#define FWAT_STR_MIN_LENGTH BIT(fwat_str_min_length) +#define FWAT_STR_MAX_LENGTH BIT(fwat_str_max_length) +#define FWAT_STR_ALL_ATTRS GENMASK(fwat_str_attrs_last, 0) + +static_assert(fwat_bool_current_value =3D=3D 0); +static_assert(fwat_enum_current_value =3D=3D 0); +static_assert(fwat_int_current_value =3D=3D 0); +static_assert(fwat_str_current_value =3D=3D 0); + +/** + * struct fwat_group_data - Data struct common between group types + * @id: Group ID defined by the user. + * @name: Name of the group. + * @display_name: Name showed in the display_name attribute. (Optional) + * @language_code: Language code showed in the display_name_language_code + * attribute. (Optional) + * @mode: Mode for the current_value attribute. All other attributes will = have + * 0444 permissions. + * @fattrs: Bitmap of selected attributes for this group type. + * @show_override: Custom show method for attributes in this group, except= for + * the current_value attribute, for which the a `read` callback + * will still be used. (Optional) + * + * NOTE: This struct is not meant to be defined directly. It is supposed t= o be + * embedded and defined as part of fwat_[type]_data structs. + */ +struct fwat_group_data { + long id; + umode_t mode; + const char *name; + const char *display_name; + const char *language_code; + unsigned long fattrs; + ssize_t (*show_override)(struct device *dev, int type, char *buf); +}; + +/** + * struct fwat_bool_data - Data struct for the boolean group type + * @read: Read callback for the current_value attribute. + * @write: Write callback for the current_value attribute. + * @default_val: Default value. + * @group: Group data. + */ +struct fwat_bool_data { + int (*read)(struct device *dev, long id, bool *val); + int (*write)(struct device *dev, long id, bool val); + bool default_val; + struct fwat_group_data group; +}; + +/** + * struct fwat_enum_data - Data struct for the enumeration group type + * @read: Read callback for the current_value attribute. + * @write: Write callback for the current_value attribute. + * @default_idx: Index of the default value in the @possible_vals array. + * @possible_vals: Array of possible value strings for this group type. + * @group: Group data. + * + * NOTE: The `val_idx` argument in the @write callback is guaranteed to be= a + * valid (within bounds) index. However, the user is in charge of wr= iting + * valid indexes to the `*val_idx` argument of the @read callback. + * Failing to do so may result in an OOB access. + */ +struct fwat_enum_data { + int (*read)(struct device *dev, long id, int *val_idx); + int (*write)(struct device *dev, long id, int val_idx); + int default_idx; + const char * const *possible_vals; + struct fwat_group_data group; +}; + +/** + * struct fwat_int_data - Data struct for the integer group type + * @read: Read callback for the current_value attribute. + * @write: Write callback for the current_value attribute. + * @default_val: Default value. + * @min_val: Minimum value. + * @max_val: Maximum value. + * @increment: Scalar increment for this value. + * @group: Group data. + * + * NOTE: The @min_val, @max_val, @increment constraints are merely informa= tive. + * These values are not enforced in any of the callbacks. + */ +struct fwat_int_data { + int (*read)(struct device *dev, long id, long *val); + int (*write)(struct device *dev, long id, long val); + long default_val; + long min_val; + long max_val; + long increment; + struct fwat_group_data group; +}; + +/** + * struct fwat_str_data - Data struct for the string group type + * @read: Read callback for the current_value attribute. + * @write: Write callback for the current_value attribute. + * @default_val: Default value. + * @min_len: Minimum string length. + * @max_len: Maximum string length. + * @group: Group data. + * + * NOTE: The @min_len, @max_len constraints are merely informative. These + * values are not enforced in any of the callbacks. + */ +struct fwat_str_data { + int (*read)(struct device *dev, long id, const char **buf); + int (*write)(struct device *dev, long id, const char *buf); + const char *default_val; + long min_len; + long max_len; + struct fwat_group_data group; +}; + +#define __FWAT_GROUP(_name, _disp_name, _mode, _fattrs) \ + { .name =3D __stringify(_name), .display_name =3D _disp_name, .mode =3D _= mode, .fattrs =3D _fattrs } + +/** + * DEFINE_FWAT_BOOL_GROUP - Convenience macro to quickly define an static + * struct fwat_bool_data instance + * @_name: Name of the group. + * @_disp_name: Name showed in the display_name attribute. (Optional) + * @_def_val: Default value. + * @_mode: Mode for the current_value attribute. All other attributes will= have + * 0444 permissions. + * @_fattrs: Bitmap of selected attributes for this group type. + * + * `read` and `write` callbacks are required to be already defined as + * `_name##_read` and `_name##_write` respectively. + */ +#define DEFINE_FWAT_BOOL_GROUP(_name, _disp_name, _def_val, _mode, _fattrs= ) \ + static const struct fwat_bool_data _name##_group_data =3D { \ + .read =3D _name##_read, \ + .write =3D _name##_write, \ + .default_val =3D _def_val, \ + .group =3D __FWAT_GROUP(_name, _disp_name, _mode, _fattrs), \ + } + +/** + * DEFINE_FWAT_ENUM_GROUP - Convenience macro to quickly define an static + * struct fwat_enum_data instance + * @_name: Name of the group. + * @_disp_name: Name showed in the display_name attribute. (Optional) + * @_def_idx: Index of the default value in the @_poss_vals array. + * @_poss_vals: Array of possible value strings for this group type. + * @_mode: Mode for the current_value attribute. All other attributes will= have + * 0444 permissions. + * @_fattrs: Bitmap of selected attributes for this group type. + * + * `read` and `write` callbacks are required to be already defined as + * `_name##_read` and `_name##_write` respectively. + * + * NOTE: The `val_idx` argument in the `write` callback is guaranteed to b= e a + * valid (within bounds) index. However, the user is in charge of wr= iting + * valid indexes to the `*val_idx` argument of the `read` callback. + * Failing to do so may result in an OOB access. + */ +#define DEFINE_FWAT_ENUM_GROUP(_name, _disp_name, _poss_vals, _def_idx, _m= ode, _fattrs) \ + static const struct fwat_enum_data _name##_group_data =3D { \ + .read =3D _name##_read, \ + .write =3D _name##_write, \ + .default_idx =3D _def_idx, \ + .possible_vals =3D _poss_vals, \ + .group =3D __FWAT_GROUP(_name, _disp_name, _mode, _fattrs), \ + } + +/** + * DEFINE_FWAT_INT_GROUP - Convenience macro to quickly define an static + * struct fwat_int_data instance + * @_name: Name of the group. + * @_disp_name: Name showed in the display_name attribute. (Optional) + * @_def_val: Default value. + * @_min: Minimum value. + * @_max: Maximum value. + * @_inc: Scalar increment for this value. + * @_mode: Mode for the current_value attribute. All other attributes will= have + * 0444 permissions. + * @_fattrs: Bitmap of selected attributes for this group type. + * + * `read` and `write` callbacks are required to be already defined as + * `_name##_read` and `_name##_write` respectively. + * + * NOTE: The @_min, @_max, @_inc constraints are merely informative. These + * values are not enforced in any of the callbacks. + */ +#define DEFINE_FWAT_INT_GROUP(_name, _disp_name, _def_val, _min, _max, _in= c, _mode, _fattrs) \ + static const struct fwat_int_data _name##_group_data =3D { \ + .read =3D _name##_read, \ + .write =3D _name##_write, \ + .default_val =3D _def_val, \ + .min_val =3D _min, \ + .max_val =3D _max, \ + .increment =3D _inc, \ + .group =3D __FWAT_GROUP(_name, _disp_name, _mode, _fattrs), \ + } + +/** + * DEFINE_FWAT_STR_GROUP - Convenience macro to quickly define an static + * struct fwat_str_data instance + * @_name: Name of the group. + * @_disp_name: Name showed in the display_name attribute. (Optional) + * @_def_val: Default value. + * @_min: Minimum string length. + * @_max: Maximum string length. + * @_mode: Mode for the current_value attribute. All other attributes will= have + * 0444 permissions. + * @_fattrs: Bitmap of selected attributes for this group type. + * + * `read` and `write` callbacks are required to be already defined as + * `_name##_read` and `_name##_write` respectively. + * + * NOTE: The @_min, @_max constraints are merely informative. These values= are + * not enforced in any of the callbacks. + */ +#define DEFINE_FWAT_STR_GROUP(_name, _disp_name, _def_val, _min, _max, _mo= de, _fattrs) \ + static const struct fwat_str_data _name##_group_data =3D { \ + .read =3D _name##_read, \ + .write =3D _name##_write, \ + .default_val =3D _def_val, \ + .min_len =3D _min, \ + .max_len =3D _max, \ + .group =3D __FWAT_GROUP(_name, _disp_name, _mode, _fattrs), \ + } + +int fwat_create_bool_group(struct fwat_device *fadev, + const struct fwat_bool_data *data); +int fwat_create_enum_group(struct fwat_device *fadev, + const struct fwat_enum_data *data); +int fwat_create_int_group(struct fwat_device *fadev, + const struct fwat_int_data *data); +int fwat_create_str_group(struct fwat_device *fadev, + const struct fwat_str_data *data); + +/** + * fwat_create_group - Convenience generic macro to create a group + * @_dev: fwat_device + * @_data: One of fwat_{bool,enum,int,str}_data instance + * + * This macro (and associated functions) creates a sysfs group under the + * 'attributes' directory, which is located in the class device root direc= tory. + * + * See Documentation/ABI/testing/sysfs-class-firmware-attributes for detai= ls. + * + * The @_data associated with this group may be created either statically, + * through DEFINE_FWAT_*_GROUP macros or dynamically, in which case the us= er + * would have allocate and fill the struct manually. The dynamic approach = should + * be preferred when group constraints and/or visibility is decided dynami= cally. + * + * Example: + * + * static int stat_read(...){...}; + * static int stat_write(...){...}; + * + * DEFINE_FWAT_(BOOL|ENUM|INT|STR)_GROUP(stat, ...); + * + * static int create_groups(struct fwat_device *fadev) + * { + * struct fwat_enum_data *dyn_group_data; + * + * dyn_group_data =3D kzalloc(...); + * // Fill the data + * ... + * fwat_create_group(fadev, &stat_group_data); + * fwat_create_group(fadev, &dyn_group_data); + * fwat_create_group(...); + * ... + * } + * + * Return: 0 on success, -errno on failure + */ +#define fwat_create_group(_dev, _data) \ + _Generic((_data), \ + const struct fwat_bool_data * : fwat_create_bool_group, \ + const struct fwat_enum_data * : fwat_create_enum_group, \ + const struct fwat_int_data * : fwat_create_int_group, \ + const struct fwat_str_data * : fwat_create_str_group) \ + (_dev, _data) + struct fwat_device * __must_check fwat_device_register(struct device *parent, const char *name, void *data, const struct attribute_group **groups); --=20 2.50.0 From nobody Wed Oct 8 09:04:35 2025 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25DDA24290B; Mon, 30 Jun 2025 08:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270519; cv=none; b=UJNis2kxtjn1QnM0mv5gY6KxT5pr1MaDG1yj2RZpkEV2ovrURLpyBrmhU7ys9gPt3pgPw87wDN4zeh2gnH1B7TckYr1UyxUTNFzjBGtggNT7SXwGDzvWmvZ1evLkLJCQYuq7ck3/NaX/Ke23gt4btoFK6Iq9z3tWIrRTHUGpCes= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270519; c=relaxed/simple; bh=1/uY3FjgYDtVpBV5UgGBGxzO4C9dj7R2QKPSjyd0w4E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ayL19GpXLdKyn4K3MSSSbKy9DlcNhyAIt2E2pntOnp6lmgZN9lWD3g3Wk4u3dXr+BNM2zrcvU9NoldDJFW2sTnDRPzNUBHqK0mTZP62AFOMrt7VjpR0de8IVn1oULG+goG8+eKaUEcItExfAADlGuO2FemopSBXjjXiQMH+YVE4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J3LD/dPg; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J3LD/dPg" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6fd0a3cd326so23137246d6.1; Mon, 30 Jun 2025 01:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751270517; x=1751875317; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Whn+81gfDlilc+limqNRyBz7Xbl+U+qQ54Hz3BONpwk=; b=J3LD/dPgZ4Wy4vdef/w+Id5cNvZ3/JDRHDc78hDIj3FC/5oO2lWWZTphb9vK1LRPUm xUl/a+EI/ZV/qPZTWjKrDzL7s6VgYRV4C1sDZY/zeHDvm1bUn8PQ4Ojng5ihbEqp0LKW xKyGVX81TUBVZ8r1wAIa3CNmbqfRUAB6JVIbIcNfuv498qelVZAw/rJ68Mw9Fwh7eAHs HDIfOZfHA+UWEmBJo/b1aWfiAHmeJfQGxfPVgP7Ipjk+XNM6lpqSRIRTcmjrPOtnJ6Oz 93Ocbxm/4DNbrqvOc1X5Ssdufcj9jFIHxgApbJDDBA26i4eoaJrByU7Z7OSmyQBpOC6d lqJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751270517; x=1751875317; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Whn+81gfDlilc+limqNRyBz7Xbl+U+qQ54Hz3BONpwk=; b=lrFI8TwRZp5w8yU+2e6YQe5tpYM4Zg0oT96s1DmdtH2t5u3lxIYjH6oDrjAAjsE0Ju +qgxuNLyh5Y31B+iFA+GijC+QR5xMsWFLNe53vH0SX/e7Uq37MHvW9ETc9figC4V6f4/ 8FD959C9GDpm5P56Uq2nUSToca6QJN7SvF2g2lOW0kBPrZXTgFPPx5+vNAN6hJXk5Fd4 LRqGugGpuwUq5Z4OK0/y64vVVXgHc3F1m+soDJyCNhTcH4nXXCaWdM1t1WbGhOtuux9X 9YVKJ7e8aTeaH/DjfpUMHnvn25aEb05ovJe/Z6CRJbScZzVyJ4Y0lrqpmNHrASKRdWEX OUlg== X-Forwarded-Encrypted: i=1; AJvYcCVeK9C/PXncMyfyeZ0mXnb/B+MZCGH1YSmVDshvDWXP6xxhaGMWoRQ0T4zC60IaWQ5Yy4yO7oXgp6BG+XY=@vger.kernel.org, AJvYcCXEpiXL0oYz/tehU96441XqbMkuLdoQwDX5ipI/qdtVwB83PrNFoLRIvFg3w+/sX9hP7RJvQmoPj98wRBpUQctb27rI/g==@vger.kernel.org X-Gm-Message-State: AOJu0YyurlHlX75Zdl8IMYjLF3vQ5KDst4u6n9ZDrLX4lEP+eayEd0F+ LiBg7yRZLQPRAifpgSGGEaR9d/vEcIVkOXZCiu3W9NOIJfyrZqsJEw7z X-Gm-Gg: ASbGncveDIJx401jZePYoBjopZ0qP2ZUkXUGfn5Q94D12WNR2TWa/Unds8ojTzmBIa3 x6hZl08BKl9rwSTRcK0YE3PF6F4vnZIjpCB8E/ZnLeVnxXoT2lNheNzSgO1v09LRCj/A0A82svb 6Mf6aJJDHU6eGYkR+XSuJS6mQPB4WopdHg3M2RYKhz4WP+NttxLWGa2mA/Az8YYTgTHmQ2tOcxT Ro2+ReDBmU49b7uymiurutn+hvcqJQv/4QaF582uzhEumodZUBbpqO25ThMgG3WuS92ywXzsY/M rGcsaJLrUrODDKPuGbvUhhWXU7veqUScKIiC4w4g3CmYVAXWuNkeelrxNTzqqg== X-Google-Smtp-Source: AGHT+IHzODiFqjh2agzMecnsqWzAYvk8YwCXgRhF7MhOXYuSwJ7MXqPuK+QBrPXdM3fpz2ViJvBKPA== X-Received: by 2002:a05:6214:2a8e:b0:6fa:fd8b:54de with SMTP id 6a1803df08f44-70002915ae5mr190685226d6.30.1751270516816; Mon, 30 Jun 2025 01:01:56 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd772df637sm63677026d6.79.2025.06.30.01.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 01:01:56 -0700 (PDT) From: Kurt Borja Date: Mon, 30 Jun 2025 05:01:10 -0300 Subject: [PATCH v4 3/6] platform/x86: firmware_attributes_class: Move header to include directory Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250630-fw-attrs-api-v4-3-1a04952b255f@gmail.com> References: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> In-Reply-To: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3715; i=kuurtb@gmail.com; h=from:subject:message-id; bh=1/uY3FjgYDtVpBV5UgGBGxzO4C9dj7R2QKPSjyd0w4E=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBlJLsk3/ssIsGTOduz+w3WK+fTX7Q5hZ54U+Z95dF/g+ bdzTs0vOkpZGMS4GGTFFFnaExZ9exSV99bvQOh9mDmsTCBDGLg4BWAiOxcwMmyKk9vFPunz8QZ3 c/s1UupK4VJyqy82LtC37l2mmsSYYMjwv5bDVUtr37GytKBtu4okisufhRarS2xrn9V4TN0wOqG QCQA= X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Move firmware_attributes_class.h to include/linux/ to avoid hardcoding paths inside drivers/platform/x86/. Signed-off-by: Kurt Borja --- drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 2 +- drivers/platform/x86/firmware_attributes_class.c | 2 +- drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 2 +- drivers/platform/x86/lenovo/think-lmi.c | 2 +- drivers/platform/x86/samsung-galaxybook.c | 2 +- {drivers/platform/x86 =3D> include/linux}/firmware_attributes_class.h | 0 6 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/p= latform/x86/dell/dell-wmi-sysman/sysman.c index d00389b860e4ea0655c740c78bc3751f323b6370..3aec09987ab145508ed05b02e61= a6d94edf79484 100644 --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c @@ -12,8 +12,8 @@ #include #include #include +#include #include "dell-wmi-sysman.h" -#include "../../firmware_attributes_class.h" =20 #define MAX_TYPES 4 #include diff --git a/drivers/platform/x86/firmware_attributes_class.c b/drivers/pla= tform/x86/firmware_attributes_class.c index 86d2a8bf4bb9debc81e38c928c5a3eb5a440cc18..4e7938b6f1ad4ab3fa5f5ecc560= 305a3fca4d57b 100644 --- a/drivers/platform/x86/firmware_attributes_class.c +++ b/drivers/platform/x86/firmware_attributes_class.c @@ -11,7 +11,7 @@ #include #include #include -#include "firmware_attributes_class.h" +#include =20 #define FWAT_TYPE_NONE -1 =20 diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platfor= m/x86/hp/hp-bioscfg/bioscfg.c index 13237890fc92002e7e730b1c235ddf068a6737cd..2df31af8a3b4ac88710af1fae2d= 5dabbb3185f1d 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c @@ -12,7 +12,7 @@ #include #include #include "bioscfg.h" -#include "../../firmware_attributes_class.h" +#include #include #include =20 diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86= /lenovo/think-lmi.c index 34a47269e3d34d2eda6b71af73892656cd2bf67d..f61a6287eb0ebe9ac4c0c9445c3= b54c12b276691 100644 --- a/drivers/platform/x86/lenovo/think-lmi.c +++ b/drivers/platform/x86/lenovo/think-lmi.c @@ -20,7 +20,7 @@ #include #include #include -#include "../firmware_attributes_class.h" +#include #include "think-lmi.h" =20 static bool debug_support; diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x= 86/samsung-galaxybook.c index 5878a351993eb05a4c5c2c75b4915d972ce9becc..9a5a7b956a9f6a2738470e83ce9= 3f4cccf4bf3b4 100644 --- a/drivers/platform/x86/samsung-galaxybook.c +++ b/drivers/platform/x86/samsung-galaxybook.c @@ -28,7 +28,7 @@ #include #include #include -#include "firmware_attributes_class.h" +#include =20 #define DRIVER_NAME "samsung-galaxybook" =20 diff --git a/drivers/platform/x86/firmware_attributes_class.h b/include/lin= ux/firmware_attributes_class.h similarity index 100% rename from drivers/platform/x86/firmware_attributes_class.h rename to include/linux/firmware_attributes_class.h --=20 2.50.0 From nobody Wed Oct 8 09:04:35 2025 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E734242D76; Mon, 30 Jun 2025 08:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270524; cv=none; b=EyRKYKGM7Ugw7IhRVl0GJu5yPoNtjk2k3+OStu5YRZXDENvXtI5TuNaCXXHD9Fj6aeKgw/xADNXCt3s10h0vYz3V74ZTpMAU+U7NlpisunS38UY0zpTddL0fxYm/Ll9O8IrB2S+Y6dH8N3MCcSCJ8ep8hCKq2TbKZH21b/sT2XM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270524; c=relaxed/simple; bh=liILi0h70NtnHMaTrnZq1JtW1kl+WBBQwRBtx4jqqqU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=W3/JlZ+NiV8PSTFpPgQHEbH7KViCn9Z2NR3yIX/AB+HsBERT76phdbOB8CY9Q2mT3IQp9OAqLt1rgv0RhZEnA5p5dIFCt+POBXvOnr4ZgE6S9wjj/9uNs2kr/0kzr1ruiAKRxsK/Lc1u84Nva1aYPDYNGpbDvpRcefHKxYyFVPc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KeRG9qk7; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KeRG9qk7" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7d3f192a64eso381014385a.2; Mon, 30 Jun 2025 01:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751270521; x=1751875321; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=K2/KSwnwApNBj2qg4eJFgFllM2G5u9JrEk978fuXLkk=; b=KeRG9qk7YxNJexqBFwir5APGPiCsRdvGUhbA11evtKV54tz9emegvh5+GUj2TRbR0K 6pKMG1dJDea1nsMynfRg3xyOoSCtFeuYQKXHXobCv1KxHP/jJZHc27ajFXPMQbnUorGw j9oJB4B88Xkvp2/a95OGf70PIz0RfoKKLOaxspcyKJgvk1egqyi9qiiOmx1nIlCPWc8Z xpDbhfS3SG2VqAEjInDIM9lE6F9z5DEoxlZ/wsAskYzpqXKw9VZR3pN3JxSctgsNhVbp p2e4aKglG2uUOpTPykrsTj34jdOHXXC/lgOxUcUQryclkGgqXxnvJJT7oe13ZXWRPSY+ DEkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751270521; x=1751875321; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K2/KSwnwApNBj2qg4eJFgFllM2G5u9JrEk978fuXLkk=; b=uN1SWSvSXcQKtd+6ihFIiEdxnucKMKZMNTQl3/S//ninVK0H5aauKnr4f6myLBtk3X TOc2aLw8qnMpXEgWGCmCC0NgZ9wbqjeuywMH8gJZkETIEF6mD+ci/rdfn2cdlNqo+Yjv DLN2UulNHQSnC5nZkUedim4KlT2JkSeO0a9JWA3HQDAgr86cHi8ovnT0ks+utQ2z5P+B Z64V+EI9akJzxnemx6pFYqf/WCoIG8Gu0NDl1ztWwGgfZnJY33Xe9v1NisJD0HaiYGsl s32wK8KITOxCvf6MXVLnEzrH1CMBjtlZst34v3AyhlZX29/+07acnoOImXoaaloDFvOL gQxw== X-Forwarded-Encrypted: i=1; AJvYcCVpWKsAjuTxiLoExfxToAebmUVmNCJr6K4kzgHVeFfsudlciuE/1IZoLvb2d8xkV8naQfHg8tZ1I39pDUM=@vger.kernel.org, AJvYcCWfh9PTagGri3sh9B8KRJUCXixLuoMgqjekSKL8BCDqLaW8altHePAJMT9HhvPQWakoi5tVetRwohm2L2x7YG0R4fyKzg==@vger.kernel.org X-Gm-Message-State: AOJu0Yy50zRzSxCT8kgYG4O0lAw4LCfp4ywDoMM2gC0KQZZc+w/D12yk olsppTpWbWj9Yp/QduxmY9ucmswNKwcK/EoLlYPvSBOysWhj9ZXi5rLK X-Gm-Gg: ASbGnct0BJA1nXii6x5GMV00ihrWkYnbdiY3Xw/nqcNPTcZCIRvFJLnXd7ZuJjo8b3u AjqriuFQ33hcBc2Fjutux0hnAMfCF1UQ98GNBwHx0pMsdbJ9OL8XW7L/AHlYhlxSHI1GB5I8knM SKmvXZE67y7mvl9qnu+gcEqFyl2BxiJ+2BNr5rkOweiBNyoS85mNCWlbFIBQcW4E1sffF6e8oWE 6THAYF3p4Xojnd5GeEkP0THn9vxkZ2Lqs7/AMMMcVMiR7WIUl7hDqPT3vf2r6seawtLucggnLF4 eYZ179LkVprA5shV+md92mCkh5SL9gRVzio97RGdJjyXFnyYkBohWunj3+sd4EMMBKl7jLYA X-Google-Smtp-Source: AGHT+IGi948axwW3grs/bp+26eYMfDmth0LKYtJPzBATa5xws7sjcNEmZBpdKS9xlkZrBJT50LStqQ== X-Received: by 2002:a05:620a:2910:b0:7d3:8da2:e9e2 with SMTP id af79cd13be357-7d443990ab8mr1720530085a.27.1751270521143; Mon, 30 Jun 2025 01:02:01 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd772df637sm63677026d6.79.2025.06.30.01.01.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 01:02:00 -0700 (PDT) From: Kurt Borja Date: Mon, 30 Jun 2025 05:01:11 -0300 Subject: [PATCH v4 4/6] platform/x86: samsung-galaxybook: Transition new firmware_attributes API Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250630-fw-attrs-api-v4-4-1a04952b255f@gmail.com> References: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> In-Reply-To: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=10903; i=kuurtb@gmail.com; h=from:subject:message-id; bh=liILi0h70NtnHMaTrnZq1JtW1kl+WBBQwRBtx4jqqqU=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBlJLskW2oYR7au2XeWV7Lb+PJt3/rV7XDGFroZWC/MM+ h43ll/tKGVhEONikBVTZGlPWPTtUVTeW78Dofdh5rAygQxh4OIUgIlsa2Fk+Mxx7p1TyWu93Ev2 fxQLL6y2bVlz+objEdVnl1OCPBU0fBj+qa900ikvFKi8YfSdsZKHpW/fNnfrw692HZfw2fohS/c RLwA= X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Transition to new firmware_attributes API. Defining firmware_attributes groups statically through DEFINE_FWAT_ENUM_GROUP() incurs in a minor ABI change. In particular the display_name_language_code attribute is no longer created. Fortunately, this doesn't break user-space compatibility, because this attribute is not required, neither by the ABI specification nor by user-space tools. Signed-off-by: Kurt Borja --- drivers/platform/x86/samsung-galaxybook.c | 244 ++++++++------------------= ---- 1 file changed, 61 insertions(+), 183 deletions(-) diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x= 86/samsung-galaxybook.c index 9a5a7b956a9f6a2738470e83ce93f4cccf4bf3b4..d1db2a3f716aafc5a314f2bdc57= f7c958a9ae346 100644 --- a/drivers/platform/x86/samsung-galaxybook.c +++ b/drivers/platform/x86/samsung-galaxybook.c @@ -36,8 +36,6 @@ struct samsung_galaxybook { struct platform_device *platform; struct acpi_device *acpi; =20 - struct device *fw_attrs_dev; - struct kset *fw_attrs_kset; /* block in case firmware attributes are updated in multiple threads */ struct mutex fw_attr_lock; =20 @@ -60,36 +58,6 @@ struct samsung_galaxybook { u8 profile_performance_modes[PLATFORM_PROFILE_LAST]; }; =20 -enum galaxybook_fw_attr_id { - GB_ATTR_POWER_ON_LID_OPEN, - GB_ATTR_USB_CHARGING, - GB_ATTR_BLOCK_RECORDING, -}; - -static const char * const galaxybook_fw_attr_name[] =3D { - [GB_ATTR_POWER_ON_LID_OPEN] =3D "power_on_lid_open", - [GB_ATTR_USB_CHARGING] =3D "usb_charging", - [GB_ATTR_BLOCK_RECORDING] =3D "block_recording", -}; - -static const char * const galaxybook_fw_attr_desc[] =3D { - [GB_ATTR_POWER_ON_LID_OPEN] =3D "Power On Lid Open", - [GB_ATTR_USB_CHARGING] =3D "USB Charging", - [GB_ATTR_BLOCK_RECORDING] =3D "Block Recording", -}; - -#define GB_ATTR_LANGUAGE_CODE "en_US.UTF-8" - -struct galaxybook_fw_attr { - struct samsung_galaxybook *galaxybook; - enum galaxybook_fw_attr_id fw_attr_id; - struct attribute_group attr_group; - struct kobj_attribute display_name; - struct kobj_attribute current_value; - int (*get_value)(struct samsung_galaxybook *galaxybook, bool *value); - int (*set_value)(struct samsung_galaxybook *galaxybook, const bool value); -}; - struct sawb { u16 safn; u16 sasb; @@ -908,193 +876,106 @@ static int galaxybook_block_recording_init(struct s= amsung_galaxybook *galaxybook =20 /* Firmware Attributes setup */ =20 -static ssize_t type_show(struct kobject *kobj, struct kobj_attribute *attr= , char *buf) +static const char * const galaxybook_possible_vals[] =3D { + [false] =3D "0", [true] =3D "1", NULL +}; + +static int power_on_lid_open_read(struct device *dev, long id, int *val_id= x) { - return sysfs_emit(buf, "enumeration\n"); -} - -static struct kobj_attribute fw_attr_type =3D __ATTR_RO(type); - -static ssize_t default_value_show(struct kobject *kobj, struct kobj_attrib= ute *attr, char *buf) -{ - return sysfs_emit(buf, "0\n"); -} - -static struct kobj_attribute fw_attr_default_value =3D __ATTR_RO(default_v= alue); - -static ssize_t possible_values_show(struct kobject *kobj, struct kobj_attr= ibute *attr, char *buf) -{ - return sysfs_emit(buf, "0;1\n"); -} - -static struct kobj_attribute fw_attr_possible_values =3D __ATTR_RO(possibl= e_values); - -static ssize_t display_name_language_code_show(struct kobject *kobj, struc= t kobj_attribute *attr, - char *buf) -{ - return sysfs_emit(buf, "%s\n", GB_ATTR_LANGUAGE_CODE); -} - -static struct kobj_attribute fw_attr_display_name_language_code =3D - __ATTR_RO(display_name_language_code); - -static ssize_t display_name_show(struct kobject *kobj, struct kobj_attribu= te *attr, char *buf) -{ - struct galaxybook_fw_attr *fw_attr =3D - container_of(attr, struct galaxybook_fw_attr, display_name); - - return sysfs_emit(buf, "%s\n", galaxybook_fw_attr_desc[fw_attr->fw_attr_i= d]); -} - -static ssize_t current_value_show(struct kobject *kobj, struct kobj_attrib= ute *attr, char *buf) -{ - struct galaxybook_fw_attr *fw_attr =3D - container_of(attr, struct galaxybook_fw_attr, current_value); - bool value; + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); + bool val; int err; =20 - err =3D fw_attr->get_value(fw_attr->galaxybook, &value); + err =3D power_on_lid_open_acpi_get(galaxybook, &val); if (err) return err; =20 - return sysfs_emit(buf, "%u\n", value); + *val_idx =3D val; + + return 0; } =20 -static ssize_t current_value_store(struct kobject *kobj, struct kobj_attri= bute *attr, - const char *buf, size_t count) +static int power_on_lid_open_write(struct device *dev, long id, int val_id= x) { - struct galaxybook_fw_attr *fw_attr =3D - container_of(attr, struct galaxybook_fw_attr, current_value); - struct samsung_galaxybook *galaxybook =3D fw_attr->galaxybook; - bool value; + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); + + return power_on_lid_open_acpi_set(galaxybook, val_idx ? true : false); +} + +DEFINE_FWAT_ENUM_GROUP(power_on_lid_open, "Power On Lid Open", galaxybook_= possible_vals, + false, 0644, FWAT_ENUM_ALL_ATTRS); + +static int usb_charging_read(struct device *dev, long id, int *val_idx) +{ + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); + bool val; int err; =20 - if (!count) - return -EINVAL; - - err =3D kstrtobool(buf, &value); + err =3D usb_charging_acpi_get(galaxybook, &val); if (err) return err; =20 - guard(mutex)(&galaxybook->fw_attr_lock); + *val_idx =3D val; =20 - err =3D fw_attr->set_value(galaxybook, value); + return 0; +} + +static int usb_charging_write(struct device *dev, long id, int val_idx) +{ + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); + + return usb_charging_acpi_set(galaxybook, val_idx ? true : false); +} + +DEFINE_FWAT_ENUM_GROUP(usb_charging, "USB Charging", galaxybook_possible_v= als, + false, 0644, FWAT_ENUM_ALL_ATTRS); + +static int block_recording_read(struct device *dev, long id, int *val_idx) +{ + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); + bool val; + int err; + + err =3D block_recording_acpi_get(galaxybook, &val); if (err) return err; =20 - return count; + *val_idx =3D val; + + return 0; } =20 -#define NUM_FW_ATTR_ENUM_ATTRS 6 - -static int galaxybook_fw_attr_init(struct samsung_galaxybook *galaxybook, - const enum galaxybook_fw_attr_id fw_attr_id, - int (*get_value)(struct samsung_galaxybook *galaxybook, - bool *value), - int (*set_value)(struct samsung_galaxybook *galaxybook, - const bool value)) +static int block_recording_write(struct device *dev, long id, int val_idx) { - struct galaxybook_fw_attr *fw_attr; - struct attribute **attrs; =20 - fw_attr =3D devm_kzalloc(&galaxybook->platform->dev, sizeof(*fw_attr), GF= P_KERNEL); - if (!fw_attr) - return -ENOMEM; + struct samsung_galaxybook *galaxybook =3D dev_get_drvdata(dev); =20 - attrs =3D devm_kcalloc(&galaxybook->platform->dev, NUM_FW_ATTR_ENUM_ATTRS= + 1, - sizeof(*attrs), GFP_KERNEL); - if (!attrs) - return -ENOMEM; - - attrs[0] =3D &fw_attr_type.attr; - attrs[1] =3D &fw_attr_default_value.attr; - attrs[2] =3D &fw_attr_possible_values.attr; - attrs[3] =3D &fw_attr_display_name_language_code.attr; - - sysfs_attr_init(&fw_attr->display_name.attr); - fw_attr->display_name.attr.name =3D "display_name"; - fw_attr->display_name.attr.mode =3D 0444; - fw_attr->display_name.show =3D display_name_show; - attrs[4] =3D &fw_attr->display_name.attr; - - sysfs_attr_init(&fw_attr->current_value.attr); - fw_attr->current_value.attr.name =3D "current_value"; - fw_attr->current_value.attr.mode =3D 0644; - fw_attr->current_value.show =3D current_value_show; - fw_attr->current_value.store =3D current_value_store; - attrs[5] =3D &fw_attr->current_value.attr; - - attrs[6] =3D NULL; - - fw_attr->galaxybook =3D galaxybook; - fw_attr->fw_attr_id =3D fw_attr_id; - fw_attr->attr_group.name =3D galaxybook_fw_attr_name[fw_attr_id]; - fw_attr->attr_group.attrs =3D attrs; - fw_attr->get_value =3D get_value; - fw_attr->set_value =3D set_value; - - return sysfs_create_group(&galaxybook->fw_attrs_kset->kobj, &fw_attr->att= r_group); + return block_recording_acpi_set(galaxybook, val_idx ? true : false); } =20 -static void galaxybook_kset_unregister(void *data) -{ - struct kset *kset =3D data; - - kset_unregister(kset); -} - -static void galaxybook_fw_attrs_dev_unregister(void *data) -{ - struct device *fw_attrs_dev =3D data; - - device_unregister(fw_attrs_dev); -} +DEFINE_FWAT_ENUM_GROUP(block_recording, "Block Recording", galaxybook_poss= ible_vals, + false, 0644, FWAT_ENUM_ALL_ATTRS); =20 static int galaxybook_fw_attrs_init(struct samsung_galaxybook *galaxybook) { + struct fwat_device *fdev; bool value; int err; =20 - err =3D devm_mutex_init(&galaxybook->platform->dev, &galaxybook->fw_attr_= lock); - if (err) - return err; - - galaxybook->fw_attrs_dev =3D device_create(&firmware_attributes_class, NU= LL, MKDEV(0, 0), - NULL, "%s", DRIVER_NAME); - if (IS_ERR(galaxybook->fw_attrs_dev)) - return PTR_ERR(galaxybook->fw_attrs_dev); - - err =3D devm_add_action_or_reset(&galaxybook->platform->dev, - galaxybook_fw_attrs_dev_unregister, - galaxybook->fw_attrs_dev); - if (err) - return err; - - galaxybook->fw_attrs_kset =3D kset_create_and_add("attributes", NULL, - &galaxybook->fw_attrs_dev->kobj); - if (!galaxybook->fw_attrs_kset) - return -ENOMEM; - err =3D devm_add_action_or_reset(&galaxybook->platform->dev, - galaxybook_kset_unregister, galaxybook->fw_attrs_kset); - if (err) - return err; + fdev =3D devm_fwat_device_register(&galaxybook->platform->dev, DRIVER_NAM= E, galaxybook, NULL); + if (IS_ERR(fdev)) + return PTR_ERR(fdev); =20 err =3D power_on_lid_open_acpi_get(galaxybook, &value); if (!err) { - err =3D galaxybook_fw_attr_init(galaxybook, - GB_ATTR_POWER_ON_LID_OPEN, - &power_on_lid_open_acpi_get, - &power_on_lid_open_acpi_set); + err =3D fwat_create_group(fdev, &power_on_lid_open_group_data); if (err) return err; } =20 err =3D usb_charging_acpi_get(galaxybook, &value); if (!err) { - err =3D galaxybook_fw_attr_init(galaxybook, - GB_ATTR_USB_CHARGING, - &usb_charging_acpi_get, - &usb_charging_acpi_set); + err =3D fwat_create_group(fdev, &usb_charging_group_data); if (err) return err; } @@ -1107,10 +988,7 @@ static int galaxybook_fw_attrs_init(struct samsung_ga= laxybook *galaxybook) =20 galaxybook->has_block_recording =3D true; =20 - return galaxybook_fw_attr_init(galaxybook, - GB_ATTR_BLOCK_RECORDING, - &block_recording_acpi_get, - &block_recording_acpi_set); + return fwat_create_group(fdev, &block_recording_group_data); } =20 /* --=20 2.50.0 From nobody Wed Oct 8 09:04:35 2025 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F15C24337B; Mon, 30 Jun 2025 08:02:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270528; cv=none; b=SJxKyQS9Ntj8MinFJ0m2gouoB3jStVCz2p8jIanExfJjb3QBuHU0M2z5T0P62dCJ5BtMlTcN7eh3aoXWkJm4HaUGcJRAERl8qDAtKuxS1X/3GRiyS1GQx6mlrHCZ4bbf892JLqY1LxGhUhE1eOjD09KX1wHXasP8dB1EqQ4Q/w4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270528; c=relaxed/simple; bh=PGzNmxKPeKeIW9y3SLrZgxUtNxszaOvcO3mqQbh5IU4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E1D//Hdv5uQ/aWnF2/D8Tj5RO6G12m+1YBt93afXkJ9c+h0ddJQWRkOdmilQwgME33GhKXpRm5xbvcM4KGko2HxjQncrRpwqKyBUiVfJQIel9vLPyS2N3u7+vV7Y5jieQFwXLMPl5HRZZQIbP8ZbdVFo1xQkJ7U4V0nv+2zFB2c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=en0cT+gI; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="en0cT+gI" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6ecf99dd567so29262826d6.0; Mon, 30 Jun 2025 01:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751270525; x=1751875325; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SXIjFbe4Vrz2bi8rFlLHVCaoVK6EIDR/YQX7SQMy1sc=; b=en0cT+gID0V+xpNQhvkIQrW0PIUoc76tdYAhUEyqjPdAbLCm93HsEAfwswnTYBMg7z f0DDkCtKFN1vccVkzlyBnXuQ3OYrkqhsZX7jCSAeGMCDHwmLvjEpB7lePosLPkbLyaEZ fa3SD8eiz5aHCKeCz/t6nEgv8yGsnh0V4dNcmzbQjsLcvnybPlOtm2lV2z6BX1DvdzgC d0kcIRzZajlYxx4FC5VujvGOPBqB8zU+So37edBt0TKWL11JBBEDK9a1U1W7fRdn1TXp UVUgYMpsfJfQpwFUROu+UGVAmHez5+DSwwifSVb/wOsqkqkX4hfmFxccCs0VMJC2viL8 lIPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751270525; x=1751875325; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SXIjFbe4Vrz2bi8rFlLHVCaoVK6EIDR/YQX7SQMy1sc=; b=iSZQumoPeZVqBxjzBVCnUMTwlxU9YxcgOEOThwzAjkG7X7sPR8sQuPIPBPmptKPYGE 5da2e5v/dnUqmgzSeVva3G+G/tMVQRMNITJNgcuArMs/MuInRQGmH34FML8Uuo6iskrc yJQkLmJIUNTewTv99u7NVwezCn04UVcVHnYDrzNkBdTaLJn0IRnG/SRa7KQKFJfj++mw B0dSDI8dAeiO58yciB1zAKHfi0EPjC8DuWjlPrEl/1F3FbU2RwuijcqYH2aHz8qkrrqL llec8jAc2nc0Lg4HP3ljpO1AlHWl4BAt+96JmbZZYws3yup4PgdNQpRruRfPpUvZrphb iK2g== X-Forwarded-Encrypted: i=1; AJvYcCUMwBvHtE8sE8RYW0Xc//T9A2rxcRd7A56HIRQ08+e17nRMebykDee0XwlLccNiWJ1oUUj72RdVwgq0mKiJ1MrpLocisA==@vger.kernel.org, AJvYcCWr9fZJTXFPvQ9zcuyBXdWkwfrXnUZ4GhTSd3P1Xcra0v3rIqXSsELXqve/WBkhqTvVFgF6QVsKnrYRmdQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxjltXLlnWeqXTMsJhSM9YggXVrS45XoQOCjRS/ftqne5Q8hcZe qAqNF1BQVYWWyTTZQ1wHQv4zT9j6a/7sky3IHlargA0lNJEf1g9efDXX X-Gm-Gg: ASbGncuJRAnh3ec1Sye1fylVLodK/OytNPTpkqYV05oYsUjNm0keW2rYgXvdsdQDLoZ eRqqMSbMkKi2ooeBoYCTUdv6dvNSdKV9/XZqTO0unSzs8QL/xbXuPFe79rNL7Pzfl8QRKf8orKg icZ29cpQIulp6NkueIGhJEJzvrvI3FRTrzjb9DM9D9deAhTCCTyyZy7AHAFbEGJtomnu2fdPAhb 6HPEX9RtlvXrLEXQT91SmxM8hEev1vvDBwaQ6HQq/g8rRAvQ/doooUlcuRRXUatm1oEJy/rpj56 sH8rXrlUvS6s910RQ2DKNScZ7cOR0cOIv62GJOHfg/iOlQR0qcZID9oFgpGzOw== X-Google-Smtp-Source: AGHT+IGHPGZOCA4FHnX4CiRiQ9Vj+E9Y4C9AXAFlbtB2IYj6ZYSRwc4FUqgJ5xDJzF980IQJC+C2Eg== X-Received: by 2002:a05:6214:4308:b0:6fa:c453:a40d with SMTP id 6a1803df08f44-70013d52b86mr201203006d6.29.1751270525418; Mon, 30 Jun 2025 01:02:05 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd772df637sm63677026d6.79.2025.06.30.01.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 01:02:05 -0700 (PDT) From: Kurt Borja Date: Mon, 30 Jun 2025 05:01:12 -0300 Subject: [PATCH v4 5/6] Documentation: ABI: Update sysfs-class-firmware-attributes documentation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250630-fw-attrs-api-v4-5-1a04952b255f@gmail.com> References: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> In-Reply-To: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=756; i=kuurtb@gmail.com; h=from:subject:message-id; bh=PGzNmxKPeKeIW9y3SLrZgxUtNxszaOvcO3mqQbh5IU4=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBlJLslsC/K2CFxL/spbcP2ZadWlmg358Z8O+c6UK94Sm 7L81PUXHaUsDGJcDLJiiiztCYu+PYrKe+t3IPQ+zBxWJpAhDFycAjCRkzcZ/jt+ZVFtOqLy0kb6 vsDGqjWLXa54yE9lldS6FnbxanuVzXaGf2ZP/jPIm1/lEV40/WjTJJMXYce6HU9X/r6vcIn/y6a lyQwA X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Add a simple boolean type. Signed-off-by: Kurt Borja --- Documentation/ABI/testing/sysfs-class-firmware-attributes | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/ABI/testing/sysfs-class-firmware-attributes b/Do= cumentation/ABI/testing/sysfs-class-firmware-attributes index 2713efa509b465a39bf014180794bf487e5b42d6..64b8d5d49716e8387fee26e3e56= 910862f6a4f5c 100644 --- a/Documentation/ABI/testing/sysfs-class-firmware-attributes +++ b/Documentation/ABI/testing/sysfs-class-firmware-attributes @@ -18,6 +18,7 @@ Description: =20 The following are known types: =20 + - boolean - enumeration: a set of pre-defined valid values - integer: a range of numerical values - string --=20 2.50.0 From nobody Wed Oct 8 09:04:35 2025 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CDF32451F3; Mon, 30 Jun 2025 08:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270532; cv=none; b=knfuRImSUaoxmSLkjt3c0jVT3Z23iOg9RgY5qenBbAKOrV9zJAdY3/ySHWlz0KpKz31wiEbkLG2IIYHAHOIgEbgrvkyoiokZP/pT9OWptyhzvbBDaN+fNge04t77mZ/m1aTIYglCSL8C4hpjdD9zzhYRtqHJh9to/BVcLbmIFYQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270532; c=relaxed/simple; bh=hOd6+qOcYjH/w/j3ddYeY0GLTSBfqJE3weH99urGytI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C3FqkbRIsqifRa1J8w+0Eroqi1VJj3uZUYs58tS5Kyyl3YW5TFly1YL0qYCtk7mUIyMMveOnotKOhtT+7c/rbVz97G8APYJa/vx0HujcRXaCGFFiGqjO3ayVnXffjzIB1bEUzwcbP0GajwrfM/GQYWiJ9DKbIedx3aIq8Zw6qNI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TSd0dczX; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TSd0dczX" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-700fee04941so10116806d6.1; Mon, 30 Jun 2025 01:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751270530; x=1751875330; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3DnWNuVGlcxt97iON5+GLNil5h81EohwejutmAGRqZY=; b=TSd0dczXkhd9GywGbJfI7e+YZ9Eb4erqrzUbded1uNz8Gt1QU1lV59iza4C5hAAkre a8FVeR/BFQGJ+p4bNOdZEnI+plzdTmVQSD23Y3IDUfwNhxpzwgwqtEUCtu8laxx3oz+Z iEcCxCaKpz2y4jUsB3rOQk6w6BAbJyeoUtKK6mQtX38cOyedgDhZ6fgEwy3Ytp5H/Vkm wR/B0kJMQwIE1aOiyCN1LSdtRAXf0hsF/59RFZ2xGhmz5g/dY0WoOZTxWcdWttGQe5V4 vKhhnQ53nMLQuT2IGKTsk42gHosx5JnYCweoTmzGn2gocaUOkmGnIU5UYLZ+XDURRCaZ LD3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751270530; x=1751875330; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3DnWNuVGlcxt97iON5+GLNil5h81EohwejutmAGRqZY=; b=xM1kl5fvNtBgph14+pOnPXI+5D77g9cmFE5miZBICOWu6utnCuXH1GkNjWmW80iUxT sBohLyIgVZAoByG2T9bcTZDGsYoCjaE4IhsFzf3xj2/48xjeW7X8DOE7WdvwvwnG99P4 QXqxMc1lLQ865jBbixEym73/zZxWLhw0hqpDTc154Ulr4dJ0cTvvlTmLhPyt7bw6NBgR CbCiZLCdpZxT3900hpL7qIhWJb5Fwp1bD746rT5uG8NVtxAdyrw23fUM8/wQwTgH1gdY tmUhJBwTBgvKX7Qs3yjtmxNw00Gg7CqWYvU4rUJtt3fLKig8nKFpRWPwnFDiv+mWRz7Y JuJg== X-Forwarded-Encrypted: i=1; AJvYcCUleriDIl4arDGvUaVLSsD7zUmlT96qeKXH+Kwua+xYOzLvxegVdCNk5KB7FTE9lZfhu+wZwxh+09+9JuGfPzC1CFcGLw==@vger.kernel.org, AJvYcCXDU/EnrtwfKYic6nNwVVQ4mzBTFkjlPEkGV+pFJ+zp31XIlzYVO4VvDsoMK0peB5jBQqfzAuEggtmO9Ck=@vger.kernel.org X-Gm-Message-State: AOJu0YzbN4o7hqrAY0Ds0G8DUYXKbAMSLv8r2rGprN2tWojuYfjgHmll J1IS2hKN6T4sQxPli+wvDO9D59AAmVbQCHFng8J1RstzHDzRmCUIbrH8 X-Gm-Gg: ASbGncsEkYjN4OQE3k2O/BdSBE4KjzpGpjr+6faz8+kUhXg+a5j7BJd1qFGI5G4YE9w pyY7EQH9vy/qqvMgIY/AtE79Gl0oBfIAZ9Rg/ylB1Q4KC4HgsySdFnj19xcs++AbeEF4EIzLkvF mNiM2rAcA6Rzv1Q48l0dwavWloIPuivpuSrNkxQwwxZSyoeqNVGFFi47ELl0M25cacbO80MY8Zz 7bporU/NE0qtyiABlGl8+UHwHSrgTCq/kaGAEjldAx4/S+uov0efiBQm4nZjKvjBEvpMIJfUu6t KUEcR9Ld/clwsYOyfPHNAV/ixdzKJX5QafKTu9k82hUAD+DNGHESO0qMSK3V5w== X-Google-Smtp-Source: AGHT+IHsLPJS1KQ87rYWgOPssNPc34rcZKreTHx889UrwUoHfES/M4Ocd15A0FcVhMZv8rxR0ldaPg== X-Received: by 2002:a05:6214:f66:b0:6f8:bfbf:5d47 with SMTP id 6a1803df08f44-70002ee6975mr173749146d6.24.1751270529900; Mon, 30 Jun 2025 01:02:09 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd772df637sm63677026d6.79.2025.06.30.01.02.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 01:02:09 -0700 (PDT) From: Kurt Borja Date: Mon, 30 Jun 2025 05:01:13 -0300 Subject: [PATCH v4 6/6] MAINTAINERS: Add FIRMWARE ATTRIBUTES CLASS entry Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250630-fw-attrs-api-v4-6-1a04952b255f@gmail.com> References: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> In-Reply-To: <20250630-fw-attrs-api-v4-0-1a04952b255f@gmail.com> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Joshua Grisham , Mark Pearson , Armin Wolf , Mario Limonciello Cc: Antheas Kapenekakis , "Derek J. Clark" , Prasanth Ksr , Jorge Lopez , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=875; i=kuurtb@gmail.com; h=from:subject:message-id; bh=hOd6+qOcYjH/w/j3ddYeY0GLTSBfqJE3weH99urGytI=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBlJLsm6O5ZMUXeYl93O9T9y4/Xosi8rruXGLNjM+DtJ/ 2LVPRnbjlIWBjEuBlkxRZb2hEXfHkXlvfU7EHofZg4rE8gQBi5OAZhI4GJGhjPTGhu1Y9e2THuo 1tFz92WklWfVOgENwe4ECeceCbmHpgz/A+qPCXNeO6OhHCXknOX5Nc1Qof7PzX/ff7gweX08ZV3 KBgA= X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Add entry for the FIRMWARE ATTRIBUTES CLASS. Signed-off-by: Kurt Borja --- MAINTAINERS | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c14614613377df7f40565c6df50661fe3f510034..c799f603e9210e4703eeb1f0ac9= d6b9e8bd469c5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9352,6 +9352,14 @@ F: include/linux/firewire.h F: include/uapi/linux/firewire*.h F: tools/firewire/ =20 +FIRMWARE ATTRIBUTES CLASS +M: Kurt Borja +L: platform-driver-x86@vger.kernel.org +S: Maintained +F: drivers/platform/x86/firmware_attributes_class.c +F: include/linux/firmware_attributes_class.h +K: (devm_)?fwat_device_(un)?register + FIRMWARE FRAMEWORK FOR ARMV8-A M: Sudeep Holla L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) --=20 2.50.0