From nobody Wed Oct 8 12:36:07 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2517E1925BC; Fri, 27 Jun 2025 15:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751038170; cv=none; b=PhhsjrTPoENt4RIxO8puYScfd8soVCQLQZn106Fw27xm2tayJNoJ3G0AbSf/Vvw5Zq52E4eClZWMp/St/Z++YXaFzVLr6F5uVh/mZwynWtCohmlzQNL2iDbu94klB6lg6Hh9s25uL4h6K0oasKfB+4OJCOfx3VNLE91NEi50DGo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751038170; c=relaxed/simple; bh=P2snesJzCcoewtMetOLPemSPMxBI1rMj38HQO6OHc0g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hBZA8CYFLKmILN0y+wB6uAKu5zm/f+q/uMjM482FtPr5gciAeilCVeX6ClakITz/S0QwGJdMSNcn7k4r/DS64ircn+EohyS0SuXY0Fo9SdBpFFJEbW1o6k2C1QnVI3BkyFqkB0RH18vbRo2u7E3VQuiDq9HkVDyOo1+uLAOVxpE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H6iaMyjI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H6iaMyjI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86233C4CEE3; Fri, 27 Jun 2025 15:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751038169; bh=P2snesJzCcoewtMetOLPemSPMxBI1rMj38HQO6OHc0g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H6iaMyjIJSuJKtCHJZ6x37YyMHYme+Bod9u1ZsU/7PCjyXrz//E4WTaIOqMbkhjd/ 94+M0wIwSFWutdT5V/qplc4oFcCxbz+fKtX/IEtelLZHoWuIZE251HW5Up/60hIoaC AU32kdGZZilFI92vGZyghti24aRHHEFBE65lQoDD+pbqbazVRg74Y9aYF0IqS8oIbN yaHZY0go/TQ3yBy3zW38sTyiwcuo+OKWqYD5xS/dWBdm7bAG65bf4E/n4U/j3Xwlfi Fk/SrzofSaJ0YGEkBqoin29zJWVs94bodR2PeW6ZrQBinmwH1LQPadLLACOGloEEUF PKAdsBX1HNs1A== Received: by wens.tw (Postfix, from userid 1000) id 2BE3A5FAC5; Fri, 27 Jun 2025 23:29:27 +0800 (CST) From: Chen-Yu Tsai To: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andre Przywara , linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 1/4] dt-bindings: power: Add A523 PPU and PCK600 power controllers Date: Fri, 27 Jun 2025 23:29:15 +0800 Message-Id: <20250627152918.2606728-2-wens@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250627152918.2606728-1-wens@kernel.org> References: <20250627152918.2606728-1-wens@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen-Yu Tsai The A523 PPU is likely the same kind of hardware seen on previous SoCs. The A523 PCK600, as the name suggests, is likely a customized version of ARM's PCK-600 power controller. Comparing the BSP driver against ARM's PPU datasheet shows that the basic registers line up, but Allwinner's hardware has some additional delay controls in the reserved register range. As such it is likely not fully compatible with the standard ARM version. Document A523 PPU and PCK600 compatibles. Signed-off-by: Chen-Yu Tsai Reviewed-by: Andre Przywara --- .../bindings/power/allwinner,sun20i-d1-ppu.yaml | 2 ++ .../power/allwinner,sun55i-a523-pck600.h | 15 +++++++++++++++ .../dt-bindings/power/allwinner,sun55i-a523-ppu.h | 12 ++++++++++++ 3 files changed, 29 insertions(+) create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-pck600.h create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-ppu.h diff --git a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-pp= u.yaml b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.ya= ml index f578be6a3bc8..b9f550994512 100644 --- a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml +++ b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml @@ -18,6 +18,8 @@ properties: enum: - allwinner,sun20i-d1-ppu - allwinner,sun8i-v853-ppu + - allwinner,sun55i-a523-ppu + - allwinner,sun55i-a523-pck-600 =20 reg: maxItems: 1 diff --git a/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h b/inc= lude/dt-bindings/power/allwinner,sun55i-a523-pck600.h new file mode 100644 index 000000000000..6b3d8ea7bb69 --- /dev/null +++ b/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ + +#ifndef _DT_BINDINGS_POWER_SUN55I_A523_PCK600_H_ +#define _DT_BINDINGS_POWER_SUN55I_A523_PCK600_H_ + +#define PD_VE 0 +#define PD_GPU 1 +#define PD_VI 2 +#define PD_VO0 3 +#define PD_VO1 4 +#define PD_DE 5 +#define PD_NAND 6 +#define PD_PCIE 7 + +#endif /* _DT_BINDINGS_POWER_SUN55I_A523_PCK600_H_ */ diff --git a/include/dt-bindings/power/allwinner,sun55i-a523-ppu.h b/includ= e/dt-bindings/power/allwinner,sun55i-a523-ppu.h new file mode 100644 index 000000000000..bc9aba73c19a --- /dev/null +++ b/include/dt-bindings/power/allwinner,sun55i-a523-ppu.h @@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ + +#ifndef _DT_BINDINGS_POWER_SUN55I_A523_PPU_H_ +#define _DT_BINDINGS_POWER_SUN55I_A523_PPU_H_ + +#define PD_DSP 0 +#define PD_NPU 1 +#define PD_AUDIO 2 +#define PD_SRAM 3 +#define PD_RISCV 4 + +#endif /* _DT_BINDINGS_POWER_SUN55I_A523_PPU_H_ */ --=20 2.39.5 From nobody Wed Oct 8 12:36:07 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFF621CAA6C; Fri, 27 Jun 2025 15:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751038170; cv=none; b=amkcX3SjytAgVVqkCuiQsX7c0ulFQYaweWDk6QLilDodB80vTbn7qJQ7FbBJ3ELpRmCfSEuAY0eMbR8HmaYi8N6RGIKS78XJ9ECvzoEgkSOk4dvFh9N/6Eweoj6NI6cKk1NuOh5mTpvE5YKLjECluHETpKXCxKfAm550kAwuPR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751038170; c=relaxed/simple; bh=HqUKn0G06bLQgn9/7br5JqwZjyala+dj86Idxb210+E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aovpS8pixSeb2xdCCw3U9+JMhTr1ft2368uUJ7Eb0XPKUQF2wasau1cBhRVNEhtbWGoUrZIPr4fUNsHo+/QqJy+MKuhvpLgulP0POp6vp6Feu1tVUR5q5X1FMnnA6bhMe4iPRUvVlu0LBeNPv9MqNKKNF69dmEY6hZa6Sr0u1c8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q4JdDqPN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q4JdDqPN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A848BC4CEF1; Fri, 27 Jun 2025 15:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751038169; bh=HqUKn0G06bLQgn9/7br5JqwZjyala+dj86Idxb210+E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q4JdDqPNgf+N/qPpe13/rDdggJ7X82WQoNvBLavdF/iOvGPAzdTEXe0IhAKQMCmVA Ln3U/mI1h5dDSxMLGDaoMxOR6qv0X8JSUXPmXWY/0bVYSj8hL96ZBFf/ySh9hu8mSu XwOC6BPRQj2ZTVFU8TQ4lqTyc0QyOsUUZ7AL7Lv8pwqlLHseQX69T53OrFSSSitvlx HTHN+6ud0sjimLb+vYovqDfvn1dqHYC52gCGsyDkfTHfTaqUe1uRnuBjjXaoogoF9J yfstODLz/pwRxXt4iOBMpRYRmQIGadAYgZ/jS/G4I5DBJc8/g24KrZBqZq/xcWLMfI Ja1KkTT7T5l4A== Received: by wens.tw (Postfix, from userid 1000) id 32F395FF77; Fri, 27 Jun 2025 23:29:27 +0800 (CST) From: Chen-Yu Tsai To: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andre Przywara , linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 2/4] pmdomain: sunxi: sun20i-ppu: add A523 support Date: Fri, 27 Jun 2025 23:29:16 +0800 Message-Id: <20250627152918.2606728-3-wens@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250627152918.2606728-1-wens@kernel.org> References: <20250627152918.2606728-1-wens@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen-Yu Tsai A523 has a PPU like the one in the Allwinner D1 SoC. Add a compatible entry and a list of power domain names for it. Signed-off-by: Chen-Yu Tsai Reviewed-by: Andre Przywara --- drivers/pmdomain/sunxi/sun20i-ppu.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/pmdomain/sunxi/sun20i-ppu.c b/drivers/pmdomain/sunxi/s= un20i-ppu.c index 9f002748d224..b65876a68cc1 100644 --- a/drivers/pmdomain/sunxi/sun20i-ppu.c +++ b/drivers/pmdomain/sunxi/sun20i-ppu.c @@ -193,6 +193,19 @@ static const struct sun20i_ppu_desc sun8i_v853_ppu_des= c =3D { .num_domains =3D ARRAY_SIZE(sun8i_v853_ppu_pd_names), }; =20 +static const char *const sun55i_a523_ppu_pd_names[] =3D { + "DSP", + "NPU", + "AUDIO", + "SRAM", + "RISCV", +}; + +static const struct sun20i_ppu_desc sun55i_a523_ppu_desc =3D { + .names =3D sun55i_a523_ppu_pd_names, + .num_domains =3D ARRAY_SIZE(sun55i_a523_ppu_pd_names), +}; + static const struct of_device_id sun20i_ppu_of_match[] =3D { { .compatible =3D "allwinner,sun20i-d1-ppu", @@ -202,6 +215,10 @@ static const struct of_device_id sun20i_ppu_of_match[]= =3D { .compatible =3D "allwinner,sun8i-v853-ppu", .data =3D &sun8i_v853_ppu_desc, }, + { + .compatible =3D "allwinner,sun55i-a523-ppu", + .data =3D &sun55i_a523_ppu_desc, + }, { } }; MODULE_DEVICE_TABLE(of, sun20i_ppu_of_match); --=20 2.39.5 From nobody Wed Oct 8 12:36:07 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF8F2E92CA; Fri, 27 Jun 2025 15:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751038170; cv=none; b=SDLR2LFhADWKAQSg11sCyklB0MrU92J8sqUAyUIKr8T2KgBCYKCz/Wxz6sX+g93kQuvbOl3tx540H/N7oMam8T7vCVC0DsxSWr86UV+pKQ9KaGysZiwmfZ4FRfjHYdx2Mk/W1NMljhSUMgc4cQpVZJEunv1Sz4L8N6abQXpwoK8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751038170; c=relaxed/simple; bh=bhvlZxpF344s3Cn9ppDtECocZaX1zt5idxwPfkm+U2o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ReaxlrIWJ2pYEUVOJOSC8UCrNFpSVjuwbviT9Tg/F9K8DHPTcVqzqikEVNcNWXeWB+ulWFpOV7QTmaGjI/7lufuh+MUd6V6jxQE6uUdlxeXmw93w7aye8GQWbhKn1XXK1vzxUiTVJMQGElqEhEg6C9gKTIzaRO4toXMc3SZ9asM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JkGB5Sru; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JkGB5Sru" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DDE8C4CEED; Fri, 27 Jun 2025 15:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751038169; bh=bhvlZxpF344s3Cn9ppDtECocZaX1zt5idxwPfkm+U2o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JkGB5SruwGHa7bhPahYo6Ha4osWfBPDQBjj9IKPRyIjusvaMwmsipcrvxRJGvVk3K Po1Z4uq+VMj0Z/joaBfC/2ajkUW4yIfutqFcJXUgczFMTjaWARBItsazPLcSHPRReY TdEwem2snEQ7H8BwwB9j2jCGQYR3VRW3ky2gtNxLtA0R0SI5f1Ykl1NGH+TJEEm1Tw KLrAL4nevPFY/U+irslJ2qiqQrMpAZSy+UY4RWj/VV+7XQb1mAyerrGJLPKDX6XCH/ 4ufLxjcL44NQnUq7Tz/9n1PBCJSylPFAIgh9j+FTJjcFSpox9yI87mSzNT0D30btgd Ezy/vmu9AY8bw== Received: by wens.tw (Postfix, from userid 1000) id 39E2A5FFBC; Fri, 27 Jun 2025 23:29:27 +0800 (CST) From: Chen-Yu Tsai To: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andre Przywara , linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 3/4] pmdomain: sunxi: add driver for Allwinner A523's PCK-600 power controller Date: Fri, 27 Jun 2025 23:29:17 +0800 Message-Id: <20250627152918.2606728-4-wens@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250627152918.2606728-1-wens@kernel.org> References: <20250627152918.2606728-1-wens@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen-Yu Tsai Allwinner A523 family has a second power controller, named PCK-600 in the datasheets and BSP. It is likely based on ARM's PCK-600 hardware block, with some additional delay controls. The only documentation for this hardware is the BSP driver. The standard registers defined in ARM's Power Policy Unit Architecture Specification line up. Some extra delay controls are found in the reserved range of registers. Add a driver for this power controller. Delay control register values and power domain names are from the BSP driver. Signed-off-by: Chen-Yu Tsai --- drivers/pmdomain/sunxi/Kconfig | 8 + drivers/pmdomain/sunxi/Makefile | 1 + drivers/pmdomain/sunxi/sun55i-pck600.c | 225 +++++++++++++++++++++++++ 3 files changed, 234 insertions(+) create mode 100644 drivers/pmdomain/sunxi/sun55i-pck600.c diff --git a/drivers/pmdomain/sunxi/Kconfig b/drivers/pmdomain/sunxi/Kconfig index 43eecb3ea981..3e2b77cd9a2b 100644 --- a/drivers/pmdomain/sunxi/Kconfig +++ b/drivers/pmdomain/sunxi/Kconfig @@ -18,3 +18,11 @@ config SUN50I_H6_PRCM_PPU Say y to enable the Allwinner H6/H616 PRCM power domain driver. This is required to enable the Mali GPU in the H616 SoC, it is optional for the H6. + +config SUN55I_PCK600 + bool "Allwinner A523 PCK-600 power domain driver" + depends on PM + select PM_GENERIC_DOMAINS + help + Say y to enable the PCK-600 power domain driver. This saves power + when certain peripherals, such as the video engine, are idle. diff --git a/drivers/pmdomain/sunxi/Makefile b/drivers/pmdomain/sunxi/Makef= ile index c1343e123759..e344b232fc9f 100644 --- a/drivers/pmdomain/sunxi/Makefile +++ b/drivers/pmdomain/sunxi/Makefile @@ -1,3 +1,4 @@ # SPDX-License-Identifier: GPL-2.0-only obj-$(CONFIG_SUN20I_PPU) +=3D sun20i-ppu.o obj-$(CONFIG_SUN50I_H6_PRCM_PPU) +=3D sun50i-h6-prcm-ppu.o +obj-$(CONFIG_SUN55I_PCK600) +=3D sun55i-pck600.o diff --git a/drivers/pmdomain/sunxi/sun55i-pck600.c b/drivers/pmdomain/sunx= i/sun55i-pck600.c new file mode 100644 index 000000000000..7248f6113665 --- /dev/null +++ b/drivers/pmdomain/sunxi/sun55i-pck600.c @@ -0,0 +1,225 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Allwinner PCK-600 power domain support + * + * Copyright (c) 2025 Chen-Yu Tsai + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define PPU_PWPR 0x0 +#define PPU_PWSR 0x8 +#define PPU_DCDR0 0x170 +#define PPU_DCDR1 0x174 + +#define PPU_PWSR_PWR_STATUS GENMASK(3, 0) +#define PPU_POWER_MODE_ON 0x8 +#define PPU_POWER_MODE_OFF 0x0 + +#define PPU_REG_SIZE 0x1000 + +struct sunxi_pck600_desc { + const char * const *pd_names; + unsigned int num_domains; + u32 logic_power_switch0_delay_offset; + u32 logic_power_switch1_delay_offset; + u32 off2on_delay_offset; + u32 device_ctrl0_delay; + u32 device_ctrl1_delay; + u32 logic_power_switch0_delay; + u32 logic_power_switch1_delay; + u32 off2on_delay; +}; + +struct sunxi_pck600_pd { + struct generic_pm_domain genpd; + struct sunxi_pck600 *pck; + void __iomem *base; +}; + +struct sunxi_pck600 { + struct device *dev; + struct genpd_onecell_data genpd_data; + struct sunxi_pck600_pd pds[]; +}; + +#define to_sunxi_pd(gpd) container_of(gpd, struct sunxi_pck600_pd, genpd) + +static int sunxi_pck600_pd_set_power(struct sunxi_pck600_pd *pd, bool on) +{ + struct sunxi_pck600 *pck =3D pd->pck; + struct generic_pm_domain *genpd =3D &pd->genpd; + int ret; + u32 val, reg; + + val =3D on ? PPU_POWER_MODE_ON : PPU_POWER_MODE_OFF; + + reg =3D readl(pd->base + PPU_PWPR); + FIELD_MODIFY(PPU_PWSR_PWR_STATUS, ®, val); + writel(reg, pd->base + PPU_PWPR); + + /* push write out to hardware */ + reg =3D readl(pd->base + PPU_PWPR); + + ret =3D readl_poll_timeout_atomic(pd->base + PPU_PWSR, reg, + FIELD_GET(PPU_PWSR_PWR_STATUS, reg) =3D=3D val, + 0, 10000); + if (ret) + dev_err(pck->dev, "failed to turn domain \"%s\" %s: %d\n", + genpd->name, str_on_off(on), ret); + + return ret; +} + +static int sunxi_pck600_power_on(struct generic_pm_domain *domain) +{ + struct sunxi_pck600_pd *pd =3D to_sunxi_pd(domain); + + return sunxi_pck600_pd_set_power(pd, true); +} + +static int sunxi_pck600_power_off(struct generic_pm_domain *domain) +{ + struct sunxi_pck600_pd *pd =3D to_sunxi_pd(domain); + + return sunxi_pck600_pd_set_power(pd, false); +} + +static void sunxi_pck600_pd_setup(struct sunxi_pck600_pd *pd, + const struct sunxi_pck600_desc *desc) +{ + writel(desc->device_ctrl0_delay, pd->base + PPU_DCDR0); + writel(desc->device_ctrl1_delay, pd->base + PPU_DCDR1); + writel(desc->logic_power_switch0_delay, + pd->base + desc->logic_power_switch0_delay_offset); + writel(desc->logic_power_switch1_delay, + pd->base + desc->logic_power_switch1_delay_offset); + writel(desc->off2on_delay, pd->base + desc->off2on_delay_offset); +} + +static int sunxi_pck600_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + const struct sunxi_pck600_desc *desc; + struct genpd_onecell_data *genpds; + struct sunxi_pck600 *pck; + struct reset_control *rst; + struct clk *clk; + void __iomem *base; + int i, ret; + + desc =3D of_device_get_match_data(dev); + + pck =3D devm_kzalloc(dev, struct_size(pck, pds, desc->num_domains), GFP_K= ERNEL); + if (!pck) + return -ENOMEM; + + pck->dev =3D &pdev->dev; + platform_set_drvdata(pdev, pck); + + genpds =3D &pck->genpd_data; + genpds->num_domains =3D desc->num_domains; + genpds->domains =3D devm_kcalloc(dev, desc->num_domains, + sizeof(*genpds->domains), GFP_KERNEL); + if (!genpds->domains) + return -ENOMEM; + + base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(base)) + return PTR_ERR(base); + + rst =3D devm_reset_control_get_exclusive_released(dev, NULL); + if (IS_ERR(rst)) + return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n"); + + clk =3D devm_clk_get_enabled(dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), "failed to get clock\n"); + + for (i =3D 0; i < desc->num_domains; i++) { + struct sunxi_pck600_pd *pd =3D &pck->pds[i]; + + pd->genpd.name =3D desc->pd_names[i]; + pd->genpd.power_off =3D sunxi_pck600_power_off; + pd->genpd.power_on =3D sunxi_pck600_power_on; + pd->base =3D base + PPU_REG_SIZE * i; + + sunxi_pck600_pd_setup(pd, desc); + ret =3D pm_genpd_init(&pd->genpd, NULL, false); + if (ret) { + dev_err_probe(dev, ret, "failed to initialize power domain\n"); + goto err_remove_pds; + } + + genpds->domains[i] =3D &pd->genpd; + } + + ret =3D of_genpd_add_provider_onecell(dev_of_node(dev), genpds); + if (ret) { + dev_err_probe(dev, ret, "failed to add PD provider\n"); + goto err_remove_pds; + } + + return 0; + +err_remove_pds: + for (i--; i >=3D 0; i--) + pm_genpd_remove(genpds->domains[i]); + + return ret; +} + +static const char * const sun55i_a523_pck600_pd_names[] =3D { + "VE", "GPU", "VI", "VO0", "VO1", "DE", "NAND", "PCIE" +}; + +static const struct sunxi_pck600_desc sun55i_a523_pck600_desc =3D { + .pd_names =3D sun55i_a523_pck600_pd_names, + .num_domains =3D ARRAY_SIZE(sun55i_a523_pck600_pd_names), + .logic_power_switch0_delay_offset =3D 0xc00, + .logic_power_switch1_delay_offset =3D 0xc04, + .off2on_delay_offset =3D 0xc10, + .device_ctrl0_delay =3D 0xffffff, + .device_ctrl1_delay =3D 0xffff, + .logic_power_switch0_delay =3D 0x8080808, + .logic_power_switch1_delay =3D 0x808, + .off2on_delay =3D 0x8 +}; + +static const struct of_device_id sunxi_pck600_of_match[] =3D { + { + .compatible =3D "allwinner,sun55i-a523-pck-600", + .data =3D &sun55i_a523_pck600_desc, + }, + {} +}; +MODULE_DEVICE_TABLE(of, sunxi_pck600_of_match); + +static struct platform_driver sunxi_pck600_driver =3D { + .probe =3D sunxi_pck600_probe, + .driver =3D { + .name =3D "sunxi-pck-600", + .of_match_table =3D sunxi_pck600_of_match, + /* Power domains cannot be removed if in use. */ + .suppress_bind_attrs =3D true, + }, +}; +module_platform_driver(sunxi_pck600_driver); + +MODULE_DESCRIPTION("Allwinner PCK-600 power domain driver"); +MODULE_AUTHOR("Chen-Yu Tsai "); +MODULE_LICENSE("GPL"); --=20 2.39.5 From nobody Wed Oct 8 12:36:07 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6938D2E9EB2; Fri, 27 Jun 2025 15:29:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751038170; cv=none; b=swUSA9h1EhCt5iaQK0xOm0a3MmOXt8M+lPdZOPxsKwPFa+ZPWxysRrNHLgqN8D4ebjQd04XBZoO+5d0rMeUwQR1ye9Xsv1S9iGC38PactKQbUNMVw1ypfJ9jI7nyZMQ5RkC50yNqh0fi4sUPfV03LKQhCU6FjW7GaQcCv3fToI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751038170; c=relaxed/simple; bh=LsM/oKAoyeVrerWCsGQ8qkJnLZGaVDxv1+0mdy8Bbow=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lQHgHcELMr9Sq95dMXwbORS7g6oROrew99TpqiCOxmM8e5d7HkWSbn0V+630F7Vh2WDYhT8+ow27YJsZAtZxlz5ml30Sv+TxcfMz2DxDNh6BqOWbS9Y/Tbfd6k7xJb61SSHipSffsKpJmh1os783Z+6FVEtaDNSsojtahkx1vBk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WenOP8PH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WenOP8PH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3042C4CEF3; Fri, 27 Jun 2025 15:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751038170; bh=LsM/oKAoyeVrerWCsGQ8qkJnLZGaVDxv1+0mdy8Bbow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WenOP8PHK54BpguPCGqN18tbpif+eHEwWcahV5qmVT/6mzlrR/UYs8eZWUf0uLGtq ctzHnFY1AEgvkiJK9SH+iK7T9KOLa6BATLbG9HoNaJBpMNgf7gAoUjtKEdMEBc/BIH T1knLPaUKHZCXMfvmFEcLximJTRYKJQtJTm/IDxB3fIn1sKOt/4QMPnSWjQYH6jvec WaTHuq6PK8059ndMHc9Zvkp0gkP0dzAiM7D0Q9d+bYY4JGXAhJLO2NeImTPRjU1tJD tM0ug3rBiz9+ymzGK6y71ZPG8D9V+qkqInbENL3CrVZibO+YbGArB3Wd8nJsVvfUU0 8dP1I/pq56IBg== Received: by wens.tw (Postfix, from userid 1000) id 456665FFC8; Fri, 27 Jun 2025 23:29:27 +0800 (CST) From: Chen-Yu Tsai To: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andre Przywara , linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 4/4] arm64: dts: allwinner: a523: Add power controller device nodes Date: Fri, 27 Jun 2025 23:29:18 +0800 Message-Id: <20250627152918.2606728-5-wens@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250627152918.2606728-1-wens@kernel.org> References: <20250627152918.2606728-1-wens@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen-Yu Tsai The A523 SoC family has two power controllers, one based on the existing PPU, and one newer one based on ARM's PCK-600. Add device nodes for both of them. Signed-off-by: Chen-Yu Tsai Reviewed-by: Andre Przywara --- arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/bo= ot/dts/allwinner/sun55i-a523.dtsi index 6f62201fd739..255e0ef98219 100644 --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi @@ -7,6 +7,8 @@ #include #include #include +#include +#include =20 / { interrupt-parent =3D <&gic>; @@ -576,6 +578,14 @@ mdio0: mdio { }; }; =20 + ppu: power-controller@7001400 { + compatible =3D "allwinner,sun55i-a523-ppu"; + reg =3D <0x07001400 0x400>; + clocks =3D <&r_ccu CLK_BUS_R_PPU1>; + resets =3D <&r_ccu RST_BUS_R_PPU1>; + #power-domain-cells =3D <1>; + }; + r_ccu: clock-controller@7010000 { compatible =3D "allwinner,sun55i-a523-r-ccu"; reg =3D <0x7010000 0x250>; @@ -622,6 +632,14 @@ r_i2c_pins: r-i2c-pins { }; }; =20 + pck600: power-controller@7060000 { + compatible =3D "allwinner,sun55i-a523-pck-600"; + reg =3D <0x07060000 0x8000>; + clocks =3D <&r_ccu CLK_BUS_R_PPU0>; + resets =3D <&r_ccu RST_BUS_R_PPU0>; + #power-domain-cells =3D <1>; + }; + r_i2c0: i2c@7081400 { compatible =3D "allwinner,sun55i-a523-i2c", "allwinner,sun8i-v536-i2c", --=20 2.39.5