From nobody Mon Feb 9 15:26:58 2026 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 514A22E2671 for ; Fri, 27 Jun 2025 14:23:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751034198; cv=none; b=kG4QIDEjrpwvLxGnD1EFVbIB/oQGufscpDOpz3xkLvn0j/28ROKtGlPXVnBhel4/1mjS+xtwYIzreAkw/4KD/sDXHiEVNhzLJf/bF8GianbaBzYC3UOlrXGi6gtS25Vl6gd7LPQ+evWcEXV0F46EuVn103QM3dIpykPNGyEVvyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751034198; c=relaxed/simple; bh=Tsq4Cj77x0Uz84CFPrzoZFbQG9zudBpa1tvUCC6Cylk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hdbHTkluVPs5XDTFXpgCSy5Qj6wW2bYnY5f/YCMP3X7xdQKO4oTI2Vchlt2tYvf+hY+IiW5ZvvMb3HTeTR3wZOrCIk/LYLsPf86oPeSkaijuAsW65He8whuiH6PelYj/bIzWqQUK7axkU6zfd/FRNqaeSHwZmOTuDTyKeozuFFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=EK1jlKyD; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="EK1jlKyD" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7d0976776dcso236653685a.2 for ; Fri, 27 Jun 2025 07:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1751034195; x=1751638995; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nEeEDXRCRhzfd7WiQWk3nSeJTZHMTuZTnU4CBiNxmaU=; b=EK1jlKyDIeNtBRcI5wFNDltVIXn8kPh4loOP5YOpsenltX9x8xgULOkLlFiukaxiNn pEm8ALvW7JtFGEIalrm9C9pT8BvdBmWF9hXgvpQxTscvkfu6zCcqNgM2BOFQ/w49r/nr /Sq3B56Z/LW/Rj6RWxlLNEC3ooLhaZV30ze8ds2lPAc1uyeoeqdSdURiqZgbeETYG5Sw 1EqdI3fDLSTTsJjsoFfhn9r1tX5t4gwRwS7c2YG3Io1sPW6BJgv+zljAcln7z2sLZDT5 Kxaaboq/Pn8xZIHu85Ji4i9pdxZBYLyV4uSpC1xHhhgZ1Zw7JH09LWmlL/+7AGNmKqjy LC2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751034195; x=1751638995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nEeEDXRCRhzfd7WiQWk3nSeJTZHMTuZTnU4CBiNxmaU=; b=MItG3J7zZ8QpoZR5QO6U+CSyw5gUJW+kKHNA6/T/3yJHdmdP1bpVNR/Ly4L37chfJM yWrbaVoqo064KoPDOM5vtMTRSV+ZO/cifQY9kyY2fpsOzQ9lcuOJyFNr7kJSuW5onJzz L5FfLGlAbV/vja6Hyo6smyUuC9Rfze2deZx84dRrCEijo3vpAnmVkwAenb/hT23nrw8p IFnlCbp7d2Zbe0OgRG/BnnQZ+nz5VFXSqXZcm+GeLIxTDk4X3rYeslhqdXn9n8ZOaqAG sy2VqdhwbzrLCa0B4gTmzvz1Fv8GgqsLIUS64g9FAZIOgLZicOdJuTI4YjAGJnr/Ku6L spSw== X-Forwarded-Encrypted: i=1; AJvYcCUU/5V/LpKQv6wGUr6TI2PHHfY5FCVWKztd/QgB48Gb3fBRMLsadce0vQ5tekatpQ5fZQVh6g/ZRTDHMKQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yya8DGC0L1YBmV1KI8Pb7Pq/nbXoIsyj7lK1Y5oNAeNh8nK+LRH EOF7/iSr0kwx0yTblJoisFwJuEx5dFvr59JcjuEQIiPtAVEAmWmV7ols/ZX6nwfwO7g= X-Gm-Gg: ASbGncuRDGrRVekITue8RaxXhXDEKByTOW6B7LviLE8GczhEzW3UEY4Nb4AbdDov+dB ezG+SOPkvlCSMbfPsRlDhCun2Wjtl4KSYUT3TM+m8gd1Rgppgy0KrF73W93JrD4GykoK4zAtK7t MCNI0QLHzYCvhw1WwUkKSPYwELMlaGuU/9PErUgnT+iTCiMlJ0vHPqSuuuUMo6C87HruY/ZS/p8 0/KCGkNGy2olx7k2edd4tthgvo6WedzqWcpSQ2g20Zalo3qibSoEfT96A/vVaLnlv+Sa96eLGHr HeapMnGazY27NWe6mLWOavQ8WlPEpWwwN4AI4O+i2xxwfcAmsAC1eBQM7C5427CPQUWJB5KR4ag pALnrabG9UsbYv8DF3PTqfQsszWoxEqFiFIpVBpHfwuavrA== X-Google-Smtp-Source: AGHT+IHjeJKicOQMrv5A2JPa7JA08EcBfBp+Vurfdw26JNZtOFtPu0+xcyBQuRqWuhl/FSD4KBiKAg== X-Received: by 2002:a05:620a:2b87:b0:7d3:8ee7:ca10 with SMTP id af79cd13be357-7d443935786mr517736085a.2.1751034195204; Fri, 27 Jun 2025 07:23:15 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d44323b4c4sm135708785a.106.2025.06.27.07.23.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jun 2025 07:23:14 -0700 (PDT) From: Alex Elder To: lee@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mat.jonczyk@o2.pl, dlan@gentoo.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, troymitchell988@gmail.com, guodong@riscstar.com, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v6 2/8] mfd: simple-mfd-i2c: specify max_register Date: Fri, 27 Jun 2025 09:23:01 -0500 Message-ID: <20250627142309.1444135-3-elder@riscstar.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250627142309.1444135-1-elder@riscstar.com> References: <20250627142309.1444135-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" All devices supported by simple MFD use the same 8-bit register 8-bit value regmap configuration. There is an option available for a device to specify a custome configuration, but no existing device uses it. Lee Jones suggested modifying the simple MFD implementation to remove the generality of the full regmap configuration and add a max_register value to the simple_mfd_data structure. This can be used in the regmap configuration to limit the valid register addresses if desired. It's simpler, and covers all existing and anticipated device types. Signed-off-by: Alex Elder Suggested-by: Lee Jones --- v6: - New patch, changing the simple MFD functionality drivers/mfd/simple-mfd-i2c.c | 18 ++++++------------ drivers/mfd/simple-mfd-i2c.h | 2 +- 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c index 22159913bea03..c1dc315d44dcf 100644 --- a/drivers/mfd/simple-mfd-i2c.c +++ b/drivers/mfd/simple-mfd-i2c.c @@ -24,27 +24,21 @@ =20 #include "simple-mfd-i2c.h" =20 -static const struct regmap_config regmap_config_8r_8v =3D { - .reg_bits =3D 8, - .val_bits =3D 8, -}; - static int simple_mfd_i2c_probe(struct i2c_client *i2c) { const struct simple_mfd_data *simple_mfd_data; - const struct regmap_config *regmap_config; + struct regmap_config regmap_config =3D { }; struct regmap *regmap; int ret; =20 simple_mfd_data =3D device_get_match_data(&i2c->dev); =20 - /* If no regmap_config is specified, use the default 8reg and 8val bits */ - if (!simple_mfd_data || !simple_mfd_data->regmap_config) - regmap_config =3D ®map_config_8r_8v; - else - regmap_config =3D simple_mfd_data->regmap_config; + regmap_config.reg_bits =3D 8; + regmap_config.val_bits =3D 8; + if (simple_mfd_data) + regmap_config.max_register =3D simple_mfd_data->max_register; =20 - regmap =3D devm_regmap_init_i2c(i2c, regmap_config); + regmap =3D devm_regmap_init_i2c(i2c, ®map_config); if (IS_ERR(regmap)) return PTR_ERR(regmap); =20 diff --git a/drivers/mfd/simple-mfd-i2c.h b/drivers/mfd/simple-mfd-i2c.h index 7cb2bdd347d97..4121fe1bc1d70 100644 --- a/drivers/mfd/simple-mfd-i2c.h +++ b/drivers/mfd/simple-mfd-i2c.h @@ -24,9 +24,9 @@ #include =20 struct simple_mfd_data { - const struct regmap_config *regmap_config; const struct mfd_cell *mfd_cell; size_t mfd_cell_size; + unsigned int max_register; }; =20 #endif /* __MFD_SIMPLE_MFD_I2C_H */ --=20 2.45.2