From nobody Wed Oct 8 13:21:51 2025 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF120265621 for ; Fri, 27 Jun 2025 10:29:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751020161; cv=none; b=o0nFk1pYkeBmRPqEJOzrqncFLd3BGTVpUH+Pra/+VQUzRVndtfxHHrouXNNHtE15ZCBMLzBdzIv6ovLf3sq88GJrPjCBtVjEABgNpJ4qVZjYtkv0XPX7iaSsGNhC/KFKwBD1Ebi4fDFqevZvBaMWNScHATuwAFLdZMXnuNfqW30= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751020161; c=relaxed/simple; bh=RtSqrL5NPnrIkXjUCqt5JUaUtLmPHtutEkZzbuUiyR4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k02Q+lrbOLowvdMZ7Rd9fGhUa3yb8u5EOVl3I8jnmcxjNxYNAEndvJsdcoQock2mcH/3LdeizYh9Dto1pCG4MhbGKzh48t2X4hPvt+AdH057pa1Im/3SFNL0lnu2C5VSDgzU7GimsuN+j7S64Gt4DHpboTOzIzc4oxsUhE3DoBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=IEpoHaoc; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=D99svzmz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=IEpoHaoc; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=D99svzmz; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="IEpoHaoc"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="D99svzmz"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="IEpoHaoc"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="D99svzmz" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1569F1F390; Fri, 27 Jun 2025 10:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751020156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3eFktvj1dMXg1kcORPvVDlpnpmrTK5eI/7k3r/5suas=; b=IEpoHaoclu1UMC0sy/HVvUeghz8Sfd2vQ4wZ9DQM0tiMCfTiCKUZxwfY0yH+I2oot08j/K 7Vc0Gx9hv87+Vv1CyPEcxAwvAX9K2aoVz04FZCxn5r+TEYrOdauNRxqNiAW3hnOgRCfym7 bAq3KS881Z6b4iVcmschiw9/3+nNYHY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751020156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3eFktvj1dMXg1kcORPvVDlpnpmrTK5eI/7k3r/5suas=; b=D99svzmzvZEvx+mIu1Pm1VluCazWc8TYTi2VIEq/RXWmHc5mK2hG7OhA9q/26UDWjRc0cV Girxo+cNYTSxu6DA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IEpoHaoc; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=D99svzmz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751020156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3eFktvj1dMXg1kcORPvVDlpnpmrTK5eI/7k3r/5suas=; b=IEpoHaoclu1UMC0sy/HVvUeghz8Sfd2vQ4wZ9DQM0tiMCfTiCKUZxwfY0yH+I2oot08j/K 7Vc0Gx9hv87+Vv1CyPEcxAwvAX9K2aoVz04FZCxn5r+TEYrOdauNRxqNiAW3hnOgRCfym7 bAq3KS881Z6b4iVcmschiw9/3+nNYHY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751020156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3eFktvj1dMXg1kcORPvVDlpnpmrTK5eI/7k3r/5suas=; b=D99svzmzvZEvx+mIu1Pm1VluCazWc8TYTi2VIEq/RXWmHc5mK2hG7OhA9q/26UDWjRc0cV Girxo+cNYTSxu6DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 949EE13A8E; Fri, 27 Jun 2025 10:29:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id iKmYIXtyXmgIAgAAD6G6ig (envelope-from ); Fri, 27 Jun 2025 10:29:15 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Muchun Song , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v3 1/5] mm,hugetlb: Change mechanism to detect a COW on private mapping Date: Fri, 27 Jun 2025 12:29:00 +0200 Message-ID: <20250627102904.107202-2-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250627102904.107202-1-osalvador@suse.de> References: <20250627102904.107202-1-osalvador@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[8]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Level: X-Spam-Flag: NO X-Rspamd-Queue-Id: 1569F1F390 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: -3.01 Content-Type: text/plain; charset="utf-8" hugetlb_wp() checks whether the process is trying to COW on a private mappi= ng in order to know whether the reservation for that address was already consu= med or not. If it was consumed and we are the ownner of the mapping, the folio will hav= e to be unmapped from the other processes. Currently, that check is done by looking up the folio in the pagecache and compare it to the folio which is mapped in our pagetables. If it differs, it means we already mapped it privately before, consuming a reservation on the way. All we are interested in is whether the mapped folio is anonymous, so we can simplify and check for that instead. Also, we transition from a trylock to a folio_lock, since the former was on= ly needed when hugetlb_fault() had to lock both folios, in order to avoid dead= lock. Fixes: 40549ba8f8e0 ("hugetlb: use new vma_lock for pmd sharing synchroniza= tion") Reported-by: Gavin Guo Closes: https://lore.kernel.org/lkml/20250513093448.592150-1-gavinguo@igali= a.com/ Signed-off-by: Oscar Salvador Suggested-by: Peter Xu Acked-by: David Hildenbrand --- mm/hugetlb.c | 82 +++++++++++++++------------------------------------- 1 file changed, 24 insertions(+), 58 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 8746ed2fec13..87f2d8acdc8a 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6152,8 +6152,7 @@ static void unmap_ref_private(struct mm_struct *mm, s= truct vm_area_struct *vma, * cannot race with other handlers or page migration. * Keep the pte_same checks anyway to make transition from the mutex easie= r. */ -static vm_fault_t hugetlb_wp(struct folio *pagecache_folio, - struct vm_fault *vmf) +static vm_fault_t hugetlb_wp(struct vm_fault *vmf) { struct vm_area_struct *vma =3D vmf->vma; struct mm_struct *mm =3D vma->vm_mm; @@ -6215,16 +6214,17 @@ static vm_fault_t hugetlb_wp(struct folio *pagecach= e_folio, PageAnonExclusive(&old_folio->page), &old_folio->page); =20 /* - * If the process that created a MAP_PRIVATE mapping is about to - * perform a COW due to a shared page count, attempt to satisfy - * the allocation without using the existing reserves. The pagecache - * page is used to determine if the reserve at this address was - * consumed or not. If reserves were used, a partial faulted mapping - * at the time of fork() could consume its reserves on COW instead - * of the full address range. + * If the process that created a MAP_PRIVATE mapping is about to perform + * a COW due to a shared page count, attempt to satisfy the allocation + * without using the existing reserves. + * In order to determine where this is a COW on a MAP_PRIVATE mapping it + * is enough to check whether the old_folio is anonymous. This means that + * the reserve for this address was consumed. If reserves were used, a + * partial faulted mapping at the fime of fork() could consume its reserv= es + * on COW instead of the full address range. */ if (is_vma_resv_set(vma, HPAGE_RESV_OWNER) && - old_folio !=3D pagecache_folio) + folio_test_anon(old_folio)) cow_from_owner =3D true; =20 folio_get(old_folio); @@ -6603,7 +6603,7 @@ static vm_fault_t hugetlb_no_page(struct address_spac= e *mapping, hugetlb_count_add(pages_per_huge_page(h), mm); if ((vmf->flags & FAULT_FLAG_WRITE) && !(vma->vm_flags & VM_SHARED)) { /* Optimization, do the COW without a second fault */ - ret =3D hugetlb_wp(folio, vmf); + ret =3D hugetlb_wp(vmf); } =20 spin_unlock(vmf->ptl); @@ -6671,10 +6671,8 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, struc= t vm_area_struct *vma, vm_fault_t ret; u32 hash; struct folio *folio =3D NULL; - struct folio *pagecache_folio =3D NULL; struct hstate *h =3D hstate_vma(vma); struct address_space *mapping; - int need_wait_lock =3D 0; struct vm_fault vmf =3D { .vma =3D vma, .address =3D address & huge_page_mask(h), @@ -6769,8 +6767,7 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, struct= vm_area_struct *vma, * If we are going to COW/unshare the mapping later, we examine the * pending reservations for this page now. This will ensure that any * allocations necessary to record that reservation occur outside the - * spinlock. Also lookup the pagecache page now as it is used to - * determine if a reservation has been consumed. + * spinlock. */ if ((flags & (FAULT_FLAG_WRITE|FAULT_FLAG_UNSHARE)) && !(vma->vm_flags & VM_MAYSHARE) && !huge_pte_write(vmf.orig_pte)) { @@ -6780,11 +6777,6 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, struc= t vm_area_struct *vma, } /* Just decrements count, does not deallocate */ vma_end_reservation(h, vma, vmf.address); - - pagecache_folio =3D filemap_lock_hugetlb_folio(h, mapping, - vmf.pgoff); - if (IS_ERR(pagecache_folio)) - pagecache_folio =3D NULL; } =20 vmf.ptl =3D huge_pte_lock(h, mm, vmf.pte); @@ -6798,10 +6790,6 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, struc= t vm_area_struct *vma, (flags & FAULT_FLAG_WRITE) && !huge_pte_write(vmf.orig_pte)) { if (!userfaultfd_wp_async(vma)) { spin_unlock(vmf.ptl); - if (pagecache_folio) { - folio_unlock(pagecache_folio); - folio_put(pagecache_folio); - } hugetlb_vma_unlock_read(vma); mutex_unlock(&hugetlb_fault_mutex_table[hash]); return handle_userfault(&vmf, VM_UFFD_WP); @@ -6813,24 +6801,20 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, stru= ct vm_area_struct *vma, /* Fallthrough to CoW */ } =20 - /* - * hugetlb_wp() requires page locks of pte_page(vmf.orig_pte) and - * pagecache_folio, so here we need take the former one - * when folio !=3D pagecache_folio or !pagecache_folio. - */ - folio =3D page_folio(pte_page(vmf.orig_pte)); - if (folio !=3D pagecache_folio) - if (!folio_trylock(folio)) { - need_wait_lock =3D 1; - goto out_ptl; - } - - folio_get(folio); - if (flags & (FAULT_FLAG_WRITE|FAULT_FLAG_UNSHARE)) { if (!huge_pte_write(vmf.orig_pte)) { - ret =3D hugetlb_wp(pagecache_folio, &vmf); - goto out_put_page; + /* hugetlb_wp() requires page locks of pte_page(vmf.orig_pte) */ + folio =3D page_folio(pte_page(vmf.orig_pte)); + folio_get(folio); + spin_unlock(vmf.ptl); + folio_lock(folio); + spin_lock(vmf.ptl); + if (likely(pte_same(vmf.orig_pte, + huge_ptep_get(mm, vmf.address, vmf.pte)))) + ret =3D hugetlb_wp(&vmf); + folio_unlock(folio); + folio_put(folio); + goto out_ptl; } else if (likely(flags & FAULT_FLAG_WRITE)) { vmf.orig_pte =3D huge_pte_mkdirty(vmf.orig_pte); } @@ -6839,17 +6823,8 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, struc= t vm_area_struct *vma, if (huge_ptep_set_access_flags(vma, vmf.address, vmf.pte, vmf.orig_pte, flags & FAULT_FLAG_WRITE)) update_mmu_cache(vma, vmf.address, vmf.pte); -out_put_page: - if (folio !=3D pagecache_folio) - folio_unlock(folio); - folio_put(folio); out_ptl: spin_unlock(vmf.ptl); - - if (pagecache_folio) { - folio_unlock(pagecache_folio); - folio_put(pagecache_folio); - } out_mutex: hugetlb_vma_unlock_read(vma); =20 @@ -6861,15 +6836,6 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, struc= t vm_area_struct *vma, vma_end_read(vma); =20 mutex_unlock(&hugetlb_fault_mutex_table[hash]); - /* - * Generally it's safe to hold refcount during waiting page lock. But - * here we just wait to defer the next page fault to avoid busy loop and - * the page is not used after unlocked before returning from the current - * page fault. So we are safe from accessing freed page, even if we wait - * here without taking refcount. - */ - if (need_wait_lock) - folio_wait_locked(folio); return ret; } =20 --=20 2.50.0 From nobody Wed Oct 8 13:21:51 2025 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6585F29B8CE for ; Fri, 27 Jun 2025 10:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751020167; cv=none; b=BBEhBaWdv/VTdcvi/ZLetXnQYPe2OPQNjMFsMOTae2jVE8dKLo5ZRbqbwQbv2LrAlG+I4crxD9kD53w8Z99PhyPEVUMmHS50JOo9d19NPxm881zi5U1XSoDdPOmyo844rVqh2/9Oivtc2rIVLjmITMs0TtciOVq4VU+1vZd3BBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751020167; c=relaxed/simple; bh=tMSZrM567WGrFzyhrwSKI8dZCdOlHInFkR86DKCo15s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L02HgyQfaunU+67iGl4lrnIzy72kiqgwx9Pbb+7sW61Gh6RgrIl5Yh7kOa6l8qkosHDupXFOcFnK4mL75xau51m4JJvPALHmXB/f5n5rl9yWrpysPkYY71vHjWD2WZWxrsjmJXOT3IUEbbGQAirnG4hl0iMhiQn8fAe/ECf50iw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=qiwJZJ4s; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=dN15uj3R; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=qiwJZJ4s; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=dN15uj3R; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="qiwJZJ4s"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="dN15uj3R"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="qiwJZJ4s"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="dN15uj3R" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9FBCB21179; Fri, 27 Jun 2025 10:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751020156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=evbYQwrIEyoGBUi3yWxrK/P56VGnTwRekMGyPPYLQ0g=; b=qiwJZJ4sWMmcSOenzHf0FWdaqjM06zZLCXLq/ixq5a5Bd4jTDZoeESblyYJXTcwhVmSBHb zgXXzO2c6DYJqkiCM+moSdUjCILUqsWZxDBNeIuTgeu4wTlja3heogQBeuQyOOb3bNgT3n 0RM/slNyD1GJ0BAtRef9h+9WVTcGXk8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751020156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=evbYQwrIEyoGBUi3yWxrK/P56VGnTwRekMGyPPYLQ0g=; b=dN15uj3R3/olVSArz5UrBVfaq59DnLPe9+T6lSTGP+9aCrJF18kYtaQwp8HiwrCfGdFd2O N9x1K9XTZNBtNvCA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=qiwJZJ4s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=dN15uj3R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751020156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=evbYQwrIEyoGBUi3yWxrK/P56VGnTwRekMGyPPYLQ0g=; b=qiwJZJ4sWMmcSOenzHf0FWdaqjM06zZLCXLq/ixq5a5Bd4jTDZoeESblyYJXTcwhVmSBHb zgXXzO2c6DYJqkiCM+moSdUjCILUqsWZxDBNeIuTgeu4wTlja3heogQBeuQyOOb3bNgT3n 0RM/slNyD1GJ0BAtRef9h+9WVTcGXk8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751020156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=evbYQwrIEyoGBUi3yWxrK/P56VGnTwRekMGyPPYLQ0g=; b=dN15uj3R3/olVSArz5UrBVfaq59DnLPe9+T6lSTGP+9aCrJF18kYtaQwp8HiwrCfGdFd2O N9x1K9XTZNBtNvCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 26C3F13786; Fri, 27 Jun 2025 10:29:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YLC2BnxyXmgIAgAAD6G6ig (envelope-from ); Fri, 27 Jun 2025 10:29:16 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Muchun Song , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v3 2/5] mm,hugetlb: Sort out folio locking in the faulting path Date: Fri, 27 Jun 2025 12:29:01 +0200 Message-ID: <20250627102904.107202-3-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250627102904.107202-1-osalvador@suse.de> References: <20250627102904.107202-1-osalvador@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 9FBCB21179 X-Rspamd-Action: no action X-Spam-Flag: NO X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[8]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Score: -3.01 X-Spam-Level: Content-Type: text/plain; charset="utf-8" Recent conversations showed that there was a misunderstanding about why we were locking the folio prior to call in hugetlb_wp(). In fact, as soon as we have the folio mapped into the pagetables, we no lon= ger need to hold it locked, because we know that no concurrent truncation could= have happened. There is only one case where the folio needs to be locked, and that is when= we are handling an anonymous folio, because hugetlb_wp() will check whether it= can re-use it exclusively for the process that is faulting it in. So, pass the folio locked to hugetlb_wp() when that is the case. Suggested-by: David Hildenbrand Signed-off-by: Oscar Salvador --- mm/hugetlb.c | 33 +++++++++++++++++++++++++++------ 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 87f2d8acdc8a..15113345babb 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6437,6 +6437,7 @@ static vm_fault_t hugetlb_no_page(struct address_spac= e *mapping, pte_t new_pte; bool new_folio, new_pagecache_folio =3D false; u32 hash =3D hugetlb_fault_mutex_hash(mapping, vmf->pgoff); + bool folio_locked =3D true; =20 /* * Currently, we are forced to kill the process in the event the @@ -6602,6 +6603,14 @@ static vm_fault_t hugetlb_no_page(struct address_spa= ce *mapping, =20 hugetlb_count_add(pages_per_huge_page(h), mm); if ((vmf->flags & FAULT_FLAG_WRITE) && !(vma->vm_flags & VM_SHARED)) { + /* + * No need to keep file folios locked. See comment in + * hugetlb_fault(). + */ + if (!anon_rmap) { + folio_locked =3D false; + folio_unlock(folio); + } /* Optimization, do the COW without a second fault */ ret =3D hugetlb_wp(vmf); } @@ -6616,7 +6625,8 @@ static vm_fault_t hugetlb_no_page(struct address_spac= e *mapping, if (new_folio) folio_set_hugetlb_migratable(folio); =20 - folio_unlock(folio); + if (folio_locked) + folio_unlock(folio); out: hugetlb_vma_unlock_read(vma); =20 @@ -6803,16 +6813,27 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, stru= ct vm_area_struct *vma, =20 if (flags & (FAULT_FLAG_WRITE|FAULT_FLAG_UNSHARE)) { if (!huge_pte_write(vmf.orig_pte)) { - /* hugetlb_wp() requires page locks of pte_page(vmf.orig_pte) */ + /* + * Anonymous folios need to be lock since hugetlb_wp() + * checks whether we can re-use the folio exclusively + * for us in case we are the only user of it. + */ folio =3D page_folio(pte_page(vmf.orig_pte)); folio_get(folio); + if (!folio_test_anon(folio)) + goto lock_unneeded; + spin_unlock(vmf.ptl); folio_lock(folio); spin_lock(vmf.ptl); - if (likely(pte_same(vmf.orig_pte, - huge_ptep_get(mm, vmf.address, vmf.pte)))) - ret =3D hugetlb_wp(&vmf); - folio_unlock(folio); + if (unlikely(!pte_same(vmf.orig_pte, huge_ptep_get(mm, + vmf.address, vmf.pte)))) + goto unlock_folio; +lock_unneeded: + ret =3D hugetlb_wp(&vmf); +unlock_folio: + if (folio_test_anon(folio)) + folio_unlock(folio); folio_put(folio); goto out_ptl; } else if (likely(flags & FAULT_FLAG_WRITE)) { --=20 2.50.0 From nobody Wed Oct 8 13:21:51 2025 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D3A62BD025 for ; Fri, 27 Jun 2025 10:29:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751020174; cv=none; b=NkehR12wiD53NgBKtnU/toTzHbjT83F3Xo6lJTrWGR+UwSVEf8hriWtrL8Dvexjhg6ICvkmVgWvREm6ftwdRBBxPzDnTj8k9nvXOCxF2P9TVyLmN+Cs9dFInfm2GmbQ2SbxYClWzdYvm19rj/OxXa/PORjVH9UJ1kDPOJvptbI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751020174; c=relaxed/simple; bh=RCT98MJcqLy0wcaKO6p8gPLlDe7Vs074FWtfs+//G7k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dt2jqbHk+Wvshn++6Btc4wnmNvva2Dd+U0SGdpeQl+coWJoYyEFC2ao9df/N86OMGKccubkVVFOy45pUTTyqKxFzC42E3bYJdGC2KibYFtcYyBvszsG+BbPQZdXBIxYIqKOGDdWgxeVuQlKYv621790H1NHa4QkWnBBgz3IWcsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=0d8TrslY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=3UGXTVzu; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=0d8TrslY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=3UGXTVzu; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="0d8TrslY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="3UGXTVzu"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="0d8TrslY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="3UGXTVzu" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 39E4F21185; Fri, 27 Jun 2025 10:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751020157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bq9/EYkAwYHFk8gdnXIfLxkomiePmXJvIrEAfONGHY8=; b=0d8TrslYkmmCf0STyidG7hJQg4vCw9sjE+xqYEd3ATPU/OG8OkIm2WmeuIvWYT5ex9lajL +/FsIMstxncNk4/yGWfp4BQYNb4O8B9PyNOyeEIWU3ho2lpuu3hryKo7aEbNNnT4dpTMUa 529Ea97vJVRF7eRA2V2sw5rBqx/9AiM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751020157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bq9/EYkAwYHFk8gdnXIfLxkomiePmXJvIrEAfONGHY8=; b=3UGXTVzuc9vmjmW+IYe1gALsOuUWEoOTiCsYmTLYvLqORrccCIeZjl9wag/nM352BS6R3C HH4anUCWN4mwrvDg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751020157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bq9/EYkAwYHFk8gdnXIfLxkomiePmXJvIrEAfONGHY8=; b=0d8TrslYkmmCf0STyidG7hJQg4vCw9sjE+xqYEd3ATPU/OG8OkIm2WmeuIvWYT5ex9lajL +/FsIMstxncNk4/yGWfp4BQYNb4O8B9PyNOyeEIWU3ho2lpuu3hryKo7aEbNNnT4dpTMUa 529Ea97vJVRF7eRA2V2sw5rBqx/9AiM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751020157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bq9/EYkAwYHFk8gdnXIfLxkomiePmXJvIrEAfONGHY8=; b=3UGXTVzuc9vmjmW+IYe1gALsOuUWEoOTiCsYmTLYvLqORrccCIeZjl9wag/nM352BS6R3C HH4anUCWN4mwrvDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B1A0613A8E; Fri, 27 Jun 2025 10:29:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SIGuKHxyXmgIAgAAD6G6ig (envelope-from ); Fri, 27 Jun 2025 10:29:16 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Muchun Song , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v3 3/5] mm,hugetlb: Rename anon_rmap to new_anon_folio and make it boolean Date: Fri, 27 Jun 2025 12:29:02 +0200 Message-ID: <20250627102904.107202-4-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250627102904.107202-1-osalvador@suse.de> References: <20250627102904.107202-1-osalvador@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid]; RCVD_TLS_ALL(0.00)[] X-Spam-Level: X-Spam-Flag: NO X-Spam-Score: -2.80 Content-Type: text/plain; charset="utf-8" anon_rmap is used to determine whether the new allocated folio is anonymous. Rename it to something more meaningul like new_anon_folio and make it boole= an, as we use it like that. While we are at it, drop 'new_pagecache_folio' as 'new_anon_folio' is enoug= h to check whether we need to restore the consumed reservation. Signed-off-by: Oscar Salvador --- mm/hugetlb.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 15113345babb..b110394d8d6e 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6427,17 +6427,16 @@ static bool hugetlb_pte_stable(struct hstate *h, st= ruct mm_struct *mm, unsigned static vm_fault_t hugetlb_no_page(struct address_space *mapping, struct vm_fault *vmf) { + u32 hash =3D hugetlb_fault_mutex_hash(mapping, vmf->pgoff); + bool new_folio, new_anon_folio =3D false; struct vm_area_struct *vma =3D vmf->vma; struct mm_struct *mm =3D vma->vm_mm; struct hstate *h =3D hstate_vma(vma); vm_fault_t ret =3D VM_FAULT_SIGBUS; - int anon_rmap =3D 0; - unsigned long size; + bool folio_locked =3D true; struct folio *folio; + unsigned long size; pte_t new_pte; - bool new_folio, new_pagecache_folio =3D false; - u32 hash =3D hugetlb_fault_mutex_hash(mapping, vmf->pgoff); - bool folio_locked =3D true; =20 /* * Currently, we are forced to kill the process in the event the @@ -6536,10 +6535,9 @@ static vm_fault_t hugetlb_no_page(struct address_spa= ce *mapping, ret =3D VM_FAULT_SIGBUS; goto out; } - new_pagecache_folio =3D true; } else { + new_anon_folio =3D true; folio_lock(folio); - anon_rmap =3D 1; } } else { /* @@ -6588,7 +6586,7 @@ static vm_fault_t hugetlb_no_page(struct address_spac= e *mapping, if (!pte_same(huge_ptep_get(mm, vmf->address, vmf->pte), vmf->orig_pte)) goto backout; =20 - if (anon_rmap) + if (new_anon_folio) hugetlb_add_new_anon_rmap(folio, vma, vmf->address); else hugetlb_add_file_rmap(folio); @@ -6607,7 +6605,7 @@ static vm_fault_t hugetlb_no_page(struct address_spac= e *mapping, * No need to keep file folios locked. See comment in * hugetlb_fault(). */ - if (!anon_rmap) { + if (!new_anon_folio) { folio_locked =3D false; folio_unlock(folio); } @@ -6643,7 +6641,8 @@ static vm_fault_t hugetlb_no_page(struct address_spac= e *mapping, backout: spin_unlock(vmf->ptl); backout_unlocked: - if (new_folio && !new_pagecache_folio) + /* We only need to restore reservations for private mappings */ + if (new_anon_folio) restore_reserve_on_error(h, vma, vmf->address, folio); =20 folio_unlock(folio); --=20 2.50.0 From nobody Wed Oct 8 13:21:51 2025 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5AEF265621 for ; Fri, 27 Jun 2025 10:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751020167; cv=none; b=XdV5QxPBwGD9ZRoDb35g8sOjvjKG/P3rNBQ9WMK0T6BOxz4oavz357Ip9r0x3l2OM3gWR2f3yeIzZb5RxzR7bRI6qxxevJSdAQdoUGO1HbjtvN8+9qWKX8lD1NMidnbY4Tdq2pZY86r9POUSKWhORDTF76NH8ZpJgR70ekPPDwk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751020167; c=relaxed/simple; bh=vseYA1og9Dzm9Um8QPlJ2K5kCj40A+SZNuPIon+KCLg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iD7xGlvWJ90aq7IA4MYlrIPDJC5FSFKt2B+54uncOtLuPoVoH9ELZwmBh2bNg07bbBx/ONySAoduGizfNOaHh/YR8QFmkq/v/JKBHfOySMaAJp4i60hIIATy6I6W39Tn3R9w/Mq80MXMf3B5vs2urimloOKAcFRS3mKe8Bwlep0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=aZxfJg82; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=0CrZMoCS; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=aZxfJg82; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=0CrZMoCS; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="aZxfJg82"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="0CrZMoCS"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="aZxfJg82"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="0CrZMoCS" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D8E201F394; Fri, 27 Jun 2025 10:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751020157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HjkIsGEVefVATIO9BVUjIgRSloD/rqP2CC47WtBUxBA=; b=aZxfJg82NIVKvrEb5EaNKaVuop99Uu1oF3AmtCsTMayBk9eQYSyHe3X8PrTdeMEs0xcHnD jbafH1L0qhPtbwyEAlo4kyCFAX35pUNPDOlTarlGxCvH7cUn97iM1ctm7HOWWtMWICOEsC GHqeopw7Z/SM0aBhQ3KNC1vC/vf3c7I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751020157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HjkIsGEVefVATIO9BVUjIgRSloD/rqP2CC47WtBUxBA=; b=0CrZMoCS/wke7+RyuQps0mLylKefoh66HLsouh/NIo21VdYsDqDgP0wuiX/y2NVa6OGbXB A8k95XQKu9EDEwAw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aZxfJg82; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0CrZMoCS DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751020157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HjkIsGEVefVATIO9BVUjIgRSloD/rqP2CC47WtBUxBA=; b=aZxfJg82NIVKvrEb5EaNKaVuop99Uu1oF3AmtCsTMayBk9eQYSyHe3X8PrTdeMEs0xcHnD jbafH1L0qhPtbwyEAlo4kyCFAX35pUNPDOlTarlGxCvH7cUn97iM1ctm7HOWWtMWICOEsC GHqeopw7Z/SM0aBhQ3KNC1vC/vf3c7I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751020157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HjkIsGEVefVATIO9BVUjIgRSloD/rqP2CC47WtBUxBA=; b=0CrZMoCS/wke7+RyuQps0mLylKefoh66HLsouh/NIo21VdYsDqDgP0wuiX/y2NVa6OGbXB A8k95XQKu9EDEwAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 46F8F13A9C; Fri, 27 Jun 2025 10:29:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6HFqDn1yXmgIAgAAD6G6ig (envelope-from ); Fri, 27 Jun 2025 10:29:17 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Muchun Song , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v3 4/5] mm,hugetlb: Drop obsolete comment about non-present pte and second faults Date: Fri, 27 Jun 2025 12:29:03 +0200 Message-ID: <20250627102904.107202-5-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250627102904.107202-1-osalvador@suse.de> References: <20250627102904.107202-1-osalvador@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLfw9wkb71jz54yo3bnq4aib6i)]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Level: X-Spam-Flag: NO X-Rspamd-Queue-Id: D8E201F394 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: -3.01 Content-Type: text/plain; charset="utf-8" There is a comment in hugetlb_fault() that does not hold anymore. This one: /* * vmf.orig_pte could be a migration/hwpoison vmf.orig_pte at this * point, so this check prevents the kernel from going below assuming * that we have an active hugepage in pagecache. This goto expects * the 2nd page fault, and is_hugetlb_entry_(migration|hwpoisoned) * check will properly handle it. */ This was written because back in the day we used to do: hugetlb_fault () { ptep =3D huge_pte_offset(...) if (ptep) { entry =3D huge_ptep_get(ptep) if (unlikely(is_hugetlb_entry_migration(entry)) ... else if (unlikely(is_hugetlb_entry_hwpoisoned(entry))) ... } ... ... /* * entry could be a migration/hwpoison entry at this point, so this * check prevents the kernel from going below assuming that we have * a active hugepage in pagecache. This goto expects the 2nd page fault, * and is_hugetlb_entry_(migration|hwpoisoned) check will properly * handle it. */ if (!pte_present(entry)) goto out_mutex; ... } The code was designed to check for hwpoisoned/migration entries upfront, and then bail out if further down the pte was not present anymore, relying on the second fault to properly handle migration/hwpoison entries t= hat time around. The way we handle this is different nowadays, so drop the misleading commen= t. Signed-off-by: Oscar Salvador --- mm/hugetlb.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index b110394d8d6e..0a6a519fabe5 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6747,13 +6747,7 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, struc= t vm_area_struct *vma, =20 ret =3D 0; =20 - /* - * vmf.orig_pte could be a migration/hwpoison vmf.orig_pte at this - * point, so this check prevents the kernel from going below assuming - * that we have an active hugepage in pagecache. This goto expects - * the 2nd page fault, and is_hugetlb_entry_(migration|hwpoisoned) - * check will properly handle it. - */ + /* Not present, either a migration or a hwpoisoned entry */ if (!pte_present(vmf.orig_pte)) { if (unlikely(is_hugetlb_entry_migration(vmf.orig_pte))) { /* --=20 2.50.0 From nobody Wed Oct 8 13:21:51 2025 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712C02BDC1D for ; Fri, 27 Jun 2025 10:29:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751020174; cv=none; b=YubU01fQeWAG2mUkw7SoTxLo1pWxgoxXCGJKBHVWIbGcb8yaYwcdtX+G7ePcI8PGmP93XudI0ecg8R077tSOLPQ17j/BuLk4es2iPuH/TsZ8ebg3tRn+wxpwmFFiQ+EM0GZP3qRCP5Y0v2QoxIXp8MbGueQkYZNI5hdGo2epkHM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751020174; c=relaxed/simple; bh=DMB1IokfNeWikJ+Ngbt+5vobnNSrFFXdTEJSNQ4yk/Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dJ4Kw0BvKLozU/nQWcmNnH8obF5oWgBEaCFbTSDj2r6xRYeacbzcmefdnWx9mCSzSgKdCBeaSbKZsK8d7KZkrdiYxXiY8r06pGPOR//oGYKosS3UJojnlstl74gNn7vQ85VhzfVoPdpa7C3tSikr8HjzwEcwj1sIFi4m0q3KGa0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=sHhER//3; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=jSc8xpIH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=sHhER//3; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=jSc8xpIH; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="sHhER//3"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="jSc8xpIH"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="sHhER//3"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="jSc8xpIH" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 64CA41F441; Fri, 27 Jun 2025 10:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751020158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kfi8/l69UuNC8lJU7DgbzOuhvxfNUkN/vTlkmP1mOoE=; b=sHhER//3GH862S3JMnhCJeTtFLSEHJMOWm/MExazrOAbpCVX+1Bx/pZTiCY/KN5lrf/WsV aiO/VxgxAGthlKn9k/GSW/9SUiuXIwr66IkeEEiivtYSpdCu1l2mSScoyROgozHCt/05Yr Yk21vOJ71appP356AQTMKW/SQyLCEk4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751020158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kfi8/l69UuNC8lJU7DgbzOuhvxfNUkN/vTlkmP1mOoE=; b=jSc8xpIHdSpHpvhTXFG2YZY5CsodQ+lEbZ9WZbVjjCLkuh6b7kCUKYqqWOOAwUTtRbo3LS WDbwfVqHxdgGjuAA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="sHhER//3"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jSc8xpIH DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751020158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kfi8/l69UuNC8lJU7DgbzOuhvxfNUkN/vTlkmP1mOoE=; b=sHhER//3GH862S3JMnhCJeTtFLSEHJMOWm/MExazrOAbpCVX+1Bx/pZTiCY/KN5lrf/WsV aiO/VxgxAGthlKn9k/GSW/9SUiuXIwr66IkeEEiivtYSpdCu1l2mSScoyROgozHCt/05Yr Yk21vOJ71appP356AQTMKW/SQyLCEk4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751020158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kfi8/l69UuNC8lJU7DgbzOuhvxfNUkN/vTlkmP1mOoE=; b=jSc8xpIHdSpHpvhTXFG2YZY5CsodQ+lEbZ9WZbVjjCLkuh6b7kCUKYqqWOOAwUTtRbo3LS WDbwfVqHxdgGjuAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E109413786; Fri, 27 Jun 2025 10:29:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gCIaNH1yXmgIAgAAD6G6ig (envelope-from ); Fri, 27 Jun 2025 10:29:17 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Muchun Song , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v3 5/5] mm,hugetlb: Drop unlikelys from hugetlb_fault Date: Fri, 27 Jun 2025 12:29:04 +0200 Message-ID: <20250627102904.107202-6-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250627102904.107202-1-osalvador@suse.de> References: <20250627102904.107202-1-osalvador@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 64CA41F441 X-Rspamd-Action: no action X-Spam-Flag: NO X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLfw9wkb71jz54yo3bnq4aib6i)]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Score: -3.01 X-Spam-Level: Content-Type: text/plain; charset="utf-8" The unlikely predates an era where we were checking for hwpoisoned/migration entries prior to checking whether the pte was present. Currently, we check for the pte to be a migration/hwpoison entry after we have checked that is not present, so it must be either one or the other. Signed-off-by: Oscar Salvador --- mm/hugetlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 0a6a519fabe5..64d628755b7f 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6749,7 +6749,7 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, struct= vm_area_struct *vma, =20 /* Not present, either a migration or a hwpoisoned entry */ if (!pte_present(vmf.orig_pte)) { - if (unlikely(is_hugetlb_entry_migration(vmf.orig_pte))) { + if (is_hugetlb_entry_migration(vmf.orig_pte)) { /* * Release the hugetlb fault lock now, but retain * the vma lock, because it is needed to guard the @@ -6760,7 +6760,7 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, struct= vm_area_struct *vma, mutex_unlock(&hugetlb_fault_mutex_table[hash]); migration_entry_wait_huge(vma, vmf.address, vmf.pte); return 0; - } else if (unlikely(is_hugetlb_entry_hwpoisoned(vmf.orig_pte))) + } else if (is_hugetlb_entry_hwpoisoned(vmf.orig_pte)) ret =3D VM_FAULT_HWPOISON_LARGE | VM_FAULT_SET_HINDEX(hstate_index(h)); goto out_mutex; --=20 2.50.0