From nobody Wed Oct 8 14:20:56 2025 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A9272EF9C5; Thu, 26 Jun 2025 19:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750965659; cv=none; b=fKtLmQMKrqPcYwpL6ddiNoItIAQfnY78tPc/m6jsBWmSyqiHKaVHtDwPMV7v72uk1AKCp0mgTWkLaDYy7vD9oTXMCfsMvg9bcAzt4wsj3NJXTbAybeL8aOWNPsW3J/7VzlrHm6yS7zoRP2VLgNU0MHCTvLcq+gQosY9v4kb1V2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750965659; c=relaxed/simple; bh=NWDPKseR7FgqJe1BUa7IKDcIuriaLO9oc++4NoGT7So=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YiU0hPPrHAMIenE8j1LjQPLe3ORdwdeyO/GudZpmSp596oTJMAjPrcOEhWTcM2U12t8FkHRqejqA+Aq3ezZsJqMzI51owXfGTzZyTA5+6XwcrxLPn4dbpCTg6bVHj2oVdyUHuKTsmxPaCiDWcDYhfFklA7XCaV0IiEV8QZ5GENY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=LufkMeHJ; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="LufkMeHJ" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A711D2600B; Thu, 26 Jun 2025 21:20:56 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id oCsJiwgKFbxM; Thu, 26 Jun 2025 21:20:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1750965656; bh=NWDPKseR7FgqJe1BUa7IKDcIuriaLO9oc++4NoGT7So=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=LufkMeHJflu/2/hw6zQgWML1OwQT3aV93y1CJyVkN0xr8SlPhI1BueFfFavVqRMLl kql4TcXR0IT+00S+pg/ffp+NlKzPs3MHdQW2z/maueuhEonk8vSF95O55s0xUOCpwb TQ98HFTy5N1tad/phEppHUnCrOfarzsTybh6OSwrd9Bre3im2VGRDbCdHCk2kkQilj 3/8Ebfu06NP/Sm+nXAePoDOKpZ7HcCKIG9qs/gVjRVRtgtR+R+8PMgH47XkAifbGO6 TkATHF5Q2rp83O4pPhEzIoGt6B+WKROMEoCu+cHZ0lhUPxylADl9X1tLh5gP395/09 a+8QRrrOH5ViQ== From: Kaustabh Chakraborty Date: Fri, 27 Jun 2025 00:50:28 +0530 Subject: [PATCH v3 1/3] dt-bindings: display: samsung,exynos7-decon: add properties for iommus and ports Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250627-exynosdrm-decon-v3-1-5b456f88cfea@disroot.org> References: <20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org> In-Reply-To: <20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org> To: Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Alim Akhtar , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Conor Dooley , Ajay Kumar , Akshu Agrawal , Krzysztof Kozlowski , Conor Dooley Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1750965633; l=1210; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=NWDPKseR7FgqJe1BUa7IKDcIuriaLO9oc++4NoGT7So=; b=m+aG9N+L2Gn97HTnVn7EGvna1RTNUGO5iN00NlXhBtqiDuUyW3bfmzBBGQ3fbayDX3yMBnGjK unsnSIaDQQDCHNl3dSJ3MC4Dc7iKGm+P7/kjxGc0dUVLCuFxpJXC7LF X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Similar to FIMD and Exynos5433's DECON, the Exynos7 DECON hardware: - May optionally require an IOMMU to initialize a display region. - May require a port connection to another block, say an MIC or a DSI master. Document these bindings in the devicetree schema. Signed-off-by: Kaustabh Chakraborty --- .../bindings/display/samsung/samsung,exynos7-decon.yaml | 8 ++++= ++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,exyn= os7-decon.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,= exynos7-decon.yaml index 53916e4c95d8c0369138941a556c23f5d42fbd39..1e9500c86590d555cfa6f04790e= 2b64da291b78b 100644 --- a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-dec= on.yaml +++ b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-dec= on.yaml @@ -80,6 +80,14 @@ properties: - const: vsync - const: lcd_sys =20 + iommus: + maxItems: 1 + + ports: + $ref: /schemas/graph.yaml#/properties/ports + description: + Contains a port which is connected to mic or dsim node. + power-domains: maxItems: 1 =20 --=20 2.49.0 From nobody Wed Oct 8 14:20:56 2025 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40C432EF9B4; Thu, 26 Jun 2025 19:21:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750965673; cv=none; b=SUA1N7mOI701PCq9uHlld25OXkdARpZyydovammi6Ur9GxXlux256MINfii1ZM1x4bQEPe72y0m8ioKYXSKN1sYj8VplsSBLCni7HuwREQ2l/s2NMxUMXq/1oqmtBzMlO15q/pMaLZooufuAJwlPBPcj9dFMVvLUTHB3Q9WdDag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750965673; c=relaxed/simple; bh=KbVD8W1QVZAFqfq85+oBgINP5cpWpTrtB33hPtktZ+Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FozYk1vF0Y3jD3z9NfOPTQ6arZT3OMr2v8CPEejEa13Ztk7vVGLjUOL6pFhqCnemYVzqquCYQ0QHRwMFH4X5dEIWlKX3OD9j3vZXTxeX/dn8UrWv55/vE9Ypt+VfYvnvDUT5hM7ZheaK19tqNc5Y+uGWTt7HB5vn6F0tqXYmUPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=MG8glo+f; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="MG8glo+f" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 7C5AB25EA5; Thu, 26 Jun 2025 21:21:09 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id HpXY8ydbfAis; Thu, 26 Jun 2025 21:21:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1750965666; bh=KbVD8W1QVZAFqfq85+oBgINP5cpWpTrtB33hPtktZ+Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=MG8glo+fruRM+8D2BU0fMp0cvDbaYgtOlshEO7nse3GJghFUYkSKj4Ql7t0om0X9j UrekMns4NSUP1mcIZTQXP3iSL8DQZZ+uUNOsxmH6xnPinqovDbTxX6zjzBb8kh4urL 5NDJ5EQOSVqcDZmCh0mcXhIy+x+DVgRwb/8BiINWK/BKhT6mAuAYMy5TIHEF0UxEKI hR5FSu+F3XwBjPR7gst4RHrbIqpEDJeC6uGdsyVS0465s9bzoxvsjv99Q/ByGrz6gH R/mBRuOrF/NI4/AXfwhJs9GYnCuYpWQySdZd1Ot4Zo3HB9SZJwB0YCojuaGOMXm/Y2 WkeugJ3uib13w== From: Kaustabh Chakraborty Date: Fri, 27 Jun 2025 00:50:29 +0530 Subject: [PATCH v3 2/3] drm/exynos: exynos7_drm_decon: fix call of decon_commit() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250627-exynosdrm-decon-v3-2-5b456f88cfea@disroot.org> References: <20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org> In-Reply-To: <20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org> To: Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Alim Akhtar , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Conor Dooley , Ajay Kumar , Akshu Agrawal , Krzysztof Kozlowski , Conor Dooley Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kaustabh Chakraborty , stable@vger.kernel.org X-Developer-Signature: v=1; a=ed25519-sha256; t=1750965633; l=1313; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=KbVD8W1QVZAFqfq85+oBgINP5cpWpTrtB33hPtktZ+Q=; b=l6zKg3a8pR9r1QKiRsjmvmVHGHaF1tZJjt8lK5gh/2h/KiirJyc9jqoyg3mzVMn7Vci4KJW5R MMkXTr3ADETC4zz5BREvnEqVAErWJijHMYQhLXViseVxR+jLvxzVTRo X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= decon_commit() has a condition guard at the beginning: if (ctx->suspended) return; But, when it is being called from decon_atomic_enable(), ctx->suspended is still set to true, which prevents its execution. decon_commit() is vital for setting up display timing values, without which the display pipeline fails to function properly. Call the function after ctx->suspended is set to false as a fix. Cc: stable@vger.kernel.org Fixes: 96976c3d9aff ("drm/exynos: Add DECON driver") Signed-off-by: Kaustabh Chakraborty --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/e= xynos/exynos7_drm_decon.c index f91daefa9d2bc5e314c279822047e60ee0d7ca99..43bcbe2e2917df43d7c2d27a977= 1e892628dd682 100644 --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c @@ -583,9 +583,9 @@ static void decon_atomic_enable(struct exynos_drm_crtc = *crtc) if (test_and_clear_bit(0, &ctx->irq_flags)) decon_enable_vblank(ctx->crtc); =20 - decon_commit(ctx->crtc); - ctx->suspended =3D false; + + decon_commit(ctx->crtc); } =20 static void decon_atomic_disable(struct exynos_drm_crtc *crtc) --=20 2.49.0 From nobody Wed Oct 8 14:20:56 2025 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 949F82264D3; Thu, 26 Jun 2025 19:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750965681; cv=none; b=sCqa9k+x4lfFGqtAEr2A3CT3/2UTJeglcDyLX6K4G9LWAtM2nPkHwGFtslEZx7dXM40RRZ0yKiApYPDN/k9IeNjD9Rv4cqr4fNE6zx/2LQadj2y91HFXt1Ez6ecMlwv4PGyp9uL77NW5v8KDJt9/XccNJyT3kcX8Ryekqze+1fg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750965681; c=relaxed/simple; bh=D8o5aKxiqPDfJaP/Wlra9wiusUGgyAqkKg4+LuSvXis=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SBK+llowCJ7++b0V18hHNeQEwD+D+JGwzS91/eAKPb+rjPnI5kDhOgUbLcNM3KwASECE4RTb/k8oRjoGalJjo3lFXvRu52GPRDDqycy9jHv1CHiBxQmfZViBQ69D65vxf9mnxdxOkAsX56x6TzRaWg99GMcKK1J285+rvbDaf4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=Pn62ZQw+; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="Pn62ZQw+" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 3CA0825D64; Thu, 26 Jun 2025 21:21:18 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id IstntXv3cZpE; Thu, 26 Jun 2025 21:21:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1750965677; bh=D8o5aKxiqPDfJaP/Wlra9wiusUGgyAqkKg4+LuSvXis=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Pn62ZQw+QE0tjCn0VDNyryMq5NiYYLWChHURVJLwXWY2Rtsz8kcRaMh+VeqrNGfPK QuawYtCEC5pwvYquUJF0BTaMYUdEP8mymD61+I3J8Xi2vCBuYj5GsovKtkj0QKWpcJ SWkHfNKqjS2N/+UHOsL9ZJKWbbnkBf5hR0OTTNwaIr4OY7IxzOxJETsWYDP7jQ8uFV 5DEerlKJvRnt3vZ9+CT63xLNQXw5Jd/E3Tn9H3C4usiVQ7WnH/WkraBe41J2S/gY9A aPvN8jGDGw3u9oyx+EU+4ao2KrmF/gUBkSa5srdyrzqIdNeg7YFct6bsKZaG8tBtQ/ dhC4GJ1vo/jxw== From: Kaustabh Chakraborty Date: Fri, 27 Jun 2025 00:50:30 +0530 Subject: [PATCH v3 3/3] drm/exynos: exynos7_drm_decon: add vblank check in IRQ handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250627-exynosdrm-decon-v3-3-5b456f88cfea@disroot.org> References: <20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org> In-Reply-To: <20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org> To: Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Alim Akhtar , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Conor Dooley , Ajay Kumar , Akshu Agrawal , Krzysztof Kozlowski , Conor Dooley Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kaustabh Chakraborty , stable@vger.kernel.org X-Developer-Signature: v=1; a=ed25519-sha256; t=1750965633; l=1467; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=D8o5aKxiqPDfJaP/Wlra9wiusUGgyAqkKg4+LuSvXis=; b=Zaidk2/MU65T4C2DakEpl1E0vJyg4XwWxX2szoui0qZZcrrbhIkFhB55oDTaWDS1w+QzFykVB dtvzv6gyjheBTohjdUEszCp2rVBomHkZYW6z6n3GgQhxqz5uqjV/bmL X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= If there's support for another console device (such as a TTY serial), the kernel occasionally panics during boot. The panic message and a relevant snippet of the call stack is as follows: Unable to handle kernel NULL pointer dereference at virtual address 00000= 0000000000 Call trace: drm_crtc_handle_vblank+0x10/0x30 (P) decon_irq_handler+0x88/0xb4 [...] Otherwise, the panics don't happen. This indicates that it's some sort of race condition. Add a check to validate if the drm device can handle vblanks before calling drm_crtc_handle_vblank() to avoid this. Cc: stable@vger.kernel.org Fixes: 96976c3d9aff ("drm/exynos: Add DECON driver") Signed-off-by: Kaustabh Chakraborty --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/e= xynos/exynos7_drm_decon.c index 43bcbe2e2917df43d7c2d27a9771e892628dd682..c0c0f23169c993ac315fc8d7bcb= d09ea6ec9966a 100644 --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c @@ -636,6 +636,10 @@ static irqreturn_t decon_irq_handler(int irq, void *de= v_id) if (!ctx->drm_dev) goto out; =20 + /* check if crtc and vblank have been initialized properly */ + if (!drm_dev_has_vblank(ctx->drm_dev)) + goto out; + if (!ctx->i80_if) { drm_crtc_handle_vblank(&ctx->crtc->base); =20 --=20 2.49.0