From nobody Wed Oct 8 16:06:34 2025 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04D012F4305; Thu, 26 Jun 2025 19:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750966829; cv=none; b=PJUB9L5invuaDNs1lzeFrvP/JOvRcvekhKULmCPqZamBCnzV46RQJ/rp4W51eSvw+F4mJn59pJvEY7m8WD0IDCaCJTXb/XSw0Vr/lvKLR41FE0oOBYzotUQk7T0fXeXmExCDpKl37h0FT0M35QDpbFEfQ2SCirh2lqO06EVlxaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750966829; c=relaxed/simple; bh=t7fxqve/o3YKyaqfpTmXJILhPTxiSVZnhtUpJPbKvRo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gMdz8Flp3lR/cPo36USzT7UWR1rAGFGl0InVZAcKse0+wNAXRYdGrfPAbQLA0j/sWiNuFDPSTbnpxt9E64grBK9jdBJple45UK7T+qb1FNXs9H5D2hR9hcK7shoYOvkbYgfLIMb+mhK8iJtXEAKxFvrxZdvAW0IqPv5mpmMaQ4M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=mmVrGFls; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="mmVrGFls" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 9A11525C0F; Thu, 26 Jun 2025 21:40:26 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id p1a6vYULtFzR; Thu, 26 Jun 2025 21:40:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1750966825; bh=t7fxqve/o3YKyaqfpTmXJILhPTxiSVZnhtUpJPbKvRo=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=mmVrGFlsc0Ra9JaJzZVyuh0i11SiByW3G0PWYtKTPqCC688y4ZHNSZr/6ksPwyK99 QCekE1Pc/JvfhyO8JwBHK037wYWOISAlbyfT0q7SIpq8T+dJFKA67o1/wHdGHHmTtv nzWy8WLArZ8fYFAm1lNDsdOdAyRqjU552qoWgypRwsS8jGidYi2CKA8Xbi3eUTX62Y 29BwnKeklQoonrRGbPy/F6X7leG0365RwU+yDmzSKX6pL03f8JdqQWtELW9+gtbqf5 Tv8+VLl2tNRp1GiQ23DJ/l8roMPWpX5n6IaplSjzJtVMVMKibk/q6bdv4YckJ1gf2h Cn8Uuzh+YtUog== From: Kaustabh Chakraborty Date: Fri, 27 Jun 2025 01:08:55 +0530 Subject: [PATCH v2 06/13] drm/bridge: samsung-dsim: allow configuring the VIDEO_MODE bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250627-exynos7870-dsim-v2-6-1433b67378d3@disroot.org> References: <20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org> In-Reply-To: <20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org> To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1750966738; l=3602; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=t7fxqve/o3YKyaqfpTmXJILhPTxiSVZnhtUpJPbKvRo=; b=XltL8QkdEjIx9KFxO5hmh0IhlylpnUheEjCnkcz5UAFmU93o3ppkzXbUi9/PlBT7D+tu8W/1X pVZ5H+zYerHCqjx8hcn55VnYQod5MuoZ+J33KraTco6evZkp368CQ/n X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= The VIDEO_MODE bit of DSIM_CONFIG is hardcoded to BIT(25), but Exynos7870's DSIM has it in BIT(18) as per downstream kernel sources. In order to support both, move this bit value to the driver data struct and define it for every driver compatible. Reference the value from there instead, in functions wherever required. Signed-off-by: Kaustabh Chakraborty --- drivers/gpu/drm/bridge/samsung-dsim.c | 9 +++++++-- include/drm/bridge/samsung-dsim.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge= /samsung-dsim.c index c61524b6daf936b904743af4487cfb172dd687f0..0ebf0037d181ff6a4c54df10485= 93c97cc89f2eb 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -86,7 +86,6 @@ */ #define DSIM_HSE_DISABLE_MODE BIT(23) #define DSIM_AUTO_MODE BIT(24) -#define DSIM_VIDEO_MODE BIT(25) #define DSIM_BURST_MODE BIT(26) #define DSIM_SYNC_INFORM BIT(27) #define DSIM_EOT_DISABLE BIT(28) @@ -416,6 +415,7 @@ static const struct samsung_dsim_driver_data exynos3_ds= i_driver_data =3D { .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 1, .num_bits_resol =3D 11, + .video_mode_bit =3D 25, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -442,6 +442,7 @@ static const struct samsung_dsim_driver_data exynos4_ds= i_driver_data =3D { .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 1, .num_bits_resol =3D 11, + .video_mode_bit =3D 25, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -466,6 +467,7 @@ static const struct samsung_dsim_driver_data exynos5_ds= i_driver_data =3D { .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 1, .num_bits_resol =3D 11, + .video_mode_bit =3D 25, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -490,6 +492,7 @@ static const struct samsung_dsim_driver_data exynos5433= _dsi_driver_data =3D { .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 0, .num_bits_resol =3D 12, + .video_mode_bit =3D 25, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -514,6 +517,7 @@ static const struct samsung_dsim_driver_data exynos5422= _dsi_driver_data =3D { .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 1, .num_bits_resol =3D 12, + .video_mode_bit =3D 25, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -538,6 +542,7 @@ static const struct samsung_dsim_driver_data imx8mm_dsi= _driver_data =3D { .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 0, .num_bits_resol =3D 12, + .video_mode_bit =3D 25, .esc_clken_bit =3D 28, .byte_clken_bit =3D 24, .tx_req_hsclk_bit =3D 31, @@ -946,7 +951,7 @@ static int samsung_dsim_init_link(struct samsung_dsim *= dsi) * mode, otherwise it will support command mode. */ if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO) { - reg |=3D DSIM_VIDEO_MODE; + reg |=3D BIT(driver_data->video_mode_bit); =20 /* * The user manual describes that following bits are ignored in diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung= -dsim.h index a5f13f224b0817fe3135edd77276c4e715219cda..f364fd2703c3644e822df30408d= 82cc3d6206b05 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -63,6 +63,7 @@ struct samsung_dsim_driver_data { unsigned int wait_for_hdr_fifo; unsigned int wait_for_reset; unsigned int num_bits_resol; + unsigned int video_mode_bit; unsigned int esc_clken_bit; unsigned int byte_clken_bit; unsigned int tx_req_hsclk_bit; --=20 2.49.0