From nobody Wed Oct 8 16:06:35 2025 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 921FE2F4305; Thu, 26 Jun 2025 19:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750966816; cv=none; b=uFwX55JmVQ32LEkc1/7RNLbViq6kjeFcPqPkODoKziYtM/WZ1WU0BhT1c8jw7JlYiBaGK3hoMLhpHui4Vl9146uzGKD8qbRter3il8EhFnLWWA6q+DpW4A1dYn/7PD58/PHdxZNXecRu/J2kFRyb/qCr2se+GdypqlcwTkPLbVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750966816; c=relaxed/simple; bh=vy1snYTGnHH6IixePbf9/yaHh6iBLoAuBkPV9RrFW/k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NcXhJVD5Up3++3k0+TysIUNKa9txBoYskMbC7Z3nKtePLVa5SR13S1fAPoKwbMEtTSIkPDQF8QXe9bkX5w7hlf1ORaOdfXht2btxayoR7NK7lUaAUrEIKmwTIdK/WdVhyFGLOtKgDTlnkLSxutpLrGNfwZisgXmAGvOnmUPJNQw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=YSKf609N; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="YSKf609N" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 1F3C925EE9; Thu, 26 Jun 2025 21:40:13 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id b5jeVJosM-64; Thu, 26 Jun 2025 21:40:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1750966811; bh=vy1snYTGnHH6IixePbf9/yaHh6iBLoAuBkPV9RrFW/k=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=YSKf609NiaX48IVcBYOBQNE8WwkNePe2kLgpVQUDu2I7tEGTNMP4AhqM58tu39lRt LH68Fy/qGuZYqwWOpsXiOJiRiZ2adCUH78y9kyS5R7ZzN8C89d5zezKXktHaqq9TuH uBWWIpwRdHg+c1OJnqHXU/BnFvTg650l5zMIg3yTo3Clp+P4vgjes4/rGaNHnHbze4 3thpZ+iWr5ZG8k/GpNMEYX+43EItekcncgz6jpTnPtkQGCEzIRdLfvPDFDjEIg9aEo 57ICVbC5YPp/DnIrkxw36v5QayYaBVPnt3/nn77yYUKoR73T8IgUO/L3VUEoawDKhb YNZJtx0jNd+Mg== From: Kaustabh Chakraborty Date: Fri, 27 Jun 2025 01:08:54 +0530 Subject: [PATCH v2 05/13] drm/bridge: samsung-dsim: allow configuring the MAIN_VSA offset Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250627-exynos7870-dsim-v2-5-1433b67378d3@disroot.org> References: <20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org> In-Reply-To: <20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org> To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1750966738; l=4240; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=vy1snYTGnHH6IixePbf9/yaHh6iBLoAuBkPV9RrFW/k=; b=JeIuFbKJEf3KFGOldLFmoVE8vR5E87MXGabNg5fDbkiQEJ2WeiHkB/pUMLWPb+lz35whLGQyU 0rFb9RT2j0KDsFuOZM3VF7mfqAAdrYn3+MfsjIQwlOmLMM9wibaEvRn X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= The MAIN_VSA offset of DSIM_MSYNC is hardcoded to a 22-bit offset, but Exynos7870's DSIM has it in a 16-bit offset as per the downstream kernel sources. In order to support both, move this offset value to the driver data struct and define it for every driver compatible. Reference the value from there instead, in functions wherever required. Signed-off-by: Kaustabh Chakraborty --- drivers/gpu/drm/bridge/samsung-dsim.c | 13 ++++++++++--- include/drm/bridge/samsung-dsim.h | 1 + 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge= /samsung-dsim.c index c85c7c3af74ebce9732f9531ba5c31d992a19a23..c61524b6daf936b904743af4487= cfb172dd687f0 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -124,9 +124,9 @@ #define DSIM_MAIN_HBP_MASK ((0xffff) << 0) =20 /* DSIM_MSYNC */ -#define DSIM_MAIN_VSA(x) ((x) << 22) +#define DSIM_MAIN_VSA(x, offset) ((x) << offset) #define DSIM_MAIN_HSA(x) ((x) << 0) -#define DSIM_MAIN_VSA_MASK ((0x3ff) << 22) +#define DSIM_MAIN_VSA_MASK(offset) ((0x3ff) << offset) #define DSIM_MAIN_HSA_MASK ((0xffff) << 0) =20 /* DSIM_SDRESOL */ @@ -422,6 +422,7 @@ static const struct samsung_dsim_driver_data exynos3_ds= i_driver_data =3D { .lane_esc_clk_bit =3D 19, .lane_esc_data_offset =3D 20, .pll_p_offset =3D 13, + .main_vsa_offset =3D 22, .reg_values =3D reg_values, .pll_fin_min =3D 6, .pll_fin_max =3D 12, @@ -447,6 +448,7 @@ static const struct samsung_dsim_driver_data exynos4_ds= i_driver_data =3D { .lane_esc_clk_bit =3D 19, .lane_esc_data_offset =3D 20, .pll_p_offset =3D 13, + .main_vsa_offset =3D 22, .reg_values =3D reg_values, .pll_fin_min =3D 6, .pll_fin_max =3D 12, @@ -470,6 +472,7 @@ static const struct samsung_dsim_driver_data exynos5_ds= i_driver_data =3D { .lane_esc_clk_bit =3D 19, .lane_esc_data_offset =3D 20, .pll_p_offset =3D 13, + .main_vsa_offset =3D 22, .reg_values =3D reg_values, .pll_fin_min =3D 6, .pll_fin_max =3D 12, @@ -493,6 +496,7 @@ static const struct samsung_dsim_driver_data exynos5433= _dsi_driver_data =3D { .lane_esc_clk_bit =3D 19, .lane_esc_data_offset =3D 20, .pll_p_offset =3D 13, + .main_vsa_offset =3D 22, .reg_values =3D exynos5433_reg_values, .pll_fin_min =3D 6, .pll_fin_max =3D 12, @@ -516,6 +520,7 @@ static const struct samsung_dsim_driver_data exynos5422= _dsi_driver_data =3D { .lane_esc_clk_bit =3D 19, .lane_esc_data_offset =3D 20, .pll_p_offset =3D 13, + .main_vsa_offset =3D 22, .reg_values =3D exynos5422_reg_values, .pll_fin_min =3D 6, .pll_fin_max =3D 12, @@ -543,6 +548,7 @@ static const struct samsung_dsim_driver_data imx8mm_dsi= _driver_data =3D { * downstream driver - drivers/gpu/drm/bridge/sec-dsim.c */ .pll_p_offset =3D 14, + .main_vsa_offset =3D 22, .reg_values =3D imx8mm_dsim_reg_values, .pll_fin_min =3D 2, .pll_fin_max =3D 30, @@ -1034,6 +1040,7 @@ static void samsung_dsim_set_display_mode(struct sams= ung_dsim *dsi) { struct drm_display_mode *m =3D &dsi->mode; unsigned int num_bits_resol =3D dsi->driver_data->num_bits_resol; + unsigned int main_vsa_offset =3D dsi->driver_data->main_vsa_offset; u32 reg; =20 if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO) { @@ -1060,7 +1067,7 @@ static void samsung_dsim_set_display_mode(struct sams= ung_dsim *dsi) reg =3D DSIM_MAIN_HFP(hfp) | DSIM_MAIN_HBP(hbp); samsung_dsim_write(dsi, DSIM_MHPORCH_REG, reg); =20 - reg =3D DSIM_MAIN_VSA(m->vsync_end - m->vsync_start) + reg =3D DSIM_MAIN_VSA(m->vsync_end - m->vsync_start, main_vsa_offset) | DSIM_MAIN_HSA(hsa); samsung_dsim_write(dsi, DSIM_MSYNC_REG, reg); } diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung= -dsim.h index 8938eccf78730019e0404101c855dc2d7d225668..a5f13f224b0817fe3135edd7727= 6c4e715219cda 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -69,6 +69,7 @@ struct samsung_dsim_driver_data { unsigned int lane_esc_clk_bit; unsigned int lane_esc_data_offset; unsigned int pll_p_offset; + unsigned int main_vsa_offset; const unsigned int *reg_values; unsigned int pll_fin_min; unsigned int pll_fin_max; --=20 2.49.0