From nobody Wed Oct 8 16:06:36 2025 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4B7C2F0E42; Thu, 26 Jun 2025 19:39:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750966791; cv=none; b=AzlFWWq2mXXx4njstasUONr46w2eopqFmxKjF7Y72ZVXySkGoG02Yf7nPRrQ1IIdzbdgx5+mRye1EPI/nl0hm95lhY3o/1V9QDZI+IPbRfFOwx1P2CJKlSxyj6qEqhOOP91v8L0wI7xaTYHfoy7Jh2I1ycMrBeW7X/qpYWaFrQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750966791; c=relaxed/simple; bh=wlVGQBMaNz6zTceF2YNMK+fgvVG3wMWLRik/PjF4UlI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FidzCVsJ/C3cciGd5ohxVGjn9SvIEDd/XJxWK9h4u3R4LUF5Qf40M3Oaa5m5jQEusBNtX4mxzC0+lCYeh88e5CB2vg096ZsCZ92fEg4yg62uhbE1X0L4C6tJWTDI+B1HQLASHtXtmBlTbVNBAVFvUfFlcI2kvTv/EJGVFjaIUH0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=kPRuSPDO; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="kPRuSPDO" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 135F025B9F; Thu, 26 Jun 2025 21:39:48 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8OArNbdu2Lx8; Thu, 26 Jun 2025 21:39:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1750966786; bh=wlVGQBMaNz6zTceF2YNMK+fgvVG3wMWLRik/PjF4UlI=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=kPRuSPDOvanJK/wQwkPmgrtN8Lra72ICEqTBV6nRskUzlCuyq4RnlRrgbtfflyxZC Oddp7EpYCL+Tq8/xPMmOpfg5BCrgKFZsy0knSn/5lcNDww+l6spCLa/djbDIXKjevU i+RW95EPrzSKBhfabk4BkXoD+B0TB6I7FIVCadjzKtZr5qUuFI8mPbxIi6PnoBuNFq ZeSriHDj5aKhTesK0m1gUuuAfcgTR5Y5y3oe3FoT+Tev8tIexj9Ss11Zl+XZzUf72t erwS8HBDiRcX0gMURdJKBk98nlC+HUNa5z56ZKo59sGmUF2adh3VjRZ9hS/9nEqlRq fo018fw9n2xtQ== From: Kaustabh Chakraborty Date: Fri, 27 Jun 2025 01:08:52 +0530 Subject: [PATCH v2 03/13] drm/bridge: samsung-dsim: add flag to control header FIFO wait Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250627-exynos7870-dsim-v2-3-1433b67378d3@disroot.org> References: <20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org> In-Reply-To: <20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org> To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1750966738; l=3612; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=wlVGQBMaNz6zTceF2YNMK+fgvVG3wMWLRik/PjF4UlI=; b=dZNr8jWpFp0IUbelfuaBn8YmfCyKFG03gqkl7Cz9s+fKOS7knK7ApH+t6cQqu/FXq2nS5PTB0 ySzzMZynJugAcV6/yaH83i78keW2BvL3duI5hF5MWMQ5k0KDXK59utO X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Exynos7870's DSIM device doesn't require waiting for the header FIFO during a MIPI DSI transfer. Add a flag in the driver data in order to control said behavior. Signed-off-by: Kaustabh Chakraborty --- drivers/gpu/drm/bridge/samsung-dsim.c | 15 ++++++++++++--- include/drm/bridge/samsung-dsim.h | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge= /samsung-dsim.c index 3c716334f1a21bf446ebe17f810d5258dd9a4c24..112d558579d8f987c695e1704a5= 772ebbadfd625 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -417,6 +417,7 @@ static const struct samsung_dsim_driver_data exynos3_ds= i_driver_data =3D { .has_clklane_stop =3D 1, .num_clks =3D 2, .max_freq =3D 1000, + .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 1, .num_bits_resol =3D 11, .pll_p_offset =3D 13, @@ -436,6 +437,7 @@ static const struct samsung_dsim_driver_data exynos4_ds= i_driver_data =3D { .has_clklane_stop =3D 1, .num_clks =3D 2, .max_freq =3D 1000, + .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 1, .num_bits_resol =3D 11, .pll_p_offset =3D 13, @@ -453,6 +455,7 @@ static const struct samsung_dsim_driver_data exynos5_ds= i_driver_data =3D { .plltmr_reg =3D 0x58, .num_clks =3D 2, .max_freq =3D 1000, + .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 1, .num_bits_resol =3D 11, .pll_p_offset =3D 13, @@ -470,6 +473,7 @@ static const struct samsung_dsim_driver_data exynos5433= _dsi_driver_data =3D { .has_clklane_stop =3D 1, .num_clks =3D 5, .max_freq =3D 1500, + .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 0, .num_bits_resol =3D 12, .pll_p_offset =3D 13, @@ -487,6 +491,7 @@ static const struct samsung_dsim_driver_data exynos5422= _dsi_driver_data =3D { .has_clklane_stop =3D 1, .num_clks =3D 2, .max_freq =3D 1500, + .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 1, .num_bits_resol =3D 12, .pll_p_offset =3D 13, @@ -504,6 +509,7 @@ static const struct samsung_dsim_driver_data imx8mm_dsi= _driver_data =3D { .has_clklane_stop =3D 1, .num_clks =3D 2, .max_freq =3D 2100, + .wait_for_hdr_fifo =3D 1, .wait_for_reset =3D 0, .num_bits_resol =3D 12, /* @@ -1110,6 +1116,7 @@ static void samsung_dsim_send_to_fifo(struct samsung_= dsim *dsi, { struct device *dev =3D dsi->dev; struct mipi_dsi_packet *pkt =3D &xfer->packet; + const struct samsung_dsim_driver_data *driver_data =3D dsi->driver_data; const u8 *payload =3D pkt->payload + xfer->tx_done; u16 length =3D pkt->payload_length - xfer->tx_done; bool first =3D !xfer->tx_done; @@ -1150,9 +1157,11 @@ static void samsung_dsim_send_to_fifo(struct samsung= _dsim *dsi, return; =20 reg =3D get_unaligned_le32(pkt->header); - if (samsung_dsim_wait_for_hdr_fifo(dsi)) { - dev_err(dev, "waiting for header FIFO timed out\n"); - return; + if (driver_data->wait_for_hdr_fifo) { + if (samsung_dsim_wait_for_hdr_fifo(dsi)) { + dev_err(dev, "waiting for header FIFO timed out\n"); + return; + } } =20 if (NEQV(xfer->flags & MIPI_DSI_MSG_USE_LPM, diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung= -dsim.h index a50e4f521b9d9561f6a3b9fe3e174c0e140849a2..3641c57557f42fd90cd2e8c0282= f69dbe36ba2de 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -60,6 +60,7 @@ struct samsung_dsim_driver_data { unsigned int num_clks; unsigned int min_freq; unsigned int max_freq; + unsigned int wait_for_hdr_fifo; unsigned int wait_for_reset; unsigned int num_bits_resol; unsigned int pll_p_offset; --=20 2.49.0