From nobody Tue Feb 10 23:12:15 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33D9B2F1997 for ; Thu, 26 Jun 2025 19:57:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750967823; cv=none; b=Enf5ib0MeswAyjpWRI3YA/B/hxfou5wr6+hlLGt2AWw3dZvpixO8cfbzVQWyw8ebJnSUzaxlhu1HqBYBPsX6sSo2xVj9xjpvVrqyklhWZLBxTArOIjWH2qRKO4y1+2PhUJC/RfQGZpyIFIdpv8u7mvtfF6TvCyLsAMzAZkNVp7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750967823; c=relaxed/simple; bh=amQzdgQn1nBGZUehLLz6xzFzzEqkFIbXu0BcytcPHK8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jFQiVIrO+kRKbBWgoaFv/4KFUw6QN14KBXVAo6oh9UrSWDl2e5StlFOooEVGPOEznOMeBDHq70zCnAX1hqX8BZKLAF7bxcBugqw+EP3T826r80cLKMJoUpsUvWj/iiq2BIPHqQQBZcboaS1ux9xMOl8HApMTxzBvM7QTaix3qXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nt67gnlJ; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nt67gnlJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750967822; x=1782503822; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=amQzdgQn1nBGZUehLLz6xzFzzEqkFIbXu0BcytcPHK8=; b=nt67gnlJZqumtI9DoOPoKuhdPvMwNIyFZQJjlVqtk2OPkvwhQANCbPPf zw4Wl3ckhdCdTvwmasH/RqgPfECEaACAxbn7aVqcBZZFnIIDG3ZQgmOGd bKhALKMFBprsDjklFMLfr8Uj6oolRe57xnnz5vI7u4cs2LlXRbJ+RC0DY PG3W077eQ6T9lLA5JJyhKXlG2aTKaW+gnSYRPXz6XoK6pPv+myBACDWlO lEJZSyZYd1lTVQfynL9gmkD2+eMTnLUn3MTFDju6WaVmvel+QGmUzKouV kCfynkSn4QeYjQzDEhoBH2zlDAe/lfM/L5g5wPtmqWtFJdoKXlHfjOAkG w==; X-CSE-ConnectionGUID: V7BdgTTyQrWEaDC7zl6zfg== X-CSE-MsgGUID: D+O+2c2zRFGEebozAGxfqg== X-IronPort-AV: E=McAfee;i="6800,10657,11476"; a="53002172" X-IronPort-AV: E=Sophos;i="6.16,268,1744095600"; d="scan'208";a="53002172" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2025 12:57:00 -0700 X-CSE-ConnectionGUID: C61qElHxQ6qRJzgShF9rKQ== X-CSE-MsgGUID: Q12Lm5HwQRiwIIKuH6maOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,268,1744095600"; d="scan'208";a="156902917" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 26 Jun 2025 12:57:00 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, tglx@linutronix.de, dave.hansen@linux.intel.com, irogers@google.com, adrian.hunter@intel.com, jolsa@kernel.org, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Cc: dapeng1.mi@linux.intel.com, ak@linux.intel.com, zide.chen@intel.com, mark.rutland@arm.com, broonie@kernel.org, ravi.bangoria@amd.com, Kan Liang Subject: [RFC PATCH V2 07/13] perf/x86: Move XMM to sample_simd_vec_regs Date: Thu, 26 Jun 2025 12:56:04 -0700 Message-Id: <20250626195610.405379-8-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250626195610.405379-1-kan.liang@linux.intel.com> References: <20250626195610.405379-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The XMM0-15 are SIMD registers. Move them from sample_regs to sample_simd_vec_regs. Reject access to the extended space of the sample_regs if the new sample_simd_vec_regs is used. The perf_reg_value requires the abi to understand the layout of the sample_regs. Add the abi information in the struct x86_perf_regs. Implement the X86-specific perf_simd_reg_validate to validate the SIMD registers configuration from the user tool. Only the XMM0-15 is supported now. More registers will be added in the following patches. Implement the X86-specific perf_simd_reg_value to retrieve the XMM value. Signed-off-by: Kan Liang --- arch/x86/events/core.c | 38 ++++++++++++++++++++- arch/x86/events/intel/ds.c | 2 +- arch/x86/events/perf_event.h | 12 +++++++ arch/x86/include/asm/perf_event.h | 1 + arch/x86/include/uapi/asm/perf_regs.h | 6 ++++ arch/x86/kernel/perf_regs.c | 49 ++++++++++++++++++++++++++- 6 files changed, 105 insertions(+), 3 deletions(-) diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c index 899bd5680f6b..2515179ac664 100644 --- a/arch/x86/events/core.c +++ b/arch/x86/events/core.c @@ -710,6 +710,22 @@ int x86_pmu_hw_config(struct perf_event *event) return -EINVAL; if (!(x86_pmu.ext_regs_mask & X86_EXT_REGS_XMM)) return -EINVAL; + if (event->attr.sample_simd_regs_enabled) + return -EINVAL; + } + + if (event_has_simd_regs(event)) { + if (!(event->pmu->capabilities & PERF_PMU_CAP_SIMD_REGS)) + return -EINVAL; + /* Not require any vector registers but set width */ + if (event->attr.sample_simd_vec_reg_qwords && + !event->attr.sample_simd_vec_reg_intr && + !event->attr.sample_simd_vec_reg_user) + return -EINVAL; + /* The vector registers set is not supported */ + if (event->attr.sample_simd_vec_reg_qwords >=3D PERF_X86_XMM_QWORDS && + !(x86_pmu.ext_regs_mask & X86_EXT_REGS_XMM)) + return -EINVAL; } } return x86_setup_perfctr(event); @@ -1785,6 +1801,16 @@ void x86_pmu_setup_regs_data(struct perf_event *even= t, data->dyn_size +=3D sizeof(u64); if (data->regs_user.regs) data->dyn_size +=3D hweight64(attr->sample_regs_user) * sizeof(u64); + if (attr->sample_simd_regs_enabled && data->regs_user.abi) { + /* num and qwords of vector and pred registers */ + data->dyn_size +=3D sizeof(u64); + /* data[] */ + data->dyn_size +=3D hweight64(attr->sample_simd_vec_reg_user) * + sizeof(u64) * + attr->sample_simd_vec_reg_qwords; + data->regs_user.abi |=3D PERF_SAMPLE_REGS_ABI_SIMD; + } + perf_regs->abi =3D data->regs_user.abi; data->sample_flags |=3D PERF_SAMPLE_REGS_USER; } =20 @@ -1794,10 +1820,20 @@ void x86_pmu_setup_regs_data(struct perf_event *eve= nt, data->dyn_size +=3D sizeof(u64); if (data->regs_intr.regs) data->dyn_size +=3D hweight64(attr->sample_regs_intr) * sizeof(u64); + if (attr->sample_simd_regs_enabled && data->regs_intr.abi) { + /* num and qwords of vector and pred registers */ + data->dyn_size +=3D sizeof(u64); + /* data[] */ + data->dyn_size +=3D hweight64(attr->sample_simd_vec_reg_intr) * + sizeof(u64) * + attr->sample_simd_vec_reg_qwords; + data->regs_intr.abi |=3D PERF_SAMPLE_REGS_ABI_SIMD; + } + perf_regs->abi =3D data->regs_intr.abi; data->sample_flags |=3D PERF_SAMPLE_REGS_INTR; } =20 - if (event_has_extended_regs(event)) { + if (event_needs_xmm(event)) { perf_regs->xmm_regs =3D NULL; mask |=3D XFEATURE_MASK_SSE; } diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c index 8437730abfb7..849136bef336 100644 --- a/arch/x86/events/intel/ds.c +++ b/arch/x86/events/intel/ds.c @@ -1415,7 +1415,7 @@ static u64 pebs_update_adaptive_cfg(struct perf_event= *event) if (gprs || (attr->precise_ip < 2) || tsx_weight) pebs_data_cfg |=3D PEBS_DATACFG_GP; =20 - if (event_has_extended_regs(event)) + if (event_needs_xmm(event)) pebs_data_cfg |=3D PEBS_DATACFG_XMMS; =20 if (sample_type & PERF_SAMPLE_BRANCH_STACK) { diff --git a/arch/x86/events/perf_event.h b/arch/x86/events/perf_event.h index 37ed46cafa53..69964433a245 100644 --- a/arch/x86/events/perf_event.h +++ b/arch/x86/events/perf_event.h @@ -133,6 +133,18 @@ static inline bool is_acr_event_group(struct perf_even= t *event) return check_leader_group(event->group_leader, PERF_X86_EVENT_ACR); } =20 +static inline bool event_needs_xmm(struct perf_event *event) +{ + if (event->attr.sample_simd_regs_enabled && + event->attr.sample_simd_vec_reg_qwords >=3D PERF_X86_XMM_QWORDS) + return true; + + if (!event->attr.sample_simd_regs_enabled && + event_has_extended_regs(event)) + return true; + return false; +} + struct amd_nb { int nb_id; /* NorthBridge id */ int refcnt; /* reference count */ diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_= event.h index f36f04bc95f1..538219c59979 100644 --- a/arch/x86/include/asm/perf_event.h +++ b/arch/x86/include/asm/perf_event.h @@ -592,6 +592,7 @@ extern void perf_events_lapic_init(void); struct pt_regs; struct x86_perf_regs { struct pt_regs regs; + u64 abi; union { u64 *xmm_regs; u32 *xmm_space; /* for xsaves */ diff --git a/arch/x86/include/uapi/asm/perf_regs.h b/arch/x86/include/uapi/= asm/perf_regs.h index 7c9d2bb3833b..bd8af802f757 100644 --- a/arch/x86/include/uapi/asm/perf_regs.h +++ b/arch/x86/include/uapi/asm/perf_regs.h @@ -55,4 +55,10 @@ enum perf_event_x86_regs { =20 #define PERF_REG_EXTENDED_MASK (~((1ULL << PERF_REG_X86_XMM0) - 1)) =20 +#define PERF_X86_SIMD_VEC_REGS_MAX 16 +#define PERF_X86_SIMD_VEC_MASK GENMASK_ULL(PERF_X86_SIMD_VEC_REGS_MAX - 1= , 0) + +#define PERF_X86_XMM_QWORDS 2 +#define PERF_X86_SIMD_QWORDS_MAX PERF_X86_XMM_QWORDS + #endif /* _ASM_X86_PERF_REGS_H */ diff --git a/arch/x86/kernel/perf_regs.c b/arch/x86/kernel/perf_regs.c index 624703af80a1..638b9e186c50 100644 --- a/arch/x86/kernel/perf_regs.c +++ b/arch/x86/kernel/perf_regs.c @@ -63,6 +63,9 @@ u64 perf_reg_value(struct pt_regs *regs, int idx) =20 if (idx >=3D PERF_REG_X86_XMM0 && idx < PERF_REG_X86_XMM_MAX) { perf_regs =3D container_of(regs, struct x86_perf_regs, regs); + /* SIMD registers are moved to dedicated sample_simd_vec_reg */ + if (perf_regs->abi & PERF_SAMPLE_REGS_ABI_SIMD) + return 0; if (!perf_regs->xmm_regs) return 0; return perf_regs->xmm_regs[idx - PERF_REG_X86_XMM0]; @@ -74,6 +77,49 @@ u64 perf_reg_value(struct pt_regs *regs, int idx) return regs_get_register(regs, pt_regs_offset[idx]); } =20 +u64 perf_simd_reg_value(struct pt_regs *regs, int idx, + u16 qwords_idx, bool pred) +{ + struct x86_perf_regs *perf_regs =3D container_of(regs, struct x86_perf_re= gs, regs); + + if (pred) + return 0; + + if (WARN_ON_ONCE(idx >=3D PERF_X86_SIMD_VEC_REGS_MAX || + qwords_idx >=3D PERF_X86_SIMD_QWORDS_MAX)) + return 0; + + if (qwords_idx < PERF_X86_XMM_QWORDS) { + if (!perf_regs->xmm_regs) + return 0; + return perf_regs->xmm_regs[idx * PERF_X86_XMM_QWORDS + qwords_idx]; + } + + return 0; +} + +int perf_simd_reg_validate(u16 vec_qwords, u64 vec_mask, + u16 pred_qwords, u32 pred_mask) +{ + /* pred_qwords implies sample_simd_{pred,vec}_reg_* are supported */ + if (!pred_qwords) + return 0; + + if (!vec_qwords) { + if (vec_mask) + return -EINVAL; + } else { + if (vec_qwords !=3D PERF_X86_XMM_QWORDS) + return -EINVAL; + if (vec_mask & ~PERF_X86_SIMD_VEC_MASK) + return -EINVAL; + } + if (pred_mask) + return -EINVAL; + + return 0; +} + #define PERF_REG_X86_RESERVED (((1ULL << PERF_REG_X86_XMM0) - 1) & \ ~((1ULL << PERF_REG_X86_MAX) - 1)) =20 @@ -114,7 +160,8 @@ void perf_get_regs_user(struct perf_regs *regs_user, =20 int perf_reg_validate(u64 mask) { - if (!mask || (mask & (REG_NOSUPPORT | PERF_REG_X86_RESERVED))) + /* The mask could be 0 if only the SIMD registers are interested */ + if (mask & (REG_NOSUPPORT | PERF_REG_X86_RESERVED)) return -EINVAL; =20 return 0; --=20 2.38.1