From nobody Wed Oct 8 18:13:31 2025 Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27982F3C03; Wed, 25 Jun 2025 23:16:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750893365; cv=none; b=aD/sJNto4N/J3kz5AhFCiqa7Vsc/5DBI16t4xQ3jI8qAmUt9fOll53tTUj9EVKFKhiF2Qlq47q9zgaeLjfvKqmXrbWEBhGjuLiWW5I/6xJNeXy1WrlXGk6spxolE7VEHcKUtd8jfT5IkzJsAwjc4PD7iOD1tZm6Icnd/KGF+JDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750893365; c=relaxed/simple; bh=1XLIoUNepTsfquzGFeMeCkcWIXW1TQPk/V17jLEsQZY=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=toRX3SxaDhndbnmjHNxu3P1IWM1uiAdUmNu+8p/yq/WZmKbP8xMkmYWSjesUbJIPYqJjiEnocsRFSszyMEq6uTysRlAsWIclYJ2QqzO0DfsJPnnyhRbH50zMk3qUNbAGDrTFATkRY1PuYWNTUfIwAxTc5mwqFdGYMfv9KJRGEGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 933F81A076A; Wed, 25 Jun 2025 23:16:00 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf01.hostedemail.com (Postfix) with ESMTPA id EB2346000C; Wed, 25 Jun 2025 23:15:56 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uUZLp-000000044fm-47ky; Wed, 25 Jun 2025 19:16:21 -0400 Message-ID: <20250625231621.837156133@goodmis.org> User-Agent: quilt/0.68 Date: Wed, 25 Jun 2025 19:15:42 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, x86@kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Josh Poimboeuf , Peter Zijlstra , Ingo Molnar , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Andrii Nakryiko , Indu Bhagat , "Jose E. Marchesi" , Beau Belgrave , Jens Remus , Linus Torvalds , Andrew Morton , Jens Axboe , Namhyung Kim , Alexei Starovoitov Subject: [PATCH v11 01/11] perf: Remove get_perf_callchain() init_nr argument References: <20250625231541.584226205@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: dbxpjiorj471mxt686gaupc66nuu6x7d X-Rspamd-Server: rspamout08 X-Rspamd-Queue-Id: EB2346000C X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX18yjclvbQfSUhFeSmIXFujOYUwUO3QTEmw= X-HE-Tag: 1750893356-970480 X-HE-Meta: U2FsdGVkX19Ft5fdWLFGWfAs9j77l81WNl0ZWGQnyoIkcuTqAwUvXbhqNTGA6/4ev6ys/qca8VhXB1zZTzEcRy+qdAzyDlf2cGefI0VJWre/PJCQ6wAyHynFzvWyGZ+gC4/x2MXujf8Lcg/wIKZM8mEsaslCh3ZLlmupgIMksp7LUBG4RCGsAU8yXVV+blFw4HANGhi8tQyYeS7aD0pBJqREcx0Y4R8PwpjIWj6gio5z3TaYYfaT9ybht+05naOuVLGwqZhcEZ7M96fOo9/6Lkm3yB0veiI0100SJus78L83FVibr7XgPeXanDzfqZn3P5uX8hZJKqPw92KEFBS2oL95dYlgAczfGdC/f79XVserHbquGyCHPNAx/0flkXt9mAFFTCXI7xRWIwk7qBhX++8ZzhsyCEcO2fjzNuLFqmc= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Josh Poimboeuf The 'init_nr' argument has double duty: it's used to initialize both the number of contexts and the number of stack entries. That's confusing and the callers always pass zero anyway. Hard code the zero. Acked-by: Namhyung Kim Acked-by: Alexei Starovoitov Signed-off-by: Josh Poimboeuf Signed-off-by: Steven Rostedt (Google) --- include/linux/perf_event.h | 2 +- kernel/bpf/stackmap.c | 4 ++-- kernel/events/callchain.c | 12 ++++++------ kernel/events/core.c | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index ec9d96025683..54e0d31afcad 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -1719,7 +1719,7 @@ DECLARE_PER_CPU(struct perf_callchain_entry, perf_cal= lchain_entry); extern void perf_callchain_user(struct perf_callchain_entry_ctx *entry, st= ruct pt_regs *regs); extern void perf_callchain_kernel(struct perf_callchain_entry_ctx *entry, = struct pt_regs *regs); extern struct perf_callchain_entry * -get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool us= er, +get_perf_callchain(struct pt_regs *regs, bool kernel, bool user, u32 max_stack, bool crosstask, bool add_mark); extern int get_callchain_buffers(int max_stack); extern void put_callchain_buffers(void); diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c index 3615c06b7dfa..ec3a57a5fba1 100644 --- a/kernel/bpf/stackmap.c +++ b/kernel/bpf/stackmap.c @@ -314,7 +314,7 @@ BPF_CALL_3(bpf_get_stackid, struct pt_regs *, regs, str= uct bpf_map *, map, if (max_depth > sysctl_perf_event_max_stack) max_depth =3D sysctl_perf_event_max_stack; =20 - trace =3D get_perf_callchain(regs, 0, kernel, user, max_depth, + trace =3D get_perf_callchain(regs, kernel, user, max_depth, false, false); =20 if (unlikely(!trace)) @@ -451,7 +451,7 @@ static long __bpf_get_stack(struct pt_regs *regs, struc= t task_struct *task, else if (kernel && task) trace =3D get_callchain_entry_for_task(task, max_depth); else - trace =3D get_perf_callchain(regs, 0, kernel, user, max_depth, + trace =3D get_perf_callchain(regs, kernel, user, max_depth, crosstask, false); =20 if (unlikely(!trace) || trace->nr < skip) { diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c index 6c83ad674d01..b0f5bd228cd8 100644 --- a/kernel/events/callchain.c +++ b/kernel/events/callchain.c @@ -217,7 +217,7 @@ static void fixup_uretprobe_trampoline_entries(struct p= erf_callchain_entry *entr } =20 struct perf_callchain_entry * -get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool us= er, +get_perf_callchain(struct pt_regs *regs, bool kernel, bool user, u32 max_stack, bool crosstask, bool add_mark) { struct perf_callchain_entry *entry; @@ -228,11 +228,11 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr,= bool kernel, bool user, if (!entry) return NULL; =20 - ctx.entry =3D entry; - ctx.max_stack =3D max_stack; - ctx.nr =3D entry->nr =3D init_nr; - ctx.contexts =3D 0; - ctx.contexts_maxed =3D false; + ctx.entry =3D entry; + ctx.max_stack =3D max_stack; + ctx.nr =3D entry->nr =3D 0; + ctx.contexts =3D 0; + ctx.contexts_maxed =3D false; =20 if (kernel && !user_mode(regs)) { if (add_mark) diff --git a/kernel/events/core.c b/kernel/events/core.c index 1f746469fda5..ca7e9e7d19bf 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8178,7 +8178,7 @@ perf_callchain(struct perf_event *event, struct pt_re= gs *regs) if (!kernel && !user) return &__empty_callchain; =20 - callchain =3D get_perf_callchain(regs, 0, kernel, user, + callchain =3D get_perf_callchain(regs, kernel, user, max_stack, crosstask, true); return callchain ?: &__empty_callchain; } --=20 2.47.2