From nobody Wed Oct 8 17:29:48 2025 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BBE91ADC69 for ; Wed, 25 Jun 2025 17:49:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750873779; cv=none; b=tBTqlPgBXI5n6dUvTHIAzoNkezg9/Vlut2qYt7zUh1zKWhRRC8VNaRz2hxf8aqYL8+vc1mhu1ynU6jsX4ghbNv+jWy229HzXl5miIT5W8a9ue3jfP0IcbPStWmxBmWCGBqfKxxBDt7hpFBOFf2wucCAKSK5XYiW9P0pZ2sDR+PE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750873779; c=relaxed/simple; bh=hdaQbQzAWC7hOZjbVSYZQ6WivmG3DlnKW6X1M/R7boo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aK9+xU20LBX6pzSgLJNOgOXp8gY7TfWh8UJHKM63HsiAgHf6SfzwvMy9/KWIL1FCrQNkjVnF2p0aD7gxqX67h3JHgHdW661HHwiaxWQVTbY2Tpx3P7VJgW9sB14nVy7pYg14w+LtwNHpDiqilaOa8WqcMemujLSSxo1aKSZrCgc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ITI5eHSS; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ITI5eHSS" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-74931666cbcso250230b3a.0 for ; Wed, 25 Jun 2025 10:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750873778; x=1751478578; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c1ioaSGcSzaoSqR57at2NFDMA+eF56Ru2c256CsXdIs=; b=ITI5eHSS4J2li/seQOx/iaD0Kd5Rvc1VOfc1w57aDKiExbi0Q38rg1iAC2+4/0Pkht JONUzSOd9sGrX6tNZGiEoZGoJe9d2KrcMKTU1buOkOcNT1W4LZAMhghnKiEOUi/E/taw rzBZIBzM2wfao6Cb+C/fjxMWdUxf1yR+teDM8H0+tFGkqUhR9f89w1UX8zeRpM9eHPsW rUv8gmm9679KjiJIYw8RwsPliC8MdfJeL4jtYCzteOWZOyQ5+uZ1snx4gbCMOpkIXM/b wd8zwko2uehlgXNC0HE6ZPx6UsdlI+H6iFgb5hQMzzWjDqxtM4BbGqpcq8+qkDhG37Gz 28/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750873778; x=1751478578; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c1ioaSGcSzaoSqR57at2NFDMA+eF56Ru2c256CsXdIs=; b=bAgY0kLM7PYDRmSahtGTgaIpYvIuJ/wbgLiCmwsCnbs7stQz4t9e5bqPZGc+Upqkmn 3tA0sY71KZYQDf7yXSu6ceGb7PBzdPwkZdM8gv+aiCmx3wrWRRS0rffnGHIpoqZMlNvX lYntOQane+DcWgqCGcuMmd1EsUyCNNRXwYrNtpN5wfxFwrD0oZmg4YwMUby8LcvVOitO 0P5UA5amrX7dLEv2+8LoGSqUhN/n9bUNhNdWtlBGbUAOapnLlrRu5C9vOyR6kncOSBo8 8WKyMoHQyVtvW6sX/mPyO6ak5ls/bur5IBw+GsL5NL8bkwOyWnVSsiduky9ZraTRH+kV ayfA== X-Gm-Message-State: AOJu0Yxn3FL74VC3+/u+wHB6ZYoJFxGvC6KSVRBylbkHDWFX7tr+v1oS UHdiLXnaHt2xi/gKuK7rd2Q+JVdhhiB01EDkbO+siDKbHRSJpJj4Pix7 X-Gm-Gg: ASbGncvoK/xv+Eya36xPw4bJjFPXh1CJsGVPlIvSXANk140PcH0hJkWdVHTw4vjtABL 1v5Rg3Tv5a9jRtJ96Qv5JTDT72RbWP26+kdN6EVYzcJ2WYswjC6PCF+6CmPm7yebdfMMPAYvBgD 5Fv4951dhyZZg0GI5joXUMg2/pPB7vmcCFokLhDVJ/xgg2/wDuhJyG5hUqU2fG6n1BROpEUM0HC 2mmjnh8qFI9CJVstjS3AXipYGOenidqS+8V9H6BLKIVMUf1gHPO90Sw8PFTuFCzagLULt/GU6de FGrQ23N7MiG3GP1sDcF94Imyr1RilXPKtzjuA+0pPs/UoSu6vWVH6ZpE9OyYUUduOWchbq6j0rn MQwlbQrSqA6zdhwUOpD0SqGGR0JJn6Hg= X-Google-Smtp-Source: AGHT+IFipD4D2odHuNdn/ATlCMR+IXWifKXifixJMQ7PhzMzFi6ZABQLZm7aZko8k9Nhwg8uIoSZQQ== X-Received: by 2002:a05:6a20:7d9a:b0:21f:5361:d7f7 with SMTP id adf61e73a8af0-2207f285b2cmr7515854637.31.1750873777676; Wed, 25 Jun 2025 10:49:37 -0700 (PDT) Received: from fedora.. (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-749b5e23879sm4944869b3a.57.2025.06.25.10.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 10:49:37 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, "Matthew Wilcox (Oracle)" , David Hildenbrand , Jordan Rome , Andrew Morton , "Vishal Moola (Oracle)" Subject: [RFC PATCH 1/3] mm/memory.c: convert __copy_remote_vm_str() to folios Date: Wed, 25 Jun 2025 10:48:39 -0700 Message-ID: <20250625174841.1094510-2-vishal.moola@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250625174841.1094510-1-vishal.moola@gmail.com> References: <20250625174841.1094510-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use kmap_local_folio() instead of kmap_local_page(). Replaces 2 calls to compound_head() from unmap_and_put_page() with one. This prepares us for the removal of unmap_and_put_page(), and helps prepare for the eventual gup folio conversions since this function now supports individual subpages from large folios. Signed-off-by: Vishal Moola (Oracle) --- mm/memory.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 0f9b32a20e5b..747866060658 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -6820,9 +6820,10 @@ static int __copy_remote_vm_str(struct mm_struct *mm= , unsigned long addr, } =20 while (len) { - int bytes, offset, retval; + int bytes, folio_offset, page_offset retval; void *maddr; struct page *page; + struct folio *folio; struct vm_area_struct *vma =3D NULL; =20 page =3D get_user_page_vma_remote(mm, addr, gup_flags, &vma); @@ -6837,17 +6838,20 @@ static int __copy_remote_vm_str(struct mm_struct *m= m, unsigned long addr, goto out; } =20 + folio =3D page_folio(page); bytes =3D len; - offset =3D addr & (PAGE_SIZE - 1); - if (bytes > PAGE_SIZE - offset) - bytes =3D PAGE_SIZE - offset; + folio_offset =3D offset_in_folio(folio, addr); + page_offset =3D offset_in_page(folio_offset); + + if (bytes > PAGE_SIZE - page_offset) + bytes =3D PAGE_SIZE - page_offset; =20 - maddr =3D kmap_local_page(page); - retval =3D strscpy(buf, maddr + offset, bytes); + maddr =3D kmap_local_folio(folio, folio_offset); + retval =3D strscpy(buf, maddr, bytes); if (retval >=3D 0) { /* Found the end of the string */ buf +=3D retval; - unmap_and_put_page(page, maddr); + folio_release_kmap(folio, maddr); break; } =20 @@ -6859,13 +6863,16 @@ static int __copy_remote_vm_str(struct mm_struct *m= m, unsigned long addr, */ if (bytes !=3D len) { addr +=3D bytes - 1; - copy_from_user_page(vma, page, addr, buf, maddr + (PAGE_SIZE - 1), 1); + copy_from_user_page(vma, + folio_page(folio, folio_offset / PAGE_SIZE), + addr, buf, + maddr + (PAGE_SIZE - page_offset - 1), 1); buf +=3D 1; addr +=3D 1; } len -=3D bytes; =20 - unmap_and_put_page(page, maddr); + folio_release_kmap(folio, maddr); } =20 out: --=20 2.49.0 From nobody Wed Oct 8 17:29:48 2025 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B7972D542A for ; Wed, 25 Jun 2025 17:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750873786; cv=none; b=a8+09NwLgYyQ6Qr3j5nMLmZoo0DzoR70oyqvrijSPNqwEHIg6UaUs3by5Flsw2gziQSTC8+xffv7CcE8UzfY+4P+2s7JsqQryj+6s4VdeZqZMVP9TCP6hHO1XSbhA1sGD2HE8epRSpDWHXKIcPkQqyYPWDvrjYBzlZrkLommVr0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750873786; c=relaxed/simple; bh=OV9y7iZJnkNU+hCTeUmbIDCyHAsjpmeKt/T76AN1rfE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kJBN+gEdIQXHtQ2YYifJoc3TCOdr8mzJ3ay2WqyC+2i/pALQi8uUYSZghgRFnaQbtfLfN0jFh1f7emc88r/LpCm0IcKg8M9BZb3s6Gqm+ko4vK7FxE3T3BxpYonff786HN5I15VFv+3iBVV8Sw96zanQl0t6zz+k3HY35MbwWho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QhCX3D1f; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QhCX3D1f" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7490cb9a892so194042b3a.0 for ; Wed, 25 Jun 2025 10:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750873784; x=1751478584; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R7ELidRxv5KKmB1tooy+w2E0Xw3mvApCUwofU9YBKSg=; b=QhCX3D1fBA1feKC7LbSWJcsp1SSlkASJc1AfD9em7XMnz7qf/pKBj/KSEB47el9co6 r6wfvV6GSrA3v4h59xfsAtgHu5A82DatR07zfQnM0Wd1Epvae6ES4TynbWvbmRULSCRL tsF+B5W2MBkjwpG9bCXC9hR80A8w5dMGCw6VPbP7kpfmKJYJBBBq9LictnYztjyluenO TvEoJztadBILGPtwjBFzbOuegOtOGe+eJyrRCjaOj0JH7JG49y/IEuzUXIkguLMNiUGw orAlG4EBI/AUPzXZqY6b0Unq1s+fRvT7IC6wTn7KxQmQcckJqpYAuV6miEW2WB6Mn708 C8Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750873784; x=1751478584; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R7ELidRxv5KKmB1tooy+w2E0Xw3mvApCUwofU9YBKSg=; b=VCLC2sAUO9VuZHLfykojUlp1wVz9ek2BW7SNry6Za5U0nScZvdiCJe8L0pzv3TuYet rBSlPiOsPW2i3KuM+IMhzkD49rlkRQdfLsM3sWoJZxoTu8HkwarYcC6dEaz+jGeVJx/I 0Bt50pN2AWEql6EJUCq7357ejuUzDyqpSkPUKHWxHWnb4QuXHoFZzF/4KglV3Lc2nCgT oX4fCAoDJIITA47+NTBOckQsD4MmMR9pHj4bjjfNMJTjV1Fy15bio1hbwDwLagQJSGJV xN3Na2AbuqJAqUhCiVVmjUN+WEU3Plg88w7vOdCqLxq0c2TpyAp5oSfkF7HLmw8uHFif pp/Q== X-Gm-Message-State: AOJu0YxUnnMyC8ADNLEwOWmC3xa6WsgOlzEZMwj/sMBZ3eRBuWcmdP9G hbD4MHltw34wIRdUhnn4SlDDftrZhEBfGVci0oBXPnOwNlR+q2X4L0n9FwTtTSVG X-Gm-Gg: ASbGnct7iklkUUDAjTdm+Dy48GTLjnRiLnzm9UYmK9wEZB9WzXSFmA0K8qzgq3VGgTt 2AmiaRuaZWTM6W0shv5fG3aon76VGSrvO3ZpUQ9JBtheis5goT35+xK6H/fnL4uoGf+FHge2IwL 4gDpkvtaRUJi0rYnEVaW5EmISH9Y2J276EVTsJElxEPT2/XDqmyii+jGdOTw7IGjMYv0yrUXBMV s9lrwqOPgeZhQHvV7a7dnKBca/O0XZddhqRuiwAN4cXy1gB1U7kJlu0pm3l68UT8Les3w6iaTjY xN8RFVYOYNi3fthtlead2ulNNG/7V+mN0nNZnJ+IcSQdnCKHORyg3qL8qsQxaVfV1CZBqgV1WfE FfdI7L2tySBUl2/no9e6LOZAIvr4QI1g= X-Google-Smtp-Source: AGHT+IFB2gKiuXE84YJDoX3zi/YmAkg3LM7lCafc1Ca+BpzzyJ0vb7ym6lhK+vu+NVwaXRCaonnGpQ== X-Received: by 2002:a05:6a00:2e1a:b0:736:50d1:fc84 with SMTP id d2e1a72fcca58-74ad45bf9cbmr5346890b3a.21.1750873783759; Wed, 25 Jun 2025 10:49:43 -0700 (PDT) Received: from fedora.. (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-749b5e23879sm4944869b3a.57.2025.06.25.10.49.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 10:49:43 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, "Matthew Wilcox (Oracle)" , David Hildenbrand , Jordan Rome , Andrew Morton , "Vishal Moola (Oracle)" Subject: [RFC PATCH 2/3] mm/memory.c: convert __access_remote_vm() to folios Date: Wed, 25 Jun 2025 10:48:40 -0700 Message-ID: <20250625174841.1094510-3-vishal.moola@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250625174841.1094510-1-vishal.moola@gmail.com> References: <20250625174841.1094510-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use kmap_local_folio() instead of kmap_local_page(). Replaces 2 calls to compound_head() with one. This prepares us for the removal of unmap_and_put_page(), and helps prepare for the eventual gup folio conversions since this function now supports individual subpages from large folios. Signed-off-by: Vishal Moola (Oracle) --- mm/memory.c | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 747866060658..5eeca95b9c61 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -6696,8 +6696,9 @@ static int __access_remote_vm(struct mm_struct *mm, u= nsigned long addr, =20 /* ignore errors, just check how much was successfully transferred */ while (len) { - int bytes, offset; + int bytes, folio_offset; void *maddr; + struct folio *folio; struct vm_area_struct *vma =3D NULL; struct page *page =3D get_user_page_vma_remote(mm, addr, gup_flags, &vma); @@ -6729,21 +6730,25 @@ static int __access_remote_vm(struct mm_struct *mm,= unsigned long addr, if (bytes <=3D 0) break; } else { + folio =3D page_folio(page); bytes =3D len; - offset =3D addr & (PAGE_SIZE-1); - if (bytes > PAGE_SIZE-offset) - bytes =3D PAGE_SIZE-offset; + folio_offset =3D offset_in_folio(folio, addr); + + if (bytes > PAGE_SIZE - offset_in_page(folio_offset)) + bytes =3D PAGE_SIZE - offset_in_page(folio_offset); =20 - maddr =3D kmap_local_page(page); + maddr =3D kmap_local_folio(folio, folio_offset); if (write) { - copy_to_user_page(vma, page, addr, - maddr + offset, buf, bytes); - set_page_dirty_lock(page); + copy_to_user_page(vma, + folio_page(folio, folio_offset / PAGE_SIZE), + addr, maddr, buf, bytes); + folio_mark_dirty_lock(folio); } else { - copy_from_user_page(vma, page, addr, - buf, maddr + offset, bytes); + copy_from_user_page(vma, + folio_page(folio, folio_offset / PAGE_SIZE), + addr, buf, maddr, bytes); } - unmap_and_put_page(page, maddr); + folio_release_kmap(folio, maddr); } len -=3D bytes; buf +=3D bytes; --=20 2.49.0 From nobody Wed Oct 8 17:29:48 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B91892D5C60 for ; Wed, 25 Jun 2025 17:49:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750873791; cv=none; b=L12DcZ7+ukZsSsjER8Ex3TLKP+da3aP22K9lCv5t6eU4vTcwZllEczATqptbgS9Wo+Lgig52diuFmXStYrfhAOxuYU//SfndHXmFpJvKErcr21l6sd6t+6FodxRjn9QPzh869ipbyNCSQvEeJUh/kuc9wcGsqGd4P4HCRi82u+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750873791; c=relaxed/simple; bh=uTW7gs8kvA6nVolSFxs/7DSjkSEwH+EY5b1Idlv0EC4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TLADs2hCm4yEcyrYD0NERYFDd6wnkI01TkjJl6s/MSclG70ZTCvEGezuAlZrds1Pz86LSRddtl9KydS36wZHDtA6qmyhu+y3Dglf61/tPPXwbjeSNYSbm6EIf1BnmRpnTpTc6CC8EflCVRbRtnVoHer8JmWchlKpgTdZZVblkWk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jaqc9mGN; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jaqc9mGN" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-747e41d5469so267398b3a.3 for ; Wed, 25 Jun 2025 10:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750873789; x=1751478589; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R8ReRc6UFydYH9gtSn+f80zTiGgWBcsSXK6ZsJcWtV4=; b=jaqc9mGN8HYERqBgRbgQrP4CqUspvLD2OqY4tM1vgph2pjHpYucn1snHPS0ms8l1Ip NP0bUlIuOO/BU0VcZZg3ok7LGVaovRNx4Wyp/ywOdcHf7eFMU3+qrunOHR8rKuvRQsa9 +HilTkcTeYjCOo9NYjFcgwDjwSBbSLc+gLqr9x7WfGsGY9S+qxt98/G3goWjosxaFUzL YZVOgS4xKp5yUWJa0bTg1jgZU+xzNtQr6IyyxelivEbEJkNlwKbr2IaPNiliVuAOjJbe wCqpjfmPSSkwcyKEE9OkUhxP/D8XosGKIPTUpLbyduaJCbW13iwU0cdMr3CckaHxYlQF 7g9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750873789; x=1751478589; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R8ReRc6UFydYH9gtSn+f80zTiGgWBcsSXK6ZsJcWtV4=; b=SJJjrX089mBIFZUCyelYXGeMIiUrXSEQWG+Ewo04R+NJ6O5tK4MA0oY5ngL/V5/quz BkXSIpSa3mqq6+31bTP9NurOfryJZ6VFl9rLBb0/LFVOXPZ3EWsuUp616L/eIi6qiN8e 3mIMFaABe8nzmNvynSFd0RgHDOqNTlGoikjuGJnDphqnASCc6EVmPuvxuSkw84SIfN6x Gs7ATCbJHwsc5D42loZkBXE/G962qUQbtwTCX8bwKWOtnrkByGg3inpBo90huKdSJQxz fnsSR+Sy0sfQHSmi6s0j6QP+EKpHuBTsMsyfdhYtgbSHWDX8kB1gyr9tPsW3XWZkyZBl Wrtg== X-Gm-Message-State: AOJu0YzY3zzOA6vuBd3qlRFUUalcpHEXzY+gOa1pkwidCGe7jZzFqDfw BSgDHcn7bNDyI03Bm2xjEOI1J9ZrCMxG7y+TlYEjEBQ8RWq2vRUQ1D12YyKX87iZ X-Gm-Gg: ASbGnctKxgfennO8EUaqmGWaVrGmQPFG4s38M32x3xNL+HEoA4IZXHb7NUlthWWC2n8 Eei7DmAachzhER3mYq+xzt5iqERKkRs8UeCAHEeVmsUx6dggYN/gkluQeNqbT+ViI9jOB1dEvQA i1kgEnOaS/zAOjpK5CXIDonLVSKTkXKCFMhSaQBtAOVnUCPdAGMT9UQq7zxmjcjGg0zKLUCtl7g pQS+ENF2NXLIpt/KSithSxsuyolfhfPZS9ZjL3E4ZRiCsWcOBBwZYHK02BXqFRlujA2GqPdLAt6 1cJ4lkFeOAL8LINH/iTRmQtQ8MsyaAlBbT8OvmOtPUwvWw3YqNyUCQyiKD7ok8Bq9Kb0L48b52Y yKH328bk5U3hSf7szJiYy X-Google-Smtp-Source: AGHT+IGS7kz5uX1FDITaZRBZY3QMqayTuas64co39YoDcp/ViK2Vwt6D23GmpoPp4sqoII7r3Sgngg== X-Received: by 2002:a05:6a20:158d:b0:218:59b:b2f4 with SMTP id adf61e73a8af0-2207f31ce05mr6229096637.42.1750873788931; Wed, 25 Jun 2025 10:49:48 -0700 (PDT) Received: from fedora.. (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-749b5e23879sm4944869b3a.57.2025.06.25.10.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 10:49:48 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, "Matthew Wilcox (Oracle)" , David Hildenbrand , Jordan Rome , Andrew Morton , "Vishal Moola (Oracle)" Subject: [RFC PATCH 3/3] mm: Remove unmap_and_put_page() Date: Wed, 25 Jun 2025 10:48:41 -0700 Message-ID: <20250625174841.1094510-4-vishal.moola@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250625174841.1094510-1-vishal.moola@gmail.com> References: <20250625174841.1094510-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are no callers of unmap_and_put_page() left. Remove it. Signed-off-by: Vishal Moola (Oracle) --- include/linux/highmem.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/include/linux/highmem.h b/include/linux/highmem.h index a30526cc53a7..6234f316468c 100644 --- a/include/linux/highmem.h +++ b/include/linux/highmem.h @@ -682,10 +682,4 @@ static inline void folio_release_kmap(struct folio *fo= lio, void *addr) kunmap_local(addr); folio_put(folio); } - -static inline void unmap_and_put_page(struct page *page, void *addr) -{ - folio_release_kmap(page_folio(page), addr); -} - #endif /* _LINUX_HIGHMEM_H */ --=20 2.49.0