From nobody Wed Oct 8 17:34:32 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DA33288CB7; Wed, 25 Jun 2025 16:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750867818; cv=none; b=qgZTpKhA2hbSz+yl9iHAygY6i9zZWMA1mwKHY56inC+ebaKZ9twLuRRiKKEiwlOm/lmyWFRsOCwhNexIfw3FxRujNQG/FylORuGSCYFCKuPQ2CeuBBXc/7tpvsezTVThJ/8LDxlgwCCciTaZu3vQI/bDq1cCVLyO7qVVqBzHUpU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750867818; c=relaxed/simple; bh=KdpcS/Uk7isYRVWT/mSpfRP2Itl9wHV6KE4tzwxN1hQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gWbwHKGZv0/jPCH1WnkYeuGTdDJPfZhEgAcodSXH3DRG82mZEtNSYLPpN21YzZlE+sGJ1LDdByxs3FIKFHJcty84VsEZzrDo2O0+8pz4pVKbLNfjjPuufe3BsjpcBc0ZT2NMKJqq1SBn5p2YxadR9XMeHkNPSUEDMBty/JyMQNw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MADrJ5TK; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MADrJ5TK" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-237311f5a54so634235ad.2; Wed, 25 Jun 2025 09:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750867816; x=1751472616; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pc1jNIABXFUjdhg20cszbcmMVWTi+ij66dmyNpShB0A=; b=MADrJ5TKTnspnpheGxUHh9n5LX11589OPZSZ01PLyPoxjjC8TTVh7h5naI+CyGlRBq 7zZG8gjhACmUM2iP2E8iiWOfAGeYkcpuHUedekV+wDrfREiOVqOWqfQ8XhaMaNnsokaU MytSdvcn94V6050ERzhfFpo65vkKgYmVaJMTvrE+//0LEG03Bx/Jz4G+QlNp+DZ5AFvZ dAgnDpZE65KLsKnym/wJHWHdnBORwVSeScO+3OevJhyM5vxBTPwDe1jbMbPBRjMASymX /thy+war+IHDxFbTCnJr1zcyhzuvwrBzkF1/vpprDNVl4eDez3HDiw5RE6UdH97Bh4rn tTIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750867816; x=1751472616; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pc1jNIABXFUjdhg20cszbcmMVWTi+ij66dmyNpShB0A=; b=i5MSi2fDJT7Ncded6j+vMVoAOHcvmAtbxQl06ruSqrbxBJOn3qUaYoDc0RZp5fpAzF N0S9yQQqLCr4to87Gcwp2+tPr0QWPTAcPXa6G5xiLZmkR6FVxUOPNyJCUe1g5x4+PQeL T0bCqNGcgmae/D21u7L3ZdlLOdXLydUiP9uSufq2VPzM5IEDdk/YrsTlXkwhWiZaEg2q CIrQqTdQo/wOgI5HTnH087RAelhe2Xq9Rz2MqsXzBOIf/jE6Dl5b0P8ycFdZAqSfNP1a i5LuvLSbpYZ/zToMbkTcHHdG30DVmCOdR5OsNixugynGqwAYdlzlAhWNtQwCZDF++So6 xh4w== X-Forwarded-Encrypted: i=1; AJvYcCUSDMjfEDaOLo0+Jk912f027oCArCZjgQGBggxJf6jthGv/I7jUEXC90F1LLEYR8ltj98amfZegaCBK3a2S@vger.kernel.org, AJvYcCX4knt8JeAvKXSBVeoIeU2xHEHaf+LCFD65KIYqxFpBeRxXVJstVzr2Or91eYPoNVkoHJ4=@vger.kernel.org X-Gm-Message-State: AOJu0Yza/d3Hy1ZsBsa5tD0ssXl2QQdt//4L+3Im4TdinCDtbCOQW9RZ DBVEp/nxzxQ6nCf9FMjM5K0sFMfpKYGP/uuW+Xv8V9nb7lD8vAQ0LFeM2t6Ecw== X-Gm-Gg: ASbGncv/IlFUYdwtY+rzjAN0/2uxzlqxZT9B+7mIJqUKcBiPX+1AwGbbyS00GD/0Huv O+HzknWEmE4UmEKeltoly+rtymEWBTaUFUcJqgXqxJXr28jXrpL09Bi7bzsKAVxJHx5juBWBunu IsaVPwQRvwtORvECHtD3n/CnFjKlV0zub0tFuKa7IwZ3yfEvaam35wTCN48vtqxeWBy1hIvnPJ4 R88f9xohYsMVpwTpK72SEMQxA1E4E8NH/K7myw4HsZqIYe6mLKSM/7MhEi4jUhb9Foh5n6/XmoK SbUmFDGuvMZrSaXgPzjGXjJz3du431U7y3iOAw9ZPnLBXFsHvDyqww7Eaijn/4ZdyFqSqm1orIW 7BtABCxWzj/5M X-Google-Smtp-Source: AGHT+IG/+p4FHGoe27JAVTRBEQ4H98Gv/PlWKAyUxkOvHplkB2K8gJQfwSJufTq2+AlYaxWELoKFHg== X-Received: by 2002:a17:902:da8b:b0:235:efbb:9539 with SMTP id d9443c01a7336-23823fd7640mr75866245ad.17.1750867815986; Wed, 25 Jun 2025 09:10:15 -0700 (PDT) Received: from minh.192.168.1.1 ([2001:ee0:4f0e:fb30:1cf0:45c2:bdd1:b92d]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-237d873845esm143219175ad.243.2025.06.25.09.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 09:10:14 -0700 (PDT) From: Bui Quang Minh To: netdev@vger.kernel.org Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Bui Quang Minh Subject: [PATCH net 1/4] virtio-net: ensure the received length does not exceed allocated size Date: Wed, 25 Jun 2025 23:08:46 +0700 Message-ID: <20250625160849.61344-2-minhquangbui99@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250625160849.61344-1-minhquangbui99@gmail.com> References: <20250625160849.61344-1-minhquangbui99@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In xdp_linearize_page, when reading the following buffers from the ring, we forget to check the received length with the true allocate size. This can lead to an out-of-bound read. This commit adds that missing check. Fixes: 4941d472bf95 ("virtio-net: do not reset during XDP set") Signed-off-by: Bui Quang Minh --- drivers/net/virtio_net.c | 27 ++++++++++++++++++++++----- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index e53ba600605a..2a130a3e50ac 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1797,7 +1797,8 @@ static unsigned int virtnet_get_headroom(struct virtn= et_info *vi) * across multiple buffers (num_buf > 1), and we make sure buffers * have enough headroom. */ -static struct page *xdp_linearize_page(struct receive_queue *rq, +static struct page *xdp_linearize_page(struct net_device *dev, + struct receive_queue *rq, int *num_buf, struct page *p, int offset, @@ -1818,17 +1819,33 @@ static struct page *xdp_linearize_page(struct recei= ve_queue *rq, page_off +=3D *len; =20 while (--*num_buf) { - unsigned int buflen; + unsigned int headroom, tailroom, room; + unsigned int truesize, buflen; void *buf; + void *ctx; int off; =20 - buf =3D virtnet_rq_get_buf(rq, &buflen, NULL); + buf =3D virtnet_rq_get_buf(rq, &buflen, &ctx); if (unlikely(!buf)) goto err_buf; =20 p =3D virt_to_head_page(buf); off =3D buf - page_address(p); =20 + truesize =3D mergeable_ctx_to_truesize(ctx); + headroom =3D mergeable_ctx_to_headroom(ctx); + tailroom =3D headroom ? sizeof(struct skb_shared_info) : 0; + room =3D SKB_DATA_ALIGN(headroom + tailroom); + + if (unlikely(buflen > truesize - room)) { + put_page(p); + pr_debug("%s: rx error: len %u exceeds truesize %lu\n", + dev->name, buflen, + (unsigned long)(truesize - room)); + DEV_STATS_INC(dev, rx_length_errors); + goto err_buf; + } + /* guard against a misconfigured or uncooperative backend that * is sending packet larger than the MTU. */ @@ -1917,7 +1934,7 @@ static struct sk_buff *receive_small_xdp(struct net_d= evice *dev, headroom =3D vi->hdr_len + header_offset; buflen =3D SKB_DATA_ALIGN(GOOD_PACKET_LEN + headroom) + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); - xdp_page =3D xdp_linearize_page(rq, &num_buf, page, + xdp_page =3D xdp_linearize_page(dev, rq, &num_buf, page, offset, header_offset, &tlen); if (!xdp_page) @@ -2252,7 +2269,7 @@ static void *mergeable_xdp_get_buf(struct virtnet_inf= o *vi, */ if (!xdp_prog->aux->xdp_has_frags) { /* linearize data for XDP */ - xdp_page =3D xdp_linearize_page(rq, num_buf, + xdp_page =3D xdp_linearize_page(vi->dev, rq, num_buf, *page, offset, XDP_PACKET_HEADROOM, len); --=20 2.43.0 From nobody Wed Oct 8 17:34:32 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6E582BEC2D; Wed, 25 Jun 2025 16:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750867829; cv=none; b=sOnsb54RFOM7eZNc0Ra8HZ744fnvz/kbZuwFvDcsKX5zD80fpBG0zh6YxLAzQ6ODFh79d1iHe/C1Q2+iqSfh1zuMtFz+/VNsi0d/kpq9J9aR57r7K9EDWgnE8MqqEjWQlzD/ZkGmGPvMgKb1LyLBFvptsDZSgGII894YY8OVkPE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750867829; c=relaxed/simple; bh=0sJ8AeOBtujsSHHSnnt99pZ3s4tdzAw+C4OWiCGVWno=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RRJjabRDncLRYTxSckqYEIHrxe0Iw2ejVN7Mzy4EThMsjTsMjQFOaoLAQcP+6IzyE18X7MuI6DCVZsgTLLKPaXQ3NoI7UOhAeUlaDbe1hzokyL8bLGo63lV37agLOcnJWDXA1TvWG86MpVrmOlmSBAyaDdAjkpRAUl9MV9dQtJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dy+NoLn+; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dy+NoLn+" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-234b440afa7so723185ad.0; Wed, 25 Jun 2025 09:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750867827; x=1751472627; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jmQ7iHayqhhe6CdrM/SyPC+bVPoeFePLL7uHhJ+6594=; b=Dy+NoLn+94mErGq7qhcbDA701ALDJa6eM3ZTmMYWTG4Ey4XwlDryYDExbYj2dz//Cr XW+dzn1gJ0nyXLr8KOAJNVQ46WZNWPL7kG7qj6lT46jKgs9kzzEjyvgv20932E94XrPR BMFSkYj8yyad4CEITtiT9PA+N38Hlp+Nz/sq695j+ETJAtCkeMHX5b/Pre+qZLYSMOA8 CrWqRk69NRm4ALJtvaOB3F8gGezMNZxn4sJ+NjW9fSphfPeP/lkcfKd5b875py2nOEC7 ujYFpDoallj89lFj7Hj2Sm2BbwvQkpCvZWkKJTSr1UE4jwQb7rYpLxZpkGvL9d2fkSUY xzag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750867827; x=1751472627; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jmQ7iHayqhhe6CdrM/SyPC+bVPoeFePLL7uHhJ+6594=; b=MlX50jwvUlSOzQsmKZysH3xoicc4GwWJ0Viy2cnLBpolbVjEa7OZ9Isj5W0UZgDiZg HvdNBHqdZl+maLATxuwPFxlw+RW4IDm2bH9ETRs295zk8vmivOk2h7Q9ksXGTRCZvI2R Y5GxqvgICJMXZ81OZ1q1hrH6LJJUklkZjArTJve84RxNDwanfISwYXdFoAxAA7zkjvJl gqAYnlG0Bj483ZWRSIeJWyxY/3c2OjHXanTbavuqG7RG6X3VXMXpEMNnjMUTRSm1wasb T87i26Q7TvNZ/l9b/ESB5EClbuH+5UhfZaz+ELninK9Kq+s9+4pRKyhlT7LDXvzFd6gp xXaA== X-Forwarded-Encrypted: i=1; AJvYcCUoKnMTaCOZsmajS+4ZrVOlCVHSZdPD+Uge8AEdk508xG2DWtoxR0xuIctr7gQI0CFg286Y+KQS4M/x8Qdr@vger.kernel.org, AJvYcCVK4UNYNKklrVWxVC1FrXeyKztppQxFnoycPsVT9gIN2DtXX22DKg6QrGzdkucmndb/gHU=@vger.kernel.org X-Gm-Message-State: AOJu0YyNYu9otGPJZlByOeBSeZDLi7dQ0UTrwXyg40HSFgfKIgvIT6u/ s+/kWadICUgoktQr/Lf6AmfwjtDoOEE71EL2W14uuphjHQO7e8NI1ahxFxmICA== X-Gm-Gg: ASbGncsXtnAPRFD3L3SfemdoF+y2Y8GM6hV3zmYrtuNbwt3hDNefv+snffFWw0kQnMC f4ZTWF6Khe9pWFZrNipEVvLz/9K34Z/jA+n4R7BXGwJpGMWUdyFgvMM0bnNSej6gMyl0yVvcqYE I8FfZlLeYajG+SykhofZAgNsmyYgHWFdyOfGesxekhIJ56Lmwq1R79lT1XCcaNk1M4qonVKcaKc fMHm4ZPZXgRkY+9djH9o+kD+IqjFPNy54whV/KUfiXXMuFapcSN9CaS0VseSH/5v1veLJCfKUDq fBuYwe5+Z77bmklz8F18kf7cKtksgTAU19dEe/xnqFpGXALb95uPzQwaUe/117KJqVo5uZ3AwwG uBQ== X-Google-Smtp-Source: AGHT+IHZco/gamSdqfqByRJ3U6FIbuRY9/AJtMaXeQeuyElS4WMZmBKDToEdDl1TnVC6imwFD7vuIQ== X-Received: by 2002:a17:902:d58f:b0:234:cb4a:bc48 with SMTP id d9443c01a7336-23824030cfamr69817065ad.31.1750867826672; Wed, 25 Jun 2025 09:10:26 -0700 (PDT) Received: from minh.192.168.1.1 ([2001:ee0:4f0e:fb30:1cf0:45c2:bdd1:b92d]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-237d873845esm143219175ad.243.2025.06.25.09.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 09:10:23 -0700 (PDT) From: Bui Quang Minh To: netdev@vger.kernel.org Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Bui Quang Minh Subject: [PATCH net 2/4] virtio-net: remove redundant truesize check with PAGE_SIZE Date: Wed, 25 Jun 2025 23:08:47 +0700 Message-ID: <20250625160849.61344-3-minhquangbui99@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250625160849.61344-1-minhquangbui99@gmail.com> References: <20250625160849.61344-1-minhquangbui99@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The truesize is guaranteed not to exceed PAGE_SIZE in get_mergeable_buf_len(). It is saved in mergeable context, which is not changeable by the host side, so the check in receive path is quite redundant. Signed-off-by: Bui Quang Minh Acked-by: Jason Wang --- drivers/net/virtio_net.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 2a130a3e50ac..6f9fedad4a5e 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2144,9 +2144,9 @@ static int virtnet_build_xdp_buff_mrg(struct net_devi= ce *dev, { struct virtio_net_hdr_mrg_rxbuf *hdr =3D buf; unsigned int headroom, tailroom, room; - unsigned int truesize, cur_frag_size; struct skb_shared_info *shinfo; unsigned int xdp_frags_truesz =3D 0; + unsigned int truesize; struct page *page; skb_frag_t *frag; int offset; @@ -2194,9 +2194,8 @@ static int virtnet_build_xdp_buff_mrg(struct net_devi= ce *dev, tailroom =3D headroom ? sizeof(struct skb_shared_info) : 0; room =3D SKB_DATA_ALIGN(headroom + tailroom); =20 - cur_frag_size =3D truesize; - xdp_frags_truesz +=3D cur_frag_size; - if (unlikely(len > truesize - room || cur_frag_size > PAGE_SIZE)) { + xdp_frags_truesz +=3D truesize; + if (unlikely(len > truesize - room)) { put_page(page); pr_debug("%s: rx error: len %u exceeds truesize %lu\n", dev->name, len, (unsigned long)(truesize - room)); --=20 2.43.0 From nobody Wed Oct 8 17:34:32 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 918AD2D23B8; Wed, 25 Jun 2025 16:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750867836; cv=none; b=RAm4UXj0ueWtNz76IDgg4CrjdH485n1B3dhaJ5zo3aw4TElm8qwtuLN7CYZvaFIfiuHcvTLWEKV3kcDyB6G04NtnJIfVELlYiSREKiVdZ55K9iwvwvVnN/Ea3I/C1SSok6tQDJSPf3tZZP+D5j4Vc8SWFunNhjuz89xYp5Kq0Go= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750867836; c=relaxed/simple; bh=4VNy85BUiywaXD9Mqe5C4cqxPjoK22ldzoO5xhVanSM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EyeqXLCj/396WSWc7iodwo+Vz7COGpE0qE0iAWHgpLHi0Pnar7GIndihj9JBoX32kFS7ZGNCKjrereXQUHWSsiyqMThSA+Eyllfi5kK1fHuuPY5l8jgqYaasVcWrzTAGzwjP3P7iQ9/MQDLLoaxxei89LQsUZkpdm+66LTOeoYs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=STfFHJI9; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="STfFHJI9" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-236192f8770so1267345ad.0; Wed, 25 Jun 2025 09:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750867833; x=1751472633; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uU4X+SI62dfgcKBBMkPrylaI2hont+JORdjl4bJDSKE=; b=STfFHJI9u7nIjbrJSCc8v9Xlo5N+fTxOdgtg5PS+yCiCejcglsyizZG89o+irTib7D hjOhoJqbvhZHA0Fb/26Qv2Qi77J0BTyugL/QWgBDt0lj5rTikhF29JETkIvb9cCA9l9i 1EnkE98GLhZ2sC3h6P2pnXOObjoJCsrt2mfeC0Y5FhyOuiGhVVOlZEReU+JOBM0mXLVS jHL6M9CxX/8V9yJEmsSOOsMpdJcYaf1KXYO/qT6uCRWctiBCartKTsl7LVTawaq38qzQ L7Tc8S4QjefQS9L2UjI65OVzoSmrmmhVuUvpgRBAgX/N1TW6dQNTirCVWaSNLX7uxLJx /DjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750867833; x=1751472633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uU4X+SI62dfgcKBBMkPrylaI2hont+JORdjl4bJDSKE=; b=rZ3x1QciRdo+q4Bvy8UhT+feco/Bs9o0XU+69oc06rCVMjljrAylIUrppYwXGcGNky LCUGHzPFSEd3dccNFWudSGNpJLNchR4uWqNxyYapl4cqb3u8XL9tvoYGAmmYCk417StZ JKzPVEgC3b8T5J/SEj5hn3H5Egr86StXk4NVIgaHpnoM4ATbgc8Mi00MIVGBaQ2SRSg+ U3ARRQyTsaK73ue38EVfH0ZkcH5NvQy7DsNeq4jDU1sX4uBAqszLaAoqM7N9Q02qkIZE 51L6J6Gayb/B/3793+jMhrCoh4Ch5uRXHXm1A2ZmldPVlK1DYFoNMM5cqpel09wjiMfs AUug== X-Forwarded-Encrypted: i=1; AJvYcCVFVhbdEV1Sgwcbqmk4Ont9qyzOVefS/QqmP8sUijkMb2BxokEHYP2rdt1nORClvGKQSUFQZ4qfFUNSVXV8@vger.kernel.org, AJvYcCXO0mhP0Hxo4uVWrpzZWI5Qq0CQqmyL4uoppS5kKgcRmsbIDko5SPFnVgh21gbSlCp8NQs=@vger.kernel.org X-Gm-Message-State: AOJu0YwBoHq+c/0ih3JuxKDkwZE0Un6oVtgCa3Xy3oiGOTET7NXgSLrA Pv2dwp9U/o1WCN78bjuJxTbxLVWeDQRrl835MWzn90wyZbs6xo0dn08e+AvDew== X-Gm-Gg: ASbGncshMY9g3DPHBpTCRVGihv3WLH8ty988n2scoWRznXlqccHxr4oWrffDGvue0m/ Ez/W67JX5WvmdNvmdPyAytZpfb0Uq/+Gb8cPa46v+1/M1G1xtW69udIwuZWjKyCsDcVZrYiJdHk 17xBL1jnIkvBqytGdavDblWikQnj0y007SMJVSA0byvA9DJTbS+m3C+SygI9Mcv1ymomLttOVTe fcxRbbk3LG/mJcXohr2yoBD8yPicrIjMdDsuSbea6/CoCsU5H4hPO/sSHHMwoFf6UTvsaRl/6c0 WuD+C/FBy/1CTQARAT/2/VyT6XMIB/4+BbSPcRVOBD23h4mSA7RswLTxgPrNBqA6v0DqMCvp8FI p/g== X-Google-Smtp-Source: AGHT+IEtOCWRRtycCWE6b2ddeIkB621raQHnk3klmvycYJo2xwdbq//kpd/UA+wGQ7RO8gQtx2zEWA== X-Received: by 2002:a17:902:8212:b0:221:751f:cfbe with SMTP id d9443c01a7336-2390a4e1c2fmr1517585ad.19.1750867833222; Wed, 25 Jun 2025 09:10:33 -0700 (PDT) Received: from minh.192.168.1.1 ([2001:ee0:4f0e:fb30:1cf0:45c2:bdd1:b92d]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-237d873845esm143219175ad.243.2025.06.25.09.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 09:10:32 -0700 (PDT) From: Bui Quang Minh To: netdev@vger.kernel.org Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Bui Quang Minh Subject: [PATCH net 3/4] virtio-net: create a helper to check received mergeable buffer's length Date: Wed, 25 Jun 2025 23:08:48 +0700 Message-ID: <20250625160849.61344-4-minhquangbui99@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250625160849.61344-1-minhquangbui99@gmail.com> References: <20250625160849.61344-1-minhquangbui99@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, we have repeated code to check the received mergeable buffer's length with allocated size. This commit creates a helper to do that and converts current code to use it. Signed-off-by: Bui Quang Minh --- drivers/net/virtio_net.c | 68 +++++++++++++++++----------------------- 1 file changed, 29 insertions(+), 39 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 6f9fedad4a5e..844cb2a78be0 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -778,6 +778,26 @@ static unsigned int mergeable_ctx_to_truesize(void *mr= g_ctx) return (unsigned long)mrg_ctx & ((1 << MRG_CTX_HEADER_SHIFT) - 1); } =20 +static int check_mergeable_len(struct net_device *dev, void *mrg_ctx, + unsigned int len) +{ + unsigned int headroom, tailroom, room, truesize; + + truesize =3D mergeable_ctx_to_truesize(mrg_ctx); + headroom =3D mergeable_ctx_to_headroom(mrg_ctx); + tailroom =3D headroom ? sizeof(struct skb_shared_info) : 0; + room =3D SKB_DATA_ALIGN(headroom + tailroom); + + if (len > truesize - room) { + pr_debug("%s: rx error: len %u exceeds truesize %lu\n", + dev->name, len, (unsigned long)(truesize - room)); + DEV_STATS_INC(dev, rx_length_errors); + return -1; + } + + return 0; +} + static struct sk_buff *virtnet_build_skb(void *buf, unsigned int buflen, unsigned int headroom, unsigned int len) @@ -1819,8 +1839,7 @@ static struct page *xdp_linearize_page(struct net_dev= ice *dev, page_off +=3D *len; =20 while (--*num_buf) { - unsigned int headroom, tailroom, room; - unsigned int truesize, buflen; + unsigned int buflen; void *buf; void *ctx; int off; @@ -1832,17 +1851,8 @@ static struct page *xdp_linearize_page(struct net_de= vice *dev, p =3D virt_to_head_page(buf); off =3D buf - page_address(p); =20 - truesize =3D mergeable_ctx_to_truesize(ctx); - headroom =3D mergeable_ctx_to_headroom(ctx); - tailroom =3D headroom ? sizeof(struct skb_shared_info) : 0; - room =3D SKB_DATA_ALIGN(headroom + tailroom); - - if (unlikely(buflen > truesize - room)) { + if (check_mergeable_len(dev, ctx, buflen)) { put_page(p); - pr_debug("%s: rx error: len %u exceeds truesize %lu\n", - dev->name, buflen, - (unsigned long)(truesize - room)); - DEV_STATS_INC(dev, rx_length_errors); goto err_buf; } =20 @@ -2143,7 +2153,6 @@ static int virtnet_build_xdp_buff_mrg(struct net_devi= ce *dev, struct virtnet_rq_stats *stats) { struct virtio_net_hdr_mrg_rxbuf *hdr =3D buf; - unsigned int headroom, tailroom, room; struct skb_shared_info *shinfo; unsigned int xdp_frags_truesz =3D 0; unsigned int truesize; @@ -2189,20 +2198,14 @@ static int virtnet_build_xdp_buff_mrg(struct net_de= vice *dev, page =3D virt_to_head_page(buf); offset =3D buf - page_address(page); =20 - truesize =3D mergeable_ctx_to_truesize(ctx); - headroom =3D mergeable_ctx_to_headroom(ctx); - tailroom =3D headroom ? sizeof(struct skb_shared_info) : 0; - room =3D SKB_DATA_ALIGN(headroom + tailroom); - - xdp_frags_truesz +=3D truesize; - if (unlikely(len > truesize - room)) { + if (check_mergeable_len(dev, ctx, len)) { put_page(page); - pr_debug("%s: rx error: len %u exceeds truesize %lu\n", - dev->name, len, (unsigned long)(truesize - room)); - DEV_STATS_INC(dev, rx_length_errors); goto err; } =20 + truesize =3D mergeable_ctx_to_truesize(ctx); + xdp_frags_truesz +=3D truesize; + frag =3D &shinfo->frags[shinfo->nr_frags++]; skb_frag_fill_page_desc(frag, page, offset, len); if (page_is_pfmemalloc(page)) @@ -2416,18 +2419,12 @@ static struct sk_buff *receive_mergeable(struct net= _device *dev, struct sk_buff *head_skb, *curr_skb; unsigned int truesize =3D mergeable_ctx_to_truesize(ctx); unsigned int headroom =3D mergeable_ctx_to_headroom(ctx); - unsigned int tailroom =3D headroom ? sizeof(struct skb_shared_info) : 0; - unsigned int room =3D SKB_DATA_ALIGN(headroom + tailroom); =20 head_skb =3D NULL; u64_stats_add(&stats->bytes, len - vi->hdr_len); =20 - if (unlikely(len > truesize - room)) { - pr_debug("%s: rx error: len %u exceeds truesize %lu\n", - dev->name, len, (unsigned long)(truesize - room)); - DEV_STATS_INC(dev, rx_length_errors); + if (check_mergeable_len(dev, ctx, len)) goto err_skb; - } =20 if (unlikely(vi->xdp_enabled)) { struct bpf_prog *xdp_prog; @@ -2462,17 +2459,10 @@ static struct sk_buff *receive_mergeable(struct net= _device *dev, u64_stats_add(&stats->bytes, len); page =3D virt_to_head_page(buf); =20 - truesize =3D mergeable_ctx_to_truesize(ctx); - headroom =3D mergeable_ctx_to_headroom(ctx); - tailroom =3D headroom ? sizeof(struct skb_shared_info) : 0; - room =3D SKB_DATA_ALIGN(headroom + tailroom); - if (unlikely(len > truesize - room)) { - pr_debug("%s: rx error: len %u exceeds truesize %lu\n", - dev->name, len, (unsigned long)(truesize - room)); - DEV_STATS_INC(dev, rx_length_errors); + if (check_mergeable_len(dev, ctx, len)) goto err_skb; - } =20 + truesize =3D mergeable_ctx_to_truesize(ctx); curr_skb =3D virtnet_skb_append_frag(head_skb, curr_skb, page, buf, len, truesize); if (!curr_skb) --=20 2.43.0 From nobody Wed Oct 8 17:34:32 2025 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D5052BDC3F; Wed, 25 Jun 2025 16:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750867842; cv=none; b=G+vAKdZtFDWqiqe4TqmbsnFsd/avVqIcWB8fOOyrekf4HUEVpXRxZ67O9julRB/evw+PL38w0SW4RTgm3KgOE3HsTSjYoDB1cKjffDVENmYKucsQ+oyrJkja+vsikYFBJMKnjavOmbtoyABFFlJ7ueB3oLge1PBgTn3kZUBSg5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750867842; c=relaxed/simple; bh=ZvqfaDM3961shpPhB0QWB5bEV3krPacm7GyvkiFlYMc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ifg1xk0Z6iiI+fu0MTt32V6WnuFj7nfcpAJjs+aBXTpn6zStnUjapqXD1NSnB/XMENHqJQIEj3F0oRJhxRf8t9JynsnNadKMtQrRkrM+ohlE2LLUSX2bLCpD3SMIdYkpXPykukYDUie9fbUfrrlq04KBo5aWu5jYd12dyEpRx2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EstgvQjE; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EstgvQjE" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-23636167afeso765105ad.3; Wed, 25 Jun 2025 09:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750867839; x=1751472639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1MTOim0bI+o2eKzB/GRE0kdcUWqcDv8nQxQv5pqAodc=; b=EstgvQjE+EYSv4jC3myCZLpHWtozN1OKMwnmCDEAsc5OlAn+tBzpeJ84EgWn1sQDNo v1x4ZsOk5Okfuy323T0TFAXT43gAy3wFsFLZ5iuKT6kWiGdfDU0acae5xi9P1+/P5/HF Lslg96maOu4x7FskQorbfq3O1ZrB8wHMWCe25VIQDXMzgGIYjdJtXcjSdeqSYghHwBgW yD/4UtagdTKC6r3qkrc3Fhz3qlYEojyaVMnx0loI3LxvEoyhkumfvFloOlHi7WHfHz8+ S7oSWE+bN5IghlDdfUxEgN18NgyiUiR1eARZcz13o1lj1e3oiNQ5ePOjW+HCqOWxGBko 8ihQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750867839; x=1751472639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1MTOim0bI+o2eKzB/GRE0kdcUWqcDv8nQxQv5pqAodc=; b=hjMC9VkXlPRNNFCVKWY4YIuC5Zer/WXFxdValIA07TjZNG4HVTgmo6i9R38u0mZMBx yc1c1alE8jNUxSWGuVBgfHLbgGZIOuXrFh9IHYAW2UrDzGUPkIs21udK1XmJkFWwgqLa u4HSIvqL9BZOyKlhD4DUhx8n185z7nrEXok2qLfqkAvPr5u6p61vVDnFNC9MyX2L4evG 4u0yJakXQ+mJ7nfFLjYIH3aPma+W3zdPj6uNG9dBmL6v/pBMqH/Dtvo/OcT+xxkdQIvi tqoPlgsx8oKP8XN5VfAD/o2fdEOEraYxV/TwVtIOAfNIkOovuyMgPazUiJNQ5xuLcqqf WDxw== X-Forwarded-Encrypted: i=1; AJvYcCU38cDg746nscnmoYcwhnMpAUsGQJ9Bpr6bYfOhl2N3v8cbkxHjZ45kgfO5Egs9ZAAh6npkqacN4kCPeyMa@vger.kernel.org, AJvYcCWJVwdEHPr1sxK5o6cUeryGsfufivg+4ST1WO8Gu4a39fY9rF6bmrzfvZ/vAzehqAwFg98=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8pahVLjvt2OFrFCnp1sNOpmDt1zYNg0jqWtLCoKPkf+Q00ByZ iztTcoYuVlRL3bICkDaRx4KS9c6UVS8zthkxPCd81vogzi3UulPdeOUUFADSvQ== X-Gm-Gg: ASbGncs5LHSeoRDL2dpM5TQL2qvly1HEiBOwOi9Bb/3+C2ZmMcDoWSXRgb/gGz4I5qW 5cGL2Aq2WPYUGwjkzk1OIW96r1JgXezS1NIvzC+dbbYUbR9RKwP7GtuskTBxThvRxHl6kl72mbz WqfNFeYmp4ACBs5rf/7mvrGlZJlLgYsGKMwtaD4tNGfIZHuazskaJPi3CP7ggNHWSazIjftbr6O +TS6u6NHUnzb3FbS3cl8QwFLcrM0g4SD8XUoaZgw6B/uJssllEt6rpbSYzGm8CxeK6D2C3mrQKb HrykicEucxs7Bak6TOlZBVxo8O52byjvWbwFzqq1GR41GaFIbmBXRpRLIQed8IshLZaYzyi0OMV xSA== X-Google-Smtp-Source: AGHT+IFpH0ZhFM1LT/le3DUpl/1q/Q6WJthAozRqmYPKj6YzBEcv9GZLE7JYOv+loHFwm0tdUStuWw== X-Received: by 2002:a17:903:1a4e:b0:234:c549:d9f1 with SMTP id d9443c01a7336-23824086ea1mr55865985ad.47.1750867839525; Wed, 25 Jun 2025 09:10:39 -0700 (PDT) Received: from minh.192.168.1.1 ([2001:ee0:4f0e:fb30:1cf0:45c2:bdd1:b92d]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-237d873845esm143219175ad.243.2025.06.25.09.10.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 09:10:38 -0700 (PDT) From: Bui Quang Minh To: netdev@vger.kernel.org Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Bui Quang Minh Subject: [PATCH net 4/4] virtio-net: allow more allocated space for mergeable XDP Date: Wed, 25 Jun 2025 23:08:49 +0700 Message-ID: <20250625160849.61344-5-minhquangbui99@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250625160849.61344-1-minhquangbui99@gmail.com> References: <20250625160849.61344-1-minhquangbui99@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When the mergeable receive buffer is prefilled before XDP is set, it does not reserve the space for XDP_PACKET_HEADROOM and skb_shared_info. So when XDP is set and this buffer is used to receive frame, we need to create a new buffer with reserved headroom, tailroom and copy the frame data over. Currently, the new buffer's size is restricted to PAGE_SIZE only. If the frame data's length + headroom + tailroom exceeds PAGE_SIZE, the frame is dropped. However, it seems like there is no restriction on the total size in XDP. So we can just increase the size of new buffer to 2 * PAGE_SIZE in that case and continue to process the frame. In my opinion, the current drop behavior is fine and expected so this commit is just an improvement not a bug fix. Signed-off-by: Bui Quang Minh --- drivers/net/virtio_net.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 844cb2a78be0..663cec686045 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2277,13 +2277,26 @@ static void *mergeable_xdp_get_buf(struct virtnet_i= nfo *vi, len); if (!xdp_page) return NULL; + + *frame_sz =3D PAGE_SIZE; } else { + unsigned int total_len; + xdp_room =3D SKB_DATA_ALIGN(XDP_PACKET_HEADROOM + sizeof(struct skb_shared_info)); - if (*len + xdp_room > PAGE_SIZE) + total_len =3D *len + xdp_room; + + /* This must never happen because len cannot exceed PAGE_SIZE */ + if (unlikely(total_len > 2 * PAGE_SIZE)) return NULL; =20 - xdp_page =3D alloc_page(GFP_ATOMIC); + if (total_len > PAGE_SIZE) { + xdp_page =3D alloc_pages(GFP_ATOMIC, 1); + *frame_sz =3D 2 * PAGE_SIZE; + } else { + xdp_page =3D alloc_page(GFP_ATOMIC); + *frame_sz =3D PAGE_SIZE; + } if (!xdp_page) return NULL; =20 @@ -2291,8 +2304,6 @@ static void *mergeable_xdp_get_buf(struct virtnet_inf= o *vi, page_address(*page) + offset, *len); } =20 - *frame_sz =3D PAGE_SIZE; - put_page(*page); =20 *page =3D xdp_page; --=20 2.43.0