From nobody Wed Oct 8 19:13:20 2025 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD25B79D0 for ; Wed, 25 Jun 2025 05:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750828886; cv=none; b=SSJSBMo4Ypfgb6kVOKwOxdZz+BL/qtGsJ6xsxRUNF0ThjYMSyM4f+TcJtqbEPcqiy+ee5ejCtUnyPWd69l9aN9ZzteKCvtYtAiJQgDDjaDlo85Uk5W+2QT5T7bCJ+WhTYARrMrdoWIC/j7MAHVIk2CmNM33co/ezTbBLsOxVo7s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750828886; c=relaxed/simple; bh=xTCQ5Co7j4ZX7l03fJkRNZOE8GD7nb6sEADXr0HP+Sc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M4pOrIEhUsJdwvEhsNt3Zo5doNVemwb4E7BbafNVMa1tcDbtKtCBwyvoTsvhKANGTFEaSdhoIcroj3ebiBmQE5+QEXBfVdLOiEqiO18KzYGeNMGJLs3sQUVbL1ParRFJlTyQN0X0khV3BoRPAhw7WbFrAHoAiXHGm1njtr4k1zM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dQimpEvD; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dQimpEvD" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-74801bc6dc5so417815b3a.1 for ; Tue, 24 Jun 2025 22:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750828884; x=1751433684; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EdewN+OqwPnfjHa4kNqJuR+GOLJuDMWb9fhOCDaUpO4=; b=dQimpEvDKErL8a7WGESUmAgtdMZ14xL4pOHHsK+Gs8MEgXvoItHHddcBJRK/32t2uB NLycxL7AM5bJcXLapcD/EXJENXZNsSFH34hKdCZnncNHoqO+L0Zu8vKN+38ET+cmWqin FSa/IJdttL/fWsE958dVXAkBOmhJIe26DVS+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750828884; x=1751433684; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EdewN+OqwPnfjHa4kNqJuR+GOLJuDMWb9fhOCDaUpO4=; b=J9VQ6hQgD5r170zgyfHHzxYQE3aN1owMZp7KF3gDYdsa1mqOLUTtwPyyyFFRmDIF0Z RoEIvM99LAtN2jHtsmcMOxwdtlJW7Afgq2Ak882t4wuXIkMt4GHdJRHAG5HHxumGju01 VDlOROFch6GvNoqGv5xcWdk2tAkv1XcXZpAltnVqWgazS3RFFNyzk+wH2Bwp5nDi3YBa EGVDecOQrljXT3xmthtf5/MOIpKxOtzuavTIgr2WUpeXQAyDyOisXvpBu1EQWpB874TX CbH6geqZFyr9Ooxx0swbUckgX0PJmRKTIrzU8KKv0EqJ2Z8QeqkuStY3DQ07S/8OAzMF UwDg== X-Forwarded-Encrypted: i=1; AJvYcCXsb8tTlyDK9G4FwL6Ku0cjPcT9FEPFR11hTiaJ4m1YZDVBQsRqnKibRLJHinNzvcUfPh5U9Fjrphk197Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yxvr00wNpu2siv2m4M8WSfPa00pNaGAcKVM8cI8eMMejAxDwxdB G4h0pIr09WmG4C16L6vJDs6GDUoKKUqcU1l9A3a2b1xScZQeEPFwXwACJVVAA97+9A== X-Gm-Gg: ASbGncundiNwrDtMsNV6t5CGnV8Tfj3ZyiejAStvPaEiu2G7zu/SCUTLf68vRptNR64 wWz+92MhJ9s0n+/8BP5Xk6qnlKeLZB8rexff5ASECNmCqLM3jMra1jN6TXwUd/Qe+OKPByq+CGW b8LWXMfT7KyfzDF4Y/mAW5lIw8Zy2FeKVcpdzKTs+4CggMIY+lbXZWB3sntVUza2QhxgNduu+pW MaHl/8RVvjfafvnw0ZpGCZ45uGBUShY1fnfUu9k0hPpqO2n4zLdc7WW0gIEwC0IbhgrUV8Oponk Z7wv3UB8rJojTT1rbe6Ry8yN5v4zvYd19Iqrqn8Wq4psdyNKmUkFWdlB1vRGfYnJmTX3CpwC71U CI1nbnA0hvTcu X-Google-Smtp-Source: AGHT+IHtRUvI4BFjONg8E4iCJF2EoVUYaYsRjRtF6W4pN3FGjeweBp2iZqpmntUDbugSl88Vu2pCtA== X-Received: by 2002:a05:6a00:464f:b0:749:1e60:bdd with SMTP id d2e1a72fcca58-74ad4ad593emr2674902b3a.2.1750828884013; Tue, 24 Jun 2025 22:21:24 -0700 (PDT) Received: from tigerii.tok.corp.google.com ([2401:fa00:8f:203:301e:ee9a:3fb5:c761]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-749c882cda6sm3536393b3a.96.2025.06.24.22.21.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 22:21:23 -0700 (PDT) From: Sergey Senozhatsky To: Chaotian Jing , Ulf Hansson , Matthias Brugger , AngeloGioacchino Del Regno Cc: Masami Hiramatsu , Tomasz Figa , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Sergey Senozhatsky Subject: [PATCH] mtk-sd: reset host->mrq on prepare_data() error Date: Wed, 25 Jun 2025 14:20:37 +0900 Message-ID: <20250625052106.584905-1-senozhatsky@chromium.org> X-Mailer: git-send-email 2.50.0.714.g196bf9f422-goog In-Reply-To: <174972756982.3337526.6755001617701603082.stgit@mhiramat.tok.corp.google.com> References: <174972756982.3337526.6755001617701603082.stgit@mhiramat.tok.corp.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Do not leave host with dangling ->mrq pointer if we hit the msdc_prepare_data() error out path. Signed-off-by: Sergey Senozhatsky Reviewed-by: Masami Hiramatsu (Google) --- drivers/mmc/host/mtk-sd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index b12cfb9a5e5f..d7020e06dd55 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -1492,6 +1492,7 @@ static void msdc_ops_request(struct mmc_host *mmc, st= ruct mmc_request *mrq) if (mrq->data) { msdc_prepare_data(host, mrq->data); if (!msdc_data_prepared(mrq->data)) { + host->mrq =3D NULL; /* * Failed to prepare DMA area, fail fast before * starting any commands. --=20 2.50.0.714.g196bf9f422-goog