From nobody Wed Oct 8 19:15:18 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 789AA3074B8; Wed, 25 Jun 2025 04:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750825059; cv=none; b=GFc+/6Anncg56ClilOZki67fbYx6ekKupEnpGqmCg4L0RupJJ1QJ99pzApcgZ7dR0Nk97qcO6sl+3eKMHXBZbDYrdMOLcrAoNUEPsWTRxrMO+IMQwmznvLWrKhF0Wz+k2lz3wlZhYhRgptTdmKQNel87JdYU54UzijSz6wvyXF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750825059; c=relaxed/simple; bh=LU5gpIhuAUK109q+rE1Usl5jLpZUfP8Ja5YEHv+2uUg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gx4XZIhhKoZqFyiJjFRyv692VLJq1BWgVZHP8p35a+e94RnsCBEFOYmFJu9RC08KEan+FcAgdZWXfW1iJFbms2RHJWYgtDnHcibTd7S4vUNk+iepHL7YakK7EgFIDKMRauA3NspzG6wKSiAgwRFn8XbLXqUBx51ff4M10iaH/4Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=sLu2xyNy; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="sLu2xyNy" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55OMigaA030672; Wed, 25 Jun 2025 04:17:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=emLgM d9NdJMjhl8z4aBxY3ZGdmBDfpCboppn1p+odHQ=; b=sLu2xyNyx6zdFy4KAjzlh ETOd+BH31D72lw59vDkqgAQKoKPb+TQ0UOCNFgyaGyxwReqqboPSYXqn0NxgVpzE NuKqODgplFj+oTZVLh6Hp2R5UqUUqFR6uettkqqx2IdSrtJ2QxaW3KuoYxgRqH7t VOkZqOWiNoNAAQxTmNZm9CeidLOvUBzVlR4byW5T7p2Y6IUVpG8OeFicjvcMB2q5 utmEBmNMHdfISCiEZAaEb9XfdBR5Q7PI8iYQ6CmJyEniylkFved2gWB3fkFbH22v nfuo/Fh4YNSjFWR5cj6Bj9ZE2T0MHh7GRr2OfaHM19qbG9OIziZpeJmWM/oO3npC g== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47ds8mxej4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 04:17:19 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55P1WKS6024347; Wed, 25 Jun 2025 04:17:18 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47ehkrhffr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 04:17:18 +0000 Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 55P4HGqa029022; Wed, 25 Jun 2025 04:17:17 GMT Received: from ca-dev110.us.oracle.com (ca-dev110.us.oracle.com [10.129.136.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 47ehkrhfem-2; Wed, 25 Jun 2025 04:17:17 +0000 From: Alok Tiwari To: linux-nvme@lists.infradead.org, rdunlap@infradead.org, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, nilay@linux.ibm.com, corbet@lwn.net Cc: alok.a.tiwari@oracle.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/5] nvme: Fix multiple spelling and grammar issues in host drivers Date: Tue, 24 Jun 2025 21:16:30 -0700 Message-ID: <20250625041643.174110-2-alok.a.tiwari@oracle.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250625041643.174110-1-alok.a.tiwari@oracle.com> References: <20250625041643.174110-1-alok.a.tiwari@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-25_01,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506250029 X-Authority-Analysis: v=2.4 cv=IcWHWXqa c=1 sm=1 tr=0 ts=685b7850 b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6IFa9wvqVegA:10 a=yPCof4ZbAAAA:8 a=JfrnYn6hAAAA:8 a=XhBexOnarudRnIWOcXAA:9 a=1CNFftbPRP8L7MoqJWF3:22 cc=ntf awl=host:13207 X-Proofpoint-ORIG-GUID: Wz8z3D6RuFZ3FBn-U2dDtbpmDQ0mPanP X-Proofpoint-GUID: Wz8z3D6RuFZ3FBn-U2dDtbpmDQ0mPanP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI1MDAzMCBTYWx0ZWRfX5//C/y83WULC Ws63kyfQJOyPORryhoW6td+0nH0Acqmoegn3XX27gvX9bL0AzRgmneYrpi4BxcqCYbc1yEQPbYD IQyRWGDmGbpqsi2z7GGMLiwtuzoSBfkQyXvEbaaeIyxq5VF8XdOF29q7DhgmLP/9vBjCXM7fp9Z +sJ2wtvP91Gg5vI6C1eDVNEM1TSLgxinx7lNqTXxo3gJnEfpstaxdUJW5JM8A1TbM6CfTQO2mvZ H9yap2Q4/ah6S05NzAuo4WVkUW8NDywAXR4UzyxA2ZkXB66hUbN28ncq7sbDQy4mWD5DQnf6Har qTmZU8ehyzTIXuAS8RR1ebBOLPrzOHUreQz/PEJTWq2sqGMR717FQnlquvwMu1rrQ4qMfW7XAE3 EgbEQLrh6rHomDhuYGbFpMLELu/lhFSNpI8ljonmCToA96OMklQJXj8C9tYXozmi+/lPQ01+ Content-Type: text/plain; charset="utf-8" This commit fixes several typos and grammatical issues across various nvme host driver files: - Corrected "glace" to "glance" in a comment in apple.c - Fixed "Idependent" to "Independent" in core.c - Changed "unsucceesful" to "unsuccessful", "they blk-mq" to "the blk-mq", Fixed "terminaed" to "terminated" and other grammar in fc.c - Updated "O's" to "0's" to clarify meaning in nvme.h - function name comment *_transter_len() -> *_transfer_len() in zns.c Fixed sysfs_emit() output format in pci.c (replaced x%08x with 0x%08x) These changes improve the code readability and documentation consistency across the NVMe driver. Signed-off-by: Alok Tiwari Reviewed-by: Randy Dunlap Reviewed-by: Chaitanya Kulkarni --- v2 no changes only added Reviewed-by --- drivers/nvme/host/apple.c | 4 ++-- drivers/nvme/host/core.c | 2 +- drivers/nvme/host/fc.c | 10 +++++----- drivers/nvme/host/nvme.h | 2 +- drivers/nvme/host/pci.c | 2 +- drivers/nvme/host/rdma.c | 2 +- drivers/nvme/target/passthru.c | 4 ++-- drivers/nvme/target/zns.c | 2 +- 8 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c index b1fddfa33ab97..1286c31320e63 100644 --- a/drivers/nvme/host/apple.c +++ b/drivers/nvme/host/apple.c @@ -301,8 +301,8 @@ static void apple_nvme_submit_cmd(struct apple_nvme_que= ue *q, memcpy(&q->sqes[tag], cmd, sizeof(*cmd)); =20 /* - * This lock here doesn't make much sense at a first glace but - * removing it will result in occasional missed completetion + * This lock here doesn't make much sense at a first glance but + * removing it will result in occasional missed completion * interrupts even though the commands still appear on the CQ. * It's unclear why this happens but our best guess is that * there is a bug in the firmware triggered when a new command diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 92697f98c601d..ffefa781a3de3 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -4289,7 +4289,7 @@ static void nvme_scan_ns(struct nvme_ctrl *ctrl, unsi= gned nsid) } =20 /* - * If available try to use the Command Set Idependent Identify Namespace + * If available try to use the Command Set Independent Identify Namespace * data structure to find all the generic information that is needed to * set up a namespace. If not fall back to the legacy version. */ diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index 014b387f1e8b1..08a5ea3e93836 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -899,7 +899,7 @@ EXPORT_SYMBOL_GPL(nvme_fc_set_remoteport_devloss); * may crash. * * As such: - * Wrapper all the dma routines and check the dev pointer. + * Wrap all the dma routines and check the dev pointer. * * If simple mappings (return just a dma address, we'll noop them, * returning a dma address of 0. @@ -1955,8 +1955,8 @@ nvme_fc_fcpio_done(struct nvmefc_fcp_req *req) } =20 /* - * For the linux implementation, if we have an unsucceesful - * status, they blk-mq layer can typically be called with the + * For the linux implementation, if we have an unsuccessful + * status, the blk-mq layer can typically be called with the * non-zero status and the content of the cqe isn't important. */ if (status) @@ -2429,7 +2429,7 @@ static bool nvme_fc_terminate_exchange(struct request= *req, void *data) =20 /* * This routine runs through all outstanding commands on the association - * and aborts them. This routine is typically be called by the + * and aborts them. This routine is typically called by the * delete_association routine. It is also called due to an error during * reconnect. In that scenario, it is most likely a command that initializ= es * the controller, including fabric Connect commands on io queues, that @@ -2622,7 +2622,7 @@ nvme_fc_unmap_data(struct nvme_fc_ctrl *ctrl, struct = request *rq, * as part of the exchange. The CQE is the last thing for the io, * which is transferred (explicitly or implicitly) with the RSP IU * sent on the exchange. After the CQE is received, the FC exchange is - * terminaed and the Exchange may be used on a different io. + * terminated and the Exchange may be used on a different io. * * The transport to LLDD api has the transport making a request for a * new fcp io request to the LLDD. The LLDD then allocates a FC exchange diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index a468cdc5b5cb7..97818eb1a4143 100644 --- a/drivers/nvme/host/nvme.h +++ b/drivers/nvme/host/nvme.h @@ -69,7 +69,7 @@ enum nvme_quirks { NVME_QUIRK_IDENTIFY_CNS =3D (1 << 1), =20 /* - * The controller deterministically returns O's on reads to + * The controller deterministically returns 0's on reads to * logical blocks that deallocate was called on. */ NVME_QUIRK_DEALLOCATE_ZEROES =3D (1 << 2), diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 8ff12e415cb5d..982abf0514c9d 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2333,7 +2333,7 @@ static ssize_t cmb_show(struct device *dev, struct de= vice_attribute *attr, { struct nvme_dev *ndev =3D to_nvme_dev(dev_get_drvdata(dev)); =20 - return sysfs_emit(buf, "cmbloc : x%08x\ncmbsz : x%08x\n", + return sysfs_emit(buf, "cmbloc : 0x%08x\ncmbsz : 0x%08x\n", ndev->cmbloc, ndev->cmbsz); } static DEVICE_ATTR_RO(cmb); diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index 9bd3646568d03..190a4cfa8a5ee 100644 --- a/drivers/nvme/host/rdma.c +++ b/drivers/nvme/host/rdma.c @@ -877,7 +877,7 @@ static int nvme_rdma_configure_io_queues(struct nvme_rd= ma_ctrl *ctrl, bool new) =20 /* * Only start IO queues for which we have allocated the tagset - * and limitted it to the available queues. On reconnects, the + * and limited it to the available queues. On reconnects, the * queue number might have changed. */ nr_queues =3D min(ctrl->tag_set.nr_hw_queues + 1, ctrl->ctrl.queue_count); diff --git a/drivers/nvme/target/passthru.c b/drivers/nvme/target/passthru.c index b7515c53829b8..3b4b0df8f8799 100644 --- a/drivers/nvme/target/passthru.c +++ b/drivers/nvme/target/passthru.c @@ -106,7 +106,7 @@ static u16 nvmet_passthru_override_id_ctrl(struct nvmet= _req *req) pctrl->max_hw_sectors); =20 /* - * nvmet_passthru_map_sg is limitted to using a single bio so limit + * nvmet_passthru_map_sg is limited to using a single bio so limit * the mdts based on BIO_MAX_VECS as well */ max_hw_sectors =3D min_not_zero(BIO_MAX_VECS << PAGE_SECTORS_SHIFT, @@ -147,7 +147,7 @@ static u16 nvmet_passthru_override_id_ctrl(struct nvmet= _req *req) * When passthru controller is setup using nvme-loop transport it will * export the passthru ctrl subsysnqn (PCIe NVMe ctrl) and will fail in * the nvme/host/core.c in the nvme_init_subsystem()->nvme_active_ctrl() - * code path with duplicate ctr subsynqn. In order to prevent that we + * code path with duplicate ctrl subsysnqn. In order to prevent that we * mask the passthru-ctrl subsysnqn with the target ctrl subsysnqn. */ memcpy(id->subnqn, ctrl->subsysnqn, sizeof(id->subnqn)); diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c index 29a60fabfcc8a..15a579cf528c1 100644 --- a/drivers/nvme/target/zns.c +++ b/drivers/nvme/target/zns.c @@ -541,7 +541,7 @@ void nvmet_bdev_execute_zone_append(struct nvmet_req *r= eq) struct bio *bio; int sg_cnt; =20 - /* Request is completed on len mismatch in nvmet_check_transter_len() */ + /* Request is completed on len mismatch in nvmet_check_transfer_len() */ if (!nvmet_check_transfer_len(req, nvmet_rw_data_len(req))) return; =20 --=20 2.46.0 From nobody Wed Oct 8 19:15:18 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDB9EA48; Wed, 25 Jun 2025 04:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750825059; cv=none; b=WauSnkqiJVi97LCuQH1LiN1sGBe8R8s0LGC0rpB28AUPSukrL4OqSaDgmJKCwV9GZiO/n0KKYbAfQ9tXvdhzUIxgOkjj2/pfGLTfGVRN1KewJ/xiKIL+6mVpR2/7f5kV72X9zjOa69ytgrveujEhPjY21iEq2+Zh65OCpXqZl/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750825059; c=relaxed/simple; bh=ayz0ddO8nsSjDXhUrpotgHNzVxU0EFw4zfpcC/d7MPA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=doquu8mTO0gTxsgtPSZ2oUrC1N7lwnWWFg8jCXul0Vx6MossTkENnTVma7DRdMzal8SkyVGT76MPo3hu3xFgftC6mRHORkC22gDI3RnbcbD0/v6RR+el49YMTLOIDt5vr3Q2D16/AlxNzjC4a11vLJuEPwx0keeOjiFhFfnSzeQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=qFEzvlro; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="qFEzvlro" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55OMif1S019163; Wed, 25 Jun 2025 04:17:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=F6lc3 DSqQYj9CtY6Jlxvu1LhuvGfPj9itOscaOVFwY0=; b=qFEzvlrotHs9pAPB4NBwd h3CGDoQ3vc/5nI/G9UuoURGeHfhzEa+2bV/Q0LYp266HAw371YxJhcu54lwacVj4 20gIrGrArqqSohqxoFI133QGw7IuepQhEp/D11Haxe3B8VSqj19e1lPIW+0Kz8q/ llRuGTOYzT7Tj3DUJr6h8MOiqSTqJd/telG+e+bYZCP47ZJZVr0ojNZ8SxzuqjPX qP2gMKR+6il3na04T+36Ofv8HNVkPC1QPoT+2//omnxdgYwE5NEVRcI44dtN02V7 2hJT2XSRbEWSoOeBxmii75G/sDt8dmdEs+/uiMF+djmhY7xJl02B8x9rOUIsyx1L g== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47ds7uxjfb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 04:17:21 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55P3Sue9024338; Wed, 25 Jun 2025 04:17:19 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47ehkrhfga-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 04:17:19 +0000 Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 55P4HGqc029022; Wed, 25 Jun 2025 04:17:19 GMT Received: from ca-dev110.us.oracle.com (ca-dev110.us.oracle.com [10.129.136.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 47ehkrhfem-3; Wed, 25 Jun 2025 04:17:19 +0000 From: Alok Tiwari To: linux-nvme@lists.infradead.org, rdunlap@infradead.org, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, nilay@linux.ibm.com, corbet@lwn.net Cc: alok.a.tiwari@oracle.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/5] nvme: Fix incorrect variable in io cqes error message Date: Tue, 24 Jun 2025 21:16:31 -0700 Message-ID: <20250625041643.174110-3-alok.a.tiwari@oracle.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250625041643.174110-1-alok.a.tiwari@oracle.com> References: <20250625041643.174110-1-alok.a.tiwari@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-25_01,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506250029 X-Proofpoint-GUID: cGEJcelzIzUfI69AJ7iKTjCVqb57Dtow X-Authority-Analysis: v=2.4 cv=CeII5Krl c=1 sm=1 tr=0 ts=685b7851 b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6IFa9wvqVegA:10 a=yPCof4ZbAAAA:8 a=JfrnYn6hAAAA:8 a=SRTLixNVdz0Y03tMcBAA:9 a=1CNFftbPRP8L7MoqJWF3:22 cc=ntf awl=host:13207 X-Proofpoint-ORIG-GUID: cGEJcelzIzUfI69AJ7iKTjCVqb57Dtow X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI1MDAzMCBTYWx0ZWRfX8LPr2HxVY4Fi dG9dNes1JoAMnhHsPuCP+IXi3lfSl1qyq2u8hnTDXgMXt+lg92aY5yET5020RQTt1bnS1upC3hw WwXs+mltvo8RMguQ4ryI1W9AqIFXJj/E0Wc+ASoEOepRZivkASJgRBe1AKJckLLN5QlEsrCpi3q S5Dw+A02OYK1cHQtN1p3ACmq7xCGJ7ok6nOFEXTkVKFKmvWNDxpF8dLU4zmY+l8JtaA5ei8K7cM jdU1It2AVVVoVvwMry8WGE3Y85JwGqlxUU7EAhc6OTxWrPwpH9OKznHAt+ROKqBqXf+wObxLMuK VNmoZ1CD4hV8su874ksnFms2jnznl1WGo8/KtFAd79k+NiDbfZQ9G6l9n7MCrYBOqiOI/TGV0ed q/KwL6KqJANLhJvWQtOJPyCHt87E8Kb5dD/v0sDG2CJ7ONdAgxF5/wpQZTvaFlBcZObsZji5 Content-Type: text/plain; charset="utf-8" Corrected the error log to print ctrl->io_cqes instead of incorrectly using ctrl->io_sqes for the io cqes size check. Signed-off-by: Alok Tiwari Reviewed-by: Randy Dunlap Reviewed-by: Chaitanya Kulkarni --- v2 no changes only added Reviewed-by --- drivers/nvme/target/pci-epf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/target/pci-epf.c b/drivers/nvme/target/pci-epf.c index a4295a5b8d280..44288d8f5aa11 100644 --- a/drivers/nvme/target/pci-epf.c +++ b/drivers/nvme/target/pci-epf.c @@ -1860,7 +1860,7 @@ static int nvmet_pci_epf_enable_ctrl(struct nvmet_pci= _epf_ctrl *ctrl) ctrl->io_cqes =3D 1UL << nvmet_cc_iocqes(ctrl->cc); if (ctrl->io_cqes < sizeof(struct nvme_completion)) { dev_err(ctrl->dev, "Unsupported I/O CQES %zu (need %zu)\n", - ctrl->io_sqes, sizeof(struct nvme_completion)); + ctrl->io_cqes, sizeof(struct nvme_completion)); goto err; } =20 --=20 2.46.0 From nobody Wed Oct 8 19:15:18 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E572307490; Wed, 25 Jun 2025 04:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750825058; cv=none; b=HrpNpVm3kZ67ue5es1q02qIF477Vk/zUXXEtMWJZ9TB3xtf4NjBz8RwwKiWkume6UMKNAlET6gibDWP4erjCFn8RDlMJUGj1o1boaRERsxOPtfN+Ycw2o6WKjLqPfg5ELzRDQQbj9oZk/7hxUJRZzcXGLDngIBZW2lh5t3RRA8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750825058; c=relaxed/simple; bh=oBifa7HgdAmU0P8c+iv7KaLVhafdKxDD99mndx0l1Hc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rj1ug7kSkquynTpMw31g9OJ8QfWUgvgiZjKN5lo/lGCciirIitv28P5eAlZeFKZWLxf3uKBRSZjlycGN/3oPThjYHzJI/8dfWdQ7RwvLTugNvYO7AG2vTmEsGS/LFeYsWdi7xuzTcg7O6C2C1Vi8NHLWB7bdbZvDjQhhKi4k9mg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=hRIjSz28; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="hRIjSz28" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55OMiveR005149; Wed, 25 Jun 2025 04:17:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=SvGZh iUYui8KbGx47ihhr8pF1NSZfJJcOgsix8Qx1ac=; b=hRIjSz28X8/wKkPsTbiT3 VmpkS0XbElHxJCs3uCw4e5vDEapShUg5PRsxGqV/B6k0rRFneN7B+SiETIOCkFkY x3eeAEVLjW07zG7bypnRz2j7Wz5xGXHLRnCu9YXSg7ZarYanyS/68yPDQ6bH4X70 vMS/yF9DGNX7DAERQVSA67JOc2x4px//8D4xIQspp/JyTtvG7M5qKoEe/NkBMbK3 LXzXmi3n6bMH4n4CHWRRtaYhKZy2EpHaOLtL7UW6UbbHXCfDO8IdRsqeMlWGUiGD naCkpIX5RaTJsZQ+mOPQUSrI8+TpNURk7Dly70rFHgj0/gnXS/PvEAnE3lJWAkf7 Q== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47egt7dd07-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 04:17:21 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55P1fYqV024212; Wed, 25 Jun 2025 04:17:21 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47ehkrhfgv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 04:17:21 +0000 Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 55P4HGqe029022; Wed, 25 Jun 2025 04:17:20 GMT Received: from ca-dev110.us.oracle.com (ca-dev110.us.oracle.com [10.129.136.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 47ehkrhfem-4; Wed, 25 Jun 2025 04:17:20 +0000 From: Alok Tiwari To: linux-nvme@lists.infradead.org, rdunlap@infradead.org, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, nilay@linux.ibm.com, corbet@lwn.net Cc: alok.a.tiwari@oracle.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/5] nvmet: Remove redundant assignment of error code in nvmet_ns_enable() Date: Tue, 24 Jun 2025 21:16:32 -0700 Message-ID: <20250625041643.174110-4-alok.a.tiwari@oracle.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250625041643.174110-1-alok.a.tiwari@oracle.com> References: <20250625041643.174110-1-alok.a.tiwari@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-25_01,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506250029 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI1MDAzMCBTYWx0ZWRfX75lhb/iGGSBV 19j0x2GsWJyN4FSuaQORWyUI8Vt2ryiyeKXEw9TNot7NrKTAXvEDJP60p+7kf6/qGY7ozI/vLU8 hLGybdKgx8Kdmi3+YVMuT/O01uA15XFxaqIsMi8MzILKZTsdawlEQ0dMmur9PbIauRv/qinaJ8e 0Btr72QgdJIqmhU+mgnMLhzZQ2Ea+ZIwo67YL2jYnxZgSOz9e4a2b/23y1+VcqEbO2WkiABNAN7 /epkErt26oUAyLJ8KNRYCRulQmQ2IAzfynHL2yXqyYZVXGE3nlyuxXDyzdHTzv54ratAp/qEQ+i QN5Jjr8Bzsu7/dzvt654xCGqq0SxR43/XJXqDDU+9TnT9oNCzSLuBRyzcDbJMitDDS12ANMRfQV oK2/LAXOwtWWkL9p8617A1Nf/n+w/P6TrpbJx7kYD7/xZ3bxm74WgCYP7GGwOK4jPQx0kTt+ X-Proofpoint-GUID: L7LC2VHGr2DSRg6mxJ2BMUYGzwtydKYa X-Authority-Analysis: v=2.4 cv=QNpoRhLL c=1 sm=1 tr=0 ts=685b7852 b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6IFa9wvqVegA:10 a=yPCof4ZbAAAA:8 a=JfrnYn6hAAAA:8 a=hQNXMjqaqMWDSZxnGksA:9 a=1CNFftbPRP8L7MoqJWF3:22 cc=ntf awl=host:13207 X-Proofpoint-ORIG-GUID: L7LC2VHGr2DSRg6mxJ2BMUYGzwtydKYa Content-Type: text/plain; charset="utf-8" removing the unnecessary ret =3D -EMFILE; assignment since it is immediately overwritten by the result of nvmet_bdev_ns_enable() The initial value(-EMFILE) is redundant because it has no effect on the code logic or outcome. Signed-off-by: Alok Tiwari Reviewed-by: Randy Dunlap Reviewed-by: Chaitanya Kulkarni --- v2 no changes only added Reviewed-by --- drivers/nvme/target/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 175c5b6d4dd58..884286f90688a 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -581,8 +581,6 @@ int nvmet_ns_enable(struct nvmet_ns *ns) if (ns->enabled) goto out_unlock; =20 - ret =3D -EMFILE; - ret =3D nvmet_bdev_ns_enable(ns); if (ret =3D=3D -ENOTBLK) ret =3D nvmet_file_ns_enable(ns); --=20 2.46.0 From nobody Wed Oct 8 19:15:18 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 514E21DF99C; Wed, 25 Jun 2025 04:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750825062; cv=none; b=Ad+BSw+Fe98B4pAf2fEaeev+tfkpnwghH7kNO4m7kXbouF35dew8YKbMeRgK6LXUgTq0bGsob2wzAxb63SS6eMvLaIGG0Gn0iRvqScfm2rYRh67oMy0xwZI4PfL5hfK4Bg1zbAP4mP3R7YJyWqTtYxGNyC6G/HSLlk+qKz3NM9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750825062; c=relaxed/simple; bh=WaJG7fxZK60LRj2I0OegX5/Geds4wssue7zeBO7ztoU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qaOkeawZfnZqiW3k4cNLCLoGYBxEwWm4JhRiCZptMzeeuw4/8/kVPxvphkHmcpmVExUXFP7n0jkJCStvJ26H7wn7SUa3NsdIVfSfXwNWDA/ZpbqJ2hy7U5vIDi9yfquQFR4CmZYt2R9Nlh8GGCs4eZNzwfnx2MUV/f9xIK4Y2SQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=rN20owLt; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="rN20owLt" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55OMia1C012705; Wed, 25 Jun 2025 04:17:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=yvq1h WHBDno53FsR1afZbBZCFVS049qax8wAHdWQ3SI=; b=rN20owLtBbR4o9PVjydiz htl/pAJAjbzA4/uQudQwz5ghCeVp+Y3QSFdhvPwHW/95cWGHOBQu84ycsVBVC6zx y+Te7TiH8HxTV/a4qyPYKBXpMAX63ddaTiSuFXYrZKC5BYWJ4XEBNt8gwQuf+zdW A8iTGHHF8OhMPRcR5WpSxkYfloEpGNaUTIIAghr/Rv+ZaiarjwxJ4TJU71VJ22Ha a65W6/tAFgeOK+DqZjrfNV6ugsUbCmiAKoZdS+AtQUwJrCjmiNuREY6NzzxD/Bsu T/GqOrV2RiaynMujhCU3z0Razx+OwyyAlVPTRvX/wEWAdhK7IA2/eHFQf2CuVlJF A== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47egumnfr2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 04:17:23 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55P1Z36q024414; Wed, 25 Jun 2025 04:17:22 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47ehkrhfhe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 04:17:22 +0000 Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 55P4HGqg029022; Wed, 25 Jun 2025 04:17:22 GMT Received: from ca-dev110.us.oracle.com (ca-dev110.us.oracle.com [10.129.136.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 47ehkrhfem-5; Wed, 25 Jun 2025 04:17:22 +0000 From: Alok Tiwari To: linux-nvme@lists.infradead.org, rdunlap@infradead.org, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, nilay@linux.ibm.com, corbet@lwn.net Cc: alok.a.tiwari@oracle.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/5] nvme: Fix typo in status code constant for self-test in progress Date: Tue, 24 Jun 2025 21:16:33 -0700 Message-ID: <20250625041643.174110-5-alok.a.tiwari@oracle.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250625041643.174110-1-alok.a.tiwari@oracle.com> References: <20250625041643.174110-1-alok.a.tiwari@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-25_01,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506250029 X-Proofpoint-ORIG-GUID: l7oEuo7l1ztBQNgdxSvX8eNsLp-fXSbo X-Proofpoint-GUID: l7oEuo7l1ztBQNgdxSvX8eNsLp-fXSbo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI1MDAyOSBTYWx0ZWRfXxoDXhU0hKznN e6brteV+ZitTWd0TJMuwh72DhfBOWrqlqEGohwSSFy+FJoiiNFpkA3GFiONzWerjzzlsmXfjG5W z93AHH5EXnGAckkvvAjXAWHJWuS01BFnzo6P3nKYh1XKthXslfgrxJiFHm4xXKCZcH60ZaiFbkk KEjsysunmLRMBxI60y/qhNYREhrE57T8x/fjQZtmFjhvh5m6AapQSQkKCHasndzgND2bmIZt/TM eZXF8CtQoN/F0D4SocfPdT3I92befCW6OVlKwRrI5C55c++IVdgqKyQaRUVnLphI+i9V5zFAfXc O2bENS+26YL76GV2ItV3nhXIIfxVe4pTOemxY824sW8A6EEtRbYdispxuXL0WBwl1dTr0QopeIp UdmMyArQ/pcL5CddXlwM4FB9ghVTcsU7kSgK2TVeuE22nb01EJ08BFjMtInB52XYOBkaU3BE X-Authority-Analysis: v=2.4 cv=S5rZwJsP c=1 sm=1 tr=0 ts=685b7853 b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6IFa9wvqVegA:10 a=yPCof4ZbAAAA:8 a=JfrnYn6hAAAA:8 a=JPcgd-ljN0tfNaZuDOwA:9 a=1CNFftbPRP8L7MoqJWF3:22 cc=ntf awl=host:13207 Content-Type: text/plain; charset="utf-8" Corrected a typo error in the NVMe status code constant from NVME_SC_SELT_TEST_IN_PROGRESS to NVME_SC_SELF_TEST_IN_PROGRESS to accurately reflect its meaning. Signed-off-by: Alok Tiwari Reviewed-by: Randy Dunlap Reviewed-by: Chaitanya Kulkarni --- v2 no changes only added Reviewed-by --- drivers/nvme/host/constants.c | 4 ++-- include/linux/nvme.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/host/constants.c b/drivers/nvme/host/constants.c index 1a0058be58210..dc90df9e13a21 100644 --- a/drivers/nvme/host/constants.c +++ b/drivers/nvme/host/constants.c @@ -133,7 +133,7 @@ static const char * const nvme_statuses[] =3D { [NVME_SC_NS_NOT_ATTACHED] =3D "Namespace Not Attached", [NVME_SC_THIN_PROV_NOT_SUPP] =3D "Thin Provisioning Not Supported", [NVME_SC_CTRL_LIST_INVALID] =3D "Controller List Invalid", - [NVME_SC_SELT_TEST_IN_PROGRESS] =3D "Device Self-test In Progress", + [NVME_SC_SELF_TEST_IN_PROGRESS] =3D "Device Self-test In Progress", [NVME_SC_BP_WRITE_PROHIBITED] =3D "Boot Partition Write Prohibited", [NVME_SC_CTRL_ID_INVALID] =3D "Invalid Controller Identifier", [NVME_SC_SEC_CTRL_STATE_INVALID] =3D "Invalid Secondary Controller State", @@ -145,7 +145,7 @@ static const char * const nvme_statuses[] =3D { [NVME_SC_BAD_ATTRIBUTES] =3D "Conflicting Attributes", [NVME_SC_INVALID_PI] =3D "Invalid Protection Information", [NVME_SC_READ_ONLY] =3D "Attempted Write to Read Only Range", - [NVME_SC_CMD_SIZE_LIM_EXCEEDED ] =3D "Command Size Limits Exceeded", + [NVME_SC_CMD_SIZE_LIM_EXCEEDED] =3D "Command Size Limits Exceeded", [NVME_SC_ZONE_BOUNDARY_ERROR] =3D "Zoned Boundary Error", [NVME_SC_ZONE_FULL] =3D "Zone Is Full", [NVME_SC_ZONE_READ_ONLY] =3D "Zone Is Read Only", diff --git a/include/linux/nvme.h b/include/linux/nvme.h index b65a1b9f2116c..655d194f8e722 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -2155,7 +2155,7 @@ enum { NVME_SC_NS_NOT_ATTACHED =3D 0x11a, NVME_SC_THIN_PROV_NOT_SUPP =3D 0x11b, NVME_SC_CTRL_LIST_INVALID =3D 0x11c, - NVME_SC_SELT_TEST_IN_PROGRESS =3D 0x11d, + NVME_SC_SELF_TEST_IN_PROGRESS =3D 0x11d, NVME_SC_BP_WRITE_PROHIBITED =3D 0x11e, NVME_SC_CTRL_ID_INVALID =3D 0x11f, NVME_SC_SEC_CTRL_STATE_INVALID =3D 0x120, --=20 2.46.0 From nobody Wed Oct 8 19:15:18 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF7CE1E2307; Wed, 25 Jun 2025 04:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750825063; cv=none; b=nei/l68uRUUXB2NNShQN8XRMkTbp9AajISg3dnWFjhJev8T6iCVhIQMd9dEvWP/uqulOThbn0b40om4MCGkdbrxgUTJtbXaR1PyQxLAxA36UCnyBiDTGsJVPXUNtM8D/jsFy36/pYveSnyD2hM/aHCdphVsx3w0jj9jam+Bufuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750825063; c=relaxed/simple; bh=7z6DeedOJBeNMP/B+UH07XB98vYovCuAtoRvx475+VE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eG54szMIHRGBzxbgHgFL7HrwYDZipixfQWtwfBhVk1WF3kjHMGU3GBQ+e9zjk2b6qz31WnoE01MRe+aMmzS0wOg2MXFkQN31oQuG8JwSkr6PZo9vUYJesaQN1W9pU0pk1UhrFq8UXEoCUBT21/UL/npAHzbJdRMbBV4HZue70ag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=EztW5mlc; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="EztW5mlc" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55OMifMJ030643; Wed, 25 Jun 2025 04:17:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=ECbJE R7HPArjDkUDk2lFtARP1Py/Ve5oi80LCYZNong=; b=EztW5mlclaGDiB4O5FgRr jarlMBGOjVhMBka7q0SGLb5zePtRD0I5FmLC8AIWPeoKbAWkQQ1NLeDBAyJFiIv6 ZMwaPABgpfsKDLOFpnwARkxHpp4SfaOAoHDAvk+l7cth3TIHJu0LRQdXf07Uuh3u FY5pRaSu88Y7eFvKfLmmfZ9f+n9ctaxWkq6y7lRn4geyMjSbjPxXEOeNuSa+u5sm afEoYfNl8RV8iBQD9EuDAlSIETvuGXHvWW+GVG6Ri7S1BK0TOnNKKbL7N4Lu2X7P GDgSdg+uOcH7UDkgi0zZ+2m+sZXE4R7DjdIPFAiKymsqKYjp+sKkhwmfkkXzU1Sc w== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47ds8mxej5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 04:17:25 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55P3eaB1024408; Wed, 25 Jun 2025 04:17:24 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47ehkrhfhv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 04:17:24 +0000 Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 55P4HGqi029022; Wed, 25 Jun 2025 04:17:23 GMT Received: from ca-dev110.us.oracle.com (ca-dev110.us.oracle.com [10.129.136.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 47ehkrhfem-6; Wed, 25 Jun 2025 04:17:23 +0000 From: Alok Tiwari To: linux-nvme@lists.infradead.org, rdunlap@infradead.org, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, nilay@linux.ibm.com, corbet@lwn.net Cc: alok.a.tiwari@oracle.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/5] docs: nvme: fix grammar in nvme-pci-endpoint-target.rst Date: Tue, 24 Jun 2025 21:16:34 -0700 Message-ID: <20250625041643.174110-6-alok.a.tiwari@oracle.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250625041643.174110-1-alok.a.tiwari@oracle.com> References: <20250625041643.174110-1-alok.a.tiwari@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-25_01,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506250029 X-Authority-Analysis: v=2.4 cv=IcWHWXqa c=1 sm=1 tr=0 ts=685b7855 b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6IFa9wvqVegA:10 a=yPCof4ZbAAAA:8 a=JfrnYn6hAAAA:8 a=VwQbUJbxAAAA:8 a=8xN46rftBpwEPShuBVEA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=1CNFftbPRP8L7MoqJWF3:22 cc=ntf awl=host:13207 X-Proofpoint-ORIG-GUID: 42A_yuHYoqQbRvjFi9cZOixc_T0n_n7T X-Proofpoint-GUID: 42A_yuHYoqQbRvjFi9cZOixc_T0n_n7T X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI1MDAzMCBTYWx0ZWRfX++eHeVTEkkZw mz/IphO9hZYKsElG9f2kKuSHKKd6va4MTF0ezxtv5AehjQasw4KwMcCnMAJlMQC2prMikH0lHlT mAh5d5YsZPSC1YoRHnYn+NjheaL85iV1oZLRs026ypXZu6rKqjIo6DYojOBGgThHiCoxbePrb8z CvrtEzJO55u1j9PA+C++F1GZUfXcIbJg9bHIuOhu2uNcCZwkOU/udLCd+S4d7j3G/GC6lhujKSy u1g25YuliSEfq/fiK1NfWfPVoiE64ETZlKb6ix6tuNFypAeOdXltZxhrPcwo+3k5CLKysic/1PZ AA5WHhwhSsyXfhSaDieYQg0schEXDNzTZrosrP9mXNLTYgNb4dtkCGzALGkcvaUT0794VYQAerk nFT3DZoM/oKrMD8Yjk+41DC6sfI+CCUhNux7gSpLMxNHAgKHuSbixN7Vr7QfKLbIUeB3ruBU Content-Type: text/plain; charset="utf-8" Notable changes: Use "an NVMe" instead of "a NVMe" throughout the document Fix incorrect phrasing such as "will is discoverable" -> "is discoverable" Ensure consistent and proper article usage for clarity. Signed-off-by: Alok Tiwari Reviewed-by: Randy Dunlap Reviewed-by: Bagas Sanjaya Reviewed-by: Chaitanya Kulkarni --- v2=20 Extended the underline by one more character as suggested by Randy added Reviewed-by --- .../nvme/nvme-pci-endpoint-target.rst | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/Documentation/nvme/nvme-pci-endpoint-target.rst b/Documentatio= n/nvme/nvme-pci-endpoint-target.rst index b699595d1762b..2f75c8a267de5 100644 --- a/Documentation/nvme/nvme-pci-endpoint-target.rst +++ b/Documentation/nvme/nvme-pci-endpoint-target.rst @@ -6,20 +6,20 @@ NVMe PCI Endpoint Function Target =20 :Author: Damien Le Moal =20 -The NVMe PCI endpoint function target driver implements a NVMe PCIe contro= ller -using a NVMe fabrics target controller configured with the PCI transport t= ype. +The NVMe PCI endpoint function target driver implements an NVMe PCIe contr= oller +using an NVMe fabrics target controller configured with the PCI transport = type. =20 Overview =3D=3D=3D=3D=3D=3D=3D=3D =20 -The NVMe PCI endpoint function target driver allows exposing a NVMe target +The NVMe PCI endpoint function target driver allows exposing an NVMe target controller over a PCIe link, thus implementing an NVMe PCIe device similar= to a regular M.2 SSD. The target controller is created in the same manner as wh= en using NVMe over fabrics: the controller represents the interface to an NVMe subsystem using a port. The port transfer type must be configured to be "pci". The subsystem can be configured to have namespaces backed by regular files or block devices, or can use NVMe passthrough to expose to the PCI h= ost an -existing physical NVMe device or a NVMe fabrics host controller (e.g. a NV= Me TCP +existing physical NVMe device or an NVMe fabrics host controller (e.g. a N= VMe TCP host controller). =20 The NVMe PCI endpoint function target driver relies as much as possible on= the @@ -181,10 +181,10 @@ Creating an NVMe endpoint device is a two step proces= s. First, an NVMe target subsystem and port must be defined. Second, the NVMe PCI endpoint device m= ust be setup and bound to the subsystem and port created. =20 -Creating a NVMe Subsystem and Port ----------------------------------- +Creating an NVMe Subsystem and Port +----------------------------------- =20 -Details about how to configure a NVMe target subsystem and port are outsid= e the +Details about how to configure an NVMe target subsystem and port are outsi= de the scope of this document. The following only provides a simple example of a = port and subsystem with a single namespace backed by a null_blk device. =20 @@ -234,8 +234,8 @@ Finally, create the target port and link it to the subs= ystem:: # ln -s /sys/kernel/config/nvmet/subsystems/nvmepf.0.nqn \ /sys/kernel/config/nvmet/ports/1/subsystems/nvmepf.0.nqn =20 -Creating a NVMe PCI Endpoint Device ------------------------------------ +Creating an NVMe PCI Endpoint Device +------------------------------------ =20 With the NVMe target subsystem and port ready for use, the NVMe PCI endpoi= nt device can now be created and enabled. The NVMe PCI endpoint target driver @@ -303,7 +303,7 @@ device controller:: =20 nvmet_pci_epf nvmet_pci_epf.0: Enabling controller =20 -On the host side, the NVMe PCI endpoint function target device will is +On the host side, the NVMe PCI endpoint function target device is discoverable as a PCI device, with the vendor ID and device ID as configur= ed:: =20 # lspci -n --=20 2.46.0