From nobody Wed Oct 8 21:12:26 2025 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70BE71E32BE; Wed, 25 Jun 2025 03:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750821095; cv=none; b=KvXPxAs7Sj1bjkBBpMhGL4XrShTRKohxa/Vn6Mr+bl6FHbznhNMzjEws7OxR5KuS1K8LBuM1TFDO+S2VdAuuWlkMax+RgGmZG4aiT1UPUfkCOBFhcXXR2INhf4MHiJVoJlFjd4SI6JJGyT69CE1JUPNBcNSdlFmRvrQuChBqo+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750821095; c=relaxed/simple; bh=JPcvKh/jQAHEETOG+k6olIvrMgI+nTXU1PIG0qFgfik=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VCo5wcqXFiK5uyuVhrajnabFUq/ApHSZ4i6r+Tc2KpVOdHgsF7bx3medRV0JV3gOqRygY3F4rAbrILDas/urf067Xh8a2KnF2VEEmt2JCAa1M7qIlXnnvD78RVboB2cA5whdn+lt5NhDpwjtbCKx50kDEtbdT1HvR7VhA32TPeA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HpSRA0v1; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HpSRA0v1" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4a58d95ea53so5962521cf.0; Tue, 24 Jun 2025 20:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750821092; x=1751425892; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:feedback-id:from:to:cc:subject :date:message-id:reply-to; bh=CPJydrkhnERanEDJeh8iKFAtkTK1x51r4pmOIL1PfXo=; b=HpSRA0v19F9mUJnOXdepSt3nr9KiSJPHqh+KMuMeiu6vyC/ou3HAjGW6ag6nw+d8VB BwgtjTwyibi9Dxe4ircFPB3Xdt+GjmAmYHAJeV18DESVSeCJc9orxxpWMbtHOAmrPiHV 4EPFvVtETjDdMiW/xsxMO6UqTxY9E3bqeL484w3QN5IEXG3wG3QirWuwiwN7LehRsl3i l4utsRcduPSQT7mCuqE3cX89hS0DnvHTl5xb9qVF/HmpJeBdr1KHbhwQhIN5UHP7TL+3 O3R3kbrIbL4DS5HbQEwNdxa2hi8TTUKdbW3e0ctAsRatbeReNqRKrPycwJwfXx4F3xS8 WNVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750821092; x=1751425892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:feedback-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CPJydrkhnERanEDJeh8iKFAtkTK1x51r4pmOIL1PfXo=; b=u2PZzqla7FtZ8DbKju3KikB7YK0jc0pPLix+lXsARS+QmNvglEP1lf1lbHkU84Jxwu lJDUAIpzPumUmDEidGlaEdGyDn13D69OqlF4pm1AvOyz5V+hs4Ji6+tMSuhBVo0UApRW UCj9oYeVL2TkDmONwrLuk3R5MKouiclFJROPy8EGoSUmPr2gdQznc5DnTGgKW5FCXiAz oyrCRQ9BfUQYMJZBHimty19krJqjKkz0JmAMCqtNRqNFNRzkWhQXOdIkIAgEFe4/97ZD T2FTLUXrFhoHmxm1lCIolXkmqRpFKI1mo9NSPD80cjBGE24lUsCME7xX66BQ89vH7Pen XfMw== X-Forwarded-Encrypted: i=1; AJvYcCUsDCa0Dp5d1zHItyVOW6duPOYB3NGoofukZTPPJBS5ZPkHLkxaXGJYCaS/kaWf4NazjI3E@vger.kernel.org, AJvYcCXU6BKp9DiKvmmmMQ5/ZBpn0WALTSSjxhVVGdojd/D0ZkNBxGP6sUZm8zMe5NxcijsKNuG4ZpI=@vger.kernel.org X-Gm-Message-State: AOJu0YwQCFmmiNk62cozgS6xd/SxO5GXhmlvfCEUt4wTE2roq3Jf8Nxo EmEDZmjfxckpEKt5ky+8ae33c7Fm7x0Bfc6Vzl0wswSdJykGmMjQUzC6 X-Gm-Gg: ASbGncuOOhC1xuzcENGnQl+30ehszkZ3bJzy8CmGG+J2TC19IiGK0ogm9f/FmRPR/KZ P7RUmL59gq5OGJ4PYtPn3L24kyMwsVl1ca+PdhbsL3HS7xNU1KCYO/yh68f08xkxKL53fV/fpbe grCm/oDOzgRKIpoFKDYpfaHKb3CuX6DCK+3XKrcdG6eqLoRKKgFIq8uTT8aeNppkOuSEYw5ZCAl VxtNaOv74EblBADdR/uf1Ck4iJTg14HwrK1jlwWmfQLCyp59taYPEabh7Kl+8O4vCnfjZ27G4tp UD20nQE4rDkRIFvGDAaNZp/ic71xF1Uz4dhk3y8wbe5lSYOG9yVaB0NaGJd0NvIRFbLGQmJxcfG 3jRG0vAons0y+yjILHYJozZix9OMVutOm1gtk9wISmDls/MDzDPh0 X-Google-Smtp-Source: AGHT+IGW0TiZzG9hPxpBHcORi1BL38UTs0PtOJHlHm1exg6B9dlOGYVh+aZvZ1C6ZdIypaz5HFXCZA== X-Received: by 2002:a05:622a:198c:b0:4a7:896:f2d3 with SMTP id d75a77b69052e-4a7c112d0a4mr23737041cf.0.1750821092305; Tue, 24 Jun 2025 20:11:32 -0700 (PDT) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a79de8d57bsm30445411cf.72.2025.06.24.20.11.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 20:11:31 -0700 (PDT) Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfauth.phl.internal (Postfix) with ESMTP id 480CEF40066; Tue, 24 Jun 2025 23:11:31 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Tue, 24 Jun 2025 23:11:31 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgddvudeiiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeeuohhquhhnucfh vghnghcuoegsohhquhhnrdhfvghnghesghhmrghilhdrtghomheqnecuggftrfgrthhtvg hrnhepgeeljeeitdehvdehgefgjeevfeejjeekgfevffeiueejhfeuiefggeeuheeggefg necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsghoqh hunhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqieelvdeghedtieegqddu jeejkeehheehvddqsghoqhhunhdrfhgvnhhgpeepghhmrghilhdrtghomhesfhhigihmvg drnhgrmhgvpdhnsggprhgtphhtthhopedviedpmhhouggvpehsmhhtphhouhhtpdhrtghp thhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtg hpthhtoheprhgtuhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlkhhm mheslhhishhtshdrlhhinhhugidruggvvhdprhgtphhtthhopehpvghtvghriiesihhnfh hrrgguvggrugdrohhrghdprhgtphhtthhopehmihhnghhosehkvghrnhgvlhdrohhrghdp rhgtphhtthhopeifihhllheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepsghoqhhunh drfhgvnhhgsehgmhgrihhlrdgtohhmpdhrtghpthhtoheplhhonhhgmhgrnhesrhgvughh rghtrdgtohhmpdhrtghpthhtohepuggrvhgvsehsthhgohhlrggsshdrnhgvth X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Jun 2025 23:11:30 -0400 (EDT) From: Boqun Feng To: linux-kernel@vger.kernel.org, rcu@vger.kernel.org, lkmm@lists.linux.dev Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Breno Leitao , aeh@meta.com, netdev@vger.kernel.org, edumazet@google.com, jhs@mojatatu.com, kernel-team@meta.com, Erik Lundgren Subject: [PATCH 5/8] shazptr: Allow skip self scan in synchronize_shaptr() Date: Tue, 24 Jun 2025 20:10:58 -0700 Message-Id: <20250625031101.12555-6-boqun.feng@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250625031101.12555-1-boqun.feng@gmail.com> References: <20250625031101.12555-1-boqun.feng@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a module parameter for shazptr to allow skip the self scan in synchronize_shaptr(). This can force every synchronize_shaptr() to use shazptr scan kthread, and help testing the shazptr scan kthread. Another reason users may want to set this paramter is to reduce the self scan CPU cost in synchronize_shaptr(). Signed-off-by: Boqun Feng --- kernel/locking/shazptr.c | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/kernel/locking/shazptr.c b/kernel/locking/shazptr.c index a8559cb559f8..b3f7e8390eb2 100644 --- a/kernel/locking/shazptr.c +++ b/kernel/locking/shazptr.c @@ -14,11 +14,17 @@ #include #include #include +#include #include #include #include #include =20 +#ifdef MODULE_PARAM_PREFIX +#undef MODULE_PARAM_PREFIX +#endif +#define MODULE_PARAM_PREFIX "shazptr." + DEFINE_PER_CPU_SHARED_ALIGNED(void *, shazptr_slots); EXPORT_PER_CPU_SYMBOL_GPL(shazptr_slots); =20 @@ -252,6 +258,10 @@ static void synchronize_shazptr_busywait(void *ptr) } } =20 +/* Disabled by default. */ +static int skip_synchronize_self_scan; +module_param(skip_synchronize_self_scan, int, 0644); + static void synchronize_shazptr_normal(void *ptr) { int cpu; @@ -259,15 +269,19 @@ static void synchronize_shazptr_normal(void *ptr) =20 smp_mb(); /* Synchronize with the smp_mb() in shazptr_acquire(). */ =20 - for_each_possible_cpu(cpu) { - void **slot =3D per_cpu_ptr(&shazptr_slots, cpu); - void *val; + if (unlikely(skip_synchronize_self_scan)) { + blocking_grp_mask =3D ~0UL; + } else { + for_each_possible_cpu(cpu) { + void **slot =3D per_cpu_ptr(&shazptr_slots, cpu); + void *val; =20 - /* Pair with smp_store_release() in shazptr_clear(). */ - val =3D smp_load_acquire(slot); + /* Pair with smp_store_release() in shazptr_clear(). */ + val =3D smp_load_acquire(slot); =20 - if (val =3D=3D ptr || val =3D=3D SHAZPTR_WILDCARD) - blocking_grp_mask |=3D 1UL << (cpu / shazptr_scan.cpu_grp_size); + if (val =3D=3D ptr || val =3D=3D SHAZPTR_WILDCARD) + blocking_grp_mask |=3D 1UL << (cpu / shazptr_scan.cpu_grp_size); + } } =20 /* Found blocking slots, prepare to wait. */ --=20 2.39.5 (Apple Git-154)