From nobody Wed Oct 8 16:27:21 2025 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 081231A8F84; Thu, 26 Jun 2025 01:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750900703; cv=none; b=fkRos1UB22HP8rCHIaIbpuze2Kr5QYxUpe17mJBZyCLmaMxcLUP9rGYeJ2sfyfDjeMaYas/Baq2g2NRByV5nChASG9/G39E/WgVICbZKecvTyjcQU6KCNN8NhsqFPRX0V0QY/HJSQXVVdyWwMgVpcHBKrayuOgFrB9LJZPImFa4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750900703; c=relaxed/simple; bh=NId6dVIRM82oZqoe/djI3x5LrQqmZEFk9eESRjH1XbA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Gwh6hTfPcezhHD1+EXAK07oy8wxzloXNjeh7FHlZSU1LCtSH51qQrbcGKnR0nBlQuOomQ4kreD2MYiFb7qrFwG1EPtFwBpfTA03EsuU7aQHFP+FFlHoqQAgTUVFmBopE4+G98ihgC8yxVZe31bBUjnYcenqpG5uctc8HXT/R/hc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dTH+VM9i; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dTH+VM9i" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-235ea292956so5549375ad.1; Wed, 25 Jun 2025 18:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750900701; x=1751505501; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QUH60rkmaYOcZLjFXwllzQMjUnApXp6M8TjXxDz/90o=; b=dTH+VM9iLSIGtLsc4gpliY6vEyZfmkCUaOp8CCzW1xxBWzPpbM++m0HYfyRgsienj/ YaDSC+dbgdwcJSx8877LQ+myugP18vJW6ETwT0P+vv1sZg9pY1xWP9WFFvJguLyFrxMz ab9/dBI4JPYF8wB+4cXZuamAu8N2AhbNcE50YwCiACgx9T21qaKJ2gMiBCc47QbmcVNe DnQrRnMPoZKnDXmChGblKrcw6LAcO5HyiyChUBumOVhQgL3BgE15EdpM/1TuleOMJt/m dpfpvw/8tI/p2uoiTFRWfD+lntzLPFCAg4eY97zZ577uQGsypTthulXwpC001TkvWi7f PGlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750900701; x=1751505501; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QUH60rkmaYOcZLjFXwllzQMjUnApXp6M8TjXxDz/90o=; b=Txs0fKQPS/seI8qVSs0wiAq1KrOU+42muMYpsfA6nu4FkOh3APuUo/N7wj3X7G9Rfz UCw42B0p04MLRIyuTVywFmwgIQd5cweHNp7P84WpucOnEARaD7CG4psVfS663nPK63Cu x0pNrQv7NIDTNIt/1oNJ51oAZiT6u6hyfwChL7hQuAiouA+DSZL82FC/vs+M7Ul3X/fg cwx9YdSCoy1OWIUz0RDComN9DfQ/8YbONgkfZtvGnDV++DtGGayINxzWqUB8smedWbjo EBCFDtnUQ4J/QuUbWXh5IqW6sN8OQQTxT3mku4xVkdRmW3Fh8uvoPREAbx4bMIVjCKId A+og== X-Forwarded-Encrypted: i=1; AJvYcCU8a5LETYXnbf9P/Cg9ycUbVCNornX6t0LUxO8TdGeu6xx3wOsFgeS+YiT4ugTSqaUDubnt7FE0bEyDh24=@vger.kernel.org X-Gm-Message-State: AOJu0Yyb1nqbhw6C7ykRiDKT1e9xxjsNpWmAVENrkikKcqL0UYjrnekw RU8HNkbXK9kQIfE26Uls+GLn/5HZnk4j9wRhdGXTObvV+C8MrvRJ5PN8 X-Gm-Gg: ASbGncucVSqW4xf2wsXdBiOY/8rMa2M99lxC7HQziSGu8mc/37qtUWCMGGNXQlieKII ALwZb9zVgIIhX5+3AuLJvpEFOGwU/n/IzqrO/kS1Sn247P05iuPPyH59j4BkHvLze5yT4z/PPeH KyxzdtpZN5lsVtGvHl6bz+yIK2vmR6CQrnKpufqCG8WYEiW6DIzS2tyOg84KKG6vscBhpJWIPTK QWQTfC+/yR9miT+JqyOlaRgzqpei0Q00egoZEFrVVDbLt5UwCRIVWVTefKulanEYdQ6WPirLeP+ sNcTnWnRpS5Ry7KK83pHE9qwzsXEgvrtYbghhJifGjDHk7k4ubgmsK2247YRKA== X-Google-Smtp-Source: AGHT+IHG4Nr8+zs+gy4ZXyJCScP+aECQxrOdMQjGdXTeEDnCFd748e6PydeLLNA5lNjHk/muMZiYIA== X-Received: by 2002:a17:902:dad0:b0:234:d399:f948 with SMTP id d9443c01a7336-23824044836mr84127815ad.33.1750900701305; Wed, 25 Jun 2025 18:18:21 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d871f10fsm142710025ad.233.2025.06.25.18.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 18:18:20 -0700 (PDT) From: Kurt Borja Date: Wed, 25 Jun 2025 22:17:35 -0300 Subject: [PATCH 1/3] platform/x86: hp-bioscfg: Fix class device unregistration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250625-dest-fix-v1-1-3a0f342312bb@gmail.com> References: <20250625-dest-fix-v1-0-3a0f342312bb@gmail.com> In-Reply-To: <20250625-dest-fix-v1-0-3a0f342312bb@gmail.com> To: Jorge Lopez , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Mark Pearson , Prasanth Ksr , Mario Limonciello , Divya Bharathi Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1297; i=kuurtb@gmail.com; h=from:subject:message-id; bh=NId6dVIRM82oZqoe/djI3x5LrQqmZEFk9eESRjH1XbA=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBkx869eCVs3W3zupvB21blnFWa3/nqXYeE6Mbaz6gf3L LYV2cGPOkpZGMS4GGTFFFnaExZ9exSV99bvQOh9mDmsTCBDGLg4BWAixxwZ/krr7GJT2XVGcMn/ mp8tsUvubP8+w0Vv/akX2Q+XMIi3q+kyMqznlp9+qiz5eqk2986pKnvbPZU33XstMi3v6N+31r+ WcfIBAA== X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Devices under the firmware_attributes_class do not have unique a dev_t. Therefore, device_unregister() should be used instead of device_destroy(), since the latter may match any device with a given dev_t. Fixes: a34fc329b189 ("platform/x86: hp-bioscfg: bioscfg") Signed-off-by: Kurt Borja --- drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platfor= m/x86/hp/hp-bioscfg/bioscfg.c index 13237890fc92002e7e730b1c235ddf068a6737cd..5bfa7159f5bcd57385a20fe9ac6= 46597b320a378 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c @@ -1034,7 +1034,7 @@ static int __init hp_init(void) release_attributes_data(); =20 err_destroy_classdev: - device_destroy(&firmware_attributes_class, MKDEV(0, 0)); + device_unregister(bioscfg_drv.class_dev); =20 err_unregister_class: hp_exit_attr_set_interface(); @@ -1045,7 +1045,7 @@ static int __init hp_init(void) static void __exit hp_exit(void) { release_attributes_data(); - device_destroy(&firmware_attributes_class, MKDEV(0, 0)); + device_unregister(bioscfg_drv.class_dev); =20 hp_exit_attr_set_interface(); } --=20 2.50.0 From nobody Wed Oct 8 16:27:21 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F6A91BD9D3; Thu, 26 Jun 2025 01:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750900706; cv=none; b=AcxWqxYBvkvxDV40cp54cxyeEGTHs8phbYg2XpflogqjbpBYbxZwWy4sq1KrXGrUBRdcVePXqF0I+rN7Db7gKZLdjtTeQdZDb1g2lIWxQTUXkE1FlKsYmKOLr6SMC2ZN5a9PQunHm8maSIfBHJz6yK5/AaP7LCA58iXoKK6tZY4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750900706; c=relaxed/simple; bh=nC8H/A+QRZ3V0YztO+CXOqVjDLNDSttloQq+3XJkDJw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NnaGcnFYo8EjZWVAfy9PIkpK3XwjnLUWvDjupZQM4b+uWYSuoOUPxskLfgBfB3GtPt201hVEm0qOmzIFo9KNVldnNCTzYEuuWx7zqZgdE7Oc2ajKJuO7sQWj+haPtMjOsbYpZBE1VvEiIxdeA0eKnVmbCG6C5aWYxo5w6YSiX8M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SPvpS6Cb; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SPvpS6Cb" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-23633a6ac50so7012985ad.2; Wed, 25 Jun 2025 18:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750900705; x=1751505505; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FwIi6jWNZtQTGTAbQRjQnPjf7pghpX890D+aGUCZ1VE=; b=SPvpS6Cblap0b1TLnOrGcMgR18Hrwh1awyt9z+oeGlRda0F/9/MDidMxB5QOMUPQu6 md0jB8AoRIsJlzTO2sBfAnAzdhil1swQLNn/Dk02bGSx5VuRtFiomZA52sA/bP+aCxrL whse+OanpHXped8Cib8gUij+QlfTAxunCsVIJUpVNPPXUNh5QbgOJ9ux4eVRi8qbiSTh 20BWL9NDjfhnF3W8zLOoOQfSXfYKrH6DkiJnSxcMOWQowty5Cdb9fAHuZZZCWgbD4qm8 H1QKKSlBAhomnlgFo7GbKq6zwZEon1YFtDINQeuI87uecEbiJpR9M939SySVzvmVCOZd +UZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750900705; x=1751505505; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FwIi6jWNZtQTGTAbQRjQnPjf7pghpX890D+aGUCZ1VE=; b=uaPG0IxpvLB+cHZrbEo8PRNdcEOPCNKtUZujuXhJGss2RtkX/WojxCJXwO/RqLOyEG KQ+w3tm1ZSQ4fnS0ehsk9mGbX0beFMGrKi03fOPG5amEiQMGuv1NVt5awbim3vpDuAkn ssGU4k5a3p1Q6B/uW4qKXBSciPB/+w7edaso9UZ8bcHp+tDvPMbzO797x7H6fLNvKKPF zefClNvRE0uDxao1JNCk4Lk/xMWV1U4cdUS7t0cs0BfDofGhXIqAa7endsrHX+8DWt+y bPENSxdQsr68An+jFw5XrqDyXsuG9eXW6OmznNBoYrT0zPM/cZym6Gs1SkbSiSNu2W1i dfQQ== X-Forwarded-Encrypted: i=1; AJvYcCUe6W5VCwjnWERpEM7JxLIkPbGWuN/OUFfVPLJhyFr1B2jZbyA8wCt/UAGz1lXBtbX5TIoJ+XTMe2S6vZQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzo7eMT4dZ4J8OqptalihxmyvxYceqrzSBwmmI0wna4NA0IOQso Y7hf7v59Ew9TY+Zexo4ybAvt4ptHZNJDNGqp7xE42bhN/FMm3gfLJ4TX X-Gm-Gg: ASbGncs0aQYJurIif5JtJhuoUY+sCkLdfuttLJv5Q+gwO2GQsN3/kZHunC/bYXhGoE+ JVmwKlTlKYIGWexvoiuPs5lD1Aymo4bJNYRsvLKTb+WGot/c5Ob9mDYteogJ2WDfeaxsdlJx5jq riNqARFvjgscoQ7TfIaDt6mFtj6jvPn9qms01j2VRK8fWW0Kg1SFYyy008Klw4w8vSbOo0sohDW qwGolr/JEZ/+g2i/eBl5CeYh8TMQ0XRNK7oHxQEXXSMfzvWeZWhf0DRU9+/fnhIhutFu3XHiYQZ avFJc55SfYlc25H+ziiEFBvMpSAz8gQFQ1xwdPwd/elPL9Sa2+xaTMoF1ynRLA== X-Google-Smtp-Source: AGHT+IGtJvH5h4QmhjHN0NiHua+DnH4X/RUxAxgHcW/LIEV5hQwjVqbipbPqd8JgeBz895hX74yAkQ== X-Received: by 2002:a17:902:d491:b0:231:c792:205 with SMTP id d9443c01a7336-23823f6cee7mr89468815ad.4.1750900704884; Wed, 25 Jun 2025 18:18:24 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d871f10fsm142710025ad.233.2025.06.25.18.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 18:18:24 -0700 (PDT) From: Kurt Borja Date: Wed, 25 Jun 2025 22:17:36 -0300 Subject: [PATCH 2/3] platform/x86: think-lmi: Fix class device unregistration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250625-dest-fix-v1-2-3a0f342312bb@gmail.com> References: <20250625-dest-fix-v1-0-3a0f342312bb@gmail.com> In-Reply-To: <20250625-dest-fix-v1-0-3a0f342312bb@gmail.com> To: Jorge Lopez , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Mark Pearson , Prasanth Ksr , Mario Limonciello , Divya Bharathi Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1361; i=kuurtb@gmail.com; h=from:subject:message-id; bh=nC8H/A+QRZ3V0YztO+CXOqVjDLNDSttloQq+3XJkDJw=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBkx869O+d19t+NDgcGSVU7r97Apvlzn8dv3pv2vK8zMG jdEOO43dpSyMIhxMciKKbK0Jyz69igq763fgdD7MHNYmUCGMHBxCsBE4icy/DNwf+5QmGTebbp1 Jt/5FdfeNu5cs1Ti8uOiow6nf/OwVbUwMrS17v+zPHWnxcuTK1c2rr2kY9/0fVOcoX4fn5mo+4b NHbwA X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Devices under the firmware_attributes_class do not have unique a dev_t. Therefore, device_unregister() should be used instead of device_destroy(), since the latter may match any device with a given dev_t. Fixes: a40cd7ef22fb ("platform/x86: think-lmi: Add WMI interface support on= Lenovo platforms") Signed-off-by: Kurt Borja --- drivers/platform/x86/lenovo/think-lmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86= /lenovo/think-lmi.c index 34a47269e3d34d2eda6b71af73892656cd2bf67d..085d6fb8ff6a61009217dc2a397= f73116bceeb61 100644 --- a/drivers/platform/x86/lenovo/think-lmi.c +++ b/drivers/platform/x86/lenovo/think-lmi.c @@ -1556,7 +1556,7 @@ static int tlmi_sysfs_init(void) fail_create_attr: tlmi_release_attr(); fail_device_created: - device_destroy(&firmware_attributes_class, MKDEV(0, 0)); + device_unregister(tlmi_priv.class_dev); fail_class_created: return ret; } @@ -1783,7 +1783,7 @@ static int tlmi_analyze(struct wmi_device *wdev) static void tlmi_remove(struct wmi_device *wdev) { tlmi_release_attr(); - device_destroy(&firmware_attributes_class, MKDEV(0, 0)); + device_unregister(tlmi_priv.class_dev); } =20 static int tlmi_probe(struct wmi_device *wdev, const void *context) --=20 2.50.0 From nobody Wed Oct 8 16:27:21 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 344651CAA79; Thu, 26 Jun 2025 01:18:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750900710; cv=none; b=bNOvCt8YFnpSZKWDBtjdopOnD34/fFM7nxB9bvPpBKGhs3QHgQXOk/dhzx23MOpaKRY9fgyuP96/hKU10ujM3/pYshvYP+DcaGRBdKA+mf8iPuavh2XwWleplrM6nTNwdKKpuxW+F//hdOO1d4Nm9Do2fRbnR/RGBgNn5Gc9eaw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750900710; c=relaxed/simple; bh=+0W0cycMmDqAsq4M7XhomUZQgzncfix1NC75ZRNSBv8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cuj8Y81T/qYAuypFHd9dBoPNllchuz3isbub2GCvfcoBnDFOf0EebYkpSGS+itYF1AMEbWtSOMU9ohNjgXF0rgrk40mroxiiVDCY2t+OVD7C7AeRkIeBSdfZuMsEkEH5rD7SCEzhN/49J474Q6Jsn7J1U6LX6uOw2B9TyUQqBiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=meQXPkyd; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="meQXPkyd" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-234bfe37cccso6646955ad.0; Wed, 25 Jun 2025 18:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750900708; x=1751505508; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kX1IqpuQILj2KVu3MokWvztdE3IjUipqVBcxbKIWMu4=; b=meQXPkydccxwe4gu0usPbpWaLjUrT/imNOz3NsnPYcQ8lUHkENEHpDX0g88h2SkZaI 3UF06fNXJhK9MTTFQtJD4S34n0ymbpRlXXLa5+aGlm7/N0ijcU4QWQIQReYlYZxxwDhE BmceWFpiwBo57+Q/aELKyuy4rKTIXiW4aaM/bAGup0LQgJ5IhQVJef0K4ymkUfuBirvS YTb9gVmVJ/5H78S1RXjrhHG3HIQA1IZD134/ua6lrVOhvGapsfM1ZCZHiWi91l5Fv8B/ 3aoSmyKeM2ce8MjeEY1olkgKprc1t4e0nW5B1bCj/fOingHuuNIQ21JEwbuyrMGLAjbH D9cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750900708; x=1751505508; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kX1IqpuQILj2KVu3MokWvztdE3IjUipqVBcxbKIWMu4=; b=LRpznXLqiKf8VeZwknxERfT8v66QDKadLxg4MIMIWrkUGew8a5bNlTucXca4U11TVQ Cs8lMsD77r2zRrujW2cqmf+0G7YS+dcoHTY4Ni/VDsLZqmpqRaXoW+EpiJ/FvON6IQiy L9QtdjxN8suPC+AcMoBXmFhS5h6CcPq2OjGJ8CinR0JPqHiWBs8iXcPW76SBsxAz593c u2JTKTbjM5HyGhCgwrWpWD82tYmgoft0qo7N2L90KWJ3CSU4L1IhB6FHILQrleMhIgT5 HLOojPkyi0bg8qIqaXpTwkcMq/l5Hi8YwbPAGZyDUVrvDN3WN9A9Q0OyLjYvsgbHXszd LWFw== X-Forwarded-Encrypted: i=1; AJvYcCUbLWn4tqX/tnfKTKySHIc14DmsNlg5FcqPPfr/1hxvYmWxnSETup6XAkntnRQEHftt7hK29lLUlQMMglw=@vger.kernel.org X-Gm-Message-State: AOJu0YwvK2xnHLkwOD/gPp6w4HJupLz8uxh2gOWcELgF2TduxxJr1WBO 3u6uQVSLkvEpjKWEgtpTFDmZz4CVoB46I27FwKZeKBEoa87A+ZPFQdmg X-Gm-Gg: ASbGncs1hB75eEBk9bi7fYeqjspy/zvb06ckhMo09mbTwQ6kD99gSVYr0tqy2L1wqqA kVipQdnarHQnbsw8pceotnlTw5DtzGiy8gsp04s1xrDEXWc/v0XqdJrxCYu7kpqxANV0MEtJcrp n/lhZsMLlc+chbNRzMQlTWJTgma+HwXu14YCQJl/aikcvgug4yPgNlFLwYUhrNG/md5d/yfL2wu zi7c+bau5r61mHCwPr+s/AvWZRy8AapZKlxFmUv6ykm/8AEKGEbD7hWIRgPfuKM1Eet5LjARjQY I+2ey2nNw3y2H73mjZyTc3xMrOzRvytOKLhLyGvknQfuQED38mhbIuPujr4lQQ== X-Google-Smtp-Source: AGHT+IGi1/B0kQo9zgzcnMps8F+X57XZP9yJayERCHDyZIv7bmiGpRfpTxhYC2d1Lb1SiBXfc3R/PA== X-Received: by 2002:a17:903:1b64:b0:234:8ec1:4af1 with SMTP id d9443c01a7336-23823fb89d7mr77903335ad.0.1750900708472; Wed, 25 Jun 2025 18:18:28 -0700 (PDT) Received: from [192.168.1.26] ([181.88.247.122]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d871f10fsm142710025ad.233.2025.06.25.18.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 18:18:28 -0700 (PDT) From: Kurt Borja Date: Wed, 25 Jun 2025 22:17:37 -0300 Subject: [PATCH 3/3] platform/x86: dell-wmi-sysman: Fix class device unregistration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250625-dest-fix-v1-3-3a0f342312bb@gmail.com> References: <20250625-dest-fix-v1-0-3a0f342312bb@gmail.com> In-Reply-To: <20250625-dest-fix-v1-0-3a0f342312bb@gmail.com> To: Jorge Lopez , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Mark Pearson , Prasanth Ksr , Mario Limonciello , Divya Bharathi Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Kurt Borja X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1434; i=kuurtb@gmail.com; h=from:subject:message-id; bh=+0W0cycMmDqAsq4M7XhomUZQgzncfix1NC75ZRNSBv8=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDBkx86/xlidqNmx5Ysgy63B34Qnznc9juIMeh9nOyFI7O efgHe2+jlIWBjEuBlkxRZb2hEXfHkXlvfU7EHofZg4rE8gQBi5OAZjIJRaGvzIPvTy6D7RJeLoX sEcEiK5YezPp59WKsDVVtrF1sh+Wn2X4H3JDKkXrX9pE99p1uX93NsZfEd/0ct+ivIr9modmbmy 04QQA X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Devices under the firmware_attributes_class do not have unique a dev_t. Therefore, device_unregister() should be used instead of device_destroy(), since the latter may match any device with a given dev_t. Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Managemen= t Driver over WMI for Dell Systems") Signed-off-by: Kurt Borja --- drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/p= latform/x86/dell/dell-wmi-sysman/sysman.c index d00389b860e4ea0655c740c78bc3751f323b6370..e345c62fbb35529fb4903f8c11f= 0fd07d941f94d 100644 --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c @@ -597,7 +597,7 @@ static int __init sysman_init(void) release_attributes_data(); =20 err_destroy_classdev: - device_destroy(&firmware_attributes_class, MKDEV(0, 0)); + device_unregister(wmi_priv.class_dev); =20 err_exit_bios_attr_pass_interface: exit_bios_attr_pass_interface(); @@ -611,7 +611,7 @@ static int __init sysman_init(void) static void __exit sysman_exit(void) { release_attributes_data(); - device_destroy(&firmware_attributes_class, MKDEV(0, 0)); + device_unregister(wmi_priv.class_dev); exit_bios_attr_set_interface(); exit_bios_attr_pass_interface(); } --=20 2.50.0