From nobody Wed Oct 8 19:58:43 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C2882EA145; Tue, 24 Jun 2025 19:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750794277; cv=none; b=gDCOjVqXgcDSfRGZ+nUZXrLlkfx4LyRpMXk4vaYoPuLDkf53Zx4lMKk6CgJ4taxP18j94KvEnMqJX1h18gUbWL0w1k1xXGCBR6WJPYg1JvuKTHLbemZD3Hf3mU8f+QJWPORddnt49Zcp16fFRS59G0pGmr8R/qIUOxrA01SOb3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750794277; c=relaxed/simple; bh=3pFsyry3ogPsPI2M+Srbmm7Hms/oHfolhCZF5ZerzyQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cPZSNJqTtD894NQM7n9zZjrXmrD97Ydj5F8/zMFWDigfPl6HwTAmQel2Q4UtKHJI6yJp/tTDWgIUuc56oDJ7mniE53SNUTCQuixSuyio0sDj2vcFqC+t+5f85OekQnUQmbbXWLgIzB4uiViI+53EZh7+E3m3AOiOHMhCYk/SU74= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=p3AZS7rh; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="p3AZS7rh" Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55OHBjic029946; Tue, 24 Jun 2025 19:44:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=L+xWg Q/9RAPDdeXdahMohh/91ikHv/27/0j3Sa/Uu0U=; b=p3AZS7rho9rTKGflpKuNT NjRwqgUBPbrbvZqKYdSCNaSpDvPR9BRL+iMUGA4QIza/cAu0xhQEc0x8uJoi3TTO 6Z0xKea0vU/B6WFPFg8e54jssn/kFBhB/us290XfYyfvdBtmWG4aziB3vLloHefI krkePVXub/jIyeGu0e0op965hcMHsDH76eX+rMo+6zVw0oHm/2P4JJUwHYWp6IYA eF5sI96YDqJ/xOgrQb6ikjzPrEKeTgiwYiIXDJCE64KbTlcPag1hZx378tMXK4iu KlTwOJCHe0S/V0Jqvl+evqI88lESRn9WztFyzZ2uzE/zIOOttduAKdmcmicJtm54 Q== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47ds8y5xyt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2025 19:44:24 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55OJFAdc024643; Tue, 24 Jun 2025 19:44:23 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47ehkr3huj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2025 19:44:23 +0000 Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 55OJiLcN031379; Tue, 24 Jun 2025 19:44:22 GMT Received: from ca-dev110.us.oracle.com (ca-dev110.us.oracle.com [10.129.136.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 47ehkr3hsx-2; Tue, 24 Jun 2025 19:44:22 +0000 From: Alok Tiwari To: jonathan.cameron@huawei.com, will@kernel.org, mark.rutland@arm.com, linux-cxl@vger.kernel.org Cc: alok.a.tiwari@oracle.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] perf/cxlpmu: Fix devm_kcalloc() argument order in cxl_pmu_probe() Date: Tue, 24 Jun 2025 12:43:38 -0700 Message-ID: <20250624194350.109790-2-alok.a.tiwari@oracle.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250624194350.109790-1-alok.a.tiwari@oracle.com> References: <20250624194350.109790-1-alok.a.tiwari@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-24_06,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506240161 X-Proofpoint-ORIG-GUID: WwzDPj097zbDIdTUO8vgaoJoCcdL-zik X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI0MDE2MSBTYWx0ZWRfXxrlLTDf9HdRS DYtBlN1G4DH9OFH10nBhKuFBOSpZxvArKTarQaRzul1L2zgETlYq1ohdNp8y5bbgwdxhjIfXJtx pJRS7Ag7O2U/TVSSK60BKmyAcjN1Zripwv0Ol7UEivAO8TpyOL0N0aOT0ucs0C37wuwMfTExBYn Ldnut56lvTEygwbbkM9YPiwGXHhzspwC8kBQU0X/Va1bthVlM5gFGK52te6Klpr5qCxm5R84Brh rvecnS0cF1AE15yiackeI23gzccUmjG3b0lFSjqBbU6gEey1rRd6OOQsFfidSiFMwtLatdqATDB u5RYjs7FgP8Ij0yYzb5dYdUnp/NkAqm/KIZNEZmK7AtllXx+Xwi/cu98jJjl7V2WRWgkum5ZJch nijbZJOthefsXZjsox76I1pNwHNc5VjVNb5VMVWw1mFFm21CXXXHVspNBaXAWAIACpWYlqkU X-Proofpoint-GUID: WwzDPj097zbDIdTUO8vgaoJoCcdL-zik X-Authority-Analysis: v=2.4 cv=PqSTbxM3 c=1 sm=1 tr=0 ts=685b0018 b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6IFa9wvqVegA:10 a=yPCof4ZbAAAA:8 a=yaHg9FHjClEfhIwcEPsA:9 cc=ntf awl=host:13207 Content-Type: text/plain; charset="utf-8" The previous code mistakenly swapped the count and size parameters. This fix corrects the argument order in devm_kcalloc() to follow the conventional count, size form, avoiding potential confusion or bugs. Previous usage: devm_kcalloc(dev, sizeof(*info->hw_events), info->num_counters, GFP_KERNEL); New usage: devm_kcalloc(dev, info->num_counters, sizeof(*info->hw_events), GFP_KERNEL); Previous incorrect order could lead to unexpected memory allocation behavior. This fix ensures correct allocation of hw_event structure. Signed-off-by: Alok Tiwari Reviewed-by: Jonathan Cameron --- drivers/perf/cxl_pmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/perf/cxl_pmu.c b/drivers/perf/cxl_pmu.c index d6693519eaee2..8998c0a2f3a2d 100644 --- a/drivers/perf/cxl_pmu.c +++ b/drivers/perf/cxl_pmu.c @@ -834,8 +834,8 @@ static int cxl_pmu_probe(struct device *dev) if (rc) return rc; =20 - info->hw_events =3D devm_kcalloc(dev, sizeof(*info->hw_events), - info->num_counters, GFP_KERNEL); + info->hw_events =3D devm_kcalloc(dev, info->num_counters, + sizeof(*info->hw_events), GFP_KERNEL); if (!info->hw_events) return -ENOMEM; =20 --=20 2.46.0 From nobody Wed Oct 8 19:58:43 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E3D72E9ECB; Tue, 24 Jun 2025 19:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750794276; cv=none; b=giQICA8KtPPApCurL3eNgb1oqlR+IoxzDasxoOIqmGf5YXqTc7KkPvrWhqiBOWGFsKKTR8+ec2oSkKpHZPQpavjp1flHkFFOUMITUjwbhfibv/Oaj7bzw8eSRBDoU7S0Kd+Yx3OG1jhY3lZCy2oVEdDbrF7TaDCD6EAh+BUrTQI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750794276; c=relaxed/simple; bh=IN3wWVe2Hmc/vA1fI2DD1642OUHRN6fgGeZ4GithXTY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=brsRI4rEJo1eOHReQTGPVd5iUQRpGzBRmr5KFJM6D/EHIE4rCtQ7vzkNPyyLeD0nM4RSC8wSRpoYqRLRu2rhb+ptKd9L6rHXH6SmhFxn8Nlfd66xtd2PmbhZwuJDDSg6HXkA+HtAGC+l0hr6vF2tOBrD1cXYczMqJsXmjrgX4x0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=GYoEp7+X; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="GYoEp7+X" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55OHBbgO000471; Tue, 24 Jun 2025 19:44:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=rSQSn qeu99rtGwswH/49UwEvNR5Ue855Zlm0k6zy62k=; b=GYoEp7+Xoi2Mzvn/2Gufh bViIhH8fj7ibVPdMb6oRkzXPZVbMPzTMkYefd7TaI/zAiMb5FtNR/DpzAyKM1ZhB /1WL9T6F23FZMKAYSoB9VwJ/MqQh/hsgRIkk9VdyQn0A6vnxS5LbQ6SFRZUf4VB7 xAoQKjrChtzrQd80X/PkHJzPdZD8HhnovFt0i8vlnY9xysA7rSB43nzNgdJuLfrW row0zcRuyEsDoTrypPI9osfDYZ2jR/dRnW8LilIy2V7K4MEtwsrWyfxgt0YFNHTJ BFQmbmOvsHwPwjhTCLGVqJlxJY2I+YhUOeFqmPJ6FTdu3mml6/VB48ZpBelMdNe4 g== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47egt5mv9y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2025 19:44:25 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55OJL0QB024130; Tue, 24 Jun 2025 19:44:24 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47ehkr3hux-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2025 19:44:24 +0000 Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 55OJiLcP031379; Tue, 24 Jun 2025 19:44:23 GMT Received: from ca-dev110.us.oracle.com (ca-dev110.us.oracle.com [10.129.136.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 47ehkr3hsx-3; Tue, 24 Jun 2025 19:44:23 +0000 From: Alok Tiwari To: jonathan.cameron@huawei.com, will@kernel.org, mark.rutland@arm.com, linux-cxl@vger.kernel.org Cc: alok.a.tiwari@oracle.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] perf/cxlpmu: Remove unintended newline from IRQ name format string Date: Tue, 24 Jun 2025 12:43:39 -0700 Message-ID: <20250624194350.109790-3-alok.a.tiwari@oracle.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250624194350.109790-1-alok.a.tiwari@oracle.com> References: <20250624194350.109790-1-alok.a.tiwari@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-24_06,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506240161 X-Proofpoint-GUID: r9lWqjKSoLzLxSWK6Kd40sKVpCDsTu0Z X-Authority-Analysis: v=2.4 cv=PMYP+eqC c=1 sm=1 tr=0 ts=685b0019 b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6IFa9wvqVegA:10 a=yPCof4ZbAAAA:8 a=CPhUkEKbwItqaMuKtVMA:9 cc=ntf awl=host:13207 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI0MDE2MSBTYWx0ZWRfXxzYD+jXRRTna UN/jOhYHlKpcDRDJeRAQ+GG6VVRhs8BH6vFOt8NJE/e0J0IRWtUAXsXAzbTza5gWKkGQg1FpTP2 FPjd2yaBjyCc/FpVwUo5EiONJa8hS2mjB3p5yq523oM7YAMW24z3AHPoQxt4WLQ3VhrhZz6YXww HMUaPCcggE+ZIKH+E0De+pS4qUey8N1PQ5L9Jf9appCAlYEcmmGeyn8F3Na3xRjW+K6/3RqMOqP y2a7GaMXnEFGNIjiUl4ftZwwfUYSS6LHQwNnKtBYcpljyEOO59+xo7O92HdEOV99EhtL8/YH+Ev iCK4gp6nVIryPvcYGn2y+BxkYCtOB6UR1HpYuSN5yLPQtLOZ1EM0b+onR/9qGusAJhne54bWZd5 vPo/aHvWozvpsvWNi5y9jfSuJ8VM16MTlpWFK34CydWUss6auNTD2s5SUUZsaBFF7kVp4gTo X-Proofpoint-ORIG-GUID: r9lWqjKSoLzLxSWK6Kd40sKVpCDsTu0Z Content-Type: text/plain; charset="utf-8" The IRQ name format string used in devm_kasprintf() mistakenly included a newline character "\n". This could lead to confusing log output or misformatted names in sysfs or debug messages. This fix removes the newline to ensure proper IRQ naming. Signed-off-by: Alok Tiwari Reviewed-by: Jonathan Cameron --- drivers/perf/cxl_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/perf/cxl_pmu.c b/drivers/perf/cxl_pmu.c index 8998c0a2f3a2d..5a475a5a1f095 100644 --- a/drivers/perf/cxl_pmu.c +++ b/drivers/perf/cxl_pmu.c @@ -873,7 +873,7 @@ static int cxl_pmu_probe(struct device *dev) return rc; irq =3D rc; =20 - irq_name =3D devm_kasprintf(dev, GFP_KERNEL, "%s_overflow\n", dev_name); + irq_name =3D devm_kasprintf(dev, GFP_KERNEL, "%s_overflow", dev_name); if (!irq_name) return -ENOMEM; =20 --=20 2.46.0 From nobody Wed Oct 8 19:58:43 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E4602E9ED8; Tue, 24 Jun 2025 19:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750794276; cv=none; b=NWwIbt7j1PicbchUB5Tgry8+ip8he0Fkg9MM/hUBZx+fHMv626npy40+7fhKSGtnnqKjsXuYTmMWCz6yeZsaTPgiVTAQp2q7hx4n7EIOb5cnEmwLLi8ZiGJjbrkhmf8s5fhwQhRGQBPlivQx6HWfBk5NCicQKFzsRRG3LwrPRYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750794276; c=relaxed/simple; bh=sBd4i6NfN8Nagy/LxcY8zqS/alXR3Z8Cwab51tRWFQc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N3y2lkdmd6GKFEhRWdjXpTkvFhjghBaMmhHK+bGkrjhtX4OueI4xbFvJ/pG2NEwiR+ycnRUn1p1N6gIJ4aoCBDQrkYdmS9jwlwXjSJ27oUP0l7mzdX8jmQsEaQ+BcX1GqEaKKYTKUwUrpPzIsjlPVKa3ucjkn65J9JpdFbKeeS8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=BQgN2+Od; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="BQgN2+Od" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55OHBaLo006329; Tue, 24 Jun 2025 19:44:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=2heMm h50U9/9fd3I2Fq191i4cQ9bhdmCrjgCm4fMKSY=; b=BQgN2+Od7YJocacBGlCV5 pDROzy4ncWc8lg8zUtT1X/ByT0soj7j8Il5MAlMgiYfKj0T05/pQxSMPyM8M29+g X57xGrqGHBDaJPHTJFOLbsyrxpmyGIGlZlqcaGlJBrPU4zdigh611+CL+PoACpdi nugIwSwMzSdXl8dgh8kw+iPvqpAvd86YvnuJ0er5CAMQNj0AuUn3GQNLKUPEwvAN vGMOvUTXemsMTndDIQqFvQiT3Ct8P9y9CImQtkq2utwDrr0SrAhPfq/68GDqlriv RWTzQLvNtBy9RPZSf22se0QuK5IQsagVtAxHs37D3aNIhGry+ldnU5jPdMzb/lDA A== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47egummwph-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2025 19:44:25 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55OJR0Of024157; Tue, 24 Jun 2025 19:44:25 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47ehkr3hvd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2025 19:44:25 +0000 Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 55OJiLcR031379; Tue, 24 Jun 2025 19:44:24 GMT Received: from ca-dev110.us.oracle.com (ca-dev110.us.oracle.com [10.129.136.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 47ehkr3hsx-4; Tue, 24 Jun 2025 19:44:24 +0000 From: Alok Tiwari To: jonathan.cameron@huawei.com, will@kernel.org, mark.rutland@arm.com, linux-cxl@vger.kernel.org Cc: alok.a.tiwari@oracle.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] perf/cxlpmu: Fix typos in cxl_pmu.c comments and documentation Date: Tue, 24 Jun 2025 12:43:40 -0700 Message-ID: <20250624194350.109790-4-alok.a.tiwari@oracle.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250624194350.109790-1-alok.a.tiwari@oracle.com> References: <20250624194350.109790-1-alok.a.tiwari@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-24_06,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506240161 X-Proofpoint-ORIG-GUID: DOBrEKH3SOuxSu46q0fPrpr0OyoWn6KR X-Proofpoint-GUID: DOBrEKH3SOuxSu46q0fPrpr0OyoWn6KR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI0MDE2MSBTYWx0ZWRfX33tc4A+wJXL5 nAxh1wvPccoTEx1KoWwfDLpmd5FmdoaNX1QW6XvZ/YQG1sqnAPeS5ykaDvufGoN5DggVYUbdMTW bkHyLRc+qVEdUXn4NsX6/pUJA9ucA0rMOXJ+XgSgqk7gJbLKu1zoZyPAPfHC6v7etXx14Z33K7e ohEfYjUUI9hSWn8X/C/kcCGcLjo2ddc2EMVK0Fvpceoxv8HSq4P+QA2U8EBwbnHneZOW9xAvqs5 NE6of3+uSfTipWv+CMUJewctb22jzuYn5y94mSiahPP/6BO9KuSRhIaE21TSJScCBGRvOMUCsUf G1x09zfe28srODGyqtvaKwV5IHbKQepPbX43OKh+dbZO5+q7emcEKpJU0jsp/rnlUBrQ7NMBnyD GLTisXQ8/6Tn++qWBqfnc9K0g1dKJpSXCHhmEFKePHTt1mmHZnqJ0iryvHFWzHYFzuKho0D9 X-Authority-Analysis: v=2.4 cv=S5rZwJsP c=1 sm=1 tr=0 ts=685b0019 b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6IFa9wvqVegA:10 a=yPCof4ZbAAAA:8 a=SMJxHL9mSaAU-aCgd-cA:9 cc=ntf awl=host:13207 Content-Type: text/plain; charset="utf-8" Fix several minor typo errors in comments: - Remove duplicated word "a" in "a a VID / GroupID". - Correct "Opcopdes" to "Opcodes" in CXL spec reference. - Fix spelling of "implemnted" to "implemented". Improves code readability and documentation consistency. Signed-off-by: Alok Tiwari Reviewed-by: Jonathan Cameron --- drivers/perf/cxl_pmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/perf/cxl_pmu.c b/drivers/perf/cxl_pmu.c index 5a475a5a1f095..d094030220bf2 100644 --- a/drivers/perf/cxl_pmu.c +++ b/drivers/perf/cxl_pmu.c @@ -113,7 +113,7 @@ struct cxl_pmu_info { =20 /* * All CPMU counters are discoverable via the Event Capabilities Registers. - * Each Event Capability register contains a a VID / GroupID. + * Each Event Capability register contains a VID / GroupID. * A counter may then count any combination (by summing) of events in * that group which are in the Supported Events Bitmask. * However, there are some complexities to the scheme. @@ -406,7 +406,7 @@ static struct attribute *cxl_pmu_event_attrs[] =3D { CXL_PMU_EVENT_CXL_ATTR(s2m_bisnp_curblk, CXL_PMU_GID_S2M_BISNP, BIT(4)), CXL_PMU_EVENT_CXL_ATTR(s2m_bisnp_datblk, CXL_PMU_GID_S2M_BISNP, BIT(5)), CXL_PMU_EVENT_CXL_ATTR(s2m_bisnp_invblk, CXL_PMU_GID_S2M_BISNP, BIT(6)), - /* CXL rev 3.1 Table 3-50 S2M NDR Opcopdes */ + /* CXL rev 3.1 Table 3-50 S2M NDR Opcodes */ CXL_PMU_EVENT_CXL_ATTR(s2m_ndr_cmp, CXL_PMU_GID_S2M_NDR, BIT(0)), CXL_PMU_EVENT_CXL_ATTR(s2m_ndr_cmps, CXL_PMU_GID_S2M_NDR, BIT(1)), CXL_PMU_EVENT_CXL_ATTR(s2m_ndr_cmpe, CXL_PMU_GID_S2M_NDR, BIT(2)), @@ -627,7 +627,7 @@ static void cxl_pmu_event_start(struct perf_event *even= t, int flags) hwc->state =3D 0; =20 /* - * Currently only hdm filter control is implemnted, this code will + * Currently only hdm filter control is implemented, this code will * want generalizing when more filters are added. */ if (info->filter_hdm) { --=20 2.46.0