From nobody Wed Oct 8 22:37:18 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10CC52EA74B; Tue, 24 Jun 2025 15:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750777713; cv=none; b=ZoFfLdP6dUig/wjWEamlT+WLvok8XzsAl4XQrinvt8GybmRmx7IBmh5vwEEhKtv/lese4x0aQ1FbzQA1iLn4v2gvRflhynMmXrxHjRQZmJ6d4ZxgoqNjtsrzeLqs3wLd2LZSW08rntBRj3MCk+WCp8C67xSK3rZyeJD1wlbqNDk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750777713; c=relaxed/simple; bh=JOVIgeyXUscWiujQ8Da71WDqvgkxsjYjFJncsY2bfic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O0I8Yo/znqqvSGlRQaUij87IKwmw669GmhcyqinkuOBR2D5QhhS+KsRk6RfC2b8wQgQhqNLUc1lPm9tzOHcGMM3NhWDSatRyYvu+HH9BHBtWUpi6fp3Yu/oAxvkrt3AZXvpCFtsKQEuLr5M5H2TZls4+4eTQwrR/DOiJ9av6v1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iRdhVVm5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iRdhVVm5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF8A1C4CEE3; Tue, 24 Jun 2025 15:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750777712; bh=JOVIgeyXUscWiujQ8Da71WDqvgkxsjYjFJncsY2bfic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iRdhVVm5Z1MGsfPnys8RTIq0M61TcVP++p3LwZwSnQ+Yf+5WxvumkerWMHDKBN0gm mrekRrh3xp9t+hrzE0eGvI2Dbh6k+MCXUcHf7EsJc9fDivd0+suAKdUxk8HopthqtC TTq8uZB8dZzOqsYJg05yFUKDj9/Dw/HJzsEiU0II8orOSqpbgEox4CiGKm7hq6Hsqr biyUyUEXzP12cvLH5gSH3e4qaAocgSQPgv6JowRz7SAGtWW/zlTaXfjK8rAI5yTSvz JeoFCmkDK/AqXA06WQRn0i9SNhV9XMKcETOzcLAbMIB4EdaTwyRMTa9va1LV00vITP Ys1Y0DoMeMgag== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 37/66] kconfig: gconf: use GtkFileChooser in on_save_as1_activate() Date: Wed, 25 Jun 2025 00:05:25 +0900 Message-ID: <20250624150645.1107002-38-masahiroy@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250624150645.1107002-1-masahiroy@kernel.org> References: <20250624150645.1107002-1-masahiroy@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" gtk_file_selection_new() is deprecated, and gtk_file_chooser_dialog_new() should be used instead. [1] [1]: https://gitlab.gnome.org/GNOME/gtk/-/blob/2.24.33/docs/reference/gtk/t= mpl/gtkfilesel.sgml?ref_type=3Dtags#L156 Signed-off-by: Masahiro Yamada Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- scripts/kconfig/gconf.c | 56 ++++++++++++++++++++--------------------- 1 file changed, 27 insertions(+), 29 deletions(-) diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c index f33f39d50f3d..b019711142c3 100644 --- a/scripts/kconfig/gconf.c +++ b/scripts/kconfig/gconf.c @@ -198,38 +198,36 @@ static void on_save_activate(GtkMenuItem *menuitem, g= pointer user_data) conf_write_autoconf(0); } =20 - -static void -store_filename(GtkFileSelection * file_selector, gpointer user_data) -{ - const gchar *fn; - - fn =3D gtk_file_selection_get_filename(GTK_FILE_SELECTION - (user_data)); - - if (conf_write(fn)) - text_insert_msg("Error", "Unable to save configuration !"); - - gtk_widget_destroy(GTK_WIDGET(user_data)); -} - static void on_save_as1_activate(GtkMenuItem *menuitem, gpointer user_data) { - GtkWidget *fs; + GtkWidget *dialog; + GtkFileChooser *chooser; + gint res; =20 - fs =3D gtk_file_selection_new("Save file as..."); - g_signal_connect(GTK_OBJECT(GTK_FILE_SELECTION(fs)->ok_button), - "clicked", - G_CALLBACK(store_filename), (gpointer) fs); - g_signal_connect_swapped(GTK_OBJECT - (GTK_FILE_SELECTION(fs)->ok_button), - "clicked", G_CALLBACK(gtk_widget_destroy), - (gpointer) fs); - g_signal_connect_swapped(GTK_OBJECT - (GTK_FILE_SELECTION(fs)->cancel_button), - "clicked", G_CALLBACK(gtk_widget_destroy), - (gpointer) fs); - gtk_widget_show(fs); + dialog =3D gtk_file_chooser_dialog_new("Save file as...", + GTK_WINDOW(user_data), + GTK_FILE_CHOOSER_ACTION_SAVE, + "_Cancel", GTK_RESPONSE_CANCEL, + "_Save", GTK_RESPONSE_ACCEPT, + NULL); + + chooser =3D GTK_FILE_CHOOSER(dialog); + gtk_file_chooser_set_filename(chooser, conf_get_configname()); + + res =3D gtk_dialog_run(GTK_DIALOG(dialog)); + if (res =3D=3D GTK_RESPONSE_ACCEPT) { + char *filename; + + filename =3D gtk_file_chooser_get_filename(chooser); + + if (conf_write(filename)) + text_insert_msg("Error", + "Unable to save configuration !"); + + g_free(filename); + } + + gtk_widget_destroy(dialog); } =20 static void on_show_name1_activate(GtkMenuItem *menuitem, gpointer user_da= ta) --=20 2.43.0