From nobody Wed Oct 8 22:37:19 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 323C12D3A80; Tue, 24 Jun 2025 15:07:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750777679; cv=none; b=QnPKdBVcDzuKtRTFVhmf3wniVJorn0wsiz5aT+G5z3Q7Fr/5wWw9StgFRNyfLXLMHvnzhrFXz0qHFWvjdsEvzQrPv3z0nnaDk+NbpCjfPZw7VriCQzrsxHi5OuuMbMmjuGqTQ43zkrleVTv5BNJdEqdVVHl/qWBzfMEXyeaJXD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750777679; c=relaxed/simple; bh=7R9zLWVFiLd9C1meIr0Aq65EzG0bbG2WnzXi/9AlQKY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gu7/MRXRp8prJhz4c48/90yt8Kd5hOQB36zMB6AB/W5pErXHvK+RwMVwZbUIkLHOK2usRXQuGT+CVhhZGTiFXrx3e3/ilQ0WFchCi5AmqeDxmI5s5SNAdSg05P7bpu0Tkk0jV30oJBdL7F6aWDkyR8XcwSptqQ4YFMYE+KN2xpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ReshN+DS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ReshN+DS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DB60C4CEF3; Tue, 24 Jun 2025 15:07:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750777678; bh=7R9zLWVFiLd9C1meIr0Aq65EzG0bbG2WnzXi/9AlQKY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ReshN+DSDx1NCSu9XGW9wu59RACEShcoTShMju3VFSQtgQZp93OkT4SmflzD5WXiw f5hx/HhMnNygiGLA/i3DZbzp9ltE96yr2jpBb9rvM9OB6B04KSbUP2JyFc3Mvmv6um M2beU0MFem3BoInFsRwheIBtUjQJJJBGQO1xzmVJAWx476aj8Nj1UqQYDe5EmqhtBV IJuhtWSSG6IY5uM9+jp4ZD0U53+apImX9fvkvfGrQ03rXuElly0eag038m3E0gl5pK iTm9AKK7jEEmSGk2apTD06iORGYD2JvZUvBu2wrW3yG3oB+pe8YIhxd68cEh2o3BuL BGYw2Z1fvaH4w== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 21/66] kconfig: gconf: remove unneeded variables in on_treeview*_button_press_event() Date: Wed, 25 Jun 2025 00:05:09 +0900 Message-ID: <20250624150645.1107002-22-masahiroy@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250624150645.1107002-1-masahiroy@kernel.org> References: <20250624150645.1107002-1-masahiroy@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" No all position parameters are used here. Passing NULL to gtk_tree_view_get_cursor() or gtk_tree_view_get_path_at_pos() is allowed. [1] [2] [1]: https://gitlab.gnome.org/GNOME/gtk/-/blob/2.24.33/gtk/gtktreeview.c#L1= 2638 [1]: https://gitlab.gnome.org/GNOME/gtk/-/blob/2.24.33/gtk/gtktreeview.c#L1= 2795 Signed-off-by: Masahiro Yamada --- scripts/kconfig/gconf.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c index c78eded5c01b..ab2e0df21037 100644 --- a/scripts/kconfig/gconf.c +++ b/scripts/kconfig/gconf.c @@ -822,13 +822,10 @@ on_treeview2_button_press_event(GtkWidget * widget, GtkTreeIter iter; struct menu *menu; gint col; - gint tx =3D (gint) event->x; gint ty =3D (gint) event->y; - gint cx, cy; =20 - gtk_tree_view_get_path_at_pos(view, tx, ty, &path, &column, &cx, - &cy); + gtk_tree_view_get_path_at_pos(view, tx, ty, &path, &column, NULL, NULL); if (path =3D=3D NULL) return FALSE; =20 @@ -871,12 +868,11 @@ on_treeview2_key_press_event(GtkWidget * widget, { GtkTreeView *view =3D GTK_TREE_VIEW(widget); GtkTreePath *path; - GtkTreeViewColumn *column; GtkTreeIter iter; struct menu *menu; gint col; =20 - gtk_tree_view_get_cursor(view, &path, &column); + gtk_tree_view_get_cursor(view, &path, NULL); if (path =3D=3D NULL) return FALSE; =20 @@ -930,16 +926,12 @@ on_treeview1_button_press_event(GtkWidget * widget, { GtkTreeView *view =3D GTK_TREE_VIEW(widget); GtkTreePath *path; - GtkTreeViewColumn *column; GtkTreeIter iter; struct menu *menu; - gint tx =3D (gint) event->x; gint ty =3D (gint) event->y; - gint cx, cy; =20 - gtk_tree_view_get_path_at_pos(view, tx, ty, &path, &column, &cx, - &cy); + gtk_tree_view_get_path_at_pos(view, tx, ty, &path, NULL, NULL, NULL); if (path =3D=3D NULL) return FALSE; =20 --=20 2.43.0