From nobody Wed Oct 8 20:53:21 2025 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81EC3288536 for ; Tue, 24 Jun 2025 11:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750763410; cv=none; b=skttisurmJwkbTzY4dizRVxg0t2JsE0RHLDZJIJ426cuQzmIEGhpQfS0eXHWMoAsjMp7v19vBAb0CiQx99XkyeMyHnPdBDhwrEUt7RMZy71YYnI2NaZlDNG8YVBVfOvNX/VhP00+l4MamrvLZ4u9zfUM4vxVnA/U5GJaRf66/5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750763410; c=relaxed/simple; bh=z4rJtnFF30lqR3jrDEtJ16ql7i973YYLkV6fm+6rt/Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RpTeHg4ipkVIZ+9/ZZ4WMLXvRWHOJwEW+YZNsZymimBmKhpgZEU38M1+QTBi66vkJI2sQIbrmg1YS/UdpubMVeOQgHdpKbhGFJPSmtf8/5QoU5vAiYQ0OYYthMNe7vFQtyW49h/xp6+kINBDvvDk5MSw0+Bum50nYk1jV6FeC2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ITI77JqV; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ITI77JqV" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-551efd86048so289379e87.3 for ; Tue, 24 Jun 2025 04:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750763407; x=1751368207; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5t54NOu9eJMfewpsFMkasSGMJUYUFumjVVb6dnB5QGU=; b=ITI77JqV+600vjMciOQiN59nbadMg1SrrkoLGwbKaTEuxwVDMEXD0X0NlnUAOPsr6F ccsJtIN0ECT50kl+PaypIgQKKLfIk8oX2DGXOuFZxnqwdL5kBSXS+rXl4UN5bkOK8qtu P3z+DmpWA+1PMdG+eEocV1oBGAZn0BOv64NcbBmgtFil8Xb0EMaWKy0JMuECzlcZvvxA xvxrFhRfR+srfDnTxWSOogsTDswMJP8Y3jcgYD/c2ppUh/teMi+k7lgdCZFyZafPyaty yGuVy062N4d1mmlPPL8x1dIk5USMdk47eZHnJJygOfigJ6lpfuKowdjtvCT3wRx555S2 lp8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750763407; x=1751368207; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5t54NOu9eJMfewpsFMkasSGMJUYUFumjVVb6dnB5QGU=; b=Lreqsf1r45ulvMvwf7N0KJjqoA0yxv2gPPeibrzizTlOBh6OkOmygsjujzzxnMGFEZ eveayRLgOhLhqvTCp+PMeRuQx1PBjZIK1M0lKUQwFgqrNF40DlTeTQW9Mag+TfdxWnnC tjZvd3YJuFveWsC9WvezV1Y6Hy2nhGlLxmFrsDSt2xndCWpe5zOUHiDlX+kVFJhmMH1u ltl1C9/UYPuDNnMgutbzdOB0/VEmM2EXgXND7dxnqjBL02ohippuURcWXwopNpzFo+gN EkTYH/d5EU51qqH93oLp6ovcr3iXlBh7HbPB+DJWOdl/KFECYpE8wyejqv5qtMuZe12J 4T2g== X-Gm-Message-State: AOJu0Yx7FIAZ02Zhin29iiT6MhHnsvuKiebQHjd4s2xknFBUHL6pjDT0 GGD3rcUS9oztF9VoJbAwAVLNVUvx914l5BNJPUVMAwTTF+72zZhoL7esegQmZA4NM/g= X-Gm-Gg: ASbGncul8M1Fx30MBdXqjqgRYSncpBqefWpHEAhGnA6qRCcO6NBJ++GQRa7ICMiWs6p VbB1G1tqLIJgSpClcA4H3be0yvfi0AbrzBOSea4EXILoDFI+H37U0FS9muQAg2BbGDgRN2Tctk6 9ruigRliDBw5egvSEWGNSHY9Wb3E6JYV4YdkVZDKfVCxoVHolh7O3isADriRPsouYU0aLt5/xEA YRCjxEV4hxUwrMJqWMd2FLKwW5663rPePUpAPEHDgk7CmuHY9MHwwmgifezz5N2PwgZcCpeCqeA 29Vkvh5CKpaWnY5dHJyQVEEvsu+YZBQkgipnW+qwnNKm2F68WkRKojuTFR/fX1b97k1nmLZq28F Zn8/DMQE27bgTlLdFVnF5MVEgYkAr1UkD4PZo X-Google-Smtp-Source: AGHT+IENbLN83OkH03hyG1yobNT45Foc2hr2LQyAWmtZ5swCAZoTpbyCfwqy+Q3f5C109deHitMiZA== X-Received: by 2002:a05:6512:3e04:b0:553:30fc:cee4 with SMTP id 2adb3069b0e04-553e3d1d8bfmr4582281e87.49.1750763406612; Tue, 24 Jun 2025 04:10:06 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553e41bbd9dsm1791204e87.105.2025.06.24.04.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 04:10:05 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: linux-kernel@vger.kernel.org, Erick Shepherd , stable@vger.kernel.org, Adrian Hunter , Jonathan Liu , Salvatore Bonaccorso Subject: [PATCH] Revert "mmc: sdhci: Disable SD card clock before changing parameters" Date: Tue, 24 Jun 2025 13:09:32 +0200 Message-ID: <20250624110932.176925-1-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It has turned out the trying to strictly conform to the SDHCI specification is causing problems. Let's revert and start over. This reverts commit fb3bbc46c94f261b6156ee863c1b06c84cf157dc. Cc: Erick Shepherd Cc: stable@vger.kernel.org Fixes: fb3bbc46c94f ("mmc: sdhci: Disable SD card clock before changing par= ameters") Suggested-by: Adrian Hunter Reported-by: Jonathan Liu Reported-by: Salvatore Bonaccorso Closes: https://bugs.debian.org/1108065 Signed-off-by: Ulf Hansson Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 4c6c2cc93c41..3a17821efa5c 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2065,15 +2065,10 @@ void sdhci_set_clock(struct sdhci_host *host, unsig= ned int clock) =20 host->mmc->actual_clock =3D 0; =20 - clk =3D sdhci_readw(host, SDHCI_CLOCK_CONTROL); - if (clk & SDHCI_CLOCK_CARD_EN) - sdhci_writew(host, clk & ~SDHCI_CLOCK_CARD_EN, - SDHCI_CLOCK_CONTROL); + sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL); =20 - if (clock =3D=3D 0) { - sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL); + if (clock =3D=3D 0) return; - } =20 clk =3D sdhci_calc_clk(host, clock, &host->mmc->actual_clock); sdhci_enable_clk(host, clk); --=20 2.43.0